Uh oh!
There was an error while loading. Please reload this page.
feat(server-utils): Migrate OpenAI integration to orchestrion - #21877
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
nicohrubecforce-pushed
the
nh/openai-orchestrion
branch
from
July 1, 2026 09:29
b53ebd6 to
8149b88CompareContributor
size-limit report 📦
|
nicohrubecforce-pushed
the
nh/openai-orchestrion
branch
2 times, most recently
from
July 1, 2026 10:15
e03ecce to
856774bCompareUh oh!
There was an error while loading. Please reload this page.
nicohrubecforce-pushed
the
nh/openai-orchestrion
branch
5 times, most recently
from
July 1, 2026 11:14
127e3b2 to
c9ec0e1CompareThere was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9ca6a54. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
nicohrubec
marked this pull request as ready for review
July 1, 2026 16:42
nicohrubec
requested review from
JPeer264, andreiborza and mydea
and removed request for
a teamJuly 1, 2026 16:42
Uh oh!
There was an error while loading. Please reload this page.
JPeer264
approved these changes
Jul 2, 2026
| @@ -0,0 +1,18 @@ | |||
| import * as Sentry from '@sentry/node'; | |||
Member
There was a problem hiding this comment.
l: I think these tests can be removed after #21911 has been rebased?
nicohrubecforce-pushed
the
nh/openai-orchestrion
branch
from
July 2, 2026 14:47
30a9558 to
db3e09bCompareAdds the orchestrion diagnostics-channel OpenAI integration (chat, responses, embeddings, conversations) and registers it in the channelIntegrations map. Skips span creation when a higher-level provider (e.g. langchain) already instruments the SDK to avoid double spans. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nicohrubecforce-pushed
the
nh/openai-orchestrion
branch
from
July 2, 2026 16:15
db3e09b to
62e81c0CompareUh oh!
There was an error while loading. Please reload this page.
logaretm
reviewed
Jul 3, 2026
Uh oh!
There was an error while loading. Please reload this page.
# Conflicts: # packages/server-utils/src/orchestrion/index.ts
… integration Let errors bubble to the global handlers instead of capturing them as unhandled at the instrumentation level, matching the DB/cache channel subscribers. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
49 tasks
lux-in-tenebris-lucet pushed a commit
to lux-in-tenebris-lucet/sentry-javascript
that referenced
this pull request
Aug 8, 2026
… instrumentation level The exported instrumentOpenAiClient, instrumentAnthropicAiClient and instrumentGoogleGenAIClient wrappers captured provider errors with mechanism.handled = false and then rethrew, so the SDK classified the error as an unhandled crash before the application's retry or fallback logic ran. A call that succeeded on retry still produced an unhandled event, and each retry produced another one. Applies the convention established for the channel-based OpenAI integration in getsentry#21877 to the manual client instrumentation, which is the only available path on the edge and serverless runtimes. Error span status and the original error identity are unchanged. The anthropic suite asserted this divergence directly, expecting the model-error event only while orchestrion was disabled. Both paths agree now, so that branch and its expectation are gone. Captures are kept where a provider reports an error as data on an otherwise successful call, since the caller never sees those as a thrown error. The AI integration suites no longer mask these events with .ignore('event'), so they fail if the capture returns. Dropping the capture also left the .catch() in createWithResponseWrapper rethrowing into a promise nothing observes, which is not a handler at all: awaiting the two promises in sequence orphans the second whenever the first rejects. They are awaited together now. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
lux-in-tenebris-lucet pushed a commit
to lux-in-tenebris-lucet/sentry-javascript
that referenced
this pull request
Aug 13, 2026
… instrumentation level The exported instrumentOpenAiClient, instrumentAnthropicAiClient and instrumentGoogleGenAIClient wrappers captured provider errors with mechanism.handled = false and then rethrew, so the SDK classified the error as an unhandled crash before the application's retry or fallback logic ran. A call that succeeded on retry still produced an unhandled event, and each retry produced another one. Applies the convention established for the channel-based OpenAI integration in getsentry#21877 to the manual client instrumentation, which is the only available path on the edge and serverless runtimes. Error span status and the original error identity are unchanged. The anthropic suite asserted this divergence directly, expecting the model-error event only while orchestrion was disabled. Both paths agree now, so that branch and its expectation are gone. Captures are kept where a provider reports an error as data on an otherwise successful call, since the caller never sees those as a thrown error. The AI integration suites no longer mask these events with .ignore('event'), so they fail if the capture returns. Dropping the capture also left the .catch() in createWithResponseWrapper rethrowing into a promise nothing observes, which is not a handler at all: awaiting the two promises in sequence orphans the second whenever the first rejects. They are awaited together now. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an orchestrion based OpenAI integration to server-utils, covering all the APIs and both streaming and non-streaming mode. Leaves the core integration intact and only exports the necessary utils that are needed for the orchestrion integration.
Closes#20912