Uh oh!
There was an error while loading. Please reload this page.
feat(server-utils): Migrate @opentelemetry/instrumentation-kafkajs to orchestrion - #21923
Merged
Conversation
chargomeforce-pushed
the
cg-orchestrion-kafka
branch
from
July 7, 2026 09:44
d1aab2f to
e3762fcCompareContributor
size-limit report 📦
|
chargome
commented
Jul 7, 2026
MemberAuthor
bugbot run |
Uh oh!
There was an error while loading. Please reload this page.
chargome
commented
Jul 7, 2026
MemberAuthor
bugbot run |
Uh oh!
There was an error while loading. Please reload this page.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
chargomeforce-pushed
the
cg-orchestrion-kafka
branch
from
July 9, 2026 09:59
9f0d1d4 to
59a222eComparechargome
commented
Jul 9, 2026
MemberAuthor
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 59a222e. Configure here.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
chargomeforce-pushed
the
cg-orchestrion-kafka
branch
from
July 9, 2026 12:05
59a222e to
58919daComparechargome
marked this pull request as ready for review
July 9, 2026 12:59
chargome
requested review from
JPeer264, andreiborza, isaacs, mydea and nicohrubec
and removed request for
a teamJuly 9, 2026 12:59
andreiborza
approved these changes
Jul 9, 2026
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
# Conflicts: # dev-packages/node-integration-tests/suites/tracing/kafkajs/test.ts
mydea added a commit
that referenced
this pull request
Jul 15, 2026
…o orchestrion (#22229) Rewrites the `mysql2` instrumentation from an OpenTelemetry `InstrumentationBase` patcher to a `node:diagnostics_channel` listener, with orchestrion injecting the channel into the instrumented module ..(#21923) migrations. - The orchestrion config covers both mysql2 file layouts (`Connection` in `lib/connection.js` for `< 3.11.5`; `BaseConnection` in `lib/base/connection.js` for `>= 3.11.5`). Fixes#20763 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
49 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sendBatch(producer) andrun(consumer) inkafkajsv2; bothproducer.sendandsendBatchroute through the singlesendBatchchannel, and the consumer'seachMessage/eachBatchcallbacks are swapped for span-creating wrappers. Spans now match the OTel integration (except for origin).transactionspan is not emitted — the transformer can't replacetransaction()'s return value to patch commit/abort. Transactional sends still produce producer spans, since they route through the same instrumentedsendBatch.closes#20756