Skip to content

ref(node): Refactor orchestrion config into separate files - #21957

Merged
mydea merged 2 commits into
developfrom
fn/orchestrion-config-per-file
Jul 6, 2026
Merged

ref(node): Refactor orchestrion config into separate files#21957
mydea merged 2 commits into
developfrom
fn/orchestrion-config-per-file

Conversation

@mydea

@mydeamydea commented Jul 3, 2026

Copy link
Copy Markdown
Member

This PR just splits up the orchestrion config for instrumentation into a file per instrumentation, making it a bit cleaner and easier to follow.

This is on top of #21658

@mydeamydea self-assigned this Jul 3, 2026
Base automatically changed from fn/try-orchestrion to developJuly 3, 2026 12:54
@mydea
mydeaforce-pushed the fn/orchestrion-config-per-file branch from 1551956 to 4693d6cCompareJuly 3, 2026 13:02
@mydea
mydea marked this pull request as ready for review July 3, 2026 13:03
@mydea
mydea requested a review from a team as a code ownerJuly 3, 2026 13:03
@mydea
mydea requested review from JPeer264 and andreiborza and removed request for a teamJuly 3, 2026 13:03
@mydea
mydeaforce-pushed the fn/orchestrion-config-per-file branch from 4693d6c to 3adefafCompareJuly 3, 2026 13:09
cursor[bot]
cursorBot reviewed Jul 3, 2026
View reviewed changes

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 3adefaf. Configure here.

Comment threadpackages/server-utils/rollup.npm.config.mjs
isaacs
isaacs approved these changes Jul 4, 2026
View reviewed changes

@isaacsisaacs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clanker concern about file location breaking the submodule export is valid.

Once that's fixed, omg, yes, please get this landed ASAP, before we add more of these. It's so annoying to keep resolving those conflicts, this can't happen soon enough! 👏😅

Comment threadpackages/server-utils/src/orchestrion/channels.ts
...pgChannels,
...openaiChannels,
...anthropicAiChannels,
...vercelAiChannels,

@isaacsisaacsJul 4, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES. 👏

Comment threadpackages/server-utils/rollup.npm.config.mjs
@mydea
mydea merged commit 14ed5f1 into developJul 6, 2026
388 of 390 checks passed
@mydea
mydea deleted the fn/orchestrion-config-per-file branch July 6, 2026 07:52
@nicohrubecnicohrubec mentioned this pull request Jul 6, 2026
Closed
@sentry-release-botsentry-release-botBot mentioned this pull request Jul 7, 2026
Closed
49 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments
@isaacsisaacsisaacs approved these changes
@JPeer264JPeer264Awaiting requested review from JPeer264JPeer264 was automatically assigned from getsentry/team-javascript-sdks-server
@andreiborzaandreiborzaAwaiting requested review from andreiborzaandreiborza was automatically assigned from getsentry/team-javascript-sdks-server

Assignees

@mydeamydea

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@isaacs