Uh oh!
There was an error while loading. Please reload this page.
test(nextjs): Add orchestrion e2e test app - #22080
Merged
Merged
Conversation
Contributor
size-limit report 📦
|
chargomeforce-pushed
the
cg/nextjs-orchestrion-e2e
branch
from
July 8, 2026 17:03
a7f4e38 to
35bcc80Comparechargome
marked this pull request as ready for review
July 9, 2026 16:13
chargome added a commit
that referenced
this pull request
Jul 10, 2026
Adds an experimental option for opting in to orchestrion instrumentation. - Once the opt-in flag is set we: - Un-externalize the bundle-safe instrumented packages; bundle-unsafe ones (`mysql`) stay external and are instrumented by the runtime module hook, which works because we also externalize the `@apm-js-collab/*` transformer packages. - `transpilePackages` for the ones that Next externalizes by default (e.g. `pg`) — removing them from serverExternalPackages isn't enough for Next's own defaults. - Inject the code-transform loader as a Turbopack rule and as a webpack plugin. - The webpack loader gets exported from our server utils package (which can be used for turbopack too) Verified in [e2e](#22080) closes#22009 --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
chargome
requested review from
JPeer264, andreiborza, mydea and s1gr1d
and removed request for
a teamJuly 10, 2026 10:53
Exercises the experimental useDiagnosticsChannelInjection opt-in on both Turbopack and webpack builds: ioredis is instrumented via the build-time loader (bundle-safe allowlist), pg and mysql via the runtime module hook, asserted through API routes and a dynamically rendered SSR page. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
chargomeforce-pushed
the
cg/nextjs-orchestrion-e2e
branch
from
July 10, 2026 11:09
a7025ea to
01946a2CompareThe nextjs-16-orchestrion test app pins the same next@16.2.3 as the other nextjs-16-* E2E apps; dependency review only scans newly added manifests, so the pre-existing pin surfaces on this PR. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Resolves the dependency-review failures on the newly added manifest (all flagged high-severity advisories are patched in 16.2.6+), instead of allowlisting the 16.2.3 GHSAs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
andreiborza
approved these changes
Jul 10, 2026
andreiborza
left a comment
Member
There was a problem hiding this comment.
Nice, thanks for adding this.
timfish
approved these changes
Jul 10, 2026
timfish
left a comment
Collaborator
There was a problem hiding this comment.
Would be good to get this merged before the weekend!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an e2e test for nextjs-16 with opt-in for orchestrion.
Tests both webpack+turbopack paths
closes#21993