Skip to content

ref(core): Use common span attribute keys from Sentry conventions - #22081

Merged
Lms24 merged 1 commit into
developfrom
lms/ref-use-conventions-common-span-attributes
Jul 8, 2026
Merged

ref(core): Use common span attribute keys from Sentry conventions#22081
Lms24 merged 1 commit into
developfrom
lms/ref-use-conventions-common-span-attributes

Conversation

@Lms24

@Lms24Lms24 commented Jul 8, 2026

Copy link
Copy Markdown
Member

Deprecates a few of our attribute key exports, in favour of the same attribute keys in @sentry/conventions. Replaces all usage of the attributes across the codebase.

Decided to give this a go on some very infrequently used attributes first, to check bundle size impact and work required for such migrations.

@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

PathSize% ChangeChange
@sentry/browser27.59 kB--
@sentry/browser - with treeshaking flags26.03 kB--
@sentry/browser (incl. Tracing)46.27 kB--
@sentry/browser (incl. Tracing + Span Streaming)48.02 kB-0.03%-12 B 🔽
@sentry/browser (incl. Tracing, Profiling)51.03 kB--
@sentry/browser (incl. Tracing, Replay)85.56 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags75.17 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)90.26 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)102.91 kB--
@sentry/browser (incl. Feedback)44.76 kB--
@sentry/browser (incl. sendFeedback)32.38 kB--
@sentry/browser (incl. FeedbackAsync)37.51 kB--
@sentry/browser (incl. Metrics)28.67 kB--
@sentry/browser (incl. Logs)28.91 kB--
@sentry/browser (incl. Metrics & Logs)29.59 kB--
@sentry/react29.38 kB--
@sentry/react (incl. Tracing)48.53 kB--
@sentry/vue33.03 kB--
@sentry/vue (incl. Tracing)48.16 kB--
@sentry/svelte27.61 kB--
CDN Bundle30 kB--
CDN Bundle (incl. Tracing)48.24 kB-0.04%-17 B 🔽
CDN Bundle (incl. Logs, Metrics)31.57 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.55 kB-0.05%-24 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics)70.81 kB--
CDN Bundle (incl. Tracing, Replay)85.74 kB+0.02%+11 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)87.05 kB+0.02%+16 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)91.55 kB+0.01%+1 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)92.83 kB+0.01%+9 B 🔺
CDN Bundle - uncompressed89.35 kB--
CDN Bundle (incl. Tracing) - uncompressed145.97 kB-0.02%-25 B 🔽
CDN Bundle (incl. Logs, Metrics) - uncompressed94.05 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed149.94 kB-0.02%-25 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed218.75 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed265.13 kB-0.01%-25 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed269.09 kB-0.01%-25 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed278.83 kB-0.01%-25 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed282.78 kB-0.01%-25 B 🔽
@sentry/nextjs (client)50.94 kB--
@sentry/sveltekit (client)46.68 kB--
@sentry/core/server78.42 kB+0.05%+35 B 🔺
@sentry/core/browser64.74 kB-0.01%-2 B 🔽
@sentry/node-core62.72 kB--
@sentry/node124.6 kB-0.01%-3 B 🔽
@sentry/node (incl. diagnostics channel injection)131.87 kB-0.01%-4 B 🔽
@sentry/node/import (ESM hook with diagnostics-channel injection)69.95 kB--
@sentry/node/light50.72 kB--
@sentry/node - without tracing74.05 kB+0.01%+3 B 🔺
@sentry/aws-serverless85.5 kB+0.01%+1 B 🔺
@sentry/cloudflare (withSentry) - minified181.69 kB+0.01%+12 B 🔺
@sentry/cloudflare (withSentry)449.12 kB-0.07%-274 B 🔽

View base workflow run

@Lms24
Lms24 marked this pull request as ready for review July 8, 2026 10:56
@Lms24
Lms24 requested review from a team as code ownersJuly 8, 2026 10:56
@Lms24
Lms24 requested review from JPeer264, andreiborza, logaretm and mydea and removed request for a teamJuly 8, 2026 10:56
@Lms24

Lms24 commented Jul 8, 2026

Copy link
Copy Markdown
MemberAuthor

size impact seems mostly favourable (or within margins of minimal flakes). Gonna merge

@Lms24
Lms24 merged commit d4e997e into developJul 8, 2026
304 checks passed
@Lms24
Lms24 deleted the lms/ref-use-conventions-common-span-attributes branch July 8, 2026 12:20
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Lms24@andreiborza