Uh oh!
There was an error while loading. Please reload this page.
feat(server-utils): Add requiresParentSpan option to bindTracingChannelToSpan - #22113
Merged
Merged
Conversation
…elToSpan Hoists the repeated "skip when there's no active span" guard out of the individual `getSpan` callbacks into a `requiresParentSpan` option on the binding helper. Migrates mysql2, ioredis, postgres, and postgres-js onto it.
Contributor
size-limit report 📦
|
logaretm
marked this pull request as ready for review
July 8, 2026 19:27
logaretm
requested review from
JPeer264, andreiborza, isaacs and mydea
and removed request for
a teamJuly 8, 2026 19:27
andreiborza
approved these changes
Jul 8, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 17b4fd9. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bunch of the diagnostics-channel subscribers repeated the same guard at the top of their
getSpancallback.Usually the logic is to bail out with
undefinedwhen there's no active span, so we don't open a top-level db span for queries/connects that happen outside a request.This pulls that into a
requiresParentSpanoption onbindTracingChannelToSpanand moves the check into the bind store, beforegetSpanruns. Behaviorally identical, just one place instead of five.If you need to actually inspect the parent span before deciding, that still belongs in
getSpan.Feel free to push back if this over complicates the
bindTracingChannelToSpan, I thought it was a nice opportunity to normalize this behavior but not a biggie.