Uh oh!
There was an error while loading. Please reload this page.
feat(server-utils): Port SQS, SNS and Lambda aws-sdk extensions with trace propagation - #22165
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
5069f36 to
6abbb22CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
6abbb22 to
1964abfCompareUh oh!
There was an error while loading. Please reload this page.
1964abf to
f024586CompareUh oh!
There was an error while loading. Please reload this page.
size-limit report 📦
|
f024586 to
430affdCompare430affd to
d26e97fCompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
d26e97f to
711b9bdCompareUh oh!
There was an error while loading. Please reload this page.
3f1cf4a to
c43b14cComparec43b14c to
d993b9eCompared993b9e to
c2cad25Comparec2cad25 to
786f10cCompare7671eef to
6f95d7cCompare6f95d7c to
511baf5Compare511baf5 to
a528fedComparea528fed to
511baf5Compare511baf5 to
879987dCompareUh oh!
There was an error while loading. Please reload this page.
511baf5 to
d9ae35dCompared9ae35d to
0d5ff66Compare7e8a838 to
fe3ca8eCompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| let spanAttributes: Record<string, unknown> = {}; | ||
| let spanName: string | undefined; | ||
| switch (request.commandName) { |
There was a problem hiding this comment.
l: this looks a bit weird to me, why use a switch with a single case?
There was a problem hiding this comment.
Fair, this has been in the vendored otel instrumentation like this but I'll update to an if
| span.setAttribute(MESSAGING_BATCH_MESSAGE_COUNT, messages.length); | ||
| for (const message of messages) { | ||
| const headers = extractPropagationHeaders(message); |
There was a problem hiding this comment.
l: maybe this is a bit easier to read if we refactor the treatment of one message into a function?
| /** DynamoDB `db.system` value (an attribute value, not a key, so not covered by conventions). */ | ||
| export const DB_SYSTEM_VALUE_DYNAMODB = 'dynamodb'; | ||
| // Messaging (obsolete OTel convention with no `@sentry/conventions` export, kept for parity) |
There was a problem hiding this comment.
q: will this change in v11 or do we keep as is?
There was a problem hiding this comment.
We can update this in v11, I'll add a todo/task.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d8bd9cf. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
d8bd9cf to
d5c1dc0Compare…-link helper, note v11 destination_kind TODO
Uh oh!
There was an error while loading. Please reload this page.

Ports the messaging service extensions from the OTel aws-sdk integration to the orchestrion channel integration and registers them in the service registry:
messaging.*attributes, trace propagation into outgoingMessageAttributes(single and batch), and span links from received messages via the propagated headersPublish,messaging.*and topic ARN attributes, trace propagation intoMessageAttributesfaas.*attributes forInvoke, trace propagation into the base64ClientContext(respecting the 3583 byte cap)Propagation writes Sentry-native
sentry-trace/baggageheaders derived from the request span instead of OTelpropagation.inject, and the SQS receive side reads them back withpropagationContextFromHeaders.Part of #20946