Uh oh!
There was an error while loading. Please reload this page.
feat(server-utils): Port Bedrock aws-sdk extension and add integration tests - #22166
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
188ac82 to
ff165d4Compareff165d4 to
a4dd353Comparesize-limit report 📦
|
a4dd353 to
968db2fCompare968db2f to
5f2a15fCompare5f2a15f to
8f3599bCompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
8f3599b to
0a944abCompare0a944ab to
5506257Compare14699e8 to
a464258Compare2849cfe to
8e57368Compare8e57368 to
a265ce7Compared096bd6 to
7813fbfCompare7813fbf to
b26c7d1Compareb26c7d1 to
87eaf3aComparedb6d0a5 to
86f20c1CompareThere was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 86f20c1. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
ee60599 to
a94d0e5Comparea94d0e5 to
4ec2635Compare4ec2635 to
2c0f0f5CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
nicohrubec
left a comment
There was a problem hiding this comment.
nice, didn't know that we support this already
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.

Ports the BedrockRuntime gen_ai service extension from the OTel aws-sdk integration to the orchestrion channel integration: chat span name and request parameters for
Converse/ConverseStream, per-model-family request body parsing forInvokeModel/InvokeModelWithResponseStream(titan, nova, claude, llama, cohere, mistral), token usage and finish reasons from responses, and deferred span end for the streaming commands (the span ends when the wrapped stream is consumed).Adds nock-mocked integration tests for the non-streaming
ConverseandInvokeModelcommands, asserted against both the OTel and diagnostics-channel paths. The streaming commands use the AWS binary eventstream framing which nock cannot mock, so they stay untested here.This completes orchestrion parity with the OTel aws-sdk integration.
User-facing differences to the vendored OTel instrumentation
ConverseStreamcallers receive the original response object with itsstreamwrapped in place, instead of a new object (a channel subscriber can't replace the resolved value); relevant only to identity-sensitive codeFixes#20946