Uh oh!
There was an error while loading. Please reload this page.
feat(node): move dc integration swap to _init - #22173
Merged
Merged
Conversation
isaacs
requested review from
JPeer264, andreiborza and mydea
and removed request for
a teamJuly 10, 2026 03:33
Contributor
size-limit report 📦
|
isaacsforce-pushed
the
isaacs/node-move-default-integration-swap
branch
from
July 10, 2026 14:15
7b12bae to
63a580fCompareisaacsforce-pushed
the
isaacs/node-move-default-integration-swap
branch
from
July 10, 2026 16:30
63a580f to
89c3b4cCompareisaacsforce-pushed
the
isaacs/node-move-default-integration-swap
branch
from
July 10, 2026 16:53
89c3b4c to
1d877dfCompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
isaacsforce-pushed
the
isaacs/node-move-default-integration-swap
branch
from
July 10, 2026 17:16
1d877df to
5d4d988CompareThere was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5d4d988. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
isaacsforce-pushed
the
isaacs/node-move-default-integration-swap
branch
from
July 10, 2026 17:36
5d4d988 to
b2a369dCompareMove the diagnostics-channel integration swap out of `getDefaultIntegrations` and into `_init`, so it also applies to framework SDKs that pass their own `defaultIntegrations` array, and is skipped when defaults are explicitly empty. This will be needed because the NestJS SDK (and others) build on top of the Node SDK, but swap out their default integrations.
isaacsforce-pushed
the
isaacs/node-move-default-integration-swap
branch
from
July 13, 2026 00:42
b2a369d to
56289c4CompareJPeer264
approved these changes
Jul 13, 2026
JPeer264
left a comment
Member
There was a problem hiding this comment.
LGTM.
super-l: I think this is more of a fix than a feat, but that's a nit and can be ignored.
andreiborza
approved these changes
Jul 13, 2026
isaacs
commented
Jul 13, 2026
MemberAuthor
Oh, no, that's actually a great point. Idk what I was thinking, users 100% do not need this in the changelog 😅 I'll edit the commit headline and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the diagnostics-channel integration swap out of
getDefaultIntegrationsand into_init, so it also applies to framework SDKs that pass their owndefaultIntegrationsarray, and is skipped when defaults are explicitly empty.This will be needed because the NestJS SDK (and others) build on top of the Node SDK, but swap out their default integrations.