ref(nestjs): extract shared span helpers by isaacs · Pull Request #22175 · getsentry/sentry-javascript

isaacs · 2026-07-10T03:34:30Z

Pull the span-emitting/patching logic out of the OTel InstrumentationBase classes into wrap-components, wrap-handlers, and wrap-route so it can be reused by the diagnostics-channel integration.

Refactor only. There is still only the OTel implementation, which still emits the same spans as before. However, this will be needed when the next implementation is added.

github-actions · 2026-07-10T03:48:06Z

size-limit report 📦

Path	Size	% Change	Change
@sentry/browser	27.61 kB	-	-
@sentry/browser - with treeshaking flags	26.05 kB	-	-
@sentry/browser (incl. Tracing)	46.36 kB	-	-
@sentry/browser (incl. Tracing + Span Streaming)	48.16 kB	-	-
@sentry/browser (incl. Tracing, Profiling)	51.15 kB	-	-
@sentry/browser (incl. Tracing, Replay)	85.63 kB	-	-
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags	75.27 kB	-	-
@sentry/browser (incl. Tracing, Replay with Canvas)	90.34 kB	-	-
@sentry/browser (incl. Tracing, Replay, Feedback)	103 kB	-	-
@sentry/browser (incl. Feedback)	44.79 kB	-	-
@sentry/browser (incl. sendFeedback)	32.41 kB	-	-
@sentry/browser (incl. FeedbackAsync)	37.53 kB	-	-
@sentry/browser (incl. Metrics)	28.69 kB	-	-
@sentry/browser (incl. Logs)	28.93 kB	-	-
@sentry/browser (incl. Metrics & Logs)	29.62 kB	-	-
@sentry/react	29.4 kB	-	-
@sentry/react (incl. Tracing)	48.63 kB	-	-
@sentry/vue	33.04 kB	-	-
@sentry/vue (incl. Tracing)	48.34 kB	-	-
@sentry/svelte	27.63 kB	-	-
CDN Bundle	30.01 kB	-	-
CDN Bundle (incl. Tracing)	48.34 kB	-	-
CDN Bundle (incl. Logs, Metrics)	31.59 kB	-	-
CDN Bundle (incl. Tracing, Logs, Metrics)	49.65 kB	-	-
CDN Bundle (incl. Replay, Logs, Metrics)	70.82 kB	-	-
CDN Bundle (incl. Tracing, Replay)	85.84 kB	-	-
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)	87.16 kB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback)	91.65 kB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)	92.92 kB	-	-
CDN Bundle - uncompressed	89.37 kB	-	-
CDN Bundle (incl. Tracing) - uncompressed	146.12 kB	-	-
CDN Bundle (incl. Logs, Metrics) - uncompressed	94.07 kB	-	-
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed	150.09 kB	-	-
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed	218.8 kB	-	-
CDN Bundle (incl. Tracing, Replay) - uncompressed	265.32 kB	-	-
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed	269.28 kB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed	279.02 kB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed	282.97 kB	-	-
@sentry/nextjs (client)	51.18 kB	-	-
@sentry/sveltekit (client)	46.81 kB	-	-
@sentry/core/server	78.42 kB	-	-
@sentry/core/browser	64.77 kB	-	-
@sentry/node-core	62.73 kB	-	-
@sentry/node	125.09 kB	-	-
@sentry/node (incl. diagnostics channel injection)	139.35 kB	-	-
@sentry/node/import (ESM hook with diagnostics-channel injection)	69.96 kB	-	-
@sentry/node/light	50.73 kB	-0.01%	-2 B 🔽
@sentry/node - without tracing	74.1 kB	-	-
@sentry/aws-serverless	83.33 kB	+0.01%	+2 B 🔺
@sentry/cloudflare (withSentry) - minified	181.58 kB	-	-
@sentry/cloudflare (withSentry)	449.49 kB	-	-

View base workflow run

nicohrubec

overall lgtm, I just have two small questions/remarks

JPeer264

LGTM.

Just this one clanker concern would be nice to validate

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 0ebbf46. Configure here.}

Pull the span-emitting/patching logic out of the OTel `InstrumentationBase` classes into `wrap-components`, `wrap-handlers`, and `wrap-route` so it can be reused by the diagnostics-channel integration. Refactor only. There is still only the OTel implementation, which still emits the same spans as before. However, this will be needed when the next implementation is added.

isaacs requested a review from a team as a code owner July 10, 2026 03:34

isaacs requested review from chargome, mydea and nicohrubec and removed request for a teamJuly 10, 2026 03:34

nicohrubec approved these changes Jul 10, 2026
View reviewed changes

Comment threadpackages/nestjs/src/integrations/helpers.ts
Comment threadpackages/nestjs/src/integrations/sentry-nest-bullmq-instrumentation.ts Outdated

isaacs requested a review from a team as a code owner July 10, 2026 14:15

isaacs requested review from JPeer264 and andreiborza and removed request for a teamJuly 10, 2026 14:15

isaacs force-pushed the isaacs/nestjs-extract-helpers branch from 1eb7633 to fa0de85Compare July 10, 2026 14:16

isaacs force-pushed the isaacs/nestjs-extract-helpers branch from fa0de85 to dd92103Compare July 10, 2026 16:30

isaacs force-pushed the isaacs/nestjs-extract-helpers branch from dd92103 to b74dcbdCompare July 10, 2026 16:53

isaacs force-pushed the isaacs/nestjs-extract-helpers branch from b74dcbd to 9315716Compare July 10, 2026 17:16

sentryBot reviewed Jul 10, 2026
View reviewed changes

Comment threadpackages/nestjs/src/integrations/wrap-handlers.ts

isaacs force-pushed the isaacs/nestjs-extract-helpers branch from 9315716 to 28b5141Compare July 10, 2026 17:36

isaacs force-pushed the isaacs/nestjs-extract-helpers branch from 28b5141 to 915478fCompare July 13, 2026 00:42

cursorBot reviewed Jul 13, 2026
View reviewed changes

Comment threadpackages/nestjs/src/integrations/wrap-handlers.ts
Comment threadpackages/nestjs/src/integrations/wrap-handlers.ts Outdated
Comment threadpackages/nestjs/src/integrations/wrap-handlers.ts

sentryBot reviewed Jul 13, 2026
View reviewed changes

Comment threadpackages/nestjs/src/integrations/wrap-components.ts

JPeer264 approved these changes Jul 13, 2026
View reviewed changes

Comment threadpackages/nestjs/src/integrations/wrap-route.ts Outdated
Comment threadpackages/nestjs/src/integrations/wrap-components.ts

andreiborza approved these changes Jul 13, 2026
View reviewed changes

Comment threadpackages/nestjs/src/integrations/sentry-nest-instrumentation.ts Outdated

Base automatically changed from isaacs/node-move-default-integration-swap to developJuly 13, 2026 14:08

isaacs requested a review from a team as a code owner July 13, 2026 14:08

isaacs requested review from msonnb and removed request for a teamJuly 13, 2026 14:08

isaacs force-pushed the isaacs/nestjs-extract-helpers branch from 915478f to b49e065Compare July 13, 2026 14:08

sentryBot reviewed Jul 13, 2026
View reviewed changes

Comment threadpackages/nestjs/src/integrations/wrap-route.ts

isaacs force-pushed the isaacs/nestjs-extract-helpers branch from b49e065 to 5714894Compare July 13, 2026 14:15

cursorBot reviewed Jul 13, 2026
View reviewed changes

Comment threadpackages/nestjs/src/integrations/wrap-handlers.ts Outdated

isaacs force-pushed the isaacs/nestjs-extract-helpers branch from 5714894 to 139ac5eCompare July 13, 2026 15:03

sentryBot reviewed Jul 13, 2026
View reviewed changes

Comment threadpackages/nestjs/src/integrations/wrap-route.ts

cursorBot reviewed Jul 13, 2026
View reviewed changes

Comment threadpackages/nestjs/src/integrations/wrap-route.ts

isaacs force-pushed the isaacs/nestjs-extract-helpers branch 2 times, most recently from b4e6fdc to 868f6a8Compare July 13, 2026 15:24

cursorBot reviewed Jul 13, 2026
View reviewed changes

Comment threadpackages/nestjs/src/integrations/helpers.ts Outdated

isaacs force-pushed the isaacs/nestjs-extract-helpers branch from 868f6a8 to 0ebbf46Compare July 13, 2026 15:39

cursorBot reviewed Jul 13, 2026
View reviewed changes

Comment threadpackages/nestjs/src/integrations/helpers.ts

isaacs force-pushed the isaacs/nestjs-extract-helpers branch from 0ebbf46 to 8f95306Compare July 13, 2026 15:47

isaacs merged commit 0ea8a51 into developJul 13, 2026
58 checks passed

isaacs deleted the isaacs/nestjs-extract-helpers branch July 13, 2026 18:15

sentry-release-botBot mentioned this pull request Jul 16, 2026
publish: getsentry/sentry-javascript@10.66.0 getsentry/publish#8918
Closed
49 tasks

github-actionsBot mentioned this pull request Jul 20, 2026
[skill-drift] update(sentry-nestjs-sdk): document experimentalUseDiagnosticsChannelInjection() getsentry/sentry-for-ai#292
Open

Navigation Menu

Uh oh!

Uh oh!

ref(nestjs): extract shared span helpers - #22175

ref(nestjs): extract shared span helpers#22175
isaacs merged 1 commit into
developfrom
isaacs/nestjs-extract-helpers

isaacs commented Jul 10, 2026

Uh oh!

github-actionsBot commented Jul 10, 2026•
edited
Loading

Uh oh!

nicohrubec left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JPeer264 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursorBot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

isaacs commented Jul 10, 2026

Uh oh!

github-actionsBot commented Jul 10, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

nicohrubec left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JPeer264 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursorBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actionsBot commented Jul 10, 2026•
edited
Loading