Skip to content

feat(nestjs): add orchestrion diagnostics-channel instrumentation - #22176

Merged
isaacs merged 1 commit into
developfrom
isaacs/nestjs-orchestrion-impl
Jul 13, 2026
Merged

feat(nestjs): add orchestrion diagnostics-channel instrumentation#22176
isaacs merged 1 commit into
developfrom
isaacs/nestjs-orchestrion-impl

Conversation

@isaacs

@isaacsisaacs commented Jul 10, 2026

Copy link
Copy Markdown
Member

Add the NestJS channel subscriber in @sentry/nestjs, plus its code-transform config and channel names in @sentry/server-utils.

nestIntegration now uses the diagnostics-channel path when orchestrion is injected and the vendored OTel path otherwise. Only the span origin differs between the two implementations.

Fix: #20947
Fix: #20904
Fix: #20905
Fix: #20906
Fix: #20907
Fix: JS-2519
Fix: JS-2477
Fix: JS-2478
Fix: JS-2479
Fix: JS-2480

@isaacs
isaacs requested review from a team as code ownersJuly 10, 2026 03:36
@isaacs
isaacs requested review from JPeer264, andreiborza, chargome, mydea and s1gr1d and removed request for a teamJuly 10, 2026 03:36
@linear-code

linear-codeBot commented Jul 10, 2026

Copy link
Copy Markdown

@isaacs
isaacsforce-pushed the isaacs/nestjs-orchestrion-impl branch from 2ace4ec to d7b514aCompareJuly 10, 2026 03:36
Comment threadpackages/nestjs/src/integrations/nest.ts
@github-actions

github-actionsBot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser27.61 kB--
@sentry/browser - with treeshaking flags26.05 kB--
@sentry/browser (incl. Tracing)46.36 kB--
@sentry/browser (incl. Tracing + Span Streaming)48.16 kB--
@sentry/browser (incl. Tracing, Profiling)51.15 kB--
@sentry/browser (incl. Tracing, Replay)85.63 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags75.27 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)90.34 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)103 kB--
@sentry/browser (incl. Feedback)44.79 kB--
@sentry/browser (incl. sendFeedback)32.41 kB--
@sentry/browser (incl. FeedbackAsync)37.53 kB--
@sentry/browser (incl. Metrics)28.69 kB--
@sentry/browser (incl. Logs)28.93 kB--
@sentry/browser (incl. Metrics & Logs)29.62 kB--
@sentry/react29.4 kB--
@sentry/react (incl. Tracing)48.63 kB--
@sentry/vue33.04 kB--
@sentry/vue (incl. Tracing)48.34 kB--
@sentry/svelte27.63 kB--
CDN Bundle30.01 kB--
CDN Bundle (incl. Tracing)48.34 kB--
CDN Bundle (incl. Logs, Metrics)31.59 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.65 kB--
CDN Bundle (incl. Replay, Logs, Metrics)70.82 kB--
CDN Bundle (incl. Tracing, Replay)85.84 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)87.16 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)91.65 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)92.92 kB--
CDN Bundle - uncompressed89.37 kB--
CDN Bundle (incl. Tracing) - uncompressed146.12 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed94.07 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed150.09 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed218.8 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed265.32 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed269.28 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed279.02 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed282.97 kB--
@sentry/nextjs (client)51.18 kB--
@sentry/sveltekit (client)46.81 kB--
@sentry/core/server78.42 kB--
@sentry/core/browser64.77 kB--
@sentry/node-core62.73 kB+0.01%+1 B 🔺
@sentry/node125.09 kB--
@sentry/node (incl. diagnostics channel injection)139.66 kB+0.23%+315 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection)69.96 kB--
@sentry/node/light50.73 kB--
@sentry/node - without tracing74.1 kB--
@sentry/aws-serverless83.32 kB-0.01%-2 B 🔽
@sentry/cloudflare (withSentry) - minified181.58 kB--
@sentry/cloudflare (withSentry)449.49 kB--

View base workflow run

@isaacs
isaacsforce-pushed the isaacs/nestjs-orchestrion-impl branch from d7b514a to 9d8bcb6CompareJuly 10, 2026 14:16
@isaacs
isaacsforce-pushed the isaacs/nestjs-orchestrion-impl branch from 9d8bcb6 to f3a502eCompareJuly 10, 2026 16:30
@isaacs
isaacsforce-pushed the isaacs/nestjs-orchestrion-impl branch from f3a502e to d63141cCompareJuly 10, 2026 16:53
@isaacs
isaacsforce-pushed the isaacs/nestjs-orchestrion-impl branch from d63141c to 9e50193CompareJuly 10, 2026 17:16
@isaacs
isaacsforce-pushed the isaacs/nestjs-orchestrion-impl branch 3 times, most recently from 03c4d95 to e554559CompareJuly 13, 2026 00:42

@JPeer264JPeer264 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Got 3 comments

Comment threadpackages/server-utils/src/orchestrion/config/index.ts Outdated
@isaacs
isaacs requested a review from a team as a code ownerJuly 13, 2026 14:08
@isaacs
isaacsforce-pushed the isaacs/nestjs-orchestrion-impl branch from e554559 to 2fa98d0CompareJuly 13, 2026 14:08

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2fa98d0. Configure here.

Comment threadpackages/server-utils/src/orchestrion/config/index.ts Outdated
Comment threadpackages/server-utils/src/orchestrion/config/index.ts Outdated
@isaacs
isaacsforce-pushed the isaacs/nestjs-orchestrion-impl branch from 2fa98d0 to a01cbf6CompareJuly 13, 2026 14:15
@isaacs
isaacsforce-pushed the isaacs/nestjs-orchestrion-impl branch from a01cbf6 to 481c2ccCompareJuly 13, 2026 15:03
@isaacs
isaacsforce-pushed the isaacs/nestjs-orchestrion-impl branch from 481c2cc to f16df75CompareJuly 13, 2026 15:24
@isaacs
isaacsforce-pushed the isaacs/nestjs-orchestrion-impl branch from f16df75 to 93a8cbeCompareJuly 13, 2026 15:24
@isaacs
isaacsforce-pushed the isaacs/nestjs-orchestrion-impl branch from 93a8cbe to 588a170CompareJuly 13, 2026 15:39
@isaacs
isaacsforce-pushed the isaacs/nestjs-orchestrion-impl branch from 588a170 to e493838CompareJuly 13, 2026 15:47
Base automatically changed from isaacs/nestjs-extract-helpers to developJuly 13, 2026 18:15
@isaacs
isaacsforce-pushed the isaacs/nestjs-orchestrion-impl branch from e493838 to 47b1bceCompareJuly 13, 2026 18:15
Add the NestJS channel subscriber in `@sentry/nestjs`, plus its
code-transform config and channel names in `@sentry/server-utils`.
`nestIntegration` now uses the diagnostics-channel path when orchestrion
is injected and the vendored OTel path otherwise. Only the span origin
differs between the two implementations.
Fix: #20947Fix: #20904Fix: #20905Fix: #20906Fix: #20907
Fix: JS-2519
Fix: JS-2477
Fix: JS-2478
Fix: JS-2479
Fix: JS-2480
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants

@isaacs@JPeer264