Uh oh!
There was an error while loading. Please reload this page.
feat(node): Rewrite tedious instrumentation to orchestrion tracing channels - #22238
Merged
isaacs merged 1 commit intoJul 16, 2026
Conversation
Contributor
size-limit report 📦
|
logaretmforce-pushed
the
awad/js-2417-rewrite-opentelemetryinstrumentation-tedious-to-orchestrion
branch
from
July 14, 2026 16:16
f0842ac to
9a144ddComparelogaretm
marked this pull request as ready for review
July 14, 2026 17:32
logaretm
requested review from
JPeer264, isaacs and mydea
and removed request for
a teamJuly 14, 2026 17:32
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9a144dd. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
logaretmforce-pushed
the
awad/js-2417-rewrite-opentelemetryinstrumentation-tedious-to-orchestrion
branch
from
July 14, 2026 18:09
9a144dd to
ca2f97cCompareUh oh!
There was an error while loading. Please reload this page.
isaacs
requested changes
Jul 15, 2026
isaacs
left a comment
Member
There was a problem hiding this comment.
Span attribs need an op. Other than that, this looks great.
Uh oh!
There was an error while loading. Please reload this page.
…annels Migrate the tedious integration off the vendored `InstrumentationBase` monkey-patch onto a `node:diagnostics_channel` subscriber whose channels are injected by the orchestrion code transform. The OTel path stays as the fallback when orchestrion isn't injected. tedious is a default performance integration, so it uses the central `channelIntegrations` swap: `_init` filters the OTel `Tedious` integration out of the defaults by name and appends the channel one. No per-integration node code. The subscriber wraps the six `Connection` request methods (one db span each) and `Connection.connect` (active-database bookkeeping). Each method returns synchronously while the request settles later via its callback/events, so the subscriber owns span-ending: it wraps `request.callback` and listens for the request `error` and connection `end` events, mirroring the vendored OTel instrumentation. Fixes#20766
logaretmforce-pushed
the
awad/js-2417-rewrite-opentelemetryinstrumentation-tedious-to-orchestrion
branch
from
July 15, 2026 22:43
ca2f97c to
5b723c2Compareisaacs
approved these changes
Jul 16, 2026
Uh oh!
There was an error while loading. Please reload this page.
isaacs
deleted the
awad/js-2417-rewrite-opentelemetryinstrumentation-tedious-to-orchestrion
branch
July 16, 2026 16:19
49 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates the tedious integration off the vendored
InstrumentationBaseonto anode:diagnostics_channelsubscriber whose channels orchestrion injects into the library. The OTel path stays as the fallback when orchestrion isn't injected.closes#20766