Uh oh!
There was an error while loading. Please reload this page.
fix(browser): Propagate trace data from active span if http.client span is non-recording - #22246
Merged
Conversation
Contributor
size-limit report 📦
|
Lms24
marked this pull request as ready for review
July 14, 2026 13:11
Lms24
requested review from
logaretm, msonnb and mydea
and removed request for
a teamJuly 14, 2026 13:11
http.client span is not recordinghttp.client span is not recordinghttp.client span is non-recordingLms24force-pushed
the
lms/fix-browser-active-span-http-client-non-recording
branch
from
July 15, 2026 11:29
f503cbe to
ace6029CompareLms24
changed the base branch from
develop
to
lms/fix-node-ative-span-http-client-non-recordingJuly 15, 2026 11:29
Lms24force-pushed
the
lms/fix-browser-active-span-http-client-non-recording
branch
from
July 15, 2026 14:55
ace6029 to
19e1891Compare…an is not recording
Expect the incoming DSC fields to be preserved while the ignored segment changes the propagated sampling decision to false. Co-Authored-By: Cursor <cursoragent@cursor.com>
Lms24force-pushed
the
lms/fix-browser-active-span-http-client-non-recording
branch
from
July 15, 2026 16:36
19e1891 to
f3a2c1eComparelogaretm
approved these changes
Jul 15, 2026
Uh oh!
There was an error while loading. Please reload this page.
Lms24 added a commit
that referenced
this pull request
Jul 16, 2026
This PR preserves trace propagation for ignored spans in span streaming mode: - When segment spans are ignored, incoming DSC (via baggage) is kept as-is, but is mutated to carry a negative sampling decision, in line with the `sentry-trace` header, which already emitted a negative sampling decision - ignored child and HTTP client spans propagate from the nearest emitted parent across fetch, `node:http` - For Orchestrion/tracing-channel-based instrumentation, we only set a child span as the active span if it is not ignored. This was already implemented in the OTel context manager previously but probably didn't get ported correctly to the new approach. Turns out, the DSC changes are also a requirement for #22246, so I threw it on top of this PR. ref #22262 --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com>
49 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an inconsistency with trace propagation via browser
http.clientspans: If anhttp.clientspan was started as aNonRecordingSpanwe'd still take it as the span we generate our tracing headers from (viagetTraceData). What we should do instead is to propagate the currently active span, so that span trees from a downstream service don't become orphaned.This PR also adds integration tests for 3 scenarios with
ignoreSpans:ref: #22262