fix(bundler-plugins): do not warn on known sourcemap-less chunks by isaacs · Pull Request #22267 · getsentry/sentry-javascript

isaacs · 2026-07-14T19:42:53Z

Prevent potentially large number of noisy warnings that by design never emit sourcemaps.

For example:

~/b0f41f6b-e36f-409b-817f-921f7d295a7b-155.js (no sourcemap found, debug id b0f41f6b-...)
- warning: could not determine a source map reference (Could not auto-detect referenced sourcemap for ~/b0f41f6b-...-155.js)

This cannot be safely avoided using the file path glob approach, as seen in #18938, because the file paths in question here (uuids and alphanumeric hashes) can't be guaranteed to never hold user code as seen in the cases covered by #18938.

Instead, when no symbolication can be performed because the chunk is a stub without any sourcemap, downgrade the warning to a debug log.

fix: #22199
fix: #22199

linear-code · 2026-07-14T19:42:56Z

JS-3006

timfish · 2026-07-14T19:49:03Z

This warning highlighted to users if they don't have sourcemaps enabled. After these changes is this still some kind of warning in this case?

isaacs · 2026-07-15T00:59:27Z

This warning highlighted to users if they don't have sourcemaps enabled. After these changes is this still some kind of warning in this case?

Ah, yes, that would be bad, whoops. Good catch.

I think we can still resolve this, though, by moving the warning up a level, to the manager instead of on the per-file level. Fixed on bfc2b32

timfish · 2026-07-15T01:44:59Z

The test failures suggest that this change results in the sourcemap cli command no longer running when there are no sourcemaps. I guess this is preferable but I don't fully understand the consequences!

sentry · 2026-07-15T04:09:06Z

+ if (files.length === 0) {
+ logger.warn(
+ `No source maps found for any of the ${debugIdChunkFilePaths.length} matched build ` +
+ 'artifacts, so no source maps were uploaded to Sentry. This usually means source map ' +
+ 'generation is not enabled in your bundler. Enable it so Sentry can un-minify your stack traces.',
+ );
+ return;
+ }


Bug: The warning for no source maps being found is misleading. It assumes source map generation is disabled, but it could also mean the asset glob only matched chunks without source maps.
_{Severity: LOW}
Suggested Fix
The warning message should be more nuanced. Instead of definitively stating that source map generation is disabled, it should suggest that either source map generation is disabled OR that the sourcemaps.assets glob pattern might not be matching any files that have source maps. This would guide the user to check both their bundler configuration and their plugin configuration.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not valid. Location: packages/bundler-plugins/src/core/build-plugin-manager.ts#L710-L717 Potential issue: The warning logged when no source maps are found for upload is misleading. The code checks if the temporary upload folder is empty (`files.length === 0`) and, if so, logs that "source map generation is not enabled". However, this folder can also be empty when the `sourcemaps.assets` glob pattern correctly matches files that legitimately do not have source maps, such as framework stubs. This can misdirect users into debugging their bundler configuration when the actual issue is a misconfigured glob pattern that only includes sourcemap-less chunks.
_{Did we get this right? 👍 / 👎 to inform future reviews.}

Prevent potentially large number of noisy warnings that by design never emit sourcemaps. For example: ``` ~/b0f41f6b-e36f-409b-817f-921f7d295a7b-155.js (no sourcemap found, debug id b0f41f6b-...) - warning: could not determine a source map reference (Could not auto-detect referenced sourcemap for ~/b0f41f6b-...-155.js) ``` This cannot be safely avoided using the file path glob approach, as seen in #18938, because the file paths in question here (uuids and alphanumeric hashes) can't be guaranteed to _never_ hold user code as seen in the cases covered by #18938. Instead, when no symbolication can be performed because the chunk is a stub without any sourcemap, downgrade the warning to a debug log. fix: #22199 fix: JS-3006

github-actions · 2026-07-17T10:36:34Z

👋 @chargome — Please review this PR when you get a chance!

chargome

LGTM did you test this in a real-world nextjs app too?

isaacs · 2026-07-27T15:31:04Z

@chargome

LGTM did you test this in a real-world nextjs app too?

I did. It does prevent the excessive logs in the case the user reported (they're still there in debug mode).

isaacs · 2026-07-14T19:42:53Z

Prevent potentially large number of noisy warnings that by design never emit sourcemaps.

For example:

~/b0f41f6b-e36f-409b-817f-921f7d295a7b-155.js (no sourcemap found, debug id b0f41f6b-...)
- warning: could not determine a source map reference (Could not auto-detect referenced sourcemap for ~/b0f41f6b-...-155.js)

This cannot be safely avoided using the file path glob approach, as seen in #18938, because the file paths in question here (uuids and alphanumeric hashes) can't be guaranteed to never hold user code as seen in the cases covered by #18938.

Instead, when no symbolication can be performed because the chunk is a stub without any sourcemap, downgrade the warning to a debug log.

fix: #22199
fix: #22199

linear-code · 2026-07-14T19:42:56Z

JS-3006

timfish · 2026-07-14T19:49:03Z

This warning highlighted to users if they don't have sourcemaps enabled. After these changes is this still some kind of warning in this case?

isaacs · 2026-07-15T00:59:27Z

This warning highlighted to users if they don't have sourcemaps enabled. After these changes is this still some kind of warning in this case?

Ah, yes, that would be bad, whoops. Good catch.

I think we can still resolve this, though, by moving the warning up a level, to the manager instead of on the per-file level. Fixed on bfc2b32

timfish · 2026-07-15T01:44:59Z

The test failures suggest that this change results in the sourcemap cli command no longer running when there are no sourcemaps. I guess this is preferable but I don't fully understand the consequences!

sentry · 2026-07-15T04:09:06Z

+ if (files.length === 0) {
+ logger.warn(
+ `No source maps found for any of the ${debugIdChunkFilePaths.length} matched build ` +
+ 'artifacts, so no source maps were uploaded to Sentry. This usually means source map ' +
+ 'generation is not enabled in your bundler. Enable it so Sentry can un-minify your stack traces.',
+ );
+ return;
+ }


Bug: The warning for no source maps being found is misleading. It assumes source map generation is disabled, but it could also mean the asset glob only matched chunks without source maps.
_{Severity: LOW}
Suggested Fix
The warning message should be more nuanced. Instead of definitively stating that source map generation is disabled, it should suggest that either source map generation is disabled OR that the sourcemaps.assets glob pattern might not be matching any files that have source maps. This would guide the user to check both their bundler configuration and their plugin configuration.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not valid. Location: packages/bundler-plugins/src/core/build-plugin-manager.ts#L710-L717 Potential issue: The warning logged when no source maps are found for upload is misleading. The code checks if the temporary upload folder is empty (`files.length === 0`) and, if so, logs that "source map generation is not enabled". However, this folder can also be empty when the `sourcemaps.assets` glob pattern correctly matches files that legitimately do not have source maps, such as framework stubs. This can misdirect users into debugging their bundler configuration when the actual issue is a misconfigured glob pattern that only includes sourcemap-less chunks.
_{Did we get this right? 👍 / 👎 to inform future reviews.}

Prevent potentially large number of noisy warnings that by design never emit sourcemaps. For example: ``` ~/b0f41f6b-e36f-409b-817f-921f7d295a7b-155.js (no sourcemap found, debug id b0f41f6b-...) - warning: could not determine a source map reference (Could not auto-detect referenced sourcemap for ~/b0f41f6b-...-155.js) ``` This cannot be safely avoided using the file path glob approach, as seen in #18938, because the file paths in question here (uuids and alphanumeric hashes) can't be guaranteed to _never_ hold user code as seen in the cases covered by #18938. Instead, when no symbolication can be performed because the chunk is a stub without any sourcemap, downgrade the warning to a debug log. fix: #22199 fix: JS-3006

github-actions · 2026-07-17T10:36:34Z

👋 @chargome — Please review this PR when you get a chance!

chargome

LGTM did you test this in a real-world nextjs app too?

isaacs · 2026-07-27T15:31:04Z

@chargome

LGTM did you test this in a real-world nextjs app too?

I did. It does prevent the excessive logs in the case the user reported (they're still there in debug mode).

isaacs · 2026-07-14T19:42:53Z

Prevent potentially large number of noisy warnings that by design never emit sourcemaps.

For example:

~/b0f41f6b-e36f-409b-817f-921f7d295a7b-155.js (no sourcemap found, debug id b0f41f6b-...)
- warning: could not determine a source map reference (Could not auto-detect referenced sourcemap for ~/b0f41f6b-...-155.js)

This cannot be safely avoided using the file path glob approach, as seen in #18938, because the file paths in question here (uuids and alphanumeric hashes) can't be guaranteed to never hold user code as seen in the cases covered by #18938.

Instead, when no symbolication can be performed because the chunk is a stub without any sourcemap, downgrade the warning to a debug log.

fix: #22199
fix: #22199

linear-code · 2026-07-14T19:42:56Z

JS-3006

timfish · 2026-07-14T19:49:03Z

This warning highlighted to users if they don't have sourcemaps enabled. After these changes is this still some kind of warning in this case?

isaacs · 2026-07-15T00:59:27Z

This warning highlighted to users if they don't have sourcemaps enabled. After these changes is this still some kind of warning in this case?

Ah, yes, that would be bad, whoops. Good catch.

I think we can still resolve this, though, by moving the warning up a level, to the manager instead of on the per-file level. Fixed on bfc2b32

timfish · 2026-07-15T01:44:59Z

The test failures suggest that this change results in the sourcemap cli command no longer running when there are no sourcemaps. I guess this is preferable but I don't fully understand the consequences!

sentry · 2026-07-15T04:09:06Z

+ if (files.length === 0) {
+ logger.warn(
+ `No source maps found for any of the ${debugIdChunkFilePaths.length} matched build ` +
+ 'artifacts, so no source maps were uploaded to Sentry. This usually means source map ' +
+ 'generation is not enabled in your bundler. Enable it so Sentry can un-minify your stack traces.',
+ );
+ return;
+ }


Bug: The warning for no source maps being found is misleading. It assumes source map generation is disabled, but it could also mean the asset glob only matched chunks without source maps.
_{Severity: LOW}
Suggested Fix
The warning message should be more nuanced. Instead of definitively stating that source map generation is disabled, it should suggest that either source map generation is disabled OR that the sourcemaps.assets glob pattern might not be matching any files that have source maps. This would guide the user to check both their bundler configuration and their plugin configuration.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not valid. Location: packages/bundler-plugins/src/core/build-plugin-manager.ts#L710-L717 Potential issue: The warning logged when no source maps are found for upload is misleading. The code checks if the temporary upload folder is empty (`files.length === 0`) and, if so, logs that "source map generation is not enabled". However, this folder can also be empty when the `sourcemaps.assets` glob pattern correctly matches files that legitimately do not have source maps, such as framework stubs. This can misdirect users into debugging their bundler configuration when the actual issue is a misconfigured glob pattern that only includes sourcemap-less chunks.
_{Did we get this right? 👍 / 👎 to inform future reviews.}

Prevent potentially large number of noisy warnings that by design never emit sourcemaps. For example: ``` ~/b0f41f6b-e36f-409b-817f-921f7d295a7b-155.js (no sourcemap found, debug id b0f41f6b-...) - warning: could not determine a source map reference (Could not auto-detect referenced sourcemap for ~/b0f41f6b-...-155.js) ``` This cannot be safely avoided using the file path glob approach, as seen in #18938, because the file paths in question here (uuids and alphanumeric hashes) can't be guaranteed to _never_ hold user code as seen in the cases covered by #18938. Instead, when no symbolication can be performed because the chunk is a stub without any sourcemap, downgrade the warning to a debug log. fix: #22199 fix: JS-3006

github-actions · 2026-07-17T10:36:34Z

👋 @chargome — Please review this PR when you get a chance!

chargome

LGTM did you test this in a real-world nextjs app too?

isaacs · 2026-07-27T15:31:04Z

@chargome

LGTM did you test this in a real-world nextjs app too?

I did. It does prevent the excessive logs in the case the user reported (they're still there in debug mode).

isaacs · 2026-07-14T19:42:53Z

Prevent potentially large number of noisy warnings that by design never emit sourcemaps.

For example:

~/b0f41f6b-e36f-409b-817f-921f7d295a7b-155.js (no sourcemap found, debug id b0f41f6b-...)
- warning: could not determine a source map reference (Could not auto-detect referenced sourcemap for ~/b0f41f6b-...-155.js)

This cannot be safely avoided using the file path glob approach, as seen in #18938, because the file paths in question here (uuids and alphanumeric hashes) can't be guaranteed to never hold user code as seen in the cases covered by #18938.

Instead, when no symbolication can be performed because the chunk is a stub without any sourcemap, downgrade the warning to a debug log.

fix: #22199
fix: #22199

linear-code · 2026-07-14T19:42:56Z

JS-3006

timfish · 2026-07-14T19:49:03Z

This warning highlighted to users if they don't have sourcemaps enabled. After these changes is this still some kind of warning in this case?

isaacs · 2026-07-15T00:59:27Z

This warning highlighted to users if they don't have sourcemaps enabled. After these changes is this still some kind of warning in this case?

Ah, yes, that would be bad, whoops. Good catch.

I think we can still resolve this, though, by moving the warning up a level, to the manager instead of on the per-file level. Fixed on bfc2b32

timfish · 2026-07-15T01:44:59Z

The test failures suggest that this change results in the sourcemap cli command no longer running when there are no sourcemaps. I guess this is preferable but I don't fully understand the consequences!

sentry · 2026-07-15T04:09:06Z

+ if (files.length === 0) {
+ logger.warn(
+ `No source maps found for any of the ${debugIdChunkFilePaths.length} matched build ` +
+ 'artifacts, so no source maps were uploaded to Sentry. This usually means source map ' +
+ 'generation is not enabled in your bundler. Enable it so Sentry can un-minify your stack traces.',
+ );
+ return;
+ }


Bug: The warning for no source maps being found is misleading. It assumes source map generation is disabled, but it could also mean the asset glob only matched chunks without source maps.
_{Severity: LOW}
Suggested Fix
The warning message should be more nuanced. Instead of definitively stating that source map generation is disabled, it should suggest that either source map generation is disabled OR that the sourcemaps.assets glob pattern might not be matching any files that have source maps. This would guide the user to check both their bundler configuration and their plugin configuration.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not valid. Location: packages/bundler-plugins/src/core/build-plugin-manager.ts#L710-L717 Potential issue: The warning logged when no source maps are found for upload is misleading. The code checks if the temporary upload folder is empty (`files.length === 0`) and, if so, logs that "source map generation is not enabled". However, this folder can also be empty when the `sourcemaps.assets` glob pattern correctly matches files that legitimately do not have source maps, such as framework stubs. This can misdirect users into debugging their bundler configuration when the actual issue is a misconfigured glob pattern that only includes sourcemap-less chunks.
_{Did we get this right? 👍 / 👎 to inform future reviews.}

Prevent potentially large number of noisy warnings that by design never emit sourcemaps. For example: ``` ~/b0f41f6b-e36f-409b-817f-921f7d295a7b-155.js (no sourcemap found, debug id b0f41f6b-...) - warning: could not determine a source map reference (Could not auto-detect referenced sourcemap for ~/b0f41f6b-...-155.js) ``` This cannot be safely avoided using the file path glob approach, as seen in #18938, because the file paths in question here (uuids and alphanumeric hashes) can't be guaranteed to _never_ hold user code as seen in the cases covered by #18938. Instead, when no symbolication can be performed because the chunk is a stub without any sourcemap, downgrade the warning to a debug log. fix: #22199 fix: JS-3006

github-actions · 2026-07-17T10:36:34Z

👋 @chargome — Please review this PR when you get a chance!

chargome

LGTM did you test this in a real-world nextjs app too?

isaacs · 2026-07-27T15:31:04Z

@chargome

LGTM did you test this in a real-world nextjs app too?

I did. It does prevent the excessive logs in the case the user reported (they're still there in debug mode).

isaacs · 2026-07-14T19:42:53Z

Prevent potentially large number of noisy warnings that by design never emit sourcemaps.

For example:

~/b0f41f6b-e36f-409b-817f-921f7d295a7b-155.js (no sourcemap found, debug id b0f41f6b-...)
- warning: could not determine a source map reference (Could not auto-detect referenced sourcemap for ~/b0f41f6b-...-155.js)

This cannot be safely avoided using the file path glob approach, as seen in #18938, because the file paths in question here (uuids and alphanumeric hashes) can't be guaranteed to never hold user code as seen in the cases covered by #18938.

Instead, when no symbolication can be performed because the chunk is a stub without any sourcemap, downgrade the warning to a debug log.

fix: #22199
fix: #22199

linear-code · 2026-07-14T19:42:56Z

JS-3006

timfish · 2026-07-14T19:49:03Z

This warning highlighted to users if they don't have sourcemaps enabled. After these changes is this still some kind of warning in this case?

isaacs · 2026-07-15T00:59:27Z

This warning highlighted to users if they don't have sourcemaps enabled. After these changes is this still some kind of warning in this case?

Ah, yes, that would be bad, whoops. Good catch.

I think we can still resolve this, though, by moving the warning up a level, to the manager instead of on the per-file level. Fixed on bfc2b32

timfish · 2026-07-15T01:44:59Z

The test failures suggest that this change results in the sourcemap cli command no longer running when there are no sourcemaps. I guess this is preferable but I don't fully understand the consequences!

sentry · 2026-07-15T04:09:06Z

+ if (files.length === 0) {
+ logger.warn(
+ `No source maps found for any of the ${debugIdChunkFilePaths.length} matched build ` +
+ 'artifacts, so no source maps were uploaded to Sentry. This usually means source map ' +
+ 'generation is not enabled in your bundler. Enable it so Sentry can un-minify your stack traces.',
+ );
+ return;
+ }


Bug: The warning for no source maps being found is misleading. It assumes source map generation is disabled, but it could also mean the asset glob only matched chunks without source maps.
_{Severity: LOW}
Suggested Fix
The warning message should be more nuanced. Instead of definitively stating that source map generation is disabled, it should suggest that either source map generation is disabled OR that the sourcemaps.assets glob pattern might not be matching any files that have source maps. This would guide the user to check both their bundler configuration and their plugin configuration.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not valid. Location: packages/bundler-plugins/src/core/build-plugin-manager.ts#L710-L717 Potential issue: The warning logged when no source maps are found for upload is misleading. The code checks if the temporary upload folder is empty (`files.length === 0`) and, if so, logs that "source map generation is not enabled". However, this folder can also be empty when the `sourcemaps.assets` glob pattern correctly matches files that legitimately do not have source maps, such as framework stubs. This can misdirect users into debugging their bundler configuration when the actual issue is a misconfigured glob pattern that only includes sourcemap-less chunks.
_{Did we get this right? 👍 / 👎 to inform future reviews.}

Prevent potentially large number of noisy warnings that by design never emit sourcemaps. For example: ``` ~/b0f41f6b-e36f-409b-817f-921f7d295a7b-155.js (no sourcemap found, debug id b0f41f6b-...) - warning: could not determine a source map reference (Could not auto-detect referenced sourcemap for ~/b0f41f6b-...-155.js) ``` This cannot be safely avoided using the file path glob approach, as seen in #18938, because the file paths in question here (uuids and alphanumeric hashes) can't be guaranteed to _never_ hold user code as seen in the cases covered by #18938. Instead, when no symbolication can be performed because the chunk is a stub without any sourcemap, downgrade the warning to a debug log. fix: #22199 fix: JS-3006

github-actions · 2026-07-17T10:36:34Z

👋 @chargome — Please review this PR when you get a chance!

chargome

LGTM did you test this in a real-world nextjs app too?

isaacs · 2026-07-27T15:31:04Z

@chargome

LGTM did you test this in a real-world nextjs app too?

I did. It does prevent the excessive logs in the case the user reported (they're still there in debug mode).

isaacs · 2026-07-14T19:42:53Z

Prevent potentially large number of noisy warnings that by design never emit sourcemaps.

For example:

~/b0f41f6b-e36f-409b-817f-921f7d295a7b-155.js (no sourcemap found, debug id b0f41f6b-...)
- warning: could not determine a source map reference (Could not auto-detect referenced sourcemap for ~/b0f41f6b-...-155.js)

This cannot be safely avoided using the file path glob approach, as seen in #18938, because the file paths in question here (uuids and alphanumeric hashes) can't be guaranteed to never hold user code as seen in the cases covered by #18938.

Instead, when no symbolication can be performed because the chunk is a stub without any sourcemap, downgrade the warning to a debug log.

fix: #22199
fix: #22199

linear-code · 2026-07-14T19:42:56Z

JS-3006

timfish · 2026-07-14T19:49:03Z

This warning highlighted to users if they don't have sourcemaps enabled. After these changes is this still some kind of warning in this case?

isaacs · 2026-07-15T00:59:27Z

This warning highlighted to users if they don't have sourcemaps enabled. After these changes is this still some kind of warning in this case?

Ah, yes, that would be bad, whoops. Good catch.

I think we can still resolve this, though, by moving the warning up a level, to the manager instead of on the per-file level. Fixed on bfc2b32

timfish · 2026-07-15T01:44:59Z

The test failures suggest that this change results in the sourcemap cli command no longer running when there are no sourcemaps. I guess this is preferable but I don't fully understand the consequences!

sentry · 2026-07-15T04:09:06Z

+ if (files.length === 0) {
+ logger.warn(
+ `No source maps found for any of the ${debugIdChunkFilePaths.length} matched build ` +
+ 'artifacts, so no source maps were uploaded to Sentry. This usually means source map ' +
+ 'generation is not enabled in your bundler. Enable it so Sentry can un-minify your stack traces.',
+ );
+ return;
+ }


Bug: The warning for no source maps being found is misleading. It assumes source map generation is disabled, but it could also mean the asset glob only matched chunks without source maps.
_{Severity: LOW}
Suggested Fix
The warning message should be more nuanced. Instead of definitively stating that source map generation is disabled, it should suggest that either source map generation is disabled OR that the sourcemaps.assets glob pattern might not be matching any files that have source maps. This would guide the user to check both their bundler configuration and their plugin configuration.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not valid. Location: packages/bundler-plugins/src/core/build-plugin-manager.ts#L710-L717 Potential issue: The warning logged when no source maps are found for upload is misleading. The code checks if the temporary upload folder is empty (`files.length === 0`) and, if so, logs that "source map generation is not enabled". However, this folder can also be empty when the `sourcemaps.assets` glob pattern correctly matches files that legitimately do not have source maps, such as framework stubs. This can misdirect users into debugging their bundler configuration when the actual issue is a misconfigured glob pattern that only includes sourcemap-less chunks.
_{Did we get this right? 👍 / 👎 to inform future reviews.}

Prevent potentially large number of noisy warnings that by design never emit sourcemaps. For example: ``` ~/b0f41f6b-e36f-409b-817f-921f7d295a7b-155.js (no sourcemap found, debug id b0f41f6b-...) - warning: could not determine a source map reference (Could not auto-detect referenced sourcemap for ~/b0f41f6b-...-155.js) ``` This cannot be safely avoided using the file path glob approach, as seen in #18938, because the file paths in question here (uuids and alphanumeric hashes) can't be guaranteed to _never_ hold user code as seen in the cases covered by #18938. Instead, when no symbolication can be performed because the chunk is a stub without any sourcemap, downgrade the warning to a debug log. fix: #22199 fix: JS-3006

github-actions · 2026-07-17T10:36:34Z

👋 @chargome — Please review this PR when you get a chance!

chargome

LGTM did you test this in a real-world nextjs app too?

isaacs · 2026-07-27T15:31:04Z

@chargome

LGTM did you test this in a real-world nextjs app too?

I did. It does prevent the excessive logs in the case the user reported (they're still there in debug mode).

isaacs · 2026-07-14T19:42:53Z

Prevent potentially large number of noisy warnings that by design never emit sourcemaps.

For example:

~/b0f41f6b-e36f-409b-817f-921f7d295a7b-155.js (no sourcemap found, debug id b0f41f6b-...)
- warning: could not determine a source map reference (Could not auto-detect referenced sourcemap for ~/b0f41f6b-...-155.js)

This cannot be safely avoided using the file path glob approach, as seen in #18938, because the file paths in question here (uuids and alphanumeric hashes) can't be guaranteed to never hold user code as seen in the cases covered by #18938.

Instead, when no symbolication can be performed because the chunk is a stub without any sourcemap, downgrade the warning to a debug log.

fix: #22199
fix: #22199

linear-code · 2026-07-14T19:42:56Z

JS-3006

timfish · 2026-07-14T19:49:03Z

This warning highlighted to users if they don't have sourcemaps enabled. After these changes is this still some kind of warning in this case?

isaacs · 2026-07-15T00:59:27Z

This warning highlighted to users if they don't have sourcemaps enabled. After these changes is this still some kind of warning in this case?

Ah, yes, that would be bad, whoops. Good catch.

I think we can still resolve this, though, by moving the warning up a level, to the manager instead of on the per-file level. Fixed on bfc2b32

timfish · 2026-07-15T01:44:59Z

The test failures suggest that this change results in the sourcemap cli command no longer running when there are no sourcemaps. I guess this is preferable but I don't fully understand the consequences!

sentry · 2026-07-15T04:09:06Z

+ if (files.length === 0) {
+ logger.warn(
+ `No source maps found for any of the ${debugIdChunkFilePaths.length} matched build ` +
+ 'artifacts, so no source maps were uploaded to Sentry. This usually means source map ' +
+ 'generation is not enabled in your bundler. Enable it so Sentry can un-minify your stack traces.',
+ );
+ return;
+ }


Bug: The warning for no source maps being found is misleading. It assumes source map generation is disabled, but it could also mean the asset glob only matched chunks without source maps.
_{Severity: LOW}
Suggested Fix
The warning message should be more nuanced. Instead of definitively stating that source map generation is disabled, it should suggest that either source map generation is disabled OR that the sourcemaps.assets glob pattern might not be matching any files that have source maps. This would guide the user to check both their bundler configuration and their plugin configuration.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not valid. Location: packages/bundler-plugins/src/core/build-plugin-manager.ts#L710-L717 Potential issue: The warning logged when no source maps are found for upload is misleading. The code checks if the temporary upload folder is empty (`files.length === 0`) and, if so, logs that "source map generation is not enabled". However, this folder can also be empty when the `sourcemaps.assets` glob pattern correctly matches files that legitimately do not have source maps, such as framework stubs. This can misdirect users into debugging their bundler configuration when the actual issue is a misconfigured glob pattern that only includes sourcemap-less chunks.
_{Did we get this right? 👍 / 👎 to inform future reviews.}

Prevent potentially large number of noisy warnings that by design never emit sourcemaps. For example: ``` ~/b0f41f6b-e36f-409b-817f-921f7d295a7b-155.js (no sourcemap found, debug id b0f41f6b-...) - warning: could not determine a source map reference (Could not auto-detect referenced sourcemap for ~/b0f41f6b-...-155.js) ``` This cannot be safely avoided using the file path glob approach, as seen in #18938, because the file paths in question here (uuids and alphanumeric hashes) can't be guaranteed to _never_ hold user code as seen in the cases covered by #18938. Instead, when no symbolication can be performed because the chunk is a stub without any sourcemap, downgrade the warning to a debug log. fix: #22199 fix: JS-3006

github-actions · 2026-07-17T10:36:34Z

👋 @chargome — Please review this PR when you get a chance!

chargome

LGTM did you test this in a real-world nextjs app too?

isaacs · 2026-07-27T15:31:04Z

@chargome

LGTM did you test this in a real-world nextjs app too?

I did. It does prevent the excessive logs in the case the user reported (they're still there in debug mode).

isaacs · 2026-07-14T19:42:53Z

Prevent potentially large number of noisy warnings that by design never emit sourcemaps.

For example:

~/b0f41f6b-e36f-409b-817f-921f7d295a7b-155.js (no sourcemap found, debug id b0f41f6b-...)
- warning: could not determine a source map reference (Could not auto-detect referenced sourcemap for ~/b0f41f6b-...-155.js)

This cannot be safely avoided using the file path glob approach, as seen in #18938, because the file paths in question here (uuids and alphanumeric hashes) can't be guaranteed to never hold user code as seen in the cases covered by #18938.

Instead, when no symbolication can be performed because the chunk is a stub without any sourcemap, downgrade the warning to a debug log.

fix: #22199
fix: #22199

linear-code · 2026-07-14T19:42:56Z

JS-3006

timfish · 2026-07-14T19:49:03Z

This warning highlighted to users if they don't have sourcemaps enabled. After these changes is this still some kind of warning in this case?

isaacs · 2026-07-15T00:59:27Z

This warning highlighted to users if they don't have sourcemaps enabled. After these changes is this still some kind of warning in this case?

Ah, yes, that would be bad, whoops. Good catch.

I think we can still resolve this, though, by moving the warning up a level, to the manager instead of on the per-file level. Fixed on bfc2b32

timfish · 2026-07-15T01:44:59Z

The test failures suggest that this change results in the sourcemap cli command no longer running when there are no sourcemaps. I guess this is preferable but I don't fully understand the consequences!

sentry · 2026-07-15T04:09:06Z

+ if (files.length === 0) {
+ logger.warn(
+ `No source maps found for any of the ${debugIdChunkFilePaths.length} matched build ` +
+ 'artifacts, so no source maps were uploaded to Sentry. This usually means source map ' +
+ 'generation is not enabled in your bundler. Enable it so Sentry can un-minify your stack traces.',
+ );
+ return;
+ }


Bug: The warning for no source maps being found is misleading. It assumes source map generation is disabled, but it could also mean the asset glob only matched chunks without source maps.
_{Severity: LOW}
Suggested Fix
The warning message should be more nuanced. Instead of definitively stating that source map generation is disabled, it should suggest that either source map generation is disabled OR that the sourcemaps.assets glob pattern might not be matching any files that have source maps. This would guide the user to check both their bundler configuration and their plugin configuration.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not valid. Location: packages/bundler-plugins/src/core/build-plugin-manager.ts#L710-L717 Potential issue: The warning logged when no source maps are found for upload is misleading. The code checks if the temporary upload folder is empty (`files.length === 0`) and, if so, logs that "source map generation is not enabled". However, this folder can also be empty when the `sourcemaps.assets` glob pattern correctly matches files that legitimately do not have source maps, such as framework stubs. This can misdirect users into debugging their bundler configuration when the actual issue is a misconfigured glob pattern that only includes sourcemap-less chunks.
_{Did we get this right? 👍 / 👎 to inform future reviews.}

Prevent potentially large number of noisy warnings that by design never emit sourcemaps. For example: ``` ~/b0f41f6b-e36f-409b-817f-921f7d295a7b-155.js (no sourcemap found, debug id b0f41f6b-...) - warning: could not determine a source map reference (Could not auto-detect referenced sourcemap for ~/b0f41f6b-...-155.js) ``` This cannot be safely avoided using the file path glob approach, as seen in #18938, because the file paths in question here (uuids and alphanumeric hashes) can't be guaranteed to _never_ hold user code as seen in the cases covered by #18938. Instead, when no symbolication can be performed because the chunk is a stub without any sourcemap, downgrade the warning to a debug log. fix: #22199 fix: JS-3006

github-actions · 2026-07-17T10:36:34Z

👋 @chargome — Please review this PR when you get a chance!

chargome

LGTM did you test this in a real-world nextjs app too?

isaacs · 2026-07-27T15:31:04Z

@chargome

LGTM did you test this in a real-world nextjs app too?

I did. It does prevent the excessive logs in the case the user reported (they're still there in debug mode).

isaacs requested review from chargome and timfish July 14, 2026 19:42

sentryBot reviewed Jul 15, 2026
View reviewed changes

isaacs added 2 commits July 15, 2026 11:20

fixup! fix(bundler-plugins): do not warn on known sourcemap-less chunks
9ed5e0b

isaacs force-pushed the isaacs/fix-22199-reduce-warning-on-empty-chunks branch from bfc2b32 to 9ed5e0bCompare July 15, 2026 18:20

timfish approved these changes Jul 21, 2026
View reviewed changes

chargome approved these changes Jul 24, 2026
View reviewed changes

isaacs merged commit 32c5db9 into developJul 27, 2026
51 checks passed

isaacs deleted the isaacs/fix-22199-reduce-warning-on-empty-chunks branch July 27, 2026 15:31

isaacs requested review from chargome and timfish July 14, 2026 19:42

sentryBot reviewed Jul 15, 2026
View reviewed changes

isaacs added 2 commits July 15, 2026 11:20

fixup! fix(bundler-plugins): do not warn on known sourcemap-less chunks
9ed5e0b

isaacs force-pushed the isaacs/fix-22199-reduce-warning-on-empty-chunks branch from bfc2b32 to 9ed5e0bCompare July 15, 2026 18:20

timfish approved these changes Jul 21, 2026
View reviewed changes

chargome approved these changes Jul 24, 2026
View reviewed changes

isaacs merged commit 32c5db9 into developJul 27, 2026
51 checks passed

isaacs deleted the isaacs/fix-22199-reduce-warning-on-empty-chunks branch July 27, 2026 15:31

isaacs requested review from chargome and timfish July 14, 2026 19:42

sentryBot reviewed Jul 15, 2026
View reviewed changes

isaacs added 2 commits July 15, 2026 11:20

fixup! fix(bundler-plugins): do not warn on known sourcemap-less chunks
9ed5e0b

isaacs force-pushed the isaacs/fix-22199-reduce-warning-on-empty-chunks branch from bfc2b32 to 9ed5e0bCompare July 15, 2026 18:20

timfish approved these changes Jul 21, 2026
View reviewed changes

chargome approved these changes Jul 24, 2026
View reviewed changes

isaacs merged commit 32c5db9 into developJul 27, 2026
51 checks passed

isaacs deleted the isaacs/fix-22199-reduce-warning-on-empty-chunks branch July 27, 2026 15:31

isaacs requested review from chargome and timfish July 14, 2026 19:42

sentryBot reviewed Jul 15, 2026
View reviewed changes

isaacs added 2 commits July 15, 2026 11:20

fixup! fix(bundler-plugins): do not warn on known sourcemap-less chunks
9ed5e0b

isaacs force-pushed the isaacs/fix-22199-reduce-warning-on-empty-chunks branch from bfc2b32 to 9ed5e0bCompare July 15, 2026 18:20

timfish approved these changes Jul 21, 2026
View reviewed changes

chargome approved these changes Jul 24, 2026
View reviewed changes

isaacs merged commit 32c5db9 into developJul 27, 2026
51 checks passed

isaacs deleted the isaacs/fix-22199-reduce-warning-on-empty-chunks branch July 27, 2026 15:31

isaacs requested review from chargome and timfish July 14, 2026 19:42

sentryBot reviewed Jul 15, 2026
View reviewed changes

isaacs added 2 commits July 15, 2026 11:20

fixup! fix(bundler-plugins): do not warn on known sourcemap-less chunks
9ed5e0b

isaacs force-pushed the isaacs/fix-22199-reduce-warning-on-empty-chunks branch from bfc2b32 to 9ed5e0bCompare July 15, 2026 18:20

timfish approved these changes Jul 21, 2026
View reviewed changes

chargome approved these changes Jul 24, 2026
View reviewed changes

isaacs merged commit 32c5db9 into developJul 27, 2026
51 checks passed

isaacs deleted the isaacs/fix-22199-reduce-warning-on-empty-chunks branch July 27, 2026 15:31

isaacs requested review from chargome and timfish July 14, 2026 19:42

sentryBot reviewed Jul 15, 2026
View reviewed changes

isaacs added 2 commits July 15, 2026 11:20

fixup! fix(bundler-plugins): do not warn on known sourcemap-less chunks
9ed5e0b

isaacs force-pushed the isaacs/fix-22199-reduce-warning-on-empty-chunks branch from bfc2b32 to 9ed5e0bCompare July 15, 2026 18:20

timfish approved these changes Jul 21, 2026
View reviewed changes

chargome approved these changes Jul 24, 2026
View reviewed changes

isaacs merged commit 32c5db9 into developJul 27, 2026
51 checks passed

isaacs deleted the isaacs/fix-22199-reduce-warning-on-empty-chunks branch July 27, 2026 15:31

isaacs requested review from chargome and timfish July 14, 2026 19:42

sentryBot reviewed Jul 15, 2026
View reviewed changes

isaacs added 2 commits July 15, 2026 11:20

fixup! fix(bundler-plugins): do not warn on known sourcemap-less chunks
9ed5e0b

isaacs force-pushed the isaacs/fix-22199-reduce-warning-on-empty-chunks branch from bfc2b32 to 9ed5e0bCompare July 15, 2026 18:20

timfish approved these changes Jul 21, 2026
View reviewed changes

chargome approved these changes Jul 24, 2026
View reviewed changes

isaacs merged commit 32c5db9 into developJul 27, 2026
51 checks passed

isaacs deleted the isaacs/fix-22199-reduce-warning-on-empty-chunks branch July 27, 2026 15:31

isaacs requested review from chargome and timfish July 14, 2026 19:42

sentryBot reviewed Jul 15, 2026
View reviewed changes

isaacs added 2 commits July 15, 2026 11:20

fixup! fix(bundler-plugins): do not warn on known sourcemap-less chunks
9ed5e0b

isaacs force-pushed the isaacs/fix-22199-reduce-warning-on-empty-chunks branch from bfc2b32 to 9ed5e0bCompare July 15, 2026 18:20

timfish approved these changes Jul 21, 2026
View reviewed changes

chargome approved these changes Jul 24, 2026
View reviewed changes

isaacs merged commit 32c5db9 into developJul 27, 2026
51 checks passed

isaacs deleted the isaacs/fix-22199-reduce-warning-on-empty-chunks branch July 27, 2026 15:31

Uh oh!

Uh oh!

Conversation

isaacs commented Jul 14, 2026• edited by chargome Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linear-codeBot commented Jul 14, 2026

Uh oh!

timfish commented Jul 14, 2026

Uh oh!

isaacs commented Jul 15, 2026

Uh oh!

timfish commented Jul 15, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sentryBotJul 15, 2026

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Jul 17, 2026

Uh oh!

chargome left a comment

Choose a reason for hiding this comment

Uh oh!

isaacs commented Jul 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

isaacs commented Jul 14, 2026• edited by chargome Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linear-codeBot commented Jul 14, 2026

Uh oh!

timfish commented Jul 14, 2026

Uh oh!

isaacs commented Jul 15, 2026

Uh oh!

timfish commented Jul 15, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sentryBotJul 15, 2026

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Jul 17, 2026

Uh oh!

chargome left a comment

Choose a reason for hiding this comment

Uh oh!

isaacs commented Jul 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

isaacs commented Jul 14, 2026• edited by chargome Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linear-codeBot commented Jul 14, 2026

Uh oh!

timfish commented Jul 14, 2026

Uh oh!

isaacs commented Jul 15, 2026

Uh oh!

isaacs commented Jul 14, 2026•
edited by chargome
Loading

timfish commented Jul 15, 2026•
edited
Loading

isaacs commented Jul 14, 2026•
edited by chargome
Loading

timfish commented Jul 15, 2026•
edited
Loading

isaacs commented Jul 14, 2026•
edited by chargome
Loading

timfish commented Jul 15, 2026•
edited
Loading

isaacs commented Jul 14, 2026•
edited by chargome
Loading

timfish commented Jul 15, 2026•
edited
Loading