Uh oh!
There was an error while loading. Please reload this page.
feat(server-utils): Capture and log orchestrion stats - #22269
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
size-limit report 📦
|
Uh oh!
There was an error while loading. Please reload this page.
| * orchestrion bundler plugin. | ||
| * | ||
| * `injectDiagnostics` sets `globalThis.__SENTRY_ORCHESTRION__.bundler = true` at | ||
| * `injectDiagnostics` sets `globalThis.__SENTRY_ORCHESTRION__.bundler = ["mysql"]` at |
| // Already injected (runtime --import hook or bundler plugin) — nothing to do. | ||
| if (g.runtime) { | ||
| if (GLOBAL_OBJ?.__SENTRY_ORCHESTRION__?.runtime) { |
There was a problem hiding this comment.
m: Shouldn't this be the following?
| if(GLOBAL_OBJ?.__SENTRY_ORCHESTRION__?.runtime){ | |
| if(!!GLOBAL_OBJ?.__SENTRY_ORCHESTRION__?.runtime.length){ |
There was a problem hiding this comment.
No, an empty array signifies that the the hooks have been setup:
| '(mysql, …) will not record spans. Make sure the diagnostics channels are injected ' + | ||
| 'via the runtime `--import` hook or a bundler plugin before the instrumented modules load.', | ||
| ); | ||
| if (!runtime && !bundler) { |
There was a problem hiding this comment.
l/m: Also here. We should check for the array length, right?
There was a problem hiding this comment.
If either of these are defined, we will hit the debug logging below with more details for each.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This PR:
debug: true