Uh oh!
There was an error while loading. Please reload this page.
fix(server-utils): Dedupe ioredis orchestrion span for offline-queued commands - #22279
Merged
Merged
Conversation
Contributor
size-limit report 📦
|
chargome
commented
Jul 15, 2026
MemberAuthor
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit fe8d7b2. Configure here.
chargome
marked this pull request as ready for review
July 15, 2026 09:39
chargome
requested review from
logaretm, mydea and nicohrubec
and removed request for
a teamJuly 15, 2026 09:39
nicohrubec
approved these changes
Jul 15, 2026
| // Each command maps to exactly one span (no offline-queue duplicate). | ||
| const setSpans = spans.filter(span => span.description === 'set test-key [1 other arguments]'); | ||
| expect(setSpans).toHaveLength(1); |
Member
There was a problem hiding this comment.
does this already trigger this case?
| waitForTracingChannelBinding(() => { | ||
| bindTracingChannelToSpan( | ||
| commandChannel, | ||
| data => { |
Member
There was a problem hiding this comment.
all of this is just refactored to startIORedisCommandSpan right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Offline commands that were drained on connect produced duplicated spans, which we now prevent by just deduping in a
WeakSet.Saw this when testing locally, this was not catched by e2e before.