Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(node): Only setup orchestrion channel listeners when needed#22312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
0c6362f889bd692e61a246a50634b05054679dd729b23198a946e8417e5f38395a95a5File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -44,7 +44,7 @@ import { | ||
| } from '@sentry/server-utils/orchestrion/config'; | ||
| const BUNDLER_MARKER_BANNER = | ||
| ';(globalThis.__SENTRY_ORCHESTRION__=(globalThis.__SENTRY_ORCHESTRION__||{})).bundler=true;'; | ||
| ';(globalThis.__SENTRY_ORCHESTRION__=(globalThis.__SENTRY_ORCHESTRION__||{})).bundler=[];'; | ||
cursor[bot] marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| // Minimal shape of Bun's `PluginBuilder` that we touch. Typed locally instead | ||
| // of depending on `bun-types`, which would pull Bun's globals. | ||
| @@ -57,7 +57,7 @@ interface BunPluginBuilder { | ||
| * with the central `SENTRY_INSTRUMENTATIONS`. The plugin injects | ||
| * `diagnostics_channel.tracingChannel` calls into the instrumented libraries as | ||
| * `bun build` bundles them, and injects a banner that sets | ||
| * `globalThis.__SENTRY_ORCHESTRION__.bundler = true` when the bundle boots | ||
| * `globalThis.__SENTRY_ORCHESTRION__.bundler = []` when the bundle boots | ||
| * | ||
| * Pass the result to `Bun.build({ plugins: [...] })`. | ||
| * | ||
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @isaacs do we actually need this? Can we properly inject this with the correct modules somehow?