Uh oh!
There was an error while loading. Please reload this page.
test(cloudflare): Proof that AI providers work OOTB on Cloudflare - #22313
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 10d6264. Configure here.
| [GEN_AI_USAGE_INPUT_TOKENS_ATTRIBUTE]: { value: 10, type: 'integer' }, | ||
| [GEN_AI_USAGE_OUTPUT_TOKENS_ATTRIBUTE]: { value: 15, type: 'integer' }, | ||
| [GEN_AI_USAGE_TOTAL_TOKENS_ATTRIBUTE]: { value: 25, type: 'integer' }, | ||
| }, |
There was a problem hiding this comment.
Broken exact span assertions
High Severity
The new exact toEqual checks on streamed AI spans only list gen-ai attributes. Streamed spans also get common fields from applyCommonSpanAttributes (sentry.trace.lifecycle, sentry.segment.*, sentry.sdk.*, sentry.release, sentry.environment), so these assertions fail. The langchain suite has the same issue.
Additional Locations (2)
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 10d6264. Configure here.
| const url = typeof input === 'string' ? input : input instanceof URL ? input.href : input.url; | ||
| const client: GoogleGenAIClient = Sentry.instrumentGoogleGenAIClient(mockClient); | ||
| if (!url.includes('generativelanguage.googleapis.com')) { |
Lms24
left a comment
There was a problem hiding this comment.
Good change! This much more respects the "integration" in "integration tests" :D
10d6264 to
75f5b8aCompareUh oh!
There was an error while loading. Please reload this page.
The Cloudflare integration tests were already testing all AI integrations, but used mocks.
I changed the following in all tests:
mocks.tsand changed it to the actual package.fetchis being mocked