fix(serve-rutils): Orchestrion diagnostics for async and require - #22327

Merged
timfish merged 2 commits into
developfrom
timfish/fix/orchestrion-diagnostics
Jul 16, 2026
Merged

fix(serve-rutils): Orchestrion diagnostics for async and require#22327
timfish merged 2 commits into
developfrom
timfish/fix/orchestrion-diagnostics

Conversation

@timfish

@timfishtimfish commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

This PR fixes some issues with capturing runtime orchestrion diagnostics:

  • Handles and logs errors!
  • Configures the hook for the async loader and require hook

Notes:

  • This is all really nasty and can be reduced considerably when we drop support for Node without require(esm).
  • We have to block registerDiagnosticsChannelInjection from running on the loader thread or it crashes!
  • I dropped all the usage of DEBUG_BUILD because this code is all server side and we want these to always be captured when debug: true. Probably worth adjusting the ai prompt to reflect this!

@timfish
timfish requested a review from a team as a code ownerJuly 16, 2026 13:17
@timfish
timfish requested review from isaacs, mydea, s1gr1d and stephanie-anderson and removed request for a teamJuly 16, 2026 13:17
cursor[bot]

This comment was marked as outdated.

@github-actions

github-actionsBot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser27.74 kB--
@sentry/browser - with treeshaking flags26.19 kB--
@sentry/browser (incl. Tracing)46.57 kB--
@sentry/browser (incl. Tracing + Span Streaming)48.36 kB--
@sentry/browser (incl. Tracing, Profiling)51.34 kB--
@sentry/browser (incl. Tracing, Replay)85.83 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags75.46 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)90.55 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)103.18 kB--
@sentry/browser (incl. Feedback)44.92 kB--
@sentry/browser (incl. sendFeedback)32.54 kB--
@sentry/browser (incl. FeedbackAsync)37.67 kB--
@sentry/browser (incl. Metrics)28.84 kB--
@sentry/browser (incl. Logs)29.07 kB--
@sentry/browser (incl. Metrics & Logs)29.76 kB--
@sentry/react29.54 kB--
@sentry/react (incl. Tracing)48.82 kB--
@sentry/vue33.17 kB--
@sentry/vue (incl. Tracing)48.55 kB--
@sentry/svelte27.77 kB--
CDN Bundle30.14 kB--
CDN Bundle (incl. Tracing)48.52 kB--
CDN Bundle (incl. Logs, Metrics)31.72 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.83 kB--
CDN Bundle (incl. Replay, Logs, Metrics)70.97 kB--
CDN Bundle (incl. Tracing, Replay)86.04 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)87.33 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)91.82 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)93.09 kB--
CDN Bundle - uncompressed89.85 kB--
CDN Bundle (incl. Tracing) - uncompressed146.66 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed94.56 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed150.64 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed219.28 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed265.86 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed269.82 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed279.56 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed283.52 kB--
@sentry/nextjs (client)51.38 kB--
@sentry/sveltekit (client)47 kB--
@sentry/core/server78.63 kB--
@sentry/core/browser64.99 kB--
@sentry/node-core63.21 kB-0.01%-1 B 🔽
@sentry/node125.45 kB--
@sentry/node (incl. diagnostics channel injection)141.28 kB+0.08%+111 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection)70.03 kB+0.01%+2 B 🔺
@sentry/node/light51.33 kB--
@sentry/node - without tracing74.7 kB--
@sentry/aws-serverless83.92 kB--
@sentry/cloudflare (withSentry) - minified182.1 kB--
@sentry/cloudflare (withSentry)450.9 kB--

View base workflow run

@mydeamydea changed the title fix: Orchestrion diagnostics for async and requirefix(serve-rutils): Orchestrion diagnostics for async and requireJul 16, 2026
@timfish
timfish merged commit e0865f9 into developJul 16, 2026
226 checks passed
@timfish
timfish deleted the timfish/fix/orchestrion-diagnostics branch July 16, 2026 15:26
timfish added a commit that referenced this pull request Jul 16, 2026
I missed this commit off of #22327.
This ensure that we only skip registering the hooks on the loader thread
which means Sentry in a worker thread can still hook loading.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@timfish@mydea
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

fix(serve-rutils): Orchestrion diagnostics for async and require - #22327

Merged
timfish merged 2 commits into
developfrom
timfish/fix/orchestrion-diagnostics
Jul 16, 2026
Merged

fix(serve-rutils): Orchestrion diagnostics for async and require#22327
timfish merged 2 commits into
developfrom
timfish/fix/orchestrion-diagnostics

Conversation

@timfish

@timfishtimfish commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

This PR fixes some issues with capturing runtime orchestrion diagnostics:

  • Handles and logs errors!
  • Configures the hook for the async loader and require hook

Notes:

  • This is all really nasty and can be reduced considerably when we drop support for Node without require(esm).
  • We have to block registerDiagnosticsChannelInjection from running on the loader thread or it crashes!
  • I dropped all the usage of DEBUG_BUILD because this code is all server side and we want these to always be captured when debug: true. Probably worth adjusting the ai prompt to reflect this!

@timfish
timfish requested a review from a team as a code ownerJuly 16, 2026 13:17
@timfish
timfish requested review from isaacs, mydea, s1gr1d and stephanie-anderson and removed request for a teamJuly 16, 2026 13:17
cursor[bot]

This comment was marked as outdated.

@github-actions

github-actionsBot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser27.74 kB--
@sentry/browser - with treeshaking flags26.19 kB--
@sentry/browser (incl. Tracing)46.57 kB--
@sentry/browser (incl. Tracing + Span Streaming)48.36 kB--
@sentry/browser (incl. Tracing, Profiling)51.34 kB--
@sentry/browser (incl. Tracing, Replay)85.83 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags75.46 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)90.55 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)103.18 kB--
@sentry/browser (incl. Feedback)44.92 kB--
@sentry/browser (incl. sendFeedback)32.54 kB--
@sentry/browser (incl. FeedbackAsync)37.67 kB--
@sentry/browser (incl. Metrics)28.84 kB--
@sentry/browser (incl. Logs)29.07 kB--
@sentry/browser (incl. Metrics & Logs)29.76 kB--
@sentry/react29.54 kB--
@sentry/react (incl. Tracing)48.82 kB--
@sentry/vue33.17 kB--
@sentry/vue (incl. Tracing)48.55 kB--
@sentry/svelte27.77 kB--
CDN Bundle30.14 kB--
CDN Bundle (incl. Tracing)48.52 kB--
CDN Bundle (incl. Logs, Metrics)31.72 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.83 kB--
CDN Bundle (incl. Replay, Logs, Metrics)70.97 kB--
CDN Bundle (incl. Tracing, Replay)86.04 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)87.33 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)91.82 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)93.09 kB--
CDN Bundle - uncompressed89.85 kB--
CDN Bundle (incl. Tracing) - uncompressed146.66 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed94.56 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed150.64 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed219.28 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed265.86 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed269.82 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed279.56 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed283.52 kB--
@sentry/nextjs (client)51.38 kB--
@sentry/sveltekit (client)47 kB--
@sentry/core/server78.63 kB--
@sentry/core/browser64.99 kB--
@sentry/node-core63.21 kB-0.01%-1 B 🔽
@sentry/node125.45 kB--
@sentry/node (incl. diagnostics channel injection)141.28 kB+0.08%+111 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection)70.03 kB+0.01%+2 B 🔺
@sentry/node/light51.33 kB--
@sentry/node - without tracing74.7 kB--
@sentry/aws-serverless83.92 kB--
@sentry/cloudflare (withSentry) - minified182.1 kB--
@sentry/cloudflare (withSentry)450.9 kB--

View base workflow run

@mydeamydea changed the title fix: Orchestrion diagnostics for async and requirefix(serve-rutils): Orchestrion diagnostics for async and requireJul 16, 2026
@timfish
timfish merged commit e0865f9 into developJul 16, 2026
226 checks passed
@timfish
timfish deleted the timfish/fix/orchestrion-diagnostics branch July 16, 2026 15:26
timfish added a commit that referenced this pull request Jul 16, 2026
I missed this commit off of #22327.
This ensure that we only skip registering the hooks on the loader thread
which means Sentry in a worker thread can still hook loading.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@timfish@mydea
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(serve-rutils): Orchestrion diagnostics for async and require - #22327

Merged
timfish merged 2 commits into
developfrom
timfish/fix/orchestrion-diagnostics
Jul 16, 2026
Merged

fix(serve-rutils): Orchestrion diagnostics for async and require#22327
timfish merged 2 commits into
developfrom
timfish/fix/orchestrion-diagnostics

Conversation

@timfish

@timfishtimfish commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

This PR fixes some issues with capturing runtime orchestrion diagnostics:

  • Handles and logs errors!
  • Configures the hook for the async loader and require hook

Notes:

  • This is all really nasty and can be reduced considerably when we drop support for Node without require(esm).
  • We have to block registerDiagnosticsChannelInjection from running on the loader thread or it crashes!
  • I dropped all the usage of DEBUG_BUILD because this code is all server side and we want these to always be captured when debug: true. Probably worth adjusting the ai prompt to reflect this!

@timfish
timfish requested a review from a team as a code ownerJuly 16, 2026 13:17
@timfish
timfish requested review from isaacs, mydea, s1gr1d and stephanie-anderson and removed request for a teamJuly 16, 2026 13:17
cursor[bot]

This comment was marked as outdated.

@github-actions

github-actionsBot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser27.74 kB--
@sentry/browser - with treeshaking flags26.19 kB--
@sentry/browser (incl. Tracing)46.57 kB--
@sentry/browser (incl. Tracing + Span Streaming)48.36 kB--
@sentry/browser (incl. Tracing, Profiling)51.34 kB--
@sentry/browser (incl. Tracing, Replay)85.83 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags75.46 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)90.55 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)103.18 kB--
@sentry/browser (incl. Feedback)44.92 kB--
@sentry/browser (incl. sendFeedback)32.54 kB--
@sentry/browser (incl. FeedbackAsync)37.67 kB--
@sentry/browser (incl. Metrics)28.84 kB--
@sentry/browser (incl. Logs)29.07 kB--
@sentry/browser (incl. Metrics & Logs)29.76 kB--
@sentry/react29.54 kB--
@sentry/react (incl. Tracing)48.82 kB--
@sentry/vue33.17 kB--
@sentry/vue (incl. Tracing)48.55 kB--
@sentry/svelte27.77 kB--
CDN Bundle30.14 kB--
CDN Bundle (incl. Tracing)48.52 kB--
CDN Bundle (incl. Logs, Metrics)31.72 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.83 kB--
CDN Bundle (incl. Replay, Logs, Metrics)70.97 kB--
CDN Bundle (incl. Tracing, Replay)86.04 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)87.33 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)91.82 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)93.09 kB--
CDN Bundle - uncompressed89.85 kB--
CDN Bundle (incl. Tracing) - uncompressed146.66 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed94.56 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed150.64 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed219.28 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed265.86 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed269.82 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed279.56 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed283.52 kB--
@sentry/nextjs (client)51.38 kB--
@sentry/sveltekit (client)47 kB--
@sentry/core/server78.63 kB--
@sentry/core/browser64.99 kB--
@sentry/node-core63.21 kB-0.01%-1 B 🔽
@sentry/node125.45 kB--
@sentry/node (incl. diagnostics channel injection)141.28 kB+0.08%+111 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection)70.03 kB+0.01%+2 B 🔺
@sentry/node/light51.33 kB--
@sentry/node - without tracing74.7 kB--
@sentry/aws-serverless83.92 kB--
@sentry/cloudflare (withSentry) - minified182.1 kB--
@sentry/cloudflare (withSentry)450.9 kB--

View base workflow run

@mydeamydea changed the title fix: Orchestrion diagnostics for async and requirefix(serve-rutils): Orchestrion diagnostics for async and requireJul 16, 2026
@timfish
timfish merged commit e0865f9 into developJul 16, 2026
226 checks passed
@timfish
timfish deleted the timfish/fix/orchestrion-diagnostics branch July 16, 2026 15:26
timfish added a commit that referenced this pull request Jul 16, 2026
I missed this commit off of #22327.
This ensure that we only skip registering the hooks on the loader thread
which means Sentry in a worker thread can still hook loading.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@timfish@mydea
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(serve-rutils): Orchestrion diagnostics for async and require - #22327

Merged
timfish merged 2 commits into
developfrom
timfish/fix/orchestrion-diagnostics
Jul 16, 2026
Merged

fix(serve-rutils): Orchestrion diagnostics for async and require#22327
timfish merged 2 commits into
developfrom
timfish/fix/orchestrion-diagnostics

Conversation

@timfish

@timfishtimfish commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

This PR fixes some issues with capturing runtime orchestrion diagnostics:

  • Handles and logs errors!
  • Configures the hook for the async loader and require hook

Notes:

  • This is all really nasty and can be reduced considerably when we drop support for Node without require(esm).
  • We have to block registerDiagnosticsChannelInjection from running on the loader thread or it crashes!
  • I dropped all the usage of DEBUG_BUILD because this code is all server side and we want these to always be captured when debug: true. Probably worth adjusting the ai prompt to reflect this!

@timfish
timfish requested a review from a team as a code ownerJuly 16, 2026 13:17
@timfish
timfish requested review from isaacs, mydea, s1gr1d and stephanie-anderson and removed request for a teamJuly 16, 2026 13:17
cursor[bot]

This comment was marked as outdated.

@github-actions

github-actionsBot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser27.74 kB--
@sentry/browser - with treeshaking flags26.19 kB--
@sentry/browser (incl. Tracing)46.57 kB--
@sentry/browser (incl. Tracing + Span Streaming)48.36 kB--
@sentry/browser (incl. Tracing, Profiling)51.34 kB--
@sentry/browser (incl. Tracing, Replay)85.83 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags75.46 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)90.55 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)103.18 kB--
@sentry/browser (incl. Feedback)44.92 kB--
@sentry/browser (incl. sendFeedback)32.54 kB--
@sentry/browser (incl. FeedbackAsync)37.67 kB--
@sentry/browser (incl. Metrics)28.84 kB--
@sentry/browser (incl. Logs)29.07 kB--
@sentry/browser (incl. Metrics & Logs)29.76 kB--
@sentry/react29.54 kB--
@sentry/react (incl. Tracing)48.82 kB--
@sentry/vue33.17 kB--
@sentry/vue (incl. Tracing)48.55 kB--
@sentry/svelte27.77 kB--
CDN Bundle30.14 kB--
CDN Bundle (incl. Tracing)48.52 kB--
CDN Bundle (incl. Logs, Metrics)31.72 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.83 kB--
CDN Bundle (incl. Replay, Logs, Metrics)70.97 kB--
CDN Bundle (incl. Tracing, Replay)86.04 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)87.33 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)91.82 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)93.09 kB--
CDN Bundle - uncompressed89.85 kB--
CDN Bundle (incl. Tracing) - uncompressed146.66 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed94.56 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed150.64 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed219.28 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed265.86 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed269.82 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed279.56 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed283.52 kB--
@sentry/nextjs (client)51.38 kB--
@sentry/sveltekit (client)47 kB--
@sentry/core/server78.63 kB--
@sentry/core/browser64.99 kB--
@sentry/node-core63.21 kB-0.01%-1 B 🔽
@sentry/node125.45 kB--
@sentry/node (incl. diagnostics channel injection)141.28 kB+0.08%+111 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection)70.03 kB+0.01%+2 B 🔺
@sentry/node/light51.33 kB--
@sentry/node - without tracing74.7 kB--
@sentry/aws-serverless83.92 kB--
@sentry/cloudflare (withSentry) - minified182.1 kB--
@sentry/cloudflare (withSentry)450.9 kB--

View base workflow run

@mydeamydea changed the title fix: Orchestrion diagnostics for async and requirefix(serve-rutils): Orchestrion diagnostics for async and requireJul 16, 2026
@timfish
timfish merged commit e0865f9 into developJul 16, 2026
226 checks passed
@timfish
timfish deleted the timfish/fix/orchestrion-diagnostics branch July 16, 2026 15:26
timfish added a commit that referenced this pull request Jul 16, 2026
I missed this commit off of #22327.
This ensure that we only skip registering the hooks on the loader thread
which means Sentry in a worker thread can still hook loading.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@timfish@mydea
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

fix(serve-rutils): Orchestrion diagnostics for async and require - #22327

Merged
timfish merged 2 commits into
developfrom
timfish/fix/orchestrion-diagnostics
Jul 16, 2026
Merged

fix(serve-rutils): Orchestrion diagnostics for async and require#22327
timfish merged 2 commits into
developfrom
timfish/fix/orchestrion-diagnostics

Conversation

@timfish

@timfishtimfish commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

This PR fixes some issues with capturing runtime orchestrion diagnostics:

  • Handles and logs errors!
  • Configures the hook for the async loader and require hook

Notes:

  • This is all really nasty and can be reduced considerably when we drop support for Node without require(esm).
  • We have to block registerDiagnosticsChannelInjection from running on the loader thread or it crashes!
  • I dropped all the usage of DEBUG_BUILD because this code is all server side and we want these to always be captured when debug: true. Probably worth adjusting the ai prompt to reflect this!

@timfish
timfish requested a review from a team as a code ownerJuly 16, 2026 13:17
@timfish
timfish requested review from isaacs, mydea, s1gr1d and stephanie-anderson and removed request for a teamJuly 16, 2026 13:17
cursor[bot]

This comment was marked as outdated.

@github-actions

github-actionsBot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser27.74 kB--
@sentry/browser - with treeshaking flags26.19 kB--
@sentry/browser (incl. Tracing)46.57 kB--
@sentry/browser (incl. Tracing + Span Streaming)48.36 kB--
@sentry/browser (incl. Tracing, Profiling)51.34 kB--
@sentry/browser (incl. Tracing, Replay)85.83 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags75.46 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)90.55 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)103.18 kB--
@sentry/browser (incl. Feedback)44.92 kB--
@sentry/browser (incl. sendFeedback)32.54 kB--
@sentry/browser (incl. FeedbackAsync)37.67 kB--
@sentry/browser (incl. Metrics)28.84 kB--
@sentry/browser (incl. Logs)29.07 kB--
@sentry/browser (incl. Metrics & Logs)29.76 kB--
@sentry/react29.54 kB--
@sentry/react (incl. Tracing)48.82 kB--
@sentry/vue33.17 kB--
@sentry/vue (incl. Tracing)48.55 kB--
@sentry/svelte27.77 kB--
CDN Bundle30.14 kB--
CDN Bundle (incl. Tracing)48.52 kB--
CDN Bundle (incl. Logs, Metrics)31.72 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.83 kB--
CDN Bundle (incl. Replay, Logs, Metrics)70.97 kB--
CDN Bundle (incl. Tracing, Replay)86.04 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)87.33 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)91.82 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)93.09 kB--
CDN Bundle - uncompressed89.85 kB--
CDN Bundle (incl. Tracing) - uncompressed146.66 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed94.56 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed150.64 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed219.28 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed265.86 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed269.82 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed279.56 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed283.52 kB--
@sentry/nextjs (client)51.38 kB--
@sentry/sveltekit (client)47 kB--
@sentry/core/server78.63 kB--
@sentry/core/browser64.99 kB--
@sentry/node-core63.21 kB-0.01%-1 B 🔽
@sentry/node125.45 kB--
@sentry/node (incl. diagnostics channel injection)141.28 kB+0.08%+111 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection)70.03 kB+0.01%+2 B 🔺
@sentry/node/light51.33 kB--
@sentry/node - without tracing74.7 kB--
@sentry/aws-serverless83.92 kB--
@sentry/cloudflare (withSentry) - minified182.1 kB--
@sentry/cloudflare (withSentry)450.9 kB--

View base workflow run

@mydeamydea changed the title fix: Orchestrion diagnostics for async and requirefix(serve-rutils): Orchestrion diagnostics for async and requireJul 16, 2026
@timfish
timfish merged commit e0865f9 into developJul 16, 2026
226 checks passed
@timfish
timfish deleted the timfish/fix/orchestrion-diagnostics branch July 16, 2026 15:26
timfish added a commit that referenced this pull request Jul 16, 2026
I missed this commit off of #22327.
This ensure that we only skip registering the hooks on the loader thread
which means Sentry in a worker thread can still hook loading.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@timfish@mydea
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(serve-rutils): Orchestrion diagnostics for async and require - #22327

Merged
timfish merged 2 commits into
developfrom
timfish/fix/orchestrion-diagnostics
Jul 16, 2026
Merged

fix(serve-rutils): Orchestrion diagnostics for async and require#22327
timfish merged 2 commits into
developfrom
timfish/fix/orchestrion-diagnostics

Conversation

@timfish

@timfishtimfish commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

This PR fixes some issues with capturing runtime orchestrion diagnostics:

  • Handles and logs errors!
  • Configures the hook for the async loader and require hook

Notes:

  • This is all really nasty and can be reduced considerably when we drop support for Node without require(esm).
  • We have to block registerDiagnosticsChannelInjection from running on the loader thread or it crashes!
  • I dropped all the usage of DEBUG_BUILD because this code is all server side and we want these to always be captured when debug: true. Probably worth adjusting the ai prompt to reflect this!

@timfish
timfish requested a review from a team as a code ownerJuly 16, 2026 13:17
@timfish
timfish requested review from isaacs, mydea, s1gr1d and stephanie-anderson and removed request for a teamJuly 16, 2026 13:17
cursor[bot]

This comment was marked as outdated.

@github-actions

github-actionsBot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser27.74 kB--
@sentry/browser - with treeshaking flags26.19 kB--
@sentry/browser (incl. Tracing)46.57 kB--
@sentry/browser (incl. Tracing + Span Streaming)48.36 kB--
@sentry/browser (incl. Tracing, Profiling)51.34 kB--
@sentry/browser (incl. Tracing, Replay)85.83 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags75.46 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)90.55 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)103.18 kB--
@sentry/browser (incl. Feedback)44.92 kB--
@sentry/browser (incl. sendFeedback)32.54 kB--
@sentry/browser (incl. FeedbackAsync)37.67 kB--
@sentry/browser (incl. Metrics)28.84 kB--
@sentry/browser (incl. Logs)29.07 kB--
@sentry/browser (incl. Metrics & Logs)29.76 kB--
@sentry/react29.54 kB--
@sentry/react (incl. Tracing)48.82 kB--
@sentry/vue33.17 kB--
@sentry/vue (incl. Tracing)48.55 kB--
@sentry/svelte27.77 kB--
CDN Bundle30.14 kB--
CDN Bundle (incl. Tracing)48.52 kB--
CDN Bundle (incl. Logs, Metrics)31.72 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.83 kB--
CDN Bundle (incl. Replay, Logs, Metrics)70.97 kB--
CDN Bundle (incl. Tracing, Replay)86.04 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)87.33 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)91.82 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)93.09 kB--
CDN Bundle - uncompressed89.85 kB--
CDN Bundle (incl. Tracing) - uncompressed146.66 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed94.56 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed150.64 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed219.28 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed265.86 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed269.82 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed279.56 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed283.52 kB--
@sentry/nextjs (client)51.38 kB--
@sentry/sveltekit (client)47 kB--
@sentry/core/server78.63 kB--
@sentry/core/browser64.99 kB--
@sentry/node-core63.21 kB-0.01%-1 B 🔽
@sentry/node125.45 kB--
@sentry/node (incl. diagnostics channel injection)141.28 kB+0.08%+111 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection)70.03 kB+0.01%+2 B 🔺
@sentry/node/light51.33 kB--
@sentry/node - without tracing74.7 kB--
@sentry/aws-serverless83.92 kB--
@sentry/cloudflare (withSentry) - minified182.1 kB--
@sentry/cloudflare (withSentry)450.9 kB--

View base workflow run

@mydeamydea changed the title fix: Orchestrion diagnostics for async and requirefix(serve-rutils): Orchestrion diagnostics for async and requireJul 16, 2026
@timfish
timfish merged commit e0865f9 into developJul 16, 2026
226 checks passed
@timfish
timfish deleted the timfish/fix/orchestrion-diagnostics branch July 16, 2026 15:26
timfish added a commit that referenced this pull request Jul 16, 2026
I missed this commit off of #22327.
This ensure that we only skip registering the hooks on the loader thread
which means Sentry in a worker thread can still hook loading.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@timfish@mydea
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(serve-rutils): Orchestrion diagnostics for async and require - #22327

Merged
timfish merged 2 commits into
developfrom
timfish/fix/orchestrion-diagnostics
Jul 16, 2026
Merged

fix(serve-rutils): Orchestrion diagnostics for async and require#22327
timfish merged 2 commits into
developfrom
timfish/fix/orchestrion-diagnostics

Conversation

@timfish

@timfishtimfish commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

This PR fixes some issues with capturing runtime orchestrion diagnostics:

  • Handles and logs errors!
  • Configures the hook for the async loader and require hook

Notes:

  • This is all really nasty and can be reduced considerably when we drop support for Node without require(esm).
  • We have to block registerDiagnosticsChannelInjection from running on the loader thread or it crashes!
  • I dropped all the usage of DEBUG_BUILD because this code is all server side and we want these to always be captured when debug: true. Probably worth adjusting the ai prompt to reflect this!

@timfish
timfish requested a review from a team as a code ownerJuly 16, 2026 13:17
@timfish
timfish requested review from isaacs, mydea, s1gr1d and stephanie-anderson and removed request for a teamJuly 16, 2026 13:17
cursor[bot]

This comment was marked as outdated.

@github-actions

github-actionsBot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser27.74 kB--
@sentry/browser - with treeshaking flags26.19 kB--
@sentry/browser (incl. Tracing)46.57 kB--
@sentry/browser (incl. Tracing + Span Streaming)48.36 kB--
@sentry/browser (incl. Tracing, Profiling)51.34 kB--
@sentry/browser (incl. Tracing, Replay)85.83 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags75.46 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)90.55 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)103.18 kB--
@sentry/browser (incl. Feedback)44.92 kB--
@sentry/browser (incl. sendFeedback)32.54 kB--
@sentry/browser (incl. FeedbackAsync)37.67 kB--
@sentry/browser (incl. Metrics)28.84 kB--
@sentry/browser (incl. Logs)29.07 kB--
@sentry/browser (incl. Metrics & Logs)29.76 kB--
@sentry/react29.54 kB--
@sentry/react (incl. Tracing)48.82 kB--
@sentry/vue33.17 kB--
@sentry/vue (incl. Tracing)48.55 kB--
@sentry/svelte27.77 kB--
CDN Bundle30.14 kB--
CDN Bundle (incl. Tracing)48.52 kB--
CDN Bundle (incl. Logs, Metrics)31.72 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.83 kB--
CDN Bundle (incl. Replay, Logs, Metrics)70.97 kB--
CDN Bundle (incl. Tracing, Replay)86.04 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)87.33 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)91.82 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)93.09 kB--
CDN Bundle - uncompressed89.85 kB--
CDN Bundle (incl. Tracing) - uncompressed146.66 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed94.56 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed150.64 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed219.28 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed265.86 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed269.82 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed279.56 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed283.52 kB--
@sentry/nextjs (client)51.38 kB--
@sentry/sveltekit (client)47 kB--
@sentry/core/server78.63 kB--
@sentry/core/browser64.99 kB--
@sentry/node-core63.21 kB-0.01%-1 B 🔽
@sentry/node125.45 kB--
@sentry/node (incl. diagnostics channel injection)141.28 kB+0.08%+111 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection)70.03 kB+0.01%+2 B 🔺
@sentry/node/light51.33 kB--
@sentry/node - without tracing74.7 kB--
@sentry/aws-serverless83.92 kB--
@sentry/cloudflare (withSentry) - minified182.1 kB--
@sentry/cloudflare (withSentry)450.9 kB--

View base workflow run

@mydeamydea changed the title fix: Orchestrion diagnostics for async and requirefix(serve-rutils): Orchestrion diagnostics for async and requireJul 16, 2026
@timfish
timfish merged commit e0865f9 into developJul 16, 2026
226 checks passed
@timfish
timfish deleted the timfish/fix/orchestrion-diagnostics branch July 16, 2026 15:26
timfish added a commit that referenced this pull request Jul 16, 2026
I missed this commit off of #22327.
This ensure that we only skip registering the hooks on the loader thread
which means Sentry in a worker thread can still hook loading.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@timfish@mydea
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

fix(serve-rutils): Orchestrion diagnostics for async and require - #22327

Merged
timfish merged 2 commits into
developfrom
timfish/fix/orchestrion-diagnostics
Jul 16, 2026
Merged

fix(serve-rutils): Orchestrion diagnostics for async and require#22327
timfish merged 2 commits into
developfrom
timfish/fix/orchestrion-diagnostics

Conversation

@timfish

@timfishtimfish commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

This PR fixes some issues with capturing runtime orchestrion diagnostics:

  • Handles and logs errors!
  • Configures the hook for the async loader and require hook

Notes:

  • This is all really nasty and can be reduced considerably when we drop support for Node without require(esm).
  • We have to block registerDiagnosticsChannelInjection from running on the loader thread or it crashes!
  • I dropped all the usage of DEBUG_BUILD because this code is all server side and we want these to always be captured when debug: true. Probably worth adjusting the ai prompt to reflect this!

@timfish
timfish requested a review from a team as a code ownerJuly 16, 2026 13:17
@timfish
timfish requested review from isaacs, mydea, s1gr1d and stephanie-anderson and removed request for a teamJuly 16, 2026 13:17
cursor[bot]

This comment was marked as outdated.

@github-actions

github-actionsBot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser27.74 kB--
@sentry/browser - with treeshaking flags26.19 kB--
@sentry/browser (incl. Tracing)46.57 kB--
@sentry/browser (incl. Tracing + Span Streaming)48.36 kB--
@sentry/browser (incl. Tracing, Profiling)51.34 kB--
@sentry/browser (incl. Tracing, Replay)85.83 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags75.46 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)90.55 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)103.18 kB--
@sentry/browser (incl. Feedback)44.92 kB--
@sentry/browser (incl. sendFeedback)32.54 kB--
@sentry/browser (incl. FeedbackAsync)37.67 kB--
@sentry/browser (incl. Metrics)28.84 kB--
@sentry/browser (incl. Logs)29.07 kB--
@sentry/browser (incl. Metrics & Logs)29.76 kB--
@sentry/react29.54 kB--
@sentry/react (incl. Tracing)48.82 kB--
@sentry/vue33.17 kB--
@sentry/vue (incl. Tracing)48.55 kB--
@sentry/svelte27.77 kB--
CDN Bundle30.14 kB--
CDN Bundle (incl. Tracing)48.52 kB--
CDN Bundle (incl. Logs, Metrics)31.72 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.83 kB--
CDN Bundle (incl. Replay, Logs, Metrics)70.97 kB--
CDN Bundle (incl. Tracing, Replay)86.04 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)87.33 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)91.82 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)93.09 kB--
CDN Bundle - uncompressed89.85 kB--
CDN Bundle (incl. Tracing) - uncompressed146.66 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed94.56 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed150.64 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed219.28 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed265.86 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed269.82 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed279.56 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed283.52 kB--
@sentry/nextjs (client)51.38 kB--
@sentry/sveltekit (client)47 kB--
@sentry/core/server78.63 kB--
@sentry/core/browser64.99 kB--
@sentry/node-core63.21 kB-0.01%-1 B 🔽
@sentry/node125.45 kB--
@sentry/node (incl. diagnostics channel injection)141.28 kB+0.08%+111 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection)70.03 kB+0.01%+2 B 🔺
@sentry/node/light51.33 kB--
@sentry/node - without tracing74.7 kB--
@sentry/aws-serverless83.92 kB--
@sentry/cloudflare (withSentry) - minified182.1 kB--
@sentry/cloudflare (withSentry)450.9 kB--

View base workflow run

@mydeamydea changed the title fix: Orchestrion diagnostics for async and requirefix(serve-rutils): Orchestrion diagnostics for async and requireJul 16, 2026
@timfish
timfish merged commit e0865f9 into developJul 16, 2026
226 checks passed
@timfish
timfish deleted the timfish/fix/orchestrion-diagnostics branch July 16, 2026 15:26
timfish added a commit that referenced this pull request Jul 16, 2026
I missed this commit off of #22327.
This ensure that we only skip registering the hooks on the loader thread
which means Sentry in a worker thread can still hook loading.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@timfish@mydea