Uh oh!
There was an error while loading. Please reload this page.
fix(server-utils): Ensure all orchestrion instrumentation lazy registers - #22387
Closed
mydea wants to merge 2 commits into
Closed
fix(server-utils): Ensure all orchestrion instrumentation lazy registers#22387mydea wants to merge 2 commits into
mydea wants to merge 2 commits into
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Contributor
size-limit report 📦
|
mydeaforce-pushed
the
fn/lazy-register-orchestrion
branch
from
July 20, 2026 11:28
d3bf68e to
8e918d3CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
timfish
reviewed
Jul 20, 2026
timfish
left a comment
Collaborator
There was a problem hiding this comment.
I can't find where invokeOrchestrionInstrumentation is defined 🤔
mydea
commented
Jul 21, 2026
MemberAuthor
This is in the other PR in this stack: #22386 |
mydeaforce-pushed
the
fn/lazy-register-orchestrion
branch
from
July 21, 2026 07:55
8e918d3 to
03b2355Comparemydea
marked this pull request as ready for review
July 21, 2026 07:55
mydea
requested review from
msonnb and stephanie-anderson
and removed request for
a teamJuly 21, 2026 07:55
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 03b2355. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
mydeaforce-pushed
the
fn/lazy-register-orchestrion
branch
from
July 21, 2026 08:34
03b2355 to
93dba1aCompareUh oh!
There was an error while loading. Please reload this page.
chargome
approved these changes
Jul 22, 2026
| functionQuery: { expressionName: 'query', kind: 'Auto' }, | ||
| }, | ||
| ] satisfies InstrumentationConfig[]; | ||
| ] as const satisfies InstrumentationConfig[]; |
Member
There was a problem hiding this comment.
q: Why was this cast necessary everywhere?
isaacs
commented
Jul 27, 2026
Member
Superseded by #22518. |
andreiborza pushed a commit
that referenced
this pull request
Aug 3, 2026
…ers (#22518) This ports and refactors the intent of #22387, using the mechanisms landed on `develop` in #22094, rather than the mechanisms in #22386 which are similar in intent, but substantially different in implementation. The difference from #22387 is entirely in the plumbing underneath the helper. The way that "is my module injected?" and "tell me when it gets injected" are answered, both now use the machinery that already landed. Beyond that, the actual registration, event emitting, double-wrap guard, and integration refactoring, should all look very familiar. --------- Co-authored-by: Francesco Novy <francesco.novy@sentry.io> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: Jan Peer Stöcklmair <jan.peer@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates all orchestrion tracing-channel integrations to the
invokeOrchestrionInstrumentationhelper so that every integration lazily registers its channel subscribers only once the corresponding module is actually injected, rather than registering eagerly atSentry.init().Previously each integration wired up its own diagnostics-channel subscription directly, which meant subscribers could be registered before (or without) the target module ever being loaded, and the timing was inconsistent across integrations. Routing everything through the shared helper makes the behavior uniform: subscribers are set up for build-time-injected modules immediately and for runtime-injected modules when injection happens, always before the module publishes, and never more than once.
Alongside the migration, several integrations (hapi, graphql, kafkajs) are restructured into a
<name>/index.ts+<name>/instrumentation.tslayout to match the existing convention and keep the instrumentation wiring separate from the integration definition.Stacked on top of #22386 (ensure injected modules can reliably be picked up).