feat(core): Add url.full attribute to core fetch instrumentation#22415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lms24 merged 3 commits into from
Jul 21, 2026
Merged

feat(core): Add url.full attribute to core fetch instrumentation #22415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c7b54bc
ref(core): Add `url.full` attribute to core fetch instrumentation
Lms24 Jul 21, 2026
50f2d36
adjust tests
Lms24 Jul 21, 2026
9861918
fix bun build fail
Lms24 Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions dev-packages/e2e-tests/test-applications/astro-6-cf-workers/tests/tracing.dynamic.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -242,6 +242,8 @@ test.describe('nested SSR routes (client, server, server request)', () => {
'sentry.op': 'http.client',
'sentry.origin': 'auto.http.fetch',
url: expect.stringContaining('/api/user/myUsername123.json'),
'http.url': 'http://localhost:3030/api/user/myUsername123.json',
'url.full': 'http://localhost:3030/api/user/myUsername123.json',
},
});

Expand Down
1 change: 1 addition & 0 deletions dev-packages/e2e-tests/test-applications/nextjs-pages-dir/tests/middleware.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -75,6 +75,7 @@ test('Should trace outgoing fetch requests inside middleware and create breadcru
type: 'fetch',
url: 'http://localhost:3030/',
'http.url': 'http://localhost:3030/',
'url.full': 'http://localhost:3030/',
'server.address': 'localhost:3030',
'sentry.op': 'http.client',
'sentry.origin': 'auto.http.wintercg_fetch',
Expand Down
4 changes: 2 additions & 2 deletions packages/browser-utils/src/metrics/browserMetrics.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,6 @@ import {
isPrimitive,
parseUrl,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_URL_FULL,
setMeasurement,
spanToJSON,
stringMatchesSomePattern,
Expand All@@ -30,6 +29,7 @@ import { getActivationStart } from './web-vitals/lib/getActivationStart';
import { getNavigationEntry } from './web-vitals/lib/getNavigationEntry';
import { getVisibilityWatcher } from './web-vitals/lib/getVisibilityWatcher';
import { DEBUG_BUILD } from '../debug-build';
import { URL_FULL } from '@sentry/conventions/attributes';
interface NavigatorNetworkInformation {
readonly connection?: NetworkInformation;
}
Expand DownExpand Up@@ -775,7 +775,7 @@ export function _addResourceSpans(

attributes['url.same_origin'] = resourceUrl.includes(WINDOW.location.origin);

attributes[SEMANTIC_ATTRIBUTE_URL_FULL] = resourceUrl;
attributes[URL_FULL] = resourceUrl;

_setResourceRequestAttributes(entry, attributes, [
// https://developer.mozilla.org/en-US/docs/Web/API/PerformanceResourceTiming/responseStatus
Expand Down
5 changes: 2 additions & 3 deletions packages/browser/src/integrations/graphqlClient.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,13 +5,12 @@ import {
isString,
SEMANTIC_ATTRIBUTE_HTTP_REQUEST_METHOD,
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_URL_FULL,
spanToJSON,
stringMatchesSomePattern,
} from '@sentry/core/browser';
import type { FetchHint, XhrHint } from '@sentry/browser-utils';
import { getBodyString, getFetchRequestArgBody, SENTRY_XHR_DATA_KEY } from '@sentry/browser-utils';
import { GRAPHQL_DOCUMENT } from '@sentry/conventions/attributes';
import { GRAPHQL_DOCUMENT, URL_FULL } from '@sentry/conventions/attributes';

interface GraphQLClientOptions {
endpoints: Array<string | RegExp>;
Expand DownExpand Up@@ -71,7 +70,7 @@ function _updateSpanWithGraphQLData(client: Client, options: GraphQLClientOption

// Fall back to `url` because fetch instrumentation only sets `http.url` for absolute URLs;
// relative URLs end up only in `url` (see `getFetchSpanAttributes` in packages/core/src/fetch.ts).
const httpUrl = spanAttributes[SEMANTIC_ATTRIBUTE_URL_FULL] || spanAttributes['http.url'] || spanAttributes['url'];
const httpUrl = spanAttributes[URL_FULL] || spanAttributes['http.url'] || spanAttributes['url'];
const httpMethod = spanAttributes[SEMANTIC_ATTRIBUTE_HTTP_REQUEST_METHOD] || spanAttributes['http.method'];

if (!isString(httpUrl) || !isString(httpMethod)) {
Expand Down
3 changes: 2 additions & 1 deletion packages/browser/src/integrations/httpcontext.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
import { defineIntegration, safeSetSpanJSONAttributes, SEMANTIC_ATTRIBUTE_SENTRY_OP } from '@sentry/core/browser';
import { getHttpRequestData, WINDOW } from '../helpers';
import { URL_FULL } from '@sentry/conventions/attributes';

/**
* Collects information about HTTP request headers and
Expand DownExpand Up@@ -39,7 +40,7 @@ export const httpContextIntegration = defineIntegration(() => {
safeSetSpanJSONAttributes(span, {
// Coerce empty string to undefined so the helper's nullish check drops it,
// rather than writing an empty `url.full` attribute onto the span.
'url.full': spanOp !== 'http.client' ? reqData.url : undefined,
[URL_FULL]: spanOp !== 'http.client' ? reqData.url : undefined,
'http.request.header.user_agent': reqData.headers['User-Agent'],
'http.request.header.referer': reqData.headers['Referer'],
});
Expand Down
8 changes: 5 additions & 3 deletions packages/browser/src/tracing/request.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -40,6 +40,7 @@ import {
} from '@sentry/browser-utils';
import type { BrowserClient } from '../client';
import { baggageHeaderHasSentryValues, createHeadersSafely, getFullURL, isPerformanceResourceTiming } from './utils';
import { HTTP_URL, URL_FULL } from '@sentry/conventions/attributes';

/** Options for Request Instrumentation */
export interface RequestInstrumentationOptions {
Expand DownExpand Up@@ -172,10 +173,11 @@ export function instrumentOutgoingRequests(client: Client, _options?: Partial<Re
const host = fullUrl ? parseUrl(fullUrl).host : undefined;
const sanitizedFullUrl = fullUrl ? stripDataUrlContent(fullUrl) : undefined;
createdSpan.setAttributes({
'http.url': sanitizedFullUrl,
// oxlint-disable-next-line typescript/no-deprecated
[HTTP_URL]: sanitizedFullUrl,
// `url.full` must match `http.url`. Setting it here ensures parentless `http.client`
// segment spans don't get `url.full` backfilled with the host page URL (see httpContextIntegration).
'url.full': sanitizedFullUrl,
[URL_FULL]: sanitizedFullUrl,
'server.address': host,
});

Expand DownExpand Up@@ -393,7 +395,7 @@ function xhrCallback(
'http.url': sanitizedFullUrl,
// `url.full` must match `http.url`. Setting it here ensures parentless `http.client`
// segment spans don't get `url.full` backfilled with the host page URL (see httpContextIntegration).
'url.full': sanitizedFullUrl,
[URL_FULL]: sanitizedFullUrl,
'server.address': parsedUrl?.host,
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.http.browser',
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'http.client',
Expand Down
25 changes: 23 additions & 2 deletions packages/browser/test/integrations/graphqlClient.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@ import type { Client } from '@sentry/core/browser';
import { SentrySpan, spanToJSON } from '@sentry/core/browser';
import type { FetchHint, XhrHint } from '@sentry/browser-utils';
import { SENTRY_XHR_DATA_KEY } from '@sentry/browser-utils';
import { URL_FULL } from '@sentry/conventions/attributes';
import { describe, expect, test } from 'vitest';
import {
_getGraphQLOperation,
Expand DownExpand Up@@ -352,14 +353,15 @@ describe('GraphqlClient', () => {
extensions: {},
};

test('enriches http.client span for absolute URLs (http.url attribute)', () => {
test('enriches http.client span for absolute URLs', () => {
const handler = setupHandler([/\/graphql$/]);
const span = new SentrySpan({
name: 'POST http://localhost:4000/graphql',
op: 'http.client',
attributes: {
'http.method': 'POST',
'http.url': 'http://localhost:4000/graphql',
[URL_FULL]: 'http://localhost:4000/graphql',
url: 'http://localhost:4000/graphql',
},
});
Expand All@@ -371,9 +373,27 @@ describe('GraphqlClient', () => {
expect(json.data['graphql.document']).toBe(requestBody.query);
});

test('enriches http.client span when only url.full is present', () => {
const handler = setupHandler([/\/graphql$/]);
const span = new SentrySpan({
name: 'POST http://localhost:4000/graphql',
op: 'http.client',
attributes: {
'http.method': 'POST',
[URL_FULL]: 'http://localhost:4000/graphql',
},
});

handler(span, makeFetchHint('http://localhost:4000/graphql', requestBody));

const json = spanToJSON(span);
expect(json.description).toBe('POST http://localhost:4000/graphql (query GetHello)');
expect(json.data['graphql.document']).toBe(requestBody.query);
});

test('enriches http.client span for relative URLs (only url attribute)', () => {
const handler = setupHandler([/\/graphql$/]);
// Fetch instrumentation does NOT set http.urlfor relative URLs — only `url`.
// Fetch instrumentation does not set `http.url` or `url.full` for relative URLs.
const span = new SentrySpan({
name: 'POST /graphql',
op: 'http.client',
Expand DownExpand Up@@ -433,6 +453,7 @@ describe('GraphqlClient', () => {
attributes: {
'http.method': 'POST',
'http.url': 'http://localhost:4000/graphql',
[URL_FULL]: 'http://localhost:4000/graphql',
url: 'http://localhost:4000/graphql',
},
});
Expand Down
1 change: 1 addition & 0 deletions packages/bun/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,7 @@
"dependencies": {
"@apm-js-collab/code-transformer-bundler-plugins": "^0.7.1",
"@sentry/core": "10.67.0",
"@sentry/conventions": "^0.16.0",
"@sentry/node": "10.67.0",
"@sentry/server-utils": "10.67.0"
},
Expand Down
3 changes: 2 additions & 1 deletion packages/bun/src/integrations/bunserver.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@ import {
withIsolationScope,
} from '@sentry/core';
import type { ServeOptions } from 'bun';
import { URL_FULL } from '@sentry/conventions/attributes';

const INTEGRATION_NAME = 'BunServer' as const;

Expand DownExpand Up@@ -282,7 +283,7 @@ function getSpanAttributesFromParsedUrl(
attributes['url.path'] = parsedUrl.pathname;
}
if (!isURLObjectRelative(parsedUrl)) {
attributes['url.full'] = parsedUrl.href;
attributes[URL_FULL] = parsedUrl.href;
if (parsedUrl.port) {
attributes['url.port'] = parsedUrl.port;
}
Expand Down
5 changes: 4 additions & 1 deletion packages/core/src/fetch.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { HTTP_URL, URL_FULL } from '@sentry/conventions/attributes';
import { getClient } from './currentScopes';
import { SEMANTIC_ATTRIBUTE_SENTRY_OP, SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN } from './semanticAttributes';
import { setHttpStatus, SPAN_STATUS_ERROR, spanIsIgnored, startInactiveSpan } from './tracing';
Expand DownExpand Up@@ -388,7 +389,9 @@ function getFetchSpanAttributes(
};
if (parsedUrl) {
if (!isURLObjectRelative(parsedUrl)) {
attributes['http.url'] = stripDataUrlContent(parsedUrl.href);
// oxlint-disable-next-line typescript/no-deprecated
attributes[HTTP_URL] = stripDataUrlContent(parsedUrl.href);
attributes[URL_FULL] = stripDataUrlContent(parsedUrl.href);
Comment thread
cursor[bot] marked this conversation as resolved.
attributes['server.address'] = parsedUrl.host;
}
if (parsedUrl.search) {
Expand Down
5 changes: 3 additions & 2 deletions packages/core/src/integrations/requestdata.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,7 @@ import { parseCookie } from '../utils/cookie';
import { httpHeadersToSpanAttributes } from '../utils/request';
import { getClientIPAddress, ipHeaderNames } from '../vendor/getIpAddress';
import { safeSetSpanJSONAttributes } from '../tracing/spans/captureSpan';
import { URL_FULL, URL_QUERY } from '@sentry/conventions/attributes';

interface RequestDataIncludeOptions {
cookies?: boolean;
Expand DownExpand Up@@ -137,15 +138,15 @@ function addNormalizedRequestDataToSpan(
const attributes: Record<string, unknown> = {};

if (requestData.url) {
attributes['url.full'] = requestData.url;
attributes[URL_FULL] = requestData.url;
}

if (requestData.method) {
attributes['http.request.method'] = requestData.method;
}

if (requestData.query_string) {
attributes['url.query'] = normalizeQueryString(requestData.query_string);
attributes[URL_QUERY] = normalizeQueryString(requestData.query_string);
}

safeSetSpanJSONAttributes(span, attributes);
Expand Down
3 changes: 3 additions & 0 deletions packages/core/src/semanticAttributes.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -110,6 +110,9 @@ export const SEMANTIC_ATTRIBUTE_CACHE_ITEM_SIZE = 'cache.item_size';

/** TODO: Remove these once we update to latest semantic conventions */
export const SEMANTIC_ATTRIBUTE_HTTP_REQUEST_METHOD = 'http.request.method';
/**
* @deprecated Use `URL_FULL` `@sentry/conventions/attributes` instead.
*/
export const SEMANTIC_ATTRIBUTE_URL_FULL = 'url.full';

/**
Expand Down
4 changes: 2 additions & 2 deletions packages/core/src/utils/url.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
import { URL_FULL } from '@sentry/conventions/attributes';
import {
SEMANTIC_ATTRIBUTE_HTTP_REQUEST_METHOD,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
SEMANTIC_ATTRIBUTE_URL_FULL,
} from '../semanticAttributes';
import type { SpanAttributes } from '../types/span';

Expand DownExpand Up@@ -188,7 +188,7 @@ export function getHttpSpanDetailsFromUrlObject(
}

if (!isURLObjectRelative(urlObject)) {
attributes[SEMANTIC_ATTRIBUTE_URL_FULL] = urlObject.href;
attributes[URL_FULL] = urlObject.href;
if (urlObject.port) {
attributes['url.port'] = urlObject.port;
}
Expand Down
44 changes: 44 additions & 0 deletions packages/core/test/lib/fetch.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { URL_FULL } from '@sentry/conventions/attributes';
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
import type { HandlerDataFetch } from '../../src';
import { _INTERNAL_getTracingHeadersForFetchRequest, instrumentFetchRequest } from '../../src/fetch';
Expand DownExpand Up@@ -444,6 +445,49 @@ describe('_INTERNAL_getTracingHeadersForFetchRequest', () => {
});

describe('instrumentFetchRequest', () => {
describe('span attributes', () => {
afterEach(() => {
vi.restoreAllMocks();
});

it('sets url.full for absolute URLs', () => {
const url = 'https://api.example.com/users/42?include=profile#bio';
const activeSpan = new SentryNonRecordingSpan();
const fetchSpan = new SentryNonRecordingSpan();
hasSpansEnabled.mockReturnValue(true);
vi.spyOn(spanUtils, 'getActiveSpan').mockReturnValue(activeSpan);
const startInactiveSpanSpy = vi.spyOn(tracing, 'startInactiveSpan').mockReturnValue(fetchSpan);

instrumentFetchRequest(
{
fetchData: { url, method: 'GET' },
args: [url],
startTimestamp: Date.now(),
},
() => true,
() => false,
{},
{ spanOrigin: 'auto.http.fetch' },
);

expect(startInactiveSpanSpy).toHaveBeenCalledWith({
name: 'GET https://api.example.com/users/42',
attributes: {
url,
type: 'fetch',
'http.method': 'GET',
'sentry.origin': 'auto.http.fetch',
'sentry.op': 'http.client',
'http.url': url,
[URL_FULL]: url,
'server.address': 'api.example.com',
'http.query': '?include=profile',
'http.fragment': '#bio',
},
});
});
});

describe('trace header span', () => {
beforeEach(() => {
vi.clearAllMocks();
Expand Down
5 changes: 1 addition & 4 deletions packages/ember/addon/utils/instrumentEmberAppInstanceForPerformance.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,10 +14,7 @@ import {
import type { Client, Span } from '@sentry/core';
import type { EmberRouterMain } from '../types';
import { getBackburner } from './performance';

const URL_FULL = 'url.full';
const URL_PATH = 'url.path';
const URL_TEMPLATE = 'url.template';
import { URL_FULL, URL_PATH, URL_TEMPLATE } from '@sentry/conventions/attributes';

type TransitionWithIntent = Transition & { intent?: { url?: string } };

Expand Down
1 change: 1 addition & 0 deletions packages/ember/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -34,6 +34,7 @@
"@embroider/macros": "^1.16.0",
"@sentry/browser": "10.67.0",
"@sentry/core": "10.67.0",
"@sentry/conventions": "^0.16.0",
"ember-auto-import": "^2.7.2",
"ember-cli-babel": "^8.2.0",
"ember-cli-htmlbars": "^6.1.1",
Expand Down
3 changes: 2 additions & 1 deletion packages/nextjs/src/server/vercelQueuesMonitoring.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { URL_FULL } from '@sentry/conventions/attributes';
import type { Span } from '@sentry/core';
import { getIsolationScope, spanToJSON } from '@sentry/core';

Expand DownExpand Up@@ -76,7 +77,7 @@ export function maybeEnrichQueueProducerSpan(span: Span): void {
const spanData = spanToJSON(span).data;

// http.client spans have url.full attribute
const urlFull = spanData?.['url.full'] as string | undefined;
const urlFull = spanData?.[URL_FULL] as string | undefined;
if (!urlFull) {
return;
}
Expand Down
11 changes: 3 additions & 8 deletions packages/node/src/integrations/http.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,14 @@
import type { RequestOptions } from 'node:http';
import type { HttpClientRequest, HttpIncomingMessage, HttpServerResponse, Span } from '@sentry/core';
import {
defineIntegration,
hasSpansEnabled,
SEMANTIC_ATTRIBUTE_URL_FULL,
stripDataUrlContent,
getRequestUrlFromClientRequest,
} from '@sentry/core';
import { defineIntegration, hasSpansEnabled, stripDataUrlContent, getRequestUrlFromClientRequest } from '@sentry/core';
import type {
NodeClient,
SentryHttpInstrumentationOptions,
HttpServerIntegrationOptions,
HttpServerSpansIntegrationOptions,
} from '@sentry/node-core';
import { httpServerIntegration, httpServerSpansIntegration, instrumentHttpOutgoingRequests } from '@sentry/node-core';
import { URL_FULL } from '@sentry/conventions/attributes';

const INTEGRATION_NAME = 'Http' as const;

Expand DownExpand Up@@ -210,7 +205,7 @@ export const httpIntegration = defineIntegration((options: HttpOptions = {}) =>
// TODO(v11): Update these to the Sentry semantic attributes.
// https://getsentry.github.io/sentry-conventions/attributes/
span.setAttribute('http.url', sanitizedUrl);
span.setAttribute(SEMANTIC_ATTRIBUTE_URL_FULL, sanitizedUrl);
span.setAttribute(URL_FULL, sanitizedUrl);
span.updateName(`${request.method || 'GET'} ${sanitizedUrl}`);
}
options.instrumentation?.requestHook?.(span, request);
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
feat(core): Add url.full attribute to core fetch instrumentation#22415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Lms24
merged 3 commits into

from

Jul 21, 2026
 Merged


feat(core): Add url.full attribute to core fetch instrumentation
#22415
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
c7b54bc

ref(core): Add `url.full` attribute to core fetch instrumentation


Lms24 Jul 21, 2026
50f2d36

adjust tests


Lms24 Jul 21, 2026
9861918

fix bun build fail


Lms24 Jul 21, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
dev-packages/e2e-tests/test-applications/astro-6-cf-workers/tests/tracing.dynamic.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -242,6 +242,8 @@ test.describe('nested SSR routes (client, server, server request)', () => {
 'sentry.op': 'http.client',
 'sentry.origin': 'auto.http.fetch',
 url: expect.stringContaining('/api/user/myUsername123.json'),
 'http.url': 'http://localhost:3030/api/user/myUsername123.json',
 'url.full': 'http://localhost:3030/api/user/myUsername123.json',
 },
 });

Expand Down

1 change: 1 addition & 0 deletions
dev-packages/e2e-tests/test-applications/nextjs-pages-dir/tests/middleware.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -75,6 +75,7 @@ test('Should trace outgoing fetch requests inside middleware and create breadcru
 type: 'fetch',
 url: 'http://localhost:3030/',
 'http.url': 'http://localhost:3030/',
 'url.full': 'http://localhost:3030/',
 'server.address': 'localhost:3030',
 'sentry.op': 'http.client',
 'sentry.origin': 'auto.http.wintercg_fetch',
Expand Down

4 changes: 2 additions & 2 deletions
packages/browser-utils/src/metrics/browserMetrics.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,6 @@ import {
 isPrimitive,
 parseUrl,
 SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
 SEMANTIC_ATTRIBUTE_URL_FULL,
 setMeasurement,
 spanToJSON,
 stringMatchesSomePattern,
Expand All@@ -30,6 +29,7 @@ import { getActivationStart } from './web-vitals/lib/getActivationStart';
import { getNavigationEntry } from './web-vitals/lib/getNavigationEntry';
import { getVisibilityWatcher } from './web-vitals/lib/getVisibilityWatcher';
import { DEBUG_BUILD } from '../debug-build';
import { URL_FULL } from '@sentry/conventions/attributes';
interface NavigatorNetworkInformation {
 readonly connection?: NetworkInformation;
}
Expand DownExpand Up@@ -775,7 +775,7 @@ export function _addResourceSpans(

 attributes['url.same_origin'] = resourceUrl.includes(WINDOW.location.origin);

 attributes[SEMANTIC_ATTRIBUTE_URL_FULL] = resourceUrl;
 attributes[URL_FULL] = resourceUrl;

 _setResourceRequestAttributes(entry, attributes, [
 // https://developer.mozilla.org/en-US/docs/Web/API/PerformanceResourceTiming/responseStatus
Expand Down

5 changes: 2 additions & 3 deletions
packages/browser/src/integrations/graphqlClient.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,13 +5,12 @@ import {
 isString,
 SEMANTIC_ATTRIBUTE_HTTP_REQUEST_METHOD,
 SEMANTIC_ATTRIBUTE_SENTRY_OP,
 SEMANTIC_ATTRIBUTE_URL_FULL,
 spanToJSON,
 stringMatchesSomePattern,
} from '@sentry/core/browser';
import type { FetchHint, XhrHint } from '@sentry/browser-utils';
import { getBodyString, getFetchRequestArgBody, SENTRY_XHR_DATA_KEY } from '@sentry/browser-utils';
import { GRAPHQL_DOCUMENT } from '@sentry/conventions/attributes';
import { GRAPHQL_DOCUMENT, URL_FULL } from '@sentry/conventions/attributes';

interface GraphQLClientOptions {
 endpoints: Array<string | RegExp>;
Expand DownExpand Up@@ -71,7 +70,7 @@ function _updateSpanWithGraphQLData(client: Client, options: GraphQLClientOption

 // Fall back to `url` because fetch instrumentation only sets `http.url` for absolute URLs;
 // relative URLs end up only in `url` (see `getFetchSpanAttributes` in packages/core/src/fetch.ts).
 const httpUrl = spanAttributes[SEMANTIC_ATTRIBUTE_URL_FULL] || spanAttributes['http.url'] || spanAttributes['url'];
 const httpUrl = spanAttributes[URL_FULL] || spanAttributes['http.url'] || spanAttributes['url'];
 const httpMethod = spanAttributes[SEMANTIC_ATTRIBUTE_HTTP_REQUEST_METHOD] || spanAttributes['http.method'];

 if (!isString(httpUrl) || !isString(httpMethod)) {
Expand Down

3 changes: 2 additions & 1 deletion
packages/browser/src/integrations/httpcontext.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
import { defineIntegration, safeSetSpanJSONAttributes, SEMANTIC_ATTRIBUTE_SENTRY_OP } from '@sentry/core/browser';
import { getHttpRequestData, WINDOW } from '../helpers';
import { URL_FULL } from '@sentry/conventions/attributes';

/**
 * Collects information about HTTP request headers and
Expand DownExpand Up@@ -39,7 +40,7 @@ export const httpContextIntegration = defineIntegration(() => {
 safeSetSpanJSONAttributes(span, {
 // Coerce empty string to undefined so the helper's nullish check drops it,
 // rather than writing an empty `url.full` attribute onto the span.
'url.full': spanOp !== 'http.client' ? reqData.url : undefined,
[URL_FULL]: spanOp !== 'http.client' ? reqData.url : undefined,
 'http.request.header.user_agent': reqData.headers['User-Agent'],
 'http.request.header.referer': reqData.headers['Referer'],
 });
Expand Down

8 changes: 5 additions & 3 deletions
packages/browser/src/tracing/request.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -40,6 +40,7 @@ import {
} from '@sentry/browser-utils';
import type { BrowserClient } from '../client';
import { baggageHeaderHasSentryValues, createHeadersSafely, getFullURL, isPerformanceResourceTiming } from './utils';
import { HTTP_URL, URL_FULL } from '@sentry/conventions/attributes';

/** Options for Request Instrumentation */
export interface RequestInstrumentationOptions {
Expand DownExpand Up@@ -172,10 +173,11 @@ export function instrumentOutgoingRequests(client: Client, _options?: Partial<Re
 const host = fullUrl ? parseUrl(fullUrl).host : undefined;
 const sanitizedFullUrl = fullUrl ? stripDataUrlContent(fullUrl) : undefined;
 createdSpan.setAttributes({
 'http.url': sanitizedFullUrl,
 // oxlint-disable-next-line typescript/no-deprecated
 [HTTP_URL]: sanitizedFullUrl,
 // `url.full` must match `http.url`. Setting it here ensures parentless `http.client`
 // segment spans don't get `url.full` backfilled with the host page URL (see httpContextIntegration).
'url.full': sanitizedFullUrl,
[URL_FULL]: sanitizedFullUrl,
 'server.address': host,
 });

Expand DownExpand Up@@ -393,7 +395,7 @@ function xhrCallback(
 'http.url': sanitizedFullUrl,
 // `url.full` must match `http.url`. Setting it here ensures parentless `http.client`
 // segment spans don't get `url.full` backfilled with the host page URL (see httpContextIntegration).
'url.full': sanitizedFullUrl,
[URL_FULL]: sanitizedFullUrl,
 'server.address': parsedUrl?.host,
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.http.browser',
 [SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'http.client',
Expand Down

25 changes: 23 additions & 2 deletions
packages/browser/test/integrations/graphqlClient.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@ import type { Client } from '@sentry/core/browser';
import { SentrySpan, spanToJSON } from '@sentry/core/browser';
import type { FetchHint, XhrHint } from '@sentry/browser-utils';
import { SENTRY_XHR_DATA_KEY } from '@sentry/browser-utils';
import { URL_FULL } from '@sentry/conventions/attributes';
import { describe, expect, test } from 'vitest';
import {
 _getGraphQLOperation,
Expand DownExpand Up@@ -352,14 +353,15 @@ describe('GraphqlClient', () => {
 extensions: {},
 };

 test('enriches http.client span for absolute URLs (http.url attribute)', () => {
 test('enriches http.client span for absolute URLs', () => {
 const handler = setupHandler([/\/graphql$/]);
 const span = new SentrySpan({
 name: 'POST http://localhost:4000/graphql',
 op: 'http.client',
 attributes: {
 'http.method': 'POST',
 'http.url': 'http://localhost:4000/graphql',
 [URL_FULL]: 'http://localhost:4000/graphql',
 url: 'http://localhost:4000/graphql',
 },
 });
Expand All@@ -371,9 +373,27 @@ describe('GraphqlClient', () => {
 expect(json.data['graphql.document']).toBe(requestBody.query);
 });

 test('enriches http.client span when only url.full is present', () => {
 const handler = setupHandler([/\/graphql$/]);
 const span = new SentrySpan({
 name: 'POST http://localhost:4000/graphql',
 op: 'http.client',
 attributes: {
 'http.method': 'POST',
 [URL_FULL]: 'http://localhost:4000/graphql',
 },
 });

 handler(span, makeFetchHint('http://localhost:4000/graphql', requestBody));

 const json = spanToJSON(span);
 expect(json.description).toBe('POST http://localhost:4000/graphql (query GetHello)');
 expect(json.data['graphql.document']).toBe(requestBody.query);
 });

 test('enriches http.client span for relative URLs (only url attribute)', () => {
 const handler = setupHandler([/\/graphql$/]);
 // Fetch instrumentation does NOT set http.urlfor relative URLs — only `url`.
 // Fetch instrumentation does not set `http.url` or `url.full` for relative URLs.
 const span = new SentrySpan({
 name: 'POST /graphql',
 op: 'http.client',
Expand DownExpand Up@@ -433,6 +453,7 @@ describe('GraphqlClient', () => {
 attributes: {
 'http.method': 'POST',
 'http.url': 'http://localhost:4000/graphql',
 [URL_FULL]: 'http://localhost:4000/graphql',
 url: 'http://localhost:4000/graphql',
 },
 });
Expand Down

1 change: 1 addition & 0 deletions
packages/bun/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,7 @@
 "dependencies": {
 "@apm-js-collab/code-transformer-bundler-plugins": "^0.7.1",
 "@sentry/core": "10.67.0",
 "@sentry/conventions": "^0.16.0",
 "@sentry/node": "10.67.0",
 "@sentry/server-utils": "10.67.0"
 },
Expand Down

3 changes: 2 additions & 1 deletion
packages/bun/src/integrations/bunserver.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@ import {
 withIsolationScope,
} from '@sentry/core';
import type { ServeOptions } from 'bun';
import { URL_FULL } from '@sentry/conventions/attributes';

const INTEGRATION_NAME = 'BunServer' as const;

Expand DownExpand Up@@ -282,7 +283,7 @@ function getSpanAttributesFromParsedUrl(
 attributes['url.path'] = parsedUrl.pathname;
 }
 if (!isURLObjectRelative(parsedUrl)) {
 attributes['url.full'] = parsedUrl.href;
 attributes[URL_FULL] = parsedUrl.href;
 if (parsedUrl.port) {
 attributes['url.port'] = parsedUrl.port;
 }
Expand Down

5 changes: 4 additions & 1 deletion
packages/core/src/fetch.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { HTTP_URL, URL_FULL } from '@sentry/conventions/attributes';
import { getClient } from './currentScopes';
import { SEMANTIC_ATTRIBUTE_SENTRY_OP, SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN } from './semanticAttributes';
import { setHttpStatus, SPAN_STATUS_ERROR, spanIsIgnored, startInactiveSpan } from './tracing';
Expand DownExpand Up@@ -388,7 +389,9 @@ function getFetchSpanAttributes(
 };
 if (parsedUrl) {
 if (!isURLObjectRelative(parsedUrl)) {
 attributes['http.url'] = stripDataUrlContent(parsedUrl.href);
 // oxlint-disable-next-line typescript/no-deprecated
 attributes[HTTP_URL] = stripDataUrlContent(parsedUrl.href);
 attributes[URL_FULL] = stripDataUrlContent(parsedUrl.href);
Comment thread
cursor[bot] marked this conversation as resolved.

 attributes['server.address'] = parsedUrl.host;
 }
 if (parsedUrl.search) {
Expand Down

5 changes: 3 additions & 2 deletions
packages/core/src/integrations/requestdata.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,7 @@ import { parseCookie } from '../utils/cookie';
import { httpHeadersToSpanAttributes } from '../utils/request';
import { getClientIPAddress, ipHeaderNames } from '../vendor/getIpAddress';
import { safeSetSpanJSONAttributes } from '../tracing/spans/captureSpan';
import { URL_FULL, URL_QUERY } from '@sentry/conventions/attributes';

interface RequestDataIncludeOptions {
 cookies?: boolean;
Expand DownExpand Up@@ -137,15 +138,15 @@ function addNormalizedRequestDataToSpan(
 const attributes: Record<string, unknown> = {};

 if (requestData.url) {
 attributes['url.full'] = requestData.url;
 attributes[URL_FULL] = requestData.url;
 }

 if (requestData.method) {
 attributes['http.request.method'] = requestData.method;
 }

 if (requestData.query_string) {
 attributes['url.query'] = normalizeQueryString(requestData.query_string);
 attributes[URL_QUERY] = normalizeQueryString(requestData.query_string);
 }

 safeSetSpanJSONAttributes(span, attributes);
Expand Down

3 changes: 3 additions & 0 deletions
packages/core/src/semanticAttributes.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -110,6 +110,9 @@ export const SEMANTIC_ATTRIBUTE_CACHE_ITEM_SIZE = 'cache.item_size';

/** TODO: Remove these once we update to latest semantic conventions */
export const SEMANTIC_ATTRIBUTE_HTTP_REQUEST_METHOD = 'http.request.method';
/**
 * @deprecated Use `URL_FULL` `@sentry/conventions/attributes` instead.
 */
export const SEMANTIC_ATTRIBUTE_URL_FULL = 'url.full';

/**
Expand Down

4 changes: 2 additions & 2 deletions
packages/core/src/utils/url.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
import { URL_FULL } from '@sentry/conventions/attributes';
import {
 SEMANTIC_ATTRIBUTE_HTTP_REQUEST_METHOD,
 SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
 SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
 SEMANTIC_ATTRIBUTE_URL_FULL,
} from '../semanticAttributes';
import type { SpanAttributes } from '../types/span';

Expand DownExpand Up@@ -188,7 +188,7 @@ export function getHttpSpanDetailsFromUrlObject(
 }

 if (!isURLObjectRelative(urlObject)) {
 attributes[SEMANTIC_ATTRIBUTE_URL_FULL] = urlObject.href;
 attributes[URL_FULL] = urlObject.href;
 if (urlObject.port) {
 attributes['url.port'] = urlObject.port;
 }
Expand Down

44 changes: 44 additions & 0 deletions
packages/core/test/lib/fetch.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { URL_FULL } from '@sentry/conventions/attributes';
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
import type { HandlerDataFetch } from '../../src';
import { _INTERNAL_getTracingHeadersForFetchRequest, instrumentFetchRequest } from '../../src/fetch';
Expand DownExpand Up@@ -444,6 +445,49 @@ describe('_INTERNAL_getTracingHeadersForFetchRequest', () => {
});

describe('instrumentFetchRequest', () => {
 describe('span attributes', () => {
 afterEach(() => {
 vi.restoreAllMocks();
 });

 it('sets url.full for absolute URLs', () => {
 const url = 'https://api.example.com/users/42?include=profile#bio';
 const activeSpan = new SentryNonRecordingSpan();
 const fetchSpan = new SentryNonRecordingSpan();
 hasSpansEnabled.mockReturnValue(true);
 vi.spyOn(spanUtils, 'getActiveSpan').mockReturnValue(activeSpan);
 const startInactiveSpanSpy = vi.spyOn(tracing, 'startInactiveSpan').mockReturnValue(fetchSpan);

 instrumentFetchRequest(
 {
 fetchData: { url, method: 'GET' },
 args: [url],
 startTimestamp: Date.now(),
 },
 () => true,
 () => false,
 {},
 { spanOrigin: 'auto.http.fetch' },
 );

 expect(startInactiveSpanSpy).toHaveBeenCalledWith({
 name: 'GET https://api.example.com/users/42',
 attributes: {
 url,
 type: 'fetch',
 'http.method': 'GET',
 'sentry.origin': 'auto.http.fetch',
 'sentry.op': 'http.client',
 'http.url': url,
 [URL_FULL]: url,
 'server.address': 'api.example.com',
 'http.query': '?include=profile',
 'http.fragment': '#bio',
 },
 });
 });
 });

 describe('trace header span', () => {
 beforeEach(() => {
 vi.clearAllMocks();
Expand Down

5 changes: 1 addition & 4 deletions
packages/ember/addon/utils/instrumentEmberAppInstanceForPerformance.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -14,10 +14,7 @@ import {
import type { Client, Span } from '@sentry/core';
import type { EmberRouterMain } from '../types';
import { getBackburner } from './performance';

const URL_FULL = 'url.full';
const URL_PATH = 'url.path';
const URL_TEMPLATE = 'url.template';
import { URL_FULL, URL_PATH, URL_TEMPLATE } from '@sentry/conventions/attributes';

type TransitionWithIntent = Transition & { intent?: { url?: string } };

Expand Down

1 change: 1 addition & 0 deletions
packages/ember/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -34,6 +34,7 @@
 "@embroider/macros": "^1.16.0",
 "@sentry/browser": "10.67.0",
 "@sentry/core": "10.67.0",
 "@sentry/conventions": "^0.16.0",
 "ember-auto-import": "^2.7.2",
 "ember-cli-babel": "^8.2.0",
 "ember-cli-htmlbars": "^6.1.1",
Expand Down

3 changes: 2 additions & 1 deletion
packages/nextjs/src/server/vercelQueuesMonitoring.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { URL_FULL } from '@sentry/conventions/attributes';
import type { Span } from '@sentry/core';
import { getIsolationScope, spanToJSON } from '@sentry/core';

Expand DownExpand Up@@ -76,7 +77,7 @@ export function maybeEnrichQueueProducerSpan(span: Span): void {
 const spanData = spanToJSON(span).data;

 // http.client spans have url.full attribute
 const urlFull = spanData?.['url.full'] as string | undefined;
 const urlFull = spanData?.[URL_FULL] as string | undefined;
 if (!urlFull) {
 return;
 }
Expand Down

11 changes: 3 additions & 8 deletions
packages/node/src/integrations/http.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,19 +1,14 @@
import type { RequestOptions } from 'node:http';
import type { HttpClientRequest, HttpIncomingMessage, HttpServerResponse, Span } from '@sentry/core';
import {
 defineIntegration,
 hasSpansEnabled,
 SEMANTIC_ATTRIBUTE_URL_FULL,
 stripDataUrlContent,
 getRequestUrlFromClientRequest,
} from '@sentry/core';
import { defineIntegration, hasSpansEnabled, stripDataUrlContent, getRequestUrlFromClientRequest } from '@sentry/core';
import type {
 NodeClient,
 SentryHttpInstrumentationOptions,
 HttpServerIntegrationOptions,
 HttpServerSpansIntegrationOptions,
} from '@sentry/node-core';
import { httpServerIntegration, httpServerSpansIntegration, instrumentHttpOutgoingRequests } from '@sentry/node-core';
import { URL_FULL } from '@sentry/conventions/attributes';

const INTEGRATION_NAME = 'Http' as const;

Expand DownExpand Up@@ -210,7 +205,7 @@ export const httpIntegration = defineIntegration((options: HttpOptions = {}) =>
 // TODO(v11): Update these to the Sentry semantic attributes.
 // https://getsentry.github.io/sentry-conventions/attributes/
 span.setAttribute('http.url', sanitizedUrl);
 span.setAttribute(SEMANTIC_ATTRIBUTE_URL_FULL, sanitizedUrl);
 span.setAttribute(URL_FULL, sanitizedUrl);
 span.updateName(`${request.method || 'GET'} ${sanitizedUrl}`);
 }
 options.instrumentation?.requestHook?.(span, request);
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(core): Add url.full attribute to core fetch instrumentation#22415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Lms24
merged 3 commits into

from

Jul 21, 2026
 Merged


feat(core): Add url.full attribute to core fetch instrumentation
#22415
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
c7b54bc

ref(core): Add `url.full` attribute to core fetch instrumentation


Lms24 Jul 21, 2026
50f2d36

adjust tests


Lms24 Jul 21, 2026
9861918

fix bun build fail


Lms24 Jul 21, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
dev-packages/e2e-tests/test-applications/astro-6-cf-workers/tests/tracing.dynamic.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -242,6 +242,8 @@ test.describe('nested SSR routes (client, server, server request)', () => {
 'sentry.op': 'http.client',
 'sentry.origin': 'auto.http.fetch',
 url: expect.stringContaining('/api/user/myUsername123.json'),
 'http.url': 'http://localhost:3030/api/user/myUsername123.json',
 'url.full': 'http://localhost:3030/api/user/myUsername123.json',
 },
 });

Expand Down

1 change: 1 addition & 0 deletions
dev-packages/e2e-tests/test-applications/nextjs-pages-dir/tests/middleware.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -75,6 +75,7 @@ test('Should trace outgoing fetch requests inside middleware and create breadcru
 type: 'fetch',
 url: 'http://localhost:3030/',
 'http.url': 'http://localhost:3030/',
 'url.full': 'http://localhost:3030/',
 'server.address': 'localhost:3030',
 'sentry.op': 'http.client',
 'sentry.origin': 'auto.http.wintercg_fetch',
Expand Down

4 changes: 2 additions & 2 deletions
packages/browser-utils/src/metrics/browserMetrics.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,6 @@ import {
 isPrimitive,
 parseUrl,
 SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
 SEMANTIC_ATTRIBUTE_URL_FULL,
 setMeasurement,
 spanToJSON,
 stringMatchesSomePattern,
Expand All@@ -30,6 +29,7 @@ import { getActivationStart } from './web-vitals/lib/getActivationStart';
import { getNavigationEntry } from './web-vitals/lib/getNavigationEntry';
import { getVisibilityWatcher } from './web-vitals/lib/getVisibilityWatcher';
import { DEBUG_BUILD } from '../debug-build';
import { URL_FULL } from '@sentry/conventions/attributes';
interface NavigatorNetworkInformation {
 readonly connection?: NetworkInformation;
}
Expand DownExpand Up@@ -775,7 +775,7 @@ export function _addResourceSpans(

 attributes['url.same_origin'] = resourceUrl.includes(WINDOW.location.origin);

 attributes[SEMANTIC_ATTRIBUTE_URL_FULL] = resourceUrl;
 attributes[URL_FULL] = resourceUrl;

 _setResourceRequestAttributes(entry, attributes, [
 // https://developer.mozilla.org/en-US/docs/Web/API/PerformanceResourceTiming/responseStatus
Expand Down

5 changes: 2 additions & 3 deletions
packages/browser/src/integrations/graphqlClient.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,13 +5,12 @@ import {
 isString,
 SEMANTIC_ATTRIBUTE_HTTP_REQUEST_METHOD,
 SEMANTIC_ATTRIBUTE_SENTRY_OP,
 SEMANTIC_ATTRIBUTE_URL_FULL,
 spanToJSON,
 stringMatchesSomePattern,
} from '@sentry/core/browser';
import type { FetchHint, XhrHint } from '@sentry/browser-utils';
import { getBodyString, getFetchRequestArgBody, SENTRY_XHR_DATA_KEY } from '@sentry/browser-utils';
import { GRAPHQL_DOCUMENT } from '@sentry/conventions/attributes';
import { GRAPHQL_DOCUMENT, URL_FULL } from '@sentry/conventions/attributes';

interface GraphQLClientOptions {
 endpoints: Array<string | RegExp>;
Expand DownExpand Up@@ -71,7 +70,7 @@ function _updateSpanWithGraphQLData(client: Client, options: GraphQLClientOption

 // Fall back to `url` because fetch instrumentation only sets `http.url` for absolute URLs;
 // relative URLs end up only in `url` (see `getFetchSpanAttributes` in packages/core/src/fetch.ts).
 const httpUrl = spanAttributes[SEMANTIC_ATTRIBUTE_URL_FULL] || spanAttributes['http.url'] || spanAttributes['url'];
 const httpUrl = spanAttributes[URL_FULL] || spanAttributes['http.url'] || spanAttributes['url'];
 const httpMethod = spanAttributes[SEMANTIC_ATTRIBUTE_HTTP_REQUEST_METHOD] || spanAttributes['http.method'];

 if (!isString(httpUrl) || !isString(httpMethod)) {
Expand Down

3 changes: 2 additions & 1 deletion
packages/browser/src/integrations/httpcontext.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
import { defineIntegration, safeSetSpanJSONAttributes, SEMANTIC_ATTRIBUTE_SENTRY_OP } from '@sentry/core/browser';
import { getHttpRequestData, WINDOW } from '../helpers';
import { URL_FULL } from '@sentry/conventions/attributes';

/**
 * Collects information about HTTP request headers and
Expand DownExpand Up@@ -39,7 +40,7 @@ export const httpContextIntegration = defineIntegration(() => {
 safeSetSpanJSONAttributes(span, {
 // Coerce empty string to undefined so the helper's nullish check drops it,
 // rather than writing an empty `url.full` attribute onto the span.
'url.full': spanOp !== 'http.client' ? reqData.url : undefined,
[URL_FULL]: spanOp !== 'http.client' ? reqData.url : undefined,
 'http.request.header.user_agent': reqData.headers['User-Agent'],
 'http.request.header.referer': reqData.headers['Referer'],
 });
Expand Down

8 changes: 5 additions & 3 deletions
packages/browser/src/tracing/request.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -40,6 +40,7 @@ import {
} from '@sentry/browser-utils';
import type { BrowserClient } from '../client';
import { baggageHeaderHasSentryValues, createHeadersSafely, getFullURL, isPerformanceResourceTiming } from './utils';
import { HTTP_URL, URL_FULL } from '@sentry/conventions/attributes';

/** Options for Request Instrumentation */
export interface RequestInstrumentationOptions {
Expand DownExpand Up@@ -172,10 +173,11 @@ export function instrumentOutgoingRequests(client: Client, _options?: Partial<Re
 const host = fullUrl ? parseUrl(fullUrl).host : undefined;
 const sanitizedFullUrl = fullUrl ? stripDataUrlContent(fullUrl) : undefined;
 createdSpan.setAttributes({
 'http.url': sanitizedFullUrl,
 // oxlint-disable-next-line typescript/no-deprecated
 [HTTP_URL]: sanitizedFullUrl,
 // `url.full` must match `http.url`. Setting it here ensures parentless `http.client`
 // segment spans don't get `url.full` backfilled with the host page URL (see httpContextIntegration).
'url.full': sanitizedFullUrl,
[URL_FULL]: sanitizedFullUrl,
 'server.address': host,
 });

Expand DownExpand Up@@ -393,7 +395,7 @@ function xhrCallback(
 'http.url': sanitizedFullUrl,
 // `url.full` must match `http.url`. Setting it here ensures parentless `http.client`
 // segment spans don't get `url.full` backfilled with the host page URL (see httpContextIntegration).
'url.full': sanitizedFullUrl,
[URL_FULL]: sanitizedFullUrl,
 'server.address': parsedUrl?.host,
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.http.browser',
 [SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'http.client',
Expand Down

25 changes: 23 additions & 2 deletions
packages/browser/test/integrations/graphqlClient.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@ import type { Client } from '@sentry/core/browser';
import { SentrySpan, spanToJSON } from '@sentry/core/browser';
import type { FetchHint, XhrHint } from '@sentry/browser-utils';
import { SENTRY_XHR_DATA_KEY } from '@sentry/browser-utils';
import { URL_FULL } from '@sentry/conventions/attributes';
import { describe, expect, test } from 'vitest';
import {
 _getGraphQLOperation,
Expand DownExpand Up@@ -352,14 +353,15 @@ describe('GraphqlClient', () => {
 extensions: {},
 };

 test('enriches http.client span for absolute URLs (http.url attribute)', () => {
 test('enriches http.client span for absolute URLs', () => {
 const handler = setupHandler([/\/graphql$/]);
 const span = new SentrySpan({
 name: 'POST http://localhost:4000/graphql',
 op: 'http.client',
 attributes: {
 'http.method': 'POST',
 'http.url': 'http://localhost:4000/graphql',
 [URL_FULL]: 'http://localhost:4000/graphql',
 url: 'http://localhost:4000/graphql',
 },
 });
Expand All@@ -371,9 +373,27 @@ describe('GraphqlClient', () => {
 expect(json.data['graphql.document']).toBe(requestBody.query);
 });

 test('enriches http.client span when only url.full is present', () => {
 const handler = setupHandler([/\/graphql$/]);
 const span = new SentrySpan({
 name: 'POST http://localhost:4000/graphql',
 op: 'http.client',
 attributes: {
 'http.method': 'POST',
 [URL_FULL]: 'http://localhost:4000/graphql',
 },
 });

 handler(span, makeFetchHint('http://localhost:4000/graphql', requestBody));

 const json = spanToJSON(span);
 expect(json.description).toBe('POST http://localhost:4000/graphql (query GetHello)');
 expect(json.data['graphql.document']).toBe(requestBody.query);
 });

 test('enriches http.client span for relative URLs (only url attribute)', () => {
 const handler = setupHandler([/\/graphql$/]);
 // Fetch instrumentation does NOT set http.urlfor relative URLs — only `url`.
 // Fetch instrumentation does not set `http.url` or `url.full` for relative URLs.
 const span = new SentrySpan({
 name: 'POST /graphql',
 op: 'http.client',
Expand DownExpand Up@@ -433,6 +453,7 @@ describe('GraphqlClient', () => {
 attributes: {
 'http.method': 'POST',
 'http.url': 'http://localhost:4000/graphql',
 [URL_FULL]: 'http://localhost:4000/graphql',
 url: 'http://localhost:4000/graphql',
 },
 });
Expand Down

1 change: 1 addition & 0 deletions
packages/bun/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,7 @@
 "dependencies": {
 "@apm-js-collab/code-transformer-bundler-plugins": "^0.7.1",
 "@sentry/core": "10.67.0",
 "@sentry/conventions": "^0.16.0",
 "@sentry/node": "10.67.0",
 "@sentry/server-utils": "10.67.0"
 },
Expand Down

3 changes: 2 additions & 1 deletion
packages/bun/src/integrations/bunserver.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@ import {
 withIsolationScope,
} from '@sentry/core';
import type { ServeOptions } from 'bun';
import { URL_FULL } from '@sentry/conventions/attributes';

const INTEGRATION_NAME = 'BunServer' as const;

Expand DownExpand Up@@ -282,7 +283,7 @@ function getSpanAttributesFromParsedUrl(
 attributes['url.path'] = parsedUrl.pathname;
 }
 if (!isURLObjectRelative(parsedUrl)) {
 attributes['url.full'] = parsedUrl.href;
 attributes[URL_FULL] = parsedUrl.href;
 if (parsedUrl.port) {
 attributes['url.port'] = parsedUrl.port;
 }
Expand Down

5 changes: 4 additions & 1 deletion
packages/core/src/fetch.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { HTTP_URL, URL_FULL } from '@sentry/conventions/attributes';
import { getClient } from './currentScopes';
import { SEMANTIC_ATTRIBUTE_SENTRY_OP, SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN } from './semanticAttributes';
import { setHttpStatus, SPAN_STATUS_ERROR, spanIsIgnored, startInactiveSpan } from './tracing';
Expand DownExpand Up@@ -388,7 +389,9 @@ function getFetchSpanAttributes(
 };
 if (parsedUrl) {
 if (!isURLObjectRelative(parsedUrl)) {
 attributes['http.url'] = stripDataUrlContent(parsedUrl.href);
 // oxlint-disable-next-line typescript/no-deprecated
 attributes[HTTP_URL] = stripDataUrlContent(parsedUrl.href);
 attributes[URL_FULL] = stripDataUrlContent(parsedUrl.href);
Comment thread
cursor[bot] marked this conversation as resolved.

 attributes['server.address'] = parsedUrl.host;
 }
 if (parsedUrl.search) {
Expand Down

5 changes: 3 additions & 2 deletions
packages/core/src/integrations/requestdata.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,7 @@ import { parseCookie } from '../utils/cookie';
import { httpHeadersToSpanAttributes } from '../utils/request';
import { getClientIPAddress, ipHeaderNames } from '../vendor/getIpAddress';
import { safeSetSpanJSONAttributes } from '../tracing/spans/captureSpan';
import { URL_FULL, URL_QUERY } from '@sentry/conventions/attributes';

interface RequestDataIncludeOptions {
 cookies?: boolean;
Expand DownExpand Up@@ -137,15 +138,15 @@ function addNormalizedRequestDataToSpan(
 const attributes: Record<string, unknown> = {};

 if (requestData.url) {
 attributes['url.full'] = requestData.url;
 attributes[URL_FULL] = requestData.url;
 }

 if (requestData.method) {
 attributes['http.request.method'] = requestData.method;
 }

 if (requestData.query_string) {
 attributes['url.query'] = normalizeQueryString(requestData.query_string);
 attributes[URL_QUERY] = normalizeQueryString(requestData.query_string);
 }

 safeSetSpanJSONAttributes(span, attributes);
Expand Down

3 changes: 3 additions & 0 deletions
packages/core/src/semanticAttributes.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -110,6 +110,9 @@ export const SEMANTIC_ATTRIBUTE_CACHE_ITEM_SIZE = 'cache.item_size';

/** TODO: Remove these once we update to latest semantic conventions */
export const SEMANTIC_ATTRIBUTE_HTTP_REQUEST_METHOD = 'http.request.method';
/**
 * @deprecated Use `URL_FULL` `@sentry/conventions/attributes` instead.
 */
export const SEMANTIC_ATTRIBUTE_URL_FULL = 'url.full';

/**
Expand Down

4 changes: 2 additions & 2 deletions
packages/core/src/utils/url.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
import { URL_FULL } from '@sentry/conventions/attributes';
import {
 SEMANTIC_ATTRIBUTE_HTTP_REQUEST_METHOD,
 SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
 SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
 SEMANTIC_ATTRIBUTE_URL_FULL,
} from '../semanticAttributes';
import type { SpanAttributes } from '../types/span';

Expand DownExpand Up@@ -188,7 +188,7 @@ export function getHttpSpanDetailsFromUrlObject(
 }

 if (!isURLObjectRelative(urlObject)) {
 attributes[SEMANTIC_ATTRIBUTE_URL_FULL] = urlObject.href;
 attributes[URL_FULL] = urlObject.href;
 if (urlObject.port) {
 attributes['url.port'] = urlObject.port;
 }
Expand Down

44 changes: 44 additions & 0 deletions
packages/core/test/lib/fetch.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { URL_FULL } from '@sentry/conventions/attributes';
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
import type { HandlerDataFetch } from '../../src';
import { _INTERNAL_getTracingHeadersForFetchRequest, instrumentFetchRequest } from '../../src/fetch';
Expand DownExpand Up@@ -444,6 +445,49 @@ describe('_INTERNAL_getTracingHeadersForFetchRequest', () => {
});

describe('instrumentFetchRequest', () => {
 describe('span attributes', () => {
 afterEach(() => {
 vi.restoreAllMocks();
 });

 it('sets url.full for absolute URLs', () => {
 const url = 'https://api.example.com/users/42?include=profile#bio';
 const activeSpan = new SentryNonRecordingSpan();
 const fetchSpan = new SentryNonRecordingSpan();
 hasSpansEnabled.mockReturnValue(true);
 vi.spyOn(spanUtils, 'getActiveSpan').mockReturnValue(activeSpan);
 const startInactiveSpanSpy = vi.spyOn(tracing, 'startInactiveSpan').mockReturnValue(fetchSpan);

 instrumentFetchRequest(
 {
 fetchData: { url, method: 'GET' },
 args: [url],
 startTimestamp: Date.now(),
 },
 () => true,
 () => false,
 {},
 { spanOrigin: 'auto.http.fetch' },
 );

 expect(startInactiveSpanSpy).toHaveBeenCalledWith({
 name: 'GET https://api.example.com/users/42',
 attributes: {
 url,
 type: 'fetch',
 'http.method': 'GET',
 'sentry.origin': 'auto.http.fetch',
 'sentry.op': 'http.client',
 'http.url': url,
 [URL_FULL]: url,
 'server.address': 'api.example.com',
 'http.query': '?include=profile',
 'http.fragment': '#bio',
 },
 });
 });
 });

 describe('trace header span', () => {
 beforeEach(() => {
 vi.clearAllMocks();
Expand Down

5 changes: 1 addition & 4 deletions
packages/ember/addon/utils/instrumentEmberAppInstanceForPerformance.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -14,10 +14,7 @@ import {
import type { Client, Span } from '@sentry/core';
import type { EmberRouterMain } from '../types';
import { getBackburner } from './performance';

const URL_FULL = 'url.full';
const URL_PATH = 'url.path';
const URL_TEMPLATE = 'url.template';
import { URL_FULL, URL_PATH, URL_TEMPLATE } from '@sentry/conventions/attributes';

type TransitionWithIntent = Transition & { intent?: { url?: string } };

Expand Down

1 change: 1 addition & 0 deletions
packages/ember/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -34,6 +34,7 @@
 "@embroider/macros": "^1.16.0",
 "@sentry/browser": "10.67.0",
 "@sentry/core": "10.67.0",
 "@sentry/conventions": "^0.16.0",
 "ember-auto-import": "^2.7.2",
 "ember-cli-babel": "^8.2.0",
 "ember-cli-htmlbars": "^6.1.1",
Expand Down

3 changes: 2 additions & 1 deletion
packages/nextjs/src/server/vercelQueuesMonitoring.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { URL_FULL } from '@sentry/conventions/attributes';
import type { Span } from '@sentry/core';
import { getIsolationScope, spanToJSON } from '@sentry/core';

Expand DownExpand Up@@ -76,7 +77,7 @@ export function maybeEnrichQueueProducerSpan(span: Span): void {
 const spanData = spanToJSON(span).data;

 // http.client spans have url.full attribute
 const urlFull = spanData?.['url.full'] as string | undefined;
 const urlFull = spanData?.[URL_FULL] as string | undefined;
 if (!urlFull) {
 return;
 }
Expand Down

11 changes: 3 additions & 8 deletions
packages/node/src/integrations/http.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,19 +1,14 @@
import type { RequestOptions } from 'node:http';
import type { HttpClientRequest, HttpIncomingMessage, HttpServerResponse, Span } from '@sentry/core';
import {
 defineIntegration,
 hasSpansEnabled,
 SEMANTIC_ATTRIBUTE_URL_FULL,
 stripDataUrlContent,
 getRequestUrlFromClientRequest,
} from '@sentry/core';
import { defineIntegration, hasSpansEnabled, stripDataUrlContent, getRequestUrlFromClientRequest } from '@sentry/core';
import type {
 NodeClient,
 SentryHttpInstrumentationOptions,
 HttpServerIntegrationOptions,
 HttpServerSpansIntegrationOptions,
} from '@sentry/node-core';
import { httpServerIntegration, httpServerSpansIntegration, instrumentHttpOutgoingRequests } from '@sentry/node-core';
import { URL_FULL } from '@sentry/conventions/attributes';

const INTEGRATION_NAME = 'Http' as const;

Expand DownExpand Up@@ -210,7 +205,7 @@ export const httpIntegration = defineIntegration((options: HttpOptions = {}) =>
 // TODO(v11): Update these to the Sentry semantic attributes.
 // https://getsentry.github.io/sentry-conventions/attributes/
 span.setAttribute('http.url', sanitizedUrl);
 span.setAttribute(SEMANTIC_ATTRIBUTE_URL_FULL, sanitizedUrl);
 span.setAttribute(URL_FULL, sanitizedUrl);
 span.updateName(`${request.method || 'GET'} ${sanitizedUrl}`);
 }
 options.instrumentation?.requestHook?.(span, request);
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(core): Add url.full attribute to core fetch instrumentation#22415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Lms24
merged 3 commits into

from

Jul 21, 2026
 Merged


feat(core): Add url.full attribute to core fetch instrumentation
#22415
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
c7b54bc

ref(core): Add `url.full` attribute to core fetch instrumentation


Lms24 Jul 21, 2026
50f2d36

adjust tests


Lms24 Jul 21, 2026
9861918

fix bun build fail


Lms24 Jul 21, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
dev-packages/e2e-tests/test-applications/astro-6-cf-workers/tests/tracing.dynamic.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -242,6 +242,8 @@ test.describe('nested SSR routes (client, server, server request)', () => {
 'sentry.op': 'http.client',
 'sentry.origin': 'auto.http.fetch',
 url: expect.stringContaining('/api/user/myUsername123.json'),
 'http.url': 'http://localhost:3030/api/user/myUsername123.json',
 'url.full': 'http://localhost:3030/api/user/myUsername123.json',
 },
 });

Expand Down

1 change: 1 addition & 0 deletions
dev-packages/e2e-tests/test-applications/nextjs-pages-dir/tests/middleware.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -75,6 +75,7 @@ test('Should trace outgoing fetch requests inside middleware and create breadcru
 type: 'fetch',
 url: 'http://localhost:3030/',
 'http.url': 'http://localhost:3030/',
 'url.full': 'http://localhost:3030/',
 'server.address': 'localhost:3030',
 'sentry.op': 'http.client',
 'sentry.origin': 'auto.http.wintercg_fetch',
Expand Down

4 changes: 2 additions & 2 deletions
packages/browser-utils/src/metrics/browserMetrics.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,6 @@ import {
 isPrimitive,
 parseUrl,
 SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
 SEMANTIC_ATTRIBUTE_URL_FULL,
 setMeasurement,
 spanToJSON,
 stringMatchesSomePattern,
Expand All@@ -30,6 +29,7 @@ import { getActivationStart } from './web-vitals/lib/getActivationStart';
import { getNavigationEntry } from './web-vitals/lib/getNavigationEntry';
import { getVisibilityWatcher } from './web-vitals/lib/getVisibilityWatcher';
import { DEBUG_BUILD } from '../debug-build';
import { URL_FULL } from '@sentry/conventions/attributes';
interface NavigatorNetworkInformation {
 readonly connection?: NetworkInformation;
}
Expand DownExpand Up@@ -775,7 +775,7 @@ export function _addResourceSpans(

 attributes['url.same_origin'] = resourceUrl.includes(WINDOW.location.origin);

 attributes[SEMANTIC_ATTRIBUTE_URL_FULL] = resourceUrl;
 attributes[URL_FULL] = resourceUrl;

 _setResourceRequestAttributes(entry, attributes, [
 // https://developer.mozilla.org/en-US/docs/Web/API/PerformanceResourceTiming/responseStatus
Expand Down

5 changes: 2 additions & 3 deletions
packages/browser/src/integrations/graphqlClient.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,13 +5,12 @@ import {
 isString,
 SEMANTIC_ATTRIBUTE_HTTP_REQUEST_METHOD,
 SEMANTIC_ATTRIBUTE_SENTRY_OP,
 SEMANTIC_ATTRIBUTE_URL_FULL,
 spanToJSON,
 stringMatchesSomePattern,
} from '@sentry/core/browser';
import type { FetchHint, XhrHint } from '@sentry/browser-utils';
import { getBodyString, getFetchRequestArgBody, SENTRY_XHR_DATA_KEY } from '@sentry/browser-utils';
import { GRAPHQL_DOCUMENT } from '@sentry/conventions/attributes';
import { GRAPHQL_DOCUMENT, URL_FULL } from '@sentry/conventions/attributes';

interface GraphQLClientOptions {
 endpoints: Array<string | RegExp>;
Expand DownExpand Up@@ -71,7 +70,7 @@ function _updateSpanWithGraphQLData(client: Client, options: GraphQLClientOption

 // Fall back to `url` because fetch instrumentation only sets `http.url` for absolute URLs;
 // relative URLs end up only in `url` (see `getFetchSpanAttributes` in packages/core/src/fetch.ts).
 const httpUrl = spanAttributes[SEMANTIC_ATTRIBUTE_URL_FULL] || spanAttributes['http.url'] || spanAttributes['url'];
 const httpUrl = spanAttributes[URL_FULL] || spanAttributes['http.url'] || spanAttributes['url'];
 const httpMethod = spanAttributes[SEMANTIC_ATTRIBUTE_HTTP_REQUEST_METHOD] || spanAttributes['http.method'];

 if (!isString(httpUrl) || !isString(httpMethod)) {
Expand Down

3 changes: 2 additions & 1 deletion
packages/browser/src/integrations/httpcontext.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
import { defineIntegration, safeSetSpanJSONAttributes, SEMANTIC_ATTRIBUTE_SENTRY_OP } from '@sentry/core/browser';
import { getHttpRequestData, WINDOW } from '../helpers';
import { URL_FULL } from '@sentry/conventions/attributes';

/**
 * Collects information about HTTP request headers and
Expand DownExpand Up@@ -39,7 +40,7 @@ export const httpContextIntegration = defineIntegration(() => {
 safeSetSpanJSONAttributes(span, {
 // Coerce empty string to undefined so the helper's nullish check drops it,
 // rather than writing an empty `url.full` attribute onto the span.
'url.full': spanOp !== 'http.client' ? reqData.url : undefined,
[URL_FULL]: spanOp !== 'http.client' ? reqData.url : undefined,
 'http.request.header.user_agent': reqData.headers['User-Agent'],
 'http.request.header.referer': reqData.headers['Referer'],
 });
Expand Down

8 changes: 5 additions & 3 deletions
packages/browser/src/tracing/request.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -40,6 +40,7 @@ import {
} from '@sentry/browser-utils';
import type { BrowserClient } from '../client';
import { baggageHeaderHasSentryValues, createHeadersSafely, getFullURL, isPerformanceResourceTiming } from './utils';
import { HTTP_URL, URL_FULL } from '@sentry/conventions/attributes';

/** Options for Request Instrumentation */
export interface RequestInstrumentationOptions {
Expand DownExpand Up@@ -172,10 +173,11 @@ export function instrumentOutgoingRequests(client: Client, _options?: Partial<Re
 const host = fullUrl ? parseUrl(fullUrl).host : undefined;
 const sanitizedFullUrl = fullUrl ? stripDataUrlContent(fullUrl) : undefined;
 createdSpan.setAttributes({
 'http.url': sanitizedFullUrl,
 // oxlint-disable-next-line typescript/no-deprecated
 [HTTP_URL]: sanitizedFullUrl,
 // `url.full` must match `http.url`. Setting it here ensures parentless `http.client`
 // segment spans don't get `url.full` backfilled with the host page URL (see httpContextIntegration).
'url.full': sanitizedFullUrl,
[URL_FULL]: sanitizedFullUrl,
 'server.address': host,
 });

Expand DownExpand Up@@ -393,7 +395,7 @@ function xhrCallback(
 'http.url': sanitizedFullUrl,
 // `url.full` must match `http.url`. Setting it here ensures parentless `http.client`
 // segment spans don't get `url.full` backfilled with the host page URL (see httpContextIntegration).
'url.full': sanitizedFullUrl,
[URL_FULL]: sanitizedFullUrl,
 'server.address': parsedUrl?.host,
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.http.browser',
 [SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'http.client',
Expand Down

25 changes: 23 additions & 2 deletions
packages/browser/test/integrations/graphqlClient.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@ import type { Client } from '@sentry/core/browser';
import { SentrySpan, spanToJSON } from '@sentry/core/browser';
import type { FetchHint, XhrHint } from '@sentry/browser-utils';
import { SENTRY_XHR_DATA_KEY } from '@sentry/browser-utils';
import { URL_FULL } from '@sentry/conventions/attributes';
import { describe, expect, test } from 'vitest';
import {
 _getGraphQLOperation,
Expand DownExpand Up@@ -352,14 +353,15 @@ describe('GraphqlClient', () => {
 extensions: {},
 };

 test('enriches http.client span for absolute URLs (http.url attribute)', () => {
 test('enriches http.client span for absolute URLs', () => {
 const handler = setupHandler([/\/graphql$/]);
 const span = new SentrySpan({
 name: 'POST http://localhost:4000/graphql',
 op: 'http.client',
 attributes: {
 'http.method': 'POST',
 'http.url': 'http://localhost:4000/graphql',
 [URL_FULL]: 'http://localhost:4000/graphql',
 url: 'http://localhost:4000/graphql',
 },
 });
Expand All@@ -371,9 +373,27 @@ describe('GraphqlClient', () => {
 expect(json.data['graphql.document']).toBe(requestBody.query);
 });

 test('enriches http.client span when only url.full is present', () => {
 const handler = setupHandler([/\/graphql$/]);
 const span = new SentrySpan({
 name: 'POST http://localhost:4000/graphql',
 op: 'http.client',
 attributes: {
 'http.method': 'POST',
 [URL_FULL]: 'http://localhost:4000/graphql',
 },
 });

 handler(span, makeFetchHint('http://localhost:4000/graphql', requestBody));

 const json = spanToJSON(span);
 expect(json.description).toBe('POST http://localhost:4000/graphql (query GetHello)');
 expect(json.data['graphql.document']).toBe(requestBody.query);
 });

 test('enriches http.client span for relative URLs (only url attribute)', () => {
 const handler = setupHandler([/\/graphql$/]);
 // Fetch instrumentation does NOT set http.urlfor relative URLs — only `url`.
 // Fetch instrumentation does not set `http.url` or `url.full` for relative URLs.
 const span = new SentrySpan({
 name: 'POST /graphql',
 op: 'http.client',
Expand DownExpand Up@@ -433,6 +453,7 @@ describe('GraphqlClient', () => {
 attributes: {
 'http.method': 'POST',
 'http.url': 'http://localhost:4000/graphql',
 [URL_FULL]: 'http://localhost:4000/graphql',
 url: 'http://localhost:4000/graphql',
 },
 });
Expand Down

1 change: 1 addition & 0 deletions
packages/bun/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,7 @@
 "dependencies": {
 "@apm-js-collab/code-transformer-bundler-plugins": "^0.7.1",
 "@sentry/core": "10.67.0",
 "@sentry/conventions": "^0.16.0",
 "@sentry/node": "10.67.0",
 "@sentry/server-utils": "10.67.0"
 },
Expand Down

3 changes: 2 additions & 1 deletion
packages/bun/src/integrations/bunserver.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@ import {
 withIsolationScope,
} from '@sentry/core';
import type { ServeOptions } from 'bun';
import { URL_FULL } from '@sentry/conventions/attributes';

const INTEGRATION_NAME = 'BunServer' as const;

Expand DownExpand Up@@ -282,7 +283,7 @@ function getSpanAttributesFromParsedUrl(
 attributes['url.path'] = parsedUrl.pathname;
 }
 if (!isURLObjectRelative(parsedUrl)) {
 attributes['url.full'] = parsedUrl.href;
 attributes[URL_FULL] = parsedUrl.href;
 if (parsedUrl.port) {
 attributes['url.port'] = parsedUrl.port;
 }
Expand Down

5 changes: 4 additions & 1 deletion
packages/core/src/fetch.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { HTTP_URL, URL_FULL } from '@sentry/conventions/attributes';
import { getClient } from './currentScopes';
import { SEMANTIC_ATTRIBUTE_SENTRY_OP, SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN } from './semanticAttributes';
import { setHttpStatus, SPAN_STATUS_ERROR, spanIsIgnored, startInactiveSpan } from './tracing';
Expand DownExpand Up@@ -388,7 +389,9 @@ function getFetchSpanAttributes(
 };
 if (parsedUrl) {
 if (!isURLObjectRelative(parsedUrl)) {
 attributes['http.url'] = stripDataUrlContent(parsedUrl.href);
 // oxlint-disable-next-line typescript/no-deprecated
 attributes[HTTP_URL] = stripDataUrlContent(parsedUrl.href);
 attributes[URL_FULL] = stripDataUrlContent(parsedUrl.href);
Comment thread
cursor[bot] marked this conversation as resolved.

 attributes['server.address'] = parsedUrl.host;
 }
 if (parsedUrl.search) {
Expand Down

5 changes: 3 additions & 2 deletions
packages/core/src/integrations/requestdata.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,7 @@ import { parseCookie } from '../utils/cookie';
import { httpHeadersToSpanAttributes } from '../utils/request';
import { getClientIPAddress, ipHeaderNames } from '../vendor/getIpAddress';
import { safeSetSpanJSONAttributes } from '../tracing/spans/captureSpan';
import { URL_FULL, URL_QUERY } from '@sentry/conventions/attributes';

interface RequestDataIncludeOptions {
 cookies?: boolean;
Expand DownExpand Up@@ -137,15 +138,15 @@ function addNormalizedRequestDataToSpan(
 const attributes: Record<string, unknown> = {};

 if (requestData.url) {
 attributes['url.full'] = requestData.url;
 attributes[URL_FULL] = requestData.url;
 }

 if (requestData.method) {
 attributes['http.request.method'] = requestData.method;
 }

 if (requestData.query_string) {
 attributes['url.query'] = normalizeQueryString(requestData.query_string);
 attributes[URL_QUERY] = normalizeQueryString(requestData.query_string);
 }

 safeSetSpanJSONAttributes(span, attributes);
Expand Down

3 changes: 3 additions & 0 deletions
packages/core/src/semanticAttributes.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -110,6 +110,9 @@ export const SEMANTIC_ATTRIBUTE_CACHE_ITEM_SIZE = 'cache.item_size';

/** TODO: Remove these once we update to latest semantic conventions */
export const SEMANTIC_ATTRIBUTE_HTTP_REQUEST_METHOD = 'http.request.method';
/**
 * @deprecated Use `URL_FULL` `@sentry/conventions/attributes` instead.
 */
export const SEMANTIC_ATTRIBUTE_URL_FULL = 'url.full';

/**
Expand Down

4 changes: 2 additions & 2 deletions
packages/core/src/utils/url.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
import { URL_FULL } from '@sentry/conventions/attributes';
import {
 SEMANTIC_ATTRIBUTE_HTTP_REQUEST_METHOD,
 SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
 SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
 SEMANTIC_ATTRIBUTE_URL_FULL,
} from '../semanticAttributes';
import type { SpanAttributes } from '../types/span';

Expand DownExpand Up@@ -188,7 +188,7 @@ export function getHttpSpanDetailsFromUrlObject(
 }

 if (!isURLObjectRelative(urlObject)) {
 attributes[SEMANTIC_ATTRIBUTE_URL_FULL] = urlObject.href;
 attributes[URL_FULL] = urlObject.href;
 if (urlObject.port) {
 attributes['url.port'] = urlObject.port;
 }
Expand Down

44 changes: 44 additions & 0 deletions
packages/core/test/lib/fetch.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { URL_FULL } from '@sentry/conventions/attributes';
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
import type { HandlerDataFetch } from '../../src';
import { _INTERNAL_getTracingHeadersForFetchRequest, instrumentFetchRequest } from '../../src/fetch';
Expand DownExpand Up@@ -444,6 +445,49 @@ describe('_INTERNAL_getTracingHeadersForFetchRequest', () => {
});

describe('instrumentFetchRequest', () => {
 describe('span attributes', () => {
 afterEach(() => {
 vi.restoreAllMocks();
 });

 it('sets url.full for absolute URLs', () => {
 const url = 'https://api.example.com/users/42?include=profile#bio';
 const activeSpan = new SentryNonRecordingSpan();
 const fetchSpan = new SentryNonRecordingSpan();
 hasSpansEnabled.mockReturnValue(true);
 vi.spyOn(spanUtils, 'getActiveSpan').mockReturnValue(activeSpan);
 const startInactiveSpanSpy = vi.spyOn(tracing, 'startInactiveSpan').mockReturnValue(fetchSpan);

 instrumentFetchRequest(
 {
 fetchData: { url, method: 'GET' },
 args: [url],
 startTimestamp: Date.now(),
 },
 () => true,
 () => false,
 {},
 { spanOrigin: 'auto.http.fetch' },
 );

 expect(startInactiveSpanSpy).toHaveBeenCalledWith({
 name: 'GET https://api.example.com/users/42',
 attributes: {
 url,
 type: 'fetch',
 'http.method': 'GET',
 'sentry.origin': 'auto.http.fetch',
 'sentry.op': 'http.client',
 'http.url': url,
 [URL_FULL]: url,
 'server.address': 'api.example.com',
 'http.query': '?include=profile',
 'http.fragment': '#bio',
 },
 });
 });
 });

 describe('trace header span', () => {
 beforeEach(() => {
 vi.clearAllMocks();
Expand Down

5 changes: 1 addition & 4 deletions
packages/ember/addon/utils/instrumentEmberAppInstanceForPerformance.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -14,10 +14,7 @@ import {
import type { Client, Span } from '@sentry/core';
import type { EmberRouterMain } from '../types';
import { getBackburner } from './performance';

const URL_FULL = 'url.full';
const URL_PATH = 'url.path';
const URL_TEMPLATE = 'url.template';
import { URL_FULL, URL_PATH, URL_TEMPLATE } from '@sentry/conventions/attributes';

type TransitionWithIntent = Transition & { intent?: { url?: string } };

Expand Down

1 change: 1 addition & 0 deletions
packages/ember/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -34,6 +34,7 @@
 "@embroider/macros": "^1.16.0",
 "@sentry/browser": "10.67.0",
 "@sentry/core": "10.67.0",
 "@sentry/conventions": "^0.16.0",
 "ember-auto-import": "^2.7.2",
 "ember-cli-babel": "^8.2.0",
 "ember-cli-htmlbars": "^6.1.1",
Expand Down

3 changes: 2 additions & 1 deletion
packages/nextjs/src/server/vercelQueuesMonitoring.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { URL_FULL } from '@sentry/conventions/attributes';
import type { Span } from '@sentry/core';
import { getIsolationScope, spanToJSON } from '@sentry/core';

Expand DownExpand Up@@ -76,7 +77,7 @@ export function maybeEnrichQueueProducerSpan(span: Span): void {
 const spanData = spanToJSON(span).data;

 // http.client spans have url.full attribute
 const urlFull = spanData?.['url.full'] as string | undefined;
 const urlFull = spanData?.[URL_FULL] as string | undefined;
 if (!urlFull) {
 return;
 }
Expand Down

11 changes: 3 additions & 8 deletions
packages/node/src/integrations/http.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,19 +1,14 @@
import type { RequestOptions } from 'node:http';
import type { HttpClientRequest, HttpIncomingMessage, HttpServerResponse, Span } from '@sentry/core';
import {
 defineIntegration,
 hasSpansEnabled,
 SEMANTIC_ATTRIBUTE_URL_FULL,
 stripDataUrlContent,
 getRequestUrlFromClientRequest,
} from '@sentry/core';
import { defineIntegration, hasSpansEnabled, stripDataUrlContent, getRequestUrlFromClientRequest } from '@sentry/core';
import type {
 NodeClient,
 SentryHttpInstrumentationOptions,
 HttpServerIntegrationOptions,
 HttpServerSpansIntegrationOptions,
} from '@sentry/node-core';
import { httpServerIntegration, httpServerSpansIntegration, instrumentHttpOutgoingRequests } from '@sentry/node-core';
import { URL_FULL } from '@sentry/conventions/attributes';

const INTEGRATION_NAME = 'Http' as const;

Expand DownExpand Up@@ -210,7 +205,7 @@ export const httpIntegration = defineIntegration((options: HttpOptions = {}) =>
 // TODO(v11): Update these to the Sentry semantic attributes.
 // https://getsentry.github.io/sentry-conventions/attributes/
 span.setAttribute('http.url', sanitizedUrl);
 span.setAttribute(SEMANTIC_ATTRIBUTE_URL_FULL, sanitizedUrl);
 span.setAttribute(URL_FULL, sanitizedUrl);
 span.updateName(`${request.method || 'GET'} ${sanitizedUrl}`);
 }
 options.instrumentation?.requestHook?.(span, request);
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
feat(core): Add url.full attribute to core fetch instrumentation#22415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Lms24
merged 3 commits into

from

Jul 21, 2026
 Merged


feat(core): Add url.full attribute to core fetch instrumentation
#22415
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
c7b54bc

ref(core): Add `url.full` attribute to core fetch instrumentation


Lms24 Jul 21, 2026
50f2d36

adjust tests


Lms24 Jul 21, 2026
9861918

fix bun build fail


Lms24 Jul 21, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
dev-packages/e2e-tests/test-applications/astro-6-cf-workers/tests/tracing.dynamic.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -242,6 +242,8 @@ test.describe('nested SSR routes (client, server, server request)', () => {
 'sentry.op': 'http.client',
 'sentry.origin': 'auto.http.fetch',
 url: expect.stringContaining('/api/user/myUsername123.json'),
 'http.url': 'http://localhost:3030/api/user/myUsername123.json',
 'url.full': 'http://localhost:3030/api/user/myUsername123.json',
 },
 });

Expand Down

1 change: 1 addition & 0 deletions
dev-packages/e2e-tests/test-applications/nextjs-pages-dir/tests/middleware.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -75,6 +75,7 @@ test('Should trace outgoing fetch requests inside middleware and create breadcru
 type: 'fetch',
 url: 'http://localhost:3030/',
 'http.url': 'http://localhost:3030/',
 'url.full': 'http://localhost:3030/',
 'server.address': 'localhost:3030',
 'sentry.op': 'http.client',
 'sentry.origin': 'auto.http.wintercg_fetch',
Expand Down

4 changes: 2 additions & 2 deletions
packages/browser-utils/src/metrics/browserMetrics.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,6 @@ import {
 isPrimitive,
 parseUrl,
 SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
 SEMANTIC_ATTRIBUTE_URL_FULL,
 setMeasurement,
 spanToJSON,
 stringMatchesSomePattern,
Expand All@@ -30,6 +29,7 @@ import { getActivationStart } from './web-vitals/lib/getActivationStart';
import { getNavigationEntry } from './web-vitals/lib/getNavigationEntry';
import { getVisibilityWatcher } from './web-vitals/lib/getVisibilityWatcher';
import { DEBUG_BUILD } from '../debug-build';
import { URL_FULL } from '@sentry/conventions/attributes';
interface NavigatorNetworkInformation {
 readonly connection?: NetworkInformation;
}
Expand DownExpand Up@@ -775,7 +775,7 @@ export function _addResourceSpans(

 attributes['url.same_origin'] = resourceUrl.includes(WINDOW.location.origin);

 attributes[SEMANTIC_ATTRIBUTE_URL_FULL] = resourceUrl;
 attributes[URL_FULL] = resourceUrl;

 _setResourceRequestAttributes(entry, attributes, [
 // https://developer.mozilla.org/en-US/docs/Web/API/PerformanceResourceTiming/responseStatus
Expand Down

5 changes: 2 additions & 3 deletions
packages/browser/src/integrations/graphqlClient.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,13 +5,12 @@ import {
 isString,
 SEMANTIC_ATTRIBUTE_HTTP_REQUEST_METHOD,
 SEMANTIC_ATTRIBUTE_SENTRY_OP,
 SEMANTIC_ATTRIBUTE_URL_FULL,
 spanToJSON,
 stringMatchesSomePattern,
} from '@sentry/core/browser';
import type { FetchHint, XhrHint } from '@sentry/browser-utils';
import { getBodyString, getFetchRequestArgBody, SENTRY_XHR_DATA_KEY } from '@sentry/browser-utils';
import { GRAPHQL_DOCUMENT } from '@sentry/conventions/attributes';
import { GRAPHQL_DOCUMENT, URL_FULL } from '@sentry/conventions/attributes';

interface GraphQLClientOptions {
 endpoints: Array<string | RegExp>;
Expand DownExpand Up@@ -71,7 +70,7 @@ function _updateSpanWithGraphQLData(client: Client, options: GraphQLClientOption

 // Fall back to `url` because fetch instrumentation only sets `http.url` for absolute URLs;
 // relative URLs end up only in `url` (see `getFetchSpanAttributes` in packages/core/src/fetch.ts).
 const httpUrl = spanAttributes[SEMANTIC_ATTRIBUTE_URL_FULL] || spanAttributes['http.url'] || spanAttributes['url'];
 const httpUrl = spanAttributes[URL_FULL] || spanAttributes['http.url'] || spanAttributes['url'];
 const httpMethod = spanAttributes[SEMANTIC_ATTRIBUTE_HTTP_REQUEST_METHOD] || spanAttributes['http.method'];

 if (!isString(httpUrl) || !isString(httpMethod)) {
Expand Down

3 changes: 2 additions & 1 deletion
packages/browser/src/integrations/httpcontext.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
import { defineIntegration, safeSetSpanJSONAttributes, SEMANTIC_ATTRIBUTE_SENTRY_OP } from '@sentry/core/browser';
import { getHttpRequestData, WINDOW } from '../helpers';
import { URL_FULL } from '@sentry/conventions/attributes';

/**
 * Collects information about HTTP request headers and
Expand DownExpand Up@@ -39,7 +40,7 @@ export const httpContextIntegration = defineIntegration(() => {
 safeSetSpanJSONAttributes(span, {
 // Coerce empty string to undefined so the helper's nullish check drops it,
 // rather than writing an empty `url.full` attribute onto the span.
'url.full': spanOp !== 'http.client' ? reqData.url : undefined,
[URL_FULL]: spanOp !== 'http.client' ? reqData.url : undefined,
 'http.request.header.user_agent': reqData.headers['User-Agent'],
 'http.request.header.referer': reqData.headers['Referer'],
 });
Expand Down

8 changes: 5 additions & 3 deletions
packages/browser/src/tracing/request.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -40,6 +40,7 @@ import {
} from '@sentry/browser-utils';
import type { BrowserClient } from '../client';
import { baggageHeaderHasSentryValues, createHeadersSafely, getFullURL, isPerformanceResourceTiming } from './utils';
import { HTTP_URL, URL_FULL } from '@sentry/conventions/attributes';

/** Options for Request Instrumentation */
export interface RequestInstrumentationOptions {
Expand DownExpand Up@@ -172,10 +173,11 @@ export function instrumentOutgoingRequests(client: Client, _options?: Partial<Re
 const host = fullUrl ? parseUrl(fullUrl).host : undefined;
 const sanitizedFullUrl = fullUrl ? stripDataUrlContent(fullUrl) : undefined;
 createdSpan.setAttributes({
 'http.url': sanitizedFullUrl,
 // oxlint-disable-next-line typescript/no-deprecated
 [HTTP_URL]: sanitizedFullUrl,
 // `url.full` must match `http.url`. Setting it here ensures parentless `http.client`
 // segment spans don't get `url.full` backfilled with the host page URL (see httpContextIntegration).
'url.full': sanitizedFullUrl,
[URL_FULL]: sanitizedFullUrl,
 'server.address': host,
 });

Expand DownExpand Up@@ -393,7 +395,7 @@ function xhrCallback(
 'http.url': sanitizedFullUrl,
 // `url.full` must match `http.url`. Setting it here ensures parentless `http.client`
 // segment spans don't get `url.full` backfilled with the host page URL (see httpContextIntegration).
'url.full': sanitizedFullUrl,
[URL_FULL]: sanitizedFullUrl,
 'server.address': parsedUrl?.host,
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.http.browser',
 [SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'http.client',
Expand Down

25 changes: 23 additions & 2 deletions
packages/browser/test/integrations/graphqlClient.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@ import type { Client } from '@sentry/core/browser';
import { SentrySpan, spanToJSON } from '@sentry/core/browser';
import type { FetchHint, XhrHint } from '@sentry/browser-utils';
import { SENTRY_XHR_DATA_KEY } from '@sentry/browser-utils';
import { URL_FULL } from '@sentry/conventions/attributes';
import { describe, expect, test } from 'vitest';
import {
 _getGraphQLOperation,
Expand DownExpand Up@@ -352,14 +353,15 @@ describe('GraphqlClient', () => {
 extensions: {},
 };

 test('enriches http.client span for absolute URLs (http.url attribute)', () => {
 test('enriches http.client span for absolute URLs', () => {
 const handler = setupHandler([/\/graphql$/]);
 const span = new SentrySpan({
 name: 'POST http://localhost:4000/graphql',
 op: 'http.client',
 attributes: {
 'http.method': 'POST',
 'http.url': 'http://localhost:4000/graphql',
 [URL_FULL]: 'http://localhost:4000/graphql',
 url: 'http://localhost:4000/graphql',
 },
 });
Expand All@@ -371,9 +373,27 @@ describe('GraphqlClient', () => {
 expect(json.data['graphql.document']).toBe(requestBody.query);
 });

 test('enriches http.client span when only url.full is present', () => {
 const handler = setupHandler([/\/graphql$/]);
 const span = new SentrySpan({
 name: 'POST http://localhost:4000/graphql',
 op: 'http.client',
 attributes: {
 'http.method': 'POST',
 [URL_FULL]: 'http://localhost:4000/graphql',
 },
 });

 handler(span, makeFetchHint('http://localhost:4000/graphql', requestBody));

 const json = spanToJSON(span);
 expect(json.description).toBe('POST http://localhost:4000/graphql (query GetHello)');
 expect(json.data['graphql.document']).toBe(requestBody.query);
 });

 test('enriches http.client span for relative URLs (only url attribute)', () => {
 const handler = setupHandler([/\/graphql$/]);
 // Fetch instrumentation does NOT set http.urlfor relative URLs — only `url`.
 // Fetch instrumentation does not set `http.url` or `url.full` for relative URLs.
 const span = new SentrySpan({
 name: 'POST /graphql',
 op: 'http.client',
Expand DownExpand Up@@ -433,6 +453,7 @@ describe('GraphqlClient', () => {
 attributes: {
 'http.method': 'POST',
 'http.url': 'http://localhost:4000/graphql',
 [URL_FULL]: 'http://localhost:4000/graphql',
 url: 'http://localhost:4000/graphql',
 },
 });
Expand Down

1 change: 1 addition & 0 deletions
packages/bun/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,7 @@
 "dependencies": {
 "@apm-js-collab/code-transformer-bundler-plugins": "^0.7.1",
 "@sentry/core": "10.67.0",
 "@sentry/conventions": "^0.16.0",
 "@sentry/node": "10.67.0",
 "@sentry/server-utils": "10.67.0"
 },
Expand Down

3 changes: 2 additions & 1 deletion
packages/bun/src/integrations/bunserver.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@ import {
 withIsolationScope,
} from '@sentry/core';
import type { ServeOptions } from 'bun';
import { URL_FULL } from '@sentry/conventions/attributes';

const INTEGRATION_NAME = 'BunServer' as const;

Expand DownExpand Up@@ -282,7 +283,7 @@ function getSpanAttributesFromParsedUrl(
 attributes['url.path'] = parsedUrl.pathname;
 }
 if (!isURLObjectRelative(parsedUrl)) {
 attributes['url.full'] = parsedUrl.href;
 attributes[URL_FULL] = parsedUrl.href;
 if (parsedUrl.port) {
 attributes['url.port'] = parsedUrl.port;
 }
Expand Down

5 changes: 4 additions & 1 deletion
packages/core/src/fetch.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { HTTP_URL, URL_FULL } from '@sentry/conventions/attributes';
import { getClient } from './currentScopes';
import { SEMANTIC_ATTRIBUTE_SENTRY_OP, SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN } from './semanticAttributes';
import { setHttpStatus, SPAN_STATUS_ERROR, spanIsIgnored, startInactiveSpan } from './tracing';
Expand DownExpand Up@@ -388,7 +389,9 @@ function getFetchSpanAttributes(
 };
 if (parsedUrl) {
 if (!isURLObjectRelative(parsedUrl)) {
 attributes['http.url'] = stripDataUrlContent(parsedUrl.href);
 // oxlint-disable-next-line typescript/no-deprecated
 attributes[HTTP_URL] = stripDataUrlContent(parsedUrl.href);
 attributes[URL_FULL] = stripDataUrlContent(parsedUrl.href);
Comment thread
cursor[bot] marked this conversation as resolved.

 attributes['server.address'] = parsedUrl.host;
 }
 if (parsedUrl.search) {
Expand Down

5 changes: 3 additions & 2 deletions
packages/core/src/integrations/requestdata.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,7 @@ import { parseCookie } from '../utils/cookie';
import { httpHeadersToSpanAttributes } from '../utils/request';
import { getClientIPAddress, ipHeaderNames } from '../vendor/getIpAddress';
import { safeSetSpanJSONAttributes } from '../tracing/spans/captureSpan';
import { URL_FULL, URL_QUERY } from '@sentry/conventions/attributes';

interface RequestDataIncludeOptions {
 cookies?: boolean;
Expand DownExpand Up@@ -137,15 +138,15 @@ function addNormalizedRequestDataToSpan(
 const attributes: Record<string, unknown> = {};

 if (requestData.url) {
 attributes['url.full'] = requestData.url;
 attributes[URL_FULL] = requestData.url;
 }

 if (requestData.method) {
 attributes['http.request.method'] = requestData.method;
 }

 if (requestData.query_string) {
 attributes['url.query'] = normalizeQueryString(requestData.query_string);
 attributes[URL_QUERY] = normalizeQueryString(requestData.query_string);
 }

 safeSetSpanJSONAttributes(span, attributes);
Expand Down

3 changes: 3 additions & 0 deletions
packages/core/src/semanticAttributes.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -110,6 +110,9 @@ export const SEMANTIC_ATTRIBUTE_CACHE_ITEM_SIZE = 'cache.item_size';

/** TODO: Remove these once we update to latest semantic conventions */
export const SEMANTIC_ATTRIBUTE_HTTP_REQUEST_METHOD = 'http.request.method';
/**
 * @deprecated Use `URL_FULL` `@sentry/conventions/attributes` instead.
 */
export const SEMANTIC_ATTRIBUTE_URL_FULL = 'url.full';

/**
Expand Down

4 changes: 2 additions & 2 deletions
packages/core/src/utils/url.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
import { URL_FULL } from '@sentry/conventions/attributes';
import {
 SEMANTIC_ATTRIBUTE_HTTP_REQUEST_METHOD,
 SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
 SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
 SEMANTIC_ATTRIBUTE_URL_FULL,
} from '../semanticAttributes';
import type { SpanAttributes } from '../types/span';

Expand DownExpand Up@@ -188,7 +188,7 @@ export function getHttpSpanDetailsFromUrlObject(
 }

 if (!isURLObjectRelative(urlObject)) {
 attributes[SEMANTIC_ATTRIBUTE_URL_FULL] = urlObject.href;
 attributes[URL_FULL] = urlObject.href;
 if (urlObject.port) {
 attributes['url.port'] = urlObject.port;
 }
Expand Down

44 changes: 44 additions & 0 deletions
packages/core/test/lib/fetch.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { URL_FULL } from '@sentry/conventions/attributes';
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
import type { HandlerDataFetch } from '../../src';
import { _INTERNAL_getTracingHeadersForFetchRequest, instrumentFetchRequest } from '../../src/fetch';
Expand DownExpand Up@@ -444,6 +445,49 @@ describe('_INTERNAL_getTracingHeadersForFetchRequest', () => {
});

describe('instrumentFetchRequest', () => {
 describe('span attributes', () => {
 afterEach(() => {
 vi.restoreAllMocks();
 });

 it('sets url.full for absolute URLs', () => {
 const url = 'https://api.example.com/users/42?include=profile#bio';
 const activeSpan = new SentryNonRecordingSpan();
 const fetchSpan = new SentryNonRecordingSpan();
 hasSpansEnabled.mockReturnValue(true);
 vi.spyOn(spanUtils, 'getActiveSpan').mockReturnValue(activeSpan);
 const startInactiveSpanSpy = vi.spyOn(tracing, 'startInactiveSpan').mockReturnValue(fetchSpan);

 instrumentFetchRequest(
 {
 fetchData: { url, method: 'GET' },
 args: [url],
 startTimestamp: Date.now(),
 },
 () => true,
 () => false,
 {},
 { spanOrigin: 'auto.http.fetch' },
 );

 expect(startInactiveSpanSpy).toHaveBeenCalledWith({
 name: 'GET https://api.example.com/users/42',
 attributes: {
 url,
 type: 'fetch',
 'http.method': 'GET',
 'sentry.origin': 'auto.http.fetch',
 'sentry.op': 'http.client',
 'http.url': url,
 [URL_FULL]: url,
 'server.address': 'api.example.com',
 'http.query': '?include=profile',
 'http.fragment': '#bio',
 },
 });
 });
 });

 describe('trace header span', () => {
 beforeEach(() => {
 vi.clearAllMocks();
Expand Down

5 changes: 1 addition & 4 deletions
packages/ember/addon/utils/instrumentEmberAppInstanceForPerformance.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -14,10 +14,7 @@ import {
import type { Client, Span } from '@sentry/core';
import type { EmberRouterMain } from '../types';
import { getBackburner } from './performance';

const URL_FULL = 'url.full';
const URL_PATH = 'url.path';
const URL_TEMPLATE = 'url.template';
import { URL_FULL, URL_PATH, URL_TEMPLATE } from '@sentry/conventions/attributes';

type TransitionWithIntent = Transition & { intent?: { url?: string } };

Expand Down

1 change: 1 addition & 0 deletions
packages/ember/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -34,6 +34,7 @@
 "@embroider/macros": "^1.16.0",
 "@sentry/browser": "10.67.0",
 "@sentry/core": "10.67.0",
 "@sentry/conventions": "^0.16.0",
 "ember-auto-import": "^2.7.2",
 "ember-cli-babel": "^8.2.0",
 "ember-cli-htmlbars": "^6.1.1",
Expand Down

3 changes: 2 additions & 1 deletion
packages/nextjs/src/server/vercelQueuesMonitoring.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { URL_FULL } from '@sentry/conventions/attributes';
import type { Span } from '@sentry/core';
import { getIsolationScope, spanToJSON } from '@sentry/core';

Expand DownExpand Up@@ -76,7 +77,7 @@ export function maybeEnrichQueueProducerSpan(span: Span): void {
 const spanData = spanToJSON(span).data;

 // http.client spans have url.full attribute
 const urlFull = spanData?.['url.full'] as string | undefined;
 const urlFull = spanData?.[URL_FULL] as string | undefined;
 if (!urlFull) {
 return;
 }
Expand Down

11 changes: 3 additions & 8 deletions
packages/node/src/integrations/http.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,19 +1,14 @@
import type { RequestOptions } from 'node:http';
import type { HttpClientRequest, HttpIncomingMessage, HttpServerResponse, Span } from '@sentry/core';
import {
 defineIntegration,
 hasSpansEnabled,
 SEMANTIC_ATTRIBUTE_URL_FULL,
 stripDataUrlContent,
 getRequestUrlFromClientRequest,
} from '@sentry/core';
import { defineIntegration, hasSpansEnabled, stripDataUrlContent, getRequestUrlFromClientRequest } from '@sentry/core';
import type {
 NodeClient,
 SentryHttpInstrumentationOptions,
 HttpServerIntegrationOptions,
 HttpServerSpansIntegrationOptions,
} from '@sentry/node-core';
import { httpServerIntegration, httpServerSpansIntegration, instrumentHttpOutgoingRequests } from '@sentry/node-core';
import { URL_FULL } from '@sentry/conventions/attributes';

const INTEGRATION_NAME = 'Http' as const;

Expand DownExpand Up@@ -210,7 +205,7 @@ export const httpIntegration = defineIntegration((options: HttpOptions = {}) =>
 // TODO(v11): Update these to the Sentry semantic attributes.
 // https://getsentry.github.io/sentry-conventions/attributes/
 span.setAttribute('http.url', sanitizedUrl);
 span.setAttribute(SEMANTIC_ATTRIBUTE_URL_FULL, sanitizedUrl);
 span.setAttribute(URL_FULL, sanitizedUrl);
 span.updateName(`${request.method || 'GET'} ${sanitizedUrl}`);
 }
 options.instrumentation?.requestHook?.(span, request);
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(core): Add url.full attribute to core fetch instrumentation#22415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Lms24
merged 3 commits into

from

Jul 21, 2026
 Merged


feat(core): Add url.full attribute to core fetch instrumentation
#22415
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
c7b54bc

ref(core): Add `url.full` attribute to core fetch instrumentation


Lms24 Jul 21, 2026
50f2d36

adjust tests


Lms24 Jul 21, 2026
9861918

fix bun build fail


Lms24 Jul 21, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
dev-packages/e2e-tests/test-applications/astro-6-cf-workers/tests/tracing.dynamic.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -242,6 +242,8 @@ test.describe('nested SSR routes (client, server, server request)', () => {
 'sentry.op': 'http.client',
 'sentry.origin': 'auto.http.fetch',
 url: expect.stringContaining('/api/user/myUsername123.json'),
 'http.url': 'http://localhost:3030/api/user/myUsername123.json',
 'url.full': 'http://localhost:3030/api/user/myUsername123.json',
 },
 });

Expand Down

1 change: 1 addition & 0 deletions
dev-packages/e2e-tests/test-applications/nextjs-pages-dir/tests/middleware.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -75,6 +75,7 @@ test('Should trace outgoing fetch requests inside middleware and create breadcru
 type: 'fetch',
 url: 'http://localhost:3030/',
 'http.url': 'http://localhost:3030/',
 'url.full': 'http://localhost:3030/',
 'server.address': 'localhost:3030',
 'sentry.op': 'http.client',
 'sentry.origin': 'auto.http.wintercg_fetch',
Expand Down

4 changes: 2 additions & 2 deletions
packages/browser-utils/src/metrics/browserMetrics.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,6 @@ import {
 isPrimitive,
 parseUrl,
 SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
 SEMANTIC_ATTRIBUTE_URL_FULL,
 setMeasurement,
 spanToJSON,
 stringMatchesSomePattern,
Expand All@@ -30,6 +29,7 @@ import { getActivationStart } from './web-vitals/lib/getActivationStart';
import { getNavigationEntry } from './web-vitals/lib/getNavigationEntry';
import { getVisibilityWatcher } from './web-vitals/lib/getVisibilityWatcher';
import { DEBUG_BUILD } from '../debug-build';
import { URL_FULL } from '@sentry/conventions/attributes';
interface NavigatorNetworkInformation {
 readonly connection?: NetworkInformation;
}
Expand DownExpand Up@@ -775,7 +775,7 @@ export function _addResourceSpans(

 attributes['url.same_origin'] = resourceUrl.includes(WINDOW.location.origin);

 attributes[SEMANTIC_ATTRIBUTE_URL_FULL] = resourceUrl;
 attributes[URL_FULL] = resourceUrl;

 _setResourceRequestAttributes(entry, attributes, [
 // https://developer.mozilla.org/en-US/docs/Web/API/PerformanceResourceTiming/responseStatus
Expand Down

5 changes: 2 additions & 3 deletions
packages/browser/src/integrations/graphqlClient.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,13 +5,12 @@ import {
 isString,
 SEMANTIC_ATTRIBUTE_HTTP_REQUEST_METHOD,
 SEMANTIC_ATTRIBUTE_SENTRY_OP,
 SEMANTIC_ATTRIBUTE_URL_FULL,
 spanToJSON,
 stringMatchesSomePattern,
} from '@sentry/core/browser';
import type { FetchHint, XhrHint } from '@sentry/browser-utils';
import { getBodyString, getFetchRequestArgBody, SENTRY_XHR_DATA_KEY } from '@sentry/browser-utils';
import { GRAPHQL_DOCUMENT } from '@sentry/conventions/attributes';
import { GRAPHQL_DOCUMENT, URL_FULL } from '@sentry/conventions/attributes';

interface GraphQLClientOptions {
 endpoints: Array<string | RegExp>;
Expand DownExpand Up@@ -71,7 +70,7 @@ function _updateSpanWithGraphQLData(client: Client, options: GraphQLClientOption

 // Fall back to `url` because fetch instrumentation only sets `http.url` for absolute URLs;
 // relative URLs end up only in `url` (see `getFetchSpanAttributes` in packages/core/src/fetch.ts).
 const httpUrl = spanAttributes[SEMANTIC_ATTRIBUTE_URL_FULL] || spanAttributes['http.url'] || spanAttributes['url'];
 const httpUrl = spanAttributes[URL_FULL] || spanAttributes['http.url'] || spanAttributes['url'];
 const httpMethod = spanAttributes[SEMANTIC_ATTRIBUTE_HTTP_REQUEST_METHOD] || spanAttributes['http.method'];

 if (!isString(httpUrl) || !isString(httpMethod)) {
Expand Down

3 changes: 2 additions & 1 deletion
packages/browser/src/integrations/httpcontext.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
import { defineIntegration, safeSetSpanJSONAttributes, SEMANTIC_ATTRIBUTE_SENTRY_OP } from '@sentry/core/browser';
import { getHttpRequestData, WINDOW } from '../helpers';
import { URL_FULL } from '@sentry/conventions/attributes';

/**
 * Collects information about HTTP request headers and
Expand DownExpand Up@@ -39,7 +40,7 @@ export const httpContextIntegration = defineIntegration(() => {
 safeSetSpanJSONAttributes(span, {
 // Coerce empty string to undefined so the helper's nullish check drops it,
 // rather than writing an empty `url.full` attribute onto the span.
'url.full': spanOp !== 'http.client' ? reqData.url : undefined,
[URL_FULL]: spanOp !== 'http.client' ? reqData.url : undefined,
 'http.request.header.user_agent': reqData.headers['User-Agent'],
 'http.request.header.referer': reqData.headers['Referer'],
 });
Expand Down

8 changes: 5 additions & 3 deletions
packages/browser/src/tracing/request.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -40,6 +40,7 @@ import {
} from '@sentry/browser-utils';
import type { BrowserClient } from '../client';
import { baggageHeaderHasSentryValues, createHeadersSafely, getFullURL, isPerformanceResourceTiming } from './utils';
import { HTTP_URL, URL_FULL } from '@sentry/conventions/attributes';

/** Options for Request Instrumentation */
export interface RequestInstrumentationOptions {
Expand DownExpand Up@@ -172,10 +173,11 @@ export function instrumentOutgoingRequests(client: Client, _options?: Partial<Re
 const host = fullUrl ? parseUrl(fullUrl).host : undefined;
 const sanitizedFullUrl = fullUrl ? stripDataUrlContent(fullUrl) : undefined;
 createdSpan.setAttributes({
 'http.url': sanitizedFullUrl,
 // oxlint-disable-next-line typescript/no-deprecated
 [HTTP_URL]: sanitizedFullUrl,
 // `url.full` must match `http.url`. Setting it here ensures parentless `http.client`
 // segment spans don't get `url.full` backfilled with the host page URL (see httpContextIntegration).
'url.full': sanitizedFullUrl,
[URL_FULL]: sanitizedFullUrl,
 'server.address': host,
 });

Expand DownExpand Up@@ -393,7 +395,7 @@ function xhrCallback(
 'http.url': sanitizedFullUrl,
 // `url.full` must match `http.url`. Setting it here ensures parentless `http.client`
 // segment spans don't get `url.full` backfilled with the host page URL (see httpContextIntegration).
'url.full': sanitizedFullUrl,
[URL_FULL]: sanitizedFullUrl,
 'server.address': parsedUrl?.host,
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.http.browser',
 [SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'http.client',
Expand Down

25 changes: 23 additions & 2 deletions
packages/browser/test/integrations/graphqlClient.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@ import type { Client } from '@sentry/core/browser';
import { SentrySpan, spanToJSON } from '@sentry/core/browser';
import type { FetchHint, XhrHint } from '@sentry/browser-utils';
import { SENTRY_XHR_DATA_KEY } from '@sentry/browser-utils';
import { URL_FULL } from '@sentry/conventions/attributes';
import { describe, expect, test } from 'vitest';
import {
 _getGraphQLOperation,
Expand DownExpand Up@@ -352,14 +353,15 @@ describe('GraphqlClient', () => {
 extensions: {},
 };

 test('enriches http.client span for absolute URLs (http.url attribute)', () => {
 test('enriches http.client span for absolute URLs', () => {
 const handler = setupHandler([/\/graphql$/]);
 const span = new SentrySpan({
 name: 'POST http://localhost:4000/graphql',
 op: 'http.client',
 attributes: {
 'http.method': 'POST',
 'http.url': 'http://localhost:4000/graphql',
 [URL_FULL]: 'http://localhost:4000/graphql',
 url: 'http://localhost:4000/graphql',
 },
 });
Expand All@@ -371,9 +373,27 @@ describe('GraphqlClient', () => {
 expect(json.data['graphql.document']).toBe(requestBody.query);
 });

 test('enriches http.client span when only url.full is present', () => {
 const handler = setupHandler([/\/graphql$/]);
 const span = new SentrySpan({
 name: 'POST http://localhost:4000/graphql',
 op: 'http.client',
 attributes: {
 'http.method': 'POST',
 [URL_FULL]: 'http://localhost:4000/graphql',
 },
 });

 handler(span, makeFetchHint('http://localhost:4000/graphql', requestBody));

 const json = spanToJSON(span);
 expect(json.description).toBe('POST http://localhost:4000/graphql (query GetHello)');
 expect(json.data['graphql.document']).toBe(requestBody.query);
 });

 test('enriches http.client span for relative URLs (only url attribute)', () => {
 const handler = setupHandler([/\/graphql$/]);
 // Fetch instrumentation does NOT set http.urlfor relative URLs — only `url`.
 // Fetch instrumentation does not set `http.url` or `url.full` for relative URLs.
 const span = new SentrySpan({
 name: 'POST /graphql',
 op: 'http.client',
Expand DownExpand Up@@ -433,6 +453,7 @@ describe('GraphqlClient', () => {
 attributes: {
 'http.method': 'POST',
 'http.url': 'http://localhost:4000/graphql',
 [URL_FULL]: 'http://localhost:4000/graphql',
 url: 'http://localhost:4000/graphql',
 },
 });
Expand Down

1 change: 1 addition & 0 deletions
packages/bun/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,7 @@
 "dependencies": {
 "@apm-js-collab/code-transformer-bundler-plugins": "^0.7.1",
 "@sentry/core": "10.67.0",
 "@sentry/conventions": "^0.16.0",
 "@sentry/node": "10.67.0",
 "@sentry/server-utils": "10.67.0"
 },
Expand Down

3 changes: 2 additions & 1 deletion
packages/bun/src/integrations/bunserver.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@ import {
 withIsolationScope,
} from '@sentry/core';
import type { ServeOptions } from 'bun';
import { URL_FULL } from '@sentry/conventions/attributes';

const INTEGRATION_NAME = 'BunServer' as const;

Expand DownExpand Up@@ -282,7 +283,7 @@ function getSpanAttributesFromParsedUrl(
 attributes['url.path'] = parsedUrl.pathname;
 }
 if (!isURLObjectRelative(parsedUrl)) {
 attributes['url.full'] = parsedUrl.href;
 attributes[URL_FULL] = parsedUrl.href;
 if (parsedUrl.port) {
 attributes['url.port'] = parsedUrl.port;
 }
Expand Down

5 changes: 4 additions & 1 deletion
packages/core/src/fetch.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { HTTP_URL, URL_FULL } from '@sentry/conventions/attributes';
import { getClient } from './currentScopes';
import { SEMANTIC_ATTRIBUTE_SENTRY_OP, SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN } from './semanticAttributes';
import { setHttpStatus, SPAN_STATUS_ERROR, spanIsIgnored, startInactiveSpan } from './tracing';
Expand DownExpand Up@@ -388,7 +389,9 @@ function getFetchSpanAttributes(
 };
 if (parsedUrl) {
 if (!isURLObjectRelative(parsedUrl)) {
 attributes['http.url'] = stripDataUrlContent(parsedUrl.href);
 // oxlint-disable-next-line typescript/no-deprecated
 attributes[HTTP_URL] = stripDataUrlContent(parsedUrl.href);
 attributes[URL_FULL] = stripDataUrlContent(parsedUrl.href);
Comment thread
cursor[bot] marked this conversation as resolved.

 attributes['server.address'] = parsedUrl.host;
 }
 if (parsedUrl.search) {
Expand Down

5 changes: 3 additions & 2 deletions
packages/core/src/integrations/requestdata.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,7 @@ import { parseCookie } from '../utils/cookie';
import { httpHeadersToSpanAttributes } from '../utils/request';
import { getClientIPAddress, ipHeaderNames } from '../vendor/getIpAddress';
import { safeSetSpanJSONAttributes } from '../tracing/spans/captureSpan';
import { URL_FULL, URL_QUERY } from '@sentry/conventions/attributes';

interface RequestDataIncludeOptions {
 cookies?: boolean;
Expand DownExpand Up@@ -137,15 +138,15 @@ function addNormalizedRequestDataToSpan(
 const attributes: Record<string, unknown> = {};

 if (requestData.url) {
 attributes['url.full'] = requestData.url;
 attributes[URL_FULL] = requestData.url;
 }

 if (requestData.method) {
 attributes['http.request.method'] = requestData.method;
 }

 if (requestData.query_string) {
 attributes['url.query'] = normalizeQueryString(requestData.query_string);
 attributes[URL_QUERY] = normalizeQueryString(requestData.query_string);
 }

 safeSetSpanJSONAttributes(span, attributes);
Expand Down

3 changes: 3 additions & 0 deletions
packages/core/src/semanticAttributes.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -110,6 +110,9 @@ export const SEMANTIC_ATTRIBUTE_CACHE_ITEM_SIZE = 'cache.item_size';

/** TODO: Remove these once we update to latest semantic conventions */
export const SEMANTIC_ATTRIBUTE_HTTP_REQUEST_METHOD = 'http.request.method';
/**
 * @deprecated Use `URL_FULL` `@sentry/conventions/attributes` instead.
 */
export const SEMANTIC_ATTRIBUTE_URL_FULL = 'url.full';

/**
Expand Down

4 changes: 2 additions & 2 deletions
packages/core/src/utils/url.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
import { URL_FULL } from '@sentry/conventions/attributes';
import {
 SEMANTIC_ATTRIBUTE_HTTP_REQUEST_METHOD,
 SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
 SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
 SEMANTIC_ATTRIBUTE_URL_FULL,
} from '../semanticAttributes';
import type { SpanAttributes } from '../types/span';

Expand DownExpand Up@@ -188,7 +188,7 @@ export function getHttpSpanDetailsFromUrlObject(
 }

 if (!isURLObjectRelative(urlObject)) {
 attributes[SEMANTIC_ATTRIBUTE_URL_FULL] = urlObject.href;
 attributes[URL_FULL] = urlObject.href;
 if (urlObject.port) {
 attributes['url.port'] = urlObject.port;
 }
Expand Down

44 changes: 44 additions & 0 deletions
packages/core/test/lib/fetch.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { URL_FULL } from '@sentry/conventions/attributes';
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
import type { HandlerDataFetch } from '../../src';
import { _INTERNAL_getTracingHeadersForFetchRequest, instrumentFetchRequest } from '../../src/fetch';
Expand DownExpand Up@@ -444,6 +445,49 @@ describe('_INTERNAL_getTracingHeadersForFetchRequest', () => {
});

describe('instrumentFetchRequest', () => {
 describe('span attributes', () => {
 afterEach(() => {
 vi.restoreAllMocks();
 });

 it('sets url.full for absolute URLs', () => {
 const url = 'https://api.example.com/users/42?include=profile#bio';
 const activeSpan = new SentryNonRecordingSpan();
 const fetchSpan = new SentryNonRecordingSpan();
 hasSpansEnabled.mockReturnValue(true);
 vi.spyOn(spanUtils, 'getActiveSpan').mockReturnValue(activeSpan);
 const startInactiveSpanSpy = vi.spyOn(tracing, 'startInactiveSpan').mockReturnValue(fetchSpan);

 instrumentFetchRequest(
 {
 fetchData: { url, method: 'GET' },
 args: [url],
 startTimestamp: Date.now(),
 },
 () => true,
 () => false,
 {},
 { spanOrigin: 'auto.http.fetch' },
 );

 expect(startInactiveSpanSpy).toHaveBeenCalledWith({
 name: 'GET https://api.example.com/users/42',
 attributes: {
 url,
 type: 'fetch',
 'http.method': 'GET',
 'sentry.origin': 'auto.http.fetch',
 'sentry.op': 'http.client',
 'http.url': url,
 [URL_FULL]: url,
 'server.address': 'api.example.com',
 'http.query': '?include=profile',
 'http.fragment': '#bio',
 },
 });
 });
 });

 describe('trace header span', () => {
 beforeEach(() => {
 vi.clearAllMocks();
Expand Down

5 changes: 1 addition & 4 deletions
packages/ember/addon/utils/instrumentEmberAppInstanceForPerformance.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -14,10 +14,7 @@ import {
import type { Client, Span } from '@sentry/core';
import type { EmberRouterMain } from '../types';
import { getBackburner } from './performance';

const URL_FULL = 'url.full';
const URL_PATH = 'url.path';
const URL_TEMPLATE = 'url.template';
import { URL_FULL, URL_PATH, URL_TEMPLATE } from '@sentry/conventions/attributes';

type TransitionWithIntent = Transition & { intent?: { url?: string } };

Expand Down

1 change: 1 addition & 0 deletions
packages/ember/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -34,6 +34,7 @@
 "@embroider/macros": "^1.16.0",
 "@sentry/browser": "10.67.0",
 "@sentry/core": "10.67.0",
 "@sentry/conventions": "^0.16.0",
 "ember-auto-import": "^2.7.2",
 "ember-cli-babel": "^8.2.0",
 "ember-cli-htmlbars": "^6.1.1",
Expand Down

3 changes: 2 additions & 1 deletion
packages/nextjs/src/server/vercelQueuesMonitoring.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { URL_FULL } from '@sentry/conventions/attributes';
import type { Span } from '@sentry/core';
import { getIsolationScope, spanToJSON } from '@sentry/core';

Expand DownExpand Up@@ -76,7 +77,7 @@ export function maybeEnrichQueueProducerSpan(span: Span): void {
 const spanData = spanToJSON(span).data;

 // http.client spans have url.full attribute
 const urlFull = spanData?.['url.full'] as string | undefined;
 const urlFull = spanData?.[URL_FULL] as string | undefined;
 if (!urlFull) {
 return;
 }
Expand Down

11 changes: 3 additions & 8 deletions
packages/node/src/integrations/http.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,19 +1,14 @@
import type { RequestOptions } from 'node:http';
import type { HttpClientRequest, HttpIncomingMessage, HttpServerResponse, Span } from '@sentry/core';
import {
 defineIntegration,
 hasSpansEnabled,
 SEMANTIC_ATTRIBUTE_URL_FULL,
 stripDataUrlContent,
 getRequestUrlFromClientRequest,
} from '@sentry/core';
import { defineIntegration, hasSpansEnabled, stripDataUrlContent, getRequestUrlFromClientRequest } from '@sentry/core';
import type {
 NodeClient,
 SentryHttpInstrumentationOptions,
 HttpServerIntegrationOptions,
 HttpServerSpansIntegrationOptions,
} from '@sentry/node-core';
import { httpServerIntegration, httpServerSpansIntegration, instrumentHttpOutgoingRequests } from '@sentry/node-core';
import { URL_FULL } from '@sentry/conventions/attributes';

const INTEGRATION_NAME = 'Http' as const;

Expand DownExpand Up@@ -210,7 +205,7 @@ export const httpIntegration = defineIntegration((options: HttpOptions = {}) =>
 // TODO(v11): Update these to the Sentry semantic attributes.
 // https://getsentry.github.io/sentry-conventions/attributes/
 span.setAttribute('http.url', sanitizedUrl);
 span.setAttribute(SEMANTIC_ATTRIBUTE_URL_FULL, sanitizedUrl);
 span.setAttribute(URL_FULL, sanitizedUrl);
 span.updateName(`${request.method || 'GET'} ${sanitizedUrl}`);
 }
 options.instrumentation?.requestHook?.(span, request);
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(core): Add url.full attribute to core fetch instrumentation#22415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Lms24
merged 3 commits into

from

Jul 21, 2026
 Merged


feat(core): Add url.full attribute to core fetch instrumentation
#22415
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
c7b54bc

ref(core): Add `url.full` attribute to core fetch instrumentation


Lms24 Jul 21, 2026
50f2d36

adjust tests


Lms24 Jul 21, 2026
9861918

fix bun build fail


Lms24 Jul 21, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
dev-packages/e2e-tests/test-applications/astro-6-cf-workers/tests/tracing.dynamic.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -242,6 +242,8 @@ test.describe('nested SSR routes (client, server, server request)', () => {
 'sentry.op': 'http.client',
 'sentry.origin': 'auto.http.fetch',
 url: expect.stringContaining('/api/user/myUsername123.json'),
 'http.url': 'http://localhost:3030/api/user/myUsername123.json',
 'url.full': 'http://localhost:3030/api/user/myUsername123.json',
 },
 });

Expand Down

1 change: 1 addition & 0 deletions
dev-packages/e2e-tests/test-applications/nextjs-pages-dir/tests/middleware.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -75,6 +75,7 @@ test('Should trace outgoing fetch requests inside middleware and create breadcru
 type: 'fetch',
 url: 'http://localhost:3030/',
 'http.url': 'http://localhost:3030/',
 'url.full': 'http://localhost:3030/',
 'server.address': 'localhost:3030',
 'sentry.op': 'http.client',
 'sentry.origin': 'auto.http.wintercg_fetch',
Expand Down

4 changes: 2 additions & 2 deletions
packages/browser-utils/src/metrics/browserMetrics.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,6 @@ import {
 isPrimitive,
 parseUrl,
 SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
 SEMANTIC_ATTRIBUTE_URL_FULL,
 setMeasurement,
 spanToJSON,
 stringMatchesSomePattern,
Expand All@@ -30,6 +29,7 @@ import { getActivationStart } from './web-vitals/lib/getActivationStart';
import { getNavigationEntry } from './web-vitals/lib/getNavigationEntry';
import { getVisibilityWatcher } from './web-vitals/lib/getVisibilityWatcher';
import { DEBUG_BUILD } from '../debug-build';
import { URL_FULL } from '@sentry/conventions/attributes';
interface NavigatorNetworkInformation {
 readonly connection?: NetworkInformation;
}
Expand DownExpand Up@@ -775,7 +775,7 @@ export function _addResourceSpans(

 attributes['url.same_origin'] = resourceUrl.includes(WINDOW.location.origin);

 attributes[SEMANTIC_ATTRIBUTE_URL_FULL] = resourceUrl;
 attributes[URL_FULL] = resourceUrl;

 _setResourceRequestAttributes(entry, attributes, [
 // https://developer.mozilla.org/en-US/docs/Web/API/PerformanceResourceTiming/responseStatus
Expand Down

5 changes: 2 additions & 3 deletions
packages/browser/src/integrations/graphqlClient.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,13 +5,12 @@ import {
 isString,
 SEMANTIC_ATTRIBUTE_HTTP_REQUEST_METHOD,
 SEMANTIC_ATTRIBUTE_SENTRY_OP,
 SEMANTIC_ATTRIBUTE_URL_FULL,
 spanToJSON,
 stringMatchesSomePattern,
} from '@sentry/core/browser';
import type { FetchHint, XhrHint } from '@sentry/browser-utils';
import { getBodyString, getFetchRequestArgBody, SENTRY_XHR_DATA_KEY } from '@sentry/browser-utils';
import { GRAPHQL_DOCUMENT } from '@sentry/conventions/attributes';
import { GRAPHQL_DOCUMENT, URL_FULL } from '@sentry/conventions/attributes';

interface GraphQLClientOptions {
 endpoints: Array<string | RegExp>;
Expand DownExpand Up@@ -71,7 +70,7 @@ function _updateSpanWithGraphQLData(client: Client, options: GraphQLClientOption

 // Fall back to `url` because fetch instrumentation only sets `http.url` for absolute URLs;
 // relative URLs end up only in `url` (see `getFetchSpanAttributes` in packages/core/src/fetch.ts).
 const httpUrl = spanAttributes[SEMANTIC_ATTRIBUTE_URL_FULL] || spanAttributes['http.url'] || spanAttributes['url'];
 const httpUrl = spanAttributes[URL_FULL] || spanAttributes['http.url'] || spanAttributes['url'];
 const httpMethod = spanAttributes[SEMANTIC_ATTRIBUTE_HTTP_REQUEST_METHOD] || spanAttributes['http.method'];

 if (!isString(httpUrl) || !isString(httpMethod)) {
Expand Down

3 changes: 2 additions & 1 deletion
packages/browser/src/integrations/httpcontext.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
import { defineIntegration, safeSetSpanJSONAttributes, SEMANTIC_ATTRIBUTE_SENTRY_OP } from '@sentry/core/browser';
import { getHttpRequestData, WINDOW } from '../helpers';
import { URL_FULL } from '@sentry/conventions/attributes';

/**
 * Collects information about HTTP request headers and
Expand DownExpand Up@@ -39,7 +40,7 @@ export const httpContextIntegration = defineIntegration(() => {
 safeSetSpanJSONAttributes(span, {
 // Coerce empty string to undefined so the helper's nullish check drops it,
 // rather than writing an empty `url.full` attribute onto the span.
'url.full': spanOp !== 'http.client' ? reqData.url : undefined,
[URL_FULL]: spanOp !== 'http.client' ? reqData.url : undefined,
 'http.request.header.user_agent': reqData.headers['User-Agent'],
 'http.request.header.referer': reqData.headers['Referer'],
 });
Expand Down

8 changes: 5 additions & 3 deletions
packages/browser/src/tracing/request.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -40,6 +40,7 @@ import {
} from '@sentry/browser-utils';
import type { BrowserClient } from '../client';
import { baggageHeaderHasSentryValues, createHeadersSafely, getFullURL, isPerformanceResourceTiming } from './utils';
import { HTTP_URL, URL_FULL } from '@sentry/conventions/attributes';

/** Options for Request Instrumentation */
export interface RequestInstrumentationOptions {
Expand DownExpand Up@@ -172,10 +173,11 @@ export function instrumentOutgoingRequests(client: Client, _options?: Partial<Re
 const host = fullUrl ? parseUrl(fullUrl).host : undefined;
 const sanitizedFullUrl = fullUrl ? stripDataUrlContent(fullUrl) : undefined;
 createdSpan.setAttributes({
 'http.url': sanitizedFullUrl,
 // oxlint-disable-next-line typescript/no-deprecated
 [HTTP_URL]: sanitizedFullUrl,
 // `url.full` must match `http.url`. Setting it here ensures parentless `http.client`
 // segment spans don't get `url.full` backfilled with the host page URL (see httpContextIntegration).
'url.full': sanitizedFullUrl,
[URL_FULL]: sanitizedFullUrl,
 'server.address': host,
 });

Expand DownExpand Up@@ -393,7 +395,7 @@ function xhrCallback(
 'http.url': sanitizedFullUrl,
 // `url.full` must match `http.url`. Setting it here ensures parentless `http.client`
 // segment spans don't get `url.full` backfilled with the host page URL (see httpContextIntegration).
'url.full': sanitizedFullUrl,
[URL_FULL]: sanitizedFullUrl,
 'server.address': parsedUrl?.host,
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.http.browser',
 [SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'http.client',
Expand Down

25 changes: 23 additions & 2 deletions
packages/browser/test/integrations/graphqlClient.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@ import type { Client } from '@sentry/core/browser';
import { SentrySpan, spanToJSON } from '@sentry/core/browser';
import type { FetchHint, XhrHint } from '@sentry/browser-utils';
import { SENTRY_XHR_DATA_KEY } from '@sentry/browser-utils';
import { URL_FULL } from '@sentry/conventions/attributes';
import { describe, expect, test } from 'vitest';
import {
 _getGraphQLOperation,
Expand DownExpand Up@@ -352,14 +353,15 @@ describe('GraphqlClient', () => {
 extensions: {},
 };

 test('enriches http.client span for absolute URLs (http.url attribute)', () => {
 test('enriches http.client span for absolute URLs', () => {
 const handler = setupHandler([/\/graphql$/]);
 const span = new SentrySpan({
 name: 'POST http://localhost:4000/graphql',
 op: 'http.client',
 attributes: {
 'http.method': 'POST',
 'http.url': 'http://localhost:4000/graphql',
 [URL_FULL]: 'http://localhost:4000/graphql',
 url: 'http://localhost:4000/graphql',
 },
 });
Expand All@@ -371,9 +373,27 @@ describe('GraphqlClient', () => {
 expect(json.data['graphql.document']).toBe(requestBody.query);
 });

 test('enriches http.client span when only url.full is present', () => {
 const handler = setupHandler([/\/graphql$/]);
 const span = new SentrySpan({
 name: 'POST http://localhost:4000/graphql',
 op: 'http.client',
 attributes: {
 'http.method': 'POST',
 [URL_FULL]: 'http://localhost:4000/graphql',
 },
 });

 handler(span, makeFetchHint('http://localhost:4000/graphql', requestBody));

 const json = spanToJSON(span);
 expect(json.description).toBe('POST http://localhost:4000/graphql (query GetHello)');
 expect(json.data['graphql.document']).toBe(requestBody.query);
 });

 test('enriches http.client span for relative URLs (only url attribute)', () => {
 const handler = setupHandler([/\/graphql$/]);
 // Fetch instrumentation does NOT set http.urlfor relative URLs — only `url`.
 // Fetch instrumentation does not set `http.url` or `url.full` for relative URLs.
 const span = new SentrySpan({
 name: 'POST /graphql',
 op: 'http.client',
Expand DownExpand Up@@ -433,6 +453,7 @@ describe('GraphqlClient', () => {
 attributes: {
 'http.method': 'POST',
 'http.url': 'http://localhost:4000/graphql',
 [URL_FULL]: 'http://localhost:4000/graphql',
 url: 'http://localhost:4000/graphql',
 },
 });
Expand Down

1 change: 1 addition & 0 deletions
packages/bun/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,7 @@
 "dependencies": {
 "@apm-js-collab/code-transformer-bundler-plugins": "^0.7.1",
 "@sentry/core": "10.67.0",
 "@sentry/conventions": "^0.16.0",
 "@sentry/node": "10.67.0",
 "@sentry/server-utils": "10.67.0"
 },
Expand Down

3 changes: 2 additions & 1 deletion
packages/bun/src/integrations/bunserver.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@ import {
 withIsolationScope,
} from '@sentry/core';
import type { ServeOptions } from 'bun';
import { URL_FULL } from '@sentry/conventions/attributes';

const INTEGRATION_NAME = 'BunServer' as const;

Expand DownExpand Up@@ -282,7 +283,7 @@ function getSpanAttributesFromParsedUrl(
 attributes['url.path'] = parsedUrl.pathname;
 }
 if (!isURLObjectRelative(parsedUrl)) {
 attributes['url.full'] = parsedUrl.href;
 attributes[URL_FULL] = parsedUrl.href;
 if (parsedUrl.port) {
 attributes['url.port'] = parsedUrl.port;
 }
Expand Down

5 changes: 4 additions & 1 deletion
packages/core/src/fetch.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { HTTP_URL, URL_FULL } from '@sentry/conventions/attributes';
import { getClient } from './currentScopes';
import { SEMANTIC_ATTRIBUTE_SENTRY_OP, SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN } from './semanticAttributes';
import { setHttpStatus, SPAN_STATUS_ERROR, spanIsIgnored, startInactiveSpan } from './tracing';
Expand DownExpand Up@@ -388,7 +389,9 @@ function getFetchSpanAttributes(
 };
 if (parsedUrl) {
 if (!isURLObjectRelative(parsedUrl)) {
 attributes['http.url'] = stripDataUrlContent(parsedUrl.href);
 // oxlint-disable-next-line typescript/no-deprecated
 attributes[HTTP_URL] = stripDataUrlContent(parsedUrl.href);
 attributes[URL_FULL] = stripDataUrlContent(parsedUrl.href);
Comment thread
cursor[bot] marked this conversation as resolved.

 attributes['server.address'] = parsedUrl.host;
 }
 if (parsedUrl.search) {
Expand Down

5 changes: 3 additions & 2 deletions
packages/core/src/integrations/requestdata.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,7 @@ import { parseCookie } from '../utils/cookie';
import { httpHeadersToSpanAttributes } from '../utils/request';
import { getClientIPAddress, ipHeaderNames } from '../vendor/getIpAddress';
import { safeSetSpanJSONAttributes } from '../tracing/spans/captureSpan';
import { URL_FULL, URL_QUERY } from '@sentry/conventions/attributes';

interface RequestDataIncludeOptions {
 cookies?: boolean;
Expand DownExpand Up@@ -137,15 +138,15 @@ function addNormalizedRequestDataToSpan(
 const attributes: Record<string, unknown> = {};

 if (requestData.url) {
 attributes['url.full'] = requestData.url;
 attributes[URL_FULL] = requestData.url;
 }

 if (requestData.method) {
 attributes['http.request.method'] = requestData.method;
 }

 if (requestData.query_string) {
 attributes['url.query'] = normalizeQueryString(requestData.query_string);
 attributes[URL_QUERY] = normalizeQueryString(requestData.query_string);
 }

 safeSetSpanJSONAttributes(span, attributes);
Expand Down

3 changes: 3 additions & 0 deletions
packages/core/src/semanticAttributes.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -110,6 +110,9 @@ export const SEMANTIC_ATTRIBUTE_CACHE_ITEM_SIZE = 'cache.item_size';

/** TODO: Remove these once we update to latest semantic conventions */
export const SEMANTIC_ATTRIBUTE_HTTP_REQUEST_METHOD = 'http.request.method';
/**
 * @deprecated Use `URL_FULL` `@sentry/conventions/attributes` instead.
 */
export const SEMANTIC_ATTRIBUTE_URL_FULL = 'url.full';

/**
Expand Down

4 changes: 2 additions & 2 deletions
packages/core/src/utils/url.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
import { URL_FULL } from '@sentry/conventions/attributes';
import {
 SEMANTIC_ATTRIBUTE_HTTP_REQUEST_METHOD,
 SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
 SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
 SEMANTIC_ATTRIBUTE_URL_FULL,
} from '../semanticAttributes';
import type { SpanAttributes } from '../types/span';

Expand DownExpand Up@@ -188,7 +188,7 @@ export function getHttpSpanDetailsFromUrlObject(
 }

 if (!isURLObjectRelative(urlObject)) {
 attributes[SEMANTIC_ATTRIBUTE_URL_FULL] = urlObject.href;
 attributes[URL_FULL] = urlObject.href;
 if (urlObject.port) {
 attributes['url.port'] = urlObject.port;
 }
Expand Down

44 changes: 44 additions & 0 deletions
packages/core/test/lib/fetch.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { URL_FULL } from '@sentry/conventions/attributes';
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
import type { HandlerDataFetch } from '../../src';
import { _INTERNAL_getTracingHeadersForFetchRequest, instrumentFetchRequest } from '../../src/fetch';
Expand DownExpand Up@@ -444,6 +445,49 @@ describe('_INTERNAL_getTracingHeadersForFetchRequest', () => {
});

describe('instrumentFetchRequest', () => {
 describe('span attributes', () => {
 afterEach(() => {
 vi.restoreAllMocks();
 });

 it('sets url.full for absolute URLs', () => {
 const url = 'https://api.example.com/users/42?include=profile#bio';
 const activeSpan = new SentryNonRecordingSpan();
 const fetchSpan = new SentryNonRecordingSpan();
 hasSpansEnabled.mockReturnValue(true);
 vi.spyOn(spanUtils, 'getActiveSpan').mockReturnValue(activeSpan);
 const startInactiveSpanSpy = vi.spyOn(tracing, 'startInactiveSpan').mockReturnValue(fetchSpan);

 instrumentFetchRequest(
 {
 fetchData: { url, method: 'GET' },
 args: [url],
 startTimestamp: Date.now(),
 },
 () => true,
 () => false,
 {},
 { spanOrigin: 'auto.http.fetch' },
 );

 expect(startInactiveSpanSpy).toHaveBeenCalledWith({
 name: 'GET https://api.example.com/users/42',
 attributes: {
 url,
 type: 'fetch',
 'http.method': 'GET',
 'sentry.origin': 'auto.http.fetch',
 'sentry.op': 'http.client',
 'http.url': url,
 [URL_FULL]: url,
 'server.address': 'api.example.com',
 'http.query': '?include=profile',
 'http.fragment': '#bio',
 },
 });
 });
 });

 describe('trace header span', () => {
 beforeEach(() => {
 vi.clearAllMocks();
Expand Down

5 changes: 1 addition & 4 deletions
packages/ember/addon/utils/instrumentEmberAppInstanceForPerformance.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -14,10 +14,7 @@ import {
import type { Client, Span } from '@sentry/core';
import type { EmberRouterMain } from '../types';
import { getBackburner } from './performance';

const URL_FULL = 'url.full';
const URL_PATH = 'url.path';
const URL_TEMPLATE = 'url.template';
import { URL_FULL, URL_PATH, URL_TEMPLATE } from '@sentry/conventions/attributes';

type TransitionWithIntent = Transition & { intent?: { url?: string } };

Expand Down

1 change: 1 addition & 0 deletions
packages/ember/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -34,6 +34,7 @@
 "@embroider/macros": "^1.16.0",
 "@sentry/browser": "10.67.0",
 "@sentry/core": "10.67.0",
 "@sentry/conventions": "^0.16.0",
 "ember-auto-import": "^2.7.2",
 "ember-cli-babel": "^8.2.0",
 "ember-cli-htmlbars": "^6.1.1",
Expand Down

3 changes: 2 additions & 1 deletion
packages/nextjs/src/server/vercelQueuesMonitoring.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { URL_FULL } from '@sentry/conventions/attributes';
import type { Span } from '@sentry/core';
import { getIsolationScope, spanToJSON } from '@sentry/core';

Expand DownExpand Up@@ -76,7 +77,7 @@ export function maybeEnrichQueueProducerSpan(span: Span): void {
 const spanData = spanToJSON(span).data;

 // http.client spans have url.full attribute
 const urlFull = spanData?.['url.full'] as string | undefined;
 const urlFull = spanData?.[URL_FULL] as string | undefined;
 if (!urlFull) {
 return;
 }
Expand Down

11 changes: 3 additions & 8 deletions
packages/node/src/integrations/http.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,19 +1,14 @@
import type { RequestOptions } from 'node:http';
import type { HttpClientRequest, HttpIncomingMessage, HttpServerResponse, Span } from '@sentry/core';
import {
 defineIntegration,
 hasSpansEnabled,
 SEMANTIC_ATTRIBUTE_URL_FULL,
 stripDataUrlContent,
 getRequestUrlFromClientRequest,
} from '@sentry/core';
import { defineIntegration, hasSpansEnabled, stripDataUrlContent, getRequestUrlFromClientRequest } from '@sentry/core';
import type {
 NodeClient,
 SentryHttpInstrumentationOptions,
 HttpServerIntegrationOptions,
 HttpServerSpansIntegrationOptions,
} from '@sentry/node-core';
import { httpServerIntegration, httpServerSpansIntegration, instrumentHttpOutgoingRequests } from '@sentry/node-core';
import { URL_FULL } from '@sentry/conventions/attributes';

const INTEGRATION_NAME = 'Http' as const;

Expand DownExpand Up@@ -210,7 +205,7 @@ export const httpIntegration = defineIntegration((options: HttpOptions = {}) =>
 // TODO(v11): Update these to the Sentry semantic attributes.
 // https://getsentry.github.io/sentry-conventions/attributes/
 span.setAttribute('http.url', sanitizedUrl);
 span.setAttribute(SEMANTIC_ATTRIBUTE_URL_FULL, sanitizedUrl);
 span.setAttribute(URL_FULL, sanitizedUrl);
 span.updateName(`${request.method || 'GET'} ${sanitizedUrl}`);
 }
 options.instrumentation?.requestHook?.(span, request);
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
feat(core): Add url.full attribute to core fetch instrumentation#22415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Lms24
merged 3 commits into

from

Jul 21, 2026
 Merged


feat(core): Add url.full attribute to core fetch instrumentation
#22415
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
c7b54bc

ref(core): Add `url.full` attribute to core fetch instrumentation


Lms24 Jul 21, 2026
50f2d36

adjust tests


Lms24 Jul 21, 2026
9861918

fix bun build fail


Lms24 Jul 21, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
dev-packages/e2e-tests/test-applications/astro-6-cf-workers/tests/tracing.dynamic.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -242,6 +242,8 @@ test.describe('nested SSR routes (client, server, server request)', () => {
 'sentry.op': 'http.client',
 'sentry.origin': 'auto.http.fetch',
 url: expect.stringContaining('/api/user/myUsername123.json'),
 'http.url': 'http://localhost:3030/api/user/myUsername123.json',
 'url.full': 'http://localhost:3030/api/user/myUsername123.json',
 },
 });

Expand Down

1 change: 1 addition & 0 deletions
dev-packages/e2e-tests/test-applications/nextjs-pages-dir/tests/middleware.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -75,6 +75,7 @@ test('Should trace outgoing fetch requests inside middleware and create breadcru
 type: 'fetch',
 url: 'http://localhost:3030/',
 'http.url': 'http://localhost:3030/',
 'url.full': 'http://localhost:3030/',
 'server.address': 'localhost:3030',
 'sentry.op': 'http.client',
 'sentry.origin': 'auto.http.wintercg_fetch',
Expand Down

4 changes: 2 additions & 2 deletions
packages/browser-utils/src/metrics/browserMetrics.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,6 @@ import {
 isPrimitive,
 parseUrl,
 SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
 SEMANTIC_ATTRIBUTE_URL_FULL,
 setMeasurement,
 spanToJSON,
 stringMatchesSomePattern,
Expand All@@ -30,6 +29,7 @@ import { getActivationStart } from './web-vitals/lib/getActivationStart';
import { getNavigationEntry } from './web-vitals/lib/getNavigationEntry';
import { getVisibilityWatcher } from './web-vitals/lib/getVisibilityWatcher';
import { DEBUG_BUILD } from '../debug-build';
import { URL_FULL } from '@sentry/conventions/attributes';
interface NavigatorNetworkInformation {
 readonly connection?: NetworkInformation;
}
Expand DownExpand Up@@ -775,7 +775,7 @@ export function _addResourceSpans(

 attributes['url.same_origin'] = resourceUrl.includes(WINDOW.location.origin);

 attributes[SEMANTIC_ATTRIBUTE_URL_FULL] = resourceUrl;
 attributes[URL_FULL] = resourceUrl;

 _setResourceRequestAttributes(entry, attributes, [
 // https://developer.mozilla.org/en-US/docs/Web/API/PerformanceResourceTiming/responseStatus
Expand Down

5 changes: 2 additions & 3 deletions
packages/browser/src/integrations/graphqlClient.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,13 +5,12 @@ import {
 isString,
 SEMANTIC_ATTRIBUTE_HTTP_REQUEST_METHOD,
 SEMANTIC_ATTRIBUTE_SENTRY_OP,
 SEMANTIC_ATTRIBUTE_URL_FULL,
 spanToJSON,
 stringMatchesSomePattern,
} from '@sentry/core/browser';
import type { FetchHint, XhrHint } from '@sentry/browser-utils';
import { getBodyString, getFetchRequestArgBody, SENTRY_XHR_DATA_KEY } from '@sentry/browser-utils';
import { GRAPHQL_DOCUMENT } from '@sentry/conventions/attributes';
import { GRAPHQL_DOCUMENT, URL_FULL } from '@sentry/conventions/attributes';

interface GraphQLClientOptions {
 endpoints: Array<string | RegExp>;
Expand DownExpand Up@@ -71,7 +70,7 @@ function _updateSpanWithGraphQLData(client: Client, options: GraphQLClientOption

 // Fall back to `url` because fetch instrumentation only sets `http.url` for absolute URLs;
 // relative URLs end up only in `url` (see `getFetchSpanAttributes` in packages/core/src/fetch.ts).
 const httpUrl = spanAttributes[SEMANTIC_ATTRIBUTE_URL_FULL] || spanAttributes['http.url'] || spanAttributes['url'];
 const httpUrl = spanAttributes[URL_FULL] || spanAttributes['http.url'] || spanAttributes['url'];
 const httpMethod = spanAttributes[SEMANTIC_ATTRIBUTE_HTTP_REQUEST_METHOD] || spanAttributes['http.method'];

 if (!isString(httpUrl) || !isString(httpMethod)) {
Expand Down

3 changes: 2 additions & 1 deletion
packages/browser/src/integrations/httpcontext.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
import { defineIntegration, safeSetSpanJSONAttributes, SEMANTIC_ATTRIBUTE_SENTRY_OP } from '@sentry/core/browser';
import { getHttpRequestData, WINDOW } from '../helpers';
import { URL_FULL } from '@sentry/conventions/attributes';

/**
 * Collects information about HTTP request headers and
Expand DownExpand Up@@ -39,7 +40,7 @@ export const httpContextIntegration = defineIntegration(() => {
 safeSetSpanJSONAttributes(span, {
 // Coerce empty string to undefined so the helper's nullish check drops it,
 // rather than writing an empty `url.full` attribute onto the span.
'url.full': spanOp !== 'http.client' ? reqData.url : undefined,
[URL_FULL]: spanOp !== 'http.client' ? reqData.url : undefined,
 'http.request.header.user_agent': reqData.headers['User-Agent'],
 'http.request.header.referer': reqData.headers['Referer'],
 });
Expand Down

8 changes: 5 additions & 3 deletions
packages/browser/src/tracing/request.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -40,6 +40,7 @@ import {
} from '@sentry/browser-utils';
import type { BrowserClient } from '../client';
import { baggageHeaderHasSentryValues, createHeadersSafely, getFullURL, isPerformanceResourceTiming } from './utils';
import { HTTP_URL, URL_FULL } from '@sentry/conventions/attributes';

/** Options for Request Instrumentation */
export interface RequestInstrumentationOptions {
Expand DownExpand Up@@ -172,10 +173,11 @@ export function instrumentOutgoingRequests(client: Client, _options?: Partial<Re
 const host = fullUrl ? parseUrl(fullUrl).host : undefined;
 const sanitizedFullUrl = fullUrl ? stripDataUrlContent(fullUrl) : undefined;
 createdSpan.setAttributes({
 'http.url': sanitizedFullUrl,
 // oxlint-disable-next-line typescript/no-deprecated
 [HTTP_URL]: sanitizedFullUrl,
 // `url.full` must match `http.url`. Setting it here ensures parentless `http.client`
 // segment spans don't get `url.full` backfilled with the host page URL (see httpContextIntegration).
'url.full': sanitizedFullUrl,
[URL_FULL]: sanitizedFullUrl,
 'server.address': host,
 });

Expand DownExpand Up@@ -393,7 +395,7 @@ function xhrCallback(
 'http.url': sanitizedFullUrl,
 // `url.full` must match `http.url`. Setting it here ensures parentless `http.client`
 // segment spans don't get `url.full` backfilled with the host page URL (see httpContextIntegration).
'url.full': sanitizedFullUrl,
[URL_FULL]: sanitizedFullUrl,
 'server.address': parsedUrl?.host,
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.http.browser',
 [SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'http.client',
Expand Down

25 changes: 23 additions & 2 deletions
packages/browser/test/integrations/graphqlClient.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@ import type { Client } from '@sentry/core/browser';
import { SentrySpan, spanToJSON } from '@sentry/core/browser';
import type { FetchHint, XhrHint } from '@sentry/browser-utils';
import { SENTRY_XHR_DATA_KEY } from '@sentry/browser-utils';
import { URL_FULL } from '@sentry/conventions/attributes';
import { describe, expect, test } from 'vitest';
import {
 _getGraphQLOperation,
Expand DownExpand Up@@ -352,14 +353,15 @@ describe('GraphqlClient', () => {
 extensions: {},
 };

 test('enriches http.client span for absolute URLs (http.url attribute)', () => {
 test('enriches http.client span for absolute URLs', () => {
 const handler = setupHandler([/\/graphql$/]);
 const span = new SentrySpan({
 name: 'POST http://localhost:4000/graphql',
 op: 'http.client',
 attributes: {
 'http.method': 'POST',
 'http.url': 'http://localhost:4000/graphql',
 [URL_FULL]: 'http://localhost:4000/graphql',
 url: 'http://localhost:4000/graphql',
 },
 });
Expand All@@ -371,9 +373,27 @@ describe('GraphqlClient', () => {
 expect(json.data['graphql.document']).toBe(requestBody.query);
 });

 test('enriches http.client span when only url.full is present', () => {
 const handler = setupHandler([/\/graphql$/]);
 const span = new SentrySpan({
 name: 'POST http://localhost:4000/graphql',
 op: 'http.client',
 attributes: {
 'http.method': 'POST',
 [URL_FULL]: 'http://localhost:4000/graphql',
 },
 });

 handler(span, makeFetchHint('http://localhost:4000/graphql', requestBody));

 const json = spanToJSON(span);
 expect(json.description).toBe('POST http://localhost:4000/graphql (query GetHello)');
 expect(json.data['graphql.document']).toBe(requestBody.query);
 });

 test('enriches http.client span for relative URLs (only url attribute)', () => {
 const handler = setupHandler([/\/graphql$/]);
 // Fetch instrumentation does NOT set http.urlfor relative URLs — only `url`.
 // Fetch instrumentation does not set `http.url` or `url.full` for relative URLs.
 const span = new SentrySpan({
 name: 'POST /graphql',
 op: 'http.client',
Expand DownExpand Up@@ -433,6 +453,7 @@ describe('GraphqlClient', () => {
 attributes: {
 'http.method': 'POST',
 'http.url': 'http://localhost:4000/graphql',
 [URL_FULL]: 'http://localhost:4000/graphql',
 url: 'http://localhost:4000/graphql',
 },
 });
Expand Down

1 change: 1 addition & 0 deletions
packages/bun/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,7 @@
 "dependencies": {
 "@apm-js-collab/code-transformer-bundler-plugins": "^0.7.1",
 "@sentry/core": "10.67.0",
 "@sentry/conventions": "^0.16.0",
 "@sentry/node": "10.67.0",
 "@sentry/server-utils": "10.67.0"
 },
Expand Down

3 changes: 2 additions & 1 deletion
packages/bun/src/integrations/bunserver.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@ import {
 withIsolationScope,
} from '@sentry/core';
import type { ServeOptions } from 'bun';
import { URL_FULL } from '@sentry/conventions/attributes';

const INTEGRATION_NAME = 'BunServer' as const;

Expand DownExpand Up@@ -282,7 +283,7 @@ function getSpanAttributesFromParsedUrl(
 attributes['url.path'] = parsedUrl.pathname;
 }
 if (!isURLObjectRelative(parsedUrl)) {
 attributes['url.full'] = parsedUrl.href;
 attributes[URL_FULL] = parsedUrl.href;
 if (parsedUrl.port) {
 attributes['url.port'] = parsedUrl.port;
 }
Expand Down

5 changes: 4 additions & 1 deletion
packages/core/src/fetch.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { HTTP_URL, URL_FULL } from '@sentry/conventions/attributes';
import { getClient } from './currentScopes';
import { SEMANTIC_ATTRIBUTE_SENTRY_OP, SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN } from './semanticAttributes';
import { setHttpStatus, SPAN_STATUS_ERROR, spanIsIgnored, startInactiveSpan } from './tracing';
Expand DownExpand Up@@ -388,7 +389,9 @@ function getFetchSpanAttributes(
 };
 if (parsedUrl) {
 if (!isURLObjectRelative(parsedUrl)) {
 attributes['http.url'] = stripDataUrlContent(parsedUrl.href);
 // oxlint-disable-next-line typescript/no-deprecated
 attributes[HTTP_URL] = stripDataUrlContent(parsedUrl.href);
 attributes[URL_FULL] = stripDataUrlContent(parsedUrl.href);
Comment thread
cursor[bot] marked this conversation as resolved.

 attributes['server.address'] = parsedUrl.host;
 }
 if (parsedUrl.search) {
Expand Down

5 changes: 3 additions & 2 deletions
packages/core/src/integrations/requestdata.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,7 @@ import { parseCookie } from '../utils/cookie';
import { httpHeadersToSpanAttributes } from '../utils/request';
import { getClientIPAddress, ipHeaderNames } from '../vendor/getIpAddress';
import { safeSetSpanJSONAttributes } from '../tracing/spans/captureSpan';
import { URL_FULL, URL_QUERY } from '@sentry/conventions/attributes';

interface RequestDataIncludeOptions {
 cookies?: boolean;
Expand DownExpand Up@@ -137,15 +138,15 @@ function addNormalizedRequestDataToSpan(
 const attributes: Record<string, unknown> = {};

 if (requestData.url) {
 attributes['url.full'] = requestData.url;
 attributes[URL_FULL] = requestData.url;
 }

 if (requestData.method) {
 attributes['http.request.method'] = requestData.method;
 }

 if (requestData.query_string) {
 attributes['url.query'] = normalizeQueryString(requestData.query_string);
 attributes[URL_QUERY] = normalizeQueryString(requestData.query_string);
 }

 safeSetSpanJSONAttributes(span, attributes);
Expand Down

3 changes: 3 additions & 0 deletions
packages/core/src/semanticAttributes.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -110,6 +110,9 @@ export const SEMANTIC_ATTRIBUTE_CACHE_ITEM_SIZE = 'cache.item_size';

/** TODO: Remove these once we update to latest semantic conventions */
export const SEMANTIC_ATTRIBUTE_HTTP_REQUEST_METHOD = 'http.request.method';
/**
 * @deprecated Use `URL_FULL` `@sentry/conventions/attributes` instead.
 */
export const SEMANTIC_ATTRIBUTE_URL_FULL = 'url.full';

/**
Expand Down

4 changes: 2 additions & 2 deletions
packages/core/src/utils/url.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
import { URL_FULL } from '@sentry/conventions/attributes';
import {
 SEMANTIC_ATTRIBUTE_HTTP_REQUEST_METHOD,
 SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
 SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
 SEMANTIC_ATTRIBUTE_URL_FULL,
} from '../semanticAttributes';
import type { SpanAttributes } from '../types/span';

Expand DownExpand Up@@ -188,7 +188,7 @@ export function getHttpSpanDetailsFromUrlObject(
 }

 if (!isURLObjectRelative(urlObject)) {
 attributes[SEMANTIC_ATTRIBUTE_URL_FULL] = urlObject.href;
 attributes[URL_FULL] = urlObject.href;
 if (urlObject.port) {
 attributes['url.port'] = urlObject.port;
 }
Expand Down

44 changes: 44 additions & 0 deletions
packages/core/test/lib/fetch.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { URL_FULL } from '@sentry/conventions/attributes';
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
import type { HandlerDataFetch } from '../../src';
import { _INTERNAL_getTracingHeadersForFetchRequest, instrumentFetchRequest } from '../../src/fetch';
Expand DownExpand Up@@ -444,6 +445,49 @@ describe('_INTERNAL_getTracingHeadersForFetchRequest', () => {
});

describe('instrumentFetchRequest', () => {
 describe('span attributes', () => {
 afterEach(() => {
 vi.restoreAllMocks();
 });

 it('sets url.full for absolute URLs', () => {
 const url = 'https://api.example.com/users/42?include=profile#bio';
 const activeSpan = new SentryNonRecordingSpan();
 const fetchSpan = new SentryNonRecordingSpan();
 hasSpansEnabled.mockReturnValue(true);
 vi.spyOn(spanUtils, 'getActiveSpan').mockReturnValue(activeSpan);
 const startInactiveSpanSpy = vi.spyOn(tracing, 'startInactiveSpan').mockReturnValue(fetchSpan);

 instrumentFetchRequest(
 {
 fetchData: { url, method: 'GET' },
 args: [url],
 startTimestamp: Date.now(),
 },
 () => true,
 () => false,
 {},
 { spanOrigin: 'auto.http.fetch' },
 );

 expect(startInactiveSpanSpy).toHaveBeenCalledWith({
 name: 'GET https://api.example.com/users/42',
 attributes: {
 url,
 type: 'fetch',
 'http.method': 'GET',
 'sentry.origin': 'auto.http.fetch',
 'sentry.op': 'http.client',
 'http.url': url,
 [URL_FULL]: url,
 'server.address': 'api.example.com',
 'http.query': '?include=profile',
 'http.fragment': '#bio',
 },
 });
 });
 });

 describe('trace header span', () => {
 beforeEach(() => {
 vi.clearAllMocks();
Expand Down

5 changes: 1 addition & 4 deletions
packages/ember/addon/utils/instrumentEmberAppInstanceForPerformance.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -14,10 +14,7 @@ import {
import type { Client, Span } from '@sentry/core';
import type { EmberRouterMain } from '../types';
import { getBackburner } from './performance';

const URL_FULL = 'url.full';
const URL_PATH = 'url.path';
const URL_TEMPLATE = 'url.template';
import { URL_FULL, URL_PATH, URL_TEMPLATE } from '@sentry/conventions/attributes';

type TransitionWithIntent = Transition & { intent?: { url?: string } };

Expand Down

1 change: 1 addition & 0 deletions
packages/ember/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -34,6 +34,7 @@
 "@embroider/macros": "^1.16.0",
 "@sentry/browser": "10.67.0",
 "@sentry/core": "10.67.0",
 "@sentry/conventions": "^0.16.0",
 "ember-auto-import": "^2.7.2",
 "ember-cli-babel": "^8.2.0",
 "ember-cli-htmlbars": "^6.1.1",
Expand Down

3 changes: 2 additions & 1 deletion
packages/nextjs/src/server/vercelQueuesMonitoring.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { URL_FULL } from '@sentry/conventions/attributes';
import type { Span } from '@sentry/core';
import { getIsolationScope, spanToJSON } from '@sentry/core';

Expand DownExpand Up@@ -76,7 +77,7 @@ export function maybeEnrichQueueProducerSpan(span: Span): void {
 const spanData = spanToJSON(span).data;

 // http.client spans have url.full attribute
 const urlFull = spanData?.['url.full'] as string | undefined;
 const urlFull = spanData?.[URL_FULL] as string | undefined;
 if (!urlFull) {
 return;
 }
Expand Down

11 changes: 3 additions & 8 deletions
packages/node/src/integrations/http.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,19 +1,14 @@
import type { RequestOptions } from 'node:http';
import type { HttpClientRequest, HttpIncomingMessage, HttpServerResponse, Span } from '@sentry/core';
import {
 defineIntegration,
 hasSpansEnabled,
 SEMANTIC_ATTRIBUTE_URL_FULL,
 stripDataUrlContent,
 getRequestUrlFromClientRequest,
} from '@sentry/core';
import { defineIntegration, hasSpansEnabled, stripDataUrlContent, getRequestUrlFromClientRequest } from '@sentry/core';
import type {
 NodeClient,
 SentryHttpInstrumentationOptions,
 HttpServerIntegrationOptions,
 HttpServerSpansIntegrationOptions,
} from '@sentry/node-core';
import { httpServerIntegration, httpServerSpansIntegration, instrumentHttpOutgoingRequests } from '@sentry/node-core';
import { URL_FULL } from '@sentry/conventions/attributes';

const INTEGRATION_NAME = 'Http' as const;

Expand DownExpand Up@@ -210,7 +205,7 @@ export const httpIntegration = defineIntegration((options: HttpOptions = {}) =>
 // TODO(v11): Update these to the Sentry semantic attributes.
 // https://getsentry.github.io/sentry-conventions/attributes/
 span.setAttribute('http.url', sanitizedUrl);
 span.setAttribute(SEMANTIC_ATTRIBUTE_URL_FULL, sanitizedUrl);
 span.setAttribute(URL_FULL, sanitizedUrl);
 span.updateName(`${request.method || 'GET'} ${sanitizedUrl}`);
 }
 options.instrumentation?.requestHook?.(span, request);
Expand Down
Loading
Loading