fix(core): Account for clock drift in initial timestampInSeconds() call - #22488

Closed
Lms24 wants to merge 2 commits into
developfrom
lms/fix-timeStampInSeconds-partially
Closed

fix(core): Account for clock drift in initial timestampInSeconds() call#22488
Lms24 wants to merge 2 commits into
developfrom
lms/fix-timeStampInSeconds-partially

Conversation

@Lms24

@Lms24Lms24 commented Jul 22, 2026•
edited
Loading

Copy link
Copy Markdown
Member

#22375 reports a valid bug which is that timestampInSeconds() may return an inaccurate time stamp, since we don't detect clock drift between the performance.timeOrigin + performance.now() timestamp and Date.now().

This PR intentionally only partially fixes this problem by adding a clock drift check only to the initial timestampInSeconds call. This should account for cases where the monotonic performance.now() clock is already off at SDK init time but won't catch clock drift later on.

From here we have two options:

  1. Also add the drift validity check to subsequent calls. This means we'll bypass caching (what we do now) until we detect clock drift, adding performance overhead by running the validity check on every timestampInSeconds call until then.
  2. Drop using the performance time APIs entirely and only return Date.now(). This should give us more accurate timing overall but:
    • we loose nanoseconds precision
    • we'd arguably now report accurate and inaccurate times in one trace because some spans are created from PerformanceEntry entries, which include relative timestamps that might have also suffered from clock drift.

I also still need to look at the sent_at header which should prompt Relay to perform clock-drift normalization but I'm not yet sure to which extent.

Keeping this draft as a possible mitigation open for now

@github-actions

github-actionsBot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser27.8 kB+0.17%+47 B 🔺
@sentry/browser - with treeshaking flags26.24 kB+0.18%+46 B 🔺
@sentry/browser (incl. Tracing)46.6 kB+0.04%+14 B 🔺
@sentry/browser (incl. Tracing + Span Streaming)48.41 kB+0.04%+17 B 🔺
@sentry/browser (incl. Tracing, Profiling)51.42 kB+0.07%+31 B 🔺
@sentry/browser (incl. Tracing, Replay)85.88 kB+0.06%+45 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags75.51 kB+0.06%+38 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)90.61 kB+0.07%+55 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)103.23 kB+0.02%+18 B 🔺
@sentry/browser (incl. Feedback)44.99 kB+0.11%+46 B 🔺
@sentry/browser (incl. sendFeedback)32.59 kB+0.12%+39 B 🔺
@sentry/browser (incl. FeedbackAsync)37.72 kB+0.1%+34 B 🔺
@sentry/browser (incl. Metrics)28.89 kB+0.19%+52 B 🔺
@sentry/browser (incl. Logs)29.12 kB+0.22%+62 B 🔺
@sentry/browser (incl. Metrics & Logs)29.82 kB+0.18%+52 B 🔺
@sentry/react29.6 kB+0.16%+46 B 🔺
@sentry/react (incl. Tracing)48.9 kB+0.07%+31 B 🔺
@sentry/vue33.23 kB+0.16%+52 B 🔺
@sentry/vue (incl. Tracing)48.6 kB+0.08%+38 B 🔺
@sentry/svelte27.82 kB+0.17%+47 B 🔺
CDN Bundle30.2 kB+0.15%+44 B 🔺
CDN Bundle (incl. Tracing)48.58 kB+0.04%+18 B 🔺
CDN Bundle (incl. Logs, Metrics)31.78 kB+0.13%+41 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics)49.9 kB+0.09%+42 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)71.04 kB+0.06%+36 B 🔺
CDN Bundle (incl. Tracing, Replay)86.09 kB+0.05%+37 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)87.41 kB+0.05%+35 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)91.9 kB+0.04%+35 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)93.18 kB+0.06%+51 B 🔺
CDN Bundle - uncompressed90 kB+0.13%+109 B 🔺
CDN Bundle (incl. Tracing) - uncompressed146.85 kB+0.06%+81 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed94.68 kB+0.09%+81 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed150.83 kB+0.06%+81 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed219.44 kB+0.04%+81 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed266.09 kB+0.04%+81 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed270.05 kB+0.04%+81 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed279.79 kB+0.03%+81 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed283.74 kB+0.03%+81 B 🔺
@sentry/nextjs (client)51.42 kB+0.09%+42 B 🔺
@sentry/sveltekit (client)47.04 kB+0.08%+34 B 🔺
@sentry/core/server80.33 kB+0.04%+25 B 🔺
@sentry/core/browser66.75 kB+0.07%+42 B 🔺
@sentry/node-core63.26 kB+0.07%+43 B 🔺
@sentry/node124.35 kB+0.05%+53 B 🔺
@sentry/node (incl. diagnostics channel injection)149.79 kB+0.02%+19 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection)70.03 kB--
@sentry/node/light51.38 kB+0.09%+46 B 🔺
@sentry/node - without tracing74.96 kB+0.07%+47 B 🔺
@sentry/aws-serverless84.2 kB+0.05%+34 B 🔺
@sentry/cloudflare (withSentry) - minified196.74 kB+0.08%+156 B 🔺
@sentry/cloudflare (withSentry)484.48 kB+0.14%+645 B 🔺

View base workflow run

This was referenced Jul 22, 2026
Open
Open
@Lms24Lms24 mentioned this pull request Aug 5, 2026
Draft
@Lms24

Lms24 commented Aug 6, 2026

Copy link
Copy Markdown
MemberAuthor

superseded by #23054

@Lms24Lms24 closed this Aug 6, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Lms24
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
fix(core): Account for clock drift in initial timestampInSeconds() call - #22488
Closed
Lms24 wants to merge 2 commits into
developfrom 
lms/fix-timeStampInSeconds-partially
Closed
fix(core): Account for clock drift in initial timestampInSeconds() call#22488
Lms24 wants to merge 2 commits into
developfrom 
lms/fix-timeStampInSeconds-partially
Conversation
@Lms24
@Lms24Lms24
commented
Jul 22, 2026•

edited

Loading

Copy link


Copy Markdown

Member
#22375 reports a valid bug which is that timestampInSeconds() may return an inaccurate time stamp, since we don't detect clock drift between the performance.timeOrigin + performance.now() timestamp and Date.now().
This PR intentionally only partially fixes this problem by adding a clock drift check only to the initial timestampInSeconds call. This should account for cases where the monotonic performance.now() clock is already off at SDK init time but won't catch clock drift later on.
From here we have two options:
  1. Also add the drift validity check to subsequent calls. This means we'll bypass caching (what we do now) until we detect clock drift, adding performance overhead by running the validity check on every timestampInSeconds call until then.
  2. Drop using the performance time APIs entirely and only return Date.now(). This should give us more accurate timing overall but:

    • we loose nanoseconds precision
    • we'd arguably now report accurate and inaccurate times in one trace because some spans are created from PerformanceEntry entries, which include relative timestamps that might have also suffered from clock drift.
I also still need to look at the sent_at header which should prompt Relay to perform clock-drift normalization but I'm not yet sure to which extent.
Keeping this draft as a possible mitigation open for now
@github-actions
github-actionsBot
commented
Jul 22, 2026

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser27.8 kB+0.17%+47 B 🔺
@sentry/browser - with treeshaking flags26.24 kB+0.18%+46 B 🔺
@sentry/browser (incl. Tracing)46.6 kB+0.04%+14 B 🔺
@sentry/browser (incl. Tracing + Span Streaming)48.41 kB+0.04%+17 B 🔺
@sentry/browser (incl. Tracing, Profiling)51.42 kB+0.07%+31 B 🔺
@sentry/browser (incl. Tracing, Replay)85.88 kB+0.06%+45 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags75.51 kB+0.06%+38 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)90.61 kB+0.07%+55 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)103.23 kB+0.02%+18 B 🔺
@sentry/browser (incl. Feedback)44.99 kB+0.11%+46 B 🔺
@sentry/browser (incl. sendFeedback)32.59 kB+0.12%+39 B 🔺
@sentry/browser (incl. FeedbackAsync)37.72 kB+0.1%+34 B 🔺
@sentry/browser (incl. Metrics)28.89 kB+0.19%+52 B 🔺
@sentry/browser (incl. Logs)29.12 kB+0.22%+62 B 🔺
@sentry/browser (incl. Metrics & Logs)29.82 kB+0.18%+52 B 🔺
@sentry/react29.6 kB+0.16%+46 B 🔺
@sentry/react (incl. Tracing)48.9 kB+0.07%+31 B 🔺
@sentry/vue33.23 kB+0.16%+52 B 🔺
@sentry/vue (incl. Tracing)48.6 kB+0.08%+38 B 🔺
@sentry/svelte27.82 kB+0.17%+47 B 🔺
CDN Bundle30.2 kB+0.15%+44 B 🔺
CDN Bundle (incl. Tracing)48.58 kB+0.04%+18 B 🔺
CDN Bundle (incl. Logs, Metrics)31.78 kB+0.13%+41 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics)49.9 kB+0.09%+42 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)71.04 kB+0.06%+36 B 🔺
CDN Bundle (incl. Tracing, Replay)86.09 kB+0.05%+37 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)87.41 kB+0.05%+35 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)91.9 kB+0.04%+35 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)93.18 kB+0.06%+51 B 🔺
CDN Bundle - uncompressed90 kB+0.13%+109 B 🔺
CDN Bundle (incl. Tracing) - uncompressed146.85 kB+0.06%+81 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed94.68 kB+0.09%+81 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed150.83 kB+0.06%+81 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed219.44 kB+0.04%+81 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed266.09 kB+0.04%+81 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed270.05 kB+0.04%+81 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed279.79 kB+0.03%+81 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed283.74 kB+0.03%+81 B 🔺
@sentry/nextjs (client)51.42 kB+0.09%+42 B 🔺
@sentry/sveltekit (client)47.04 kB+0.08%+34 B 🔺
@sentry/core/server80.33 kB+0.04%+25 B 🔺
@sentry/core/browser66.75 kB+0.07%+42 B 🔺
@sentry/node-core63.26 kB+0.07%+43 B 🔺
@sentry/node124.35 kB+0.05%+53 B 🔺
@sentry/node (incl. diagnostics channel injection)149.79 kB+0.02%+19 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection)70.03 kB--
@sentry/node/light51.38 kB+0.09%+46 B 🔺
@sentry/node - without tracing74.96 kB+0.07%+47 B 🔺
@sentry/aws-serverless84.2 kB+0.05%+34 B 🔺
@sentry/cloudflare (withSentry) - minified196.74 kB+0.08%+156 B 🔺
@sentry/cloudflare (withSentry)484.48 kB+0.14%+645 B 🔺
View base workflow run

This was referenced Jul 22, 2026

Open

 Open

@Lms24Lms24
mentioned this pull request
Aug 5, 2026
 Draft

@Lms24
Lms24
commented
Aug 6, 2026

Copy link


Copy Markdown

MemberAuthor
superseded by #23054
@Lms24Lms24
closed this
Aug 6, 2026
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Lms24

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(core): Account for clock drift in initial timestampInSeconds() call - #22488
Closed
Lms24 wants to merge 2 commits into
developfrom 
lms/fix-timeStampInSeconds-partially
Closed
fix(core): Account for clock drift in initial timestampInSeconds() call#22488
Lms24 wants to merge 2 commits into
developfrom 
lms/fix-timeStampInSeconds-partially
Conversation
@Lms24
@Lms24Lms24
commented
Jul 22, 2026•

edited

Loading

Copy link


Copy Markdown

Member
#22375 reports a valid bug which is that timestampInSeconds() may return an inaccurate time stamp, since we don't detect clock drift between the performance.timeOrigin + performance.now() timestamp and Date.now().
This PR intentionally only partially fixes this problem by adding a clock drift check only to the initial timestampInSeconds call. This should account for cases where the monotonic performance.now() clock is already off at SDK init time but won't catch clock drift later on.
From here we have two options:
  1. Also add the drift validity check to subsequent calls. This means we'll bypass caching (what we do now) until we detect clock drift, adding performance overhead by running the validity check on every timestampInSeconds call until then.
  2. Drop using the performance time APIs entirely and only return Date.now(). This should give us more accurate timing overall but:

    • we loose nanoseconds precision
    • we'd arguably now report accurate and inaccurate times in one trace because some spans are created from PerformanceEntry entries, which include relative timestamps that might have also suffered from clock drift.
I also still need to look at the sent_at header which should prompt Relay to perform clock-drift normalization but I'm not yet sure to which extent.
Keeping this draft as a possible mitigation open for now
@github-actions
github-actionsBot
commented
Jul 22, 2026

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser27.8 kB+0.17%+47 B 🔺
@sentry/browser - with treeshaking flags26.24 kB+0.18%+46 B 🔺
@sentry/browser (incl. Tracing)46.6 kB+0.04%+14 B 🔺
@sentry/browser (incl. Tracing + Span Streaming)48.41 kB+0.04%+17 B 🔺
@sentry/browser (incl. Tracing, Profiling)51.42 kB+0.07%+31 B 🔺
@sentry/browser (incl. Tracing, Replay)85.88 kB+0.06%+45 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags75.51 kB+0.06%+38 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)90.61 kB+0.07%+55 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)103.23 kB+0.02%+18 B 🔺
@sentry/browser (incl. Feedback)44.99 kB+0.11%+46 B 🔺
@sentry/browser (incl. sendFeedback)32.59 kB+0.12%+39 B 🔺
@sentry/browser (incl. FeedbackAsync)37.72 kB+0.1%+34 B 🔺
@sentry/browser (incl. Metrics)28.89 kB+0.19%+52 B 🔺
@sentry/browser (incl. Logs)29.12 kB+0.22%+62 B 🔺
@sentry/browser (incl. Metrics & Logs)29.82 kB+0.18%+52 B 🔺
@sentry/react29.6 kB+0.16%+46 B 🔺
@sentry/react (incl. Tracing)48.9 kB+0.07%+31 B 🔺
@sentry/vue33.23 kB+0.16%+52 B 🔺
@sentry/vue (incl. Tracing)48.6 kB+0.08%+38 B 🔺
@sentry/svelte27.82 kB+0.17%+47 B 🔺
CDN Bundle30.2 kB+0.15%+44 B 🔺
CDN Bundle (incl. Tracing)48.58 kB+0.04%+18 B 🔺
CDN Bundle (incl. Logs, Metrics)31.78 kB+0.13%+41 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics)49.9 kB+0.09%+42 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)71.04 kB+0.06%+36 B 🔺
CDN Bundle (incl. Tracing, Replay)86.09 kB+0.05%+37 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)87.41 kB+0.05%+35 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)91.9 kB+0.04%+35 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)93.18 kB+0.06%+51 B 🔺
CDN Bundle - uncompressed90 kB+0.13%+109 B 🔺
CDN Bundle (incl. Tracing) - uncompressed146.85 kB+0.06%+81 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed94.68 kB+0.09%+81 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed150.83 kB+0.06%+81 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed219.44 kB+0.04%+81 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed266.09 kB+0.04%+81 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed270.05 kB+0.04%+81 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed279.79 kB+0.03%+81 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed283.74 kB+0.03%+81 B 🔺
@sentry/nextjs (client)51.42 kB+0.09%+42 B 🔺
@sentry/sveltekit (client)47.04 kB+0.08%+34 B 🔺
@sentry/core/server80.33 kB+0.04%+25 B 🔺
@sentry/core/browser66.75 kB+0.07%+42 B 🔺
@sentry/node-core63.26 kB+0.07%+43 B 🔺
@sentry/node124.35 kB+0.05%+53 B 🔺
@sentry/node (incl. diagnostics channel injection)149.79 kB+0.02%+19 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection)70.03 kB--
@sentry/node/light51.38 kB+0.09%+46 B 🔺
@sentry/node - without tracing74.96 kB+0.07%+47 B 🔺
@sentry/aws-serverless84.2 kB+0.05%+34 B 🔺
@sentry/cloudflare (withSentry) - minified196.74 kB+0.08%+156 B 🔺
@sentry/cloudflare (withSentry)484.48 kB+0.14%+645 B 🔺
View base workflow run

This was referenced Jul 22, 2026

Open

 Open

@Lms24Lms24
mentioned this pull request
Aug 5, 2026
 Draft

@Lms24
Lms24
commented
Aug 6, 2026

Copy link


Copy Markdown

MemberAuthor
superseded by #23054
@Lms24Lms24
closed this
Aug 6, 2026
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Lms24

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(core): Account for clock drift in initial timestampInSeconds() call - #22488
Closed
Lms24 wants to merge 2 commits into
developfrom 
lms/fix-timeStampInSeconds-partially
Closed
fix(core): Account for clock drift in initial timestampInSeconds() call#22488
Lms24 wants to merge 2 commits into
developfrom 
lms/fix-timeStampInSeconds-partially
Conversation
@Lms24
@Lms24Lms24
commented
Jul 22, 2026•

edited

Loading

Copy link


Copy Markdown

Member
#22375 reports a valid bug which is that timestampInSeconds() may return an inaccurate time stamp, since we don't detect clock drift between the performance.timeOrigin + performance.now() timestamp and Date.now().
This PR intentionally only partially fixes this problem by adding a clock drift check only to the initial timestampInSeconds call. This should account for cases where the monotonic performance.now() clock is already off at SDK init time but won't catch clock drift later on.
From here we have two options:
  1. Also add the drift validity check to subsequent calls. This means we'll bypass caching (what we do now) until we detect clock drift, adding performance overhead by running the validity check on every timestampInSeconds call until then.
  2. Drop using the performance time APIs entirely and only return Date.now(). This should give us more accurate timing overall but:

    • we loose nanoseconds precision
    • we'd arguably now report accurate and inaccurate times in one trace because some spans are created from PerformanceEntry entries, which include relative timestamps that might have also suffered from clock drift.
I also still need to look at the sent_at header which should prompt Relay to perform clock-drift normalization but I'm not yet sure to which extent.
Keeping this draft as a possible mitigation open for now
@github-actions
github-actionsBot
commented
Jul 22, 2026

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser27.8 kB+0.17%+47 B 🔺
@sentry/browser - with treeshaking flags26.24 kB+0.18%+46 B 🔺
@sentry/browser (incl. Tracing)46.6 kB+0.04%+14 B 🔺
@sentry/browser (incl. Tracing + Span Streaming)48.41 kB+0.04%+17 B 🔺
@sentry/browser (incl. Tracing, Profiling)51.42 kB+0.07%+31 B 🔺
@sentry/browser (incl. Tracing, Replay)85.88 kB+0.06%+45 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags75.51 kB+0.06%+38 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)90.61 kB+0.07%+55 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)103.23 kB+0.02%+18 B 🔺
@sentry/browser (incl. Feedback)44.99 kB+0.11%+46 B 🔺
@sentry/browser (incl. sendFeedback)32.59 kB+0.12%+39 B 🔺
@sentry/browser (incl. FeedbackAsync)37.72 kB+0.1%+34 B 🔺
@sentry/browser (incl. Metrics)28.89 kB+0.19%+52 B 🔺
@sentry/browser (incl. Logs)29.12 kB+0.22%+62 B 🔺
@sentry/browser (incl. Metrics & Logs)29.82 kB+0.18%+52 B 🔺
@sentry/react29.6 kB+0.16%+46 B 🔺
@sentry/react (incl. Tracing)48.9 kB+0.07%+31 B 🔺
@sentry/vue33.23 kB+0.16%+52 B 🔺
@sentry/vue (incl. Tracing)48.6 kB+0.08%+38 B 🔺
@sentry/svelte27.82 kB+0.17%+47 B 🔺
CDN Bundle30.2 kB+0.15%+44 B 🔺
CDN Bundle (incl. Tracing)48.58 kB+0.04%+18 B 🔺
CDN Bundle (incl. Logs, Metrics)31.78 kB+0.13%+41 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics)49.9 kB+0.09%+42 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)71.04 kB+0.06%+36 B 🔺
CDN Bundle (incl. Tracing, Replay)86.09 kB+0.05%+37 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)87.41 kB+0.05%+35 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)91.9 kB+0.04%+35 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)93.18 kB+0.06%+51 B 🔺
CDN Bundle - uncompressed90 kB+0.13%+109 B 🔺
CDN Bundle (incl. Tracing) - uncompressed146.85 kB+0.06%+81 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed94.68 kB+0.09%+81 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed150.83 kB+0.06%+81 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed219.44 kB+0.04%+81 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed266.09 kB+0.04%+81 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed270.05 kB+0.04%+81 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed279.79 kB+0.03%+81 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed283.74 kB+0.03%+81 B 🔺
@sentry/nextjs (client)51.42 kB+0.09%+42 B 🔺
@sentry/sveltekit (client)47.04 kB+0.08%+34 B 🔺
@sentry/core/server80.33 kB+0.04%+25 B 🔺
@sentry/core/browser66.75 kB+0.07%+42 B 🔺
@sentry/node-core63.26 kB+0.07%+43 B 🔺
@sentry/node124.35 kB+0.05%+53 B 🔺
@sentry/node (incl. diagnostics channel injection)149.79 kB+0.02%+19 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection)70.03 kB--
@sentry/node/light51.38 kB+0.09%+46 B 🔺
@sentry/node - without tracing74.96 kB+0.07%+47 B 🔺
@sentry/aws-serverless84.2 kB+0.05%+34 B 🔺
@sentry/cloudflare (withSentry) - minified196.74 kB+0.08%+156 B 🔺
@sentry/cloudflare (withSentry)484.48 kB+0.14%+645 B 🔺
View base workflow run

This was referenced Jul 22, 2026

Open

 Open

@Lms24Lms24
mentioned this pull request
Aug 5, 2026
 Draft

@Lms24
Lms24
commented
Aug 6, 2026

Copy link


Copy Markdown

MemberAuthor
superseded by #23054
@Lms24Lms24
closed this
Aug 6, 2026
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Lms24

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
fix(core): Account for clock drift in initial timestampInSeconds() call - #22488
Closed
Lms24 wants to merge 2 commits into
developfrom 
lms/fix-timeStampInSeconds-partially
Closed
fix(core): Account for clock drift in initial timestampInSeconds() call#22488
Lms24 wants to merge 2 commits into
developfrom 
lms/fix-timeStampInSeconds-partially
Conversation
@Lms24
@Lms24Lms24
commented
Jul 22, 2026•

edited

Loading

Copy link


Copy Markdown

Member
#22375 reports a valid bug which is that timestampInSeconds() may return an inaccurate time stamp, since we don't detect clock drift between the performance.timeOrigin + performance.now() timestamp and Date.now().
This PR intentionally only partially fixes this problem by adding a clock drift check only to the initial timestampInSeconds call. This should account for cases where the monotonic performance.now() clock is already off at SDK init time but won't catch clock drift later on.
From here we have two options:
  1. Also add the drift validity check to subsequent calls. This means we'll bypass caching (what we do now) until we detect clock drift, adding performance overhead by running the validity check on every timestampInSeconds call until then.
  2. Drop using the performance time APIs entirely and only return Date.now(). This should give us more accurate timing overall but:

    • we loose nanoseconds precision
    • we'd arguably now report accurate and inaccurate times in one trace because some spans are created from PerformanceEntry entries, which include relative timestamps that might have also suffered from clock drift.
I also still need to look at the sent_at header which should prompt Relay to perform clock-drift normalization but I'm not yet sure to which extent.
Keeping this draft as a possible mitigation open for now
@github-actions
github-actionsBot
commented
Jul 22, 2026

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser27.8 kB+0.17%+47 B 🔺
@sentry/browser - with treeshaking flags26.24 kB+0.18%+46 B 🔺
@sentry/browser (incl. Tracing)46.6 kB+0.04%+14 B 🔺
@sentry/browser (incl. Tracing + Span Streaming)48.41 kB+0.04%+17 B 🔺
@sentry/browser (incl. Tracing, Profiling)51.42 kB+0.07%+31 B 🔺
@sentry/browser (incl. Tracing, Replay)85.88 kB+0.06%+45 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags75.51 kB+0.06%+38 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)90.61 kB+0.07%+55 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)103.23 kB+0.02%+18 B 🔺
@sentry/browser (incl. Feedback)44.99 kB+0.11%+46 B 🔺
@sentry/browser (incl. sendFeedback)32.59 kB+0.12%+39 B 🔺
@sentry/browser (incl. FeedbackAsync)37.72 kB+0.1%+34 B 🔺
@sentry/browser (incl. Metrics)28.89 kB+0.19%+52 B 🔺
@sentry/browser (incl. Logs)29.12 kB+0.22%+62 B 🔺
@sentry/browser (incl. Metrics & Logs)29.82 kB+0.18%+52 B 🔺
@sentry/react29.6 kB+0.16%+46 B 🔺
@sentry/react (incl. Tracing)48.9 kB+0.07%+31 B 🔺
@sentry/vue33.23 kB+0.16%+52 B 🔺
@sentry/vue (incl. Tracing)48.6 kB+0.08%+38 B 🔺
@sentry/svelte27.82 kB+0.17%+47 B 🔺
CDN Bundle30.2 kB+0.15%+44 B 🔺
CDN Bundle (incl. Tracing)48.58 kB+0.04%+18 B 🔺
CDN Bundle (incl. Logs, Metrics)31.78 kB+0.13%+41 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics)49.9 kB+0.09%+42 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)71.04 kB+0.06%+36 B 🔺
CDN Bundle (incl. Tracing, Replay)86.09 kB+0.05%+37 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)87.41 kB+0.05%+35 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)91.9 kB+0.04%+35 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)93.18 kB+0.06%+51 B 🔺
CDN Bundle - uncompressed90 kB+0.13%+109 B 🔺
CDN Bundle (incl. Tracing) - uncompressed146.85 kB+0.06%+81 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed94.68 kB+0.09%+81 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed150.83 kB+0.06%+81 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed219.44 kB+0.04%+81 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed266.09 kB+0.04%+81 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed270.05 kB+0.04%+81 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed279.79 kB+0.03%+81 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed283.74 kB+0.03%+81 B 🔺
@sentry/nextjs (client)51.42 kB+0.09%+42 B 🔺
@sentry/sveltekit (client)47.04 kB+0.08%+34 B 🔺
@sentry/core/server80.33 kB+0.04%+25 B 🔺
@sentry/core/browser66.75 kB+0.07%+42 B 🔺
@sentry/node-core63.26 kB+0.07%+43 B 🔺
@sentry/node124.35 kB+0.05%+53 B 🔺
@sentry/node (incl. diagnostics channel injection)149.79 kB+0.02%+19 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection)70.03 kB--
@sentry/node/light51.38 kB+0.09%+46 B 🔺
@sentry/node - without tracing74.96 kB+0.07%+47 B 🔺
@sentry/aws-serverless84.2 kB+0.05%+34 B 🔺
@sentry/cloudflare (withSentry) - minified196.74 kB+0.08%+156 B 🔺
@sentry/cloudflare (withSentry)484.48 kB+0.14%+645 B 🔺
View base workflow run

This was referenced Jul 22, 2026

Open

 Open

@Lms24Lms24
mentioned this pull request
Aug 5, 2026
 Draft

@Lms24
Lms24
commented
Aug 6, 2026

Copy link


Copy Markdown

MemberAuthor
superseded by #23054
@Lms24Lms24
closed this
Aug 6, 2026
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Lms24

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(core): Account for clock drift in initial timestampInSeconds() call - #22488
Closed
Lms24 wants to merge 2 commits into
developfrom 
lms/fix-timeStampInSeconds-partially
Closed
fix(core): Account for clock drift in initial timestampInSeconds() call#22488
Lms24 wants to merge 2 commits into
developfrom 
lms/fix-timeStampInSeconds-partially
Conversation
@Lms24
@Lms24Lms24
commented
Jul 22, 2026•

edited

Loading

Copy link


Copy Markdown

Member
#22375 reports a valid bug which is that timestampInSeconds() may return an inaccurate time stamp, since we don't detect clock drift between the performance.timeOrigin + performance.now() timestamp and Date.now().
This PR intentionally only partially fixes this problem by adding a clock drift check only to the initial timestampInSeconds call. This should account for cases where the monotonic performance.now() clock is already off at SDK init time but won't catch clock drift later on.
From here we have two options:
  1. Also add the drift validity check to subsequent calls. This means we'll bypass caching (what we do now) until we detect clock drift, adding performance overhead by running the validity check on every timestampInSeconds call until then.
  2. Drop using the performance time APIs entirely and only return Date.now(). This should give us more accurate timing overall but:

    • we loose nanoseconds precision
    • we'd arguably now report accurate and inaccurate times in one trace because some spans are created from PerformanceEntry entries, which include relative timestamps that might have also suffered from clock drift.
I also still need to look at the sent_at header which should prompt Relay to perform clock-drift normalization but I'm not yet sure to which extent.
Keeping this draft as a possible mitigation open for now
@github-actions
github-actionsBot
commented
Jul 22, 2026

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser27.8 kB+0.17%+47 B 🔺
@sentry/browser - with treeshaking flags26.24 kB+0.18%+46 B 🔺
@sentry/browser (incl. Tracing)46.6 kB+0.04%+14 B 🔺
@sentry/browser (incl. Tracing + Span Streaming)48.41 kB+0.04%+17 B 🔺
@sentry/browser (incl. Tracing, Profiling)51.42 kB+0.07%+31 B 🔺
@sentry/browser (incl. Tracing, Replay)85.88 kB+0.06%+45 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags75.51 kB+0.06%+38 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)90.61 kB+0.07%+55 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)103.23 kB+0.02%+18 B 🔺
@sentry/browser (incl. Feedback)44.99 kB+0.11%+46 B 🔺
@sentry/browser (incl. sendFeedback)32.59 kB+0.12%+39 B 🔺
@sentry/browser (incl. FeedbackAsync)37.72 kB+0.1%+34 B 🔺
@sentry/browser (incl. Metrics)28.89 kB+0.19%+52 B 🔺
@sentry/browser (incl. Logs)29.12 kB+0.22%+62 B 🔺
@sentry/browser (incl. Metrics & Logs)29.82 kB+0.18%+52 B 🔺
@sentry/react29.6 kB+0.16%+46 B 🔺
@sentry/react (incl. Tracing)48.9 kB+0.07%+31 B 🔺
@sentry/vue33.23 kB+0.16%+52 B 🔺
@sentry/vue (incl. Tracing)48.6 kB+0.08%+38 B 🔺
@sentry/svelte27.82 kB+0.17%+47 B 🔺
CDN Bundle30.2 kB+0.15%+44 B 🔺
CDN Bundle (incl. Tracing)48.58 kB+0.04%+18 B 🔺
CDN Bundle (incl. Logs, Metrics)31.78 kB+0.13%+41 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics)49.9 kB+0.09%+42 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)71.04 kB+0.06%+36 B 🔺
CDN Bundle (incl. Tracing, Replay)86.09 kB+0.05%+37 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)87.41 kB+0.05%+35 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)91.9 kB+0.04%+35 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)93.18 kB+0.06%+51 B 🔺
CDN Bundle - uncompressed90 kB+0.13%+109 B 🔺
CDN Bundle (incl. Tracing) - uncompressed146.85 kB+0.06%+81 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed94.68 kB+0.09%+81 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed150.83 kB+0.06%+81 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed219.44 kB+0.04%+81 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed266.09 kB+0.04%+81 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed270.05 kB+0.04%+81 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed279.79 kB+0.03%+81 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed283.74 kB+0.03%+81 B 🔺
@sentry/nextjs (client)51.42 kB+0.09%+42 B 🔺
@sentry/sveltekit (client)47.04 kB+0.08%+34 B 🔺
@sentry/core/server80.33 kB+0.04%+25 B 🔺
@sentry/core/browser66.75 kB+0.07%+42 B 🔺
@sentry/node-core63.26 kB+0.07%+43 B 🔺
@sentry/node124.35 kB+0.05%+53 B 🔺
@sentry/node (incl. diagnostics channel injection)149.79 kB+0.02%+19 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection)70.03 kB--
@sentry/node/light51.38 kB+0.09%+46 B 🔺
@sentry/node - without tracing74.96 kB+0.07%+47 B 🔺
@sentry/aws-serverless84.2 kB+0.05%+34 B 🔺
@sentry/cloudflare (withSentry) - minified196.74 kB+0.08%+156 B 🔺
@sentry/cloudflare (withSentry)484.48 kB+0.14%+645 B 🔺
View base workflow run

This was referenced Jul 22, 2026

Open

 Open

@Lms24Lms24
mentioned this pull request
Aug 5, 2026
 Draft

@Lms24
Lms24
commented
Aug 6, 2026

Copy link


Copy Markdown

MemberAuthor
superseded by #23054
@Lms24Lms24
closed this
Aug 6, 2026
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Lms24

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(core): Account for clock drift in initial timestampInSeconds() call - #22488
Closed
Lms24 wants to merge 2 commits into
developfrom 
lms/fix-timeStampInSeconds-partially
Closed
fix(core): Account for clock drift in initial timestampInSeconds() call#22488
Lms24 wants to merge 2 commits into
developfrom 
lms/fix-timeStampInSeconds-partially
Conversation
@Lms24
@Lms24Lms24
commented
Jul 22, 2026•

edited

Loading

Copy link


Copy Markdown

Member
#22375 reports a valid bug which is that timestampInSeconds() may return an inaccurate time stamp, since we don't detect clock drift between the performance.timeOrigin + performance.now() timestamp and Date.now().
This PR intentionally only partially fixes this problem by adding a clock drift check only to the initial timestampInSeconds call. This should account for cases where the monotonic performance.now() clock is already off at SDK init time but won't catch clock drift later on.
From here we have two options:
  1. Also add the drift validity check to subsequent calls. This means we'll bypass caching (what we do now) until we detect clock drift, adding performance overhead by running the validity check on every timestampInSeconds call until then.
  2. Drop using the performance time APIs entirely and only return Date.now(). This should give us more accurate timing overall but:

    • we loose nanoseconds precision
    • we'd arguably now report accurate and inaccurate times in one trace because some spans are created from PerformanceEntry entries, which include relative timestamps that might have also suffered from clock drift.
I also still need to look at the sent_at header which should prompt Relay to perform clock-drift normalization but I'm not yet sure to which extent.
Keeping this draft as a possible mitigation open for now
@github-actions
github-actionsBot
commented
Jul 22, 2026

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser27.8 kB+0.17%+47 B 🔺
@sentry/browser - with treeshaking flags26.24 kB+0.18%+46 B 🔺
@sentry/browser (incl. Tracing)46.6 kB+0.04%+14 B 🔺
@sentry/browser (incl. Tracing + Span Streaming)48.41 kB+0.04%+17 B 🔺
@sentry/browser (incl. Tracing, Profiling)51.42 kB+0.07%+31 B 🔺
@sentry/browser (incl. Tracing, Replay)85.88 kB+0.06%+45 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags75.51 kB+0.06%+38 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)90.61 kB+0.07%+55 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)103.23 kB+0.02%+18 B 🔺
@sentry/browser (incl. Feedback)44.99 kB+0.11%+46 B 🔺
@sentry/browser (incl. sendFeedback)32.59 kB+0.12%+39 B 🔺
@sentry/browser (incl. FeedbackAsync)37.72 kB+0.1%+34 B 🔺
@sentry/browser (incl. Metrics)28.89 kB+0.19%+52 B 🔺
@sentry/browser (incl. Logs)29.12 kB+0.22%+62 B 🔺
@sentry/browser (incl. Metrics & Logs)29.82 kB+0.18%+52 B 🔺
@sentry/react29.6 kB+0.16%+46 B 🔺
@sentry/react (incl. Tracing)48.9 kB+0.07%+31 B 🔺
@sentry/vue33.23 kB+0.16%+52 B 🔺
@sentry/vue (incl. Tracing)48.6 kB+0.08%+38 B 🔺
@sentry/svelte27.82 kB+0.17%+47 B 🔺
CDN Bundle30.2 kB+0.15%+44 B 🔺
CDN Bundle (incl. Tracing)48.58 kB+0.04%+18 B 🔺
CDN Bundle (incl. Logs, Metrics)31.78 kB+0.13%+41 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics)49.9 kB+0.09%+42 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)71.04 kB+0.06%+36 B 🔺
CDN Bundle (incl. Tracing, Replay)86.09 kB+0.05%+37 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)87.41 kB+0.05%+35 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)91.9 kB+0.04%+35 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)93.18 kB+0.06%+51 B 🔺
CDN Bundle - uncompressed90 kB+0.13%+109 B 🔺
CDN Bundle (incl. Tracing) - uncompressed146.85 kB+0.06%+81 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed94.68 kB+0.09%+81 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed150.83 kB+0.06%+81 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed219.44 kB+0.04%+81 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed266.09 kB+0.04%+81 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed270.05 kB+0.04%+81 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed279.79 kB+0.03%+81 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed283.74 kB+0.03%+81 B 🔺
@sentry/nextjs (client)51.42 kB+0.09%+42 B 🔺
@sentry/sveltekit (client)47.04 kB+0.08%+34 B 🔺
@sentry/core/server80.33 kB+0.04%+25 B 🔺
@sentry/core/browser66.75 kB+0.07%+42 B 🔺
@sentry/node-core63.26 kB+0.07%+43 B 🔺
@sentry/node124.35 kB+0.05%+53 B 🔺
@sentry/node (incl. diagnostics channel injection)149.79 kB+0.02%+19 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection)70.03 kB--
@sentry/node/light51.38 kB+0.09%+46 B 🔺
@sentry/node - without tracing74.96 kB+0.07%+47 B 🔺
@sentry/aws-serverless84.2 kB+0.05%+34 B 🔺
@sentry/cloudflare (withSentry) - minified196.74 kB+0.08%+156 B 🔺
@sentry/cloudflare (withSentry)484.48 kB+0.14%+645 B 🔺
View base workflow run

This was referenced Jul 22, 2026

Open

 Open

@Lms24Lms24
mentioned this pull request
Aug 5, 2026
 Draft

@Lms24
Lms24
commented
Aug 6, 2026

Copy link


Copy Markdown

MemberAuthor
superseded by #23054
@Lms24Lms24
closed this
Aug 6, 2026
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Lms24

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
fix(core): Account for clock drift in initial timestampInSeconds() call - #22488
Closed
Lms24 wants to merge 2 commits into
developfrom 
lms/fix-timeStampInSeconds-partially
Closed
fix(core): Account for clock drift in initial timestampInSeconds() call#22488
Lms24 wants to merge 2 commits into
developfrom 
lms/fix-timeStampInSeconds-partially
Conversation
@Lms24
@Lms24Lms24
commented
Jul 22, 2026•

edited

Loading

Copy link


Copy Markdown

Member
#22375 reports a valid bug which is that timestampInSeconds() may return an inaccurate time stamp, since we don't detect clock drift between the performance.timeOrigin + performance.now() timestamp and Date.now().
This PR intentionally only partially fixes this problem by adding a clock drift check only to the initial timestampInSeconds call. This should account for cases where the monotonic performance.now() clock is already off at SDK init time but won't catch clock drift later on.
From here we have two options:
  1. Also add the drift validity check to subsequent calls. This means we'll bypass caching (what we do now) until we detect clock drift, adding performance overhead by running the validity check on every timestampInSeconds call until then.
  2. Drop using the performance time APIs entirely and only return Date.now(). This should give us more accurate timing overall but:

    • we loose nanoseconds precision
    • we'd arguably now report accurate and inaccurate times in one trace because some spans are created from PerformanceEntry entries, which include relative timestamps that might have also suffered from clock drift.
I also still need to look at the sent_at header which should prompt Relay to perform clock-drift normalization but I'm not yet sure to which extent.
Keeping this draft as a possible mitigation open for now
@github-actions
github-actionsBot
commented
Jul 22, 2026

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser27.8 kB+0.17%+47 B 🔺
@sentry/browser - with treeshaking flags26.24 kB+0.18%+46 B 🔺
@sentry/browser (incl. Tracing)46.6 kB+0.04%+14 B 🔺
@sentry/browser (incl. Tracing + Span Streaming)48.41 kB+0.04%+17 B 🔺
@sentry/browser (incl. Tracing, Profiling)51.42 kB+0.07%+31 B 🔺
@sentry/browser (incl. Tracing, Replay)85.88 kB+0.06%+45 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags75.51 kB+0.06%+38 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)90.61 kB+0.07%+55 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)103.23 kB+0.02%+18 B 🔺
@sentry/browser (incl. Feedback)44.99 kB+0.11%+46 B 🔺
@sentry/browser (incl. sendFeedback)32.59 kB+0.12%+39 B 🔺
@sentry/browser (incl. FeedbackAsync)37.72 kB+0.1%+34 B 🔺
@sentry/browser (incl. Metrics)28.89 kB+0.19%+52 B 🔺
@sentry/browser (incl. Logs)29.12 kB+0.22%+62 B 🔺
@sentry/browser (incl. Metrics & Logs)29.82 kB+0.18%+52 B 🔺
@sentry/react29.6 kB+0.16%+46 B 🔺
@sentry/react (incl. Tracing)48.9 kB+0.07%+31 B 🔺
@sentry/vue33.23 kB+0.16%+52 B 🔺
@sentry/vue (incl. Tracing)48.6 kB+0.08%+38 B 🔺
@sentry/svelte27.82 kB+0.17%+47 B 🔺
CDN Bundle30.2 kB+0.15%+44 B 🔺
CDN Bundle (incl. Tracing)48.58 kB+0.04%+18 B 🔺
CDN Bundle (incl. Logs, Metrics)31.78 kB+0.13%+41 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics)49.9 kB+0.09%+42 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)71.04 kB+0.06%+36 B 🔺
CDN Bundle (incl. Tracing, Replay)86.09 kB+0.05%+37 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)87.41 kB+0.05%+35 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)91.9 kB+0.04%+35 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)93.18 kB+0.06%+51 B 🔺
CDN Bundle - uncompressed90 kB+0.13%+109 B 🔺
CDN Bundle (incl. Tracing) - uncompressed146.85 kB+0.06%+81 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed94.68 kB+0.09%+81 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed150.83 kB+0.06%+81 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed219.44 kB+0.04%+81 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed266.09 kB+0.04%+81 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed270.05 kB+0.04%+81 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed279.79 kB+0.03%+81 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed283.74 kB+0.03%+81 B 🔺
@sentry/nextjs (client)51.42 kB+0.09%+42 B 🔺
@sentry/sveltekit (client)47.04 kB+0.08%+34 B 🔺
@sentry/core/server80.33 kB+0.04%+25 B 🔺
@sentry/core/browser66.75 kB+0.07%+42 B 🔺
@sentry/node-core63.26 kB+0.07%+43 B 🔺
@sentry/node124.35 kB+0.05%+53 B 🔺
@sentry/node (incl. diagnostics channel injection)149.79 kB+0.02%+19 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection)70.03 kB--
@sentry/node/light51.38 kB+0.09%+46 B 🔺
@sentry/node - without tracing74.96 kB+0.07%+47 B 🔺
@sentry/aws-serverless84.2 kB+0.05%+34 B 🔺
@sentry/cloudflare (withSentry) - minified196.74 kB+0.08%+156 B 🔺
@sentry/cloudflare (withSentry)484.48 kB+0.14%+645 B 🔺
View base workflow run

This was referenced Jul 22, 2026

Open

 Open

@Lms24Lms24
mentioned this pull request
Aug 5, 2026
 Draft

@Lms24
Lms24
commented
Aug 6, 2026

Copy link


Copy Markdown

MemberAuthor
superseded by #23054
@Lms24Lms24
closed this
Aug 6, 2026
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@Lms24