Uh oh!
There was an error while loading. Please reload this page.
feat(astro): Auto-wire orchestrion build-time instrumentation - #22830
Merged
Conversation
MemberAuthor
bugborzer run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit f72aa25. Configure here.
Contributor
size-limit report 📦
|
The multi-line hook-call argument pushed the `AstroIntegrationLogger` type mismatch onto the `logger` property line, past the single `@ts-expect-error` covering the call. Collapse to a single-line call (matching the sibling deprecation test) so the suppression covers the whole argument. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
# Conflicts: # packages/astro/package.json
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
chargome
marked this pull request as ready for review
July 30, 2026 09:06
chargome
requested review from
andreiborza, nicohrubec and s1gr1d
and removed request for
a teamJuly 30, 2026 09:06
Comment on lines
+178
to
+184
| if (sdkEnabled.server && !isCloudflare) { | ||
| updateConfig({ | ||
| vite: { | ||
| plugins: [sentryOrchestrionPlugin({ buildTimeInstrumentation }) as VitePlugin], | ||
| }, | ||
| }); | ||
| } |
Contributor
There was a problem hiding this comment.
Bug: The orchestrion plugin is unconditionally injected in dev mode, causing its config() hook to add ssr.noExternal settings, which unnecessarily bundles packages and degrades performance.
Severity: MEDIUM
Suggested Fix
Wrap the updateConfig call for the orchestrion plugin in a condition that checks if the Astro command is not 'dev', similar to how the sourcemaps plugin is handled. This will prevent the plugin from being injected and its config() hook from running during development.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: packages/astro/src/integration/index.ts#L178-L184
Potential issue: The Sentry orchestrion plugin is injected unconditionally when
`sdkEnabled.server` is true, without checking if the Astro command is `dev`. While the
plugin's `applyToEnvironment` hook prevents code transformations, its `config()` hook
still executes. This hook injects `ssr.noExternal` configurations into the Vite config
during development. As a result, Vite is forced to bundle server-side packages (e.g.,
`mysql`, `ioredis`) that are not needed for the dev server, leading to degraded
performance. This affects all users running the Astro dev server with the default Sentry
integration settings.
Did we get this right? 👍 / 👎 to inform future reviews.
MemberAuthor
There was a problem hiding this comment.
Why would they not be needed for dev?
Add `test:dev` (TEST_ENV=development, `astro dev`) alongside the existing production run and make `test:assert` run both, mirroring the nextjs e2e apps. This exercises the auto-wired orchestrion transform in Vite's dev SSR path, not just the production bundle. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
s1gr1d
approved these changes
Jul 30, 2026
This reverts commit f0e65b4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sentryAstro()now injects the orchestrion bundler plugin into the Vite config automatically duringastro:config:setup, so instrumented server-side dependencies getdiagnostics_channelpublishers injected into the SSR bundle at build time with no manual plugin setup.The
astro-7-orchestrione2e app is migrated off its manualvite.plugins: [sentryOrchestrionPlugin()]wiring to prove the built-in path.dev server investigation postponed to #22857
closes#22686