Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,8 @@ function assertGenAiStreamingSpan(span: SerializedStreamedSpan): void {
expect(span.attributes['gen_ai.usage.input_tokens']?.value).toBe(15);
expect(span.attributes['gen_ai.usage.output_tokens']?.value).toBe(8);
expect(span.attributes['gen_ai.usage.total_tokens']?.value).toBe(23);
// Both agents are addressed as `.../test`, so the instance name is the conversation id.
expect(span.attributes['gen_ai.conversation.id']?.value).toBe('test');
}

test('captures Workers AI streaming output when driven via an Agent', async ({ request, baseURL }) => {
Expand Down
8 changes: 5 additions & 3 deletions packages/cloudflare/src/instrumentations/agents/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import { instrumentAgentCallableRpc } from './instrumentAgentCallableRpc';
import { instrumentAgentRequestConversation } from './instrumentAgentRequestConversation';
import { instrumentChatAgentConversation } from './instrumentChatAgentConversation';
import type { AgentInternals } from './types';

Expand All@@ -8,9 +9,9 @@ import type { AgentInternals } from './types';
*
* - **Callable RPC spans** — a span (op `rpc`) for each `@callable()` method invoked over WebSocket.
* - **Conversation correlation** — sets the conversation id on the scope for each unit of agent
* work — chat turn or callable RPC call— so `gen_ai` spans created within it are correlated, for
* chat and plain agents alike. Defaults to the instance `name` and is rotated when the chat is
* cleared (the `message:clear` observability event).
* work — chat turn, callable RPC call, or HTTP request — so `gen_ai` spans created within it are
* correlated, for chat and plain agents alike. Defaults to the instance `name` and is rotated
* when the chat is cleared (the `message:clear` observability event).
*
* It only hooks the `agents` package internals and uses Sentry's tracing primitives. On Cloudflare
* Workers, prefer `instrumentAgentWithSentry`, which additionally instruments the Durable Object
Expand All@@ -29,6 +30,7 @@ export function instrumentCloudflareAgent<T extends object>(agent: T): T {

instrumentAgentCallableRpc(internals);
instrumentChatAgentConversation(internals);
instrumentAgentRequestConversation(internals);

return agent;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
import { type AgentInternals, setAgentConversationId } from './types';

/**
* Correlates the AI spans of an HTTP-driven agent turn with a conversation id on the active scope.
*
* `onRequest` is the third unit of agent work, alongside chat turns and `@callable()` RPC: the
* `agents` router sends every non-WebSocket request to it, which is how REST endpoints and webhooks
* reach an agent.
*
* `agents` installs `onRequest` as an own property in the `Agent` constructor (as it does
* `onMessage`), and we instrument after construction, so wrapping the own property is what the
* router ends up calling.
*/
export function instrumentAgentRequestConversation(obj: AgentInternals): void {
const original = obj.onRequest;

if (typeof original !== 'function') {
return;
}

obj.onRequest = new Proxy(original, {
apply(target, thisArg: AgentInternals, args: unknown[]): unknown {
setAgentConversationId(thisArg);

return Reflect.apply(target, thisArg, args);
},
});
}
2 changes: 2 additions & 0 deletions packages/cloudflare/src/instrumentations/agents/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,8 @@ export interface AgentInternals {
* does not, so its presence discriminates a chat agent.
*/
onChatMessage?: (...args: unknown[]) => unknown;
/** HTTP request handler; the router sends every non-WebSocket request here. */
onRequest?: (...args: unknown[]) => unknown;
/** The user's Agent class (used by the SDK for the observability event `agent` field). */
_ParentClass?: { name?: string };
/** The Agent instance name, which in the Agents model identifies the conversation/thread. */
Expand Down
38 changes: 38 additions & 0 deletions packages/cloudflare/test/instrumentCloudflareAgent.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -157,5 +157,43 @@ describe('instrumentCloudflareAgent', () => {
expect(agent.seenConversationId).toBe('instance-1');
expect('onChatMessage' in agent).toBe(false);
});

it('sets the conversation id during an HTTP request', () => {
const agent = createFakeAgent({
onRequest(this: any) {
this.seenConversationId = getCurrentScope().getScopeData().conversationId;
return 'response';
},
});
instrumentCloudflareAgent(agent);

const result = agent.onRequest(new Request('https://example.com/agents/my-agent/instance-1'));

expect(result).toBe('response');
expect(agent.seenConversationId).toBe('instance-1');
});

it('prefers the rotated conversation id over the instance name on the HTTP path', () => {
const agent = createFakeAgent({
onRequest(this: any) {
this.seenConversationId = getCurrentScope().getScopeData().conversationId;
return 'response';
},
});
instrumentCloudflareAgent(agent);

agent._emit?.('message:clear');
agent.__sentryConversationId = 'rotated-id';
agent.onRequest(new Request('https://example.com/agents/my-agent/instance-1'));

expect(agent.seenConversationId).toBe('rotated-id');
});

it('does not throw when the agent has no onRequest handler', () => {
const agent = createFakeAgent();

expect(() => instrumentCloudflareAgent(agent)).not.toThrow();
expect('onRequest' in agent).toBe(false);
});
});
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,8 @@ function assertGenAiStreamingSpan(span: SerializedStreamedSpan): void {
expect(span.attributes['gen_ai.usage.input_tokens']?.value).toBe(15);
expect(span.attributes['gen_ai.usage.output_tokens']?.value).toBe(8);
expect(span.attributes['gen_ai.usage.total_tokens']?.value).toBe(23);
// Both agents are addressed as `.../test`, so the instance name is the conversation id.
expect(span.attributes['gen_ai.conversation.id']?.value).toBe('test');
}

test('captures Workers AI streaming output when driven via an Agent', async ({ request, baseURL }) => {
Expand Down
8 changes: 5 additions & 3 deletions packages/cloudflare/src/instrumentations/agents/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import { instrumentAgentCallableRpc } from './instrumentAgentCallableRpc';
import { instrumentAgentRequestConversation } from './instrumentAgentRequestConversation';
import { instrumentChatAgentConversation } from './instrumentChatAgentConversation';
import type { AgentInternals } from './types';

Expand All@@ -8,9 +9,9 @@ import type { AgentInternals } from './types';
*
* - **Callable RPC spans** — a span (op `rpc`) for each `@callable()` method invoked over WebSocket.
* - **Conversation correlation** — sets the conversation id on the scope for each unit of agent
* work — chat turn or callable RPC call— so `gen_ai` spans created within it are correlated, for
* chat and plain agents alike. Defaults to the instance `name` and is rotated when the chat is
* cleared (the `message:clear` observability event).
* work — chat turn, callable RPC call, or HTTP request — so `gen_ai` spans created within it are
* correlated, for chat and plain agents alike. Defaults to the instance `name` and is rotated
* when the chat is cleared (the `message:clear` observability event).
*
* It only hooks the `agents` package internals and uses Sentry's tracing primitives. On Cloudflare
* Workers, prefer `instrumentAgentWithSentry`, which additionally instruments the Durable Object
Expand All@@ -29,6 +30,7 @@ export function instrumentCloudflareAgent<T extends object>(agent: T): T {

instrumentAgentCallableRpc(internals);
instrumentChatAgentConversation(internals);
instrumentAgentRequestConversation(internals);

return agent;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
import { type AgentInternals, setAgentConversationId } from './types';

/**
* Correlates the AI spans of an HTTP-driven agent turn with a conversation id on the active scope.
*
* `onRequest` is the third unit of agent work, alongside chat turns and `@callable()` RPC: the
* `agents` router sends every non-WebSocket request to it, which is how REST endpoints and webhooks
* reach an agent.
*
* `agents` installs `onRequest` as an own property in the `Agent` constructor (as it does
* `onMessage`), and we instrument after construction, so wrapping the own property is what the
* router ends up calling.
*/
export function instrumentAgentRequestConversation(obj: AgentInternals): void {
const original = obj.onRequest;

if (typeof original !== 'function') {
return;
}

obj.onRequest = new Proxy(original, {
apply(target, thisArg: AgentInternals, args: unknown[]): unknown {
setAgentConversationId(thisArg);

return Reflect.apply(target, thisArg, args);
},
});
}
2 changes: 2 additions & 0 deletions packages/cloudflare/src/instrumentations/agents/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,8 @@ export interface AgentInternals {
* does not, so its presence discriminates a chat agent.
*/
onChatMessage?: (...args: unknown[]) => unknown;
/** HTTP request handler; the router sends every non-WebSocket request here. */
onRequest?: (...args: unknown[]) => unknown;
/** The user's Agent class (used by the SDK for the observability event `agent` field). */
_ParentClass?: { name?: string };
/** The Agent instance name, which in the Agents model identifies the conversation/thread. */
Expand Down
38 changes: 38 additions & 0 deletions packages/cloudflare/test/instrumentCloudflareAgent.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -157,5 +157,43 @@ describe('instrumentCloudflareAgent', () => {
expect(agent.seenConversationId).toBe('instance-1');
expect('onChatMessage' in agent).toBe(false);
});

it('sets the conversation id during an HTTP request', () => {
const agent = createFakeAgent({
onRequest(this: any) {
this.seenConversationId = getCurrentScope().getScopeData().conversationId;
return 'response';
},
});
instrumentCloudflareAgent(agent);

const result = agent.onRequest(new Request('https://example.com/agents/my-agent/instance-1'));

expect(result).toBe('response');
expect(agent.seenConversationId).toBe('instance-1');
});

it('prefers the rotated conversation id over the instance name on the HTTP path', () => {
const agent = createFakeAgent({
onRequest(this: any) {
this.seenConversationId = getCurrentScope().getScopeData().conversationId;
return 'response';
},
});
instrumentCloudflareAgent(agent);

agent._emit?.('message:clear');
agent.__sentryConversationId = 'rotated-id';
agent.onRequest(new Request('https://example.com/agents/my-agent/instance-1'));

expect(agent.seenConversationId).toBe('rotated-id');
});

it('does not throw when the agent has no onRequest handler', () => {
const agent = createFakeAgent();

expect(() => instrumentCloudflareAgent(agent)).not.toThrow();
expect('onRequest' in agent).toBe(false);
});
});
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,8 @@ function assertGenAiStreamingSpan(span: SerializedStreamedSpan): void {
expect(span.attributes['gen_ai.usage.input_tokens']?.value).toBe(15);
expect(span.attributes['gen_ai.usage.output_tokens']?.value).toBe(8);
expect(span.attributes['gen_ai.usage.total_tokens']?.value).toBe(23);
// Both agents are addressed as `.../test`, so the instance name is the conversation id.
expect(span.attributes['gen_ai.conversation.id']?.value).toBe('test');
}

test('captures Workers AI streaming output when driven via an Agent', async ({ request, baseURL }) => {
Expand Down
8 changes: 5 additions & 3 deletions packages/cloudflare/src/instrumentations/agents/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import { instrumentAgentCallableRpc } from './instrumentAgentCallableRpc';
import { instrumentAgentRequestConversation } from './instrumentAgentRequestConversation';
import { instrumentChatAgentConversation } from './instrumentChatAgentConversation';
import type { AgentInternals } from './types';

Expand All@@ -8,9 +9,9 @@ import type { AgentInternals } from './types';
*
* - **Callable RPC spans** — a span (op `rpc`) for each `@callable()` method invoked over WebSocket.
* - **Conversation correlation** — sets the conversation id on the scope for each unit of agent
* work — chat turn or callable RPC call— so `gen_ai` spans created within it are correlated, for
* chat and plain agents alike. Defaults to the instance `name` and is rotated when the chat is
* cleared (the `message:clear` observability event).
* work — chat turn, callable RPC call, or HTTP request — so `gen_ai` spans created within it are
* correlated, for chat and plain agents alike. Defaults to the instance `name` and is rotated
* when the chat is cleared (the `message:clear` observability event).
*
* It only hooks the `agents` package internals and uses Sentry's tracing primitives. On Cloudflare
* Workers, prefer `instrumentAgentWithSentry`, which additionally instruments the Durable Object
Expand All@@ -29,6 +30,7 @@ export function instrumentCloudflareAgent<T extends object>(agent: T): T {

instrumentAgentCallableRpc(internals);
instrumentChatAgentConversation(internals);
instrumentAgentRequestConversation(internals);

return agent;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
import { type AgentInternals, setAgentConversationId } from './types';

/**
* Correlates the AI spans of an HTTP-driven agent turn with a conversation id on the active scope.
*
* `onRequest` is the third unit of agent work, alongside chat turns and `@callable()` RPC: the
* `agents` router sends every non-WebSocket request to it, which is how REST endpoints and webhooks
* reach an agent.
*
* `agents` installs `onRequest` as an own property in the `Agent` constructor (as it does
* `onMessage`), and we instrument after construction, so wrapping the own property is what the
* router ends up calling.
*/
export function instrumentAgentRequestConversation(obj: AgentInternals): void {
const original = obj.onRequest;

if (typeof original !== 'function') {
return;
}

obj.onRequest = new Proxy(original, {
apply(target, thisArg: AgentInternals, args: unknown[]): unknown {
setAgentConversationId(thisArg);

return Reflect.apply(target, thisArg, args);
},
});
}
2 changes: 2 additions & 0 deletions packages/cloudflare/src/instrumentations/agents/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,8 @@ export interface AgentInternals {
* does not, so its presence discriminates a chat agent.
*/
onChatMessage?: (...args: unknown[]) => unknown;
/** HTTP request handler; the router sends every non-WebSocket request here. */
onRequest?: (...args: unknown[]) => unknown;
/** The user's Agent class (used by the SDK for the observability event `agent` field). */
_ParentClass?: { name?: string };
/** The Agent instance name, which in the Agents model identifies the conversation/thread. */
Expand Down
38 changes: 38 additions & 0 deletions packages/cloudflare/test/instrumentCloudflareAgent.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -157,5 +157,43 @@ describe('instrumentCloudflareAgent', () => {
expect(agent.seenConversationId).toBe('instance-1');
expect('onChatMessage' in agent).toBe(false);
});

it('sets the conversation id during an HTTP request', () => {
const agent = createFakeAgent({
onRequest(this: any) {
this.seenConversationId = getCurrentScope().getScopeData().conversationId;
return 'response';
},
});
instrumentCloudflareAgent(agent);

const result = agent.onRequest(new Request('https://example.com/agents/my-agent/instance-1'));

expect(result).toBe('response');
expect(agent.seenConversationId).toBe('instance-1');
});

it('prefers the rotated conversation id over the instance name on the HTTP path', () => {
const agent = createFakeAgent({
onRequest(this: any) {
this.seenConversationId = getCurrentScope().getScopeData().conversationId;
return 'response';
},
});
instrumentCloudflareAgent(agent);

agent._emit?.('message:clear');
agent.__sentryConversationId = 'rotated-id';
agent.onRequest(new Request('https://example.com/agents/my-agent/instance-1'));

expect(agent.seenConversationId).toBe('rotated-id');
});

it('does not throw when the agent has no onRequest handler', () => {
const agent = createFakeAgent();

expect(() => instrumentCloudflareAgent(agent)).not.toThrow();
expect('onRequest' in agent).toBe(false);
});
});
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,8 @@ function assertGenAiStreamingSpan(span: SerializedStreamedSpan): void {
expect(span.attributes['gen_ai.usage.input_tokens']?.value).toBe(15);
expect(span.attributes['gen_ai.usage.output_tokens']?.value).toBe(8);
expect(span.attributes['gen_ai.usage.total_tokens']?.value).toBe(23);
// Both agents are addressed as `.../test`, so the instance name is the conversation id.
expect(span.attributes['gen_ai.conversation.id']?.value).toBe('test');
}

test('captures Workers AI streaming output when driven via an Agent', async ({ request, baseURL }) => {
Expand Down
8 changes: 5 additions & 3 deletions packages/cloudflare/src/instrumentations/agents/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import { instrumentAgentCallableRpc } from './instrumentAgentCallableRpc';
import { instrumentAgentRequestConversation } from './instrumentAgentRequestConversation';
import { instrumentChatAgentConversation } from './instrumentChatAgentConversation';
import type { AgentInternals } from './types';

Expand All@@ -8,9 +9,9 @@ import type { AgentInternals } from './types';
*
* - **Callable RPC spans** — a span (op `rpc`) for each `@callable()` method invoked over WebSocket.
* - **Conversation correlation** — sets the conversation id on the scope for each unit of agent
* work — chat turn or callable RPC call— so `gen_ai` spans created within it are correlated, for
* chat and plain agents alike. Defaults to the instance `name` and is rotated when the chat is
* cleared (the `message:clear` observability event).
* work — chat turn, callable RPC call, or HTTP request — so `gen_ai` spans created within it are
* correlated, for chat and plain agents alike. Defaults to the instance `name` and is rotated
* when the chat is cleared (the `message:clear` observability event).
*
* It only hooks the `agents` package internals and uses Sentry's tracing primitives. On Cloudflare
* Workers, prefer `instrumentAgentWithSentry`, which additionally instruments the Durable Object
Expand All@@ -29,6 +30,7 @@ export function instrumentCloudflareAgent<T extends object>(agent: T): T {

instrumentAgentCallableRpc(internals);
instrumentChatAgentConversation(internals);
instrumentAgentRequestConversation(internals);

return agent;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
import { type AgentInternals, setAgentConversationId } from './types';

/**
* Correlates the AI spans of an HTTP-driven agent turn with a conversation id on the active scope.
*
* `onRequest` is the third unit of agent work, alongside chat turns and `@callable()` RPC: the
* `agents` router sends every non-WebSocket request to it, which is how REST endpoints and webhooks
* reach an agent.
*
* `agents` installs `onRequest` as an own property in the `Agent` constructor (as it does
* `onMessage`), and we instrument after construction, so wrapping the own property is what the
* router ends up calling.
*/
export function instrumentAgentRequestConversation(obj: AgentInternals): void {
const original = obj.onRequest;

if (typeof original !== 'function') {
return;
}

obj.onRequest = new Proxy(original, {
apply(target, thisArg: AgentInternals, args: unknown[]): unknown {
setAgentConversationId(thisArg);

return Reflect.apply(target, thisArg, args);
},
});
}
2 changes: 2 additions & 0 deletions packages/cloudflare/src/instrumentations/agents/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,8 @@ export interface AgentInternals {
* does not, so its presence discriminates a chat agent.
*/
onChatMessage?: (...args: unknown[]) => unknown;
/** HTTP request handler; the router sends every non-WebSocket request here. */
onRequest?: (...args: unknown[]) => unknown;
/** The user's Agent class (used by the SDK for the observability event `agent` field). */
_ParentClass?: { name?: string };
/** The Agent instance name, which in the Agents model identifies the conversation/thread. */
Expand Down
38 changes: 38 additions & 0 deletions packages/cloudflare/test/instrumentCloudflareAgent.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -157,5 +157,43 @@ describe('instrumentCloudflareAgent', () => {
expect(agent.seenConversationId).toBe('instance-1');
expect('onChatMessage' in agent).toBe(false);
});

it('sets the conversation id during an HTTP request', () => {
const agent = createFakeAgent({
onRequest(this: any) {
this.seenConversationId = getCurrentScope().getScopeData().conversationId;
return 'response';
},
});
instrumentCloudflareAgent(agent);

const result = agent.onRequest(new Request('https://example.com/agents/my-agent/instance-1'));

expect(result).toBe('response');
expect(agent.seenConversationId).toBe('instance-1');
});

it('prefers the rotated conversation id over the instance name on the HTTP path', () => {
const agent = createFakeAgent({
onRequest(this: any) {
this.seenConversationId = getCurrentScope().getScopeData().conversationId;
return 'response';
},
});
instrumentCloudflareAgent(agent);

agent._emit?.('message:clear');
agent.__sentryConversationId = 'rotated-id';
agent.onRequest(new Request('https://example.com/agents/my-agent/instance-1'));

expect(agent.seenConversationId).toBe('rotated-id');
});

it('does not throw when the agent has no onRequest handler', () => {
const agent = createFakeAgent();

expect(() => instrumentCloudflareAgent(agent)).not.toThrow();
expect('onRequest' in agent).toBe(false);
});
});
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,8 @@ function assertGenAiStreamingSpan(span: SerializedStreamedSpan): void {
expect(span.attributes['gen_ai.usage.input_tokens']?.value).toBe(15);
expect(span.attributes['gen_ai.usage.output_tokens']?.value).toBe(8);
expect(span.attributes['gen_ai.usage.total_tokens']?.value).toBe(23);
// Both agents are addressed as `.../test`, so the instance name is the conversation id.
expect(span.attributes['gen_ai.conversation.id']?.value).toBe('test');
}

test('captures Workers AI streaming output when driven via an Agent', async ({ request, baseURL }) => {
Expand Down
8 changes: 5 additions & 3 deletions packages/cloudflare/src/instrumentations/agents/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import { instrumentAgentCallableRpc } from './instrumentAgentCallableRpc';
import { instrumentAgentRequestConversation } from './instrumentAgentRequestConversation';
import { instrumentChatAgentConversation } from './instrumentChatAgentConversation';
import type { AgentInternals } from './types';

Expand All@@ -8,9 +9,9 @@ import type { AgentInternals } from './types';
*
* - **Callable RPC spans** — a span (op `rpc`) for each `@callable()` method invoked over WebSocket.
* - **Conversation correlation** — sets the conversation id on the scope for each unit of agent
* work — chat turn or callable RPC call— so `gen_ai` spans created within it are correlated, for
* chat and plain agents alike. Defaults to the instance `name` and is rotated when the chat is
* cleared (the `message:clear` observability event).
* work — chat turn, callable RPC call, or HTTP request — so `gen_ai` spans created within it are
* correlated, for chat and plain agents alike. Defaults to the instance `name` and is rotated
* when the chat is cleared (the `message:clear` observability event).
*
* It only hooks the `agents` package internals and uses Sentry's tracing primitives. On Cloudflare
* Workers, prefer `instrumentAgentWithSentry`, which additionally instruments the Durable Object
Expand All@@ -29,6 +30,7 @@ export function instrumentCloudflareAgent<T extends object>(agent: T): T {

instrumentAgentCallableRpc(internals);
instrumentChatAgentConversation(internals);
instrumentAgentRequestConversation(internals);

return agent;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
import { type AgentInternals, setAgentConversationId } from './types';

/**
* Correlates the AI spans of an HTTP-driven agent turn with a conversation id on the active scope.
*
* `onRequest` is the third unit of agent work, alongside chat turns and `@callable()` RPC: the
* `agents` router sends every non-WebSocket request to it, which is how REST endpoints and webhooks
* reach an agent.
*
* `agents` installs `onRequest` as an own property in the `Agent` constructor (as it does
* `onMessage`), and we instrument after construction, so wrapping the own property is what the
* router ends up calling.
*/
export function instrumentAgentRequestConversation(obj: AgentInternals): void {
const original = obj.onRequest;

if (typeof original !== 'function') {
return;
}

obj.onRequest = new Proxy(original, {
apply(target, thisArg: AgentInternals, args: unknown[]): unknown {
setAgentConversationId(thisArg);

return Reflect.apply(target, thisArg, args);
},
});
}
2 changes: 2 additions & 0 deletions packages/cloudflare/src/instrumentations/agents/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,8 @@ export interface AgentInternals {
* does not, so its presence discriminates a chat agent.
*/
onChatMessage?: (...args: unknown[]) => unknown;
/** HTTP request handler; the router sends every non-WebSocket request here. */
onRequest?: (...args: unknown[]) => unknown;
/** The user's Agent class (used by the SDK for the observability event `agent` field). */
_ParentClass?: { name?: string };
/** The Agent instance name, which in the Agents model identifies the conversation/thread. */
Expand Down
38 changes: 38 additions & 0 deletions packages/cloudflare/test/instrumentCloudflareAgent.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -157,5 +157,43 @@ describe('instrumentCloudflareAgent', () => {
expect(agent.seenConversationId).toBe('instance-1');
expect('onChatMessage' in agent).toBe(false);
});

it('sets the conversation id during an HTTP request', () => {
const agent = createFakeAgent({
onRequest(this: any) {
this.seenConversationId = getCurrentScope().getScopeData().conversationId;
return 'response';
},
});
instrumentCloudflareAgent(agent);

const result = agent.onRequest(new Request('https://example.com/agents/my-agent/instance-1'));

expect(result).toBe('response');
expect(agent.seenConversationId).toBe('instance-1');
});

it('prefers the rotated conversation id over the instance name on the HTTP path', () => {
const agent = createFakeAgent({
onRequest(this: any) {
this.seenConversationId = getCurrentScope().getScopeData().conversationId;
return 'response';
},
});
instrumentCloudflareAgent(agent);

agent._emit?.('message:clear');
agent.__sentryConversationId = 'rotated-id';
agent.onRequest(new Request('https://example.com/agents/my-agent/instance-1'));

expect(agent.seenConversationId).toBe('rotated-id');
});

it('does not throw when the agent has no onRequest handler', () => {
const agent = createFakeAgent();

expect(() => instrumentCloudflareAgent(agent)).not.toThrow();
expect('onRequest' in agent).toBe(false);
});
});
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,8 @@ function assertGenAiStreamingSpan(span: SerializedStreamedSpan): void {
expect(span.attributes['gen_ai.usage.input_tokens']?.value).toBe(15);
expect(span.attributes['gen_ai.usage.output_tokens']?.value).toBe(8);
expect(span.attributes['gen_ai.usage.total_tokens']?.value).toBe(23);
// Both agents are addressed as `.../test`, so the instance name is the conversation id.
expect(span.attributes['gen_ai.conversation.id']?.value).toBe('test');
}

test('captures Workers AI streaming output when driven via an Agent', async ({ request, baseURL }) => {
Expand Down
8 changes: 5 additions & 3 deletions packages/cloudflare/src/instrumentations/agents/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import { instrumentAgentCallableRpc } from './instrumentAgentCallableRpc';
import { instrumentAgentRequestConversation } from './instrumentAgentRequestConversation';
import { instrumentChatAgentConversation } from './instrumentChatAgentConversation';
import type { AgentInternals } from './types';

Expand All@@ -8,9 +9,9 @@ import type { AgentInternals } from './types';
*
* - **Callable RPC spans** — a span (op `rpc`) for each `@callable()` method invoked over WebSocket.
* - **Conversation correlation** — sets the conversation id on the scope for each unit of agent
* work — chat turn or callable RPC call— so `gen_ai` spans created within it are correlated, for
* chat and plain agents alike. Defaults to the instance `name` and is rotated when the chat is
* cleared (the `message:clear` observability event).
* work — chat turn, callable RPC call, or HTTP request — so `gen_ai` spans created within it are
* correlated, for chat and plain agents alike. Defaults to the instance `name` and is rotated
* when the chat is cleared (the `message:clear` observability event).
*
* It only hooks the `agents` package internals and uses Sentry's tracing primitives. On Cloudflare
* Workers, prefer `instrumentAgentWithSentry`, which additionally instruments the Durable Object
Expand All@@ -29,6 +30,7 @@ export function instrumentCloudflareAgent<T extends object>(agent: T): T {

instrumentAgentCallableRpc(internals);
instrumentChatAgentConversation(internals);
instrumentAgentRequestConversation(internals);

return agent;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
import { type AgentInternals, setAgentConversationId } from './types';

/**
* Correlates the AI spans of an HTTP-driven agent turn with a conversation id on the active scope.
*
* `onRequest` is the third unit of agent work, alongside chat turns and `@callable()` RPC: the
* `agents` router sends every non-WebSocket request to it, which is how REST endpoints and webhooks
* reach an agent.
*
* `agents` installs `onRequest` as an own property in the `Agent` constructor (as it does
* `onMessage`), and we instrument after construction, so wrapping the own property is what the
* router ends up calling.
*/
export function instrumentAgentRequestConversation(obj: AgentInternals): void {
const original = obj.onRequest;

if (typeof original !== 'function') {
return;
}

obj.onRequest = new Proxy(original, {
apply(target, thisArg: AgentInternals, args: unknown[]): unknown {
setAgentConversationId(thisArg);

return Reflect.apply(target, thisArg, args);
},
});
}
2 changes: 2 additions & 0 deletions packages/cloudflare/src/instrumentations/agents/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,8 @@ export interface AgentInternals {
* does not, so its presence discriminates a chat agent.
*/
onChatMessage?: (...args: unknown[]) => unknown;
/** HTTP request handler; the router sends every non-WebSocket request here. */
onRequest?: (...args: unknown[]) => unknown;
/** The user's Agent class (used by the SDK for the observability event `agent` field). */
_ParentClass?: { name?: string };
/** The Agent instance name, which in the Agents model identifies the conversation/thread. */
Expand Down
38 changes: 38 additions & 0 deletions packages/cloudflare/test/instrumentCloudflareAgent.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -157,5 +157,43 @@ describe('instrumentCloudflareAgent', () => {
expect(agent.seenConversationId).toBe('instance-1');
expect('onChatMessage' in agent).toBe(false);
});

it('sets the conversation id during an HTTP request', () => {
const agent = createFakeAgent({
onRequest(this: any) {
this.seenConversationId = getCurrentScope().getScopeData().conversationId;
return 'response';
},
});
instrumentCloudflareAgent(agent);

const result = agent.onRequest(new Request('https://example.com/agents/my-agent/instance-1'));

expect(result).toBe('response');
expect(agent.seenConversationId).toBe('instance-1');
});

it('prefers the rotated conversation id over the instance name on the HTTP path', () => {
const agent = createFakeAgent({
onRequest(this: any) {
this.seenConversationId = getCurrentScope().getScopeData().conversationId;
return 'response';
},
});
instrumentCloudflareAgent(agent);

agent._emit?.('message:clear');
agent.__sentryConversationId = 'rotated-id';
agent.onRequest(new Request('https://example.com/agents/my-agent/instance-1'));

expect(agent.seenConversationId).toBe('rotated-id');
});

it('does not throw when the agent has no onRequest handler', () => {
const agent = createFakeAgent();

expect(() => instrumentCloudflareAgent(agent)).not.toThrow();
expect('onRequest' in agent).toBe(false);
});
});
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,8 @@ function assertGenAiStreamingSpan(span: SerializedStreamedSpan): void {
expect(span.attributes['gen_ai.usage.input_tokens']?.value).toBe(15);
expect(span.attributes['gen_ai.usage.output_tokens']?.value).toBe(8);
expect(span.attributes['gen_ai.usage.total_tokens']?.value).toBe(23);
// Both agents are addressed as `.../test`, so the instance name is the conversation id.
expect(span.attributes['gen_ai.conversation.id']?.value).toBe('test');
}

test('captures Workers AI streaming output when driven via an Agent', async ({ request, baseURL }) => {
Expand Down
8 changes: 5 additions & 3 deletions packages/cloudflare/src/instrumentations/agents/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import { instrumentAgentCallableRpc } from './instrumentAgentCallableRpc';
import { instrumentAgentRequestConversation } from './instrumentAgentRequestConversation';
import { instrumentChatAgentConversation } from './instrumentChatAgentConversation';
import type { AgentInternals } from './types';

Expand All@@ -8,9 +9,9 @@ import type { AgentInternals } from './types';
*
* - **Callable RPC spans** — a span (op `rpc`) for each `@callable()` method invoked over WebSocket.
* - **Conversation correlation** — sets the conversation id on the scope for each unit of agent
* work — chat turn or callable RPC call— so `gen_ai` spans created within it are correlated, for
* chat and plain agents alike. Defaults to the instance `name` and is rotated when the chat is
* cleared (the `message:clear` observability event).
* work — chat turn, callable RPC call, or HTTP request — so `gen_ai` spans created within it are
* correlated, for chat and plain agents alike. Defaults to the instance `name` and is rotated
* when the chat is cleared (the `message:clear` observability event).
*
* It only hooks the `agents` package internals and uses Sentry's tracing primitives. On Cloudflare
* Workers, prefer `instrumentAgentWithSentry`, which additionally instruments the Durable Object
Expand All@@ -29,6 +30,7 @@ export function instrumentCloudflareAgent<T extends object>(agent: T): T {

instrumentAgentCallableRpc(internals);
instrumentChatAgentConversation(internals);
instrumentAgentRequestConversation(internals);

return agent;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
import { type AgentInternals, setAgentConversationId } from './types';

/**
* Correlates the AI spans of an HTTP-driven agent turn with a conversation id on the active scope.
*
* `onRequest` is the third unit of agent work, alongside chat turns and `@callable()` RPC: the
* `agents` router sends every non-WebSocket request to it, which is how REST endpoints and webhooks
* reach an agent.
*
* `agents` installs `onRequest` as an own property in the `Agent` constructor (as it does
* `onMessage`), and we instrument after construction, so wrapping the own property is what the
* router ends up calling.
*/
export function instrumentAgentRequestConversation(obj: AgentInternals): void {
const original = obj.onRequest;

if (typeof original !== 'function') {
return;
}

obj.onRequest = new Proxy(original, {
apply(target, thisArg: AgentInternals, args: unknown[]): unknown {
setAgentConversationId(thisArg);

return Reflect.apply(target, thisArg, args);
},
});
}
2 changes: 2 additions & 0 deletions packages/cloudflare/src/instrumentations/agents/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,8 @@ export interface AgentInternals {
* does not, so its presence discriminates a chat agent.
*/
onChatMessage?: (...args: unknown[]) => unknown;
/** HTTP request handler; the router sends every non-WebSocket request here. */
onRequest?: (...args: unknown[]) => unknown;
/** The user's Agent class (used by the SDK for the observability event `agent` field). */
_ParentClass?: { name?: string };
/** The Agent instance name, which in the Agents model identifies the conversation/thread. */
Expand Down
38 changes: 38 additions & 0 deletions packages/cloudflare/test/instrumentCloudflareAgent.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -157,5 +157,43 @@ describe('instrumentCloudflareAgent', () => {
expect(agent.seenConversationId).toBe('instance-1');
expect('onChatMessage' in agent).toBe(false);
});

it('sets the conversation id during an HTTP request', () => {
const agent = createFakeAgent({
onRequest(this: any) {
this.seenConversationId = getCurrentScope().getScopeData().conversationId;
return 'response';
},
});
instrumentCloudflareAgent(agent);

const result = agent.onRequest(new Request('https://example.com/agents/my-agent/instance-1'));

expect(result).toBe('response');
expect(agent.seenConversationId).toBe('instance-1');
});

it('prefers the rotated conversation id over the instance name on the HTTP path', () => {
const agent = createFakeAgent({
onRequest(this: any) {
this.seenConversationId = getCurrentScope().getScopeData().conversationId;
return 'response';
},
});
instrumentCloudflareAgent(agent);

agent._emit?.('message:clear');
agent.__sentryConversationId = 'rotated-id';
agent.onRequest(new Request('https://example.com/agents/my-agent/instance-1'));

expect(agent.seenConversationId).toBe('rotated-id');
});

it('does not throw when the agent has no onRequest handler', () => {
const agent = createFakeAgent();

expect(() => instrumentCloudflareAgent(agent)).not.toThrow();
expect('onRequest' in agent).toBe(false);
});
});
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,8 @@ function assertGenAiStreamingSpan(span: SerializedStreamedSpan): void {
expect(span.attributes['gen_ai.usage.input_tokens']?.value).toBe(15);
expect(span.attributes['gen_ai.usage.output_tokens']?.value).toBe(8);
expect(span.attributes['gen_ai.usage.total_tokens']?.value).toBe(23);
// Both agents are addressed as `.../test`, so the instance name is the conversation id.
expect(span.attributes['gen_ai.conversation.id']?.value).toBe('test');
}

test('captures Workers AI streaming output when driven via an Agent', async ({ request, baseURL }) => {
Expand Down
8 changes: 5 additions & 3 deletions packages/cloudflare/src/instrumentations/agents/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import { instrumentAgentCallableRpc } from './instrumentAgentCallableRpc';
import { instrumentAgentRequestConversation } from './instrumentAgentRequestConversation';
import { instrumentChatAgentConversation } from './instrumentChatAgentConversation';
import type { AgentInternals } from './types';

Expand All@@ -8,9 +9,9 @@ import type { AgentInternals } from './types';
*
* - **Callable RPC spans** — a span (op `rpc`) for each `@callable()` method invoked over WebSocket.
* - **Conversation correlation** — sets the conversation id on the scope for each unit of agent
* work — chat turn or callable RPC call— so `gen_ai` spans created within it are correlated, for
* chat and plain agents alike. Defaults to the instance `name` and is rotated when the chat is
* cleared (the `message:clear` observability event).
* work — chat turn, callable RPC call, or HTTP request — so `gen_ai` spans created within it are
* correlated, for chat and plain agents alike. Defaults to the instance `name` and is rotated
* when the chat is cleared (the `message:clear` observability event).
*
* It only hooks the `agents` package internals and uses Sentry's tracing primitives. On Cloudflare
* Workers, prefer `instrumentAgentWithSentry`, which additionally instruments the Durable Object
Expand All@@ -29,6 +30,7 @@ export function instrumentCloudflareAgent<T extends object>(agent: T): T {

instrumentAgentCallableRpc(internals);
instrumentChatAgentConversation(internals);
instrumentAgentRequestConversation(internals);

return agent;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
import { type AgentInternals, setAgentConversationId } from './types';

/**
* Correlates the AI spans of an HTTP-driven agent turn with a conversation id on the active scope.
*
* `onRequest` is the third unit of agent work, alongside chat turns and `@callable()` RPC: the
* `agents` router sends every non-WebSocket request to it, which is how REST endpoints and webhooks
* reach an agent.
*
* `agents` installs `onRequest` as an own property in the `Agent` constructor (as it does
* `onMessage`), and we instrument after construction, so wrapping the own property is what the
* router ends up calling.
*/
export function instrumentAgentRequestConversation(obj: AgentInternals): void {
const original = obj.onRequest;

if (typeof original !== 'function') {
return;
}

obj.onRequest = new Proxy(original, {
apply(target, thisArg: AgentInternals, args: unknown[]): unknown {
setAgentConversationId(thisArg);

return Reflect.apply(target, thisArg, args);
},
});
}
2 changes: 2 additions & 0 deletions packages/cloudflare/src/instrumentations/agents/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,8 @@ export interface AgentInternals {
* does not, so its presence discriminates a chat agent.
*/
onChatMessage?: (...args: unknown[]) => unknown;
/** HTTP request handler; the router sends every non-WebSocket request here. */
onRequest?: (...args: unknown[]) => unknown;
/** The user's Agent class (used by the SDK for the observability event `agent` field). */
_ParentClass?: { name?: string };
/** The Agent instance name, which in the Agents model identifies the conversation/thread. */
Expand Down
38 changes: 38 additions & 0 deletions packages/cloudflare/test/instrumentCloudflareAgent.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -157,5 +157,43 @@ describe('instrumentCloudflareAgent', () => {
expect(agent.seenConversationId).toBe('instance-1');
expect('onChatMessage' in agent).toBe(false);
});

it('sets the conversation id during an HTTP request', () => {
const agent = createFakeAgent({
onRequest(this: any) {
this.seenConversationId = getCurrentScope().getScopeData().conversationId;
return 'response';
},
});
instrumentCloudflareAgent(agent);

const result = agent.onRequest(new Request('https://example.com/agents/my-agent/instance-1'));

expect(result).toBe('response');
expect(agent.seenConversationId).toBe('instance-1');
});

it('prefers the rotated conversation id over the instance name on the HTTP path', () => {
const agent = createFakeAgent({
onRequest(this: any) {
this.seenConversationId = getCurrentScope().getScopeData().conversationId;
return 'response';
},
});
instrumentCloudflareAgent(agent);

agent._emit?.('message:clear');
agent.__sentryConversationId = 'rotated-id';
agent.onRequest(new Request('https://example.com/agents/my-agent/instance-1'));

expect(agent.seenConversationId).toBe('rotated-id');
});

it('does not throw when the agent has no onRequest handler', () => {
const agent = createFakeAgent();

expect(() => instrumentCloudflareAgent(agent)).not.toThrow();
expect('onRequest' in agent).toBe(false);
});
});
});
Loading