Uh oh!
There was an error while loading. Please reload this page.
feat(nuxt)!: Remove deprecated sourceMapsUploadOptions module option - #22875
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ntics Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
sourceMapsUploadOptions module optionsourceMapsUploadOptions module optionnicohrubec
marked this pull request as ready for review
July 31, 2026 07:39
nicohrubec
requested review from
chargome and s1gr1d
and removed request for
a teamJuly 31, 2026 07:39
s1gr1d
approved these changes
Jul 31, 2026
Comment on lines
+165
to
+169
| /** | ||
| * Users can set `filesToDeleteAfterUpload` themselves. If they don't, we fall back to deleting the | ||
| * client/server source maps — but only the ones Sentry generated itself (i.e. when the user didn't | ||
| * configure source maps at all). If the user explicitly set source maps, we leave their files alone. | ||
| */ |
Member
There was a problem hiding this comment.
Nuxt has no undefined default values for source maps so this "deleting by default" cannot happen in the default case. Only if users would set them to undefined.
Maybe that's worth pointing out here. Also a link to the docs: https://nuxt.com/docs/4.x/api/nuxt-config#sourcemap
chargome
approved these changes
Jul 31, 2026
chargome
left a comment
Member
There was a problem hiding this comment.
LGTM, might need a migration entry for nuxt
| ? true | ||
| : // eslint-disable-next-line typescript/no-deprecated | ||
| (sourceMapsUploadOptions.enabled ?? true); | ||
| const sourceMapsEnabled = moduleOptions.sourcemaps?.disable !== true; |
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the deprecated
sourceMapsUploadOptionsmodule option from@sentry/nuxtin favor of the existing root-level options.Fixes#22249