Uh oh!
There was an error while loading. Please reload this page.
fix(replay): Convert performance entries against the origin they were observed with - #23068
Draft
Lms24 wants to merge 1 commit into
Draft
Conversation
… observed with Replay buffers raw `PerformanceEntry` objects and only converts them to wall clock time on flush, which for a long-running session can happen minutes later and across a clock drift correction. Converting them against the origin in effect at flush time retroactively shifts every buffered entry by the drift, including the ones that were timed correctly. Stamps the current time origin onto each entry as it is observed and converts against that stamp. The stamps live in a `WeakMap` so the buffer keeps holding bare entries and its identity-based dedup is unaffected. Web vitals already convert eagerly in their instrumentation handler, so they keep using the current origin. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
size-limit report 📦
|
Contributor
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you apply the label |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.