Uh oh!
There was an error while loading. Please reload this page.
feat(solid,solidstart): Support @solidjs/router v1 - #23162
Merged
Conversation
Widen the `@solidjs/router` peer dependency range to `>=0.13.4 <2.0.0-0` so v0.16 and v1.0 are supported. `@sentry/solid` previously capped at v0.15, which broke `@sentry/solidstart` with SolidStart 2 (its router peer is `>=0.16.0 <2.0.0-0`) even though solidstart's own range already allowed v1. Bump the dev dependency to v1 in both packages so the unit tests run against it. Closes: #23160 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
size-limit report 📦
|
andreiborza
marked this pull request as ready for review
August 7, 2026 16:45
andreiborza
requested review from
logaretm, mydea, nicohrubec and s1gr1d
and removed request for
a team and mydeaAugust 7, 2026 16:45
nicohrubec
approved these changes
Aug 7, 2026
| }, | ||
| "peerDependencies": { | ||
| "@solidjs/router": "^0.13.4 || ^0.14.0 || ^0.15.0", | ||
| "@solidjs/router": ">=0.13.4 <2.0.0-0", |
Contributor
There was a problem hiding this comment.
Bug: The widened peer dependency range for @solidjs/router is not tested against its minimum supported version, risking runtime crashes for users on older router versions.
Severity: HIGH
Suggested Fix
Add a testing step to the CI pipeline that installs and runs the test suite against the minimum supported version of the @solidjs/router dependency (0.13.4). This will validate that the hooks used by the SDK are compatible across the entire declared peer dependency range. Alternatively, narrow the peer dependency range to versions known to be compatible.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: packages/solid/package.json#L62
Potential issue: The peer dependency for `@solidjs/router` was broadened to `>=0.13.4
<2.0.0-0`, but the test suite only validates compatibility against version `1.0.0`. The
SDK integration uses the `useBeforeLeave`, `useCurrentMatches`, and `useLocation` hooks
without any error handling or version checks. If there were any breaking API changes in
`@solidjs/router` between version `0.13.4` and the latest tested version, users with
older, valid versions of the router would experience runtime crashes when the Sentry
integration initializes.
Also affects:
packages/solidstart/package.json:74~74
Did we get this right? 👍 / 👎 to inform future reviews.
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Aug 7, 2026
andreiborza added a commit
that referenced
this pull request
Aug 7, 2026
) ## What Bump `@solidjs/router` from `^0.15.0` to `^1.0.0` in the SolidStart 1 e2e test apps. - `solidstart`, `solidstart-spa`, `solidstart-top-level-import`, `solidstart-dynamic-import` ## Why #23162 widened the `@solidjs/router` peer range to `>=0.13.4 <2.0.0-0`, but only the `solidstart-2` app ran against v1, so the SolidStart 1 + router v1 combination the range now advertises had no coverage. The equivalent bump on v10 (#23163) passes all four suites locally. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
andreiborza added a commit
that referenced
this pull request
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Widen the
@solidjs/routerpeer dependency range in@sentry/solidand@sentry/solidstartto>=0.13.4 <2.0.0-0.@solidjs/routerv0.16 and v1.0.2.0.0-next.*) via the-0upper bound.Closes: #23160
Why
@sentry/solidcapped at v0.15, so it conflicted with@sentry/solidstarton SolidStart 2, which requires router>=0.16.0 <2.0.0-0. Router v1.0 is a version realignment with no code changes from the 0.16 line, and none of the APIs the SDK uses changed.