Uh oh!
There was an error while loading. Please reload this page.
ref(astro)!: Remove deprecated release/debug conflict workaround from BuildTimeOptionsBase - #23270
Merged
RulaKhaled merged 3 commits intoAug 13, 2026
Conversation
…BuildTimeOptionsBase
…d-releasedebug-from Resolved conflict in docs/migration/v11-end-state.md by keeping both the new @sentry/astro section (this branch) and the new @sentry/react-router section (develop). Co-Authored-By: Fable 5 <cursoragent@cursor.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
size-limit report 📦
|
RulaKhaled
commented
Aug 11, 2026
CollaboratorAuthor
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 6fab126. Configure here.
RulaKhaled
marked this pull request as ready for review
August 11, 2026 11:33
RulaKhaled
requested review from
chargome, msonnb, nicohrubec and s1gr1d
and removed request for
a teamAugust 11, 2026 11:33
chargome
approved these changes
Aug 13, 2026
chargome
left a comment
Member
There was a problem hiding this comment.
README of the sdk needs updating otherwise LGTM!
Uh oh!
There was an error while loading. Please reload this page.
RulaKhaled
deleted the
rolaabuhasna/js-3028-astro-remove-deprecated-releasedebug-from
branch
August 13, 2026 12:15
RulaKhaled added a commit
that referenced
this pull request
Aug 17, 2026
…23430) Updates the `@sentry/astro` README so the getting-started examples match the v11 split from #23270. `sentry()` is build-time only (`org`, `project`, `authToken`). Runtime options like `dsn` live in `sentry.client.config.ts` / `sentry.server.config.ts`, which are optional: without them the SDK still initializes and reads `PUBLIC_SENTRY_DSN`. This was the remaining follow-up from the review on #23270.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
DeprecatedRuntimeOptionscatch-all type in@sentry/astrothat was blockingreleaseanddebugfrom being proper build-time options onBuildTimeOptionsBase.The other deprecated runtime options (
dsn,environment,sampleRate,tracesSampleRate,replaysSessionSampleRate,replaysOnErrorSampleRate) have no build-time equivalent, so they can no longer be set viasentryAstro()at all. The generated snippet now falls back to fixed defaults for them. This was already the deprecated, discouraged path; anyone needing non-default values already needs (and can continue using) a dedicatedsentry.client.config.ts/sentry.server.config.tsfile with a directSentry.init()call, which is unaffected by this change.Closes#22248