feat(node): Add build-time opt-out for runtime channel injection by mydea · Pull Request #23475 · getsentry/sentry-javascript

mydea · 2026-08-21T09:39:18Z

Stacked on #23473.

Adds a build-time opt-out for the Node SDK's runtime diagnostics-channel injection, complementing the runtime enableRuntimeChannelInjection option from the base PR.

New __SENTRY_CHANNEL_INJECTION__ treeshaking flag, mirroring __SENTRY_TRACING__: when a bundler text-replaces it with false, the registerDiagnosticsChannelInjection() / detectOrchestrionSetup() block in init is dropped, and its transitive orchestrion-register code tree-shakes away.
Exposed through the bundler plugins' bundleSizeOptimizations.excludeChannelInjection, which maps to __SENTRY_CHANNEL_INJECTION__ = false via the same mechanism as excludeTracing.
The gate now reads both the build flag and the runtime option: (typeof __SENTRY_CHANNEL_INJECTION__ === 'undefined' || __SENTRY_CHANNEL_INJECTION__) && options.enableRuntimeChannelInjection !== false.

🤖 Generated with Claude Code

github-actions · 2026-08-21T09:47:03Z

size-limit report 📦

Path	Size	% Change	Change
@sentry/browser	28.57 kB	-	-
@sentry/browser - with treeshaking flags	26.92 kB	-	-
@sentry/browser - with treeshaking flags tracing without tracing	26.82 kB	-	-
@sentry/browser (incl. Tracing)	48.59 kB	-	-
@sentry/browser (incl. Tracing + Span Streaming)	48.6 kB	-	-
@sentry/browser (incl. Tracing, Profiling)	51.51 kB	-	-
@sentry/browser (incl. Tracing, Replay)	88.04 kB	-	-
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags	77.45 kB	-	-
@sentry/browser (incl. Tracing, Replay with Canvas)	92.75 kB	-	-
@sentry/browser (incl. Tracing, Replay, Feedback)	105.45 kB	-	-
@sentry/browser (incl. Feedback)	45.81 kB	-	-
@sentry/browser (incl. sendFeedback)	33.36 kB	-	-
@sentry/browser (incl. FeedbackAsync)	38.46 kB	-	-
@sentry/browser (incl. Metrics)	29.51 kB	-	-
@sentry/browser (incl. Logs)	29.8 kB	-	-
@sentry/browser (incl. Metrics & Logs)	30.43 kB	-	-
@sentry/react	30.31 kB	-	-
@sentry/react (incl. Tracing)	50.8 kB	-	-
@sentry/vue	35.69 kB	-	-
@sentry/vue (incl. Tracing)	50.82 kB	-	-
@sentry/svelte	28.59 kB	-	-
CDN Bundle	30.36 kB	-	-
CDN Bundle (incl. Tracing)	49.06 kB	-	-
CDN Bundle (incl. Logs, Metrics)	32.56 kB	-	-
CDN Bundle (incl. Tracing, Logs, Metrics)	50.94 kB	-	-
CDN Bundle (incl. Replay, Logs, Metrics)	72.98 kB	-	-
CDN Bundle (incl. Tracing, Replay)	86.56 kB	-	-
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)	88.44 kB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback)	92.34 kB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)	94.27 kB	-	-
CDN Bundle - uncompressed	89.97 kB	-	-
CDN Bundle (incl. Tracing) - uncompressed	146.74 kB	-	-
CDN Bundle (incl. Logs, Metrics) - uncompressed	96.26 kB	-	-
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed	152.43 kB	-	-
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed	225.36 kB	-	-
CDN Bundle (incl. Tracing, Replay) - uncompressed	266.17 kB	-	-
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed	271.85 kB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed	279.87 kB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed	285.53 kB	-	-
@sentry/nextjs (client)	53.34 kB	-	-
@sentry/sveltekit (client)	49.02 kB	-	-
@sentry/core/server	65.21 kB	-	-
@sentry/core/browser	52.34 kB	-	-
@sentry/node	121.73 kB	+0.04%	+37 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection)	85.18 kB	-	-
@sentry/node - without tracing	87.58 kB	+0.06%	+51 B 🔺
@sentry/aws-serverless	95.98 kB	+0.04%	+37 B 🔺
@sentry/cloudflare (withSentry) - minified	199.48 kB	-	-
@sentry/cloudflare (withSentry)	495.44 kB	-	-
@sentry/node - without channel injection	101.4 kB	added	added

View base workflow run

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 8ff1633. Configure here.}

isaacs

Two small fixes that I think are worth doing before landing, but this looks good otherwise.

isaacs · 2026-08-25T18:07:30Z

+ *
+ * @default false
+ */
+ excludeChannelInjection?: boolean;


Should this also be added to the BundleSizeOptimizationsOptions in packages/core/src/build-time-plugins/buildTimeOptionsBase.ts, so that it can be picked up on the bundleSizeOptimizations field of BuildTimeOptionsBase? Eg, that's what packages/nuxt/src/common/types.ts pulls its options from.

ah, you are right. this is a bit weird and maybe we can combine these together at some point...

Introduce a `__SENTRY_CHANNEL_INJECTION__` treeshaking flag (mirroring `__SENTRY_TRACING__`) that removes the runtime diagnostics-channel injection when text-replaced with `false`, and expose it through the bundler plugins' `bundleSizeOptimizations.excludeChannelInjection`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Co-authored-by: isaacs <i@izs.me>

isaacs

The blocking concern is addressed, LGTM.

cursorBot reviewed Aug 21, 2026
View reviewed changes

Comment threadpackages/node/test/sdk/diagnosticsChannelInjection.test.ts

mydea force-pushed the fn/channel-injection-build-flag branch from 68993db to c6d9d7fCompare August 21, 2026 10:04

mydea mentioned this pull request Aug 21, 2026
feat(node): Auto-exclude runtime channel injection when build-time instrumentation is on #23479
Closed

mydea force-pushed the fn/channel-injection-build-flag branch from c6d9d7f to 1d27eb4Compare August 21, 2026 11:02

cursorBot reviewed Aug 21, 2026
View reviewed changes

Comment threadpackages/node/src/sdk/index.ts Outdated

mydea force-pushed the fn/channel-injection-build-flag branch from 1d27eb4 to e670b7cCompare August 24, 2026 07:51

mydea force-pushed the fn/channel-injection-build-flag branch from e670b7c to 40ae0c4Compare August 24, 2026 09:04

mydea marked this pull request as ready for review August 24, 2026 09:24

mydea requested a review from a team as a code owner August 24, 2026 09:24

mydea requested review from msonnb and stephanie-anderson and removed request for a teamAugust 24, 2026 09:24

mydea force-pushed the fn/channel-injection-build-flag branch from 40ae0c4 to 8ff1633Compare August 24, 2026 11:06

cursorBot reviewed Aug 24, 2026
View reviewed changes

Comment threadpackages/bundler-plugins/src/core/types.ts

mydea force-pushed the fn/channel-injection-build-flag branch from 8ff1633 to 5a399f9Compare August 24, 2026 11:24

mydea requested review from Lms24 and removed request for stephanie-anderson August 24, 2026 12:52

mydea requested a review from a team as a code owner August 25, 2026 08:12

mydea requested review from JPeer264 and isaacs and removed request for a teamAugust 25, 2026 08:12

Base automatically changed from fn/default-framework-integrations to developAugust 25, 2026 12:00

mydea force-pushed the fn/channel-injection-build-flag branch from 5a399f9 to dac4c3aCompare August 25, 2026 13:31

JPeer264 approved these changes Aug 25, 2026
View reviewed changes

isaacs requested changes Aug 25, 2026
View reviewed changes

sentryBot reviewed Aug 26, 2026
View reviewed changes

Comment threadpackages/node/src/sdk/index.ts Outdated

mydeaand others added 4 commits August 26, 2026 09:35

fixes and size limit
70601d5

Update packages/node/src/sdk/index.ts
9e5a62d
Co-authored-by: isaacs <i@izs.me>

fix oops
00566b9

mydea force-pushed the fn/channel-injection-build-flag branch from f1c25ae to 00566b9Compare August 26, 2026 07:39

isaacs self-requested a review August 26, 2026 14:48

isaacs approved these changes Aug 26, 2026
View reviewed changes

mydea merged commit 9c94002 into developAug 27, 2026
273 checks passed

mydea deleted the fn/channel-injection-build-flag branch August 27, 2026 06:27

Navigation Menu

Uh oh!

Uh oh!

feat(node): Add build-time opt-out for runtime channel injection - #23475

feat(node): Add build-time opt-out for runtime channel injection#23475
mydea merged 4 commits into
developfrom
fn/channel-injection-build-flag

mydea commented Aug 21, 2026•
edited
Loading

Uh oh!

Uh oh!

github-actionsBot commented Aug 21, 2026•
edited
Loading

Uh oh!

Uh oh!

cursorBot left a comment

Uh oh!

Uh oh!

isaacs left a comment

Uh oh!

isaacsAug 25, 2026

Uh oh!

mydeaAug 26, 2026

Uh oh!

Uh oh!

Uh oh!

isaacs left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

mydea commented Aug 21, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

github-actionsBot commented Aug 21, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

Uh oh!

cursorBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

isaacs left a comment

Choose a reason for hiding this comment

Uh oh!

isaacsAug 25, 2026

Choose a reason for hiding this comment

Uh oh!

mydeaAug 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

isaacs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mydea commented Aug 21, 2026•
edited
Loading

github-actionsBot commented Aug 21, 2026•
edited
Loading