Uh oh!
There was an error while loading. Please reload this page.
feat(server-utils): Emit low cardinality mongodb span names - #23603
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 866f29c. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
Contributor
size-limit report 📦
|
Mongodb reports no SQL statement, so there is no query summary to name its spans
after. With span streaming they use the next conventions template that can be
filled instead: the operation paired with `{db.collection.name}` (or
`{db.namespace}`), falling back to that target alone when the driver reports no
operation, and then to `{db.system.name}`.
This keeps the scrubbed query document out of the span name. It stays on
`db.query.text`.
`traceLifecycle: 'static'` keeps the existing names.
Refs #23523
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>Lms24force-pushed
the
lms/feat-server-utils-low-card-db-span-names4
branch
from
August 28, 2026 14:38
866f29c to
0ea02c1CompareLms24
marked this pull request as ready for review
August 28, 2026 14:42
Lms24
requested review from
andreiborza and isaacs
and removed request for
a teamAugust 28, 2026 14:42
andreiborza
approved these changes
Aug 28, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mongodb has no SQL statement to summarize. With span streaming enabled:
{db.operation.name} {db.collection.name}, e.g.find usersendSessionsbecomes$cmd), then todb.system.namedb.query.texttraceLifecycle: 'static'keeps the existing namesAdded streaming node-integration tests for all mongodb test suites
Redis split out into #23741.
Refs #23523