feat(core): Always flush streamed span traces after segment end by default - #23714

Merged
mydea merged 9 commits into
developfrom
feat/share-span-streaming-integration
Aug 31, 2026
Merged

feat(core): Always flush streamed span traces after segment end by default#23714
mydea merged 9 commits into
developfrom
feat/share-span-streaming-integration

Conversation

@mydea

@mydeamydea commented Aug 28, 2026

Copy link
Copy Markdown
Member

The browser (browserSpanStreaming.ts) and server (spanStreaming.ts) span streaming integrations were near-identical: the afterSpanEnd buffering was byte-for-byte the same, and they only differed in the eager-flush trigger. This collapses them into a single core integration, and makes flushing a trace shortly after its segment span ends the default for all runtimes, browser and server alike.

Both install sites now call spanStreamingIntegration() with no arguments: browserSpanApi._INTERNAL_ensureBrowserSpanStreaming and ServerRuntimeClient share one behavior. A trace is flushed:

  • eagerly on flushTraceSpans (the Cloudflare drain),
  • 500ms after its segment span ends, and
  • otherwise on the SpanBuffer's own timeout/size thresholds.

Why default segment-end flushing on for the server too

Previously the server relied solely on the buffer thresholds and only the browser flushed on segment end, to avoid the server emitting more, smaller envelopes and to keep the browser's 500ms timer from holding the Node event loop open. The event-loop concern is already handled by safeUnref on the timer (a no-op in the browser), so there's no longer a reason to gate the segment-end path by runtime — flushing traces timely once their segment ends is the behavior we want everywhere.

The flushOnSegmentEnd option is retained (now defaulting to true) so a runtime can still opt out and fall back to threshold-only flushing.

Why keep it in core rather than moving to browser-utils/server-utils

The integrations are consumed internally by core — ServerRuntimeClient auto-adds it, and browserSpanApi/idleSpan auto-install it (a deliberate tree-shaking indirection). Since browser-utils and server-utils both depend on @sentry/core, core cannot import back from them without a circular dependency. Collapsing in-core sidesteps that entirely.

Export change

The integration now lives in shared-exports as a single shared symbol (star-exported by all entries) instead of being duplicated in browser-exports and server-exports. Previously the two entries resolved to different symbols, making the name an ambiguous star export that index.ts disambiguated with an explicit re-export. Now that both resolve to the same symbol, that explicit line collided with the star exports (leaving the root namespace undefined) and is removed. The startSpan/startInactiveSpan/startSpanManual disambiguation stays, as those remain genuinely distinct browser/server variants.

Comment threadpackages/core/src/integrations/spanStreaming.ts
Comment threadpackages/core/src/integrations/spanStreaming.ts Outdated
@github-actions

github-actionsBot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser28.56 kB--
@sentry/browser - with treeshaking flags26.92 kB--
@sentry/browser - with treeshaking flags tracing without tracing26.82 kB--
@sentry/browser (incl. Tracing)48.72 kB+0.09%+40 B 🔺
@sentry/browser (incl. Tracing + Span Streaming)48.74 kB+0.08%+36 B 🔺
@sentry/browser (incl. Tracing, Profiling)51.66 kB+0.08%+37 B 🔺
@sentry/browser (incl. Tracing, Replay)88.19 kB+0.05%+38 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags77.6 kB+0.06%+39 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)92.88 kB+0.04%+35 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)105.83 kB+0.04%+39 B 🔺
@sentry/browser (incl. Feedback)46.05 kB--
@sentry/browser (incl. sendFeedback)33.62 kB--
@sentry/browser (incl. FeedbackAsync)38.73 kB--
@sentry/browser (incl. Metrics)29.51 kB--
@sentry/browser (incl. Logs)29.8 kB--
@sentry/browser (incl. Metrics & Logs)30.43 kB--
@sentry/react30.3 kB--
@sentry/react (incl. Tracing)50.93 kB+0.07%+32 B 🔺
@sentry/vue35.73 kB+0.11%+39 B 🔺
@sentry/vue (incl. Tracing)50.97 kB+0.08%+38 B 🔺
@sentry/svelte28.59 kB--
CDN Bundle30.35 kB--
CDN Bundle (incl. Tracing)49.32 kB+0.06%+25 B 🔺
CDN Bundle (incl. Logs, Metrics)32.58 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)51.21 kB+0.06%+26 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)73.17 kB--
CDN Bundle (incl. Tracing, Replay)86.82 kB+0.04%+27 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)88.69 kB+0.03%+26 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)92.74 kB+0.03%+27 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)94.61 kB+0.03%+25 B 🔺
CDN Bundle - uncompressed89.95 kB--
CDN Bundle (incl. Tracing) - uncompressed147.05 kB+0.07%+89 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed96.24 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed152.74 kB+0.06%+89 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed225.41 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed266.55 kB+0.04%+89 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed272.22 kB+0.04%+89 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed280.25 kB+0.04%+89 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed285.92 kB+0.04%+89 B 🔺
@sentry/nextjs (client)53.5 kB+0.06%+28 B 🔺
@sentry/sveltekit (client)49.16 kB+0.06%+27 B 🔺
@sentry/core/server65.47 kB+0.04%+22 B 🔺
@sentry/core/browser51.87 kB+0.06%+29 B 🔺
@sentry/node123.25 kB+0.05%+52 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection)85.23 kB--
@sentry/node - without tracing87.75 kB+0.04%+27 B 🔺
@sentry/node - without channel injection102.92 kB+0.06%+59 B 🔺
@sentry/aws-serverless95.95 kB+0.08%+68 B 🔺
@sentry/cloudflare (withSentry) - minified200.65 kB+0.08%+143 B 🔺
@sentry/cloudflare (withSentry)499.13 kB+0.08%+367 B 🔺

View base workflow run

@mydea
mydea requested a review from Lms24August 28, 2026 07:42
Comment threadpackages/browser/src/integrations/browserSpanStreaming.ts Outdated
@mydea
mydea marked this pull request as ready for review August 28, 2026 08:42
@mydea
mydea requested a review from a team as a code ownerAugust 28, 2026 08:42
@mydea
mydea requested review from msonnb and removed request for a teamAugust 28, 2026 08:42
Comment threadpackages/browser/src/integrations/browserSpanStreaming.ts Outdated

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can do something better here which is what we decided on last week but I didn't have time to implement yet: Let's just always flush at segment end (with the delay), regardless of environment.

In Python, we already made that change after noticing that the 5s flushing interval accumulates a lot of memory in high-throughput environments. Since we make one request per trace anyway, the number of requests shouldn't be drastically higher.

That is, as long as we can expect that traces are generally well-formed (i.e. child spans ending before their segment span). For malformed traces, with long-running child spans we would increase the request count. I think this is a fine tradeoff IMHO.

If you have (or anyone else has) concerns about this, I'd prefer keeping the two integrations separate because the merge increases bundle size for the browser version. Which was the reason why I opted against combining them initially.

@mydea

Copy link
Copy Markdown
MemberAuthor

I think we can do something better here which is what we decided on last week but I didn't have time to implement yet: Let's just always flush at segment end (with the delay), regardless of environment.

In Python, we already made that change after noticing that the 5s flushing interval accumulates a lot of memory in high-throughput environments. Since we make one request per trace anyway, the number of requests shouldn't be drastically higher.

That is, as long as we can expect that traces are generally well-formed (i.e. child spans ending before their segment span). For malformed traces, with long-running child spans we would increase the request count. I think this is a fine tradeoff IMHO.

If you have (or anyone else has) concerns about this, I'd prefer keeping the two integrations separate because the merge increases bundle size for the browser version. Which was the reason why I opted against combining them initially.

sounds good to me, so I'll just change this so that the default for flushing is true I'd say, so you can still opt out?

@mydeamydea changed the title ref(core): Merge browser and server spanStreamingIntegration into one shared integrationfeat(core): Always flush streamed span traces after segment end by defaultAug 28, 2026
@mydea
mydeaforce-pushed the feat/share-span-streaming-integration branch from ea19f07 to 023fef5CompareAugust 28, 2026 09:45
@mydea
mydea requested a review from a team as a code ownerAugust 28, 2026 09:45
@mydea
mydea requested review from chargome and s1gr1d and removed request for a teamAugust 28, 2026 09:45
Comment threadpackages/core/src/integrations/spanStreaming.ts
Comment threadpackages/core/test/integrations/spanStreaming.test.ts
Comment threadpackages/core/src/integrations/spanStreaming.ts
@mydea
mydeaforce-pushed the feat/share-span-streaming-integration branch from 023fef5 to 5f6ffb5CompareAugust 28, 2026 09:54

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reworking this!

Small positive side-effect for our tests: Span streaming tests should now run faster, given we flush way more quickly.

Comment threadpackages/core/src/integrations/spanStreaming.ts Outdated
Comment threadpackages/core/src/integrations/spanStreaming.ts Outdated

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 5f6ffb5. Configure here.


export declare const linkedErrorsIntegration: typeof clientSdk.linkedErrorsIntegration;
export declare const contextLinesIntegration: typeof clientSdk.contextLinesIntegration;
export declare const spanStreamingIntegration: typeof clientSdk.spanStreamingIntegration;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Types drop public integration export

Medium Severity

Removing the explicit spanStreamingIntegration re-export from framework index.types.ts files drops it from the public type surface. TypeScript export * from both client and server omits colliding names, so consumers of packages such as @sentry/astro and @sentry/nextjs can no longer import it. This is flagged because the review rules treat removal of a publicly exported function without a deprecation notice as a breaking change. The same explicit re-export is still required for other shared core symbols such as withStaticSpan.

Additional Locations (2)
Fix in CursorFix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

Reviewed by Cursor Bugbot for commit 5f6ffb5. Configure here.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine

mydeaand others added 7 commits August 31, 2026 09:45
… shared integration
The browser and server span streaming integrations only differed in their
eager-flush trigger, so collapse them into a single core integration
parameterized by a `flushOnSegmentEnd` option. The browser install site
(`browserSpanApi`) passes `{ flushOnSegmentEnd: true }`; the server side
(`ServerRuntimeClient`) keeps the same call and behavior.
The integration is now exported from `shared-exports` (a single shared symbol
across all entries) instead of being duplicated in `browser-exports` and
`server-exports`. Because both entries previously resolved to *different*
symbols, the name was an ambiguous star export that `index.ts` disambiguated
explicitly; now that it resolves to the same symbol, that explicit re-export
collided with the star exports and is removed.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The `flushOnSegmentEnd` 500ms `setTimeout` now lives in shared core code and
`flushOnSegmentEnd` is a public option, so enabling it on a Node runtime could
keep a process alive until the timer fires. Wrap it in `safeUnref` (as the
`SpanBuffer` already does for its own flush timer); it's a no-op in the browser,
where this is the default path.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mydeaand others added 2 commits August 31, 2026 09:45
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
@mydea
mydeaforce-pushed the feat/share-span-streaming-integration branch from 52c5e47 to 0265ccdCompareAugust 31, 2026 07:45
@mydea
mydea requested a review from a team as a code ownerAugust 31, 2026 07:45
@mydea
mydea requested review from JPeer264 and isaacs and removed request for a teamAugust 31, 2026 07:45
@mydea
mydea merged commit b42643f into developAug 31, 2026
282 of 283 checks passed
@mydea
mydea deleted the feat/share-span-streaming-integration branch August 31, 2026 08:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@Lms24
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

feat(core): Always flush streamed span traces after segment end by default - #23714

Merged
mydea merged 9 commits into
developfrom
feat/share-span-streaming-integration
Aug 31, 2026
Merged

feat(core): Always flush streamed span traces after segment end by default#23714
mydea merged 9 commits into
developfrom
feat/share-span-streaming-integration

Conversation

@mydea

@mydeamydea commented Aug 28, 2026

Copy link
Copy Markdown
Member

The browser (browserSpanStreaming.ts) and server (spanStreaming.ts) span streaming integrations were near-identical: the afterSpanEnd buffering was byte-for-byte the same, and they only differed in the eager-flush trigger. This collapses them into a single core integration, and makes flushing a trace shortly after its segment span ends the default for all runtimes, browser and server alike.

Both install sites now call spanStreamingIntegration() with no arguments: browserSpanApi._INTERNAL_ensureBrowserSpanStreaming and ServerRuntimeClient share one behavior. A trace is flushed:

  • eagerly on flushTraceSpans (the Cloudflare drain),
  • 500ms after its segment span ends, and
  • otherwise on the SpanBuffer's own timeout/size thresholds.

Why default segment-end flushing on for the server too

Previously the server relied solely on the buffer thresholds and only the browser flushed on segment end, to avoid the server emitting more, smaller envelopes and to keep the browser's 500ms timer from holding the Node event loop open. The event-loop concern is already handled by safeUnref on the timer (a no-op in the browser), so there's no longer a reason to gate the segment-end path by runtime — flushing traces timely once their segment ends is the behavior we want everywhere.

The flushOnSegmentEnd option is retained (now defaulting to true) so a runtime can still opt out and fall back to threshold-only flushing.

Why keep it in core rather than moving to browser-utils/server-utils

The integrations are consumed internally by core — ServerRuntimeClient auto-adds it, and browserSpanApi/idleSpan auto-install it (a deliberate tree-shaking indirection). Since browser-utils and server-utils both depend on @sentry/core, core cannot import back from them without a circular dependency. Collapsing in-core sidesteps that entirely.

Export change

The integration now lives in shared-exports as a single shared symbol (star-exported by all entries) instead of being duplicated in browser-exports and server-exports. Previously the two entries resolved to different symbols, making the name an ambiguous star export that index.ts disambiguated with an explicit re-export. Now that both resolve to the same symbol, that explicit line collided with the star exports (leaving the root namespace undefined) and is removed. The startSpan/startInactiveSpan/startSpanManual disambiguation stays, as those remain genuinely distinct browser/server variants.

Comment threadpackages/core/src/integrations/spanStreaming.ts
Comment threadpackages/core/src/integrations/spanStreaming.ts Outdated
@github-actions

github-actionsBot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser28.56 kB--
@sentry/browser - with treeshaking flags26.92 kB--
@sentry/browser - with treeshaking flags tracing without tracing26.82 kB--
@sentry/browser (incl. Tracing)48.72 kB+0.09%+40 B 🔺
@sentry/browser (incl. Tracing + Span Streaming)48.74 kB+0.08%+36 B 🔺
@sentry/browser (incl. Tracing, Profiling)51.66 kB+0.08%+37 B 🔺
@sentry/browser (incl. Tracing, Replay)88.19 kB+0.05%+38 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags77.6 kB+0.06%+39 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)92.88 kB+0.04%+35 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)105.83 kB+0.04%+39 B 🔺
@sentry/browser (incl. Feedback)46.05 kB--
@sentry/browser (incl. sendFeedback)33.62 kB--
@sentry/browser (incl. FeedbackAsync)38.73 kB--
@sentry/browser (incl. Metrics)29.51 kB--
@sentry/browser (incl. Logs)29.8 kB--
@sentry/browser (incl. Metrics & Logs)30.43 kB--
@sentry/react30.3 kB--
@sentry/react (incl. Tracing)50.93 kB+0.07%+32 B 🔺
@sentry/vue35.73 kB+0.11%+39 B 🔺
@sentry/vue (incl. Tracing)50.97 kB+0.08%+38 B 🔺
@sentry/svelte28.59 kB--
CDN Bundle30.35 kB--
CDN Bundle (incl. Tracing)49.32 kB+0.06%+25 B 🔺
CDN Bundle (incl. Logs, Metrics)32.58 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)51.21 kB+0.06%+26 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)73.17 kB--
CDN Bundle (incl. Tracing, Replay)86.82 kB+0.04%+27 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)88.69 kB+0.03%+26 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)92.74 kB+0.03%+27 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)94.61 kB+0.03%+25 B 🔺
CDN Bundle - uncompressed89.95 kB--
CDN Bundle (incl. Tracing) - uncompressed147.05 kB+0.07%+89 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed96.24 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed152.74 kB+0.06%+89 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed225.41 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed266.55 kB+0.04%+89 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed272.22 kB+0.04%+89 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed280.25 kB+0.04%+89 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed285.92 kB+0.04%+89 B 🔺
@sentry/nextjs (client)53.5 kB+0.06%+28 B 🔺
@sentry/sveltekit (client)49.16 kB+0.06%+27 B 🔺
@sentry/core/server65.47 kB+0.04%+22 B 🔺
@sentry/core/browser51.87 kB+0.06%+29 B 🔺
@sentry/node123.25 kB+0.05%+52 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection)85.23 kB--
@sentry/node - without tracing87.75 kB+0.04%+27 B 🔺
@sentry/node - without channel injection102.92 kB+0.06%+59 B 🔺
@sentry/aws-serverless95.95 kB+0.08%+68 B 🔺
@sentry/cloudflare (withSentry) - minified200.65 kB+0.08%+143 B 🔺
@sentry/cloudflare (withSentry)499.13 kB+0.08%+367 B 🔺

View base workflow run

@mydea
mydea requested a review from Lms24August 28, 2026 07:42
Comment threadpackages/browser/src/integrations/browserSpanStreaming.ts Outdated
@mydea
mydea marked this pull request as ready for review August 28, 2026 08:42
@mydea
mydea requested a review from a team as a code ownerAugust 28, 2026 08:42
@mydea
mydea requested review from msonnb and removed request for a teamAugust 28, 2026 08:42
Comment threadpackages/browser/src/integrations/browserSpanStreaming.ts Outdated

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can do something better here which is what we decided on last week but I didn't have time to implement yet: Let's just always flush at segment end (with the delay), regardless of environment.

In Python, we already made that change after noticing that the 5s flushing interval accumulates a lot of memory in high-throughput environments. Since we make one request per trace anyway, the number of requests shouldn't be drastically higher.

That is, as long as we can expect that traces are generally well-formed (i.e. child spans ending before their segment span). For malformed traces, with long-running child spans we would increase the request count. I think this is a fine tradeoff IMHO.

If you have (or anyone else has) concerns about this, I'd prefer keeping the two integrations separate because the merge increases bundle size for the browser version. Which was the reason why I opted against combining them initially.

@mydea

Copy link
Copy Markdown
MemberAuthor

I think we can do something better here which is what we decided on last week but I didn't have time to implement yet: Let's just always flush at segment end (with the delay), regardless of environment.

In Python, we already made that change after noticing that the 5s flushing interval accumulates a lot of memory in high-throughput environments. Since we make one request per trace anyway, the number of requests shouldn't be drastically higher.

That is, as long as we can expect that traces are generally well-formed (i.e. child spans ending before their segment span). For malformed traces, with long-running child spans we would increase the request count. I think this is a fine tradeoff IMHO.

If you have (or anyone else has) concerns about this, I'd prefer keeping the two integrations separate because the merge increases bundle size for the browser version. Which was the reason why I opted against combining them initially.

sounds good to me, so I'll just change this so that the default for flushing is true I'd say, so you can still opt out?

@mydeamydea changed the title ref(core): Merge browser and server spanStreamingIntegration into one shared integrationfeat(core): Always flush streamed span traces after segment end by defaultAug 28, 2026
@mydea
mydeaforce-pushed the feat/share-span-streaming-integration branch from ea19f07 to 023fef5CompareAugust 28, 2026 09:45
@mydea
mydea requested a review from a team as a code ownerAugust 28, 2026 09:45
@mydea
mydea requested review from chargome and s1gr1d and removed request for a teamAugust 28, 2026 09:45
Comment threadpackages/core/src/integrations/spanStreaming.ts
Comment threadpackages/core/test/integrations/spanStreaming.test.ts
Comment threadpackages/core/src/integrations/spanStreaming.ts
@mydea
mydeaforce-pushed the feat/share-span-streaming-integration branch from 023fef5 to 5f6ffb5CompareAugust 28, 2026 09:54

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reworking this!

Small positive side-effect for our tests: Span streaming tests should now run faster, given we flush way more quickly.

Comment threadpackages/core/src/integrations/spanStreaming.ts Outdated
Comment threadpackages/core/src/integrations/spanStreaming.ts Outdated

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 5f6ffb5. Configure here.


export declare const linkedErrorsIntegration: typeof clientSdk.linkedErrorsIntegration;
export declare const contextLinesIntegration: typeof clientSdk.contextLinesIntegration;
export declare const spanStreamingIntegration: typeof clientSdk.spanStreamingIntegration;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Types drop public integration export

Medium Severity

Removing the explicit spanStreamingIntegration re-export from framework index.types.ts files drops it from the public type surface. TypeScript export * from both client and server omits colliding names, so consumers of packages such as @sentry/astro and @sentry/nextjs can no longer import it. This is flagged because the review rules treat removal of a publicly exported function without a deprecation notice as a breaking change. The same explicit re-export is still required for other shared core symbols such as withStaticSpan.

Additional Locations (2)
Fix in CursorFix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

Reviewed by Cursor Bugbot for commit 5f6ffb5. Configure here.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine

mydeaand others added 7 commits August 31, 2026 09:45
… shared integration
The browser and server span streaming integrations only differed in their
eager-flush trigger, so collapse them into a single core integration
parameterized by a `flushOnSegmentEnd` option. The browser install site
(`browserSpanApi`) passes `{ flushOnSegmentEnd: true }`; the server side
(`ServerRuntimeClient`) keeps the same call and behavior.
The integration is now exported from `shared-exports` (a single shared symbol
across all entries) instead of being duplicated in `browser-exports` and
`server-exports`. Because both entries previously resolved to *different*
symbols, the name was an ambiguous star export that `index.ts` disambiguated
explicitly; now that it resolves to the same symbol, that explicit re-export
collided with the star exports and is removed.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The `flushOnSegmentEnd` 500ms `setTimeout` now lives in shared core code and
`flushOnSegmentEnd` is a public option, so enabling it on a Node runtime could
keep a process alive until the timer fires. Wrap it in `safeUnref` (as the
`SpanBuffer` already does for its own flush timer); it's a no-op in the browser,
where this is the default path.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mydeaand others added 2 commits August 31, 2026 09:45
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
@mydea
mydeaforce-pushed the feat/share-span-streaming-integration branch from 52c5e47 to 0265ccdCompareAugust 31, 2026 07:45
@mydea
mydea requested a review from a team as a code ownerAugust 31, 2026 07:45
@mydea
mydea requested review from JPeer264 and isaacs and removed request for a teamAugust 31, 2026 07:45
@mydea
mydea merged commit b42643f into developAug 31, 2026
282 of 283 checks passed
@mydea
mydea deleted the feat/share-span-streaming-integration branch August 31, 2026 08:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@Lms24
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(core): Always flush streamed span traces after segment end by default - #23714

Merged
mydea merged 9 commits into
developfrom
feat/share-span-streaming-integration
Aug 31, 2026
Merged

feat(core): Always flush streamed span traces after segment end by default#23714
mydea merged 9 commits into
developfrom
feat/share-span-streaming-integration

Conversation

@mydea

@mydeamydea commented Aug 28, 2026

Copy link
Copy Markdown
Member

The browser (browserSpanStreaming.ts) and server (spanStreaming.ts) span streaming integrations were near-identical: the afterSpanEnd buffering was byte-for-byte the same, and they only differed in the eager-flush trigger. This collapses them into a single core integration, and makes flushing a trace shortly after its segment span ends the default for all runtimes, browser and server alike.

Both install sites now call spanStreamingIntegration() with no arguments: browserSpanApi._INTERNAL_ensureBrowserSpanStreaming and ServerRuntimeClient share one behavior. A trace is flushed:

  • eagerly on flushTraceSpans (the Cloudflare drain),
  • 500ms after its segment span ends, and
  • otherwise on the SpanBuffer's own timeout/size thresholds.

Why default segment-end flushing on for the server too

Previously the server relied solely on the buffer thresholds and only the browser flushed on segment end, to avoid the server emitting more, smaller envelopes and to keep the browser's 500ms timer from holding the Node event loop open. The event-loop concern is already handled by safeUnref on the timer (a no-op in the browser), so there's no longer a reason to gate the segment-end path by runtime — flushing traces timely once their segment ends is the behavior we want everywhere.

The flushOnSegmentEnd option is retained (now defaulting to true) so a runtime can still opt out and fall back to threshold-only flushing.

Why keep it in core rather than moving to browser-utils/server-utils

The integrations are consumed internally by core — ServerRuntimeClient auto-adds it, and browserSpanApi/idleSpan auto-install it (a deliberate tree-shaking indirection). Since browser-utils and server-utils both depend on @sentry/core, core cannot import back from them without a circular dependency. Collapsing in-core sidesteps that entirely.

Export change

The integration now lives in shared-exports as a single shared symbol (star-exported by all entries) instead of being duplicated in browser-exports and server-exports. Previously the two entries resolved to different symbols, making the name an ambiguous star export that index.ts disambiguated with an explicit re-export. Now that both resolve to the same symbol, that explicit line collided with the star exports (leaving the root namespace undefined) and is removed. The startSpan/startInactiveSpan/startSpanManual disambiguation stays, as those remain genuinely distinct browser/server variants.

Comment threadpackages/core/src/integrations/spanStreaming.ts
Comment threadpackages/core/src/integrations/spanStreaming.ts Outdated
@github-actions

github-actionsBot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser28.56 kB--
@sentry/browser - with treeshaking flags26.92 kB--
@sentry/browser - with treeshaking flags tracing without tracing26.82 kB--
@sentry/browser (incl. Tracing)48.72 kB+0.09%+40 B 🔺
@sentry/browser (incl. Tracing + Span Streaming)48.74 kB+0.08%+36 B 🔺
@sentry/browser (incl. Tracing, Profiling)51.66 kB+0.08%+37 B 🔺
@sentry/browser (incl. Tracing, Replay)88.19 kB+0.05%+38 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags77.6 kB+0.06%+39 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)92.88 kB+0.04%+35 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)105.83 kB+0.04%+39 B 🔺
@sentry/browser (incl. Feedback)46.05 kB--
@sentry/browser (incl. sendFeedback)33.62 kB--
@sentry/browser (incl. FeedbackAsync)38.73 kB--
@sentry/browser (incl. Metrics)29.51 kB--
@sentry/browser (incl. Logs)29.8 kB--
@sentry/browser (incl. Metrics & Logs)30.43 kB--
@sentry/react30.3 kB--
@sentry/react (incl. Tracing)50.93 kB+0.07%+32 B 🔺
@sentry/vue35.73 kB+0.11%+39 B 🔺
@sentry/vue (incl. Tracing)50.97 kB+0.08%+38 B 🔺
@sentry/svelte28.59 kB--
CDN Bundle30.35 kB--
CDN Bundle (incl. Tracing)49.32 kB+0.06%+25 B 🔺
CDN Bundle (incl. Logs, Metrics)32.58 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)51.21 kB+0.06%+26 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)73.17 kB--
CDN Bundle (incl. Tracing, Replay)86.82 kB+0.04%+27 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)88.69 kB+0.03%+26 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)92.74 kB+0.03%+27 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)94.61 kB+0.03%+25 B 🔺
CDN Bundle - uncompressed89.95 kB--
CDN Bundle (incl. Tracing) - uncompressed147.05 kB+0.07%+89 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed96.24 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed152.74 kB+0.06%+89 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed225.41 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed266.55 kB+0.04%+89 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed272.22 kB+0.04%+89 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed280.25 kB+0.04%+89 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed285.92 kB+0.04%+89 B 🔺
@sentry/nextjs (client)53.5 kB+0.06%+28 B 🔺
@sentry/sveltekit (client)49.16 kB+0.06%+27 B 🔺
@sentry/core/server65.47 kB+0.04%+22 B 🔺
@sentry/core/browser51.87 kB+0.06%+29 B 🔺
@sentry/node123.25 kB+0.05%+52 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection)85.23 kB--
@sentry/node - without tracing87.75 kB+0.04%+27 B 🔺
@sentry/node - without channel injection102.92 kB+0.06%+59 B 🔺
@sentry/aws-serverless95.95 kB+0.08%+68 B 🔺
@sentry/cloudflare (withSentry) - minified200.65 kB+0.08%+143 B 🔺
@sentry/cloudflare (withSentry)499.13 kB+0.08%+367 B 🔺

View base workflow run

@mydea
mydea requested a review from Lms24August 28, 2026 07:42
Comment threadpackages/browser/src/integrations/browserSpanStreaming.ts Outdated
@mydea
mydea marked this pull request as ready for review August 28, 2026 08:42
@mydea
mydea requested a review from a team as a code ownerAugust 28, 2026 08:42
@mydea
mydea requested review from msonnb and removed request for a teamAugust 28, 2026 08:42
Comment threadpackages/browser/src/integrations/browserSpanStreaming.ts Outdated

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can do something better here which is what we decided on last week but I didn't have time to implement yet: Let's just always flush at segment end (with the delay), regardless of environment.

In Python, we already made that change after noticing that the 5s flushing interval accumulates a lot of memory in high-throughput environments. Since we make one request per trace anyway, the number of requests shouldn't be drastically higher.

That is, as long as we can expect that traces are generally well-formed (i.e. child spans ending before their segment span). For malformed traces, with long-running child spans we would increase the request count. I think this is a fine tradeoff IMHO.

If you have (or anyone else has) concerns about this, I'd prefer keeping the two integrations separate because the merge increases bundle size for the browser version. Which was the reason why I opted against combining them initially.

@mydea

Copy link
Copy Markdown
MemberAuthor

I think we can do something better here which is what we decided on last week but I didn't have time to implement yet: Let's just always flush at segment end (with the delay), regardless of environment.

In Python, we already made that change after noticing that the 5s flushing interval accumulates a lot of memory in high-throughput environments. Since we make one request per trace anyway, the number of requests shouldn't be drastically higher.

That is, as long as we can expect that traces are generally well-formed (i.e. child spans ending before their segment span). For malformed traces, with long-running child spans we would increase the request count. I think this is a fine tradeoff IMHO.

If you have (or anyone else has) concerns about this, I'd prefer keeping the two integrations separate because the merge increases bundle size for the browser version. Which was the reason why I opted against combining them initially.

sounds good to me, so I'll just change this so that the default for flushing is true I'd say, so you can still opt out?

@mydeamydea changed the title ref(core): Merge browser and server spanStreamingIntegration into one shared integrationfeat(core): Always flush streamed span traces after segment end by defaultAug 28, 2026
@mydea
mydeaforce-pushed the feat/share-span-streaming-integration branch from ea19f07 to 023fef5CompareAugust 28, 2026 09:45
@mydea
mydea requested a review from a team as a code ownerAugust 28, 2026 09:45
@mydea
mydea requested review from chargome and s1gr1d and removed request for a teamAugust 28, 2026 09:45
Comment threadpackages/core/src/integrations/spanStreaming.ts
Comment threadpackages/core/test/integrations/spanStreaming.test.ts
Comment threadpackages/core/src/integrations/spanStreaming.ts
@mydea
mydeaforce-pushed the feat/share-span-streaming-integration branch from 023fef5 to 5f6ffb5CompareAugust 28, 2026 09:54

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reworking this!

Small positive side-effect for our tests: Span streaming tests should now run faster, given we flush way more quickly.

Comment threadpackages/core/src/integrations/spanStreaming.ts Outdated
Comment threadpackages/core/src/integrations/spanStreaming.ts Outdated

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 5f6ffb5. Configure here.


export declare const linkedErrorsIntegration: typeof clientSdk.linkedErrorsIntegration;
export declare const contextLinesIntegration: typeof clientSdk.contextLinesIntegration;
export declare const spanStreamingIntegration: typeof clientSdk.spanStreamingIntegration;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Types drop public integration export

Medium Severity

Removing the explicit spanStreamingIntegration re-export from framework index.types.ts files drops it from the public type surface. TypeScript export * from both client and server omits colliding names, so consumers of packages such as @sentry/astro and @sentry/nextjs can no longer import it. This is flagged because the review rules treat removal of a publicly exported function without a deprecation notice as a breaking change. The same explicit re-export is still required for other shared core symbols such as withStaticSpan.

Additional Locations (2)
Fix in CursorFix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

Reviewed by Cursor Bugbot for commit 5f6ffb5. Configure here.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine

mydeaand others added 7 commits August 31, 2026 09:45
… shared integration
The browser and server span streaming integrations only differed in their
eager-flush trigger, so collapse them into a single core integration
parameterized by a `flushOnSegmentEnd` option. The browser install site
(`browserSpanApi`) passes `{ flushOnSegmentEnd: true }`; the server side
(`ServerRuntimeClient`) keeps the same call and behavior.
The integration is now exported from `shared-exports` (a single shared symbol
across all entries) instead of being duplicated in `browser-exports` and
`server-exports`. Because both entries previously resolved to *different*
symbols, the name was an ambiguous star export that `index.ts` disambiguated
explicitly; now that it resolves to the same symbol, that explicit re-export
collided with the star exports and is removed.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The `flushOnSegmentEnd` 500ms `setTimeout` now lives in shared core code and
`flushOnSegmentEnd` is a public option, so enabling it on a Node runtime could
keep a process alive until the timer fires. Wrap it in `safeUnref` (as the
`SpanBuffer` already does for its own flush timer); it's a no-op in the browser,
where this is the default path.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mydeaand others added 2 commits August 31, 2026 09:45
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
@mydea
mydeaforce-pushed the feat/share-span-streaming-integration branch from 52c5e47 to 0265ccdCompareAugust 31, 2026 07:45
@mydea
mydea requested a review from a team as a code ownerAugust 31, 2026 07:45
@mydea
mydea requested review from JPeer264 and isaacs and removed request for a teamAugust 31, 2026 07:45
@mydea
mydea merged commit b42643f into developAug 31, 2026
282 of 283 checks passed
@mydea
mydea deleted the feat/share-span-streaming-integration branch August 31, 2026 08:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@Lms24
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(core): Always flush streamed span traces after segment end by default - #23714

Merged
mydea merged 9 commits into
developfrom
feat/share-span-streaming-integration
Aug 31, 2026
Merged

feat(core): Always flush streamed span traces after segment end by default#23714
mydea merged 9 commits into
developfrom
feat/share-span-streaming-integration

Conversation

@mydea

@mydeamydea commented Aug 28, 2026

Copy link
Copy Markdown
Member

The browser (browserSpanStreaming.ts) and server (spanStreaming.ts) span streaming integrations were near-identical: the afterSpanEnd buffering was byte-for-byte the same, and they only differed in the eager-flush trigger. This collapses them into a single core integration, and makes flushing a trace shortly after its segment span ends the default for all runtimes, browser and server alike.

Both install sites now call spanStreamingIntegration() with no arguments: browserSpanApi._INTERNAL_ensureBrowserSpanStreaming and ServerRuntimeClient share one behavior. A trace is flushed:

  • eagerly on flushTraceSpans (the Cloudflare drain),
  • 500ms after its segment span ends, and
  • otherwise on the SpanBuffer's own timeout/size thresholds.

Why default segment-end flushing on for the server too

Previously the server relied solely on the buffer thresholds and only the browser flushed on segment end, to avoid the server emitting more, smaller envelopes and to keep the browser's 500ms timer from holding the Node event loop open. The event-loop concern is already handled by safeUnref on the timer (a no-op in the browser), so there's no longer a reason to gate the segment-end path by runtime — flushing traces timely once their segment ends is the behavior we want everywhere.

The flushOnSegmentEnd option is retained (now defaulting to true) so a runtime can still opt out and fall back to threshold-only flushing.

Why keep it in core rather than moving to browser-utils/server-utils

The integrations are consumed internally by core — ServerRuntimeClient auto-adds it, and browserSpanApi/idleSpan auto-install it (a deliberate tree-shaking indirection). Since browser-utils and server-utils both depend on @sentry/core, core cannot import back from them without a circular dependency. Collapsing in-core sidesteps that entirely.

Export change

The integration now lives in shared-exports as a single shared symbol (star-exported by all entries) instead of being duplicated in browser-exports and server-exports. Previously the two entries resolved to different symbols, making the name an ambiguous star export that index.ts disambiguated with an explicit re-export. Now that both resolve to the same symbol, that explicit line collided with the star exports (leaving the root namespace undefined) and is removed. The startSpan/startInactiveSpan/startSpanManual disambiguation stays, as those remain genuinely distinct browser/server variants.

Comment threadpackages/core/src/integrations/spanStreaming.ts
Comment threadpackages/core/src/integrations/spanStreaming.ts Outdated
@github-actions

github-actionsBot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser28.56 kB--
@sentry/browser - with treeshaking flags26.92 kB--
@sentry/browser - with treeshaking flags tracing without tracing26.82 kB--
@sentry/browser (incl. Tracing)48.72 kB+0.09%+40 B 🔺
@sentry/browser (incl. Tracing + Span Streaming)48.74 kB+0.08%+36 B 🔺
@sentry/browser (incl. Tracing, Profiling)51.66 kB+0.08%+37 B 🔺
@sentry/browser (incl. Tracing, Replay)88.19 kB+0.05%+38 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags77.6 kB+0.06%+39 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)92.88 kB+0.04%+35 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)105.83 kB+0.04%+39 B 🔺
@sentry/browser (incl. Feedback)46.05 kB--
@sentry/browser (incl. sendFeedback)33.62 kB--
@sentry/browser (incl. FeedbackAsync)38.73 kB--
@sentry/browser (incl. Metrics)29.51 kB--
@sentry/browser (incl. Logs)29.8 kB--
@sentry/browser (incl. Metrics & Logs)30.43 kB--
@sentry/react30.3 kB--
@sentry/react (incl. Tracing)50.93 kB+0.07%+32 B 🔺
@sentry/vue35.73 kB+0.11%+39 B 🔺
@sentry/vue (incl. Tracing)50.97 kB+0.08%+38 B 🔺
@sentry/svelte28.59 kB--
CDN Bundle30.35 kB--
CDN Bundle (incl. Tracing)49.32 kB+0.06%+25 B 🔺
CDN Bundle (incl. Logs, Metrics)32.58 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)51.21 kB+0.06%+26 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)73.17 kB--
CDN Bundle (incl. Tracing, Replay)86.82 kB+0.04%+27 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)88.69 kB+0.03%+26 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)92.74 kB+0.03%+27 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)94.61 kB+0.03%+25 B 🔺
CDN Bundle - uncompressed89.95 kB--
CDN Bundle (incl. Tracing) - uncompressed147.05 kB+0.07%+89 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed96.24 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed152.74 kB+0.06%+89 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed225.41 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed266.55 kB+0.04%+89 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed272.22 kB+0.04%+89 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed280.25 kB+0.04%+89 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed285.92 kB+0.04%+89 B 🔺
@sentry/nextjs (client)53.5 kB+0.06%+28 B 🔺
@sentry/sveltekit (client)49.16 kB+0.06%+27 B 🔺
@sentry/core/server65.47 kB+0.04%+22 B 🔺
@sentry/core/browser51.87 kB+0.06%+29 B 🔺
@sentry/node123.25 kB+0.05%+52 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection)85.23 kB--
@sentry/node - without tracing87.75 kB+0.04%+27 B 🔺
@sentry/node - without channel injection102.92 kB+0.06%+59 B 🔺
@sentry/aws-serverless95.95 kB+0.08%+68 B 🔺
@sentry/cloudflare (withSentry) - minified200.65 kB+0.08%+143 B 🔺
@sentry/cloudflare (withSentry)499.13 kB+0.08%+367 B 🔺

View base workflow run

@mydea
mydea requested a review from Lms24August 28, 2026 07:42
Comment threadpackages/browser/src/integrations/browserSpanStreaming.ts Outdated
@mydea
mydea marked this pull request as ready for review August 28, 2026 08:42
@mydea
mydea requested a review from a team as a code ownerAugust 28, 2026 08:42
@mydea
mydea requested review from msonnb and removed request for a teamAugust 28, 2026 08:42
Comment threadpackages/browser/src/integrations/browserSpanStreaming.ts Outdated

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can do something better here which is what we decided on last week but I didn't have time to implement yet: Let's just always flush at segment end (with the delay), regardless of environment.

In Python, we already made that change after noticing that the 5s flushing interval accumulates a lot of memory in high-throughput environments. Since we make one request per trace anyway, the number of requests shouldn't be drastically higher.

That is, as long as we can expect that traces are generally well-formed (i.e. child spans ending before their segment span). For malformed traces, with long-running child spans we would increase the request count. I think this is a fine tradeoff IMHO.

If you have (or anyone else has) concerns about this, I'd prefer keeping the two integrations separate because the merge increases bundle size for the browser version. Which was the reason why I opted against combining them initially.

@mydea

Copy link
Copy Markdown
MemberAuthor

I think we can do something better here which is what we decided on last week but I didn't have time to implement yet: Let's just always flush at segment end (with the delay), regardless of environment.

In Python, we already made that change after noticing that the 5s flushing interval accumulates a lot of memory in high-throughput environments. Since we make one request per trace anyway, the number of requests shouldn't be drastically higher.

That is, as long as we can expect that traces are generally well-formed (i.e. child spans ending before their segment span). For malformed traces, with long-running child spans we would increase the request count. I think this is a fine tradeoff IMHO.

If you have (or anyone else has) concerns about this, I'd prefer keeping the two integrations separate because the merge increases bundle size for the browser version. Which was the reason why I opted against combining them initially.

sounds good to me, so I'll just change this so that the default for flushing is true I'd say, so you can still opt out?

@mydeamydea changed the title ref(core): Merge browser and server spanStreamingIntegration into one shared integrationfeat(core): Always flush streamed span traces after segment end by defaultAug 28, 2026
@mydea
mydeaforce-pushed the feat/share-span-streaming-integration branch from ea19f07 to 023fef5CompareAugust 28, 2026 09:45
@mydea
mydea requested a review from a team as a code ownerAugust 28, 2026 09:45
@mydea
mydea requested review from chargome and s1gr1d and removed request for a teamAugust 28, 2026 09:45
Comment threadpackages/core/src/integrations/spanStreaming.ts
Comment threadpackages/core/test/integrations/spanStreaming.test.ts
Comment threadpackages/core/src/integrations/spanStreaming.ts
@mydea
mydeaforce-pushed the feat/share-span-streaming-integration branch from 023fef5 to 5f6ffb5CompareAugust 28, 2026 09:54

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reworking this!

Small positive side-effect for our tests: Span streaming tests should now run faster, given we flush way more quickly.

Comment threadpackages/core/src/integrations/spanStreaming.ts Outdated
Comment threadpackages/core/src/integrations/spanStreaming.ts Outdated

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 5f6ffb5. Configure here.


export declare const linkedErrorsIntegration: typeof clientSdk.linkedErrorsIntegration;
export declare const contextLinesIntegration: typeof clientSdk.contextLinesIntegration;
export declare const spanStreamingIntegration: typeof clientSdk.spanStreamingIntegration;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Types drop public integration export

Medium Severity

Removing the explicit spanStreamingIntegration re-export from framework index.types.ts files drops it from the public type surface. TypeScript export * from both client and server omits colliding names, so consumers of packages such as @sentry/astro and @sentry/nextjs can no longer import it. This is flagged because the review rules treat removal of a publicly exported function without a deprecation notice as a breaking change. The same explicit re-export is still required for other shared core symbols such as withStaticSpan.

Additional Locations (2)
Fix in CursorFix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

Reviewed by Cursor Bugbot for commit 5f6ffb5. Configure here.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine

mydeaand others added 7 commits August 31, 2026 09:45
… shared integration
The browser and server span streaming integrations only differed in their
eager-flush trigger, so collapse them into a single core integration
parameterized by a `flushOnSegmentEnd` option. The browser install site
(`browserSpanApi`) passes `{ flushOnSegmentEnd: true }`; the server side
(`ServerRuntimeClient`) keeps the same call and behavior.
The integration is now exported from `shared-exports` (a single shared symbol
across all entries) instead of being duplicated in `browser-exports` and
`server-exports`. Because both entries previously resolved to *different*
symbols, the name was an ambiguous star export that `index.ts` disambiguated
explicitly; now that it resolves to the same symbol, that explicit re-export
collided with the star exports and is removed.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The `flushOnSegmentEnd` 500ms `setTimeout` now lives in shared core code and
`flushOnSegmentEnd` is a public option, so enabling it on a Node runtime could
keep a process alive until the timer fires. Wrap it in `safeUnref` (as the
`SpanBuffer` already does for its own flush timer); it's a no-op in the browser,
where this is the default path.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mydeaand others added 2 commits August 31, 2026 09:45
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
@mydea
mydeaforce-pushed the feat/share-span-streaming-integration branch from 52c5e47 to 0265ccdCompareAugust 31, 2026 07:45
@mydea
mydea requested a review from a team as a code ownerAugust 31, 2026 07:45
@mydea
mydea requested review from JPeer264 and isaacs and removed request for a teamAugust 31, 2026 07:45
@mydea
mydea merged commit b42643f into developAug 31, 2026
282 of 283 checks passed
@mydea
mydea deleted the feat/share-span-streaming-integration branch August 31, 2026 08:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@Lms24
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

feat(core): Always flush streamed span traces after segment end by default - #23714

Merged
mydea merged 9 commits into
developfrom
feat/share-span-streaming-integration
Aug 31, 2026
Merged

feat(core): Always flush streamed span traces after segment end by default#23714
mydea merged 9 commits into
developfrom
feat/share-span-streaming-integration

Conversation

@mydea

@mydeamydea commented Aug 28, 2026

Copy link
Copy Markdown
Member

The browser (browserSpanStreaming.ts) and server (spanStreaming.ts) span streaming integrations were near-identical: the afterSpanEnd buffering was byte-for-byte the same, and they only differed in the eager-flush trigger. This collapses them into a single core integration, and makes flushing a trace shortly after its segment span ends the default for all runtimes, browser and server alike.

Both install sites now call spanStreamingIntegration() with no arguments: browserSpanApi._INTERNAL_ensureBrowserSpanStreaming and ServerRuntimeClient share one behavior. A trace is flushed:

  • eagerly on flushTraceSpans (the Cloudflare drain),
  • 500ms after its segment span ends, and
  • otherwise on the SpanBuffer's own timeout/size thresholds.

Why default segment-end flushing on for the server too

Previously the server relied solely on the buffer thresholds and only the browser flushed on segment end, to avoid the server emitting more, smaller envelopes and to keep the browser's 500ms timer from holding the Node event loop open. The event-loop concern is already handled by safeUnref on the timer (a no-op in the browser), so there's no longer a reason to gate the segment-end path by runtime — flushing traces timely once their segment ends is the behavior we want everywhere.

The flushOnSegmentEnd option is retained (now defaulting to true) so a runtime can still opt out and fall back to threshold-only flushing.

Why keep it in core rather than moving to browser-utils/server-utils

The integrations are consumed internally by core — ServerRuntimeClient auto-adds it, and browserSpanApi/idleSpan auto-install it (a deliberate tree-shaking indirection). Since browser-utils and server-utils both depend on @sentry/core, core cannot import back from them without a circular dependency. Collapsing in-core sidesteps that entirely.

Export change

The integration now lives in shared-exports as a single shared symbol (star-exported by all entries) instead of being duplicated in browser-exports and server-exports. Previously the two entries resolved to different symbols, making the name an ambiguous star export that index.ts disambiguated with an explicit re-export. Now that both resolve to the same symbol, that explicit line collided with the star exports (leaving the root namespace undefined) and is removed. The startSpan/startInactiveSpan/startSpanManual disambiguation stays, as those remain genuinely distinct browser/server variants.

Comment threadpackages/core/src/integrations/spanStreaming.ts
Comment threadpackages/core/src/integrations/spanStreaming.ts Outdated
@github-actions

github-actionsBot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser28.56 kB--
@sentry/browser - with treeshaking flags26.92 kB--
@sentry/browser - with treeshaking flags tracing without tracing26.82 kB--
@sentry/browser (incl. Tracing)48.72 kB+0.09%+40 B 🔺
@sentry/browser (incl. Tracing + Span Streaming)48.74 kB+0.08%+36 B 🔺
@sentry/browser (incl. Tracing, Profiling)51.66 kB+0.08%+37 B 🔺
@sentry/browser (incl. Tracing, Replay)88.19 kB+0.05%+38 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags77.6 kB+0.06%+39 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)92.88 kB+0.04%+35 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)105.83 kB+0.04%+39 B 🔺
@sentry/browser (incl. Feedback)46.05 kB--
@sentry/browser (incl. sendFeedback)33.62 kB--
@sentry/browser (incl. FeedbackAsync)38.73 kB--
@sentry/browser (incl. Metrics)29.51 kB--
@sentry/browser (incl. Logs)29.8 kB--
@sentry/browser (incl. Metrics & Logs)30.43 kB--
@sentry/react30.3 kB--
@sentry/react (incl. Tracing)50.93 kB+0.07%+32 B 🔺
@sentry/vue35.73 kB+0.11%+39 B 🔺
@sentry/vue (incl. Tracing)50.97 kB+0.08%+38 B 🔺
@sentry/svelte28.59 kB--
CDN Bundle30.35 kB--
CDN Bundle (incl. Tracing)49.32 kB+0.06%+25 B 🔺
CDN Bundle (incl. Logs, Metrics)32.58 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)51.21 kB+0.06%+26 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)73.17 kB--
CDN Bundle (incl. Tracing, Replay)86.82 kB+0.04%+27 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)88.69 kB+0.03%+26 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)92.74 kB+0.03%+27 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)94.61 kB+0.03%+25 B 🔺
CDN Bundle - uncompressed89.95 kB--
CDN Bundle (incl. Tracing) - uncompressed147.05 kB+0.07%+89 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed96.24 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed152.74 kB+0.06%+89 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed225.41 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed266.55 kB+0.04%+89 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed272.22 kB+0.04%+89 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed280.25 kB+0.04%+89 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed285.92 kB+0.04%+89 B 🔺
@sentry/nextjs (client)53.5 kB+0.06%+28 B 🔺
@sentry/sveltekit (client)49.16 kB+0.06%+27 B 🔺
@sentry/core/server65.47 kB+0.04%+22 B 🔺
@sentry/core/browser51.87 kB+0.06%+29 B 🔺
@sentry/node123.25 kB+0.05%+52 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection)85.23 kB--
@sentry/node - without tracing87.75 kB+0.04%+27 B 🔺
@sentry/node - without channel injection102.92 kB+0.06%+59 B 🔺
@sentry/aws-serverless95.95 kB+0.08%+68 B 🔺
@sentry/cloudflare (withSentry) - minified200.65 kB+0.08%+143 B 🔺
@sentry/cloudflare (withSentry)499.13 kB+0.08%+367 B 🔺

View base workflow run

@mydea
mydea requested a review from Lms24August 28, 2026 07:42
Comment threadpackages/browser/src/integrations/browserSpanStreaming.ts Outdated
@mydea
mydea marked this pull request as ready for review August 28, 2026 08:42
@mydea
mydea requested a review from a team as a code ownerAugust 28, 2026 08:42
@mydea
mydea requested review from msonnb and removed request for a teamAugust 28, 2026 08:42
Comment threadpackages/browser/src/integrations/browserSpanStreaming.ts Outdated

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can do something better here which is what we decided on last week but I didn't have time to implement yet: Let's just always flush at segment end (with the delay), regardless of environment.

In Python, we already made that change after noticing that the 5s flushing interval accumulates a lot of memory in high-throughput environments. Since we make one request per trace anyway, the number of requests shouldn't be drastically higher.

That is, as long as we can expect that traces are generally well-formed (i.e. child spans ending before their segment span). For malformed traces, with long-running child spans we would increase the request count. I think this is a fine tradeoff IMHO.

If you have (or anyone else has) concerns about this, I'd prefer keeping the two integrations separate because the merge increases bundle size for the browser version. Which was the reason why I opted against combining them initially.

@mydea

Copy link
Copy Markdown
MemberAuthor

I think we can do something better here which is what we decided on last week but I didn't have time to implement yet: Let's just always flush at segment end (with the delay), regardless of environment.

In Python, we already made that change after noticing that the 5s flushing interval accumulates a lot of memory in high-throughput environments. Since we make one request per trace anyway, the number of requests shouldn't be drastically higher.

That is, as long as we can expect that traces are generally well-formed (i.e. child spans ending before their segment span). For malformed traces, with long-running child spans we would increase the request count. I think this is a fine tradeoff IMHO.

If you have (or anyone else has) concerns about this, I'd prefer keeping the two integrations separate because the merge increases bundle size for the browser version. Which was the reason why I opted against combining them initially.

sounds good to me, so I'll just change this so that the default for flushing is true I'd say, so you can still opt out?

@mydeamydea changed the title ref(core): Merge browser and server spanStreamingIntegration into one shared integrationfeat(core): Always flush streamed span traces after segment end by defaultAug 28, 2026
@mydea
mydeaforce-pushed the feat/share-span-streaming-integration branch from ea19f07 to 023fef5CompareAugust 28, 2026 09:45
@mydea
mydea requested a review from a team as a code ownerAugust 28, 2026 09:45
@mydea
mydea requested review from chargome and s1gr1d and removed request for a teamAugust 28, 2026 09:45
Comment threadpackages/core/src/integrations/spanStreaming.ts
Comment threadpackages/core/test/integrations/spanStreaming.test.ts
Comment threadpackages/core/src/integrations/spanStreaming.ts
@mydea
mydeaforce-pushed the feat/share-span-streaming-integration branch from 023fef5 to 5f6ffb5CompareAugust 28, 2026 09:54

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reworking this!

Small positive side-effect for our tests: Span streaming tests should now run faster, given we flush way more quickly.

Comment threadpackages/core/src/integrations/spanStreaming.ts Outdated
Comment threadpackages/core/src/integrations/spanStreaming.ts Outdated

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 5f6ffb5. Configure here.


export declare const linkedErrorsIntegration: typeof clientSdk.linkedErrorsIntegration;
export declare const contextLinesIntegration: typeof clientSdk.contextLinesIntegration;
export declare const spanStreamingIntegration: typeof clientSdk.spanStreamingIntegration;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Types drop public integration export

Medium Severity

Removing the explicit spanStreamingIntegration re-export from framework index.types.ts files drops it from the public type surface. TypeScript export * from both client and server omits colliding names, so consumers of packages such as @sentry/astro and @sentry/nextjs can no longer import it. This is flagged because the review rules treat removal of a publicly exported function without a deprecation notice as a breaking change. The same explicit re-export is still required for other shared core symbols such as withStaticSpan.

Additional Locations (2)
Fix in CursorFix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

Reviewed by Cursor Bugbot for commit 5f6ffb5. Configure here.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine

mydeaand others added 7 commits August 31, 2026 09:45
… shared integration
The browser and server span streaming integrations only differed in their
eager-flush trigger, so collapse them into a single core integration
parameterized by a `flushOnSegmentEnd` option. The browser install site
(`browserSpanApi`) passes `{ flushOnSegmentEnd: true }`; the server side
(`ServerRuntimeClient`) keeps the same call and behavior.
The integration is now exported from `shared-exports` (a single shared symbol
across all entries) instead of being duplicated in `browser-exports` and
`server-exports`. Because both entries previously resolved to *different*
symbols, the name was an ambiguous star export that `index.ts` disambiguated
explicitly; now that it resolves to the same symbol, that explicit re-export
collided with the star exports and is removed.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The `flushOnSegmentEnd` 500ms `setTimeout` now lives in shared core code and
`flushOnSegmentEnd` is a public option, so enabling it on a Node runtime could
keep a process alive until the timer fires. Wrap it in `safeUnref` (as the
`SpanBuffer` already does for its own flush timer); it's a no-op in the browser,
where this is the default path.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mydeaand others added 2 commits August 31, 2026 09:45
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
@mydea
mydeaforce-pushed the feat/share-span-streaming-integration branch from 52c5e47 to 0265ccdCompareAugust 31, 2026 07:45
@mydea
mydea requested a review from a team as a code ownerAugust 31, 2026 07:45
@mydea
mydea requested review from JPeer264 and isaacs and removed request for a teamAugust 31, 2026 07:45
@mydea
mydea merged commit b42643f into developAug 31, 2026
282 of 283 checks passed
@mydea
mydea deleted the feat/share-span-streaming-integration branch August 31, 2026 08:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@Lms24
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(core): Always flush streamed span traces after segment end by default - #23714

Merged
mydea merged 9 commits into
developfrom
feat/share-span-streaming-integration
Aug 31, 2026
Merged

feat(core): Always flush streamed span traces after segment end by default#23714
mydea merged 9 commits into
developfrom
feat/share-span-streaming-integration

Conversation

@mydea

@mydeamydea commented Aug 28, 2026

Copy link
Copy Markdown
Member

The browser (browserSpanStreaming.ts) and server (spanStreaming.ts) span streaming integrations were near-identical: the afterSpanEnd buffering was byte-for-byte the same, and they only differed in the eager-flush trigger. This collapses them into a single core integration, and makes flushing a trace shortly after its segment span ends the default for all runtimes, browser and server alike.

Both install sites now call spanStreamingIntegration() with no arguments: browserSpanApi._INTERNAL_ensureBrowserSpanStreaming and ServerRuntimeClient share one behavior. A trace is flushed:

  • eagerly on flushTraceSpans (the Cloudflare drain),
  • 500ms after its segment span ends, and
  • otherwise on the SpanBuffer's own timeout/size thresholds.

Why default segment-end flushing on for the server too

Previously the server relied solely on the buffer thresholds and only the browser flushed on segment end, to avoid the server emitting more, smaller envelopes and to keep the browser's 500ms timer from holding the Node event loop open. The event-loop concern is already handled by safeUnref on the timer (a no-op in the browser), so there's no longer a reason to gate the segment-end path by runtime — flushing traces timely once their segment ends is the behavior we want everywhere.

The flushOnSegmentEnd option is retained (now defaulting to true) so a runtime can still opt out and fall back to threshold-only flushing.

Why keep it in core rather than moving to browser-utils/server-utils

The integrations are consumed internally by core — ServerRuntimeClient auto-adds it, and browserSpanApi/idleSpan auto-install it (a deliberate tree-shaking indirection). Since browser-utils and server-utils both depend on @sentry/core, core cannot import back from them without a circular dependency. Collapsing in-core sidesteps that entirely.

Export change

The integration now lives in shared-exports as a single shared symbol (star-exported by all entries) instead of being duplicated in browser-exports and server-exports. Previously the two entries resolved to different symbols, making the name an ambiguous star export that index.ts disambiguated with an explicit re-export. Now that both resolve to the same symbol, that explicit line collided with the star exports (leaving the root namespace undefined) and is removed. The startSpan/startInactiveSpan/startSpanManual disambiguation stays, as those remain genuinely distinct browser/server variants.

Comment threadpackages/core/src/integrations/spanStreaming.ts
Comment threadpackages/core/src/integrations/spanStreaming.ts Outdated
@github-actions

github-actionsBot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser28.56 kB--
@sentry/browser - with treeshaking flags26.92 kB--
@sentry/browser - with treeshaking flags tracing without tracing26.82 kB--
@sentry/browser (incl. Tracing)48.72 kB+0.09%+40 B 🔺
@sentry/browser (incl. Tracing + Span Streaming)48.74 kB+0.08%+36 B 🔺
@sentry/browser (incl. Tracing, Profiling)51.66 kB+0.08%+37 B 🔺
@sentry/browser (incl. Tracing, Replay)88.19 kB+0.05%+38 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags77.6 kB+0.06%+39 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)92.88 kB+0.04%+35 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)105.83 kB+0.04%+39 B 🔺
@sentry/browser (incl. Feedback)46.05 kB--
@sentry/browser (incl. sendFeedback)33.62 kB--
@sentry/browser (incl. FeedbackAsync)38.73 kB--
@sentry/browser (incl. Metrics)29.51 kB--
@sentry/browser (incl. Logs)29.8 kB--
@sentry/browser (incl. Metrics & Logs)30.43 kB--
@sentry/react30.3 kB--
@sentry/react (incl. Tracing)50.93 kB+0.07%+32 B 🔺
@sentry/vue35.73 kB+0.11%+39 B 🔺
@sentry/vue (incl. Tracing)50.97 kB+0.08%+38 B 🔺
@sentry/svelte28.59 kB--
CDN Bundle30.35 kB--
CDN Bundle (incl. Tracing)49.32 kB+0.06%+25 B 🔺
CDN Bundle (incl. Logs, Metrics)32.58 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)51.21 kB+0.06%+26 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)73.17 kB--
CDN Bundle (incl. Tracing, Replay)86.82 kB+0.04%+27 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)88.69 kB+0.03%+26 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)92.74 kB+0.03%+27 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)94.61 kB+0.03%+25 B 🔺
CDN Bundle - uncompressed89.95 kB--
CDN Bundle (incl. Tracing) - uncompressed147.05 kB+0.07%+89 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed96.24 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed152.74 kB+0.06%+89 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed225.41 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed266.55 kB+0.04%+89 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed272.22 kB+0.04%+89 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed280.25 kB+0.04%+89 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed285.92 kB+0.04%+89 B 🔺
@sentry/nextjs (client)53.5 kB+0.06%+28 B 🔺
@sentry/sveltekit (client)49.16 kB+0.06%+27 B 🔺
@sentry/core/server65.47 kB+0.04%+22 B 🔺
@sentry/core/browser51.87 kB+0.06%+29 B 🔺
@sentry/node123.25 kB+0.05%+52 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection)85.23 kB--
@sentry/node - without tracing87.75 kB+0.04%+27 B 🔺
@sentry/node - without channel injection102.92 kB+0.06%+59 B 🔺
@sentry/aws-serverless95.95 kB+0.08%+68 B 🔺
@sentry/cloudflare (withSentry) - minified200.65 kB+0.08%+143 B 🔺
@sentry/cloudflare (withSentry)499.13 kB+0.08%+367 B 🔺

View base workflow run

@mydea
mydea requested a review from Lms24August 28, 2026 07:42
Comment threadpackages/browser/src/integrations/browserSpanStreaming.ts Outdated
@mydea
mydea marked this pull request as ready for review August 28, 2026 08:42
@mydea
mydea requested a review from a team as a code ownerAugust 28, 2026 08:42
@mydea
mydea requested review from msonnb and removed request for a teamAugust 28, 2026 08:42
Comment threadpackages/browser/src/integrations/browserSpanStreaming.ts Outdated

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can do something better here which is what we decided on last week but I didn't have time to implement yet: Let's just always flush at segment end (with the delay), regardless of environment.

In Python, we already made that change after noticing that the 5s flushing interval accumulates a lot of memory in high-throughput environments. Since we make one request per trace anyway, the number of requests shouldn't be drastically higher.

That is, as long as we can expect that traces are generally well-formed (i.e. child spans ending before their segment span). For malformed traces, with long-running child spans we would increase the request count. I think this is a fine tradeoff IMHO.

If you have (or anyone else has) concerns about this, I'd prefer keeping the two integrations separate because the merge increases bundle size for the browser version. Which was the reason why I opted against combining them initially.

@mydea

Copy link
Copy Markdown
MemberAuthor

I think we can do something better here which is what we decided on last week but I didn't have time to implement yet: Let's just always flush at segment end (with the delay), regardless of environment.

In Python, we already made that change after noticing that the 5s flushing interval accumulates a lot of memory in high-throughput environments. Since we make one request per trace anyway, the number of requests shouldn't be drastically higher.

That is, as long as we can expect that traces are generally well-formed (i.e. child spans ending before their segment span). For malformed traces, with long-running child spans we would increase the request count. I think this is a fine tradeoff IMHO.

If you have (or anyone else has) concerns about this, I'd prefer keeping the two integrations separate because the merge increases bundle size for the browser version. Which was the reason why I opted against combining them initially.

sounds good to me, so I'll just change this so that the default for flushing is true I'd say, so you can still opt out?

@mydeamydea changed the title ref(core): Merge browser and server spanStreamingIntegration into one shared integrationfeat(core): Always flush streamed span traces after segment end by defaultAug 28, 2026
@mydea
mydeaforce-pushed the feat/share-span-streaming-integration branch from ea19f07 to 023fef5CompareAugust 28, 2026 09:45
@mydea
mydea requested a review from a team as a code ownerAugust 28, 2026 09:45
@mydea
mydea requested review from chargome and s1gr1d and removed request for a teamAugust 28, 2026 09:45
Comment threadpackages/core/src/integrations/spanStreaming.ts
Comment threadpackages/core/test/integrations/spanStreaming.test.ts
Comment threadpackages/core/src/integrations/spanStreaming.ts
@mydea
mydeaforce-pushed the feat/share-span-streaming-integration branch from 023fef5 to 5f6ffb5CompareAugust 28, 2026 09:54

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reworking this!

Small positive side-effect for our tests: Span streaming tests should now run faster, given we flush way more quickly.

Comment threadpackages/core/src/integrations/spanStreaming.ts Outdated
Comment threadpackages/core/src/integrations/spanStreaming.ts Outdated

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 5f6ffb5. Configure here.


export declare const linkedErrorsIntegration: typeof clientSdk.linkedErrorsIntegration;
export declare const contextLinesIntegration: typeof clientSdk.contextLinesIntegration;
export declare const spanStreamingIntegration: typeof clientSdk.spanStreamingIntegration;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Types drop public integration export

Medium Severity

Removing the explicit spanStreamingIntegration re-export from framework index.types.ts files drops it from the public type surface. TypeScript export * from both client and server omits colliding names, so consumers of packages such as @sentry/astro and @sentry/nextjs can no longer import it. This is flagged because the review rules treat removal of a publicly exported function without a deprecation notice as a breaking change. The same explicit re-export is still required for other shared core symbols such as withStaticSpan.

Additional Locations (2)
Fix in CursorFix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

Reviewed by Cursor Bugbot for commit 5f6ffb5. Configure here.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine

mydeaand others added 7 commits August 31, 2026 09:45
… shared integration
The browser and server span streaming integrations only differed in their
eager-flush trigger, so collapse them into a single core integration
parameterized by a `flushOnSegmentEnd` option. The browser install site
(`browserSpanApi`) passes `{ flushOnSegmentEnd: true }`; the server side
(`ServerRuntimeClient`) keeps the same call and behavior.
The integration is now exported from `shared-exports` (a single shared symbol
across all entries) instead of being duplicated in `browser-exports` and
`server-exports`. Because both entries previously resolved to *different*
symbols, the name was an ambiguous star export that `index.ts` disambiguated
explicitly; now that it resolves to the same symbol, that explicit re-export
collided with the star exports and is removed.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The `flushOnSegmentEnd` 500ms `setTimeout` now lives in shared core code and
`flushOnSegmentEnd` is a public option, so enabling it on a Node runtime could
keep a process alive until the timer fires. Wrap it in `safeUnref` (as the
`SpanBuffer` already does for its own flush timer); it's a no-op in the browser,
where this is the default path.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mydeaand others added 2 commits August 31, 2026 09:45
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
@mydea
mydeaforce-pushed the feat/share-span-streaming-integration branch from 52c5e47 to 0265ccdCompareAugust 31, 2026 07:45
@mydea
mydea requested a review from a team as a code ownerAugust 31, 2026 07:45
@mydea
mydea requested review from JPeer264 and isaacs and removed request for a teamAugust 31, 2026 07:45
@mydea
mydea merged commit b42643f into developAug 31, 2026
282 of 283 checks passed
@mydea
mydea deleted the feat/share-span-streaming-integration branch August 31, 2026 08:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@Lms24
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(core): Always flush streamed span traces after segment end by default - #23714

Merged
mydea merged 9 commits into
developfrom
feat/share-span-streaming-integration
Aug 31, 2026
Merged

feat(core): Always flush streamed span traces after segment end by default#23714
mydea merged 9 commits into
developfrom
feat/share-span-streaming-integration

Conversation

@mydea

@mydeamydea commented Aug 28, 2026

Copy link
Copy Markdown
Member

The browser (browserSpanStreaming.ts) and server (spanStreaming.ts) span streaming integrations were near-identical: the afterSpanEnd buffering was byte-for-byte the same, and they only differed in the eager-flush trigger. This collapses them into a single core integration, and makes flushing a trace shortly after its segment span ends the default for all runtimes, browser and server alike.

Both install sites now call spanStreamingIntegration() with no arguments: browserSpanApi._INTERNAL_ensureBrowserSpanStreaming and ServerRuntimeClient share one behavior. A trace is flushed:

  • eagerly on flushTraceSpans (the Cloudflare drain),
  • 500ms after its segment span ends, and
  • otherwise on the SpanBuffer's own timeout/size thresholds.

Why default segment-end flushing on for the server too

Previously the server relied solely on the buffer thresholds and only the browser flushed on segment end, to avoid the server emitting more, smaller envelopes and to keep the browser's 500ms timer from holding the Node event loop open. The event-loop concern is already handled by safeUnref on the timer (a no-op in the browser), so there's no longer a reason to gate the segment-end path by runtime — flushing traces timely once their segment ends is the behavior we want everywhere.

The flushOnSegmentEnd option is retained (now defaulting to true) so a runtime can still opt out and fall back to threshold-only flushing.

Why keep it in core rather than moving to browser-utils/server-utils

The integrations are consumed internally by core — ServerRuntimeClient auto-adds it, and browserSpanApi/idleSpan auto-install it (a deliberate tree-shaking indirection). Since browser-utils and server-utils both depend on @sentry/core, core cannot import back from them without a circular dependency. Collapsing in-core sidesteps that entirely.

Export change

The integration now lives in shared-exports as a single shared symbol (star-exported by all entries) instead of being duplicated in browser-exports and server-exports. Previously the two entries resolved to different symbols, making the name an ambiguous star export that index.ts disambiguated with an explicit re-export. Now that both resolve to the same symbol, that explicit line collided with the star exports (leaving the root namespace undefined) and is removed. The startSpan/startInactiveSpan/startSpanManual disambiguation stays, as those remain genuinely distinct browser/server variants.

Comment threadpackages/core/src/integrations/spanStreaming.ts
Comment threadpackages/core/src/integrations/spanStreaming.ts Outdated
@github-actions

github-actionsBot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser28.56 kB--
@sentry/browser - with treeshaking flags26.92 kB--
@sentry/browser - with treeshaking flags tracing without tracing26.82 kB--
@sentry/browser (incl. Tracing)48.72 kB+0.09%+40 B 🔺
@sentry/browser (incl. Tracing + Span Streaming)48.74 kB+0.08%+36 B 🔺
@sentry/browser (incl. Tracing, Profiling)51.66 kB+0.08%+37 B 🔺
@sentry/browser (incl. Tracing, Replay)88.19 kB+0.05%+38 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags77.6 kB+0.06%+39 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)92.88 kB+0.04%+35 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)105.83 kB+0.04%+39 B 🔺
@sentry/browser (incl. Feedback)46.05 kB--
@sentry/browser (incl. sendFeedback)33.62 kB--
@sentry/browser (incl. FeedbackAsync)38.73 kB--
@sentry/browser (incl. Metrics)29.51 kB--
@sentry/browser (incl. Logs)29.8 kB--
@sentry/browser (incl. Metrics & Logs)30.43 kB--
@sentry/react30.3 kB--
@sentry/react (incl. Tracing)50.93 kB+0.07%+32 B 🔺
@sentry/vue35.73 kB+0.11%+39 B 🔺
@sentry/vue (incl. Tracing)50.97 kB+0.08%+38 B 🔺
@sentry/svelte28.59 kB--
CDN Bundle30.35 kB--
CDN Bundle (incl. Tracing)49.32 kB+0.06%+25 B 🔺
CDN Bundle (incl. Logs, Metrics)32.58 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)51.21 kB+0.06%+26 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)73.17 kB--
CDN Bundle (incl. Tracing, Replay)86.82 kB+0.04%+27 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)88.69 kB+0.03%+26 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)92.74 kB+0.03%+27 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)94.61 kB+0.03%+25 B 🔺
CDN Bundle - uncompressed89.95 kB--
CDN Bundle (incl. Tracing) - uncompressed147.05 kB+0.07%+89 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed96.24 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed152.74 kB+0.06%+89 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed225.41 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed266.55 kB+0.04%+89 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed272.22 kB+0.04%+89 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed280.25 kB+0.04%+89 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed285.92 kB+0.04%+89 B 🔺
@sentry/nextjs (client)53.5 kB+0.06%+28 B 🔺
@sentry/sveltekit (client)49.16 kB+0.06%+27 B 🔺
@sentry/core/server65.47 kB+0.04%+22 B 🔺
@sentry/core/browser51.87 kB+0.06%+29 B 🔺
@sentry/node123.25 kB+0.05%+52 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection)85.23 kB--
@sentry/node - without tracing87.75 kB+0.04%+27 B 🔺
@sentry/node - without channel injection102.92 kB+0.06%+59 B 🔺
@sentry/aws-serverless95.95 kB+0.08%+68 B 🔺
@sentry/cloudflare (withSentry) - minified200.65 kB+0.08%+143 B 🔺
@sentry/cloudflare (withSentry)499.13 kB+0.08%+367 B 🔺

View base workflow run

@mydea
mydea requested a review from Lms24August 28, 2026 07:42
Comment threadpackages/browser/src/integrations/browserSpanStreaming.ts Outdated
@mydea
mydea marked this pull request as ready for review August 28, 2026 08:42
@mydea
mydea requested a review from a team as a code ownerAugust 28, 2026 08:42
@mydea
mydea requested review from msonnb and removed request for a teamAugust 28, 2026 08:42
Comment threadpackages/browser/src/integrations/browserSpanStreaming.ts Outdated

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can do something better here which is what we decided on last week but I didn't have time to implement yet: Let's just always flush at segment end (with the delay), regardless of environment.

In Python, we already made that change after noticing that the 5s flushing interval accumulates a lot of memory in high-throughput environments. Since we make one request per trace anyway, the number of requests shouldn't be drastically higher.

That is, as long as we can expect that traces are generally well-formed (i.e. child spans ending before their segment span). For malformed traces, with long-running child spans we would increase the request count. I think this is a fine tradeoff IMHO.

If you have (or anyone else has) concerns about this, I'd prefer keeping the two integrations separate because the merge increases bundle size for the browser version. Which was the reason why I opted against combining them initially.

@mydea

Copy link
Copy Markdown
MemberAuthor

I think we can do something better here which is what we decided on last week but I didn't have time to implement yet: Let's just always flush at segment end (with the delay), regardless of environment.

In Python, we already made that change after noticing that the 5s flushing interval accumulates a lot of memory in high-throughput environments. Since we make one request per trace anyway, the number of requests shouldn't be drastically higher.

That is, as long as we can expect that traces are generally well-formed (i.e. child spans ending before their segment span). For malformed traces, with long-running child spans we would increase the request count. I think this is a fine tradeoff IMHO.

If you have (or anyone else has) concerns about this, I'd prefer keeping the two integrations separate because the merge increases bundle size for the browser version. Which was the reason why I opted against combining them initially.

sounds good to me, so I'll just change this so that the default for flushing is true I'd say, so you can still opt out?

@mydeamydea changed the title ref(core): Merge browser and server spanStreamingIntegration into one shared integrationfeat(core): Always flush streamed span traces after segment end by defaultAug 28, 2026
@mydea
mydeaforce-pushed the feat/share-span-streaming-integration branch from ea19f07 to 023fef5CompareAugust 28, 2026 09:45
@mydea
mydea requested a review from a team as a code ownerAugust 28, 2026 09:45
@mydea
mydea requested review from chargome and s1gr1d and removed request for a teamAugust 28, 2026 09:45
Comment threadpackages/core/src/integrations/spanStreaming.ts
Comment threadpackages/core/test/integrations/spanStreaming.test.ts
Comment threadpackages/core/src/integrations/spanStreaming.ts
@mydea
mydeaforce-pushed the feat/share-span-streaming-integration branch from 023fef5 to 5f6ffb5CompareAugust 28, 2026 09:54

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reworking this!

Small positive side-effect for our tests: Span streaming tests should now run faster, given we flush way more quickly.

Comment threadpackages/core/src/integrations/spanStreaming.ts Outdated
Comment threadpackages/core/src/integrations/spanStreaming.ts Outdated

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 5f6ffb5. Configure here.


export declare const linkedErrorsIntegration: typeof clientSdk.linkedErrorsIntegration;
export declare const contextLinesIntegration: typeof clientSdk.contextLinesIntegration;
export declare const spanStreamingIntegration: typeof clientSdk.spanStreamingIntegration;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Types drop public integration export

Medium Severity

Removing the explicit spanStreamingIntegration re-export from framework index.types.ts files drops it from the public type surface. TypeScript export * from both client and server omits colliding names, so consumers of packages such as @sentry/astro and @sentry/nextjs can no longer import it. This is flagged because the review rules treat removal of a publicly exported function without a deprecation notice as a breaking change. The same explicit re-export is still required for other shared core symbols such as withStaticSpan.

Additional Locations (2)
Fix in CursorFix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

Reviewed by Cursor Bugbot for commit 5f6ffb5. Configure here.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine

mydeaand others added 7 commits August 31, 2026 09:45
… shared integration
The browser and server span streaming integrations only differed in their
eager-flush trigger, so collapse them into a single core integration
parameterized by a `flushOnSegmentEnd` option. The browser install site
(`browserSpanApi`) passes `{ flushOnSegmentEnd: true }`; the server side
(`ServerRuntimeClient`) keeps the same call and behavior.
The integration is now exported from `shared-exports` (a single shared symbol
across all entries) instead of being duplicated in `browser-exports` and
`server-exports`. Because both entries previously resolved to *different*
symbols, the name was an ambiguous star export that `index.ts` disambiguated
explicitly; now that it resolves to the same symbol, that explicit re-export
collided with the star exports and is removed.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The `flushOnSegmentEnd` 500ms `setTimeout` now lives in shared core code and
`flushOnSegmentEnd` is a public option, so enabling it on a Node runtime could
keep a process alive until the timer fires. Wrap it in `safeUnref` (as the
`SpanBuffer` already does for its own flush timer); it's a no-op in the browser,
where this is the default path.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mydeaand others added 2 commits August 31, 2026 09:45
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
@mydea
mydeaforce-pushed the feat/share-span-streaming-integration branch from 52c5e47 to 0265ccdCompareAugust 31, 2026 07:45
@mydea
mydea requested a review from a team as a code ownerAugust 31, 2026 07:45
@mydea
mydea requested review from JPeer264 and isaacs and removed request for a teamAugust 31, 2026 07:45
@mydea
mydea merged commit b42643f into developAug 31, 2026
282 of 283 checks passed
@mydea
mydea deleted the feat/share-span-streaming-integration branch August 31, 2026 08:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@Lms24
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

feat(core): Always flush streamed span traces after segment end by default - #23714

Merged
mydea merged 9 commits into
developfrom
feat/share-span-streaming-integration
Aug 31, 2026
Merged

feat(core): Always flush streamed span traces after segment end by default#23714
mydea merged 9 commits into
developfrom
feat/share-span-streaming-integration

Conversation

@mydea

@mydeamydea commented Aug 28, 2026

Copy link
Copy Markdown
Member

The browser (browserSpanStreaming.ts) and server (spanStreaming.ts) span streaming integrations were near-identical: the afterSpanEnd buffering was byte-for-byte the same, and they only differed in the eager-flush trigger. This collapses them into a single core integration, and makes flushing a trace shortly after its segment span ends the default for all runtimes, browser and server alike.

Both install sites now call spanStreamingIntegration() with no arguments: browserSpanApi._INTERNAL_ensureBrowserSpanStreaming and ServerRuntimeClient share one behavior. A trace is flushed:

  • eagerly on flushTraceSpans (the Cloudflare drain),
  • 500ms after its segment span ends, and
  • otherwise on the SpanBuffer's own timeout/size thresholds.

Why default segment-end flushing on for the server too

Previously the server relied solely on the buffer thresholds and only the browser flushed on segment end, to avoid the server emitting more, smaller envelopes and to keep the browser's 500ms timer from holding the Node event loop open. The event-loop concern is already handled by safeUnref on the timer (a no-op in the browser), so there's no longer a reason to gate the segment-end path by runtime — flushing traces timely once their segment ends is the behavior we want everywhere.

The flushOnSegmentEnd option is retained (now defaulting to true) so a runtime can still opt out and fall back to threshold-only flushing.

Why keep it in core rather than moving to browser-utils/server-utils

The integrations are consumed internally by core — ServerRuntimeClient auto-adds it, and browserSpanApi/idleSpan auto-install it (a deliberate tree-shaking indirection). Since browser-utils and server-utils both depend on @sentry/core, core cannot import back from them without a circular dependency. Collapsing in-core sidesteps that entirely.

Export change

The integration now lives in shared-exports as a single shared symbol (star-exported by all entries) instead of being duplicated in browser-exports and server-exports. Previously the two entries resolved to different symbols, making the name an ambiguous star export that index.ts disambiguated with an explicit re-export. Now that both resolve to the same symbol, that explicit line collided with the star exports (leaving the root namespace undefined) and is removed. The startSpan/startInactiveSpan/startSpanManual disambiguation stays, as those remain genuinely distinct browser/server variants.

Comment threadpackages/core/src/integrations/spanStreaming.ts
Comment threadpackages/core/src/integrations/spanStreaming.ts Outdated
@github-actions

github-actionsBot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser28.56 kB--
@sentry/browser - with treeshaking flags26.92 kB--
@sentry/browser - with treeshaking flags tracing without tracing26.82 kB--
@sentry/browser (incl. Tracing)48.72 kB+0.09%+40 B 🔺
@sentry/browser (incl. Tracing + Span Streaming)48.74 kB+0.08%+36 B 🔺
@sentry/browser (incl. Tracing, Profiling)51.66 kB+0.08%+37 B 🔺
@sentry/browser (incl. Tracing, Replay)88.19 kB+0.05%+38 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags77.6 kB+0.06%+39 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)92.88 kB+0.04%+35 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)105.83 kB+0.04%+39 B 🔺
@sentry/browser (incl. Feedback)46.05 kB--
@sentry/browser (incl. sendFeedback)33.62 kB--
@sentry/browser (incl. FeedbackAsync)38.73 kB--
@sentry/browser (incl. Metrics)29.51 kB--
@sentry/browser (incl. Logs)29.8 kB--
@sentry/browser (incl. Metrics & Logs)30.43 kB--
@sentry/react30.3 kB--
@sentry/react (incl. Tracing)50.93 kB+0.07%+32 B 🔺
@sentry/vue35.73 kB+0.11%+39 B 🔺
@sentry/vue (incl. Tracing)50.97 kB+0.08%+38 B 🔺
@sentry/svelte28.59 kB--
CDN Bundle30.35 kB--
CDN Bundle (incl. Tracing)49.32 kB+0.06%+25 B 🔺
CDN Bundle (incl. Logs, Metrics)32.58 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)51.21 kB+0.06%+26 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)73.17 kB--
CDN Bundle (incl. Tracing, Replay)86.82 kB+0.04%+27 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)88.69 kB+0.03%+26 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)92.74 kB+0.03%+27 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)94.61 kB+0.03%+25 B 🔺
CDN Bundle - uncompressed89.95 kB--
CDN Bundle (incl. Tracing) - uncompressed147.05 kB+0.07%+89 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed96.24 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed152.74 kB+0.06%+89 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed225.41 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed266.55 kB+0.04%+89 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed272.22 kB+0.04%+89 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed280.25 kB+0.04%+89 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed285.92 kB+0.04%+89 B 🔺
@sentry/nextjs (client)53.5 kB+0.06%+28 B 🔺
@sentry/sveltekit (client)49.16 kB+0.06%+27 B 🔺
@sentry/core/server65.47 kB+0.04%+22 B 🔺
@sentry/core/browser51.87 kB+0.06%+29 B 🔺
@sentry/node123.25 kB+0.05%+52 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection)85.23 kB--
@sentry/node - without tracing87.75 kB+0.04%+27 B 🔺
@sentry/node - without channel injection102.92 kB+0.06%+59 B 🔺
@sentry/aws-serverless95.95 kB+0.08%+68 B 🔺
@sentry/cloudflare (withSentry) - minified200.65 kB+0.08%+143 B 🔺
@sentry/cloudflare (withSentry)499.13 kB+0.08%+367 B 🔺

View base workflow run

@mydea
mydea requested a review from Lms24August 28, 2026 07:42
Comment threadpackages/browser/src/integrations/browserSpanStreaming.ts Outdated
@mydea
mydea marked this pull request as ready for review August 28, 2026 08:42
@mydea
mydea requested a review from a team as a code ownerAugust 28, 2026 08:42
@mydea
mydea requested review from msonnb and removed request for a teamAugust 28, 2026 08:42
Comment threadpackages/browser/src/integrations/browserSpanStreaming.ts Outdated

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can do something better here which is what we decided on last week but I didn't have time to implement yet: Let's just always flush at segment end (with the delay), regardless of environment.

In Python, we already made that change after noticing that the 5s flushing interval accumulates a lot of memory in high-throughput environments. Since we make one request per trace anyway, the number of requests shouldn't be drastically higher.

That is, as long as we can expect that traces are generally well-formed (i.e. child spans ending before their segment span). For malformed traces, with long-running child spans we would increase the request count. I think this is a fine tradeoff IMHO.

If you have (or anyone else has) concerns about this, I'd prefer keeping the two integrations separate because the merge increases bundle size for the browser version. Which was the reason why I opted against combining them initially.

@mydea

Copy link
Copy Markdown
MemberAuthor

I think we can do something better here which is what we decided on last week but I didn't have time to implement yet: Let's just always flush at segment end (with the delay), regardless of environment.

In Python, we already made that change after noticing that the 5s flushing interval accumulates a lot of memory in high-throughput environments. Since we make one request per trace anyway, the number of requests shouldn't be drastically higher.

That is, as long as we can expect that traces are generally well-formed (i.e. child spans ending before their segment span). For malformed traces, with long-running child spans we would increase the request count. I think this is a fine tradeoff IMHO.

If you have (or anyone else has) concerns about this, I'd prefer keeping the two integrations separate because the merge increases bundle size for the browser version. Which was the reason why I opted against combining them initially.

sounds good to me, so I'll just change this so that the default for flushing is true I'd say, so you can still opt out?

@mydeamydea changed the title ref(core): Merge browser and server spanStreamingIntegration into one shared integrationfeat(core): Always flush streamed span traces after segment end by defaultAug 28, 2026
@mydea
mydeaforce-pushed the feat/share-span-streaming-integration branch from ea19f07 to 023fef5CompareAugust 28, 2026 09:45
@mydea
mydea requested a review from a team as a code ownerAugust 28, 2026 09:45
@mydea
mydea requested review from chargome and s1gr1d and removed request for a teamAugust 28, 2026 09:45
Comment threadpackages/core/src/integrations/spanStreaming.ts
Comment threadpackages/core/test/integrations/spanStreaming.test.ts
Comment threadpackages/core/src/integrations/spanStreaming.ts
@mydea
mydeaforce-pushed the feat/share-span-streaming-integration branch from 023fef5 to 5f6ffb5CompareAugust 28, 2026 09:54

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reworking this!

Small positive side-effect for our tests: Span streaming tests should now run faster, given we flush way more quickly.

Comment threadpackages/core/src/integrations/spanStreaming.ts Outdated
Comment threadpackages/core/src/integrations/spanStreaming.ts Outdated

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 5f6ffb5. Configure here.


export declare const linkedErrorsIntegration: typeof clientSdk.linkedErrorsIntegration;
export declare const contextLinesIntegration: typeof clientSdk.contextLinesIntegration;
export declare const spanStreamingIntegration: typeof clientSdk.spanStreamingIntegration;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Types drop public integration export

Medium Severity

Removing the explicit spanStreamingIntegration re-export from framework index.types.ts files drops it from the public type surface. TypeScript export * from both client and server omits colliding names, so consumers of packages such as @sentry/astro and @sentry/nextjs can no longer import it. This is flagged because the review rules treat removal of a publicly exported function without a deprecation notice as a breaking change. The same explicit re-export is still required for other shared core symbols such as withStaticSpan.

Additional Locations (2)
Fix in CursorFix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

Reviewed by Cursor Bugbot for commit 5f6ffb5. Configure here.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine

mydeaand others added 7 commits August 31, 2026 09:45
… shared integration
The browser and server span streaming integrations only differed in their
eager-flush trigger, so collapse them into a single core integration
parameterized by a `flushOnSegmentEnd` option. The browser install site
(`browserSpanApi`) passes `{ flushOnSegmentEnd: true }`; the server side
(`ServerRuntimeClient`) keeps the same call and behavior.
The integration is now exported from `shared-exports` (a single shared symbol
across all entries) instead of being duplicated in `browser-exports` and
`server-exports`. Because both entries previously resolved to *different*
symbols, the name was an ambiguous star export that `index.ts` disambiguated
explicitly; now that it resolves to the same symbol, that explicit re-export
collided with the star exports and is removed.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The `flushOnSegmentEnd` 500ms `setTimeout` now lives in shared core code and
`flushOnSegmentEnd` is a public option, so enabling it on a Node runtime could
keep a process alive until the timer fires. Wrap it in `safeUnref` (as the
`SpanBuffer` already does for its own flush timer); it's a no-op in the browser,
where this is the default path.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mydeaand others added 2 commits August 31, 2026 09:45
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
@mydea
mydeaforce-pushed the feat/share-span-streaming-integration branch from 52c5e47 to 0265ccdCompareAugust 31, 2026 07:45
@mydea
mydea requested a review from a team as a code ownerAugust 31, 2026 07:45
@mydea
mydea requested review from JPeer264 and isaacs and removed request for a teamAugust 31, 2026 07:45
@mydea
mydea merged commit b42643f into developAug 31, 2026
282 of 283 checks passed
@mydea
mydea deleted the feat/share-span-streaming-integration branch August 31, 2026 08:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@Lms24