Uh oh!
There was an error while loading. Please reload this page.
test(e2e): Port Next.js routing test apps to span streaming - #23797
Merged
Conversation
Moves nextjs-15-basepath, nextjs-15-intl and nextjs-16-trailing-slash off the static trace lifecycle and rewrites their assertions to span v2. Ref #23513 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
andreiborzaforce-pushed
the
ab/port-nextjs-routing-e2e-to-span-streaming
branch
from
September 1, 2026 07:47
189b7ed to
309501bCompareContributor
size-limit report 📦
|
andreiborza
marked this pull request as ready for review
September 1, 2026 08:55
msonnb
approved these changes
Sep 1, 2026
chargome
approved these changes
Sep 1, 2026
This was referenced Sep 1, 2026
Uh oh!
There was an error while loading. Please reload this page.
andreiborza added a commit
that referenced
this pull request
Sep 1, 2026
) ## What Adds `nextjs-16-trailing-slash-static`, a copy of `nextjs-16-trailing-slash` as it stood before #23797 ported it to span streaming, so the static trace lifecycle keeps end-to-end coverage for this group. - The copy keeps the `traceLifecycle: 'static'` pins and the transaction-based specs; only the app name changes. - Its `latest, turbopack` variant is dropped, so it adds one CI row rather than two. That dimension is already covered by the streamed app. - `next` is pinned to `16.2.11` rather than the `16.2.3` the original uses. A new `package.json` makes every dependency count as added, so dependency review evaluates advisories it never re-checks on the existing app. `16.2.11` is the first release clearing all high-severity Next.js advisories. ## Why Streaming is the default now, but static is still a supported trace lifecycle and nothing would catch a regression in it once each group moves over. `nextjs-16-trailing-slash` is the representative for the Next.js client routing group because it covers static, parameterized, nested static, catch-all and home routes. Ref #23513 --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Ports the three Next.js client-routing E2E apps (
nextjs-15-basepath,nextjs-15-intl,nextjs-16-trailing-slash) to span streaming: thetraceLifecycle: 'static'pin from #22590 is removed and the specs now assert on streamed spans instead of transactions.Why
Span streaming is the default, so the default E2E suite should exercise it. This is the first slice of #23513; these three apps were picked because they are near-identical and cover pageload and navigation route parameterization, which is where span naming changed.
Closes: #23816