Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
import * as Sentry from '@sentry/nextjs';

// Only `test` is prerendered at build time. `exception` and `message` are generated
// on-demand at request time.
export function generateStaticParams() {
return [{ id: 'test' }];
}

export default async function Page({ params }: { params: Promise<{ id: string }> }) {
const { id } = await params;

if (id === 'exception') {
Sentry.captureException(new Error('Test error from cache components page'));
return <p id="result">Error captured for id exception</p>;
}

if (id === 'message') {
Sentry.captureMessage('Test message from cache components page');
return <p id="result">Message captured for id message</p>;
}

return <p id="result">Hello, {id}!</p>;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
export async function GET() {
return Response.json({ value: 'hanging-fetch-data' });
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
import { captureException } from '@sentry/nextjs';
import type { Metadata } from 'next';

/**
* Calling captureException synchronously inside generateMetadata
* during `next build` prerender (cacheComponents). uuid4 -> crypto.randomUUID() runs
*/
export const generateMetadata = (): Metadata => {
captureException(new Error('diagnostic: data missing for this page'));
return { title: 'capture-metadata' };
};

export default function Page() {
return <h1>capture-metadata</h1>;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
export default function Loading() {
return <div id="sentinel-loading">Loading...</div>;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
import * as Sentry from '@sentry/nextjs';

// Captures an error tagged with a caller-supplied unique token. Tests use this as a drain marker: the
// token guarantees a cache miss, so the capture always happens on request, and its arrival proves the
// event pipeline has drained past every earlier request.
export default async function Page({ params }: { params: Promise<{ token: string }> }) {
const { token } = await params;

Sentry.captureException(new Error(`error-sentinel-${token}`));

return <p id="sentinel">{token}</p>;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
export default function Loading() {
return <div id="loading">Loading...</div>;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
// This `fetch()` deliberately has no cache configuration. Under Cache Components, Next.js does not
// issue such a request during a prerender - it hands out a promise that never settles and rejects it
// with a `HANGING_PROMISE_REJECTION` digest once the prerender is aborted. That rejection surfaces in
// this component and therefore in the Sentry server component wrapper, which must not report it.
export default async function Page() {
const response = await fetch('http://localhost:3030/api/hanging-fetch-data');
const data = (await response.json()) as { value: string };

return <p id="fetched-value">{data.value}</p>;
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -46,6 +46,12 @@
"extends": "../../package.json"
},
"sentryTest": {
"//": "TODO: Add variants for webpack once supported"
"variants": [
{
"build-command": "pnpm test:build-webpack",
"label": "nextjs-16-streaming-cacheComponents (webpack)",
"assert-command": "pnpm test:assert-webpack"
}
]
}
}
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { expect, test } from '@playwright/test';
import { waitForStreamedSpan, waitForStreamedSpans, getSpanOp } from '@sentry-internal/test-utils';
import { getSpanOp, waitForError, waitForStreamedSpan, waitForStreamedSpans } from '@sentry-internal/test-utils';

test('Should render cached component', async ({ page }) => {
const spansPromise = waitForStreamedSpans('nextjs-16-streaming-cacheComponents', spans => {
Expand DownExpand Up@@ -49,6 +49,34 @@ test('Should generate metadata', async ({ page }) => {
await expect(page).toHaveTitle('Cache Components Metadata Test');
});

// Capturing an event inside a Server Component that is (re)generated at request time must not
// trip Next.js Cache Components prerender guards (`new Date()` / `crypto`).
test('Should capture an exception from an on-demand generated Server Component', async ({ page }) => {
const errorPromise = waitForError('nextjs-16-streaming-cacheComponents', errorEvent => {
return errorEvent.exception?.values?.[0]?.value === 'Test error from cache components page';
});

await page.goto('/exception');

await expect(page.locator('#result')).toHaveText('Error captured for id exception');

const error = await errorPromise;
expect(error.exception?.values?.[0]?.value).toBe('Test error from cache components page');
});

test('Should capture a message from an on-demand generated Server Component', async ({ page }) => {
const messagePromise = waitForError('nextjs-16-streaming-cacheComponents', errorEvent => {
return errorEvent.message === 'Test message from cache components page';
});

await page.goto('/message');

await expect(page.locator('#result')).toHaveText('Message captured for id message');

const message = await messagePromise;
expect(message.message).toBe('Test message from cache components page');
});

test('Should generate metadata async', async ({ page }) => {
const spansPromise = waitForStreamedSpans('nextjs-16-streaming-cacheComponents', spans => {
return spans.some(
Expand DownExpand Up@@ -96,3 +124,10 @@ test('Prerendered shell does not stitch the pageload onto a stale trace', async
expect(await page.locator('meta[name="sentry-trace"]').count()).toBe(0);
expect(await page.locator('meta[name="baggage"]').count()).toBe(0);
});

test('Should prerender a page that captures an exception in generateMetadata', async ({ page }) => {
await page.goto('/capture-metadata');

await expect(page).toHaveTitle('capture-metadata');
await expect(page.locator('h1')).toHaveText('capture-metadata');
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,55 @@
import { expect, test } from '@playwright/test';
import { getSpanOp, waitForError, waitForStreamedSpan } from '@sentry-internal/test-utils';

const HANGING_PROMISE_DIGEST_MESSAGE = 'rejects when the prerender is complete';

// Under Cache Components, Next.js aborts prerenders by rejecting the promises it handed out for
// uncached `fetch()` calls. React discards those rejections - they never affect the response - so the
// Sentry wrappers must not report them. See https://github.com/getsentry/sentry-javascript/issues/23592
//
// Note this only exercises the regression under the webpack variant: server components are wrapped by
// `wrappingLoader`, which Turbopack builds do not run, so there is no wrapper to observe the rejection
// there. Under Turbopack the test still asserts the route renders and reports no errors.
test('does not capture hanging prerender promise rejections on a runtime prefetch', async ({ page, request }) => {
const capturedHangingPromiseErrors: string[] = [];
void waitForError('nextjs-16-streaming-cacheComponents', errorEvent => {
const value = errorEvent.exception?.values?.[0]?.value ?? '';
if (value.includes(HANGING_PROMISE_DIGEST_MESSAGE)) {
capturedHangingPromiseErrors.push(value);
}
return false;
});

// `Next-Router-Prefetch: 2` is what the Next.js router sends for a runtime prefetch. It makes Next.js
// run a prerender at request time, which is what produces the hanging promise rejection. A plain
// document request only replays the shell that was prerendered at build time and would not trigger it.
const prefetchResponse = await request.get('/hanging-fetch', {
headers: { RSC: '1', 'Next-Router-Prefetch': '2' },
});
expect(prefetchResponse.ok()).toBe(true);

const serverSpanPromise = waitForStreamedSpan('nextjs-16-streaming-cacheComponents', span => {
return span.name === 'GET /hanging-fetch' && getSpanOp(span) === 'http.server' && span.is_segment;
});

await page.goto('/hanging-fetch');
await expect(page.locator('#fetched-value')).toHaveText('hanging-fetch-data');

expect(await serverSpanPromise).toBeDefined();

// Drain marker instead of a sleep: request a route that deliberately captures an error, tagged with a
// token unique to this run so it can never be served from cache. It is requested strictly after the
// prefetch, and the SDK flushes per request, so once this error arrives any error the prefetch had
// captured must already have arrived too. That makes the assertion below "nothing was captured"
// rather than "nothing had been captured yet". It doubles as a check that errors do flow at all.
const token = `${Date.now()}`;
const sentinelPromise = waitForError('nextjs-16-streaming-cacheComponents', errorEvent => {
return errorEvent.exception?.values?.[0]?.value === `error-sentinel-${token}`;
});

await page.goto(`/error-sentinel/${token}`);
await expect(page.locator('#sentinel')).toHaveText(token);
await sentinelPromise;

expect(capturedHangingPromiseErrors).toEqual([]);
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
import * as Sentry from '@sentry/nextjs';

// Only `test` is prerendered at build time. `exception` and `message` are generated
// on-demand at request time.
export function generateStaticParams() {
return [{ id: 'test' }];
}

export default async function Page({ params }: { params: Promise<{ id: string }> }) {
const { id } = await params;

if (id === 'exception') {
Sentry.captureException(new Error('Test error from cache components page'));
return <p id="result">Error captured for id exception</p>;
}

if (id === 'message') {
Sentry.captureMessage('Test message from cache components page');
return <p id="result">Message captured for id message</p>;
}

return <p id="result">Hello, {id}!</p>;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
export async function GET() {
return Response.json({ value: 'hanging-fetch-data' });
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
import { captureException } from '@sentry/nextjs';
import type { Metadata } from 'next';

/**
* Calling captureException synchronously inside generateMetadata
* during `next build` prerender (cacheComponents). uuid4 -> crypto.randomUUID() runs
*/
export const generateMetadata = (): Metadata => {
captureException(new Error('diagnostic: data missing for this page'));
return { title: 'capture-metadata' };
};

export default function Page() {
return <h1>capture-metadata</h1>;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
export default function Loading() {
return <div id="sentinel-loading">Loading...</div>;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
import * as Sentry from '@sentry/nextjs';

// Captures an error tagged with a caller-supplied unique token. Tests use this as a drain marker: the
// token guarantees a cache miss, so the capture always happens on request, and its arrival proves the
// event pipeline has drained past every earlier request.
export default async function Page({ params }: { params: Promise<{ token: string }> }) {
const { token } = await params;

Sentry.captureException(new Error(`error-sentinel-${token}`));

return <p id="sentinel">{token}</p>;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
export default function Loading() {
return <div id="loading">Loading...</div>;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
// This `fetch()` deliberately has no cache configuration. Under Cache Components, Next.js does not
// issue such a request during a prerender - it hands out a promise that never settles and rejects it
// with a `HANGING_PROMISE_REJECTION` digest once the prerender is aborted. That rejection surfaces in
// this component and therefore in the Sentry server component wrapper, which must not report it.
export default async function Page() {
const response = await fetch('http://localhost:3030/api/hanging-fetch-data');
const data = (await response.json()) as { value: string };

return <p id="fetched-value">{data.value}</p>;
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -46,6 +46,12 @@
"extends": "../../package.json"
},
"sentryTest": {
"//": "TODO: Add variants for webpack once supported"
"variants": [
{
"build-command": "pnpm test:build-webpack",
"label": "nextjs-16-streaming-cacheComponents (webpack)",
"assert-command": "pnpm test:assert-webpack"
}
]
}
}
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { expect, test } from '@playwright/test';
import { waitForStreamedSpan, waitForStreamedSpans, getSpanOp } from '@sentry-internal/test-utils';
import { getSpanOp, waitForError, waitForStreamedSpan, waitForStreamedSpans } from '@sentry-internal/test-utils';

test('Should render cached component', async ({ page }) => {
const spansPromise = waitForStreamedSpans('nextjs-16-streaming-cacheComponents', spans => {
Expand DownExpand Up@@ -49,6 +49,34 @@ test('Should generate metadata', async ({ page }) => {
await expect(page).toHaveTitle('Cache Components Metadata Test');
});

// Capturing an event inside a Server Component that is (re)generated at request time must not
// trip Next.js Cache Components prerender guards (`new Date()` / `crypto`).
test('Should capture an exception from an on-demand generated Server Component', async ({ page }) => {
const errorPromise = waitForError('nextjs-16-streaming-cacheComponents', errorEvent => {
return errorEvent.exception?.values?.[0]?.value === 'Test error from cache components page';
});

await page.goto('/exception');

await expect(page.locator('#result')).toHaveText('Error captured for id exception');

const error = await errorPromise;
expect(error.exception?.values?.[0]?.value).toBe('Test error from cache components page');
});

test('Should capture a message from an on-demand generated Server Component', async ({ page }) => {
const messagePromise = waitForError('nextjs-16-streaming-cacheComponents', errorEvent => {
return errorEvent.message === 'Test message from cache components page';
});

await page.goto('/message');

await expect(page.locator('#result')).toHaveText('Message captured for id message');

const message = await messagePromise;
expect(message.message).toBe('Test message from cache components page');
});

test('Should generate metadata async', async ({ page }) => {
const spansPromise = waitForStreamedSpans('nextjs-16-streaming-cacheComponents', spans => {
return spans.some(
Expand DownExpand Up@@ -96,3 +124,10 @@ test('Prerendered shell does not stitch the pageload onto a stale trace', async
expect(await page.locator('meta[name="sentry-trace"]').count()).toBe(0);
expect(await page.locator('meta[name="baggage"]').count()).toBe(0);
});

test('Should prerender a page that captures an exception in generateMetadata', async ({ page }) => {
await page.goto('/capture-metadata');

await expect(page).toHaveTitle('capture-metadata');
await expect(page.locator('h1')).toHaveText('capture-metadata');
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,55 @@
import { expect, test } from '@playwright/test';
import { getSpanOp, waitForError, waitForStreamedSpan } from '@sentry-internal/test-utils';

const HANGING_PROMISE_DIGEST_MESSAGE = 'rejects when the prerender is complete';

// Under Cache Components, Next.js aborts prerenders by rejecting the promises it handed out for
// uncached `fetch()` calls. React discards those rejections - they never affect the response - so the
// Sentry wrappers must not report them. See https://github.com/getsentry/sentry-javascript/issues/23592
//
// Note this only exercises the regression under the webpack variant: server components are wrapped by
// `wrappingLoader`, which Turbopack builds do not run, so there is no wrapper to observe the rejection
// there. Under Turbopack the test still asserts the route renders and reports no errors.
test('does not capture hanging prerender promise rejections on a runtime prefetch', async ({ page, request }) => {
const capturedHangingPromiseErrors: string[] = [];
void waitForError('nextjs-16-streaming-cacheComponents', errorEvent => {
const value = errorEvent.exception?.values?.[0]?.value ?? '';
if (value.includes(HANGING_PROMISE_DIGEST_MESSAGE)) {
capturedHangingPromiseErrors.push(value);
}
return false;
});

// `Next-Router-Prefetch: 2` is what the Next.js router sends for a runtime prefetch. It makes Next.js
// run a prerender at request time, which is what produces the hanging promise rejection. A plain
// document request only replays the shell that was prerendered at build time and would not trigger it.
const prefetchResponse = await request.get('/hanging-fetch', {
headers: { RSC: '1', 'Next-Router-Prefetch': '2' },
});
expect(prefetchResponse.ok()).toBe(true);

const serverSpanPromise = waitForStreamedSpan('nextjs-16-streaming-cacheComponents', span => {
return span.name === 'GET /hanging-fetch' && getSpanOp(span) === 'http.server' && span.is_segment;
});

await page.goto('/hanging-fetch');
await expect(page.locator('#fetched-value')).toHaveText('hanging-fetch-data');

expect(await serverSpanPromise).toBeDefined();

// Drain marker instead of a sleep: request a route that deliberately captures an error, tagged with a
// token unique to this run so it can never be served from cache. It is requested strictly after the
// prefetch, and the SDK flushes per request, so once this error arrives any error the prefetch had
// captured must already have arrived too. That makes the assertion below "nothing was captured"
// rather than "nothing had been captured yet". It doubles as a check that errors do flow at all.
const token = `${Date.now()}`;
const sentinelPromise = waitForError('nextjs-16-streaming-cacheComponents', errorEvent => {
return errorEvent.exception?.values?.[0]?.value === `error-sentinel-${token}`;
});

await page.goto(`/error-sentinel/${token}`);
await expect(page.locator('#sentinel')).toHaveText(token);
await sentinelPromise;

expect(capturedHangingPromiseErrors).toEqual([]);
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
import * as Sentry from '@sentry/nextjs';

// Only `test` is prerendered at build time. `exception` and `message` are generated
// on-demand at request time.
export function generateStaticParams() {
return [{ id: 'test' }];
}

export default async function Page({ params }: { params: Promise<{ id: string }> }) {
const { id } = await params;

if (id === 'exception') {
Sentry.captureException(new Error('Test error from cache components page'));
return <p id="result">Error captured for id exception</p>;
}

if (id === 'message') {
Sentry.captureMessage('Test message from cache components page');
return <p id="result">Message captured for id message</p>;
}

return <p id="result">Hello, {id}!</p>;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
export async function GET() {
return Response.json({ value: 'hanging-fetch-data' });
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
import { captureException } from '@sentry/nextjs';
import type { Metadata } from 'next';

/**
* Calling captureException synchronously inside generateMetadata
* during `next build` prerender (cacheComponents). uuid4 -> crypto.randomUUID() runs
*/
export const generateMetadata = (): Metadata => {
captureException(new Error('diagnostic: data missing for this page'));
return { title: 'capture-metadata' };
};

export default function Page() {
return <h1>capture-metadata</h1>;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
export default function Loading() {
return <div id="sentinel-loading">Loading...</div>;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
import * as Sentry from '@sentry/nextjs';

// Captures an error tagged with a caller-supplied unique token. Tests use this as a drain marker: the
// token guarantees a cache miss, so the capture always happens on request, and its arrival proves the
// event pipeline has drained past every earlier request.
export default async function Page({ params }: { params: Promise<{ token: string }> }) {
const { token } = await params;

Sentry.captureException(new Error(`error-sentinel-${token}`));

return <p id="sentinel">{token}</p>;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
export default function Loading() {
return <div id="loading">Loading...</div>;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
// This `fetch()` deliberately has no cache configuration. Under Cache Components, Next.js does not
// issue such a request during a prerender - it hands out a promise that never settles and rejects it
// with a `HANGING_PROMISE_REJECTION` digest once the prerender is aborted. That rejection surfaces in
// this component and therefore in the Sentry server component wrapper, which must not report it.
export default async function Page() {
const response = await fetch('http://localhost:3030/api/hanging-fetch-data');
const data = (await response.json()) as { value: string };

return <p id="fetched-value">{data.value}</p>;
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -46,6 +46,12 @@
"extends": "../../package.json"
},
"sentryTest": {
"//": "TODO: Add variants for webpack once supported"
"variants": [
{
"build-command": "pnpm test:build-webpack",
"label": "nextjs-16-streaming-cacheComponents (webpack)",
"assert-command": "pnpm test:assert-webpack"
}
]
}
}
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { expect, test } from '@playwright/test';
import { waitForStreamedSpan, waitForStreamedSpans, getSpanOp } from '@sentry-internal/test-utils';
import { getSpanOp, waitForError, waitForStreamedSpan, waitForStreamedSpans } from '@sentry-internal/test-utils';

test('Should render cached component', async ({ page }) => {
const spansPromise = waitForStreamedSpans('nextjs-16-streaming-cacheComponents', spans => {
Expand DownExpand Up@@ -49,6 +49,34 @@ test('Should generate metadata', async ({ page }) => {
await expect(page).toHaveTitle('Cache Components Metadata Test');
});

// Capturing an event inside a Server Component that is (re)generated at request time must not
// trip Next.js Cache Components prerender guards (`new Date()` / `crypto`).
test('Should capture an exception from an on-demand generated Server Component', async ({ page }) => {
const errorPromise = waitForError('nextjs-16-streaming-cacheComponents', errorEvent => {
return errorEvent.exception?.values?.[0]?.value === 'Test error from cache components page';
});

await page.goto('/exception');

await expect(page.locator('#result')).toHaveText('Error captured for id exception');

const error = await errorPromise;
expect(error.exception?.values?.[0]?.value).toBe('Test error from cache components page');
});

test('Should capture a message from an on-demand generated Server Component', async ({ page }) => {
const messagePromise = waitForError('nextjs-16-streaming-cacheComponents', errorEvent => {
return errorEvent.message === 'Test message from cache components page';
});

await page.goto('/message');

await expect(page.locator('#result')).toHaveText('Message captured for id message');

const message = await messagePromise;
expect(message.message).toBe('Test message from cache components page');
});

test('Should generate metadata async', async ({ page }) => {
const spansPromise = waitForStreamedSpans('nextjs-16-streaming-cacheComponents', spans => {
return spans.some(
Expand DownExpand Up@@ -96,3 +124,10 @@ test('Prerendered shell does not stitch the pageload onto a stale trace', async
expect(await page.locator('meta[name="sentry-trace"]').count()).toBe(0);
expect(await page.locator('meta[name="baggage"]').count()).toBe(0);
});

test('Should prerender a page that captures an exception in generateMetadata', async ({ page }) => {
await page.goto('/capture-metadata');

await expect(page).toHaveTitle('capture-metadata');
await expect(page.locator('h1')).toHaveText('capture-metadata');
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,55 @@
import { expect, test } from '@playwright/test';
import { getSpanOp, waitForError, waitForStreamedSpan } from '@sentry-internal/test-utils';

const HANGING_PROMISE_DIGEST_MESSAGE = 'rejects when the prerender is complete';

// Under Cache Components, Next.js aborts prerenders by rejecting the promises it handed out for
// uncached `fetch()` calls. React discards those rejections - they never affect the response - so the
// Sentry wrappers must not report them. See https://github.com/getsentry/sentry-javascript/issues/23592
//
// Note this only exercises the regression under the webpack variant: server components are wrapped by
// `wrappingLoader`, which Turbopack builds do not run, so there is no wrapper to observe the rejection
// there. Under Turbopack the test still asserts the route renders and reports no errors.
test('does not capture hanging prerender promise rejections on a runtime prefetch', async ({ page, request }) => {
const capturedHangingPromiseErrors: string[] = [];
void waitForError('nextjs-16-streaming-cacheComponents', errorEvent => {
const value = errorEvent.exception?.values?.[0]?.value ?? '';
if (value.includes(HANGING_PROMISE_DIGEST_MESSAGE)) {
capturedHangingPromiseErrors.push(value);
}
return false;
});

// `Next-Router-Prefetch: 2` is what the Next.js router sends for a runtime prefetch. It makes Next.js
// run a prerender at request time, which is what produces the hanging promise rejection. A plain
// document request only replays the shell that was prerendered at build time and would not trigger it.
const prefetchResponse = await request.get('/hanging-fetch', {
headers: { RSC: '1', 'Next-Router-Prefetch': '2' },
});
expect(prefetchResponse.ok()).toBe(true);

const serverSpanPromise = waitForStreamedSpan('nextjs-16-streaming-cacheComponents', span => {
return span.name === 'GET /hanging-fetch' && getSpanOp(span) === 'http.server' && span.is_segment;
});

await page.goto('/hanging-fetch');
await expect(page.locator('#fetched-value')).toHaveText('hanging-fetch-data');

expect(await serverSpanPromise).toBeDefined();

// Drain marker instead of a sleep: request a route that deliberately captures an error, tagged with a
// token unique to this run so it can never be served from cache. It is requested strictly after the
// prefetch, and the SDK flushes per request, so once this error arrives any error the prefetch had
// captured must already have arrived too. That makes the assertion below "nothing was captured"
// rather than "nothing had been captured yet". It doubles as a check that errors do flow at all.
const token = `${Date.now()}`;
const sentinelPromise = waitForError('nextjs-16-streaming-cacheComponents', errorEvent => {
return errorEvent.exception?.values?.[0]?.value === `error-sentinel-${token}`;
});

await page.goto(`/error-sentinel/${token}`);
await expect(page.locator('#sentinel')).toHaveText(token);
await sentinelPromise;

expect(capturedHangingPromiseErrors).toEqual([]);
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
import * as Sentry from '@sentry/nextjs';

// Only `test` is prerendered at build time. `exception` and `message` are generated
// on-demand at request time.
export function generateStaticParams() {
return [{ id: 'test' }];
}

export default async function Page({ params }: { params: Promise<{ id: string }> }) {
const { id } = await params;

if (id === 'exception') {
Sentry.captureException(new Error('Test error from cache components page'));
return <p id="result">Error captured for id exception</p>;
}

if (id === 'message') {
Sentry.captureMessage('Test message from cache components page');
return <p id="result">Message captured for id message</p>;
}

return <p id="result">Hello, {id}!</p>;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
export async function GET() {
return Response.json({ value: 'hanging-fetch-data' });
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
import { captureException } from '@sentry/nextjs';
import type { Metadata } from 'next';

/**
* Calling captureException synchronously inside generateMetadata
* during `next build` prerender (cacheComponents). uuid4 -> crypto.randomUUID() runs
*/
export const generateMetadata = (): Metadata => {
captureException(new Error('diagnostic: data missing for this page'));
return { title: 'capture-metadata' };
};

export default function Page() {
return <h1>capture-metadata</h1>;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
export default function Loading() {
return <div id="sentinel-loading">Loading...</div>;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
import * as Sentry from '@sentry/nextjs';

// Captures an error tagged with a caller-supplied unique token. Tests use this as a drain marker: the
// token guarantees a cache miss, so the capture always happens on request, and its arrival proves the
// event pipeline has drained past every earlier request.
export default async function Page({ params }: { params: Promise<{ token: string }> }) {
const { token } = await params;

Sentry.captureException(new Error(`error-sentinel-${token}`));

return <p id="sentinel">{token}</p>;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
export default function Loading() {
return <div id="loading">Loading...</div>;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
// This `fetch()` deliberately has no cache configuration. Under Cache Components, Next.js does not
// issue such a request during a prerender - it hands out a promise that never settles and rejects it
// with a `HANGING_PROMISE_REJECTION` digest once the prerender is aborted. That rejection surfaces in
// this component and therefore in the Sentry server component wrapper, which must not report it.
export default async function Page() {
const response = await fetch('http://localhost:3030/api/hanging-fetch-data');
const data = (await response.json()) as { value: string };

return <p id="fetched-value">{data.value}</p>;
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -46,6 +46,12 @@
"extends": "../../package.json"
},
"sentryTest": {
"//": "TODO: Add variants for webpack once supported"
"variants": [
{
"build-command": "pnpm test:build-webpack",
"label": "nextjs-16-streaming-cacheComponents (webpack)",
"assert-command": "pnpm test:assert-webpack"
}
]
}
}
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { expect, test } from '@playwright/test';
import { waitForStreamedSpan, waitForStreamedSpans, getSpanOp } from '@sentry-internal/test-utils';
import { getSpanOp, waitForError, waitForStreamedSpan, waitForStreamedSpans } from '@sentry-internal/test-utils';

test('Should render cached component', async ({ page }) => {
const spansPromise = waitForStreamedSpans('nextjs-16-streaming-cacheComponents', spans => {
Expand DownExpand Up@@ -49,6 +49,34 @@ test('Should generate metadata', async ({ page }) => {
await expect(page).toHaveTitle('Cache Components Metadata Test');
});

// Capturing an event inside a Server Component that is (re)generated at request time must not
// trip Next.js Cache Components prerender guards (`new Date()` / `crypto`).
test('Should capture an exception from an on-demand generated Server Component', async ({ page }) => {
const errorPromise = waitForError('nextjs-16-streaming-cacheComponents', errorEvent => {
return errorEvent.exception?.values?.[0]?.value === 'Test error from cache components page';
});

await page.goto('/exception');

await expect(page.locator('#result')).toHaveText('Error captured for id exception');

const error = await errorPromise;
expect(error.exception?.values?.[0]?.value).toBe('Test error from cache components page');
});

test('Should capture a message from an on-demand generated Server Component', async ({ page }) => {
const messagePromise = waitForError('nextjs-16-streaming-cacheComponents', errorEvent => {
return errorEvent.message === 'Test message from cache components page';
});

await page.goto('/message');

await expect(page.locator('#result')).toHaveText('Message captured for id message');

const message = await messagePromise;
expect(message.message).toBe('Test message from cache components page');
});

test('Should generate metadata async', async ({ page }) => {
const spansPromise = waitForStreamedSpans('nextjs-16-streaming-cacheComponents', spans => {
return spans.some(
Expand DownExpand Up@@ -96,3 +124,10 @@ test('Prerendered shell does not stitch the pageload onto a stale trace', async
expect(await page.locator('meta[name="sentry-trace"]').count()).toBe(0);
expect(await page.locator('meta[name="baggage"]').count()).toBe(0);
});

test('Should prerender a page that captures an exception in generateMetadata', async ({ page }) => {
await page.goto('/capture-metadata');

await expect(page).toHaveTitle('capture-metadata');
await expect(page.locator('h1')).toHaveText('capture-metadata');
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,55 @@
import { expect, test } from '@playwright/test';
import { getSpanOp, waitForError, waitForStreamedSpan } from '@sentry-internal/test-utils';

const HANGING_PROMISE_DIGEST_MESSAGE = 'rejects when the prerender is complete';

// Under Cache Components, Next.js aborts prerenders by rejecting the promises it handed out for
// uncached `fetch()` calls. React discards those rejections - they never affect the response - so the
// Sentry wrappers must not report them. See https://github.com/getsentry/sentry-javascript/issues/23592
//
// Note this only exercises the regression under the webpack variant: server components are wrapped by
// `wrappingLoader`, which Turbopack builds do not run, so there is no wrapper to observe the rejection
// there. Under Turbopack the test still asserts the route renders and reports no errors.
test('does not capture hanging prerender promise rejections on a runtime prefetch', async ({ page, request }) => {
const capturedHangingPromiseErrors: string[] = [];
void waitForError('nextjs-16-streaming-cacheComponents', errorEvent => {
const value = errorEvent.exception?.values?.[0]?.value ?? '';
if (value.includes(HANGING_PROMISE_DIGEST_MESSAGE)) {
capturedHangingPromiseErrors.push(value);
}
return false;
});

// `Next-Router-Prefetch: 2` is what the Next.js router sends for a runtime prefetch. It makes Next.js
// run a prerender at request time, which is what produces the hanging promise rejection. A plain
// document request only replays the shell that was prerendered at build time and would not trigger it.
const prefetchResponse = await request.get('/hanging-fetch', {
headers: { RSC: '1', 'Next-Router-Prefetch': '2' },
});
expect(prefetchResponse.ok()).toBe(true);

const serverSpanPromise = waitForStreamedSpan('nextjs-16-streaming-cacheComponents', span => {
return span.name === 'GET /hanging-fetch' && getSpanOp(span) === 'http.server' && span.is_segment;
});

await page.goto('/hanging-fetch');
await expect(page.locator('#fetched-value')).toHaveText('hanging-fetch-data');

expect(await serverSpanPromise).toBeDefined();

// Drain marker instead of a sleep: request a route that deliberately captures an error, tagged with a
// token unique to this run so it can never be served from cache. It is requested strictly after the
// prefetch, and the SDK flushes per request, so once this error arrives any error the prefetch had
// captured must already have arrived too. That makes the assertion below "nothing was captured"
// rather than "nothing had been captured yet". It doubles as a check that errors do flow at all.
const token = `${Date.now()}`;
const sentinelPromise = waitForError('nextjs-16-streaming-cacheComponents', errorEvent => {
return errorEvent.exception?.values?.[0]?.value === `error-sentinel-${token}`;
});

await page.goto(`/error-sentinel/${token}`);
await expect(page.locator('#sentinel')).toHaveText(token);
await sentinelPromise;

expect(capturedHangingPromiseErrors).toEqual([]);
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
import * as Sentry from '@sentry/nextjs';

// Only `test` is prerendered at build time. `exception` and `message` are generated
// on-demand at request time.
export function generateStaticParams() {
return [{ id: 'test' }];
}

export default async function Page({ params }: { params: Promise<{ id: string }> }) {
const { id } = await params;

if (id === 'exception') {
Sentry.captureException(new Error('Test error from cache components page'));
return <p id="result">Error captured for id exception</p>;
}

if (id === 'message') {
Sentry.captureMessage('Test message from cache components page');
return <p id="result">Message captured for id message</p>;
}

return <p id="result">Hello, {id}!</p>;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
export async function GET() {
return Response.json({ value: 'hanging-fetch-data' });
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
import { captureException } from '@sentry/nextjs';
import type { Metadata } from 'next';

/**
* Calling captureException synchronously inside generateMetadata
* during `next build` prerender (cacheComponents). uuid4 -> crypto.randomUUID() runs
*/
export const generateMetadata = (): Metadata => {
captureException(new Error('diagnostic: data missing for this page'));
return { title: 'capture-metadata' };
};

export default function Page() {
return <h1>capture-metadata</h1>;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
export default function Loading() {
return <div id="sentinel-loading">Loading...</div>;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
import * as Sentry from '@sentry/nextjs';

// Captures an error tagged with a caller-supplied unique token. Tests use this as a drain marker: the
// token guarantees a cache miss, so the capture always happens on request, and its arrival proves the
// event pipeline has drained past every earlier request.
export default async function Page({ params }: { params: Promise<{ token: string }> }) {
const { token } = await params;

Sentry.captureException(new Error(`error-sentinel-${token}`));

return <p id="sentinel">{token}</p>;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
export default function Loading() {
return <div id="loading">Loading...</div>;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
// This `fetch()` deliberately has no cache configuration. Under Cache Components, Next.js does not
// issue such a request during a prerender - it hands out a promise that never settles and rejects it
// with a `HANGING_PROMISE_REJECTION` digest once the prerender is aborted. That rejection surfaces in
// this component and therefore in the Sentry server component wrapper, which must not report it.
export default async function Page() {
const response = await fetch('http://localhost:3030/api/hanging-fetch-data');
const data = (await response.json()) as { value: string };

return <p id="fetched-value">{data.value}</p>;
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -46,6 +46,12 @@
"extends": "../../package.json"
},
"sentryTest": {
"//": "TODO: Add variants for webpack once supported"
"variants": [
{
"build-command": "pnpm test:build-webpack",
"label": "nextjs-16-streaming-cacheComponents (webpack)",
"assert-command": "pnpm test:assert-webpack"
}
]
}
}
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { expect, test } from '@playwright/test';
import { waitForStreamedSpan, waitForStreamedSpans, getSpanOp } from '@sentry-internal/test-utils';
import { getSpanOp, waitForError, waitForStreamedSpan, waitForStreamedSpans } from '@sentry-internal/test-utils';

test('Should render cached component', async ({ page }) => {
const spansPromise = waitForStreamedSpans('nextjs-16-streaming-cacheComponents', spans => {
Expand DownExpand Up@@ -49,6 +49,34 @@ test('Should generate metadata', async ({ page }) => {
await expect(page).toHaveTitle('Cache Components Metadata Test');
});

// Capturing an event inside a Server Component that is (re)generated at request time must not
// trip Next.js Cache Components prerender guards (`new Date()` / `crypto`).
test('Should capture an exception from an on-demand generated Server Component', async ({ page }) => {
const errorPromise = waitForError('nextjs-16-streaming-cacheComponents', errorEvent => {
return errorEvent.exception?.values?.[0]?.value === 'Test error from cache components page';
});

await page.goto('/exception');

await expect(page.locator('#result')).toHaveText('Error captured for id exception');

const error = await errorPromise;
expect(error.exception?.values?.[0]?.value).toBe('Test error from cache components page');
});

test('Should capture a message from an on-demand generated Server Component', async ({ page }) => {
const messagePromise = waitForError('nextjs-16-streaming-cacheComponents', errorEvent => {
return errorEvent.message === 'Test message from cache components page';
});

await page.goto('/message');

await expect(page.locator('#result')).toHaveText('Message captured for id message');

const message = await messagePromise;
expect(message.message).toBe('Test message from cache components page');
});

test('Should generate metadata async', async ({ page }) => {
const spansPromise = waitForStreamedSpans('nextjs-16-streaming-cacheComponents', spans => {
return spans.some(
Expand DownExpand Up@@ -96,3 +124,10 @@ test('Prerendered shell does not stitch the pageload onto a stale trace', async
expect(await page.locator('meta[name="sentry-trace"]').count()).toBe(0);
expect(await page.locator('meta[name="baggage"]').count()).toBe(0);
});

test('Should prerender a page that captures an exception in generateMetadata', async ({ page }) => {
await page.goto('/capture-metadata');

await expect(page).toHaveTitle('capture-metadata');
await expect(page.locator('h1')).toHaveText('capture-metadata');
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,55 @@
import { expect, test } from '@playwright/test';
import { getSpanOp, waitForError, waitForStreamedSpan } from '@sentry-internal/test-utils';

const HANGING_PROMISE_DIGEST_MESSAGE = 'rejects when the prerender is complete';

// Under Cache Components, Next.js aborts prerenders by rejecting the promises it handed out for
// uncached `fetch()` calls. React discards those rejections - they never affect the response - so the
// Sentry wrappers must not report them. See https://github.com/getsentry/sentry-javascript/issues/23592
//
// Note this only exercises the regression under the webpack variant: server components are wrapped by
// `wrappingLoader`, which Turbopack builds do not run, so there is no wrapper to observe the rejection
// there. Under Turbopack the test still asserts the route renders and reports no errors.
test('does not capture hanging prerender promise rejections on a runtime prefetch', async ({ page, request }) => {
const capturedHangingPromiseErrors: string[] = [];
void waitForError('nextjs-16-streaming-cacheComponents', errorEvent => {
const value = errorEvent.exception?.values?.[0]?.value ?? '';
if (value.includes(HANGING_PROMISE_DIGEST_MESSAGE)) {
capturedHangingPromiseErrors.push(value);
}
return false;
});

// `Next-Router-Prefetch: 2` is what the Next.js router sends for a runtime prefetch. It makes Next.js
// run a prerender at request time, which is what produces the hanging promise rejection. A plain
// document request only replays the shell that was prerendered at build time and would not trigger it.
const prefetchResponse = await request.get('/hanging-fetch', {
headers: { RSC: '1', 'Next-Router-Prefetch': '2' },
});
expect(prefetchResponse.ok()).toBe(true);

const serverSpanPromise = waitForStreamedSpan('nextjs-16-streaming-cacheComponents', span => {
return span.name === 'GET /hanging-fetch' && getSpanOp(span) === 'http.server' && span.is_segment;
});

await page.goto('/hanging-fetch');
await expect(page.locator('#fetched-value')).toHaveText('hanging-fetch-data');

expect(await serverSpanPromise).toBeDefined();

// Drain marker instead of a sleep: request a route that deliberately captures an error, tagged with a
// token unique to this run so it can never be served from cache. It is requested strictly after the
// prefetch, and the SDK flushes per request, so once this error arrives any error the prefetch had
// captured must already have arrived too. That makes the assertion below "nothing was captured"
// rather than "nothing had been captured yet". It doubles as a check that errors do flow at all.
const token = `${Date.now()}`;
const sentinelPromise = waitForError('nextjs-16-streaming-cacheComponents', errorEvent => {
return errorEvent.exception?.values?.[0]?.value === `error-sentinel-${token}`;
});

await page.goto(`/error-sentinel/${token}`);
await expect(page.locator('#sentinel')).toHaveText(token);
await sentinelPromise;

expect(capturedHangingPromiseErrors).toEqual([]);
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
import * as Sentry from '@sentry/nextjs';

// Only `test` is prerendered at build time. `exception` and `message` are generated
// on-demand at request time.
export function generateStaticParams() {
return [{ id: 'test' }];
}

export default async function Page({ params }: { params: Promise<{ id: string }> }) {
const { id } = await params;

if (id === 'exception') {
Sentry.captureException(new Error('Test error from cache components page'));
return <p id="result">Error captured for id exception</p>;
}

if (id === 'message') {
Sentry.captureMessage('Test message from cache components page');
return <p id="result">Message captured for id message</p>;
}

return <p id="result">Hello, {id}!</p>;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
export async function GET() {
return Response.json({ value: 'hanging-fetch-data' });
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
import { captureException } from '@sentry/nextjs';
import type { Metadata } from 'next';

/**
* Calling captureException synchronously inside generateMetadata
* during `next build` prerender (cacheComponents). uuid4 -> crypto.randomUUID() runs
*/
export const generateMetadata = (): Metadata => {
captureException(new Error('diagnostic: data missing for this page'));
return { title: 'capture-metadata' };
};

export default function Page() {
return <h1>capture-metadata</h1>;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
export default function Loading() {
return <div id="sentinel-loading">Loading...</div>;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
import * as Sentry from '@sentry/nextjs';

// Captures an error tagged with a caller-supplied unique token. Tests use this as a drain marker: the
// token guarantees a cache miss, so the capture always happens on request, and its arrival proves the
// event pipeline has drained past every earlier request.
export default async function Page({ params }: { params: Promise<{ token: string }> }) {
const { token } = await params;

Sentry.captureException(new Error(`error-sentinel-${token}`));

return <p id="sentinel">{token}</p>;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
export default function Loading() {
return <div id="loading">Loading...</div>;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
// This `fetch()` deliberately has no cache configuration. Under Cache Components, Next.js does not
// issue such a request during a prerender - it hands out a promise that never settles and rejects it
// with a `HANGING_PROMISE_REJECTION` digest once the prerender is aborted. That rejection surfaces in
// this component and therefore in the Sentry server component wrapper, which must not report it.
export default async function Page() {
const response = await fetch('http://localhost:3030/api/hanging-fetch-data');
const data = (await response.json()) as { value: string };

return <p id="fetched-value">{data.value}</p>;
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -46,6 +46,12 @@
"extends": "../../package.json"
},
"sentryTest": {
"//": "TODO: Add variants for webpack once supported"
"variants": [
{
"build-command": "pnpm test:build-webpack",
"label": "nextjs-16-streaming-cacheComponents (webpack)",
"assert-command": "pnpm test:assert-webpack"
}
]
}
}
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { expect, test } from '@playwright/test';
import { waitForStreamedSpan, waitForStreamedSpans, getSpanOp } from '@sentry-internal/test-utils';
import { getSpanOp, waitForError, waitForStreamedSpan, waitForStreamedSpans } from '@sentry-internal/test-utils';

test('Should render cached component', async ({ page }) => {
const spansPromise = waitForStreamedSpans('nextjs-16-streaming-cacheComponents', spans => {
Expand DownExpand Up@@ -49,6 +49,34 @@ test('Should generate metadata', async ({ page }) => {
await expect(page).toHaveTitle('Cache Components Metadata Test');
});

// Capturing an event inside a Server Component that is (re)generated at request time must not
// trip Next.js Cache Components prerender guards (`new Date()` / `crypto`).
test('Should capture an exception from an on-demand generated Server Component', async ({ page }) => {
const errorPromise = waitForError('nextjs-16-streaming-cacheComponents', errorEvent => {
return errorEvent.exception?.values?.[0]?.value === 'Test error from cache components page';
});

await page.goto('/exception');

await expect(page.locator('#result')).toHaveText('Error captured for id exception');

const error = await errorPromise;
expect(error.exception?.values?.[0]?.value).toBe('Test error from cache components page');
});

test('Should capture a message from an on-demand generated Server Component', async ({ page }) => {
const messagePromise = waitForError('nextjs-16-streaming-cacheComponents', errorEvent => {
return errorEvent.message === 'Test message from cache components page';
});

await page.goto('/message');

await expect(page.locator('#result')).toHaveText('Message captured for id message');

const message = await messagePromise;
expect(message.message).toBe('Test message from cache components page');
});

test('Should generate metadata async', async ({ page }) => {
const spansPromise = waitForStreamedSpans('nextjs-16-streaming-cacheComponents', spans => {
return spans.some(
Expand DownExpand Up@@ -96,3 +124,10 @@ test('Prerendered shell does not stitch the pageload onto a stale trace', async
expect(await page.locator('meta[name="sentry-trace"]').count()).toBe(0);
expect(await page.locator('meta[name="baggage"]').count()).toBe(0);
});

test('Should prerender a page that captures an exception in generateMetadata', async ({ page }) => {
await page.goto('/capture-metadata');

await expect(page).toHaveTitle('capture-metadata');
await expect(page.locator('h1')).toHaveText('capture-metadata');
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,55 @@
import { expect, test } from '@playwright/test';
import { getSpanOp, waitForError, waitForStreamedSpan } from '@sentry-internal/test-utils';

const HANGING_PROMISE_DIGEST_MESSAGE = 'rejects when the prerender is complete';

// Under Cache Components, Next.js aborts prerenders by rejecting the promises it handed out for
// uncached `fetch()` calls. React discards those rejections - they never affect the response - so the
// Sentry wrappers must not report them. See https://github.com/getsentry/sentry-javascript/issues/23592
//
// Note this only exercises the regression under the webpack variant: server components are wrapped by
// `wrappingLoader`, which Turbopack builds do not run, so there is no wrapper to observe the rejection
// there. Under Turbopack the test still asserts the route renders and reports no errors.
test('does not capture hanging prerender promise rejections on a runtime prefetch', async ({ page, request }) => {
const capturedHangingPromiseErrors: string[] = [];
void waitForError('nextjs-16-streaming-cacheComponents', errorEvent => {
const value = errorEvent.exception?.values?.[0]?.value ?? '';
if (value.includes(HANGING_PROMISE_DIGEST_MESSAGE)) {
capturedHangingPromiseErrors.push(value);
}
return false;
});

// `Next-Router-Prefetch: 2` is what the Next.js router sends for a runtime prefetch. It makes Next.js
// run a prerender at request time, which is what produces the hanging promise rejection. A plain
// document request only replays the shell that was prerendered at build time and would not trigger it.
const prefetchResponse = await request.get('/hanging-fetch', {
headers: { RSC: '1', 'Next-Router-Prefetch': '2' },
});
expect(prefetchResponse.ok()).toBe(true);

const serverSpanPromise = waitForStreamedSpan('nextjs-16-streaming-cacheComponents', span => {
return span.name === 'GET /hanging-fetch' && getSpanOp(span) === 'http.server' && span.is_segment;
});

await page.goto('/hanging-fetch');
await expect(page.locator('#fetched-value')).toHaveText('hanging-fetch-data');

expect(await serverSpanPromise).toBeDefined();

// Drain marker instead of a sleep: request a route that deliberately captures an error, tagged with a
// token unique to this run so it can never be served from cache. It is requested strictly after the
// prefetch, and the SDK flushes per request, so once this error arrives any error the prefetch had
// captured must already have arrived too. That makes the assertion below "nothing was captured"
// rather than "nothing had been captured yet". It doubles as a check that errors do flow at all.
const token = `${Date.now()}`;
const sentinelPromise = waitForError('nextjs-16-streaming-cacheComponents', errorEvent => {
return errorEvent.exception?.values?.[0]?.value === `error-sentinel-${token}`;
});

await page.goto(`/error-sentinel/${token}`);
await expect(page.locator('#sentinel')).toHaveText(token);
await sentinelPromise;

expect(capturedHangingPromiseErrors).toEqual([]);
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
import * as Sentry from '@sentry/nextjs';

// Only `test` is prerendered at build time. `exception` and `message` are generated
// on-demand at request time.
export function generateStaticParams() {
return [{ id: 'test' }];
}

export default async function Page({ params }: { params: Promise<{ id: string }> }) {
const { id } = await params;

if (id === 'exception') {
Sentry.captureException(new Error('Test error from cache components page'));
return <p id="result">Error captured for id exception</p>;
}

if (id === 'message') {
Sentry.captureMessage('Test message from cache components page');
return <p id="result">Message captured for id message</p>;
}

return <p id="result">Hello, {id}!</p>;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
export async function GET() {
return Response.json({ value: 'hanging-fetch-data' });
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
import { captureException } from '@sentry/nextjs';
import type { Metadata } from 'next';

/**
* Calling captureException synchronously inside generateMetadata
* during `next build` prerender (cacheComponents). uuid4 -> crypto.randomUUID() runs
*/
export const generateMetadata = (): Metadata => {
captureException(new Error('diagnostic: data missing for this page'));
return { title: 'capture-metadata' };
};

export default function Page() {
return <h1>capture-metadata</h1>;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
export default function Loading() {
return <div id="sentinel-loading">Loading...</div>;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
import * as Sentry from '@sentry/nextjs';

// Captures an error tagged with a caller-supplied unique token. Tests use this as a drain marker: the
// token guarantees a cache miss, so the capture always happens on request, and its arrival proves the
// event pipeline has drained past every earlier request.
export default async function Page({ params }: { params: Promise<{ token: string }> }) {
const { token } = await params;

Sentry.captureException(new Error(`error-sentinel-${token}`));

return <p id="sentinel">{token}</p>;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
export default function Loading() {
return <div id="loading">Loading...</div>;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
// This `fetch()` deliberately has no cache configuration. Under Cache Components, Next.js does not
// issue such a request during a prerender - it hands out a promise that never settles and rejects it
// with a `HANGING_PROMISE_REJECTION` digest once the prerender is aborted. That rejection surfaces in
// this component and therefore in the Sentry server component wrapper, which must not report it.
export default async function Page() {
const response = await fetch('http://localhost:3030/api/hanging-fetch-data');
const data = (await response.json()) as { value: string };

return <p id="fetched-value">{data.value}</p>;
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -46,6 +46,12 @@
"extends": "../../package.json"
},
"sentryTest": {
"//": "TODO: Add variants for webpack once supported"
"variants": [
{
"build-command": "pnpm test:build-webpack",
"label": "nextjs-16-streaming-cacheComponents (webpack)",
"assert-command": "pnpm test:assert-webpack"
}
]
}
}
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { expect, test } from '@playwright/test';
import { waitForStreamedSpan, waitForStreamedSpans, getSpanOp } from '@sentry-internal/test-utils';
import { getSpanOp, waitForError, waitForStreamedSpan, waitForStreamedSpans } from '@sentry-internal/test-utils';

test('Should render cached component', async ({ page }) => {
const spansPromise = waitForStreamedSpans('nextjs-16-streaming-cacheComponents', spans => {
Expand DownExpand Up@@ -49,6 +49,34 @@ test('Should generate metadata', async ({ page }) => {
await expect(page).toHaveTitle('Cache Components Metadata Test');
});

// Capturing an event inside a Server Component that is (re)generated at request time must not
// trip Next.js Cache Components prerender guards (`new Date()` / `crypto`).
test('Should capture an exception from an on-demand generated Server Component', async ({ page }) => {
const errorPromise = waitForError('nextjs-16-streaming-cacheComponents', errorEvent => {
return errorEvent.exception?.values?.[0]?.value === 'Test error from cache components page';
});

await page.goto('/exception');

await expect(page.locator('#result')).toHaveText('Error captured for id exception');

const error = await errorPromise;
expect(error.exception?.values?.[0]?.value).toBe('Test error from cache components page');
});

test('Should capture a message from an on-demand generated Server Component', async ({ page }) => {
const messagePromise = waitForError('nextjs-16-streaming-cacheComponents', errorEvent => {
return errorEvent.message === 'Test message from cache components page';
});

await page.goto('/message');

await expect(page.locator('#result')).toHaveText('Message captured for id message');

const message = await messagePromise;
expect(message.message).toBe('Test message from cache components page');
});

test('Should generate metadata async', async ({ page }) => {
const spansPromise = waitForStreamedSpans('nextjs-16-streaming-cacheComponents', spans => {
return spans.some(
Expand DownExpand Up@@ -96,3 +124,10 @@ test('Prerendered shell does not stitch the pageload onto a stale trace', async
expect(await page.locator('meta[name="sentry-trace"]').count()).toBe(0);
expect(await page.locator('meta[name="baggage"]').count()).toBe(0);
});

test('Should prerender a page that captures an exception in generateMetadata', async ({ page }) => {
await page.goto('/capture-metadata');

await expect(page).toHaveTitle('capture-metadata');
await expect(page.locator('h1')).toHaveText('capture-metadata');
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,55 @@
import { expect, test } from '@playwright/test';
import { getSpanOp, waitForError, waitForStreamedSpan } from '@sentry-internal/test-utils';

const HANGING_PROMISE_DIGEST_MESSAGE = 'rejects when the prerender is complete';

// Under Cache Components, Next.js aborts prerenders by rejecting the promises it handed out for
// uncached `fetch()` calls. React discards those rejections - they never affect the response - so the
// Sentry wrappers must not report them. See https://github.com/getsentry/sentry-javascript/issues/23592
//
// Note this only exercises the regression under the webpack variant: server components are wrapped by
// `wrappingLoader`, which Turbopack builds do not run, so there is no wrapper to observe the rejection
// there. Under Turbopack the test still asserts the route renders and reports no errors.
test('does not capture hanging prerender promise rejections on a runtime prefetch', async ({ page, request }) => {
const capturedHangingPromiseErrors: string[] = [];
void waitForError('nextjs-16-streaming-cacheComponents', errorEvent => {
const value = errorEvent.exception?.values?.[0]?.value ?? '';
if (value.includes(HANGING_PROMISE_DIGEST_MESSAGE)) {
capturedHangingPromiseErrors.push(value);
}
return false;
});

// `Next-Router-Prefetch: 2` is what the Next.js router sends for a runtime prefetch. It makes Next.js
// run a prerender at request time, which is what produces the hanging promise rejection. A plain
// document request only replays the shell that was prerendered at build time and would not trigger it.
const prefetchResponse = await request.get('/hanging-fetch', {
headers: { RSC: '1', 'Next-Router-Prefetch': '2' },
});
expect(prefetchResponse.ok()).toBe(true);

const serverSpanPromise = waitForStreamedSpan('nextjs-16-streaming-cacheComponents', span => {
return span.name === 'GET /hanging-fetch' && getSpanOp(span) === 'http.server' && span.is_segment;
});

await page.goto('/hanging-fetch');
await expect(page.locator('#fetched-value')).toHaveText('hanging-fetch-data');

expect(await serverSpanPromise).toBeDefined();

// Drain marker instead of a sleep: request a route that deliberately captures an error, tagged with a
// token unique to this run so it can never be served from cache. It is requested strictly after the
// prefetch, and the SDK flushes per request, so once this error arrives any error the prefetch had
// captured must already have arrived too. That makes the assertion below "nothing was captured"
// rather than "nothing had been captured yet". It doubles as a check that errors do flow at all.
const token = `${Date.now()}`;
const sentinelPromise = waitForError('nextjs-16-streaming-cacheComponents', errorEvent => {
return errorEvent.exception?.values?.[0]?.value === `error-sentinel-${token}`;
});

await page.goto(`/error-sentinel/${token}`);
await expect(page.locator('#sentinel')).toHaveText(token);
await sentinelPromise;

expect(capturedHangingPromiseErrors).toEqual([]);
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
import * as Sentry from '@sentry/nextjs';

// Only `test` is prerendered at build time. `exception` and `message` are generated
// on-demand at request time.
export function generateStaticParams() {
return [{ id: 'test' }];
}

export default async function Page({ params }: { params: Promise<{ id: string }> }) {
const { id } = await params;

if (id === 'exception') {
Sentry.captureException(new Error('Test error from cache components page'));
return <p id="result">Error captured for id exception</p>;
}

if (id === 'message') {
Sentry.captureMessage('Test message from cache components page');
return <p id="result">Message captured for id message</p>;
}

return <p id="result">Hello, {id}!</p>;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
export async function GET() {
return Response.json({ value: 'hanging-fetch-data' });
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
import { captureException } from '@sentry/nextjs';
import type { Metadata } from 'next';

/**
* Calling captureException synchronously inside generateMetadata
* during `next build` prerender (cacheComponents). uuid4 -> crypto.randomUUID() runs
*/
export const generateMetadata = (): Metadata => {
captureException(new Error('diagnostic: data missing for this page'));
return { title: 'capture-metadata' };
};

export default function Page() {
return <h1>capture-metadata</h1>;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
export default function Loading() {
return <div id="sentinel-loading">Loading...</div>;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
import * as Sentry from '@sentry/nextjs';

// Captures an error tagged with a caller-supplied unique token. Tests use this as a drain marker: the
// token guarantees a cache miss, so the capture always happens on request, and its arrival proves the
// event pipeline has drained past every earlier request.
export default async function Page({ params }: { params: Promise<{ token: string }> }) {
const { token } = await params;

Sentry.captureException(new Error(`error-sentinel-${token}`));

return <p id="sentinel">{token}</p>;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
export default function Loading() {
return <div id="loading">Loading...</div>;
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
// This `fetch()` deliberately has no cache configuration. Under Cache Components, Next.js does not
// issue such a request during a prerender - it hands out a promise that never settles and rejects it
// with a `HANGING_PROMISE_REJECTION` digest once the prerender is aborted. That rejection surfaces in
// this component and therefore in the Sentry server component wrapper, which must not report it.
export default async function Page() {
const response = await fetch('http://localhost:3030/api/hanging-fetch-data');
const data = (await response.json()) as { value: string };

return <p id="fetched-value">{data.value}</p>;
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -46,6 +46,12 @@
"extends": "../../package.json"
},
"sentryTest": {
"//": "TODO: Add variants for webpack once supported"
"variants": [
{
"build-command": "pnpm test:build-webpack",
"label": "nextjs-16-streaming-cacheComponents (webpack)",
"assert-command": "pnpm test:assert-webpack"
}
]
}
}
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { expect, test } from '@playwright/test';
import { waitForStreamedSpan, waitForStreamedSpans, getSpanOp } from '@sentry-internal/test-utils';
import { getSpanOp, waitForError, waitForStreamedSpan, waitForStreamedSpans } from '@sentry-internal/test-utils';

test('Should render cached component', async ({ page }) => {
const spansPromise = waitForStreamedSpans('nextjs-16-streaming-cacheComponents', spans => {
Expand DownExpand Up@@ -49,6 +49,34 @@ test('Should generate metadata', async ({ page }) => {
await expect(page).toHaveTitle('Cache Components Metadata Test');
});

// Capturing an event inside a Server Component that is (re)generated at request time must not
// trip Next.js Cache Components prerender guards (`new Date()` / `crypto`).
test('Should capture an exception from an on-demand generated Server Component', async ({ page }) => {
const errorPromise = waitForError('nextjs-16-streaming-cacheComponents', errorEvent => {
return errorEvent.exception?.values?.[0]?.value === 'Test error from cache components page';
});

await page.goto('/exception');

await expect(page.locator('#result')).toHaveText('Error captured for id exception');

const error = await errorPromise;
expect(error.exception?.values?.[0]?.value).toBe('Test error from cache components page');
});

test('Should capture a message from an on-demand generated Server Component', async ({ page }) => {
const messagePromise = waitForError('nextjs-16-streaming-cacheComponents', errorEvent => {
return errorEvent.message === 'Test message from cache components page';
});

await page.goto('/message');

await expect(page.locator('#result')).toHaveText('Message captured for id message');

const message = await messagePromise;
expect(message.message).toBe('Test message from cache components page');
});

test('Should generate metadata async', async ({ page }) => {
const spansPromise = waitForStreamedSpans('nextjs-16-streaming-cacheComponents', spans => {
return spans.some(
Expand DownExpand Up@@ -96,3 +124,10 @@ test('Prerendered shell does not stitch the pageload onto a stale trace', async
expect(await page.locator('meta[name="sentry-trace"]').count()).toBe(0);
expect(await page.locator('meta[name="baggage"]').count()).toBe(0);
});

test('Should prerender a page that captures an exception in generateMetadata', async ({ page }) => {
await page.goto('/capture-metadata');

await expect(page).toHaveTitle('capture-metadata');
await expect(page.locator('h1')).toHaveText('capture-metadata');
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,55 @@
import { expect, test } from '@playwright/test';
import { getSpanOp, waitForError, waitForStreamedSpan } from '@sentry-internal/test-utils';

const HANGING_PROMISE_DIGEST_MESSAGE = 'rejects when the prerender is complete';

// Under Cache Components, Next.js aborts prerenders by rejecting the promises it handed out for
// uncached `fetch()` calls. React discards those rejections - they never affect the response - so the
// Sentry wrappers must not report them. See https://github.com/getsentry/sentry-javascript/issues/23592
//
// Note this only exercises the regression under the webpack variant: server components are wrapped by
// `wrappingLoader`, which Turbopack builds do not run, so there is no wrapper to observe the rejection
// there. Under Turbopack the test still asserts the route renders and reports no errors.
test('does not capture hanging prerender promise rejections on a runtime prefetch', async ({ page, request }) => {
const capturedHangingPromiseErrors: string[] = [];
void waitForError('nextjs-16-streaming-cacheComponents', errorEvent => {
const value = errorEvent.exception?.values?.[0]?.value ?? '';
if (value.includes(HANGING_PROMISE_DIGEST_MESSAGE)) {
capturedHangingPromiseErrors.push(value);
}
return false;
});

// `Next-Router-Prefetch: 2` is what the Next.js router sends for a runtime prefetch. It makes Next.js
// run a prerender at request time, which is what produces the hanging promise rejection. A plain
// document request only replays the shell that was prerendered at build time and would not trigger it.
const prefetchResponse = await request.get('/hanging-fetch', {
headers: { RSC: '1', 'Next-Router-Prefetch': '2' },
});
expect(prefetchResponse.ok()).toBe(true);

const serverSpanPromise = waitForStreamedSpan('nextjs-16-streaming-cacheComponents', span => {
return span.name === 'GET /hanging-fetch' && getSpanOp(span) === 'http.server' && span.is_segment;
});

await page.goto('/hanging-fetch');
await expect(page.locator('#fetched-value')).toHaveText('hanging-fetch-data');

expect(await serverSpanPromise).toBeDefined();

// Drain marker instead of a sleep: request a route that deliberately captures an error, tagged with a
// token unique to this run so it can never be served from cache. It is requested strictly after the
// prefetch, and the SDK flushes per request, so once this error arrives any error the prefetch had
// captured must already have arrived too. That makes the assertion below "nothing was captured"
// rather than "nothing had been captured yet". It doubles as a check that errors do flow at all.
const token = `${Date.now()}`;
const sentinelPromise = waitForError('nextjs-16-streaming-cacheComponents', errorEvent => {
return errorEvent.exception?.values?.[0]?.value === `error-sentinel-${token}`;
});

await page.goto(`/error-sentinel/${token}`);
await expect(page.locator('#sentinel')).toHaveText(token);
await sentinelPromise;

expect(capturedHangingPromiseErrors).toEqual([]);
});
Loading