test(e2e): Port React Router E2E test apps to span streaming#23839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andreiborza wants to merge 1 commit into from
Closed

test(e2e): Port React Router E2E test apps to span streaming #23839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion dev-packages/e2e-tests/test-applications/react-create-browser-router/src/index.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,7 +15,6 @@ import User from './pages/User';
const replay = Sentry.replayIntegration();

Sentry.init({
traceLifecycle: 'static',
// environment: 'qa', // dynamic sampling bias to keep transactions
dsn: process.env.REACT_APP_E2E_TEST_DSN,
integrations: [
Expand Down
164 changes: 164 additions & 0 deletions dev-packages/e2e-tests/test-applications/react-create-browser-router/tests/spans.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,164 @@
import { expect, test } from '@playwright/test';
import {
collectStreamedSpans,
getSpanOp,
waitForStreamedSpan,
waitForStreamedSpans,
} from '@sentry-internal/test-utils';

const PREVIOUS_TRACE_LINK = [
{
attributes: {
'sentry.link.type': { value: 'previous_trace', type: 'string' },
},
sampled: true,
span_id: expect.stringMatching(/[a-f0-9]{16}/),
trace_id: expect.stringMatching(/[a-f0-9]{32}/),
},
];

test('Captures a pageload span', async ({ page }) => {
const spanPromise = waitForStreamedSpan('react-create-browser-router', span => {
return getSpanOp(span) === 'pageload' && span.is_segment;
});

await page.goto('/');

const span = await spanPromise;

expect(span.name).toBe('/');
expect(span.status).toBe('ok');
expect(span.span_id).toMatch(/[a-f0-9]{16}/);
expect(span.trace_id).toMatch(/[a-f0-9]{32}/);

expect(span.attributes).toMatchObject({
'device.memory.estimated_capacity': { value: expect.any(Number), type: expect.any(String) },
'device.processor_count': { value: expect.any(Number), type: 'integer' },
'network.connection.effective_type': { value: expect.any(String), type: 'string' },
'sentry.idle_span_finish_reason': { value: 'idleTimeout', type: 'string' },
'sentry.op': { value: 'pageload', type: 'string' },
'sentry.origin': { value: 'auto.pageload.react.reactrouter_v6', type: 'string' },
'sentry.sample_rate': { value: 1, type: 'integer' },
'sentry.segment.name.source': { value: 'route', type: 'string' },
'url.template': { value: '/', type: 'string' },
'url.path': { value: '/', type: 'string' },
'url.full': { value: expect.stringMatching(/^https?:\/\/localhost:\d+\/$/), type: 'string' },
});
});

test('Captures a navigation span', async ({ page }) => {
const spansPromise = waitForStreamedSpans('react-create-browser-router', spans => {
return spans.some(span => getSpanOp(span) === 'navigation' && span.is_segment);
});

await page.goto('/');
const linkElement = page.locator('id=navigation');
await linkElement.click();

const spans = await spansPromise;
const navigationSpan = spans.find(span => span.is_segment)!;

@cursorcursorBotSep 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong segment picked for navigation

Medium Severity

The wait predicate requires a navigation segment, but the span under test is then selected with spans.find(span => span.is_segment). That envelope can also contain the still-finishing pageload segment, especially here because the click is not sequenced after pageload. Memory-router is most exposed because pageload and navigation share the name /user/:id. Flagged from the review guidelines on flaky waits that are not unique enough when telemetry can arrive in arbitrary order.

Additional Locations (2)
Fix in CursorFix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

Reviewed by Cursor Bugbot for commit 3ea1d9b. Configure here.


expect(navigationSpan.name).toBe('/user/:id');
expect(navigationSpan.status).toBe('ok');
expect(navigationSpan.span_id).toMatch(/[a-f0-9]{16}/);
expect(navigationSpan.trace_id).toMatch(/[a-f0-9]{32}/);

expect(navigationSpan.attributes).toMatchObject({
'sentry.idle_span_finish_reason': { value: 'idleTimeout', type: 'string' },
'sentry.op': { value: 'navigation', type: 'string' },
'sentry.origin': { value: 'auto.navigation.react.reactrouter_v6', type: 'string' },
'sentry.sample_rate': { value: 1, type: 'integer' },
'sentry.segment.name.source': { value: 'route', type: 'string' },
'url.template': { value: '/user/:id', type: 'string' },
'url.path': { value: '/user/5', type: 'string' },
'url.full': { value: expect.stringMatching(/^https?:\/\/localhost:\d+\/user\/5$/), type: 'string' },
});

expect(navigationSpan.links).toEqual(PREVIOUS_TRACE_LINK);

// Filter out favicon spans which may or may not be present depending on the browser version
const childSpans = spans.filter(
span => !span.is_segment && !(span.attributes['url.full']?.value as string | undefined)?.includes('favicon'),
);
expect(childSpans).toEqual([]);

@cursorcursorBotSep 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Child-span absence checked too narrowly

Medium Severity

These tests expect navigation to have no child spans, but they only inspect the single envelope that contains the navigation segment. Streamed children flush as they end, often in earlier envelopes, so unexpected children would not be seen and the empty-array assertion would still pass. Flagged because the review guidelines call out relaxed negative assertions that do not actually prove something is absent from the payload.

Additional Locations (2)
Fix in CursorFix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

Reviewed by Cursor Bugbot for commit 3ea1d9b. Configure here.

});

test('Captures a lazy pageload span', async ({ page }) => {
const spansPromise = collectStreamedSpans('react-create-browser-router', spans => {
return spans.some(span => getSpanOp(span) === 'pageload' && span.is_segment);
});

await page.goto('/lazy-loaded-user/5/foo');

const spans = await spansPromise;
const pageloadSpan = spans.find(span => getSpanOp(span) === 'pageload' && span.is_segment)!;

expect(pageloadSpan.name).toBe('/lazy-loaded-user/:id/:innerId');
expect(pageloadSpan.status).toBe('ok');

expect(pageloadSpan.attributes).toMatchObject({
'sentry.idle_span_finish_reason': { value: 'idleTimeout', type: 'string' },
'sentry.op': { value: 'pageload', type: 'string' },
'sentry.origin': { value: 'auto.pageload.react.reactrouter_v6', type: 'string' },
'sentry.sample_rate': { value: 1, type: 'integer' },
'sentry.segment.name.source': { value: 'route', type: 'string' },
'url.template': { value: '/lazy-loaded-user/:id/:innerId', type: 'string' },
'url.path': { value: '/lazy-loaded-user/5/foo', type: 'string' },
'url.full': {
value: expect.stringMatching(/^https?:\/\/localhost:\d+\/lazy-loaded-user\/5\/foo$/),
type: 'string',
},
});

expect(await page.innerText('id=content')).toContain('I am a lazy loaded user');

// One span for the outer lazy route, one for the inner one
const resourceSpans = spans.filter(
span =>
getSpanOp(span) === 'resource.script' &&
span.attributes['sentry.origin']?.value === 'auto.resource.browser.metrics',
);
expect(resourceSpans.length).toBeGreaterThanOrEqual(2);
});

test('Captures a lazy navigation span', async ({ page }) => {
const spansPromise = collectStreamedSpans('react-create-browser-router', spans => {
return spans.some(span => getSpanOp(span) === 'navigation' && span.is_segment);
});

await page.goto('/');
const linkElement = page.locator('id=lazy-navigation');
await linkElement.click();

const spans = await spansPromise;
const navigationSpan = spans.find(span => getSpanOp(span) === 'navigation' && span.is_segment)!;

expect(navigationSpan.name).toBe('/lazy-loaded-user/:id/:innerId');
expect(navigationSpan.status).toBe('ok');

expect(navigationSpan.attributes).toMatchObject({
'sentry.idle_span_finish_reason': { value: 'idleTimeout', type: 'string' },
'sentry.op': { value: 'navigation', type: 'string' },
'sentry.origin': { value: 'auto.navigation.react.reactrouter_v6', type: 'string' },
'sentry.sample_rate': { value: 1, type: 'integer' },
'sentry.segment.name.source': { value: 'route', type: 'string' },
'url.template': { value: '/lazy-loaded-user/:id/:innerId', type: 'string' },
'url.path': { value: '/lazy-loaded-user/5/foo', type: 'string' },
'url.full': {
value: expect.stringMatching(/^https?:\/\/localhost:\d+\/lazy-loaded-user\/5\/foo$/),
type: 'string',
},
});

expect(navigationSpan.links).toEqual(PREVIOUS_TRACE_LINK);

expect(await page.innerText('id=content')).toContain('I am a lazy loaded user');

// One span for the outer lazy route, one for the inner one
const resourceSpans = spans.filter(
span =>
getSpanOp(span) === 'resource.script' &&
span.attributes['sentry.origin']?.value === 'auto.resource.browser.metrics',
);
expect(resourceSpans.length).toBeGreaterThanOrEqual(2);

@cursorcursorBotSep 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lazy navigation counts pageload scripts

Medium Severity

collectStreamedSpans is started before page.goto('/'), so the later resource.script filter includes pageload bundle spans as well as lazy-navigation chunks. The toBeGreaterThanOrEqual(2) check can pass even when navigation never emits those lazy-route spans, so a regression in lazy navigation instrumentation would go unnoticed. Flagged because the review guidelines require tests to actually cover the behaviour they claim to check.

Fix in CursorFix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

Reviewed by Cursor Bugbot for commit 3ea1d9b. Configure here.

});
218 changes: 0 additions & 218 deletions ...ckages/e2e-tests/test-applications/react-create-browser-router/tests/transactions.test.ts
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion dev-packages/e2e-tests/test-applications/react-create-hash-router/src/index.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,6 @@ import Group from './pages/Group';
const replay = Sentry.replayIntegration();

Sentry.init({
traceLifecycle: 'static',
// environment: 'qa', // dynamic sampling bias to keep transactions
dsn: process.env.REACT_APP_E2E_TEST_DSN,
integrations: [
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
test(e2e): Port React Router E2E test apps to span streaming#23839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

andreiborza
wants to merge
1
commit into

from

 Closed


test(e2e): Port React Router E2E test apps to span streaming
#23839
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
dev-packages/e2e-tests/test-applications/react-create-browser-router/src/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,7 +15,6 @@ import User from './pages/User';
const replay = Sentry.replayIntegration();

Sentry.init({
 traceLifecycle: 'static',
 // environment: 'qa', // dynamic sampling bias to keep transactions
 dsn: process.env.REACT_APP_E2E_TEST_DSN,
 integrations: [
Expand Down

164 changes: 164 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-create-browser-router/tests/spans.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,164 @@
import { expect, test } from '@playwright/test';
import {
 collectStreamedSpans,
 getSpanOp,
 waitForStreamedSpan,
 waitForStreamedSpans,
} from '@sentry-internal/test-utils';

const PREVIOUS_TRACE_LINK = [
 {
 attributes: {
 'sentry.link.type': { value: 'previous_trace', type: 'string' },
 },
 sampled: true,
 span_id: expect.stringMatching(/[a-f0-9]{16}/),
 trace_id: expect.stringMatching(/[a-f0-9]{32}/),
 },
];

test('Captures a pageload span', async ({ page }) => {
 const spanPromise = waitForStreamedSpan('react-create-browser-router', span => {
 return getSpanOp(span) === 'pageload' && span.is_segment;
 });

 await page.goto('/');

 const span = await spanPromise;

 expect(span.name).toBe('/');
 expect(span.status).toBe('ok');
 expect(span.span_id).toMatch(/[a-f0-9]{16}/);
 expect(span.trace_id).toMatch(/[a-f0-9]{32}/);

 expect(span.attributes).toMatchObject({
 'device.memory.estimated_capacity': { value: expect.any(Number), type: expect.any(String) },
 'device.processor_count': { value: expect.any(Number), type: 'integer' },
 'network.connection.effective_type': { value: expect.any(String), type: 'string' },
 'sentry.idle_span_finish_reason': { value: 'idleTimeout', type: 'string' },
 'sentry.op': { value: 'pageload', type: 'string' },
 'sentry.origin': { value: 'auto.pageload.react.reactrouter_v6', type: 'string' },
 'sentry.sample_rate': { value: 1, type: 'integer' },
 'sentry.segment.name.source': { value: 'route', type: 'string' },
 'url.template': { value: '/', type: 'string' },
 'url.path': { value: '/', type: 'string' },
 'url.full': { value: expect.stringMatching(/^https?:\/\/localhost:\d+\/$/), type: 'string' },
 });
});

test('Captures a navigation span', async ({ page }) => {
 const spansPromise = waitForStreamedSpans('react-create-browser-router', spans => {
 return spans.some(span => getSpanOp(span) === 'navigation' && span.is_segment);
 });

 await page.goto('/');
 const linkElement = page.locator('id=navigation');
 await linkElement.click();

 const spans = await spansPromise;
 const navigationSpan = spans.find(span => span.is_segment)!;
@cursorcursorBotSep 1, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong segment picked for navigation
Medium Severity
The wait predicate requires a navigation segment, but the span under test is then selected with spans.find(span => span.is_segment). That envelope can also contain the still-finishing pageload segment, especially here because the click is not sequenced after pageload. Memory-router is most exposed because pageload and navigation share the name /user/:id. Flagged from the review guidelines on flaky waits that are not unique enough when telemetry can arrive in arbitrary order.
Additional Locations (2)
Fix in CursorFix in Web
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 3ea1d9b. Configure here.

 expect(navigationSpan.name).toBe('/user/:id');
 expect(navigationSpan.status).toBe('ok');
 expect(navigationSpan.span_id).toMatch(/[a-f0-9]{16}/);
 expect(navigationSpan.trace_id).toMatch(/[a-f0-9]{32}/);

 expect(navigationSpan.attributes).toMatchObject({
 'sentry.idle_span_finish_reason': { value: 'idleTimeout', type: 'string' },
 'sentry.op': { value: 'navigation', type: 'string' },
 'sentry.origin': { value: 'auto.navigation.react.reactrouter_v6', type: 'string' },
 'sentry.sample_rate': { value: 1, type: 'integer' },
 'sentry.segment.name.source': { value: 'route', type: 'string' },
 'url.template': { value: '/user/:id', type: 'string' },
 'url.path': { value: '/user/5', type: 'string' },
 'url.full': { value: expect.stringMatching(/^https?:\/\/localhost:\d+\/user\/5$/), type: 'string' },
 });

 expect(navigationSpan.links).toEqual(PREVIOUS_TRACE_LINK);

 // Filter out favicon spans which may or may not be present depending on the browser version
 const childSpans = spans.filter(
 span => !span.is_segment && !(span.attributes['url.full']?.value as string | undefined)?.includes('favicon'),
 );
 expect(childSpans).toEqual([]);
@cursorcursorBotSep 1, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Child-span absence checked too narrowly
Medium Severity
These tests expect navigation to have no child spans, but they only inspect the single envelope that contains the navigation segment. Streamed children flush as they end, often in earlier envelopes, so unexpected children would not be seen and the empty-array assertion would still pass. Flagged because the review guidelines call out relaxed negative assertions that do not actually prove something is absent from the payload.
Additional Locations (2)
Fix in CursorFix in Web
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 3ea1d9b. Configure here.
});

test('Captures a lazy pageload span', async ({ page }) => {
 const spansPromise = collectStreamedSpans('react-create-browser-router', spans => {
 return spans.some(span => getSpanOp(span) === 'pageload' && span.is_segment);
 });

 await page.goto('/lazy-loaded-user/5/foo');

 const spans = await spansPromise;
 const pageloadSpan = spans.find(span => getSpanOp(span) === 'pageload' && span.is_segment)!;

 expect(pageloadSpan.name).toBe('/lazy-loaded-user/:id/:innerId');
 expect(pageloadSpan.status).toBe('ok');

 expect(pageloadSpan.attributes).toMatchObject({
 'sentry.idle_span_finish_reason': { value: 'idleTimeout', type: 'string' },
 'sentry.op': { value: 'pageload', type: 'string' },
 'sentry.origin': { value: 'auto.pageload.react.reactrouter_v6', type: 'string' },
 'sentry.sample_rate': { value: 1, type: 'integer' },
 'sentry.segment.name.source': { value: 'route', type: 'string' },
 'url.template': { value: '/lazy-loaded-user/:id/:innerId', type: 'string' },
 'url.path': { value: '/lazy-loaded-user/5/foo', type: 'string' },
 'url.full': {
 value: expect.stringMatching(/^https?:\/\/localhost:\d+\/lazy-loaded-user\/5\/foo$/),
 type: 'string',
 },
 });

 expect(await page.innerText('id=content')).toContain('I am a lazy loaded user');

 // One span for the outer lazy route, one for the inner one
 const resourceSpans = spans.filter(
 span =>
 getSpanOp(span) === 'resource.script' &&
 span.attributes['sentry.origin']?.value === 'auto.resource.browser.metrics',
 );
 expect(resourceSpans.length).toBeGreaterThanOrEqual(2);
});

test('Captures a lazy navigation span', async ({ page }) => {
 const spansPromise = collectStreamedSpans('react-create-browser-router', spans => {
 return spans.some(span => getSpanOp(span) === 'navigation' && span.is_segment);
 });

 await page.goto('/');
 const linkElement = page.locator('id=lazy-navigation');
 await linkElement.click();

 const spans = await spansPromise;
 const navigationSpan = spans.find(span => getSpanOp(span) === 'navigation' && span.is_segment)!;

 expect(navigationSpan.name).toBe('/lazy-loaded-user/:id/:innerId');
 expect(navigationSpan.status).toBe('ok');

 expect(navigationSpan.attributes).toMatchObject({
 'sentry.idle_span_finish_reason': { value: 'idleTimeout', type: 'string' },
 'sentry.op': { value: 'navigation', type: 'string' },
 'sentry.origin': { value: 'auto.navigation.react.reactrouter_v6', type: 'string' },
 'sentry.sample_rate': { value: 1, type: 'integer' },
 'sentry.segment.name.source': { value: 'route', type: 'string' },
 'url.template': { value: '/lazy-loaded-user/:id/:innerId', type: 'string' },
 'url.path': { value: '/lazy-loaded-user/5/foo', type: 'string' },
 'url.full': {
 value: expect.stringMatching(/^https?:\/\/localhost:\d+\/lazy-loaded-user\/5\/foo$/),
 type: 'string',
 },
 });

 expect(navigationSpan.links).toEqual(PREVIOUS_TRACE_LINK);

 expect(await page.innerText('id=content')).toContain('I am a lazy loaded user');

 // One span for the outer lazy route, one for the inner one
 const resourceSpans = spans.filter(
 span =>
 getSpanOp(span) === 'resource.script' &&
 span.attributes['sentry.origin']?.value === 'auto.resource.browser.metrics',
 );
 expect(resourceSpans.length).toBeGreaterThanOrEqual(2);
@cursorcursorBotSep 1, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lazy navigation counts pageload scripts
Medium Severity
collectStreamedSpans is started before page.goto('/'), so the later resource.script filter includes pageload bundle spans as well as lazy-navigation chunks. The toBeGreaterThanOrEqual(2) check can pass even when navigation never emits those lazy-route spans, so a regression in lazy navigation instrumentation would go unnoticed. Flagged because the review guidelines require tests to actually cover the behaviour they claim to check.
Fix in CursorFix in Web
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 3ea1d9b. Configure here.
});

218 changes: 0 additions & 218 deletions
...ckages/e2e-tests/test-applications/react-create-browser-router/tests/transactions.test.ts

View file


Open in desktop


This file was deleted.


1 change: 0 additions & 1 deletion
dev-packages/e2e-tests/test-applications/react-create-hash-router/src/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,6 @@ import Group from './pages/Group';
const replay = Sentry.replayIntegration();

Sentry.init({
 traceLifecycle: 'static',
 // environment: 'qa', // dynamic sampling bias to keep transactions
 dsn: process.env.REACT_APP_E2E_TEST_DSN,
 integrations: [
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test(e2e): Port React Router E2E test apps to span streaming#23839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

andreiborza
wants to merge
1
commit into

from

 Closed


test(e2e): Port React Router E2E test apps to span streaming
#23839
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
dev-packages/e2e-tests/test-applications/react-create-browser-router/src/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,7 +15,6 @@ import User from './pages/User';
const replay = Sentry.replayIntegration();

Sentry.init({
 traceLifecycle: 'static',
 // environment: 'qa', // dynamic sampling bias to keep transactions
 dsn: process.env.REACT_APP_E2E_TEST_DSN,
 integrations: [
Expand Down

164 changes: 164 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-create-browser-router/tests/spans.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,164 @@
import { expect, test } from '@playwright/test';
import {
 collectStreamedSpans,
 getSpanOp,
 waitForStreamedSpan,
 waitForStreamedSpans,
} from '@sentry-internal/test-utils';

const PREVIOUS_TRACE_LINK = [
 {
 attributes: {
 'sentry.link.type': { value: 'previous_trace', type: 'string' },
 },
 sampled: true,
 span_id: expect.stringMatching(/[a-f0-9]{16}/),
 trace_id: expect.stringMatching(/[a-f0-9]{32}/),
 },
];

test('Captures a pageload span', async ({ page }) => {
 const spanPromise = waitForStreamedSpan('react-create-browser-router', span => {
 return getSpanOp(span) === 'pageload' && span.is_segment;
 });

 await page.goto('/');

 const span = await spanPromise;

 expect(span.name).toBe('/');
 expect(span.status).toBe('ok');
 expect(span.span_id).toMatch(/[a-f0-9]{16}/);
 expect(span.trace_id).toMatch(/[a-f0-9]{32}/);

 expect(span.attributes).toMatchObject({
 'device.memory.estimated_capacity': { value: expect.any(Number), type: expect.any(String) },
 'device.processor_count': { value: expect.any(Number), type: 'integer' },
 'network.connection.effective_type': { value: expect.any(String), type: 'string' },
 'sentry.idle_span_finish_reason': { value: 'idleTimeout', type: 'string' },
 'sentry.op': { value: 'pageload', type: 'string' },
 'sentry.origin': { value: 'auto.pageload.react.reactrouter_v6', type: 'string' },
 'sentry.sample_rate': { value: 1, type: 'integer' },
 'sentry.segment.name.source': { value: 'route', type: 'string' },
 'url.template': { value: '/', type: 'string' },
 'url.path': { value: '/', type: 'string' },
 'url.full': { value: expect.stringMatching(/^https?:\/\/localhost:\d+\/$/), type: 'string' },
 });
});

test('Captures a navigation span', async ({ page }) => {
 const spansPromise = waitForStreamedSpans('react-create-browser-router', spans => {
 return spans.some(span => getSpanOp(span) === 'navigation' && span.is_segment);
 });

 await page.goto('/');
 const linkElement = page.locator('id=navigation');
 await linkElement.click();

 const spans = await spansPromise;
 const navigationSpan = spans.find(span => span.is_segment)!;
@cursorcursorBotSep 1, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong segment picked for navigation
Medium Severity
The wait predicate requires a navigation segment, but the span under test is then selected with spans.find(span => span.is_segment). That envelope can also contain the still-finishing pageload segment, especially here because the click is not sequenced after pageload. Memory-router is most exposed because pageload and navigation share the name /user/:id. Flagged from the review guidelines on flaky waits that are not unique enough when telemetry can arrive in arbitrary order.
Additional Locations (2)
Fix in CursorFix in Web
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 3ea1d9b. Configure here.

 expect(navigationSpan.name).toBe('/user/:id');
 expect(navigationSpan.status).toBe('ok');
 expect(navigationSpan.span_id).toMatch(/[a-f0-9]{16}/);
 expect(navigationSpan.trace_id).toMatch(/[a-f0-9]{32}/);

 expect(navigationSpan.attributes).toMatchObject({
 'sentry.idle_span_finish_reason': { value: 'idleTimeout', type: 'string' },
 'sentry.op': { value: 'navigation', type: 'string' },
 'sentry.origin': { value: 'auto.navigation.react.reactrouter_v6', type: 'string' },
 'sentry.sample_rate': { value: 1, type: 'integer' },
 'sentry.segment.name.source': { value: 'route', type: 'string' },
 'url.template': { value: '/user/:id', type: 'string' },
 'url.path': { value: '/user/5', type: 'string' },
 'url.full': { value: expect.stringMatching(/^https?:\/\/localhost:\d+\/user\/5$/), type: 'string' },
 });

 expect(navigationSpan.links).toEqual(PREVIOUS_TRACE_LINK);

 // Filter out favicon spans which may or may not be present depending on the browser version
 const childSpans = spans.filter(
 span => !span.is_segment && !(span.attributes['url.full']?.value as string | undefined)?.includes('favicon'),
 );
 expect(childSpans).toEqual([]);
@cursorcursorBotSep 1, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Child-span absence checked too narrowly
Medium Severity
These tests expect navigation to have no child spans, but they only inspect the single envelope that contains the navigation segment. Streamed children flush as they end, often in earlier envelopes, so unexpected children would not be seen and the empty-array assertion would still pass. Flagged because the review guidelines call out relaxed negative assertions that do not actually prove something is absent from the payload.
Additional Locations (2)
Fix in CursorFix in Web
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 3ea1d9b. Configure here.
});

test('Captures a lazy pageload span', async ({ page }) => {
 const spansPromise = collectStreamedSpans('react-create-browser-router', spans => {
 return spans.some(span => getSpanOp(span) === 'pageload' && span.is_segment);
 });

 await page.goto('/lazy-loaded-user/5/foo');

 const spans = await spansPromise;
 const pageloadSpan = spans.find(span => getSpanOp(span) === 'pageload' && span.is_segment)!;

 expect(pageloadSpan.name).toBe('/lazy-loaded-user/:id/:innerId');
 expect(pageloadSpan.status).toBe('ok');

 expect(pageloadSpan.attributes).toMatchObject({
 'sentry.idle_span_finish_reason': { value: 'idleTimeout', type: 'string' },
 'sentry.op': { value: 'pageload', type: 'string' },
 'sentry.origin': { value: 'auto.pageload.react.reactrouter_v6', type: 'string' },
 'sentry.sample_rate': { value: 1, type: 'integer' },
 'sentry.segment.name.source': { value: 'route', type: 'string' },
 'url.template': { value: '/lazy-loaded-user/:id/:innerId', type: 'string' },
 'url.path': { value: '/lazy-loaded-user/5/foo', type: 'string' },
 'url.full': {
 value: expect.stringMatching(/^https?:\/\/localhost:\d+\/lazy-loaded-user\/5\/foo$/),
 type: 'string',
 },
 });

 expect(await page.innerText('id=content')).toContain('I am a lazy loaded user');

 // One span for the outer lazy route, one for the inner one
 const resourceSpans = spans.filter(
 span =>
 getSpanOp(span) === 'resource.script' &&
 span.attributes['sentry.origin']?.value === 'auto.resource.browser.metrics',
 );
 expect(resourceSpans.length).toBeGreaterThanOrEqual(2);
});

test('Captures a lazy navigation span', async ({ page }) => {
 const spansPromise = collectStreamedSpans('react-create-browser-router', spans => {
 return spans.some(span => getSpanOp(span) === 'navigation' && span.is_segment);
 });

 await page.goto('/');
 const linkElement = page.locator('id=lazy-navigation');
 await linkElement.click();

 const spans = await spansPromise;
 const navigationSpan = spans.find(span => getSpanOp(span) === 'navigation' && span.is_segment)!;

 expect(navigationSpan.name).toBe('/lazy-loaded-user/:id/:innerId');
 expect(navigationSpan.status).toBe('ok');

 expect(navigationSpan.attributes).toMatchObject({
 'sentry.idle_span_finish_reason': { value: 'idleTimeout', type: 'string' },
 'sentry.op': { value: 'navigation', type: 'string' },
 'sentry.origin': { value: 'auto.navigation.react.reactrouter_v6', type: 'string' },
 'sentry.sample_rate': { value: 1, type: 'integer' },
 'sentry.segment.name.source': { value: 'route', type: 'string' },
 'url.template': { value: '/lazy-loaded-user/:id/:innerId', type: 'string' },
 'url.path': { value: '/lazy-loaded-user/5/foo', type: 'string' },
 'url.full': {
 value: expect.stringMatching(/^https?:\/\/localhost:\d+\/lazy-loaded-user\/5\/foo$/),
 type: 'string',
 },
 });

 expect(navigationSpan.links).toEqual(PREVIOUS_TRACE_LINK);

 expect(await page.innerText('id=content')).toContain('I am a lazy loaded user');

 // One span for the outer lazy route, one for the inner one
 const resourceSpans = spans.filter(
 span =>
 getSpanOp(span) === 'resource.script' &&
 span.attributes['sentry.origin']?.value === 'auto.resource.browser.metrics',
 );
 expect(resourceSpans.length).toBeGreaterThanOrEqual(2);
@cursorcursorBotSep 1, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lazy navigation counts pageload scripts
Medium Severity
collectStreamedSpans is started before page.goto('/'), so the later resource.script filter includes pageload bundle spans as well as lazy-navigation chunks. The toBeGreaterThanOrEqual(2) check can pass even when navigation never emits those lazy-route spans, so a regression in lazy navigation instrumentation would go unnoticed. Flagged because the review guidelines require tests to actually cover the behaviour they claim to check.
Fix in CursorFix in Web
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 3ea1d9b. Configure here.
});

218 changes: 0 additions & 218 deletions
...ckages/e2e-tests/test-applications/react-create-browser-router/tests/transactions.test.ts

View file


Open in desktop


This file was deleted.


1 change: 0 additions & 1 deletion
dev-packages/e2e-tests/test-applications/react-create-hash-router/src/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,6 @@ import Group from './pages/Group';
const replay = Sentry.replayIntegration();

Sentry.init({
 traceLifecycle: 'static',
 // environment: 'qa', // dynamic sampling bias to keep transactions
 dsn: process.env.REACT_APP_E2E_TEST_DSN,
 integrations: [
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test(e2e): Port React Router E2E test apps to span streaming#23839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

andreiborza
wants to merge
1
commit into

from

 Closed


test(e2e): Port React Router E2E test apps to span streaming
#23839
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
dev-packages/e2e-tests/test-applications/react-create-browser-router/src/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,7 +15,6 @@ import User from './pages/User';
const replay = Sentry.replayIntegration();

Sentry.init({
 traceLifecycle: 'static',
 // environment: 'qa', // dynamic sampling bias to keep transactions
 dsn: process.env.REACT_APP_E2E_TEST_DSN,
 integrations: [
Expand Down

164 changes: 164 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-create-browser-router/tests/spans.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,164 @@
import { expect, test } from '@playwright/test';
import {
 collectStreamedSpans,
 getSpanOp,
 waitForStreamedSpan,
 waitForStreamedSpans,
} from '@sentry-internal/test-utils';

const PREVIOUS_TRACE_LINK = [
 {
 attributes: {
 'sentry.link.type': { value: 'previous_trace', type: 'string' },
 },
 sampled: true,
 span_id: expect.stringMatching(/[a-f0-9]{16}/),
 trace_id: expect.stringMatching(/[a-f0-9]{32}/),
 },
];

test('Captures a pageload span', async ({ page }) => {
 const spanPromise = waitForStreamedSpan('react-create-browser-router', span => {
 return getSpanOp(span) === 'pageload' && span.is_segment;
 });

 await page.goto('/');

 const span = await spanPromise;

 expect(span.name).toBe('/');
 expect(span.status).toBe('ok');
 expect(span.span_id).toMatch(/[a-f0-9]{16}/);
 expect(span.trace_id).toMatch(/[a-f0-9]{32}/);

 expect(span.attributes).toMatchObject({
 'device.memory.estimated_capacity': { value: expect.any(Number), type: expect.any(String) },
 'device.processor_count': { value: expect.any(Number), type: 'integer' },
 'network.connection.effective_type': { value: expect.any(String), type: 'string' },
 'sentry.idle_span_finish_reason': { value: 'idleTimeout', type: 'string' },
 'sentry.op': { value: 'pageload', type: 'string' },
 'sentry.origin': { value: 'auto.pageload.react.reactrouter_v6', type: 'string' },
 'sentry.sample_rate': { value: 1, type: 'integer' },
 'sentry.segment.name.source': { value: 'route', type: 'string' },
 'url.template': { value: '/', type: 'string' },
 'url.path': { value: '/', type: 'string' },
 'url.full': { value: expect.stringMatching(/^https?:\/\/localhost:\d+\/$/), type: 'string' },
 });
});

test('Captures a navigation span', async ({ page }) => {
 const spansPromise = waitForStreamedSpans('react-create-browser-router', spans => {
 return spans.some(span => getSpanOp(span) === 'navigation' && span.is_segment);
 });

 await page.goto('/');
 const linkElement = page.locator('id=navigation');
 await linkElement.click();

 const spans = await spansPromise;
 const navigationSpan = spans.find(span => span.is_segment)!;
@cursorcursorBotSep 1, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong segment picked for navigation
Medium Severity
The wait predicate requires a navigation segment, but the span under test is then selected with spans.find(span => span.is_segment). That envelope can also contain the still-finishing pageload segment, especially here because the click is not sequenced after pageload. Memory-router is most exposed because pageload and navigation share the name /user/:id. Flagged from the review guidelines on flaky waits that are not unique enough when telemetry can arrive in arbitrary order.
Additional Locations (2)
Fix in CursorFix in Web
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 3ea1d9b. Configure here.

 expect(navigationSpan.name).toBe('/user/:id');
 expect(navigationSpan.status).toBe('ok');
 expect(navigationSpan.span_id).toMatch(/[a-f0-9]{16}/);
 expect(navigationSpan.trace_id).toMatch(/[a-f0-9]{32}/);

 expect(navigationSpan.attributes).toMatchObject({
 'sentry.idle_span_finish_reason': { value: 'idleTimeout', type: 'string' },
 'sentry.op': { value: 'navigation', type: 'string' },
 'sentry.origin': { value: 'auto.navigation.react.reactrouter_v6', type: 'string' },
 'sentry.sample_rate': { value: 1, type: 'integer' },
 'sentry.segment.name.source': { value: 'route', type: 'string' },
 'url.template': { value: '/user/:id', type: 'string' },
 'url.path': { value: '/user/5', type: 'string' },
 'url.full': { value: expect.stringMatching(/^https?:\/\/localhost:\d+\/user\/5$/), type: 'string' },
 });

 expect(navigationSpan.links).toEqual(PREVIOUS_TRACE_LINK);

 // Filter out favicon spans which may or may not be present depending on the browser version
 const childSpans = spans.filter(
 span => !span.is_segment && !(span.attributes['url.full']?.value as string | undefined)?.includes('favicon'),
 );
 expect(childSpans).toEqual([]);
@cursorcursorBotSep 1, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Child-span absence checked too narrowly
Medium Severity
These tests expect navigation to have no child spans, but they only inspect the single envelope that contains the navigation segment. Streamed children flush as they end, often in earlier envelopes, so unexpected children would not be seen and the empty-array assertion would still pass. Flagged because the review guidelines call out relaxed negative assertions that do not actually prove something is absent from the payload.
Additional Locations (2)
Fix in CursorFix in Web
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 3ea1d9b. Configure here.
});

test('Captures a lazy pageload span', async ({ page }) => {
 const spansPromise = collectStreamedSpans('react-create-browser-router', spans => {
 return spans.some(span => getSpanOp(span) === 'pageload' && span.is_segment);
 });

 await page.goto('/lazy-loaded-user/5/foo');

 const spans = await spansPromise;
 const pageloadSpan = spans.find(span => getSpanOp(span) === 'pageload' && span.is_segment)!;

 expect(pageloadSpan.name).toBe('/lazy-loaded-user/:id/:innerId');
 expect(pageloadSpan.status).toBe('ok');

 expect(pageloadSpan.attributes).toMatchObject({
 'sentry.idle_span_finish_reason': { value: 'idleTimeout', type: 'string' },
 'sentry.op': { value: 'pageload', type: 'string' },
 'sentry.origin': { value: 'auto.pageload.react.reactrouter_v6', type: 'string' },
 'sentry.sample_rate': { value: 1, type: 'integer' },
 'sentry.segment.name.source': { value: 'route', type: 'string' },
 'url.template': { value: '/lazy-loaded-user/:id/:innerId', type: 'string' },
 'url.path': { value: '/lazy-loaded-user/5/foo', type: 'string' },
 'url.full': {
 value: expect.stringMatching(/^https?:\/\/localhost:\d+\/lazy-loaded-user\/5\/foo$/),
 type: 'string',
 },
 });

 expect(await page.innerText('id=content')).toContain('I am a lazy loaded user');

 // One span for the outer lazy route, one for the inner one
 const resourceSpans = spans.filter(
 span =>
 getSpanOp(span) === 'resource.script' &&
 span.attributes['sentry.origin']?.value === 'auto.resource.browser.metrics',
 );
 expect(resourceSpans.length).toBeGreaterThanOrEqual(2);
});

test('Captures a lazy navigation span', async ({ page }) => {
 const spansPromise = collectStreamedSpans('react-create-browser-router', spans => {
 return spans.some(span => getSpanOp(span) === 'navigation' && span.is_segment);
 });

 await page.goto('/');
 const linkElement = page.locator('id=lazy-navigation');
 await linkElement.click();

 const spans = await spansPromise;
 const navigationSpan = spans.find(span => getSpanOp(span) === 'navigation' && span.is_segment)!;

 expect(navigationSpan.name).toBe('/lazy-loaded-user/:id/:innerId');
 expect(navigationSpan.status).toBe('ok');

 expect(navigationSpan.attributes).toMatchObject({
 'sentry.idle_span_finish_reason': { value: 'idleTimeout', type: 'string' },
 'sentry.op': { value: 'navigation', type: 'string' },
 'sentry.origin': { value: 'auto.navigation.react.reactrouter_v6', type: 'string' },
 'sentry.sample_rate': { value: 1, type: 'integer' },
 'sentry.segment.name.source': { value: 'route', type: 'string' },
 'url.template': { value: '/lazy-loaded-user/:id/:innerId', type: 'string' },
 'url.path': { value: '/lazy-loaded-user/5/foo', type: 'string' },
 'url.full': {
 value: expect.stringMatching(/^https?:\/\/localhost:\d+\/lazy-loaded-user\/5\/foo$/),
 type: 'string',
 },
 });

 expect(navigationSpan.links).toEqual(PREVIOUS_TRACE_LINK);

 expect(await page.innerText('id=content')).toContain('I am a lazy loaded user');

 // One span for the outer lazy route, one for the inner one
 const resourceSpans = spans.filter(
 span =>
 getSpanOp(span) === 'resource.script' &&
 span.attributes['sentry.origin']?.value === 'auto.resource.browser.metrics',
 );
 expect(resourceSpans.length).toBeGreaterThanOrEqual(2);
@cursorcursorBotSep 1, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lazy navigation counts pageload scripts
Medium Severity
collectStreamedSpans is started before page.goto('/'), so the later resource.script filter includes pageload bundle spans as well as lazy-navigation chunks. The toBeGreaterThanOrEqual(2) check can pass even when navigation never emits those lazy-route spans, so a regression in lazy navigation instrumentation would go unnoticed. Flagged because the review guidelines require tests to actually cover the behaviour they claim to check.
Fix in CursorFix in Web
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 3ea1d9b. Configure here.
});

218 changes: 0 additions & 218 deletions
...ckages/e2e-tests/test-applications/react-create-browser-router/tests/transactions.test.ts

View file


Open in desktop


This file was deleted.


1 change: 0 additions & 1 deletion
dev-packages/e2e-tests/test-applications/react-create-hash-router/src/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,6 @@ import Group from './pages/Group';
const replay = Sentry.replayIntegration();

Sentry.init({
 traceLifecycle: 'static',
 // environment: 'qa', // dynamic sampling bias to keep transactions
 dsn: process.env.REACT_APP_E2E_TEST_DSN,
 integrations: [
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
test(e2e): Port React Router E2E test apps to span streaming#23839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

andreiborza
wants to merge
1
commit into

from

 Closed


test(e2e): Port React Router E2E test apps to span streaming
#23839
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
dev-packages/e2e-tests/test-applications/react-create-browser-router/src/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,7 +15,6 @@ import User from './pages/User';
const replay = Sentry.replayIntegration();

Sentry.init({
 traceLifecycle: 'static',
 // environment: 'qa', // dynamic sampling bias to keep transactions
 dsn: process.env.REACT_APP_E2E_TEST_DSN,
 integrations: [
Expand Down

164 changes: 164 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-create-browser-router/tests/spans.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,164 @@
import { expect, test } from '@playwright/test';
import {
 collectStreamedSpans,
 getSpanOp,
 waitForStreamedSpan,
 waitForStreamedSpans,
} from '@sentry-internal/test-utils';

const PREVIOUS_TRACE_LINK = [
 {
 attributes: {
 'sentry.link.type': { value: 'previous_trace', type: 'string' },
 },
 sampled: true,
 span_id: expect.stringMatching(/[a-f0-9]{16}/),
 trace_id: expect.stringMatching(/[a-f0-9]{32}/),
 },
];

test('Captures a pageload span', async ({ page }) => {
 const spanPromise = waitForStreamedSpan('react-create-browser-router', span => {
 return getSpanOp(span) === 'pageload' && span.is_segment;
 });

 await page.goto('/');

 const span = await spanPromise;

 expect(span.name).toBe('/');
 expect(span.status).toBe('ok');
 expect(span.span_id).toMatch(/[a-f0-9]{16}/);
 expect(span.trace_id).toMatch(/[a-f0-9]{32}/);

 expect(span.attributes).toMatchObject({
 'device.memory.estimated_capacity': { value: expect.any(Number), type: expect.any(String) },
 'device.processor_count': { value: expect.any(Number), type: 'integer' },
 'network.connection.effective_type': { value: expect.any(String), type: 'string' },
 'sentry.idle_span_finish_reason': { value: 'idleTimeout', type: 'string' },
 'sentry.op': { value: 'pageload', type: 'string' },
 'sentry.origin': { value: 'auto.pageload.react.reactrouter_v6', type: 'string' },
 'sentry.sample_rate': { value: 1, type: 'integer' },
 'sentry.segment.name.source': { value: 'route', type: 'string' },
 'url.template': { value: '/', type: 'string' },
 'url.path': { value: '/', type: 'string' },
 'url.full': { value: expect.stringMatching(/^https?:\/\/localhost:\d+\/$/), type: 'string' },
 });
});

test('Captures a navigation span', async ({ page }) => {
 const spansPromise = waitForStreamedSpans('react-create-browser-router', spans => {
 return spans.some(span => getSpanOp(span) === 'navigation' && span.is_segment);
 });

 await page.goto('/');
 const linkElement = page.locator('id=navigation');
 await linkElement.click();

 const spans = await spansPromise;
 const navigationSpan = spans.find(span => span.is_segment)!;
@cursorcursorBotSep 1, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong segment picked for navigation
Medium Severity
The wait predicate requires a navigation segment, but the span under test is then selected with spans.find(span => span.is_segment). That envelope can also contain the still-finishing pageload segment, especially here because the click is not sequenced after pageload. Memory-router is most exposed because pageload and navigation share the name /user/:id. Flagged from the review guidelines on flaky waits that are not unique enough when telemetry can arrive in arbitrary order.
Additional Locations (2)
Fix in CursorFix in Web
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 3ea1d9b. Configure here.

 expect(navigationSpan.name).toBe('/user/:id');
 expect(navigationSpan.status).toBe('ok');
 expect(navigationSpan.span_id).toMatch(/[a-f0-9]{16}/);
 expect(navigationSpan.trace_id).toMatch(/[a-f0-9]{32}/);

 expect(navigationSpan.attributes).toMatchObject({
 'sentry.idle_span_finish_reason': { value: 'idleTimeout', type: 'string' },
 'sentry.op': { value: 'navigation', type: 'string' },
 'sentry.origin': { value: 'auto.navigation.react.reactrouter_v6', type: 'string' },
 'sentry.sample_rate': { value: 1, type: 'integer' },
 'sentry.segment.name.source': { value: 'route', type: 'string' },
 'url.template': { value: '/user/:id', type: 'string' },
 'url.path': { value: '/user/5', type: 'string' },
 'url.full': { value: expect.stringMatching(/^https?:\/\/localhost:\d+\/user\/5$/), type: 'string' },
 });

 expect(navigationSpan.links).toEqual(PREVIOUS_TRACE_LINK);

 // Filter out favicon spans which may or may not be present depending on the browser version
 const childSpans = spans.filter(
 span => !span.is_segment && !(span.attributes['url.full']?.value as string | undefined)?.includes('favicon'),
 );
 expect(childSpans).toEqual([]);
@cursorcursorBotSep 1, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Child-span absence checked too narrowly
Medium Severity
These tests expect navigation to have no child spans, but they only inspect the single envelope that contains the navigation segment. Streamed children flush as they end, often in earlier envelopes, so unexpected children would not be seen and the empty-array assertion would still pass. Flagged because the review guidelines call out relaxed negative assertions that do not actually prove something is absent from the payload.
Additional Locations (2)
Fix in CursorFix in Web
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 3ea1d9b. Configure here.
});

test('Captures a lazy pageload span', async ({ page }) => {
 const spansPromise = collectStreamedSpans('react-create-browser-router', spans => {
 return spans.some(span => getSpanOp(span) === 'pageload' && span.is_segment);
 });

 await page.goto('/lazy-loaded-user/5/foo');

 const spans = await spansPromise;
 const pageloadSpan = spans.find(span => getSpanOp(span) === 'pageload' && span.is_segment)!;

 expect(pageloadSpan.name).toBe('/lazy-loaded-user/:id/:innerId');
 expect(pageloadSpan.status).toBe('ok');

 expect(pageloadSpan.attributes).toMatchObject({
 'sentry.idle_span_finish_reason': { value: 'idleTimeout', type: 'string' },
 'sentry.op': { value: 'pageload', type: 'string' },
 'sentry.origin': { value: 'auto.pageload.react.reactrouter_v6', type: 'string' },
 'sentry.sample_rate': { value: 1, type: 'integer' },
 'sentry.segment.name.source': { value: 'route', type: 'string' },
 'url.template': { value: '/lazy-loaded-user/:id/:innerId', type: 'string' },
 'url.path': { value: '/lazy-loaded-user/5/foo', type: 'string' },
 'url.full': {
 value: expect.stringMatching(/^https?:\/\/localhost:\d+\/lazy-loaded-user\/5\/foo$/),
 type: 'string',
 },
 });

 expect(await page.innerText('id=content')).toContain('I am a lazy loaded user');

 // One span for the outer lazy route, one for the inner one
 const resourceSpans = spans.filter(
 span =>
 getSpanOp(span) === 'resource.script' &&
 span.attributes['sentry.origin']?.value === 'auto.resource.browser.metrics',
 );
 expect(resourceSpans.length).toBeGreaterThanOrEqual(2);
});

test('Captures a lazy navigation span', async ({ page }) => {
 const spansPromise = collectStreamedSpans('react-create-browser-router', spans => {
 return spans.some(span => getSpanOp(span) === 'navigation' && span.is_segment);
 });

 await page.goto('/');
 const linkElement = page.locator('id=lazy-navigation');
 await linkElement.click();

 const spans = await spansPromise;
 const navigationSpan = spans.find(span => getSpanOp(span) === 'navigation' && span.is_segment)!;

 expect(navigationSpan.name).toBe('/lazy-loaded-user/:id/:innerId');
 expect(navigationSpan.status).toBe('ok');

 expect(navigationSpan.attributes).toMatchObject({
 'sentry.idle_span_finish_reason': { value: 'idleTimeout', type: 'string' },
 'sentry.op': { value: 'navigation', type: 'string' },
 'sentry.origin': { value: 'auto.navigation.react.reactrouter_v6', type: 'string' },
 'sentry.sample_rate': { value: 1, type: 'integer' },
 'sentry.segment.name.source': { value: 'route', type: 'string' },
 'url.template': { value: '/lazy-loaded-user/:id/:innerId', type: 'string' },
 'url.path': { value: '/lazy-loaded-user/5/foo', type: 'string' },
 'url.full': {
 value: expect.stringMatching(/^https?:\/\/localhost:\d+\/lazy-loaded-user\/5\/foo$/),
 type: 'string',
 },
 });

 expect(navigationSpan.links).toEqual(PREVIOUS_TRACE_LINK);

 expect(await page.innerText('id=content')).toContain('I am a lazy loaded user');

 // One span for the outer lazy route, one for the inner one
 const resourceSpans = spans.filter(
 span =>
 getSpanOp(span) === 'resource.script' &&
 span.attributes['sentry.origin']?.value === 'auto.resource.browser.metrics',
 );
 expect(resourceSpans.length).toBeGreaterThanOrEqual(2);
@cursorcursorBotSep 1, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lazy navigation counts pageload scripts
Medium Severity
collectStreamedSpans is started before page.goto('/'), so the later resource.script filter includes pageload bundle spans as well as lazy-navigation chunks. The toBeGreaterThanOrEqual(2) check can pass even when navigation never emits those lazy-route spans, so a regression in lazy navigation instrumentation would go unnoticed. Flagged because the review guidelines require tests to actually cover the behaviour they claim to check.
Fix in CursorFix in Web
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 3ea1d9b. Configure here.
});

218 changes: 0 additions & 218 deletions
...ckages/e2e-tests/test-applications/react-create-browser-router/tests/transactions.test.ts

View file


Open in desktop


This file was deleted.


1 change: 0 additions & 1 deletion
dev-packages/e2e-tests/test-applications/react-create-hash-router/src/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,6 @@ import Group from './pages/Group';
const replay = Sentry.replayIntegration();

Sentry.init({
 traceLifecycle: 'static',
 // environment: 'qa', // dynamic sampling bias to keep transactions
 dsn: process.env.REACT_APP_E2E_TEST_DSN,
 integrations: [
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test(e2e): Port React Router E2E test apps to span streaming#23839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

andreiborza
wants to merge
1
commit into

from

 Closed


test(e2e): Port React Router E2E test apps to span streaming
#23839
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
dev-packages/e2e-tests/test-applications/react-create-browser-router/src/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,7 +15,6 @@ import User from './pages/User';
const replay = Sentry.replayIntegration();

Sentry.init({
 traceLifecycle: 'static',
 // environment: 'qa', // dynamic sampling bias to keep transactions
 dsn: process.env.REACT_APP_E2E_TEST_DSN,
 integrations: [
Expand Down

164 changes: 164 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-create-browser-router/tests/spans.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,164 @@
import { expect, test } from '@playwright/test';
import {
 collectStreamedSpans,
 getSpanOp,
 waitForStreamedSpan,
 waitForStreamedSpans,
} from '@sentry-internal/test-utils';

const PREVIOUS_TRACE_LINK = [
 {
 attributes: {
 'sentry.link.type': { value: 'previous_trace', type: 'string' },
 },
 sampled: true,
 span_id: expect.stringMatching(/[a-f0-9]{16}/),
 trace_id: expect.stringMatching(/[a-f0-9]{32}/),
 },
];

test('Captures a pageload span', async ({ page }) => {
 const spanPromise = waitForStreamedSpan('react-create-browser-router', span => {
 return getSpanOp(span) === 'pageload' && span.is_segment;
 });

 await page.goto('/');

 const span = await spanPromise;

 expect(span.name).toBe('/');
 expect(span.status).toBe('ok');
 expect(span.span_id).toMatch(/[a-f0-9]{16}/);
 expect(span.trace_id).toMatch(/[a-f0-9]{32}/);

 expect(span.attributes).toMatchObject({
 'device.memory.estimated_capacity': { value: expect.any(Number), type: expect.any(String) },
 'device.processor_count': { value: expect.any(Number), type: 'integer' },
 'network.connection.effective_type': { value: expect.any(String), type: 'string' },
 'sentry.idle_span_finish_reason': { value: 'idleTimeout', type: 'string' },
 'sentry.op': { value: 'pageload', type: 'string' },
 'sentry.origin': { value: 'auto.pageload.react.reactrouter_v6', type: 'string' },
 'sentry.sample_rate': { value: 1, type: 'integer' },
 'sentry.segment.name.source': { value: 'route', type: 'string' },
 'url.template': { value: '/', type: 'string' },
 'url.path': { value: '/', type: 'string' },
 'url.full': { value: expect.stringMatching(/^https?:\/\/localhost:\d+\/$/), type: 'string' },
 });
});

test('Captures a navigation span', async ({ page }) => {
 const spansPromise = waitForStreamedSpans('react-create-browser-router', spans => {
 return spans.some(span => getSpanOp(span) === 'navigation' && span.is_segment);
 });

 await page.goto('/');
 const linkElement = page.locator('id=navigation');
 await linkElement.click();

 const spans = await spansPromise;
 const navigationSpan = spans.find(span => span.is_segment)!;
@cursorcursorBotSep 1, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong segment picked for navigation
Medium Severity
The wait predicate requires a navigation segment, but the span under test is then selected with spans.find(span => span.is_segment). That envelope can also contain the still-finishing pageload segment, especially here because the click is not sequenced after pageload. Memory-router is most exposed because pageload and navigation share the name /user/:id. Flagged from the review guidelines on flaky waits that are not unique enough when telemetry can arrive in arbitrary order.
Additional Locations (2)
Fix in CursorFix in Web
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 3ea1d9b. Configure here.

 expect(navigationSpan.name).toBe('/user/:id');
 expect(navigationSpan.status).toBe('ok');
 expect(navigationSpan.span_id).toMatch(/[a-f0-9]{16}/);
 expect(navigationSpan.trace_id).toMatch(/[a-f0-9]{32}/);

 expect(navigationSpan.attributes).toMatchObject({
 'sentry.idle_span_finish_reason': { value: 'idleTimeout', type: 'string' },
 'sentry.op': { value: 'navigation', type: 'string' },
 'sentry.origin': { value: 'auto.navigation.react.reactrouter_v6', type: 'string' },
 'sentry.sample_rate': { value: 1, type: 'integer' },
 'sentry.segment.name.source': { value: 'route', type: 'string' },
 'url.template': { value: '/user/:id', type: 'string' },
 'url.path': { value: '/user/5', type: 'string' },
 'url.full': { value: expect.stringMatching(/^https?:\/\/localhost:\d+\/user\/5$/), type: 'string' },
 });

 expect(navigationSpan.links).toEqual(PREVIOUS_TRACE_LINK);

 // Filter out favicon spans which may or may not be present depending on the browser version
 const childSpans = spans.filter(
 span => !span.is_segment && !(span.attributes['url.full']?.value as string | undefined)?.includes('favicon'),
 );
 expect(childSpans).toEqual([]);
@cursorcursorBotSep 1, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Child-span absence checked too narrowly
Medium Severity
These tests expect navigation to have no child spans, but they only inspect the single envelope that contains the navigation segment. Streamed children flush as they end, often in earlier envelopes, so unexpected children would not be seen and the empty-array assertion would still pass. Flagged because the review guidelines call out relaxed negative assertions that do not actually prove something is absent from the payload.
Additional Locations (2)
Fix in CursorFix in Web
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 3ea1d9b. Configure here.
});

test('Captures a lazy pageload span', async ({ page }) => {
 const spansPromise = collectStreamedSpans('react-create-browser-router', spans => {
 return spans.some(span => getSpanOp(span) === 'pageload' && span.is_segment);
 });

 await page.goto('/lazy-loaded-user/5/foo');

 const spans = await spansPromise;
 const pageloadSpan = spans.find(span => getSpanOp(span) === 'pageload' && span.is_segment)!;

 expect(pageloadSpan.name).toBe('/lazy-loaded-user/:id/:innerId');
 expect(pageloadSpan.status).toBe('ok');

 expect(pageloadSpan.attributes).toMatchObject({
 'sentry.idle_span_finish_reason': { value: 'idleTimeout', type: 'string' },
 'sentry.op': { value: 'pageload', type: 'string' },
 'sentry.origin': { value: 'auto.pageload.react.reactrouter_v6', type: 'string' },
 'sentry.sample_rate': { value: 1, type: 'integer' },
 'sentry.segment.name.source': { value: 'route', type: 'string' },
 'url.template': { value: '/lazy-loaded-user/:id/:innerId', type: 'string' },
 'url.path': { value: '/lazy-loaded-user/5/foo', type: 'string' },
 'url.full': {
 value: expect.stringMatching(/^https?:\/\/localhost:\d+\/lazy-loaded-user\/5\/foo$/),
 type: 'string',
 },
 });

 expect(await page.innerText('id=content')).toContain('I am a lazy loaded user');

 // One span for the outer lazy route, one for the inner one
 const resourceSpans = spans.filter(
 span =>
 getSpanOp(span) === 'resource.script' &&
 span.attributes['sentry.origin']?.value === 'auto.resource.browser.metrics',
 );
 expect(resourceSpans.length).toBeGreaterThanOrEqual(2);
});

test('Captures a lazy navigation span', async ({ page }) => {
 const spansPromise = collectStreamedSpans('react-create-browser-router', spans => {
 return spans.some(span => getSpanOp(span) === 'navigation' && span.is_segment);
 });

 await page.goto('/');
 const linkElement = page.locator('id=lazy-navigation');
 await linkElement.click();

 const spans = await spansPromise;
 const navigationSpan = spans.find(span => getSpanOp(span) === 'navigation' && span.is_segment)!;

 expect(navigationSpan.name).toBe('/lazy-loaded-user/:id/:innerId');
 expect(navigationSpan.status).toBe('ok');

 expect(navigationSpan.attributes).toMatchObject({
 'sentry.idle_span_finish_reason': { value: 'idleTimeout', type: 'string' },
 'sentry.op': { value: 'navigation', type: 'string' },
 'sentry.origin': { value: 'auto.navigation.react.reactrouter_v6', type: 'string' },
 'sentry.sample_rate': { value: 1, type: 'integer' },
 'sentry.segment.name.source': { value: 'route', type: 'string' },
 'url.template': { value: '/lazy-loaded-user/:id/:innerId', type: 'string' },
 'url.path': { value: '/lazy-loaded-user/5/foo', type: 'string' },
 'url.full': {
 value: expect.stringMatching(/^https?:\/\/localhost:\d+\/lazy-loaded-user\/5\/foo$/),
 type: 'string',
 },
 });

 expect(navigationSpan.links).toEqual(PREVIOUS_TRACE_LINK);

 expect(await page.innerText('id=content')).toContain('I am a lazy loaded user');

 // One span for the outer lazy route, one for the inner one
 const resourceSpans = spans.filter(
 span =>
 getSpanOp(span) === 'resource.script' &&
 span.attributes['sentry.origin']?.value === 'auto.resource.browser.metrics',
 );
 expect(resourceSpans.length).toBeGreaterThanOrEqual(2);
@cursorcursorBotSep 1, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lazy navigation counts pageload scripts
Medium Severity
collectStreamedSpans is started before page.goto('/'), so the later resource.script filter includes pageload bundle spans as well as lazy-navigation chunks. The toBeGreaterThanOrEqual(2) check can pass even when navigation never emits those lazy-route spans, so a regression in lazy navigation instrumentation would go unnoticed. Flagged because the review guidelines require tests to actually cover the behaviour they claim to check.
Fix in CursorFix in Web
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 3ea1d9b. Configure here.
});

218 changes: 0 additions & 218 deletions
...ckages/e2e-tests/test-applications/react-create-browser-router/tests/transactions.test.ts

View file


Open in desktop


This file was deleted.


1 change: 0 additions & 1 deletion
dev-packages/e2e-tests/test-applications/react-create-hash-router/src/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,6 @@ import Group from './pages/Group';
const replay = Sentry.replayIntegration();

Sentry.init({
 traceLifecycle: 'static',
 // environment: 'qa', // dynamic sampling bias to keep transactions
 dsn: process.env.REACT_APP_E2E_TEST_DSN,
 integrations: [
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test(e2e): Port React Router E2E test apps to span streaming#23839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

andreiborza
wants to merge
1
commit into

from

 Closed


test(e2e): Port React Router E2E test apps to span streaming
#23839
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
dev-packages/e2e-tests/test-applications/react-create-browser-router/src/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,7 +15,6 @@ import User from './pages/User';
const replay = Sentry.replayIntegration();

Sentry.init({
 traceLifecycle: 'static',
 // environment: 'qa', // dynamic sampling bias to keep transactions
 dsn: process.env.REACT_APP_E2E_TEST_DSN,
 integrations: [
Expand Down

164 changes: 164 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-create-browser-router/tests/spans.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,164 @@
import { expect, test } from '@playwright/test';
import {
 collectStreamedSpans,
 getSpanOp,
 waitForStreamedSpan,
 waitForStreamedSpans,
} from '@sentry-internal/test-utils';

const PREVIOUS_TRACE_LINK = [
 {
 attributes: {
 'sentry.link.type': { value: 'previous_trace', type: 'string' },
 },
 sampled: true,
 span_id: expect.stringMatching(/[a-f0-9]{16}/),
 trace_id: expect.stringMatching(/[a-f0-9]{32}/),
 },
];

test('Captures a pageload span', async ({ page }) => {
 const spanPromise = waitForStreamedSpan('react-create-browser-router', span => {
 return getSpanOp(span) === 'pageload' && span.is_segment;
 });

 await page.goto('/');

 const span = await spanPromise;

 expect(span.name).toBe('/');
 expect(span.status).toBe('ok');
 expect(span.span_id).toMatch(/[a-f0-9]{16}/);
 expect(span.trace_id).toMatch(/[a-f0-9]{32}/);

 expect(span.attributes).toMatchObject({
 'device.memory.estimated_capacity': { value: expect.any(Number), type: expect.any(String) },
 'device.processor_count': { value: expect.any(Number), type: 'integer' },
 'network.connection.effective_type': { value: expect.any(String), type: 'string' },
 'sentry.idle_span_finish_reason': { value: 'idleTimeout', type: 'string' },
 'sentry.op': { value: 'pageload', type: 'string' },
 'sentry.origin': { value: 'auto.pageload.react.reactrouter_v6', type: 'string' },
 'sentry.sample_rate': { value: 1, type: 'integer' },
 'sentry.segment.name.source': { value: 'route', type: 'string' },
 'url.template': { value: '/', type: 'string' },
 'url.path': { value: '/', type: 'string' },
 'url.full': { value: expect.stringMatching(/^https?:\/\/localhost:\d+\/$/), type: 'string' },
 });
});

test('Captures a navigation span', async ({ page }) => {
 const spansPromise = waitForStreamedSpans('react-create-browser-router', spans => {
 return spans.some(span => getSpanOp(span) === 'navigation' && span.is_segment);
 });

 await page.goto('/');
 const linkElement = page.locator('id=navigation');
 await linkElement.click();

 const spans = await spansPromise;
 const navigationSpan = spans.find(span => span.is_segment)!;
@cursorcursorBotSep 1, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong segment picked for navigation
Medium Severity
The wait predicate requires a navigation segment, but the span under test is then selected with spans.find(span => span.is_segment). That envelope can also contain the still-finishing pageload segment, especially here because the click is not sequenced after pageload. Memory-router is most exposed because pageload and navigation share the name /user/:id. Flagged from the review guidelines on flaky waits that are not unique enough when telemetry can arrive in arbitrary order.
Additional Locations (2)
Fix in CursorFix in Web
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 3ea1d9b. Configure here.

 expect(navigationSpan.name).toBe('/user/:id');
 expect(navigationSpan.status).toBe('ok');
 expect(navigationSpan.span_id).toMatch(/[a-f0-9]{16}/);
 expect(navigationSpan.trace_id).toMatch(/[a-f0-9]{32}/);

 expect(navigationSpan.attributes).toMatchObject({
 'sentry.idle_span_finish_reason': { value: 'idleTimeout', type: 'string' },
 'sentry.op': { value: 'navigation', type: 'string' },
 'sentry.origin': { value: 'auto.navigation.react.reactrouter_v6', type: 'string' },
 'sentry.sample_rate': { value: 1, type: 'integer' },
 'sentry.segment.name.source': { value: 'route', type: 'string' },
 'url.template': { value: '/user/:id', type: 'string' },
 'url.path': { value: '/user/5', type: 'string' },
 'url.full': { value: expect.stringMatching(/^https?:\/\/localhost:\d+\/user\/5$/), type: 'string' },
 });

 expect(navigationSpan.links).toEqual(PREVIOUS_TRACE_LINK);

 // Filter out favicon spans which may or may not be present depending on the browser version
 const childSpans = spans.filter(
 span => !span.is_segment && !(span.attributes['url.full']?.value as string | undefined)?.includes('favicon'),
 );
 expect(childSpans).toEqual([]);
@cursorcursorBotSep 1, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Child-span absence checked too narrowly
Medium Severity
These tests expect navigation to have no child spans, but they only inspect the single envelope that contains the navigation segment. Streamed children flush as they end, often in earlier envelopes, so unexpected children would not be seen and the empty-array assertion would still pass. Flagged because the review guidelines call out relaxed negative assertions that do not actually prove something is absent from the payload.
Additional Locations (2)
Fix in CursorFix in Web
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 3ea1d9b. Configure here.
});

test('Captures a lazy pageload span', async ({ page }) => {
 const spansPromise = collectStreamedSpans('react-create-browser-router', spans => {
 return spans.some(span => getSpanOp(span) === 'pageload' && span.is_segment);
 });

 await page.goto('/lazy-loaded-user/5/foo');

 const spans = await spansPromise;
 const pageloadSpan = spans.find(span => getSpanOp(span) === 'pageload' && span.is_segment)!;

 expect(pageloadSpan.name).toBe('/lazy-loaded-user/:id/:innerId');
 expect(pageloadSpan.status).toBe('ok');

 expect(pageloadSpan.attributes).toMatchObject({
 'sentry.idle_span_finish_reason': { value: 'idleTimeout', type: 'string' },
 'sentry.op': { value: 'pageload', type: 'string' },
 'sentry.origin': { value: 'auto.pageload.react.reactrouter_v6', type: 'string' },
 'sentry.sample_rate': { value: 1, type: 'integer' },
 'sentry.segment.name.source': { value: 'route', type: 'string' },
 'url.template': { value: '/lazy-loaded-user/:id/:innerId', type: 'string' },
 'url.path': { value: '/lazy-loaded-user/5/foo', type: 'string' },
 'url.full': {
 value: expect.stringMatching(/^https?:\/\/localhost:\d+\/lazy-loaded-user\/5\/foo$/),
 type: 'string',
 },
 });

 expect(await page.innerText('id=content')).toContain('I am a lazy loaded user');

 // One span for the outer lazy route, one for the inner one
 const resourceSpans = spans.filter(
 span =>
 getSpanOp(span) === 'resource.script' &&
 span.attributes['sentry.origin']?.value === 'auto.resource.browser.metrics',
 );
 expect(resourceSpans.length).toBeGreaterThanOrEqual(2);
});

test('Captures a lazy navigation span', async ({ page }) => {
 const spansPromise = collectStreamedSpans('react-create-browser-router', spans => {
 return spans.some(span => getSpanOp(span) === 'navigation' && span.is_segment);
 });

 await page.goto('/');
 const linkElement = page.locator('id=lazy-navigation');
 await linkElement.click();

 const spans = await spansPromise;
 const navigationSpan = spans.find(span => getSpanOp(span) === 'navigation' && span.is_segment)!;

 expect(navigationSpan.name).toBe('/lazy-loaded-user/:id/:innerId');
 expect(navigationSpan.status).toBe('ok');

 expect(navigationSpan.attributes).toMatchObject({
 'sentry.idle_span_finish_reason': { value: 'idleTimeout', type: 'string' },
 'sentry.op': { value: 'navigation', type: 'string' },
 'sentry.origin': { value: 'auto.navigation.react.reactrouter_v6', type: 'string' },
 'sentry.sample_rate': { value: 1, type: 'integer' },
 'sentry.segment.name.source': { value: 'route', type: 'string' },
 'url.template': { value: '/lazy-loaded-user/:id/:innerId', type: 'string' },
 'url.path': { value: '/lazy-loaded-user/5/foo', type: 'string' },
 'url.full': {
 value: expect.stringMatching(/^https?:\/\/localhost:\d+\/lazy-loaded-user\/5\/foo$/),
 type: 'string',
 },
 });

 expect(navigationSpan.links).toEqual(PREVIOUS_TRACE_LINK);

 expect(await page.innerText('id=content')).toContain('I am a lazy loaded user');

 // One span for the outer lazy route, one for the inner one
 const resourceSpans = spans.filter(
 span =>
 getSpanOp(span) === 'resource.script' &&
 span.attributes['sentry.origin']?.value === 'auto.resource.browser.metrics',
 );
 expect(resourceSpans.length).toBeGreaterThanOrEqual(2);
@cursorcursorBotSep 1, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lazy navigation counts pageload scripts
Medium Severity
collectStreamedSpans is started before page.goto('/'), so the later resource.script filter includes pageload bundle spans as well as lazy-navigation chunks. The toBeGreaterThanOrEqual(2) check can pass even when navigation never emits those lazy-route spans, so a regression in lazy navigation instrumentation would go unnoticed. Flagged because the review guidelines require tests to actually cover the behaviour they claim to check.
Fix in CursorFix in Web
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 3ea1d9b. Configure here.
});

218 changes: 0 additions & 218 deletions
...ckages/e2e-tests/test-applications/react-create-browser-router/tests/transactions.test.ts

View file


Open in desktop


This file was deleted.


1 change: 0 additions & 1 deletion
dev-packages/e2e-tests/test-applications/react-create-hash-router/src/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,6 @@ import Group from './pages/Group';
const replay = Sentry.replayIntegration();

Sentry.init({
 traceLifecycle: 'static',
 // environment: 'qa', // dynamic sampling bias to keep transactions
 dsn: process.env.REACT_APP_E2E_TEST_DSN,
 integrations: [
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
test(e2e): Port React Router E2E test apps to span streaming#23839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

andreiborza
wants to merge
1
commit into

from

 Closed


test(e2e): Port React Router E2E test apps to span streaming
#23839
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
dev-packages/e2e-tests/test-applications/react-create-browser-router/src/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,7 +15,6 @@ import User from './pages/User';
const replay = Sentry.replayIntegration();

Sentry.init({
 traceLifecycle: 'static',
 // environment: 'qa', // dynamic sampling bias to keep transactions
 dsn: process.env.REACT_APP_E2E_TEST_DSN,
 integrations: [
Expand Down

164 changes: 164 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-create-browser-router/tests/spans.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,164 @@
import { expect, test } from '@playwright/test';
import {
 collectStreamedSpans,
 getSpanOp,
 waitForStreamedSpan,
 waitForStreamedSpans,
} from '@sentry-internal/test-utils';

const PREVIOUS_TRACE_LINK = [
 {
 attributes: {
 'sentry.link.type': { value: 'previous_trace', type: 'string' },
 },
 sampled: true,
 span_id: expect.stringMatching(/[a-f0-9]{16}/),
 trace_id: expect.stringMatching(/[a-f0-9]{32}/),
 },
];

test('Captures a pageload span', async ({ page }) => {
 const spanPromise = waitForStreamedSpan('react-create-browser-router', span => {
 return getSpanOp(span) === 'pageload' && span.is_segment;
 });

 await page.goto('/');

 const span = await spanPromise;

 expect(span.name).toBe('/');
 expect(span.status).toBe('ok');
 expect(span.span_id).toMatch(/[a-f0-9]{16}/);
 expect(span.trace_id).toMatch(/[a-f0-9]{32}/);

 expect(span.attributes).toMatchObject({
 'device.memory.estimated_capacity': { value: expect.any(Number), type: expect.any(String) },
 'device.processor_count': { value: expect.any(Number), type: 'integer' },
 'network.connection.effective_type': { value: expect.any(String), type: 'string' },
 'sentry.idle_span_finish_reason': { value: 'idleTimeout', type: 'string' },
 'sentry.op': { value: 'pageload', type: 'string' },
 'sentry.origin': { value: 'auto.pageload.react.reactrouter_v6', type: 'string' },
 'sentry.sample_rate': { value: 1, type: 'integer' },
 'sentry.segment.name.source': { value: 'route', type: 'string' },
 'url.template': { value: '/', type: 'string' },
 'url.path': { value: '/', type: 'string' },
 'url.full': { value: expect.stringMatching(/^https?:\/\/localhost:\d+\/$/), type: 'string' },
 });
});

test('Captures a navigation span', async ({ page }) => {
 const spansPromise = waitForStreamedSpans('react-create-browser-router', spans => {
 return spans.some(span => getSpanOp(span) === 'navigation' && span.is_segment);
 });

 await page.goto('/');
 const linkElement = page.locator('id=navigation');
 await linkElement.click();

 const spans = await spansPromise;
 const navigationSpan = spans.find(span => span.is_segment)!;
@cursorcursorBotSep 1, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong segment picked for navigation
Medium Severity
The wait predicate requires a navigation segment, but the span under test is then selected with spans.find(span => span.is_segment). That envelope can also contain the still-finishing pageload segment, especially here because the click is not sequenced after pageload. Memory-router is most exposed because pageload and navigation share the name /user/:id. Flagged from the review guidelines on flaky waits that are not unique enough when telemetry can arrive in arbitrary order.
Additional Locations (2)
Fix in CursorFix in Web
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 3ea1d9b. Configure here.

 expect(navigationSpan.name).toBe('/user/:id');
 expect(navigationSpan.status).toBe('ok');
 expect(navigationSpan.span_id).toMatch(/[a-f0-9]{16}/);
 expect(navigationSpan.trace_id).toMatch(/[a-f0-9]{32}/);

 expect(navigationSpan.attributes).toMatchObject({
 'sentry.idle_span_finish_reason': { value: 'idleTimeout', type: 'string' },
 'sentry.op': { value: 'navigation', type: 'string' },
 'sentry.origin': { value: 'auto.navigation.react.reactrouter_v6', type: 'string' },
 'sentry.sample_rate': { value: 1, type: 'integer' },
 'sentry.segment.name.source': { value: 'route', type: 'string' },
 'url.template': { value: '/user/:id', type: 'string' },
 'url.path': { value: '/user/5', type: 'string' },
 'url.full': { value: expect.stringMatching(/^https?:\/\/localhost:\d+\/user\/5$/), type: 'string' },
 });

 expect(navigationSpan.links).toEqual(PREVIOUS_TRACE_LINK);

 // Filter out favicon spans which may or may not be present depending on the browser version
 const childSpans = spans.filter(
 span => !span.is_segment && !(span.attributes['url.full']?.value as string | undefined)?.includes('favicon'),
 );
 expect(childSpans).toEqual([]);
@cursorcursorBotSep 1, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Child-span absence checked too narrowly
Medium Severity
These tests expect navigation to have no child spans, but they only inspect the single envelope that contains the navigation segment. Streamed children flush as they end, often in earlier envelopes, so unexpected children would not be seen and the empty-array assertion would still pass. Flagged because the review guidelines call out relaxed negative assertions that do not actually prove something is absent from the payload.
Additional Locations (2)
Fix in CursorFix in Web
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 3ea1d9b. Configure here.
});

test('Captures a lazy pageload span', async ({ page }) => {
 const spansPromise = collectStreamedSpans('react-create-browser-router', spans => {
 return spans.some(span => getSpanOp(span) === 'pageload' && span.is_segment);
 });

 await page.goto('/lazy-loaded-user/5/foo');

 const spans = await spansPromise;
 const pageloadSpan = spans.find(span => getSpanOp(span) === 'pageload' && span.is_segment)!;

 expect(pageloadSpan.name).toBe('/lazy-loaded-user/:id/:innerId');
 expect(pageloadSpan.status).toBe('ok');

 expect(pageloadSpan.attributes).toMatchObject({
 'sentry.idle_span_finish_reason': { value: 'idleTimeout', type: 'string' },
 'sentry.op': { value: 'pageload', type: 'string' },
 'sentry.origin': { value: 'auto.pageload.react.reactrouter_v6', type: 'string' },
 'sentry.sample_rate': { value: 1, type: 'integer' },
 'sentry.segment.name.source': { value: 'route', type: 'string' },
 'url.template': { value: '/lazy-loaded-user/:id/:innerId', type: 'string' },
 'url.path': { value: '/lazy-loaded-user/5/foo', type: 'string' },
 'url.full': {
 value: expect.stringMatching(/^https?:\/\/localhost:\d+\/lazy-loaded-user\/5\/foo$/),
 type: 'string',
 },
 });

 expect(await page.innerText('id=content')).toContain('I am a lazy loaded user');

 // One span for the outer lazy route, one for the inner one
 const resourceSpans = spans.filter(
 span =>
 getSpanOp(span) === 'resource.script' &&
 span.attributes['sentry.origin']?.value === 'auto.resource.browser.metrics',
 );
 expect(resourceSpans.length).toBeGreaterThanOrEqual(2);
});

test('Captures a lazy navigation span', async ({ page }) => {
 const spansPromise = collectStreamedSpans('react-create-browser-router', spans => {
 return spans.some(span => getSpanOp(span) === 'navigation' && span.is_segment);
 });

 await page.goto('/');
 const linkElement = page.locator('id=lazy-navigation');
 await linkElement.click();

 const spans = await spansPromise;
 const navigationSpan = spans.find(span => getSpanOp(span) === 'navigation' && span.is_segment)!;

 expect(navigationSpan.name).toBe('/lazy-loaded-user/:id/:innerId');
 expect(navigationSpan.status).toBe('ok');

 expect(navigationSpan.attributes).toMatchObject({
 'sentry.idle_span_finish_reason': { value: 'idleTimeout', type: 'string' },
 'sentry.op': { value: 'navigation', type: 'string' },
 'sentry.origin': { value: 'auto.navigation.react.reactrouter_v6', type: 'string' },
 'sentry.sample_rate': { value: 1, type: 'integer' },
 'sentry.segment.name.source': { value: 'route', type: 'string' },
 'url.template': { value: '/lazy-loaded-user/:id/:innerId', type: 'string' },
 'url.path': { value: '/lazy-loaded-user/5/foo', type: 'string' },
 'url.full': {
 value: expect.stringMatching(/^https?:\/\/localhost:\d+\/lazy-loaded-user\/5\/foo$/),
 type: 'string',
 },
 });

 expect(navigationSpan.links).toEqual(PREVIOUS_TRACE_LINK);

 expect(await page.innerText('id=content')).toContain('I am a lazy loaded user');

 // One span for the outer lazy route, one for the inner one
 const resourceSpans = spans.filter(
 span =>
 getSpanOp(span) === 'resource.script' &&
 span.attributes['sentry.origin']?.value === 'auto.resource.browser.metrics',
 );
 expect(resourceSpans.length).toBeGreaterThanOrEqual(2);
@cursorcursorBotSep 1, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lazy navigation counts pageload scripts
Medium Severity
collectStreamedSpans is started before page.goto('/'), so the later resource.script filter includes pageload bundle spans as well as lazy-navigation chunks. The toBeGreaterThanOrEqual(2) check can pass even when navigation never emits those lazy-route spans, so a regression in lazy navigation instrumentation would go unnoticed. Flagged because the review guidelines require tests to actually cover the behaviour they claim to check.
Fix in CursorFix in Web
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 3ea1d9b. Configure here.
});

218 changes: 0 additions & 218 deletions
...ckages/e2e-tests/test-applications/react-create-browser-router/tests/transactions.test.ts

View file


Open in desktop


This file was deleted.


1 change: 0 additions & 1 deletion
dev-packages/e2e-tests/test-applications/react-create-hash-router/src/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,6 @@ import Group from './pages/Group';
const replay = Sentry.replayIntegration();

Sentry.init({
 traceLifecycle: 'static',
 // environment: 'qa', // dynamic sampling bias to keep transactions
 dsn: process.env.REACT_APP_E2E_TEST_DSN,
 integrations: [
Expand Down
Loading
Loading