Uh oh!
There was an error while loading. Please reload this page.
test(e2e): Port React Router v5 and v6 E2E apps to span streaming - #23841
Merged
Conversation
andreiborza
marked this pull request as ready for review
September 1, 2026 14:17
Contributor
size-limit report 📦
|
Lms24
approved these changes
Sep 1, 2026
| 'sentry.origin': { value: 'auto.navigation.react.reactrouter_v6', type: 'string' }, | ||
| 'sentry.segment.name.source': { value: 'route', type: 'string' }, | ||
| 'url.template': { value: '/bar/:barId', type: 'string' }, | ||
| 'url.path': { value: '/bar/456', type: 'string' }, |
Member
There was a problem hiding this comment.
super-l: should we also assert against url.full here? Just noticed we do so below but feel free to skip
MemberAuthor
There was a problem hiding this comment.
Added it, the original test omitted it there but there is no reason to.
chargome
approved these changes
Sep 1, 2026
andreiborzaforce-pushed
the
ab/js-3482/static-coverage
branch
from
September 1, 2026 16:51
9dd059d to
e4cc238Compareandreiborzaforce-pushed
the
ab/js-3482/react-router-v5-v6
branch
from
September 1, 2026 16:51
d87c67b to
b0f464fCompareUh oh!
There was an error while loading. Please reload this page.
andreiborzaforce-pushed
the
ab/js-3482/static-coverage
branch
from
September 2, 2026 08:23
e4cc238 to
ee4df2bCompareandreiborzaforce-pushed
the
ab/js-3482/react-router-v5-v6
branch
from
September 2, 2026 08:23
b0f464f to
37956c8Compareandreiborzaforce-pushed
the
ab/js-3482/static-coverage
branch
from
September 2, 2026 08:46
ee4df2b to
6817d85Compareandreiborzaforce-pushed
the
ab/js-3482/react-router-v5-v6
branch
from
September 2, 2026 08:46
37956c8 to
b24c46cCompareThere was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b24c46c. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
andreiborzaforce-pushed
the
ab/js-3482/react-router-v5-v6
branch
from
September 2, 2026 09:05
b24c46c to
e12d590Compareandreiborzaforce-pushed
the
ab/js-3482/static-coverage
branch
2 times, most recently
from
September 2, 2026 09:30
d41e1c4 to
e83f714Compareandreiborzaforce-pushed
the
ab/js-3482/react-router-v5-v6
branch
from
September 2, 2026 09:30
e12d590 to
13d5c58Compareandreiborzaforce-pushed
the
ab/js-3482/static-coverage
branch
from
September 2, 2026 10:01
e83f714 to
3f2afd6Compareandreiborzaforce-pushed
the
ab/js-3482/react-router-v5-v6
branch
from
September 2, 2026 10:01
13d5c58 to
1a0c76dCompareCopies `react-router-7-framework` into `react-router-7-framework-static`, which keeps `traceLifecycle: 'static'` and its transaction-based specs. The rest of the React Router group moves to span streaming in the PRs above, so this copy is what keeps the static lifecycle covered. The copy drops the `latest` build variant, so it costs one CI job rather than two.
Removes the `traceLifecycle: 'static'` pin from `react-router-5`, `react-router-6`, `react-router-6-use-routes` and `react-router-6-descendant-routes`, and rewrites their specs against streamed span v2. The `react-router-6` SSE spec needed more than a helper swap: streamed `http.client` names carry only the domain, so the request is matched on `url.full`, and the abort error is read off the console because spans carry no breadcrumbs. All three SSE tests load the same route, so each one also pins its lookup to a pageload span that started after it navigated.
andreiborzaforce-pushed
the
ab/js-3482/static-coverage
branch
from
September 2, 2026 10:07
3f2afd6 to
436f969Compareandreiborzaforce-pushed
the
ab/js-3482/react-router-v5-v6
branch
from
September 2, 2026 10:07
1a0c76d to
801356cCompareUh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Ports
react-router-5,react-router-6,react-router-6-use-routesandreact-router-6-descendant-routesto span streaming.Why
Span streaming is the default now, so the E2E suite has to exercise it. The SSE spec needed more than a helper swap: a streamed
http.clientspan carries only the domain in its name, so the request is matched onurl.full, and the abort error is read off the console because spans carry no breadcrumbs.Part of #23798