Uh oh!
There was an error while loading. Please reload this page.
test(e2e): Port React Router data router E2E apps to span streaming - #23842
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
size-limit report 📦
|
450d0d3 to
361c467CompareUh oh!
There was an error while loading. Please reload this page.
d87c67b to
b0f464fCompare361c467 to
a0463abCompareThere was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a0463ab. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
b0f464f to
37956c8Comparea0463ab to
035ea0cCompare37956c8 to
b24c46cCompare10e5c15 to
d2e75d6Comparee12d590 to
13d5c58Compared2e75d6 to
b6f6642CompareUh oh!
There was an error while loading. Please reload this page.
13d5c58 to
1a0c76dCompareb6f6642 to
4f8a0f4CompareUh oh!
There was an error while loading. Please reload this page.
Copies `react-router-7-framework` into `react-router-7-framework-static`, which keeps `traceLifecycle: 'static'` and its transaction-based specs. The rest of the React Router group moves to span streaming in the PRs above, so this copy is what keeps the static lifecycle covered. The copy drops the `latest` build variant, so it costs one CI job rather than two.
Removes the `traceLifecycle: 'static'` pin from `react-router-5`, `react-router-6`, `react-router-6-use-routes` and `react-router-6-descendant-routes`, and rewrites their specs against streamed span v2. The `react-router-6` SSE spec needed more than a helper swap: streamed `http.client` names carry only the domain, so the request is matched on `url.full`, and the abort error is read off the console because spans carry no breadcrumbs. All three SSE tests load the same route, so each one also pins its lookup to a pageload span that started after it navigated.
Removes the `traceLifecycle: 'static'` pin from `react-create-browser-router`, `react-create-hash-router` and `react-create-memory-router`, and rewrites their specs against streamed span v2. Two attribute groups moved under streaming and the assertions follow them: the navigator data is now `device.memory.estimated_capacity`, `device.processor_count` and `network.connection.effective_type`, and the pageload timings are `browser.performance.*`. LCP is streamed as its own `ui.webvital.lcp` span once the page hides, so it is no longer asserted on the pageload span.
1a0c76d to
801356cCompare4f8a0f4 to
a3cd640Compare## What Ports `react-router-7-spa`, `react-router-8-spa`, `react-router-7-cross-usage`, `react-router-8-cross-usage` and `react-router-8-cloudflare` to span streaming. ## Why Span streaming is the default now, so the E2E suite has to exercise it. The Cloudflare mysql spec matches on `db.query.text`, because a streamed mysql span is named after its query summary and both queries in that route come out as `SELECT`. Part of #23798
Uh oh!
There was an error while loading. Please reload this page.

What
Ports
react-create-browser-router,react-create-hash-routerandreact-create-memory-routerto span streaming.Why
Span streaming is the default now, so the E2E suite has to exercise it. Two attribute groups moved and the assertions follow them: the navigator data is now
device.memory.estimated_capacity,device.processor_countandnetwork.connection.effective_type, and the pageload timings arebrowser.performance.*. LCP is streamed as its ownui.webvital.lcpspan once the page hides, so it is no longer asserted on the pageload span.Part of #23798