Uh oh!
There was an error while loading. Please reload this page.
test(e2e): Port the React Router instrumentation API E2E app to span streaming - #23845
Merged
andreiborza merged 2 commits intoSep 2, 2026
Merged
Conversation
Contributor
size-limit report 📦
|
andreiborzaforce-pushed
the
ab/js-3482/framework-apps
branch
from
September 1, 2026 14:21
75dab6a to
ae51708Compareandreiborzaforce-pushed
the
ab/js-3482/instrumentation-api
branch
2 times, most recently
from
September 1, 2026 14:56
2f982ae to
a9e6808Compareandreiborzaforce-pushed
the
ab/js-3482/framework-apps
branch
from
September 1, 2026 14:56
ae51708 to
537187fCompareandreiborzaforce-pushed
the
ab/js-3482/instrumentation-api
branch
3 times, most recently
from
September 1, 2026 16:05
cf5c7f9 to
9e03698Compareandreiborzaforce-pushed
the
ab/js-3482/framework-apps
branch
from
September 1, 2026 16:05
47e95de to
5ecb95aCompareandreiborzaforce-pushed
the
ab/js-3482/instrumentation-api
branch
from
September 1, 2026 16:37
9e03698 to
edd1076CompareUh oh!
There was an error while loading. Please reload this page.
andreiborzaforce-pushed
the
ab/js-3482/instrumentation-api
branch
from
September 1, 2026 16:51
edd1076 to
7d44686Compareandreiborzaforce-pushed
the
ab/js-3482/framework-apps
branch
from
September 1, 2026 16:51
54e87cd to
adf8c96CompareThere was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7d44686. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
andreiborzaforce-pushed
the
ab/js-3482/framework-apps
branch
from
September 2, 2026 08:23
adf8c96 to
e2c7572Compareandreiborzaforce-pushed
the
ab/js-3482/instrumentation-api
branch
2 times, most recently
from
September 2, 2026 08:46
d638522 to
979eaa0Compareandreiborzaforce-pushed
the
ab/js-3482/framework-apps
branch
from
September 2, 2026 08:46
e2c7572 to
05a6dbdCompareandreiborzaforce-pushed
the
ab/js-3482/instrumentation-api
branch
from
September 2, 2026 09:05
979eaa0 to
01f6e5dCompareandreiborzaforce-pushed
the
ab/js-3482/framework-apps
branch
2 times, most recently
from
September 2, 2026 09:30
4736942 to
7700c10Compareandreiborzaforce-pushed
the
ab/js-3482/instrumentation-api
branch
from
September 2, 2026 09:30
01f6e5d to
9d1bbdaCompareandreiborzaforce-pushed
the
ab/js-3482/framework-apps
branch
from
September 2, 2026 10:01
7700c10 to
06f7731Compareandreiborzaforce-pushed
the
ab/js-3482/instrumentation-api
branch
from
September 2, 2026 10:01
9d1bbda to
1db63f1Compare…streaming Removes the `traceLifecycle: 'static'` pin from `react-router-7-framework-instrumentation` and rewrites its specs against streamed span v2. Loader, action, middleware and fetcher assertions now walk the streamed trace instead of a transaction's `spans` array. The orchestrion mysql spec matches on `db.query.text`, since a streamed mysql span is named after its query summary.
andreiborzaforce-pushed
the
ab/js-3482/framework-apps
branch
from
September 2, 2026 10:07
06f7731 to
bd73839Compareandreiborzaforce-pushed
the
ab/js-3482/instrumentation-api
branch
from
September 2, 2026 10:07
1db63f1 to
107a1e4Compareandreiborza
marked this pull request as ready for review
September 2, 2026 11:42
Lms24
approved these changes
Sep 2, 2026
| 'sentry.origin': { value: 'auto.db.redis', type: 'string' }, | ||
| 'db.system.name': { value: 'redis', type: 'string' }, | ||
| 'db.operation.name': { value: 'set', type: 'string' }, | ||
| 'db.query.text': { value: 'set test-key [1 other arguments]', type: 'string' }, |
Member
There was a problem hiding this comment.
note for myself: #23741 needs to update these tests for the new span name. Let's merge your PR first. I'd actually appreciate more tests on the redis db span rename PR anyway!
Comment on lines
+12
to
+13
| /** Every span below `rootSpan`, following `parent_span_id` down the tree. */ | ||
| function descendantsOf(spans: SerializedStreamedSpan[], rootSpan: SerializedStreamedSpan): SerializedStreamedSpan[] { |
Member
There was a problem hiding this comment.
l: It took me quite a bit to understand this function. two suggestions:
- can we call it
getChildSpansOf- which is what I think this function does - rename
rootSpantoparentSpan- because rootSpan is an overloaded term and I thought for a second this would be a segment span. but IIUC the fetcherSpan below is also just a child span and we want children of that span, correct?
MemberAuthor
There was a problem hiding this comment.
Renamed the parameter to parentSpan as suggested, and went with getDescendantSpansOf rather than getChildSpansOf because the walk is transitive: it collects spans nested several levels below, not just direct children. And yes, the fetcher span is itself a child span, not a segment.
| 'code.function.name': 'lazy', | ||
| }, | ||
| description: 'Lazy Route Load', | ||
| name: 'Lazy Route Load', |
Member
There was a problem hiding this comment.
side-comment: This is a bit of a weird span name and made me realize we don't yet have name/description rules for function spans 🙃 will add to #22350
`rootSpan` read as a segment span, which the fetcher span is not, and the name did not say the walk is transitive.
Uh oh!
There was an error while loading. Please reload this page.
andreiborza added a commit
that referenced
this pull request
Sep 2, 2026
…streaming (#23845) ## What Ports `react-router-7-framework-instrumentation` to span streaming. ## Why Span streaming is the default now, so the E2E suite has to exercise it. Loader, action, middleware and fetcher assertions walk the streamed trace instead of a transaction's `spans` array, and the orchestrion mysql spec matches on `db.query.text`, since a streamed mysql span is named after its query summary. Part of #23798
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Ports
react-router-7-framework-instrumentationto span streaming.Why
Span streaming is the default now, so the E2E suite has to exercise it. Loader, action, middleware and fetcher assertions walk the streamed trace instead of a transaction's
spansarray, and the orchestrion mysql spec matches ondb.query.text, since a streamed mysql span is named after its query summary.Part of #23798