Uh oh!
There was an error while loading. Please reload this page.
test(e2e): Port React E2E test apps to span streaming - #23849
Merged
andreiborza merged 2 commits intoSep 2, 2026
Conversation
Removes the `traceLifecycle: 'static'` pin from `create-react-app`, `lighthouse-react`, `react-17`, `react-19` and `react-send-to-sentry`, and rewrites the `react-17` specs against streamed span v2. `react-send-to-sentry` needed more than a helper swap. Pageload and navigation segments never become transaction events under streaming, so the app records them from `beforeSendSpan` instead of the event processor, and the trace lookup matches a span id rather than a transaction event id. `react-19` keeps its specs unchanged: they only cover error handling and the profiler, neither of which depends on the trace lifecycle.
Contributor
size-limit report 📦
|
Matching `event_id` against the recorded span id never resolved, so both span lookups polled for the full three minutes. The trace is already unique to the pageload or navigation under test, so the op identifies the segment within it without depending on which field carries the span id. Log the trace's item shapes once when the op is missing, so a repeat failure is diagnosable.
andreiborza
marked this pull request as ready for review
September 2, 2026 11:20
s1gr1d
approved these changes
Sep 2, 2026
Uh oh!
There was an error while loading. Please reload this page.
Lms24
reviewed
Sep 2, 2026
Member
There was a problem hiding this comment.
I'm curious if this will introduce new flakes, given that there's also no guarantee on the backend that all spans of a trace arrive at once. But probably fine to leave as-is for now and revisit when it comes to flakes.
If it flakes, we likely can't stop polling on the first success response from the API but rather again continue with the requests until a condition is met.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Ports
create-react-app,lighthouse-react,react-17,react-19andreact-send-to-sentryto span streaming.Why
Span streaming is the default now, so the E2E suite has to exercise it.
react-send-to-sentryneeded more than a helper swap: pageload and navigation segments never become transaction events under streaming, so the app records them frombeforeSendSpanand the trace lookup matches a span id rather than a transaction event id. That lookup runs against real Sentry, so CI is what confirms the shape.react-19keeps its specs unchanged, since they only cover error handling and the profiler.Closes: #23799