Uh oh!
There was an error while loading. Please reload this page.
test(tanstackstart): Fix matching for server-side error event - #23852
Merged
Conversation
…ent on Cloudflare The server-function error test flaked: it asserts the mechanism is `auto.middleware.tanstackstart.server_function` but occasionally received `auto.browser.global_handlers.onunhandledrejection`. The thrown error propagates back to the client over the server-function RPC and is captured a second time there with the same message. The `waitForError` predicate matched on message only, so it raced the two events and sometimes resolved with the client-side duplicate. Match the server mechanism as well so the correct event is always selected. The API-route test carries the identical latent race, so harden that predicate too. This mirrors the fix already applied to the tanstackstart-react app in #22137. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
chargome
marked this pull request as ready for review
September 1, 2026 14:40
Contributor
size-limit report 📦
|
andreiborza
approved these changes
Sep 1, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a test to assert for server only errors.