Uh oh!
There was an error while loading. Please reload this page.
test(e2e): Port cloudflare-mcp-agent to span streaming - #23859
Merged
JPeer264 merged 1 commit intoSep 2, 2026
Conversation
Contributor
size-limit report 📦
|
JPeer264force-pushed
the
jp/e2e-stream-cloudflare-mcp-agent
branch
from
September 1, 2026 15:21
d4bf4c5 to
d858741CompareJPeer264force-pushed
the
jp/e2e-stream-cloudflare-mcp-agent
branch
from
September 2, 2026 06:21
d858741 to
24630afCompareJPeer264force-pushed
the
jp/e2e-stream-cloudflare-mcp-agent
branch
from
September 2, 2026 07:10
24630af to
2ce7fabCompareJPeer264
marked this pull request as ready for review
September 2, 2026 07:11
chargome
approved these changes
Sep 2, 2026
JPeer264force-pushed
the
jp/e2e-stream-cloudflare-mcp-agent
branch
from
September 2, 2026 07:46
2ce7fab to
c2864f8Compareandreiborza
approved these changes
Sep 2, 2026
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
JPeer264force-pushed
the
jp/e2e-stream-cloudflare-mcp-agent
branch
from
September 2, 2026 11:30
c2864f8 to
2696fafCompare
Comment on lines
81
to
91
| status: 'ok', | ||
| data: expect.objectContaining({ | ||
| 'sentry.origin': 'auto.function.mcp_server', | ||
| 'sentry.op': 'mcp.server', | ||
| 'mcp.method.name': 'tools/call', | ||
| 'mcp.tool.name': 'my-tool', | ||
| 'mcp.tool.extra': 'from-mcpagent', | ||
| 'mcp.tool.result.content_count': 1, | ||
| 'mcp.tool.result.content_type': 'text', | ||
| is_segment: true, | ||
| attributes: expect.objectContaining({ | ||
| 'sentry.origin': { value: 'auto.function.mcp_server', type: 'string' }, | ||
| 'sentry.op': { value: 'mcp.server', type: 'string' }, | ||
| 'mcp.method.name': { value: 'tools/call', type: 'string' }, | ||
| 'mcp.tool.name': { value: 'my-tool', type: 'string' }, | ||
| 'mcp.tool.extra': { value: 'from-mcpagent', type: 'string' }, | ||
| 'mcp.tool.result.content_count': { value: 1, type: 'integer' }, | ||
| 'mcp.tool.result.content_type': { value: 'text', type: 'string' }, | ||
| }), |
Contributor
There was a problem hiding this comment.
Bug: The test's strict toEqual assertion is brittle as it doesn't account for the optional links field, causing it to fail if links are added to spans in the future.
Severity: LOW
Suggested Fix
To make the test more robust against future changes, use expect.objectContaining instead of toEqual. This will ensure the test only validates the presence and values of the specified fields, and will not fail if other optional fields like links are added to the span in the future.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location:
dev-packages/e2e-tests/test-applications/cloudflare-mcp-agent/tests/index.test.ts#L74-L91
Potential issue: The test uses a strict `toEqual` assertion that does not account for
the optional `links` field in the `SerializedStreamedSpan` type. While the test
currently passes because the MCP instrumentation does not add links to spans, it is
brittle. This test relies on the implicit assumption that `links` will never be
populated. If future changes to the MCP instrumentation add span links, which is a valid
use case, this test will unexpectedly fail, creating future maintenance overhead.
Did we get this right? 👍 / 👎 to inform future reviews.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports
cloudflare-mcp-agentto span streaming: pin removed from the worker and the Durable ObjectSentry.init, spec waits for the streamedtools/call my-toolspan and checks the same attribute set and the same PII exclusions onspan.attributes.