Uh oh!
There was an error while loading. Please reload this page.
test(e2e): Port nextjs-16-bun to span streaming - #23925
Merged
Merged
Conversation
Contributor
size-limit report 📦
|
chargomeforce-pushed
the
test/e2e-port-nextjs-16-bun
branch
from
September 2, 2026 11:18
cbc6209 to
6806fc0Comparechargome
marked this pull request as ready for review
September 2, 2026 13:21
andreiborza
approved these changes
Sep 2, 2026
Comment on lines
+18
to
+19
| // The isolation-scope assertions from the transaction-based spec are dropped: span v2 carries no | ||
| // scope tags, and there is no error event here to assert them on instead. |
Member
There was a problem hiding this comment.
Suggested change
| // The isolation-scope assertions from the transaction-based spec are dropped: span v2 carries no | |
| // scope tags, and there is no error event here to assert them on instead. |
l: Kinda odd having these comments when there's no code around for it anymore. I'd just nuke them.
Removes the `traceLifecycle: 'static'` pins and rewrites the specs onto streamed spans. Server-component and propagation specs use `collectStreamedSpans`; the propagation spec matches the inbound span, outbound span and the `http.client` span between them within one trace, since all three share it. The middleware isolation-scope assertions were dropped, having no span v2 equivalent and no error event to assert them on instead. The app's existing Bun-specific gaps are preserved: it asserts fewer `url.*` attributes than `nextjs-16`, and the note about Bun not populating HTTP request headers as span attributes still applies, so no header assertions were added here. Ref #23802 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
chargomeforce-pushed
the
test/e2e-port-nextjs-16-bun
branch
from
September 2, 2026 13:43
6806fc0 to
0ff21fbCompareUh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports
nextjs-16-bunto span streaming: removes thetraceLifecycle: 'static'pins and rewrites the specs onto streamed spans, usingcollectStreamedSpansfor the server-component and propagation specs.The middleware isolation-scope assertions were dropped, having no span v2 equivalent. The app's existing Bun-specific gaps are preserved - it asserts fewer
url.*attributes thannextjs-16, and Bun still does not populate request headers as span attributes.Ref #23802