Uh oh!
There was an error while loading. Please reload this page.
test(e2e): Port SvelteKit E2E test apps to span streaming - #23936
Open
msonnb wants to merge 4 commits into
Open
Conversation
msonnbforce-pushed
the
ms/js-3492-port-sveltekit-e2e-test-apps-to-span-streaming
branch
from
September 2, 2026 12:23
8c5d6d8 to
70d02efCompareContributor
size-limit report 📦
|
msonnb
marked this pull request as ready for review
September 2, 2026 12:42
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 70d02ef. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
Lms24
approved these changes
Sep 2, 2026
| 'http.method': { value: 'GET', type: 'string' }, | ||
| 'http.request.method': { value: 'GET', type: 'string' }, | ||
| 'http.route': { value: '/server-load-fetch', type: 'string' }, | ||
| 'sveltekit.tracing.original_name': { value: 'sveltekit.handle.root', type: 'string' }, |
Member
There was a problem hiding this comment.
this still needed a conventions entry. Added here: getsentry/sentry-conventions#611, along with a few other attributes also found in other tests
| op: 'function', | ||
| description: 'sveltekit.resolve', | ||
| origin: 'auto.http.sveltekit', | ||
| name: 'sveltekit.resolve', |
Member
There was a problem hiding this comment.
l: do we collect a code.function.name attribute for this as well? We still need to create function span name and description rules and I think we basically want to infer names based on the function name, so this needs to land in an attribute in addition to the span name.
If we don't, this is out of scope and should be tackled via #23954
MemberAuthor
There was a problem hiding this comment.
nope we just add op and origin for these
| * `sveltekit.resolve` span and therefore shares the trace with the server request. Stopping at | ||
| * segment boundaries keeps assertions on the server request's child spans free of browser spans. | ||
| */ | ||
| export function getSegmentChildSpans( |
Member
There was a problem hiding this comment.
this is a good observation. Maybe we need some kind of helper that waits for an entire segment (across envelopes) but drops spans not belonging to the segment 🤔 This would avoid having to add this kind of function to meta framework e2e tests.
| 'sentry.origin': { value: 'auto.db.redis', type: 'string' }, | ||
| 'db.system.name': { value: 'redis', type: 'string' }, | ||
| 'db.operation.name': { value: 'set', type: 'string' }, | ||
| 'db.query.text': { value: 'set test-key [1 other arguments]', type: 'string' }, |
Member
There was a problem hiding this comment.
heads-up: This PR needs a rebase and adjustments here because redis span names have changed via #23741
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xo7LcmA5Cte2uiSmp7hXSN
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xo7LcmA5Cte2uiSmp7hXSN
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Replaces the per-app getSegmentChildSpans tree walk in the SvelteKit specs with a shared collector that groups streamed spans by their segment id. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
msonnbforce-pushed
the
ms/js-3492-port-sveltekit-e2e-test-apps-to-span-streaming
branch
from
September 2, 2026 15:32
cf27128 to
3179d93Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports
sveltekit-2,sveltekit-2-kit-tracing,sveltekit-2-svelte-5,sveltekit-2.5.0-twp,sveltekit-3andsveltekit-cloudflare-pagesto span streaming, and addssveltekit-2-staticas a verbatim copy of the oldsveltekit-2(only the app name changed) to keep the static trace lifecycle covered.Decisions taken while porting:
sveltekit.resolvespan, so the whole request shares one trace. The kit-tracing and SvelteKit 3 specs use a smallgetSegmentChildSpanshelper that walks a segment's descendants without crossing into other segments, which keeps the exact child-span count assertions meaningful.routerspans are now namedRouter, browser fetch spansGET localhost, and mysql spans carry the query summary (SELECT) as name with the full text indb.query.text. Specs assert the new names and keep the old details as attributes.@sentry/cloudflarerequest span (GET, sourceurl); the SvelteKitGET /db-mysqlspan is its child. The db specs match on the trace instead of a transaction name.requestassertions on server transactions have no streamed equivalent and became assertions onhttp.request.methodandhttp.request.header.*attributes.closes#23808