Uh oh!
There was an error while loading. Please reload this page.
test(e2e): Migrate nuxt-4 to span streaming - #23949
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Contributor
size-limit report 📦
|
Storage span names are `cache.{operation}` under span streaming since #23830.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>s1gr1d
marked this pull request as ready for review
September 3, 2026 09:38
Uh oh!
There was an error while loading. Please reload this page.
chargome
self-requested a review
September 3, 2026 12:16
chargome
approved these changes
Sep 3, 2026
| const rootSpan = spans.find(span => span.is_segment && span.attributes['url.path']?.value === '/api/cache-test'); | ||
| return spans.filter( | ||
| span => span.trace_id === rootSpan?.trace_id && span.attributes['sentry.origin']?.value === 'auto.cache.nuxt', |
Member
There was a problem hiding this comment.
As in the other or, this should happen automatically in collectStreamedSpans
MemberAuthor
There was a problem hiding this comment.
will apply this in another PR to not re-run CI here
| expect(clientTxnEvent.contexts?.trace?.trace_id).toBe(ssrTxnEvent.contexts?.trace?.trace_id); | ||
| expect(clientTxnEvent.contexts?.trace?.trace_id).toBe(serverReqTxnEvent.contexts?.trace?.trace_id); | ||
| // All 3 root spans and the http.client span should share the same trace_id | ||
| expect(pageloadSpan?.trace_id).toBeDefined(); |
Member
There was a problem hiding this comment.
Same here, the helper should already handle this, but not blocking imo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference #23804
Two changes beyond the mechanical port. The SWR cached-html tests asserted that a second request sends no server root span — that only passed because the listener registered after
page.goto, so the (always sent) second transaction arrived unobserved. Streaming's buffered flush exposed it. The tests now check the actual SWR contract: no tracing meta tags, and each pageload starts its own trace. Also,db-test.tsruns a successful query before the failing one, so the error carries a query breadcrumb — there is no transaction event to read breadcrumbs off anymore (nuxt-3 has the same setup).