Uh oh!
There was an error while loading. Please reload this page.
test(e2e): Migrate nuxt-5 to span streaming - #23951
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
size-limit report 📦
|
Storage span names are `cache.{operation}` under span streaming since #23830.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>s1gr1d
marked this pull request as ready for review
September 2, 2026 14:54
chargome
approved these changes
Sep 3, 2026
chargome
left a comment
Member
There was a problem hiding this comment.
LGTM, just the note on trace id matching
| ); | ||
| const rootSpan = spans.find(span => span.is_segment && span.attributes['url.path']?.value === '/api/middleware-test'); | ||
| return spans.filter(span => span.trace_id === rootSpan?.trace_id); |
Member
There was a problem hiding this comment.
This is handled automatically in collectRequestSpans(#23912)
MemberAuthor
There was a problem hiding this comment.
Neat! I'm gonna add this in another PR - don't want to run CI again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference #23804
Two changes beyond the mechanical port. The shared cached-html helper (used by the pre-rendered test; the SWR tests were already skipped) asserted that a second request sends no server root span — that only passed because the listener registered after
page.goto. Streaming's buffered flush exposed the span, so the helper now checks the actual contract: no tracing meta tags, and each pageload starts its own trace. Also,db-test.tsruns a successful query before the failing one, so the error carries a query breadcrumb — there is no transaction event to read breadcrumbs off anymore.