Uh oh!
There was an error while loading. Please reload this page.
test(e2e): Add nuxt-4-static app to keep static trace lifecycle coverage - #23952
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
size-limit report 📦
|
s1gr1d
marked this pull request as ready for review
September 2, 2026 14:55
| db: | ||
| image: mysql:8.0 | ||
| restart: always | ||
| container_name: e2e-tests-nuxt-4-mysql |
Contributor
There was a problem hiding this comment.
Bug: The nuxt-4-static test application uses the same Docker container names as the nuxt-4 application, which will cause CI failures due to name conflicts.
Severity: HIGH
Suggested Fix
Update the container_name values in dev-packages/e2e-tests/test-applications/nuxt-4-static/docker-compose.yml to be unique. For instance, rename e2e-tests-nuxt-4-mysql to e2e-tests-nuxt-4-static-mysql and e2e-tests-nuxt-4-redis to e2e-tests-nuxt-4-static-redis to prevent conflicts in the CI environment.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: dev-packages/e2e-tests/test-applications/nuxt-4-static/docker-compose.yml#L5
Potential issue: The `nuxt-4-static` test application's `docker-compose.yml` file
defines container names, `e2e-tests-nuxt-4-mysql` and `e2e-tests-nuxt-4-redis`, that are
identical to those used by the existing `nuxt-4` test application. The CI workflow runs
E2E tests for all applications on the same runner without cleaning up Docker containers
between jobs. This will cause a name conflict when the CI attempts to run tests for both
applications. The second test suite to run will fail during its setup phase because
`docker compose up` will be unable to create containers with names that are already in
use, crashing the test run.
Also affects:
dev-packages/e2e-tests/test-applications/nuxt-4-static/docker-compose.yml:23~23
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference #23804
This is a verbatim copy of the nuxt-4 app that stays pinned to
traceLifecycle: 'static'and keeps the transaction-based specs. With the Nuxt/Nitro apps migrating to span streaming, this copy keeps the static trace lifecycle covered by one representative app. Only the app name changed:package.jsonname, the event proxy server name, thewaitFor*calls in the specs, and the CI variant labels. The e2e matrix discovers apps by directory, so no CI config change is needed.