Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions MIGRATION.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -1272,6 +1272,8 @@ Affected SDKs: `@sentry/remix`.
+ import { sentryRemixVitePlugin } from '@sentry/remix/vite';
```

The plugin now also applies the build-time instrumentation transform. If you added `sentryOrchestrionPlugin()` from `@sentry/server-utils/orchestrion/vite` to your Vite config manually, remove it. Opt out with `sentryRemixVitePlugin({ buildTimeInstrumentation: false })`.

## 3. Removed APIs

### `@sentry/core` / All SDKs
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,7 +13,6 @@
},
"dependencies": {
"@sentry/remix": "file:../../packed/sentry-remix-packed.tgz",
"@sentry/server-utils": "file:../../packed/sentry-server-utils-packed.tgz",
"@remix-run/css-bundle": "2.17.4",
"@remix-run/node": "2.17.4",
"@remix-run/react": "2.17.4",
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
import { vitePlugin as remix } from '@remix-run/dev';
import { sentryRemixVitePlugin } from '@sentry/remix/vite';
import { sentryOrchestrionPlugin } from '@sentry/server-utils/orchestrion/vite';
import { defineConfig } from 'vite';
import tsconfigPaths from 'vite-tsconfig-paths';

Expand All@@ -10,10 +9,6 @@ export default defineConfig({
ignoredRouteFiles: ['**/.*'],
}),
sentryRemixVitePlugin(),
// Run the orchestrion code transform over the SSR server bundle and force-bundle the
// instrumented deps (mysql, ioredis, @remix-run/server-runtime, …) so their
// diagnostics-channel calls are injected at build time.
sentryOrchestrionPlugin(),
tsconfigPaths(),
],
});
8 changes: 5 additions & 3 deletions packages/remix/src/vite/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import type { Plugin } from 'vite';
import { makeOrchestrionPlugin } from './orchestrionPlugin';
import { makeRouteManifestPlugin } from './routeManifestPlugin';
import type { SentryRemixVitePluginOptions } from './types';

Expand All@@ -7,8 +8,9 @@ export type { SentryRemixVitePluginOptions };
/**
* Sentry Vite plugins for Remix.
*
* Add these to your Vite configuration to inject the Remix route manifest, so client-side
* transactions are parameterized.
* Add these to your Vite configuration to
* - inject the Remix route manifest, so client-side transactions are parameterized, and
* - build-time instrument supported server-side dependencies (such as database clients).
*
* @example
* ```typescript
Expand All@@ -28,5 +30,5 @@ export type { SentryRemixVitePluginOptions };
* ```
*/
export function sentryRemixVitePlugin(options: SentryRemixVitePluginOptions = {}): Plugin[] {
return [makeRouteManifestPlugin(options)];
return [makeRouteManifestPlugin(options), makeOrchestrionPlugin(options)];
}
81 changes: 81 additions & 0 deletions packages/remix/src/vite/orchestrionPlugin.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,81 @@
import { sentryOrchestrionPlugin } from '@sentry/server-utils/orchestrion/vite';
import type { ConfigEnv, Plugin, ResolvedConfig, UserConfig } from 'vite';
import type { SentryRemixVitePluginOptions } from './types';

type AnyHook = (this: unknown, ...args: never[]) => unknown;
type ObjectHook<T> = T | { order?: 'pre' | 'post' | null; handler: T };
type ConfigHook = (this: unknown, config: UserConfig, env: ConfigEnv) => unknown;

const WORKER_RESOLVE_CONDITIONS = ['workerd', 'worker'];

/**
* Cloudflare Pages and Hydrogen/Oxygen builds instrument through `instrumentBuild()` from
* `@sentry/remix/cloudflare`, which wraps the build instead of subscribing to diagnostics
* channels. Transforming there would add a `node:diagnostics_channel` import and subscriber code
* that nothing reads.
*
* Oxygen sets `ssr.target`, but Remix's own Vite plugin never does — a Cloudflare app is marked by
* workerd resolve conditions instead (`cloudflareDevProxyVitePlugin` sets `externalConditions`,
* the Cloudflare template sets `conditions`), so all three signals have to be checked.
*/
function isWorkerTarget(config: UserConfig | ResolvedConfig | undefined): boolean {
const ssr = config?.ssr;
if (ssr?.target === 'webworker') {
return true;
}

return [ssr?.resolve?.conditions, ssr?.resolve?.externalConditions].some(conditions =>
conditions?.some(condition => WORKER_RESOLVE_CONDITIONS.includes(condition)),
);
}
Comment thread
cursor[bot] marked this conversation as resolved.

function hookHandler<T extends AnyHook>(hook: ObjectHook<T> | undefined): T | undefined {
return typeof hook === 'function' ? hook : hook?.handler;
}

/** No-ops a hook while `isDisabled()` holds, keeping its declared hook shape. */
function gateHook<T extends AnyHook>(
hook: ObjectHook<T> | undefined,
isDisabled: () => boolean,
): ObjectHook<T> | undefined {
if (!hook) {
return hook;
}

const handler = hookHandler(hook) as AnyHook;
const gated = function (this: unknown, ...args: never[]): unknown {
return isDisabled() ? null : handler.apply(this, args);
} as T;

return typeof hook === 'function' ? gated : { ...hook, handler: gated };
}

/** The orchestrion bundler plugin, wired to stay out of workerd builds. */
export function makeOrchestrionPlugin(options: Pick<SentryRemixVitePluginOptions, 'buildTimeInstrumentation'>): Plugin {
const orchestrion = sentryOrchestrionPlugin({ buildTimeInstrumentation: options.buildTimeInstrumentation });
const { renderChunk } = orchestrion as Plugin & { renderChunk?: ObjectHook<AnyHook> };
const config = hookHandler(orchestrion.config as ObjectHook<ConfigHook> | undefined);
const configResolved = hookHandler(orchestrion.configResolved);

let isWorkerBuild = false;

return {
...orchestrion,
// Upstream ships the plugin with `enforce: 'pre'`, which would run this hook before the
// framework plugins that set `ssr.target`. `order: 'post'` moves it after them.
config: {
order: 'post',
handler(userConfig: UserConfig, env: ConfigEnv) {
return isWorkerTarget(userConfig) ? null : (config?.(userConfig, env) ?? null);
},
},
// The authoritative check: the resolved config reflects every plugin regardless of ordering,
// and this always runs before the first `transform`.
configResolved(resolvedConfig: ResolvedConfig) {
isWorkerBuild = isWorkerTarget(resolvedConfig);
return isWorkerBuild ? undefined : configResolved?.(resolvedConfig);
},
transform: gateHook(orchestrion.transform as ObjectHook<AnyHook> | undefined, () => isWorkerBuild),
renderChunk: gateHook(renderChunk, () => isWorkerBuild),
} as Plugin;
}
11 changes: 11 additions & 0 deletions packages/remix/src/vite/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,4 +8,15 @@ export type SentryRemixVitePluginOptions = {
* @example '/absolute/path/to/app'
*/
appDirPath?: string;

/**
* Build-time instrumentation of server-side dependencies (e.g. `mysql`, `ioredis`,
* `@remix-run/server-runtime`): the plugin injects `diagnostics_channel` publishers into the
* bundled SSR output, so the SDK traces them without monkey-patching.
*
* Set to `false` to opt out.
*
* @default true
*/
buildTimeInstrumentation?: boolean;
};
121 changes: 121 additions & 0 deletions packages/remix/test/vite/index.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,121 @@
import type { ConfigEnv, UserConfig } from 'vite';
import { beforeEach, describe, expect, it, vi } from 'vitest';
import { sentryRemixVitePlugin } from '../../src/vite';

// Stub the orchestrion plugin so these stay pure wiring tests (no apm code transformer pulled in),
// mirroring the real plugin's two shapes.
const orchestrionConfig = vi.fn((_config: UserConfig, env: ConfigEnv) =>
env.command === 'serve' ? null : { ssr: { noExternal: ['mysql'] } },
);
const orchestrionConfigResolved = vi.fn();
const orchestrionTransform = vi.fn(() => ({ code: 'transformed' }));

const orchestrionVite = vi.fn((options?: { buildTimeInstrumentation?: boolean }) =>
options?.buildTimeInstrumentation === false
? { name: 'sentry-orchestrion-disabled' }
: {
name: 'code-transformer',
enforce: 'pre',
config: orchestrionConfig,
configResolved: orchestrionConfigResolved,
transform: orchestrionTransform,
},
);

vi.mock('@sentry/server-utils/orchestrion/vite', () => ({
sentryOrchestrionPlugin: (options?: { buildTimeInstrumentation?: boolean }) => orchestrionVite(options),
}));

const NODE_CONFIG = { ssr: { target: 'node' } } as UserConfig;
const WORKER_CONFIG = { ssr: { target: 'webworker' } } as UserConfig;
// Remix's own Vite plugin never sets `ssr.target`, so a Cloudflare app is only recognizable by its
// workerd resolve conditions: `cloudflareDevProxyVitePlugin` contributes `externalConditions`, the
// Cloudflare template sets `conditions` in the user's own config.
const WORKER_CONFIGS: Array<[string, UserConfig]> = [
['ssr.target', WORKER_CONFIG],
['ssr.resolve.conditions', { ssr: { resolve: { conditions: ['workerd', 'worker', 'browser'] } } } as UserConfig],
['ssr.resolve.externalConditions', { ssr: { resolve: { externalConditions: ['workerd', 'worker'] } } } as UserConfig],
];
const BUILD_ENV = { command: 'build', mode: 'production' } as ConfigEnv;
const SERVE_ENV = { command: 'serve', mode: 'development' } as ConfigEnv;

/** Calls a hook declared in either the bare-function or the `{ handler }` form. */
function callHook(hook: unknown, ...args: unknown[]): unknown {
const handler = typeof hook === 'function' ? hook : (hook as { handler: (...a: unknown[]) => unknown }).handler;
return (handler as (...a: unknown[]) => unknown)(...args);
}

describe('sentryRemixVitePlugin', () => {
beforeEach(() => {
vi.clearAllMocks();
});

it('returns the route manifest plugin and the orchestrion plugin', () => {
const plugins = sentryRemixVitePlugin();

expect(plugins.map(plugin => plugin.name)).toEqual(['sentry-remix-route-manifest', 'code-transformer']);
expect(orchestrionVite).toHaveBeenCalledWith({ buildTimeInstrumentation: undefined });
});

it('adds an inert orchestrion plugin when `buildTimeInstrumentation` is `false`', () => {
const plugins = sentryRemixVitePlugin({ buildTimeInstrumentation: false });

expect(orchestrionVite).toHaveBeenCalledWith({ buildTimeInstrumentation: false });
expect(plugins.map(plugin => plugin.name)).toContain('sentry-orchestrion-disabled');
});

it('keeps the upstream `enforce: "pre"` but defers its `config` hook to the end', () => {
const orchestrion = sentryRemixVitePlugin()[1] as { enforce?: string; config?: { order?: string } };

expect(orchestrion.enforce).toBe('pre');
expect(orchestrion.config?.order).toBe('post');
});

// The dev server keeps instrumented deps external and lets the runtime `--import` hook inject the
// channels, which the orchestrion plugin decides from `env.command` — so the wrapper has to pass
// it through untouched.
it('forwards the config env so the plugin can opt out in the dev server', () => {
const orchestrion = sentryRemixVitePlugin()[1]!;

expect(callHook(orchestrion.config, NODE_CONFIG, SERVE_ENV)).toBeNull();
expect(orchestrionConfig).toHaveBeenCalledWith(NODE_CONFIG, SERVE_ENV);
});

describe('worker targets', () => {
it('applies the orchestrion hooks for node builds', () => {
const orchestrion = sentryRemixVitePlugin()[1]!;

expect(callHook(orchestrion.config, NODE_CONFIG, BUILD_ENV)).toEqual({ ssr: { noExternal: ['mysql'] } });

callHook(orchestrion.configResolved, NODE_CONFIG);
expect(orchestrionConfigResolved).toHaveBeenCalledTimes(1);

expect(callHook(orchestrion.transform, 'code', 'mysql.js', { ssr: true })).toEqual({ code: 'transformed' });
});

it.each(WORKER_CONFIGS)('skips force-bundling and transforming when %s marks a worker', (_signal, config) => {
const orchestrion = sentryRemixVitePlugin()[1]!;

expect(callHook(orchestrion.config, config, BUILD_ENV)).toBeNull();
expect(orchestrionConfig).not.toHaveBeenCalled();

callHook(orchestrion.configResolved, config);
expect(orchestrionConfigResolved).not.toHaveBeenCalled();

expect(callHook(orchestrion.transform, 'code', 'mysql.js', { ssr: true })).toBeNull();
expect(orchestrionTransform).not.toHaveBeenCalled();
});

// Framework plugins can set `ssr.target` after our `config` hook ran, so `configResolved` is
// what actually has to keep the transform out of a worker bundle.
it('skips the transform when the worker target only shows up in the resolved config', () => {
const orchestrion = sentryRemixVitePlugin()[1]!;

callHook(orchestrion.config, {} as UserConfig, BUILD_ENV);
callHook(orchestrion.configResolved, WORKER_CONFIG);

expect(callHook(orchestrion.transform, 'code', 'mysql.js', { ssr: true })).toBeNull();
expect(orchestrionTransform).not.toHaveBeenCalled();
});
});
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions MIGRATION.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -1272,6 +1272,8 @@ Affected SDKs: `@sentry/remix`.
+ import { sentryRemixVitePlugin } from '@sentry/remix/vite';
```

The plugin now also applies the build-time instrumentation transform. If you added `sentryOrchestrionPlugin()` from `@sentry/server-utils/orchestrion/vite` to your Vite config manually, remove it. Opt out with `sentryRemixVitePlugin({ buildTimeInstrumentation: false })`.

## 3. Removed APIs

### `@sentry/core` / All SDKs
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,7 +13,6 @@
},
"dependencies": {
"@sentry/remix": "file:../../packed/sentry-remix-packed.tgz",
"@sentry/server-utils": "file:../../packed/sentry-server-utils-packed.tgz",
"@remix-run/css-bundle": "2.17.4",
"@remix-run/node": "2.17.4",
"@remix-run/react": "2.17.4",
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
import { vitePlugin as remix } from '@remix-run/dev';
import { sentryRemixVitePlugin } from '@sentry/remix/vite';
import { sentryOrchestrionPlugin } from '@sentry/server-utils/orchestrion/vite';
import { defineConfig } from 'vite';
import tsconfigPaths from 'vite-tsconfig-paths';

Expand All@@ -10,10 +9,6 @@ export default defineConfig({
ignoredRouteFiles: ['**/.*'],
}),
sentryRemixVitePlugin(),
// Run the orchestrion code transform over the SSR server bundle and force-bundle the
// instrumented deps (mysql, ioredis, @remix-run/server-runtime, …) so their
// diagnostics-channel calls are injected at build time.
sentryOrchestrionPlugin(),
tsconfigPaths(),
],
});
8 changes: 5 additions & 3 deletions packages/remix/src/vite/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import type { Plugin } from 'vite';
import { makeOrchestrionPlugin } from './orchestrionPlugin';
import { makeRouteManifestPlugin } from './routeManifestPlugin';
import type { SentryRemixVitePluginOptions } from './types';

Expand All@@ -7,8 +8,9 @@ export type { SentryRemixVitePluginOptions };
/**
* Sentry Vite plugins for Remix.
*
* Add these to your Vite configuration to inject the Remix route manifest, so client-side
* transactions are parameterized.
* Add these to your Vite configuration to
* - inject the Remix route manifest, so client-side transactions are parameterized, and
* - build-time instrument supported server-side dependencies (such as database clients).
*
* @example
* ```typescript
Expand All@@ -28,5 +30,5 @@ export type { SentryRemixVitePluginOptions };
* ```
*/
export function sentryRemixVitePlugin(options: SentryRemixVitePluginOptions = {}): Plugin[] {
return [makeRouteManifestPlugin(options)];
return [makeRouteManifestPlugin(options), makeOrchestrionPlugin(options)];
}
81 changes: 81 additions & 0 deletions packages/remix/src/vite/orchestrionPlugin.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,81 @@
import { sentryOrchestrionPlugin } from '@sentry/server-utils/orchestrion/vite';
import type { ConfigEnv, Plugin, ResolvedConfig, UserConfig } from 'vite';
import type { SentryRemixVitePluginOptions } from './types';

type AnyHook = (this: unknown, ...args: never[]) => unknown;
type ObjectHook<T> = T | { order?: 'pre' | 'post' | null; handler: T };
type ConfigHook = (this: unknown, config: UserConfig, env: ConfigEnv) => unknown;

const WORKER_RESOLVE_CONDITIONS = ['workerd', 'worker'];

/**
* Cloudflare Pages and Hydrogen/Oxygen builds instrument through `instrumentBuild()` from
* `@sentry/remix/cloudflare`, which wraps the build instead of subscribing to diagnostics
* channels. Transforming there would add a `node:diagnostics_channel` import and subscriber code
* that nothing reads.
*
* Oxygen sets `ssr.target`, but Remix's own Vite plugin never does — a Cloudflare app is marked by
* workerd resolve conditions instead (`cloudflareDevProxyVitePlugin` sets `externalConditions`,
* the Cloudflare template sets `conditions`), so all three signals have to be checked.
*/
function isWorkerTarget(config: UserConfig | ResolvedConfig | undefined): boolean {
const ssr = config?.ssr;
if (ssr?.target === 'webworker') {
return true;
}

return [ssr?.resolve?.conditions, ssr?.resolve?.externalConditions].some(conditions =>
conditions?.some(condition => WORKER_RESOLVE_CONDITIONS.includes(condition)),
);
}
Comment thread
cursor[bot] marked this conversation as resolved.

function hookHandler<T extends AnyHook>(hook: ObjectHook<T> | undefined): T | undefined {
return typeof hook === 'function' ? hook : hook?.handler;
}

/** No-ops a hook while `isDisabled()` holds, keeping its declared hook shape. */
function gateHook<T extends AnyHook>(
hook: ObjectHook<T> | undefined,
isDisabled: () => boolean,
): ObjectHook<T> | undefined {
if (!hook) {
return hook;
}

const handler = hookHandler(hook) as AnyHook;
const gated = function (this: unknown, ...args: never[]): unknown {
return isDisabled() ? null : handler.apply(this, args);
} as T;

return typeof hook === 'function' ? gated : { ...hook, handler: gated };
}

/** The orchestrion bundler plugin, wired to stay out of workerd builds. */
export function makeOrchestrionPlugin(options: Pick<SentryRemixVitePluginOptions, 'buildTimeInstrumentation'>): Plugin {
const orchestrion = sentryOrchestrionPlugin({ buildTimeInstrumentation: options.buildTimeInstrumentation });
const { renderChunk } = orchestrion as Plugin & { renderChunk?: ObjectHook<AnyHook> };
const config = hookHandler(orchestrion.config as ObjectHook<ConfigHook> | undefined);
const configResolved = hookHandler(orchestrion.configResolved);

let isWorkerBuild = false;

return {
...orchestrion,
// Upstream ships the plugin with `enforce: 'pre'`, which would run this hook before the
// framework plugins that set `ssr.target`. `order: 'post'` moves it after them.
config: {
order: 'post',
handler(userConfig: UserConfig, env: ConfigEnv) {
return isWorkerTarget(userConfig) ? null : (config?.(userConfig, env) ?? null);
},
},
// The authoritative check: the resolved config reflects every plugin regardless of ordering,
// and this always runs before the first `transform`.
configResolved(resolvedConfig: ResolvedConfig) {
isWorkerBuild = isWorkerTarget(resolvedConfig);
return isWorkerBuild ? undefined : configResolved?.(resolvedConfig);
},
transform: gateHook(orchestrion.transform as ObjectHook<AnyHook> | undefined, () => isWorkerBuild),
renderChunk: gateHook(renderChunk, () => isWorkerBuild),
} as Plugin;
}
11 changes: 11 additions & 0 deletions packages/remix/src/vite/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,4 +8,15 @@ export type SentryRemixVitePluginOptions = {
* @example '/absolute/path/to/app'
*/
appDirPath?: string;

/**
* Build-time instrumentation of server-side dependencies (e.g. `mysql`, `ioredis`,
* `@remix-run/server-runtime`): the plugin injects `diagnostics_channel` publishers into the
* bundled SSR output, so the SDK traces them without monkey-patching.
*
* Set to `false` to opt out.
*
* @default true
*/
buildTimeInstrumentation?: boolean;
};
121 changes: 121 additions & 0 deletions packages/remix/test/vite/index.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,121 @@
import type { ConfigEnv, UserConfig } from 'vite';
import { beforeEach, describe, expect, it, vi } from 'vitest';
import { sentryRemixVitePlugin } from '../../src/vite';

// Stub the orchestrion plugin so these stay pure wiring tests (no apm code transformer pulled in),
// mirroring the real plugin's two shapes.
const orchestrionConfig = vi.fn((_config: UserConfig, env: ConfigEnv) =>
env.command === 'serve' ? null : { ssr: { noExternal: ['mysql'] } },
);
const orchestrionConfigResolved = vi.fn();
const orchestrionTransform = vi.fn(() => ({ code: 'transformed' }));

const orchestrionVite = vi.fn((options?: { buildTimeInstrumentation?: boolean }) =>
options?.buildTimeInstrumentation === false
? { name: 'sentry-orchestrion-disabled' }
: {
name: 'code-transformer',
enforce: 'pre',
config: orchestrionConfig,
configResolved: orchestrionConfigResolved,
transform: orchestrionTransform,
},
);

vi.mock('@sentry/server-utils/orchestrion/vite', () => ({
sentryOrchestrionPlugin: (options?: { buildTimeInstrumentation?: boolean }) => orchestrionVite(options),
}));

const NODE_CONFIG = { ssr: { target: 'node' } } as UserConfig;
const WORKER_CONFIG = { ssr: { target: 'webworker' } } as UserConfig;
// Remix's own Vite plugin never sets `ssr.target`, so a Cloudflare app is only recognizable by its
// workerd resolve conditions: `cloudflareDevProxyVitePlugin` contributes `externalConditions`, the
// Cloudflare template sets `conditions` in the user's own config.
const WORKER_CONFIGS: Array<[string, UserConfig]> = [
['ssr.target', WORKER_CONFIG],
['ssr.resolve.conditions', { ssr: { resolve: { conditions: ['workerd', 'worker', 'browser'] } } } as UserConfig],
['ssr.resolve.externalConditions', { ssr: { resolve: { externalConditions: ['workerd', 'worker'] } } } as UserConfig],
];
const BUILD_ENV = { command: 'build', mode: 'production' } as ConfigEnv;
const SERVE_ENV = { command: 'serve', mode: 'development' } as ConfigEnv;

/** Calls a hook declared in either the bare-function or the `{ handler }` form. */
function callHook(hook: unknown, ...args: unknown[]): unknown {
const handler = typeof hook === 'function' ? hook : (hook as { handler: (...a: unknown[]) => unknown }).handler;
return (handler as (...a: unknown[]) => unknown)(...args);
}

describe('sentryRemixVitePlugin', () => {
beforeEach(() => {
vi.clearAllMocks();
});

it('returns the route manifest plugin and the orchestrion plugin', () => {
const plugins = sentryRemixVitePlugin();

expect(plugins.map(plugin => plugin.name)).toEqual(['sentry-remix-route-manifest', 'code-transformer']);
expect(orchestrionVite).toHaveBeenCalledWith({ buildTimeInstrumentation: undefined });
});

it('adds an inert orchestrion plugin when `buildTimeInstrumentation` is `false`', () => {
const plugins = sentryRemixVitePlugin({ buildTimeInstrumentation: false });

expect(orchestrionVite).toHaveBeenCalledWith({ buildTimeInstrumentation: false });
expect(plugins.map(plugin => plugin.name)).toContain('sentry-orchestrion-disabled');
});

it('keeps the upstream `enforce: "pre"` but defers its `config` hook to the end', () => {
const orchestrion = sentryRemixVitePlugin()[1] as { enforce?: string; config?: { order?: string } };

expect(orchestrion.enforce).toBe('pre');
expect(orchestrion.config?.order).toBe('post');
});

// The dev server keeps instrumented deps external and lets the runtime `--import` hook inject the
// channels, which the orchestrion plugin decides from `env.command` — so the wrapper has to pass
// it through untouched.
it('forwards the config env so the plugin can opt out in the dev server', () => {
const orchestrion = sentryRemixVitePlugin()[1]!;

expect(callHook(orchestrion.config, NODE_CONFIG, SERVE_ENV)).toBeNull();
expect(orchestrionConfig).toHaveBeenCalledWith(NODE_CONFIG, SERVE_ENV);
});

describe('worker targets', () => {
it('applies the orchestrion hooks for node builds', () => {
const orchestrion = sentryRemixVitePlugin()[1]!;

expect(callHook(orchestrion.config, NODE_CONFIG, BUILD_ENV)).toEqual({ ssr: { noExternal: ['mysql'] } });

callHook(orchestrion.configResolved, NODE_CONFIG);
expect(orchestrionConfigResolved).toHaveBeenCalledTimes(1);

expect(callHook(orchestrion.transform, 'code', 'mysql.js', { ssr: true })).toEqual({ code: 'transformed' });
});

it.each(WORKER_CONFIGS)('skips force-bundling and transforming when %s marks a worker', (_signal, config) => {
const orchestrion = sentryRemixVitePlugin()[1]!;

expect(callHook(orchestrion.config, config, BUILD_ENV)).toBeNull();
expect(orchestrionConfig).not.toHaveBeenCalled();

callHook(orchestrion.configResolved, config);
expect(orchestrionConfigResolved).not.toHaveBeenCalled();

expect(callHook(orchestrion.transform, 'code', 'mysql.js', { ssr: true })).toBeNull();
expect(orchestrionTransform).not.toHaveBeenCalled();
});

// Framework plugins can set `ssr.target` after our `config` hook ran, so `configResolved` is
// what actually has to keep the transform out of a worker bundle.
it('skips the transform when the worker target only shows up in the resolved config', () => {
const orchestrion = sentryRemixVitePlugin()[1]!;

callHook(orchestrion.config, {} as UserConfig, BUILD_ENV);
callHook(orchestrion.configResolved, WORKER_CONFIG);

expect(callHook(orchestrion.transform, 'code', 'mysql.js', { ssr: true })).toBeNull();
expect(orchestrionTransform).not.toHaveBeenCalled();
});
});
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions MIGRATION.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -1272,6 +1272,8 @@ Affected SDKs: `@sentry/remix`.
+ import { sentryRemixVitePlugin } from '@sentry/remix/vite';
```

The plugin now also applies the build-time instrumentation transform. If you added `sentryOrchestrionPlugin()` from `@sentry/server-utils/orchestrion/vite` to your Vite config manually, remove it. Opt out with `sentryRemixVitePlugin({ buildTimeInstrumentation: false })`.

## 3. Removed APIs

### `@sentry/core` / All SDKs
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,7 +13,6 @@
},
"dependencies": {
"@sentry/remix": "file:../../packed/sentry-remix-packed.tgz",
"@sentry/server-utils": "file:../../packed/sentry-server-utils-packed.tgz",
"@remix-run/css-bundle": "2.17.4",
"@remix-run/node": "2.17.4",
"@remix-run/react": "2.17.4",
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
import { vitePlugin as remix } from '@remix-run/dev';
import { sentryRemixVitePlugin } from '@sentry/remix/vite';
import { sentryOrchestrionPlugin } from '@sentry/server-utils/orchestrion/vite';
import { defineConfig } from 'vite';
import tsconfigPaths from 'vite-tsconfig-paths';

Expand All@@ -10,10 +9,6 @@ export default defineConfig({
ignoredRouteFiles: ['**/.*'],
}),
sentryRemixVitePlugin(),
// Run the orchestrion code transform over the SSR server bundle and force-bundle the
// instrumented deps (mysql, ioredis, @remix-run/server-runtime, …) so their
// diagnostics-channel calls are injected at build time.
sentryOrchestrionPlugin(),
tsconfigPaths(),
],
});
8 changes: 5 additions & 3 deletions packages/remix/src/vite/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import type { Plugin } from 'vite';
import { makeOrchestrionPlugin } from './orchestrionPlugin';
import { makeRouteManifestPlugin } from './routeManifestPlugin';
import type { SentryRemixVitePluginOptions } from './types';

Expand All@@ -7,8 +8,9 @@ export type { SentryRemixVitePluginOptions };
/**
* Sentry Vite plugins for Remix.
*
* Add these to your Vite configuration to inject the Remix route manifest, so client-side
* transactions are parameterized.
* Add these to your Vite configuration to
* - inject the Remix route manifest, so client-side transactions are parameterized, and
* - build-time instrument supported server-side dependencies (such as database clients).
*
* @example
* ```typescript
Expand All@@ -28,5 +30,5 @@ export type { SentryRemixVitePluginOptions };
* ```
*/
export function sentryRemixVitePlugin(options: SentryRemixVitePluginOptions = {}): Plugin[] {
return [makeRouteManifestPlugin(options)];
return [makeRouteManifestPlugin(options), makeOrchestrionPlugin(options)];
}
81 changes: 81 additions & 0 deletions packages/remix/src/vite/orchestrionPlugin.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,81 @@
import { sentryOrchestrionPlugin } from '@sentry/server-utils/orchestrion/vite';
import type { ConfigEnv, Plugin, ResolvedConfig, UserConfig } from 'vite';
import type { SentryRemixVitePluginOptions } from './types';

type AnyHook = (this: unknown, ...args: never[]) => unknown;
type ObjectHook<T> = T | { order?: 'pre' | 'post' | null; handler: T };
type ConfigHook = (this: unknown, config: UserConfig, env: ConfigEnv) => unknown;

const WORKER_RESOLVE_CONDITIONS = ['workerd', 'worker'];

/**
* Cloudflare Pages and Hydrogen/Oxygen builds instrument through `instrumentBuild()` from
* `@sentry/remix/cloudflare`, which wraps the build instead of subscribing to diagnostics
* channels. Transforming there would add a `node:diagnostics_channel` import and subscriber code
* that nothing reads.
*
* Oxygen sets `ssr.target`, but Remix's own Vite plugin never does — a Cloudflare app is marked by
* workerd resolve conditions instead (`cloudflareDevProxyVitePlugin` sets `externalConditions`,
* the Cloudflare template sets `conditions`), so all three signals have to be checked.
*/
function isWorkerTarget(config: UserConfig | ResolvedConfig | undefined): boolean {
const ssr = config?.ssr;
if (ssr?.target === 'webworker') {
return true;
}

return [ssr?.resolve?.conditions, ssr?.resolve?.externalConditions].some(conditions =>
conditions?.some(condition => WORKER_RESOLVE_CONDITIONS.includes(condition)),
);
}
Comment thread
cursor[bot] marked this conversation as resolved.

function hookHandler<T extends AnyHook>(hook: ObjectHook<T> | undefined): T | undefined {
return typeof hook === 'function' ? hook : hook?.handler;
}

/** No-ops a hook while `isDisabled()` holds, keeping its declared hook shape. */
function gateHook<T extends AnyHook>(
hook: ObjectHook<T> | undefined,
isDisabled: () => boolean,
): ObjectHook<T> | undefined {
if (!hook) {
return hook;
}

const handler = hookHandler(hook) as AnyHook;
const gated = function (this: unknown, ...args: never[]): unknown {
return isDisabled() ? null : handler.apply(this, args);
} as T;

return typeof hook === 'function' ? gated : { ...hook, handler: gated };
}

/** The orchestrion bundler plugin, wired to stay out of workerd builds. */
export function makeOrchestrionPlugin(options: Pick<SentryRemixVitePluginOptions, 'buildTimeInstrumentation'>): Plugin {
const orchestrion = sentryOrchestrionPlugin({ buildTimeInstrumentation: options.buildTimeInstrumentation });
const { renderChunk } = orchestrion as Plugin & { renderChunk?: ObjectHook<AnyHook> };
const config = hookHandler(orchestrion.config as ObjectHook<ConfigHook> | undefined);
const configResolved = hookHandler(orchestrion.configResolved);

let isWorkerBuild = false;

return {
...orchestrion,
// Upstream ships the plugin with `enforce: 'pre'`, which would run this hook before the
// framework plugins that set `ssr.target`. `order: 'post'` moves it after them.
config: {
order: 'post',
handler(userConfig: UserConfig, env: ConfigEnv) {
return isWorkerTarget(userConfig) ? null : (config?.(userConfig, env) ?? null);
},
},
// The authoritative check: the resolved config reflects every plugin regardless of ordering,
// and this always runs before the first `transform`.
configResolved(resolvedConfig: ResolvedConfig) {
isWorkerBuild = isWorkerTarget(resolvedConfig);
return isWorkerBuild ? undefined : configResolved?.(resolvedConfig);
},
transform: gateHook(orchestrion.transform as ObjectHook<AnyHook> | undefined, () => isWorkerBuild),
renderChunk: gateHook(renderChunk, () => isWorkerBuild),
} as Plugin;
}
11 changes: 11 additions & 0 deletions packages/remix/src/vite/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,4 +8,15 @@ export type SentryRemixVitePluginOptions = {
* @example '/absolute/path/to/app'
*/
appDirPath?: string;

/**
* Build-time instrumentation of server-side dependencies (e.g. `mysql`, `ioredis`,
* `@remix-run/server-runtime`): the plugin injects `diagnostics_channel` publishers into the
* bundled SSR output, so the SDK traces them without monkey-patching.
*
* Set to `false` to opt out.
*
* @default true
*/
buildTimeInstrumentation?: boolean;
};
121 changes: 121 additions & 0 deletions packages/remix/test/vite/index.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,121 @@
import type { ConfigEnv, UserConfig } from 'vite';
import { beforeEach, describe, expect, it, vi } from 'vitest';
import { sentryRemixVitePlugin } from '../../src/vite';

// Stub the orchestrion plugin so these stay pure wiring tests (no apm code transformer pulled in),
// mirroring the real plugin's two shapes.
const orchestrionConfig = vi.fn((_config: UserConfig, env: ConfigEnv) =>
env.command === 'serve' ? null : { ssr: { noExternal: ['mysql'] } },
);
const orchestrionConfigResolved = vi.fn();
const orchestrionTransform = vi.fn(() => ({ code: 'transformed' }));

const orchestrionVite = vi.fn((options?: { buildTimeInstrumentation?: boolean }) =>
options?.buildTimeInstrumentation === false
? { name: 'sentry-orchestrion-disabled' }
: {
name: 'code-transformer',
enforce: 'pre',
config: orchestrionConfig,
configResolved: orchestrionConfigResolved,
transform: orchestrionTransform,
},
);

vi.mock('@sentry/server-utils/orchestrion/vite', () => ({
sentryOrchestrionPlugin: (options?: { buildTimeInstrumentation?: boolean }) => orchestrionVite(options),
}));

const NODE_CONFIG = { ssr: { target: 'node' } } as UserConfig;
const WORKER_CONFIG = { ssr: { target: 'webworker' } } as UserConfig;
// Remix's own Vite plugin never sets `ssr.target`, so a Cloudflare app is only recognizable by its
// workerd resolve conditions: `cloudflareDevProxyVitePlugin` contributes `externalConditions`, the
// Cloudflare template sets `conditions` in the user's own config.
const WORKER_CONFIGS: Array<[string, UserConfig]> = [
['ssr.target', WORKER_CONFIG],
['ssr.resolve.conditions', { ssr: { resolve: { conditions: ['workerd', 'worker', 'browser'] } } } as UserConfig],
['ssr.resolve.externalConditions', { ssr: { resolve: { externalConditions: ['workerd', 'worker'] } } } as UserConfig],
];
const BUILD_ENV = { command: 'build', mode: 'production' } as ConfigEnv;
const SERVE_ENV = { command: 'serve', mode: 'development' } as ConfigEnv;

/** Calls a hook declared in either the bare-function or the `{ handler }` form. */
function callHook(hook: unknown, ...args: unknown[]): unknown {
const handler = typeof hook === 'function' ? hook : (hook as { handler: (...a: unknown[]) => unknown }).handler;
return (handler as (...a: unknown[]) => unknown)(...args);
}

describe('sentryRemixVitePlugin', () => {
beforeEach(() => {
vi.clearAllMocks();
});

it('returns the route manifest plugin and the orchestrion plugin', () => {
const plugins = sentryRemixVitePlugin();

expect(plugins.map(plugin => plugin.name)).toEqual(['sentry-remix-route-manifest', 'code-transformer']);
expect(orchestrionVite).toHaveBeenCalledWith({ buildTimeInstrumentation: undefined });
});

it('adds an inert orchestrion plugin when `buildTimeInstrumentation` is `false`', () => {
const plugins = sentryRemixVitePlugin({ buildTimeInstrumentation: false });

expect(orchestrionVite).toHaveBeenCalledWith({ buildTimeInstrumentation: false });
expect(plugins.map(plugin => plugin.name)).toContain('sentry-orchestrion-disabled');
});

it('keeps the upstream `enforce: "pre"` but defers its `config` hook to the end', () => {
const orchestrion = sentryRemixVitePlugin()[1] as { enforce?: string; config?: { order?: string } };

expect(orchestrion.enforce).toBe('pre');
expect(orchestrion.config?.order).toBe('post');
});

// The dev server keeps instrumented deps external and lets the runtime `--import` hook inject the
// channels, which the orchestrion plugin decides from `env.command` — so the wrapper has to pass
// it through untouched.
it('forwards the config env so the plugin can opt out in the dev server', () => {
const orchestrion = sentryRemixVitePlugin()[1]!;

expect(callHook(orchestrion.config, NODE_CONFIG, SERVE_ENV)).toBeNull();
expect(orchestrionConfig).toHaveBeenCalledWith(NODE_CONFIG, SERVE_ENV);
});

describe('worker targets', () => {
it('applies the orchestrion hooks for node builds', () => {
const orchestrion = sentryRemixVitePlugin()[1]!;

expect(callHook(orchestrion.config, NODE_CONFIG, BUILD_ENV)).toEqual({ ssr: { noExternal: ['mysql'] } });

callHook(orchestrion.configResolved, NODE_CONFIG);
expect(orchestrionConfigResolved).toHaveBeenCalledTimes(1);

expect(callHook(orchestrion.transform, 'code', 'mysql.js', { ssr: true })).toEqual({ code: 'transformed' });
});

it.each(WORKER_CONFIGS)('skips force-bundling and transforming when %s marks a worker', (_signal, config) => {
const orchestrion = sentryRemixVitePlugin()[1]!;

expect(callHook(orchestrion.config, config, BUILD_ENV)).toBeNull();
expect(orchestrionConfig).not.toHaveBeenCalled();

callHook(orchestrion.configResolved, config);
expect(orchestrionConfigResolved).not.toHaveBeenCalled();

expect(callHook(orchestrion.transform, 'code', 'mysql.js', { ssr: true })).toBeNull();
expect(orchestrionTransform).not.toHaveBeenCalled();
});

// Framework plugins can set `ssr.target` after our `config` hook ran, so `configResolved` is
// what actually has to keep the transform out of a worker bundle.
it('skips the transform when the worker target only shows up in the resolved config', () => {
const orchestrion = sentryRemixVitePlugin()[1]!;

callHook(orchestrion.config, {} as UserConfig, BUILD_ENV);
callHook(orchestrion.configResolved, WORKER_CONFIG);

expect(callHook(orchestrion.transform, 'code', 'mysql.js', { ssr: true })).toBeNull();
expect(orchestrionTransform).not.toHaveBeenCalled();
});
});
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions MIGRATION.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -1272,6 +1272,8 @@ Affected SDKs: `@sentry/remix`.
+ import { sentryRemixVitePlugin } from '@sentry/remix/vite';
```

The plugin now also applies the build-time instrumentation transform. If you added `sentryOrchestrionPlugin()` from `@sentry/server-utils/orchestrion/vite` to your Vite config manually, remove it. Opt out with `sentryRemixVitePlugin({ buildTimeInstrumentation: false })`.

## 3. Removed APIs

### `@sentry/core` / All SDKs
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,7 +13,6 @@
},
"dependencies": {
"@sentry/remix": "file:../../packed/sentry-remix-packed.tgz",
"@sentry/server-utils": "file:../../packed/sentry-server-utils-packed.tgz",
"@remix-run/css-bundle": "2.17.4",
"@remix-run/node": "2.17.4",
"@remix-run/react": "2.17.4",
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
import { vitePlugin as remix } from '@remix-run/dev';
import { sentryRemixVitePlugin } from '@sentry/remix/vite';
import { sentryOrchestrionPlugin } from '@sentry/server-utils/orchestrion/vite';
import { defineConfig } from 'vite';
import tsconfigPaths from 'vite-tsconfig-paths';

Expand All@@ -10,10 +9,6 @@ export default defineConfig({
ignoredRouteFiles: ['**/.*'],
}),
sentryRemixVitePlugin(),
// Run the orchestrion code transform over the SSR server bundle and force-bundle the
// instrumented deps (mysql, ioredis, @remix-run/server-runtime, …) so their
// diagnostics-channel calls are injected at build time.
sentryOrchestrionPlugin(),
tsconfigPaths(),
],
});
8 changes: 5 additions & 3 deletions packages/remix/src/vite/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import type { Plugin } from 'vite';
import { makeOrchestrionPlugin } from './orchestrionPlugin';
import { makeRouteManifestPlugin } from './routeManifestPlugin';
import type { SentryRemixVitePluginOptions } from './types';

Expand All@@ -7,8 +8,9 @@ export type { SentryRemixVitePluginOptions };
/**
* Sentry Vite plugins for Remix.
*
* Add these to your Vite configuration to inject the Remix route manifest, so client-side
* transactions are parameterized.
* Add these to your Vite configuration to
* - inject the Remix route manifest, so client-side transactions are parameterized, and
* - build-time instrument supported server-side dependencies (such as database clients).
*
* @example
* ```typescript
Expand All@@ -28,5 +30,5 @@ export type { SentryRemixVitePluginOptions };
* ```
*/
export function sentryRemixVitePlugin(options: SentryRemixVitePluginOptions = {}): Plugin[] {
return [makeRouteManifestPlugin(options)];
return [makeRouteManifestPlugin(options), makeOrchestrionPlugin(options)];
}
81 changes: 81 additions & 0 deletions packages/remix/src/vite/orchestrionPlugin.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,81 @@
import { sentryOrchestrionPlugin } from '@sentry/server-utils/orchestrion/vite';
import type { ConfigEnv, Plugin, ResolvedConfig, UserConfig } from 'vite';
import type { SentryRemixVitePluginOptions } from './types';

type AnyHook = (this: unknown, ...args: never[]) => unknown;
type ObjectHook<T> = T | { order?: 'pre' | 'post' | null; handler: T };
type ConfigHook = (this: unknown, config: UserConfig, env: ConfigEnv) => unknown;

const WORKER_RESOLVE_CONDITIONS = ['workerd', 'worker'];

/**
* Cloudflare Pages and Hydrogen/Oxygen builds instrument through `instrumentBuild()` from
* `@sentry/remix/cloudflare`, which wraps the build instead of subscribing to diagnostics
* channels. Transforming there would add a `node:diagnostics_channel` import and subscriber code
* that nothing reads.
*
* Oxygen sets `ssr.target`, but Remix's own Vite plugin never does — a Cloudflare app is marked by
* workerd resolve conditions instead (`cloudflareDevProxyVitePlugin` sets `externalConditions`,
* the Cloudflare template sets `conditions`), so all three signals have to be checked.
*/
function isWorkerTarget(config: UserConfig | ResolvedConfig | undefined): boolean {
const ssr = config?.ssr;
if (ssr?.target === 'webworker') {
return true;
}

return [ssr?.resolve?.conditions, ssr?.resolve?.externalConditions].some(conditions =>
conditions?.some(condition => WORKER_RESOLVE_CONDITIONS.includes(condition)),
);
}
Comment thread
cursor[bot] marked this conversation as resolved.

function hookHandler<T extends AnyHook>(hook: ObjectHook<T> | undefined): T | undefined {
return typeof hook === 'function' ? hook : hook?.handler;
}

/** No-ops a hook while `isDisabled()` holds, keeping its declared hook shape. */
function gateHook<T extends AnyHook>(
hook: ObjectHook<T> | undefined,
isDisabled: () => boolean,
): ObjectHook<T> | undefined {
if (!hook) {
return hook;
}

const handler = hookHandler(hook) as AnyHook;
const gated = function (this: unknown, ...args: never[]): unknown {
return isDisabled() ? null : handler.apply(this, args);
} as T;

return typeof hook === 'function' ? gated : { ...hook, handler: gated };
}

/** The orchestrion bundler plugin, wired to stay out of workerd builds. */
export function makeOrchestrionPlugin(options: Pick<SentryRemixVitePluginOptions, 'buildTimeInstrumentation'>): Plugin {
const orchestrion = sentryOrchestrionPlugin({ buildTimeInstrumentation: options.buildTimeInstrumentation });
const { renderChunk } = orchestrion as Plugin & { renderChunk?: ObjectHook<AnyHook> };
const config = hookHandler(orchestrion.config as ObjectHook<ConfigHook> | undefined);
const configResolved = hookHandler(orchestrion.configResolved);

let isWorkerBuild = false;

return {
...orchestrion,
// Upstream ships the plugin with `enforce: 'pre'`, which would run this hook before the
// framework plugins that set `ssr.target`. `order: 'post'` moves it after them.
config: {
order: 'post',
handler(userConfig: UserConfig, env: ConfigEnv) {
return isWorkerTarget(userConfig) ? null : (config?.(userConfig, env) ?? null);
},
},
// The authoritative check: the resolved config reflects every plugin regardless of ordering,
// and this always runs before the first `transform`.
configResolved(resolvedConfig: ResolvedConfig) {
isWorkerBuild = isWorkerTarget(resolvedConfig);
return isWorkerBuild ? undefined : configResolved?.(resolvedConfig);
},
transform: gateHook(orchestrion.transform as ObjectHook<AnyHook> | undefined, () => isWorkerBuild),
renderChunk: gateHook(renderChunk, () => isWorkerBuild),
} as Plugin;
}
11 changes: 11 additions & 0 deletions packages/remix/src/vite/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,4 +8,15 @@ export type SentryRemixVitePluginOptions = {
* @example '/absolute/path/to/app'
*/
appDirPath?: string;

/**
* Build-time instrumentation of server-side dependencies (e.g. `mysql`, `ioredis`,
* `@remix-run/server-runtime`): the plugin injects `diagnostics_channel` publishers into the
* bundled SSR output, so the SDK traces them without monkey-patching.
*
* Set to `false` to opt out.
*
* @default true
*/
buildTimeInstrumentation?: boolean;
};
121 changes: 121 additions & 0 deletions packages/remix/test/vite/index.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,121 @@
import type { ConfigEnv, UserConfig } from 'vite';
import { beforeEach, describe, expect, it, vi } from 'vitest';
import { sentryRemixVitePlugin } from '../../src/vite';

// Stub the orchestrion plugin so these stay pure wiring tests (no apm code transformer pulled in),
// mirroring the real plugin's two shapes.
const orchestrionConfig = vi.fn((_config: UserConfig, env: ConfigEnv) =>
env.command === 'serve' ? null : { ssr: { noExternal: ['mysql'] } },
);
const orchestrionConfigResolved = vi.fn();
const orchestrionTransform = vi.fn(() => ({ code: 'transformed' }));

const orchestrionVite = vi.fn((options?: { buildTimeInstrumentation?: boolean }) =>
options?.buildTimeInstrumentation === false
? { name: 'sentry-orchestrion-disabled' }
: {
name: 'code-transformer',
enforce: 'pre',
config: orchestrionConfig,
configResolved: orchestrionConfigResolved,
transform: orchestrionTransform,
},
);

vi.mock('@sentry/server-utils/orchestrion/vite', () => ({
sentryOrchestrionPlugin: (options?: { buildTimeInstrumentation?: boolean }) => orchestrionVite(options),
}));

const NODE_CONFIG = { ssr: { target: 'node' } } as UserConfig;
const WORKER_CONFIG = { ssr: { target: 'webworker' } } as UserConfig;
// Remix's own Vite plugin never sets `ssr.target`, so a Cloudflare app is only recognizable by its
// workerd resolve conditions: `cloudflareDevProxyVitePlugin` contributes `externalConditions`, the
// Cloudflare template sets `conditions` in the user's own config.
const WORKER_CONFIGS: Array<[string, UserConfig]> = [
['ssr.target', WORKER_CONFIG],
['ssr.resolve.conditions', { ssr: { resolve: { conditions: ['workerd', 'worker', 'browser'] } } } as UserConfig],
['ssr.resolve.externalConditions', { ssr: { resolve: { externalConditions: ['workerd', 'worker'] } } } as UserConfig],
];
const BUILD_ENV = { command: 'build', mode: 'production' } as ConfigEnv;
const SERVE_ENV = { command: 'serve', mode: 'development' } as ConfigEnv;

/** Calls a hook declared in either the bare-function or the `{ handler }` form. */
function callHook(hook: unknown, ...args: unknown[]): unknown {
const handler = typeof hook === 'function' ? hook : (hook as { handler: (...a: unknown[]) => unknown }).handler;
return (handler as (...a: unknown[]) => unknown)(...args);
}

describe('sentryRemixVitePlugin', () => {
beforeEach(() => {
vi.clearAllMocks();
});

it('returns the route manifest plugin and the orchestrion plugin', () => {
const plugins = sentryRemixVitePlugin();

expect(plugins.map(plugin => plugin.name)).toEqual(['sentry-remix-route-manifest', 'code-transformer']);
expect(orchestrionVite).toHaveBeenCalledWith({ buildTimeInstrumentation: undefined });
});

it('adds an inert orchestrion plugin when `buildTimeInstrumentation` is `false`', () => {
const plugins = sentryRemixVitePlugin({ buildTimeInstrumentation: false });

expect(orchestrionVite).toHaveBeenCalledWith({ buildTimeInstrumentation: false });
expect(plugins.map(plugin => plugin.name)).toContain('sentry-orchestrion-disabled');
});

it('keeps the upstream `enforce: "pre"` but defers its `config` hook to the end', () => {
const orchestrion = sentryRemixVitePlugin()[1] as { enforce?: string; config?: { order?: string } };

expect(orchestrion.enforce).toBe('pre');
expect(orchestrion.config?.order).toBe('post');
});

// The dev server keeps instrumented deps external and lets the runtime `--import` hook inject the
// channels, which the orchestrion plugin decides from `env.command` — so the wrapper has to pass
// it through untouched.
it('forwards the config env so the plugin can opt out in the dev server', () => {
const orchestrion = sentryRemixVitePlugin()[1]!;

expect(callHook(orchestrion.config, NODE_CONFIG, SERVE_ENV)).toBeNull();
expect(orchestrionConfig).toHaveBeenCalledWith(NODE_CONFIG, SERVE_ENV);
});

describe('worker targets', () => {
it('applies the orchestrion hooks for node builds', () => {
const orchestrion = sentryRemixVitePlugin()[1]!;

expect(callHook(orchestrion.config, NODE_CONFIG, BUILD_ENV)).toEqual({ ssr: { noExternal: ['mysql'] } });

callHook(orchestrion.configResolved, NODE_CONFIG);
expect(orchestrionConfigResolved).toHaveBeenCalledTimes(1);

expect(callHook(orchestrion.transform, 'code', 'mysql.js', { ssr: true })).toEqual({ code: 'transformed' });
});

it.each(WORKER_CONFIGS)('skips force-bundling and transforming when %s marks a worker', (_signal, config) => {
const orchestrion = sentryRemixVitePlugin()[1]!;

expect(callHook(orchestrion.config, config, BUILD_ENV)).toBeNull();
expect(orchestrionConfig).not.toHaveBeenCalled();

callHook(orchestrion.configResolved, config);
expect(orchestrionConfigResolved).not.toHaveBeenCalled();

expect(callHook(orchestrion.transform, 'code', 'mysql.js', { ssr: true })).toBeNull();
expect(orchestrionTransform).not.toHaveBeenCalled();
});

// Framework plugins can set `ssr.target` after our `config` hook ran, so `configResolved` is
// what actually has to keep the transform out of a worker bundle.
it('skips the transform when the worker target only shows up in the resolved config', () => {
const orchestrion = sentryRemixVitePlugin()[1]!;

callHook(orchestrion.config, {} as UserConfig, BUILD_ENV);
callHook(orchestrion.configResolved, WORKER_CONFIG);

expect(callHook(orchestrion.transform, 'code', 'mysql.js', { ssr: true })).toBeNull();
expect(orchestrionTransform).not.toHaveBeenCalled();
});
});
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions MIGRATION.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -1272,6 +1272,8 @@ Affected SDKs: `@sentry/remix`.
+ import { sentryRemixVitePlugin } from '@sentry/remix/vite';
```

The plugin now also applies the build-time instrumentation transform. If you added `sentryOrchestrionPlugin()` from `@sentry/server-utils/orchestrion/vite` to your Vite config manually, remove it. Opt out with `sentryRemixVitePlugin({ buildTimeInstrumentation: false })`.

## 3. Removed APIs

### `@sentry/core` / All SDKs
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,7 +13,6 @@
},
"dependencies": {
"@sentry/remix": "file:../../packed/sentry-remix-packed.tgz",
"@sentry/server-utils": "file:../../packed/sentry-server-utils-packed.tgz",
"@remix-run/css-bundle": "2.17.4",
"@remix-run/node": "2.17.4",
"@remix-run/react": "2.17.4",
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
import { vitePlugin as remix } from '@remix-run/dev';
import { sentryRemixVitePlugin } from '@sentry/remix/vite';
import { sentryOrchestrionPlugin } from '@sentry/server-utils/orchestrion/vite';
import { defineConfig } from 'vite';
import tsconfigPaths from 'vite-tsconfig-paths';

Expand All@@ -10,10 +9,6 @@ export default defineConfig({
ignoredRouteFiles: ['**/.*'],
}),
sentryRemixVitePlugin(),
// Run the orchestrion code transform over the SSR server bundle and force-bundle the
// instrumented deps (mysql, ioredis, @remix-run/server-runtime, …) so their
// diagnostics-channel calls are injected at build time.
sentryOrchestrionPlugin(),
tsconfigPaths(),
],
});
8 changes: 5 additions & 3 deletions packages/remix/src/vite/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import type { Plugin } from 'vite';
import { makeOrchestrionPlugin } from './orchestrionPlugin';
import { makeRouteManifestPlugin } from './routeManifestPlugin';
import type { SentryRemixVitePluginOptions } from './types';

Expand All@@ -7,8 +8,9 @@ export type { SentryRemixVitePluginOptions };
/**
* Sentry Vite plugins for Remix.
*
* Add these to your Vite configuration to inject the Remix route manifest, so client-side
* transactions are parameterized.
* Add these to your Vite configuration to
* - inject the Remix route manifest, so client-side transactions are parameterized, and
* - build-time instrument supported server-side dependencies (such as database clients).
*
* @example
* ```typescript
Expand All@@ -28,5 +30,5 @@ export type { SentryRemixVitePluginOptions };
* ```
*/
export function sentryRemixVitePlugin(options: SentryRemixVitePluginOptions = {}): Plugin[] {
return [makeRouteManifestPlugin(options)];
return [makeRouteManifestPlugin(options), makeOrchestrionPlugin(options)];
}
81 changes: 81 additions & 0 deletions packages/remix/src/vite/orchestrionPlugin.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,81 @@
import { sentryOrchestrionPlugin } from '@sentry/server-utils/orchestrion/vite';
import type { ConfigEnv, Plugin, ResolvedConfig, UserConfig } from 'vite';
import type { SentryRemixVitePluginOptions } from './types';

type AnyHook = (this: unknown, ...args: never[]) => unknown;
type ObjectHook<T> = T | { order?: 'pre' | 'post' | null; handler: T };
type ConfigHook = (this: unknown, config: UserConfig, env: ConfigEnv) => unknown;

const WORKER_RESOLVE_CONDITIONS = ['workerd', 'worker'];

/**
* Cloudflare Pages and Hydrogen/Oxygen builds instrument through `instrumentBuild()` from
* `@sentry/remix/cloudflare`, which wraps the build instead of subscribing to diagnostics
* channels. Transforming there would add a `node:diagnostics_channel` import and subscriber code
* that nothing reads.
*
* Oxygen sets `ssr.target`, but Remix's own Vite plugin never does — a Cloudflare app is marked by
* workerd resolve conditions instead (`cloudflareDevProxyVitePlugin` sets `externalConditions`,
* the Cloudflare template sets `conditions`), so all three signals have to be checked.
*/
function isWorkerTarget(config: UserConfig | ResolvedConfig | undefined): boolean {
const ssr = config?.ssr;
if (ssr?.target === 'webworker') {
return true;
}

return [ssr?.resolve?.conditions, ssr?.resolve?.externalConditions].some(conditions =>
conditions?.some(condition => WORKER_RESOLVE_CONDITIONS.includes(condition)),
);
}
Comment thread
cursor[bot] marked this conversation as resolved.

function hookHandler<T extends AnyHook>(hook: ObjectHook<T> | undefined): T | undefined {
return typeof hook === 'function' ? hook : hook?.handler;
}

/** No-ops a hook while `isDisabled()` holds, keeping its declared hook shape. */
function gateHook<T extends AnyHook>(
hook: ObjectHook<T> | undefined,
isDisabled: () => boolean,
): ObjectHook<T> | undefined {
if (!hook) {
return hook;
}

const handler = hookHandler(hook) as AnyHook;
const gated = function (this: unknown, ...args: never[]): unknown {
return isDisabled() ? null : handler.apply(this, args);
} as T;

return typeof hook === 'function' ? gated : { ...hook, handler: gated };
}

/** The orchestrion bundler plugin, wired to stay out of workerd builds. */
export function makeOrchestrionPlugin(options: Pick<SentryRemixVitePluginOptions, 'buildTimeInstrumentation'>): Plugin {
const orchestrion = sentryOrchestrionPlugin({ buildTimeInstrumentation: options.buildTimeInstrumentation });
const { renderChunk } = orchestrion as Plugin & { renderChunk?: ObjectHook<AnyHook> };
const config = hookHandler(orchestrion.config as ObjectHook<ConfigHook> | undefined);
const configResolved = hookHandler(orchestrion.configResolved);

let isWorkerBuild = false;

return {
...orchestrion,
// Upstream ships the plugin with `enforce: 'pre'`, which would run this hook before the
// framework plugins that set `ssr.target`. `order: 'post'` moves it after them.
config: {
order: 'post',
handler(userConfig: UserConfig, env: ConfigEnv) {
return isWorkerTarget(userConfig) ? null : (config?.(userConfig, env) ?? null);
},
},
// The authoritative check: the resolved config reflects every plugin regardless of ordering,
// and this always runs before the first `transform`.
configResolved(resolvedConfig: ResolvedConfig) {
isWorkerBuild = isWorkerTarget(resolvedConfig);
return isWorkerBuild ? undefined : configResolved?.(resolvedConfig);
},
transform: gateHook(orchestrion.transform as ObjectHook<AnyHook> | undefined, () => isWorkerBuild),
renderChunk: gateHook(renderChunk, () => isWorkerBuild),
} as Plugin;
}
11 changes: 11 additions & 0 deletions packages/remix/src/vite/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,4 +8,15 @@ export type SentryRemixVitePluginOptions = {
* @example '/absolute/path/to/app'
*/
appDirPath?: string;

/**
* Build-time instrumentation of server-side dependencies (e.g. `mysql`, `ioredis`,
* `@remix-run/server-runtime`): the plugin injects `diagnostics_channel` publishers into the
* bundled SSR output, so the SDK traces them without monkey-patching.
*
* Set to `false` to opt out.
*
* @default true
*/
buildTimeInstrumentation?: boolean;
};
121 changes: 121 additions & 0 deletions packages/remix/test/vite/index.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,121 @@
import type { ConfigEnv, UserConfig } from 'vite';
import { beforeEach, describe, expect, it, vi } from 'vitest';
import { sentryRemixVitePlugin } from '../../src/vite';

// Stub the orchestrion plugin so these stay pure wiring tests (no apm code transformer pulled in),
// mirroring the real plugin's two shapes.
const orchestrionConfig = vi.fn((_config: UserConfig, env: ConfigEnv) =>
env.command === 'serve' ? null : { ssr: { noExternal: ['mysql'] } },
);
const orchestrionConfigResolved = vi.fn();
const orchestrionTransform = vi.fn(() => ({ code: 'transformed' }));

const orchestrionVite = vi.fn((options?: { buildTimeInstrumentation?: boolean }) =>
options?.buildTimeInstrumentation === false
? { name: 'sentry-orchestrion-disabled' }
: {
name: 'code-transformer',
enforce: 'pre',
config: orchestrionConfig,
configResolved: orchestrionConfigResolved,
transform: orchestrionTransform,
},
);

vi.mock('@sentry/server-utils/orchestrion/vite', () => ({
sentryOrchestrionPlugin: (options?: { buildTimeInstrumentation?: boolean }) => orchestrionVite(options),
}));

const NODE_CONFIG = { ssr: { target: 'node' } } as UserConfig;
const WORKER_CONFIG = { ssr: { target: 'webworker' } } as UserConfig;
// Remix's own Vite plugin never sets `ssr.target`, so a Cloudflare app is only recognizable by its
// workerd resolve conditions: `cloudflareDevProxyVitePlugin` contributes `externalConditions`, the
// Cloudflare template sets `conditions` in the user's own config.
const WORKER_CONFIGS: Array<[string, UserConfig]> = [
['ssr.target', WORKER_CONFIG],
['ssr.resolve.conditions', { ssr: { resolve: { conditions: ['workerd', 'worker', 'browser'] } } } as UserConfig],
['ssr.resolve.externalConditions', { ssr: { resolve: { externalConditions: ['workerd', 'worker'] } } } as UserConfig],
];
const BUILD_ENV = { command: 'build', mode: 'production' } as ConfigEnv;
const SERVE_ENV = { command: 'serve', mode: 'development' } as ConfigEnv;

/** Calls a hook declared in either the bare-function or the `{ handler }` form. */
function callHook(hook: unknown, ...args: unknown[]): unknown {
const handler = typeof hook === 'function' ? hook : (hook as { handler: (...a: unknown[]) => unknown }).handler;
return (handler as (...a: unknown[]) => unknown)(...args);
}

describe('sentryRemixVitePlugin', () => {
beforeEach(() => {
vi.clearAllMocks();
});

it('returns the route manifest plugin and the orchestrion plugin', () => {
const plugins = sentryRemixVitePlugin();

expect(plugins.map(plugin => plugin.name)).toEqual(['sentry-remix-route-manifest', 'code-transformer']);
expect(orchestrionVite).toHaveBeenCalledWith({ buildTimeInstrumentation: undefined });
});

it('adds an inert orchestrion plugin when `buildTimeInstrumentation` is `false`', () => {
const plugins = sentryRemixVitePlugin({ buildTimeInstrumentation: false });

expect(orchestrionVite).toHaveBeenCalledWith({ buildTimeInstrumentation: false });
expect(plugins.map(plugin => plugin.name)).toContain('sentry-orchestrion-disabled');
});

it('keeps the upstream `enforce: "pre"` but defers its `config` hook to the end', () => {
const orchestrion = sentryRemixVitePlugin()[1] as { enforce?: string; config?: { order?: string } };

expect(orchestrion.enforce).toBe('pre');
expect(orchestrion.config?.order).toBe('post');
});

// The dev server keeps instrumented deps external and lets the runtime `--import` hook inject the
// channels, which the orchestrion plugin decides from `env.command` — so the wrapper has to pass
// it through untouched.
it('forwards the config env so the plugin can opt out in the dev server', () => {
const orchestrion = sentryRemixVitePlugin()[1]!;

expect(callHook(orchestrion.config, NODE_CONFIG, SERVE_ENV)).toBeNull();
expect(orchestrionConfig).toHaveBeenCalledWith(NODE_CONFIG, SERVE_ENV);
});

describe('worker targets', () => {
it('applies the orchestrion hooks for node builds', () => {
const orchestrion = sentryRemixVitePlugin()[1]!;

expect(callHook(orchestrion.config, NODE_CONFIG, BUILD_ENV)).toEqual({ ssr: { noExternal: ['mysql'] } });

callHook(orchestrion.configResolved, NODE_CONFIG);
expect(orchestrionConfigResolved).toHaveBeenCalledTimes(1);

expect(callHook(orchestrion.transform, 'code', 'mysql.js', { ssr: true })).toEqual({ code: 'transformed' });
});

it.each(WORKER_CONFIGS)('skips force-bundling and transforming when %s marks a worker', (_signal, config) => {
const orchestrion = sentryRemixVitePlugin()[1]!;

expect(callHook(orchestrion.config, config, BUILD_ENV)).toBeNull();
expect(orchestrionConfig).not.toHaveBeenCalled();

callHook(orchestrion.configResolved, config);
expect(orchestrionConfigResolved).not.toHaveBeenCalled();

expect(callHook(orchestrion.transform, 'code', 'mysql.js', { ssr: true })).toBeNull();
expect(orchestrionTransform).not.toHaveBeenCalled();
});

// Framework plugins can set `ssr.target` after our `config` hook ran, so `configResolved` is
// what actually has to keep the transform out of a worker bundle.
it('skips the transform when the worker target only shows up in the resolved config', () => {
const orchestrion = sentryRemixVitePlugin()[1]!;

callHook(orchestrion.config, {} as UserConfig, BUILD_ENV);
callHook(orchestrion.configResolved, WORKER_CONFIG);

expect(callHook(orchestrion.transform, 'code', 'mysql.js', { ssr: true })).toBeNull();
expect(orchestrionTransform).not.toHaveBeenCalled();
});
});
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions MIGRATION.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -1272,6 +1272,8 @@ Affected SDKs: `@sentry/remix`.
+ import { sentryRemixVitePlugin } from '@sentry/remix/vite';
```

The plugin now also applies the build-time instrumentation transform. If you added `sentryOrchestrionPlugin()` from `@sentry/server-utils/orchestrion/vite` to your Vite config manually, remove it. Opt out with `sentryRemixVitePlugin({ buildTimeInstrumentation: false })`.

## 3. Removed APIs

### `@sentry/core` / All SDKs
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,7 +13,6 @@
},
"dependencies": {
"@sentry/remix": "file:../../packed/sentry-remix-packed.tgz",
"@sentry/server-utils": "file:../../packed/sentry-server-utils-packed.tgz",
"@remix-run/css-bundle": "2.17.4",
"@remix-run/node": "2.17.4",
"@remix-run/react": "2.17.4",
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
import { vitePlugin as remix } from '@remix-run/dev';
import { sentryRemixVitePlugin } from '@sentry/remix/vite';
import { sentryOrchestrionPlugin } from '@sentry/server-utils/orchestrion/vite';
import { defineConfig } from 'vite';
import tsconfigPaths from 'vite-tsconfig-paths';

Expand All@@ -10,10 +9,6 @@ export default defineConfig({
ignoredRouteFiles: ['**/.*'],
}),
sentryRemixVitePlugin(),
// Run the orchestrion code transform over the SSR server bundle and force-bundle the
// instrumented deps (mysql, ioredis, @remix-run/server-runtime, …) so their
// diagnostics-channel calls are injected at build time.
sentryOrchestrionPlugin(),
tsconfigPaths(),
],
});
8 changes: 5 additions & 3 deletions packages/remix/src/vite/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import type { Plugin } from 'vite';
import { makeOrchestrionPlugin } from './orchestrionPlugin';
import { makeRouteManifestPlugin } from './routeManifestPlugin';
import type { SentryRemixVitePluginOptions } from './types';

Expand All@@ -7,8 +8,9 @@ export type { SentryRemixVitePluginOptions };
/**
* Sentry Vite plugins for Remix.
*
* Add these to your Vite configuration to inject the Remix route manifest, so client-side
* transactions are parameterized.
* Add these to your Vite configuration to
* - inject the Remix route manifest, so client-side transactions are parameterized, and
* - build-time instrument supported server-side dependencies (such as database clients).
*
* @example
* ```typescript
Expand All@@ -28,5 +30,5 @@ export type { SentryRemixVitePluginOptions };
* ```
*/
export function sentryRemixVitePlugin(options: SentryRemixVitePluginOptions = {}): Plugin[] {
return [makeRouteManifestPlugin(options)];
return [makeRouteManifestPlugin(options), makeOrchestrionPlugin(options)];
}
81 changes: 81 additions & 0 deletions packages/remix/src/vite/orchestrionPlugin.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,81 @@
import { sentryOrchestrionPlugin } from '@sentry/server-utils/orchestrion/vite';
import type { ConfigEnv, Plugin, ResolvedConfig, UserConfig } from 'vite';
import type { SentryRemixVitePluginOptions } from './types';

type AnyHook = (this: unknown, ...args: never[]) => unknown;
type ObjectHook<T> = T | { order?: 'pre' | 'post' | null; handler: T };
type ConfigHook = (this: unknown, config: UserConfig, env: ConfigEnv) => unknown;

const WORKER_RESOLVE_CONDITIONS = ['workerd', 'worker'];

/**
* Cloudflare Pages and Hydrogen/Oxygen builds instrument through `instrumentBuild()` from
* `@sentry/remix/cloudflare`, which wraps the build instead of subscribing to diagnostics
* channels. Transforming there would add a `node:diagnostics_channel` import and subscriber code
* that nothing reads.
*
* Oxygen sets `ssr.target`, but Remix's own Vite plugin never does — a Cloudflare app is marked by
* workerd resolve conditions instead (`cloudflareDevProxyVitePlugin` sets `externalConditions`,
* the Cloudflare template sets `conditions`), so all three signals have to be checked.
*/
function isWorkerTarget(config: UserConfig | ResolvedConfig | undefined): boolean {
const ssr = config?.ssr;
if (ssr?.target === 'webworker') {
return true;
}

return [ssr?.resolve?.conditions, ssr?.resolve?.externalConditions].some(conditions =>
conditions?.some(condition => WORKER_RESOLVE_CONDITIONS.includes(condition)),
);
}
Comment thread
cursor[bot] marked this conversation as resolved.

function hookHandler<T extends AnyHook>(hook: ObjectHook<T> | undefined): T | undefined {
return typeof hook === 'function' ? hook : hook?.handler;
}

/** No-ops a hook while `isDisabled()` holds, keeping its declared hook shape. */
function gateHook<T extends AnyHook>(
hook: ObjectHook<T> | undefined,
isDisabled: () => boolean,
): ObjectHook<T> | undefined {
if (!hook) {
return hook;
}

const handler = hookHandler(hook) as AnyHook;
const gated = function (this: unknown, ...args: never[]): unknown {
return isDisabled() ? null : handler.apply(this, args);
} as T;

return typeof hook === 'function' ? gated : { ...hook, handler: gated };
}

/** The orchestrion bundler plugin, wired to stay out of workerd builds. */
export function makeOrchestrionPlugin(options: Pick<SentryRemixVitePluginOptions, 'buildTimeInstrumentation'>): Plugin {
const orchestrion = sentryOrchestrionPlugin({ buildTimeInstrumentation: options.buildTimeInstrumentation });
const { renderChunk } = orchestrion as Plugin & { renderChunk?: ObjectHook<AnyHook> };
const config = hookHandler(orchestrion.config as ObjectHook<ConfigHook> | undefined);
const configResolved = hookHandler(orchestrion.configResolved);

let isWorkerBuild = false;

return {
...orchestrion,
// Upstream ships the plugin with `enforce: 'pre'`, which would run this hook before the
// framework plugins that set `ssr.target`. `order: 'post'` moves it after them.
config: {
order: 'post',
handler(userConfig: UserConfig, env: ConfigEnv) {
return isWorkerTarget(userConfig) ? null : (config?.(userConfig, env) ?? null);
},
},
// The authoritative check: the resolved config reflects every plugin regardless of ordering,
// and this always runs before the first `transform`.
configResolved(resolvedConfig: ResolvedConfig) {
isWorkerBuild = isWorkerTarget(resolvedConfig);
return isWorkerBuild ? undefined : configResolved?.(resolvedConfig);
},
transform: gateHook(orchestrion.transform as ObjectHook<AnyHook> | undefined, () => isWorkerBuild),
renderChunk: gateHook(renderChunk, () => isWorkerBuild),
} as Plugin;
}
11 changes: 11 additions & 0 deletions packages/remix/src/vite/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,4 +8,15 @@ export type SentryRemixVitePluginOptions = {
* @example '/absolute/path/to/app'
*/
appDirPath?: string;

/**
* Build-time instrumentation of server-side dependencies (e.g. `mysql`, `ioredis`,
* `@remix-run/server-runtime`): the plugin injects `diagnostics_channel` publishers into the
* bundled SSR output, so the SDK traces them without monkey-patching.
*
* Set to `false` to opt out.
*
* @default true
*/
buildTimeInstrumentation?: boolean;
};
121 changes: 121 additions & 0 deletions packages/remix/test/vite/index.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,121 @@
import type { ConfigEnv, UserConfig } from 'vite';
import { beforeEach, describe, expect, it, vi } from 'vitest';
import { sentryRemixVitePlugin } from '../../src/vite';

// Stub the orchestrion plugin so these stay pure wiring tests (no apm code transformer pulled in),
// mirroring the real plugin's two shapes.
const orchestrionConfig = vi.fn((_config: UserConfig, env: ConfigEnv) =>
env.command === 'serve' ? null : { ssr: { noExternal: ['mysql'] } },
);
const orchestrionConfigResolved = vi.fn();
const orchestrionTransform = vi.fn(() => ({ code: 'transformed' }));

const orchestrionVite = vi.fn((options?: { buildTimeInstrumentation?: boolean }) =>
options?.buildTimeInstrumentation === false
? { name: 'sentry-orchestrion-disabled' }
: {
name: 'code-transformer',
enforce: 'pre',
config: orchestrionConfig,
configResolved: orchestrionConfigResolved,
transform: orchestrionTransform,
},
);

vi.mock('@sentry/server-utils/orchestrion/vite', () => ({
sentryOrchestrionPlugin: (options?: { buildTimeInstrumentation?: boolean }) => orchestrionVite(options),
}));

const NODE_CONFIG = { ssr: { target: 'node' } } as UserConfig;
const WORKER_CONFIG = { ssr: { target: 'webworker' } } as UserConfig;
// Remix's own Vite plugin never sets `ssr.target`, so a Cloudflare app is only recognizable by its
// workerd resolve conditions: `cloudflareDevProxyVitePlugin` contributes `externalConditions`, the
// Cloudflare template sets `conditions` in the user's own config.
const WORKER_CONFIGS: Array<[string, UserConfig]> = [
['ssr.target', WORKER_CONFIG],
['ssr.resolve.conditions', { ssr: { resolve: { conditions: ['workerd', 'worker', 'browser'] } } } as UserConfig],
['ssr.resolve.externalConditions', { ssr: { resolve: { externalConditions: ['workerd', 'worker'] } } } as UserConfig],
];
const BUILD_ENV = { command: 'build', mode: 'production' } as ConfigEnv;
const SERVE_ENV = { command: 'serve', mode: 'development' } as ConfigEnv;

/** Calls a hook declared in either the bare-function or the `{ handler }` form. */
function callHook(hook: unknown, ...args: unknown[]): unknown {
const handler = typeof hook === 'function' ? hook : (hook as { handler: (...a: unknown[]) => unknown }).handler;
return (handler as (...a: unknown[]) => unknown)(...args);
}

describe('sentryRemixVitePlugin', () => {
beforeEach(() => {
vi.clearAllMocks();
});

it('returns the route manifest plugin and the orchestrion plugin', () => {
const plugins = sentryRemixVitePlugin();

expect(plugins.map(plugin => plugin.name)).toEqual(['sentry-remix-route-manifest', 'code-transformer']);
expect(orchestrionVite).toHaveBeenCalledWith({ buildTimeInstrumentation: undefined });
});

it('adds an inert orchestrion plugin when `buildTimeInstrumentation` is `false`', () => {
const plugins = sentryRemixVitePlugin({ buildTimeInstrumentation: false });

expect(orchestrionVite).toHaveBeenCalledWith({ buildTimeInstrumentation: false });
expect(plugins.map(plugin => plugin.name)).toContain('sentry-orchestrion-disabled');
});

it('keeps the upstream `enforce: "pre"` but defers its `config` hook to the end', () => {
const orchestrion = sentryRemixVitePlugin()[1] as { enforce?: string; config?: { order?: string } };

expect(orchestrion.enforce).toBe('pre');
expect(orchestrion.config?.order).toBe('post');
});

// The dev server keeps instrumented deps external and lets the runtime `--import` hook inject the
// channels, which the orchestrion plugin decides from `env.command` — so the wrapper has to pass
// it through untouched.
it('forwards the config env so the plugin can opt out in the dev server', () => {
const orchestrion = sentryRemixVitePlugin()[1]!;

expect(callHook(orchestrion.config, NODE_CONFIG, SERVE_ENV)).toBeNull();
expect(orchestrionConfig).toHaveBeenCalledWith(NODE_CONFIG, SERVE_ENV);
});

describe('worker targets', () => {
it('applies the orchestrion hooks for node builds', () => {
const orchestrion = sentryRemixVitePlugin()[1]!;

expect(callHook(orchestrion.config, NODE_CONFIG, BUILD_ENV)).toEqual({ ssr: { noExternal: ['mysql'] } });

callHook(orchestrion.configResolved, NODE_CONFIG);
expect(orchestrionConfigResolved).toHaveBeenCalledTimes(1);

expect(callHook(orchestrion.transform, 'code', 'mysql.js', { ssr: true })).toEqual({ code: 'transformed' });
});

it.each(WORKER_CONFIGS)('skips force-bundling and transforming when %s marks a worker', (_signal, config) => {
const orchestrion = sentryRemixVitePlugin()[1]!;

expect(callHook(orchestrion.config, config, BUILD_ENV)).toBeNull();
expect(orchestrionConfig).not.toHaveBeenCalled();

callHook(orchestrion.configResolved, config);
expect(orchestrionConfigResolved).not.toHaveBeenCalled();

expect(callHook(orchestrion.transform, 'code', 'mysql.js', { ssr: true })).toBeNull();
expect(orchestrionTransform).not.toHaveBeenCalled();
});

// Framework plugins can set `ssr.target` after our `config` hook ran, so `configResolved` is
// what actually has to keep the transform out of a worker bundle.
it('skips the transform when the worker target only shows up in the resolved config', () => {
const orchestrion = sentryRemixVitePlugin()[1]!;

callHook(orchestrion.config, {} as UserConfig, BUILD_ENV);
callHook(orchestrion.configResolved, WORKER_CONFIG);

expect(callHook(orchestrion.transform, 'code', 'mysql.js', { ssr: true })).toBeNull();
expect(orchestrionTransform).not.toHaveBeenCalled();
});
});
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions MIGRATION.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -1272,6 +1272,8 @@ Affected SDKs: `@sentry/remix`.
+ import { sentryRemixVitePlugin } from '@sentry/remix/vite';
```

The plugin now also applies the build-time instrumentation transform. If you added `sentryOrchestrionPlugin()` from `@sentry/server-utils/orchestrion/vite` to your Vite config manually, remove it. Opt out with `sentryRemixVitePlugin({ buildTimeInstrumentation: false })`.

## 3. Removed APIs

### `@sentry/core` / All SDKs
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,7 +13,6 @@
},
"dependencies": {
"@sentry/remix": "file:../../packed/sentry-remix-packed.tgz",
"@sentry/server-utils": "file:../../packed/sentry-server-utils-packed.tgz",
"@remix-run/css-bundle": "2.17.4",
"@remix-run/node": "2.17.4",
"@remix-run/react": "2.17.4",
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
import { vitePlugin as remix } from '@remix-run/dev';
import { sentryRemixVitePlugin } from '@sentry/remix/vite';
import { sentryOrchestrionPlugin } from '@sentry/server-utils/orchestrion/vite';
import { defineConfig } from 'vite';
import tsconfigPaths from 'vite-tsconfig-paths';

Expand All@@ -10,10 +9,6 @@ export default defineConfig({
ignoredRouteFiles: ['**/.*'],
}),
sentryRemixVitePlugin(),
// Run the orchestrion code transform over the SSR server bundle and force-bundle the
// instrumented deps (mysql, ioredis, @remix-run/server-runtime, …) so their
// diagnostics-channel calls are injected at build time.
sentryOrchestrionPlugin(),
tsconfigPaths(),
],
});
8 changes: 5 additions & 3 deletions packages/remix/src/vite/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import type { Plugin } from 'vite';
import { makeOrchestrionPlugin } from './orchestrionPlugin';
import { makeRouteManifestPlugin } from './routeManifestPlugin';
import type { SentryRemixVitePluginOptions } from './types';

Expand All@@ -7,8 +8,9 @@ export type { SentryRemixVitePluginOptions };
/**
* Sentry Vite plugins for Remix.
*
* Add these to your Vite configuration to inject the Remix route manifest, so client-side
* transactions are parameterized.
* Add these to your Vite configuration to
* - inject the Remix route manifest, so client-side transactions are parameterized, and
* - build-time instrument supported server-side dependencies (such as database clients).
*
* @example
* ```typescript
Expand All@@ -28,5 +30,5 @@ export type { SentryRemixVitePluginOptions };
* ```
*/
export function sentryRemixVitePlugin(options: SentryRemixVitePluginOptions = {}): Plugin[] {
return [makeRouteManifestPlugin(options)];
return [makeRouteManifestPlugin(options), makeOrchestrionPlugin(options)];
}
81 changes: 81 additions & 0 deletions packages/remix/src/vite/orchestrionPlugin.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,81 @@
import { sentryOrchestrionPlugin } from '@sentry/server-utils/orchestrion/vite';
import type { ConfigEnv, Plugin, ResolvedConfig, UserConfig } from 'vite';
import type { SentryRemixVitePluginOptions } from './types';

type AnyHook = (this: unknown, ...args: never[]) => unknown;
type ObjectHook<T> = T | { order?: 'pre' | 'post' | null; handler: T };
type ConfigHook = (this: unknown, config: UserConfig, env: ConfigEnv) => unknown;

const WORKER_RESOLVE_CONDITIONS = ['workerd', 'worker'];

/**
* Cloudflare Pages and Hydrogen/Oxygen builds instrument through `instrumentBuild()` from
* `@sentry/remix/cloudflare`, which wraps the build instead of subscribing to diagnostics
* channels. Transforming there would add a `node:diagnostics_channel` import and subscriber code
* that nothing reads.
*
* Oxygen sets `ssr.target`, but Remix's own Vite plugin never does — a Cloudflare app is marked by
* workerd resolve conditions instead (`cloudflareDevProxyVitePlugin` sets `externalConditions`,
* the Cloudflare template sets `conditions`), so all three signals have to be checked.
*/
function isWorkerTarget(config: UserConfig | ResolvedConfig | undefined): boolean {
const ssr = config?.ssr;
if (ssr?.target === 'webworker') {
return true;
}

return [ssr?.resolve?.conditions, ssr?.resolve?.externalConditions].some(conditions =>
conditions?.some(condition => WORKER_RESOLVE_CONDITIONS.includes(condition)),
);
}
Comment thread
cursor[bot] marked this conversation as resolved.

function hookHandler<T extends AnyHook>(hook: ObjectHook<T> | undefined): T | undefined {
return typeof hook === 'function' ? hook : hook?.handler;
}

/** No-ops a hook while `isDisabled()` holds, keeping its declared hook shape. */
function gateHook<T extends AnyHook>(
hook: ObjectHook<T> | undefined,
isDisabled: () => boolean,
): ObjectHook<T> | undefined {
if (!hook) {
return hook;
}

const handler = hookHandler(hook) as AnyHook;
const gated = function (this: unknown, ...args: never[]): unknown {
return isDisabled() ? null : handler.apply(this, args);
} as T;

return typeof hook === 'function' ? gated : { ...hook, handler: gated };
}

/** The orchestrion bundler plugin, wired to stay out of workerd builds. */
export function makeOrchestrionPlugin(options: Pick<SentryRemixVitePluginOptions, 'buildTimeInstrumentation'>): Plugin {
const orchestrion = sentryOrchestrionPlugin({ buildTimeInstrumentation: options.buildTimeInstrumentation });
const { renderChunk } = orchestrion as Plugin & { renderChunk?: ObjectHook<AnyHook> };
const config = hookHandler(orchestrion.config as ObjectHook<ConfigHook> | undefined);
const configResolved = hookHandler(orchestrion.configResolved);

let isWorkerBuild = false;

return {
...orchestrion,
// Upstream ships the plugin with `enforce: 'pre'`, which would run this hook before the
// framework plugins that set `ssr.target`. `order: 'post'` moves it after them.
config: {
order: 'post',
handler(userConfig: UserConfig, env: ConfigEnv) {
return isWorkerTarget(userConfig) ? null : (config?.(userConfig, env) ?? null);
},
},
// The authoritative check: the resolved config reflects every plugin regardless of ordering,
// and this always runs before the first `transform`.
configResolved(resolvedConfig: ResolvedConfig) {
isWorkerBuild = isWorkerTarget(resolvedConfig);
return isWorkerBuild ? undefined : configResolved?.(resolvedConfig);
},
transform: gateHook(orchestrion.transform as ObjectHook<AnyHook> | undefined, () => isWorkerBuild),
renderChunk: gateHook(renderChunk, () => isWorkerBuild),
} as Plugin;
}
11 changes: 11 additions & 0 deletions packages/remix/src/vite/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,4 +8,15 @@ export type SentryRemixVitePluginOptions = {
* @example '/absolute/path/to/app'
*/
appDirPath?: string;

/**
* Build-time instrumentation of server-side dependencies (e.g. `mysql`, `ioredis`,
* `@remix-run/server-runtime`): the plugin injects `diagnostics_channel` publishers into the
* bundled SSR output, so the SDK traces them without monkey-patching.
*
* Set to `false` to opt out.
*
* @default true
*/
buildTimeInstrumentation?: boolean;
};
121 changes: 121 additions & 0 deletions packages/remix/test/vite/index.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,121 @@
import type { ConfigEnv, UserConfig } from 'vite';
import { beforeEach, describe, expect, it, vi } from 'vitest';
import { sentryRemixVitePlugin } from '../../src/vite';

// Stub the orchestrion plugin so these stay pure wiring tests (no apm code transformer pulled in),
// mirroring the real plugin's two shapes.
const orchestrionConfig = vi.fn((_config: UserConfig, env: ConfigEnv) =>
env.command === 'serve' ? null : { ssr: { noExternal: ['mysql'] } },
);
const orchestrionConfigResolved = vi.fn();
const orchestrionTransform = vi.fn(() => ({ code: 'transformed' }));

const orchestrionVite = vi.fn((options?: { buildTimeInstrumentation?: boolean }) =>
options?.buildTimeInstrumentation === false
? { name: 'sentry-orchestrion-disabled' }
: {
name: 'code-transformer',
enforce: 'pre',
config: orchestrionConfig,
configResolved: orchestrionConfigResolved,
transform: orchestrionTransform,
},
);

vi.mock('@sentry/server-utils/orchestrion/vite', () => ({
sentryOrchestrionPlugin: (options?: { buildTimeInstrumentation?: boolean }) => orchestrionVite(options),
}));

const NODE_CONFIG = { ssr: { target: 'node' } } as UserConfig;
const WORKER_CONFIG = { ssr: { target: 'webworker' } } as UserConfig;
// Remix's own Vite plugin never sets `ssr.target`, so a Cloudflare app is only recognizable by its
// workerd resolve conditions: `cloudflareDevProxyVitePlugin` contributes `externalConditions`, the
// Cloudflare template sets `conditions` in the user's own config.
const WORKER_CONFIGS: Array<[string, UserConfig]> = [
['ssr.target', WORKER_CONFIG],
['ssr.resolve.conditions', { ssr: { resolve: { conditions: ['workerd', 'worker', 'browser'] } } } as UserConfig],
['ssr.resolve.externalConditions', { ssr: { resolve: { externalConditions: ['workerd', 'worker'] } } } as UserConfig],
];
const BUILD_ENV = { command: 'build', mode: 'production' } as ConfigEnv;
const SERVE_ENV = { command: 'serve', mode: 'development' } as ConfigEnv;

/** Calls a hook declared in either the bare-function or the `{ handler }` form. */
function callHook(hook: unknown, ...args: unknown[]): unknown {
const handler = typeof hook === 'function' ? hook : (hook as { handler: (...a: unknown[]) => unknown }).handler;
return (handler as (...a: unknown[]) => unknown)(...args);
}

describe('sentryRemixVitePlugin', () => {
beforeEach(() => {
vi.clearAllMocks();
});

it('returns the route manifest plugin and the orchestrion plugin', () => {
const plugins = sentryRemixVitePlugin();

expect(plugins.map(plugin => plugin.name)).toEqual(['sentry-remix-route-manifest', 'code-transformer']);
expect(orchestrionVite).toHaveBeenCalledWith({ buildTimeInstrumentation: undefined });
});

it('adds an inert orchestrion plugin when `buildTimeInstrumentation` is `false`', () => {
const plugins = sentryRemixVitePlugin({ buildTimeInstrumentation: false });

expect(orchestrionVite).toHaveBeenCalledWith({ buildTimeInstrumentation: false });
expect(plugins.map(plugin => plugin.name)).toContain('sentry-orchestrion-disabled');
});

it('keeps the upstream `enforce: "pre"` but defers its `config` hook to the end', () => {
const orchestrion = sentryRemixVitePlugin()[1] as { enforce?: string; config?: { order?: string } };

expect(orchestrion.enforce).toBe('pre');
expect(orchestrion.config?.order).toBe('post');
});

// The dev server keeps instrumented deps external and lets the runtime `--import` hook inject the
// channels, which the orchestrion plugin decides from `env.command` — so the wrapper has to pass
// it through untouched.
it('forwards the config env so the plugin can opt out in the dev server', () => {
const orchestrion = sentryRemixVitePlugin()[1]!;

expect(callHook(orchestrion.config, NODE_CONFIG, SERVE_ENV)).toBeNull();
expect(orchestrionConfig).toHaveBeenCalledWith(NODE_CONFIG, SERVE_ENV);
});

describe('worker targets', () => {
it('applies the orchestrion hooks for node builds', () => {
const orchestrion = sentryRemixVitePlugin()[1]!;

expect(callHook(orchestrion.config, NODE_CONFIG, BUILD_ENV)).toEqual({ ssr: { noExternal: ['mysql'] } });

callHook(orchestrion.configResolved, NODE_CONFIG);
expect(orchestrionConfigResolved).toHaveBeenCalledTimes(1);

expect(callHook(orchestrion.transform, 'code', 'mysql.js', { ssr: true })).toEqual({ code: 'transformed' });
});

it.each(WORKER_CONFIGS)('skips force-bundling and transforming when %s marks a worker', (_signal, config) => {
const orchestrion = sentryRemixVitePlugin()[1]!;

expect(callHook(orchestrion.config, config, BUILD_ENV)).toBeNull();
expect(orchestrionConfig).not.toHaveBeenCalled();

callHook(orchestrion.configResolved, config);
expect(orchestrionConfigResolved).not.toHaveBeenCalled();

expect(callHook(orchestrion.transform, 'code', 'mysql.js', { ssr: true })).toBeNull();
expect(orchestrionTransform).not.toHaveBeenCalled();
});

// Framework plugins can set `ssr.target` after our `config` hook ran, so `configResolved` is
// what actually has to keep the transform out of a worker bundle.
it('skips the transform when the worker target only shows up in the resolved config', () => {
const orchestrion = sentryRemixVitePlugin()[1]!;

callHook(orchestrion.config, {} as UserConfig, BUILD_ENV);
callHook(orchestrion.configResolved, WORKER_CONFIG);

expect(callHook(orchestrion.transform, 'code', 'mysql.js', { ssr: true })).toBeNull();
expect(orchestrionTransform).not.toHaveBeenCalled();
});
});
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions MIGRATION.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -1272,6 +1272,8 @@ Affected SDKs: `@sentry/remix`.
+ import { sentryRemixVitePlugin } from '@sentry/remix/vite';
```

The plugin now also applies the build-time instrumentation transform. If you added `sentryOrchestrionPlugin()` from `@sentry/server-utils/orchestrion/vite` to your Vite config manually, remove it. Opt out with `sentryRemixVitePlugin({ buildTimeInstrumentation: false })`.

## 3. Removed APIs

### `@sentry/core` / All SDKs
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,7 +13,6 @@
},
"dependencies": {
"@sentry/remix": "file:../../packed/sentry-remix-packed.tgz",
"@sentry/server-utils": "file:../../packed/sentry-server-utils-packed.tgz",
"@remix-run/css-bundle": "2.17.4",
"@remix-run/node": "2.17.4",
"@remix-run/react": "2.17.4",
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
import { vitePlugin as remix } from '@remix-run/dev';
import { sentryRemixVitePlugin } from '@sentry/remix/vite';
import { sentryOrchestrionPlugin } from '@sentry/server-utils/orchestrion/vite';
import { defineConfig } from 'vite';
import tsconfigPaths from 'vite-tsconfig-paths';

Expand All@@ -10,10 +9,6 @@ export default defineConfig({
ignoredRouteFiles: ['**/.*'],
}),
sentryRemixVitePlugin(),
// Run the orchestrion code transform over the SSR server bundle and force-bundle the
// instrumented deps (mysql, ioredis, @remix-run/server-runtime, …) so their
// diagnostics-channel calls are injected at build time.
sentryOrchestrionPlugin(),
tsconfigPaths(),
],
});
8 changes: 5 additions & 3 deletions packages/remix/src/vite/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import type { Plugin } from 'vite';
import { makeOrchestrionPlugin } from './orchestrionPlugin';
import { makeRouteManifestPlugin } from './routeManifestPlugin';
import type { SentryRemixVitePluginOptions } from './types';

Expand All@@ -7,8 +8,9 @@ export type { SentryRemixVitePluginOptions };
/**
* Sentry Vite plugins for Remix.
*
* Add these to your Vite configuration to inject the Remix route manifest, so client-side
* transactions are parameterized.
* Add these to your Vite configuration to
* - inject the Remix route manifest, so client-side transactions are parameterized, and
* - build-time instrument supported server-side dependencies (such as database clients).
*
* @example
* ```typescript
Expand All@@ -28,5 +30,5 @@ export type { SentryRemixVitePluginOptions };
* ```
*/
export function sentryRemixVitePlugin(options: SentryRemixVitePluginOptions = {}): Plugin[] {
return [makeRouteManifestPlugin(options)];
return [makeRouteManifestPlugin(options), makeOrchestrionPlugin(options)];
}
81 changes: 81 additions & 0 deletions packages/remix/src/vite/orchestrionPlugin.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,81 @@
import { sentryOrchestrionPlugin } from '@sentry/server-utils/orchestrion/vite';
import type { ConfigEnv, Plugin, ResolvedConfig, UserConfig } from 'vite';
import type { SentryRemixVitePluginOptions } from './types';

type AnyHook = (this: unknown, ...args: never[]) => unknown;
type ObjectHook<T> = T | { order?: 'pre' | 'post' | null; handler: T };
type ConfigHook = (this: unknown, config: UserConfig, env: ConfigEnv) => unknown;

const WORKER_RESOLVE_CONDITIONS = ['workerd', 'worker'];

/**
* Cloudflare Pages and Hydrogen/Oxygen builds instrument through `instrumentBuild()` from
* `@sentry/remix/cloudflare`, which wraps the build instead of subscribing to diagnostics
* channels. Transforming there would add a `node:diagnostics_channel` import and subscriber code
* that nothing reads.
*
* Oxygen sets `ssr.target`, but Remix's own Vite plugin never does — a Cloudflare app is marked by
* workerd resolve conditions instead (`cloudflareDevProxyVitePlugin` sets `externalConditions`,
* the Cloudflare template sets `conditions`), so all three signals have to be checked.
*/
function isWorkerTarget(config: UserConfig | ResolvedConfig | undefined): boolean {
const ssr = config?.ssr;
if (ssr?.target === 'webworker') {
return true;
}

return [ssr?.resolve?.conditions, ssr?.resolve?.externalConditions].some(conditions =>
conditions?.some(condition => WORKER_RESOLVE_CONDITIONS.includes(condition)),
);
}
Comment thread
cursor[bot] marked this conversation as resolved.

function hookHandler<T extends AnyHook>(hook: ObjectHook<T> | undefined): T | undefined {
return typeof hook === 'function' ? hook : hook?.handler;
}

/** No-ops a hook while `isDisabled()` holds, keeping its declared hook shape. */
function gateHook<T extends AnyHook>(
hook: ObjectHook<T> | undefined,
isDisabled: () => boolean,
): ObjectHook<T> | undefined {
if (!hook) {
return hook;
}

const handler = hookHandler(hook) as AnyHook;
const gated = function (this: unknown, ...args: never[]): unknown {
return isDisabled() ? null : handler.apply(this, args);
} as T;

return typeof hook === 'function' ? gated : { ...hook, handler: gated };
}

/** The orchestrion bundler plugin, wired to stay out of workerd builds. */
export function makeOrchestrionPlugin(options: Pick<SentryRemixVitePluginOptions, 'buildTimeInstrumentation'>): Plugin {
const orchestrion = sentryOrchestrionPlugin({ buildTimeInstrumentation: options.buildTimeInstrumentation });
const { renderChunk } = orchestrion as Plugin & { renderChunk?: ObjectHook<AnyHook> };
const config = hookHandler(orchestrion.config as ObjectHook<ConfigHook> | undefined);
const configResolved = hookHandler(orchestrion.configResolved);

let isWorkerBuild = false;

return {
...orchestrion,
// Upstream ships the plugin with `enforce: 'pre'`, which would run this hook before the
// framework plugins that set `ssr.target`. `order: 'post'` moves it after them.
config: {
order: 'post',
handler(userConfig: UserConfig, env: ConfigEnv) {
return isWorkerTarget(userConfig) ? null : (config?.(userConfig, env) ?? null);
},
},
// The authoritative check: the resolved config reflects every plugin regardless of ordering,
// and this always runs before the first `transform`.
configResolved(resolvedConfig: ResolvedConfig) {
isWorkerBuild = isWorkerTarget(resolvedConfig);
return isWorkerBuild ? undefined : configResolved?.(resolvedConfig);
},
transform: gateHook(orchestrion.transform as ObjectHook<AnyHook> | undefined, () => isWorkerBuild),
renderChunk: gateHook(renderChunk, () => isWorkerBuild),
} as Plugin;
}
11 changes: 11 additions & 0 deletions packages/remix/src/vite/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,4 +8,15 @@ export type SentryRemixVitePluginOptions = {
* @example '/absolute/path/to/app'
*/
appDirPath?: string;

/**
* Build-time instrumentation of server-side dependencies (e.g. `mysql`, `ioredis`,
* `@remix-run/server-runtime`): the plugin injects `diagnostics_channel` publishers into the
* bundled SSR output, so the SDK traces them without monkey-patching.
*
* Set to `false` to opt out.
*
* @default true
*/
buildTimeInstrumentation?: boolean;
};
121 changes: 121 additions & 0 deletions packages/remix/test/vite/index.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,121 @@
import type { ConfigEnv, UserConfig } from 'vite';
import { beforeEach, describe, expect, it, vi } from 'vitest';
import { sentryRemixVitePlugin } from '../../src/vite';

// Stub the orchestrion plugin so these stay pure wiring tests (no apm code transformer pulled in),
// mirroring the real plugin's two shapes.
const orchestrionConfig = vi.fn((_config: UserConfig, env: ConfigEnv) =>
env.command === 'serve' ? null : { ssr: { noExternal: ['mysql'] } },
);
const orchestrionConfigResolved = vi.fn();
const orchestrionTransform = vi.fn(() => ({ code: 'transformed' }));

const orchestrionVite = vi.fn((options?: { buildTimeInstrumentation?: boolean }) =>
options?.buildTimeInstrumentation === false
? { name: 'sentry-orchestrion-disabled' }
: {
name: 'code-transformer',
enforce: 'pre',
config: orchestrionConfig,
configResolved: orchestrionConfigResolved,
transform: orchestrionTransform,
},
);

vi.mock('@sentry/server-utils/orchestrion/vite', () => ({
sentryOrchestrionPlugin: (options?: { buildTimeInstrumentation?: boolean }) => orchestrionVite(options),
}));

const NODE_CONFIG = { ssr: { target: 'node' } } as UserConfig;
const WORKER_CONFIG = { ssr: { target: 'webworker' } } as UserConfig;
// Remix's own Vite plugin never sets `ssr.target`, so a Cloudflare app is only recognizable by its
// workerd resolve conditions: `cloudflareDevProxyVitePlugin` contributes `externalConditions`, the
// Cloudflare template sets `conditions` in the user's own config.
const WORKER_CONFIGS: Array<[string, UserConfig]> = [
['ssr.target', WORKER_CONFIG],
['ssr.resolve.conditions', { ssr: { resolve: { conditions: ['workerd', 'worker', 'browser'] } } } as UserConfig],
['ssr.resolve.externalConditions', { ssr: { resolve: { externalConditions: ['workerd', 'worker'] } } } as UserConfig],
];
const BUILD_ENV = { command: 'build', mode: 'production' } as ConfigEnv;
const SERVE_ENV = { command: 'serve', mode: 'development' } as ConfigEnv;

/** Calls a hook declared in either the bare-function or the `{ handler }` form. */
function callHook(hook: unknown, ...args: unknown[]): unknown {
const handler = typeof hook === 'function' ? hook : (hook as { handler: (...a: unknown[]) => unknown }).handler;
return (handler as (...a: unknown[]) => unknown)(...args);
}

describe('sentryRemixVitePlugin', () => {
beforeEach(() => {
vi.clearAllMocks();
});

it('returns the route manifest plugin and the orchestrion plugin', () => {
const plugins = sentryRemixVitePlugin();

expect(plugins.map(plugin => plugin.name)).toEqual(['sentry-remix-route-manifest', 'code-transformer']);
expect(orchestrionVite).toHaveBeenCalledWith({ buildTimeInstrumentation: undefined });
});

it('adds an inert orchestrion plugin when `buildTimeInstrumentation` is `false`', () => {
const plugins = sentryRemixVitePlugin({ buildTimeInstrumentation: false });

expect(orchestrionVite).toHaveBeenCalledWith({ buildTimeInstrumentation: false });
expect(plugins.map(plugin => plugin.name)).toContain('sentry-orchestrion-disabled');
});

it('keeps the upstream `enforce: "pre"` but defers its `config` hook to the end', () => {
const orchestrion = sentryRemixVitePlugin()[1] as { enforce?: string; config?: { order?: string } };

expect(orchestrion.enforce).toBe('pre');
expect(orchestrion.config?.order).toBe('post');
});

// The dev server keeps instrumented deps external and lets the runtime `--import` hook inject the
// channels, which the orchestrion plugin decides from `env.command` — so the wrapper has to pass
// it through untouched.
it('forwards the config env so the plugin can opt out in the dev server', () => {
const orchestrion = sentryRemixVitePlugin()[1]!;

expect(callHook(orchestrion.config, NODE_CONFIG, SERVE_ENV)).toBeNull();
expect(orchestrionConfig).toHaveBeenCalledWith(NODE_CONFIG, SERVE_ENV);
});

describe('worker targets', () => {
it('applies the orchestrion hooks for node builds', () => {
const orchestrion = sentryRemixVitePlugin()[1]!;

expect(callHook(orchestrion.config, NODE_CONFIG, BUILD_ENV)).toEqual({ ssr: { noExternal: ['mysql'] } });

callHook(orchestrion.configResolved, NODE_CONFIG);
expect(orchestrionConfigResolved).toHaveBeenCalledTimes(1);

expect(callHook(orchestrion.transform, 'code', 'mysql.js', { ssr: true })).toEqual({ code: 'transformed' });
});

it.each(WORKER_CONFIGS)('skips force-bundling and transforming when %s marks a worker', (_signal, config) => {
const orchestrion = sentryRemixVitePlugin()[1]!;

expect(callHook(orchestrion.config, config, BUILD_ENV)).toBeNull();
expect(orchestrionConfig).not.toHaveBeenCalled();

callHook(orchestrion.configResolved, config);
expect(orchestrionConfigResolved).not.toHaveBeenCalled();

expect(callHook(orchestrion.transform, 'code', 'mysql.js', { ssr: true })).toBeNull();
expect(orchestrionTransform).not.toHaveBeenCalled();
});

// Framework plugins can set `ssr.target` after our `config` hook ran, so `configResolved` is
// what actually has to keep the transform out of a worker bundle.
it('skips the transform when the worker target only shows up in the resolved config', () => {
const orchestrion = sentryRemixVitePlugin()[1]!;

callHook(orchestrion.config, {} as UserConfig, BUILD_ENV);
callHook(orchestrion.configResolved, WORKER_CONFIG);

expect(callHook(orchestrion.transform, 'code', 'mysql.js', { ssr: true })).toBeNull();
expect(orchestrionTransform).not.toHaveBeenCalled();
});
});
});
Loading