Uh oh!
There was an error while loading. Please reload this page.
test(e2e): Port Bun E2E test apps to span streaming - #23997
Merged
Conversation
Ports `elysia-bun`, `bun-mysql` and `bun-bytecode` plus the `bun-integration-tests` suites (`basic`, `fetch`, `hono-sdk`) to span streaming, and adds `elysia-bun-static` as a verbatim copy of the pre-port `elysia-bun` to keep the static trace lifecycle covered. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
size-limit report 📦
|
msonnb
marked this pull request as ready for review
September 3, 2026 11:41
msonnb
requested review from
andreiborza, isaacs and mydea
and removed request for
a teamSeptember 3, 2026 11:41
Uh oh!
There was an error while loading. Please reload this page.
andreiborza
approved these changes
Sep 3, 2026
| if (url.pathname === '/outgoing-fetch-message') { | ||
| await fetch(`${targetUrl}/allowed`); | ||
| Sentry.captureMessage('fetch done'); |
Member
There was a problem hiding this comment.
l: I think we don't want to usage captureMessage anymore, can you just capture an exception instead?
…adcrumb suite Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
andreiborza
approved these changes
Sep 3, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports
elysia-bun,bun-mysqlandbun-bytecodeto span streaming: thetraceLifecycle: 'static'pin from #22590 is removed and the specs assert on streamed spans instead of transactions. Thebun-integration-testssuitesbasic,fetchandhono-sdkcarried the same pin and are ported in the same pass.elysia-bun-staticis added as a verbatim copy ofelysia-bunbefore the port so the static trace lifecycle stays covered for this group. Only the app name changes, and it's added to the CI Bun setup list.Decisions taken:
Bun.servewithoutrouteshas no parameterized route, so its streamedhttp.serversegments are namedGETonly. Thebun-mysqlandfetchspecs identify the request via theurl.pathattribute instead.SELECTfor both queries inbun-mysql), so the specs match queries ondb.query.text.fetchsuite's breadcrumb test now hits a new/outgoing-fetch-errorroute that captures an exception after the fetch and asserts the breadcrumb on that event.Handle/anonymous, so the<unknown>regression test now asserts that all handler spans carry the route name.Fixes#23813
🤖 Generated with Claude Code