test(e2e): Port Deno db E2E test apps to span streaming#24003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
msonnb wants to merge 1 commit into
base:develop
Choose a base branch
from
Open

test(e2e): Port Deno db E2E test apps to span streaming #24003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion dev-packages/e2e-tests/test-applications/deno-mysql/src/app.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,6 @@ import '@sentry/deno/import';
import * as Sentry from '@sentry/deno';

Sentry.init({
traceLifecycle: 'static',
environment: 'qa',
dsn: Deno.env.get('E2E_TEST_DSN'),
debug: !!Deno.env.get('DEBUG'),
Expand Down
75 changes: 42 additions & 33 deletions dev-packages/e2e-tests/test-applications/deno-mysql/tests/mysql.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,54 +1,63 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { collectStreamedSpans, getSpanOp } from '@sentry-internal/test-utils';
import type { SerializedStreamedSpan } from '@sentry/core';

// `Deno.serve` has no route information, so with span streaming the http.server segment is
// named after the method only; the path lives in `url.path`.
function isTestMysqlSegment(span: SerializedStreamedSpan): boolean {
return getSpanOp(span) === 'http.server' && span.is_segment && span.attributes['url.path']?.value === '/test-mysql';
}

test('mysql queries emit a db span with orchestrion-channel attributes', async ({ baseURL }) => {
// Each incoming request gets a Sentry http.server transaction (via the
// Each incoming request gets a Sentry http.server segment span (via the
// default denoServeIntegration); the mysql queries run inside it, so their
// db spans attach to that transaction.
const transactionPromise = waitForTransaction('deno-mysql', event => {
return (
event?.contexts?.trace?.op === 'http.server' &&
(event.request?.url ?? '').includes('/test-mysql') &&
(event.spans?.some(span => span.op === 'db') ?? false)
);
});
// db spans join that trace.
const spansPromise = collectStreamedSpans(
'deno-mysql',
spans => spans.some(isTestMysqlSegment) && spans.some(span => getSpanOp(span) === 'db'),
);

const res = await fetch(`${baseURL}/test-mysql`);
expect(res.status).toBe(200);
await res.json();

const transaction = await transactionPromise;
const dbSpans = transaction.spans!.filter(span => span.op === 'db');
const spans = await spansPromise;
const dbSpans = spans.filter(span => getSpanOp(span) === 'db');

const firstQuery = dbSpans.find(span => span.description === 'SELECT 1 + 1 AS solution');
const firstQuery = dbSpans.find(span => span.attributes['db.query.text']?.value === 'SELECT 1 + 1 AS solution');
expect(firstQuery).toBeDefined();
expect(firstQuery!.data?.['sentry.origin']).toBe('auto.db.mysql');
expect(firstQuery!.data?.['db.system.name']).toBe('mysql');
expect(firstQuery!.data?.['db.query.text']).toBe('SELECT 1 + 1 AS solution');
expect(firstQuery!.data?.['server.port']).toBe(3306);
expect(firstQuery!.data?.['db.user']).toBe('root');
// With span streaming, db span names are the low-cardinality query summary, not the raw SQL
expect(firstQuery!.name).toBe('SELECT');
expect(firstQuery!.attributes).toMatchObject({
'sentry.origin': { value: 'auto.db.mysql', type: 'string' },
'db.system.name': { value: 'mysql', type: 'string' },
'db.query.text': { value: 'SELECT 1 + 1 AS solution', type: 'string' },
'server.port': { value: 3306, type: 'integer' },
'db.user': { value: 'root', type: 'string' },
});
});

test('a nested query lands on the same transaction (AsyncLocalStorage context restored)', async ({ baseURL }) => {
test('a nested query lands on the same trace (AsyncLocalStorage context restored)', async ({ baseURL }) => {
// The second query runs inside the first query's callback — i.e. across
// mysql's async socket-callback dispatch. Both spans appearing on the SAME
// http.server transaction proves denoMysqlIntegration's context strategy
// mysql's async socket-callback dispatch. Both db spans being children of the
// SAME http.server segment proves denoMysqlIntegration's context strategy
// restored the parent span across that async boundary (otherwise the nested
// query would start its own trace and never join this transaction).
const transactionPromise = waitForTransaction('deno-mysql', event => {
return (
event?.contexts?.trace?.op === 'http.server' &&
(event.request?.url ?? '').includes('/test-mysql') &&
(event.spans?.filter(span => span.op === 'db').length ?? 0) >= 2
);
});
// query would start its own trace and never join this one).
const spansPromise = collectStreamedSpans(
'deno-mysql',
spans => spans.some(isTestMysqlSegment) && spans.filter(span => getSpanOp(span) === 'db').length >= 2,
);

const res = await fetch(`${baseURL}/test-mysql`);
expect(res.status).toBe(200);
await res.json();

const transaction = await transactionPromise;
const descriptions = transaction.spans!.filter(span => span.op === 'db').map(span => span.description);
expect(descriptions).toContain('SELECT 1 + 1 AS solution');
expect(descriptions).toContain('SELECT NOW()');
const spans = await spansPromise;
const segment = spans.find(isTestMysqlSegment)!;
const dbSpans = spans.filter(span => getSpanOp(span) === 'db');

const queries = dbSpans.map(span => span.attributes['db.query.text']?.value);
expect(queries).toContain('SELECT 1 + 1 AS solution');
expect(queries).toContain('SELECT NOW()');
expect(dbSpans.every(span => span.parent_span_id === segment.span_id)).toBe(true);
});
1 change: 0 additions & 1 deletion dev-packages/e2e-tests/test-applications/deno-pg/src/app.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,6 @@ import '@sentry/deno/import';
import * as Sentry from '@sentry/deno';

Sentry.init({
traceLifecycle: 'static',
environment: 'qa',
dsn: Deno.env.get('E2E_TEST_DSN'),
debug: !!Deno.env.get('DEBUG'),
Expand Down
75 changes: 42 additions & 33 deletions dev-packages/e2e-tests/test-applications/deno-pg/tests/pg.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,55 +1,64 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { collectStreamedSpans, getSpanOp } from '@sentry-internal/test-utils';
import type { SerializedStreamedSpan } from '@sentry/core';

// `Deno.serve` has no route information, so with span streaming the http.server segment is
// named after the method only; the path lives in `url.path`.
function isTestPgSegment(span: SerializedStreamedSpan): boolean {
return getSpanOp(span) === 'http.server' && span.is_segment && span.attributes['url.path']?.value === '/test-pg';
}

test('pg queries emit a db span with orchestrion-channel attributes', async ({ baseURL }) => {
// Each incoming request gets a Sentry http.server transaction (via the
// Each incoming request gets a Sentry http.server segment span (via the
// default denoServeIntegration); the pg queries run inside it, so their
// db spans attach to that transaction.
const transactionPromise = waitForTransaction('deno-pg', event => {
return (
event?.contexts?.trace?.op === 'http.server' &&
(event.request?.url ?? '').includes('/test-pg') &&
(event.spans?.some(span => span.op === 'db') ?? false)
);
});
// db spans join that trace.
const spansPromise = collectStreamedSpans(
'deno-pg',
spans => spans.some(isTestPgSegment) && spans.some(span => getSpanOp(span) === 'db'),
);

const res = await fetch(`${baseURL}/test-pg`);
expect(res.status).toBe(200);
await res.json();

const transaction = await transactionPromise;
const dbSpans = transaction.spans!.filter(span => span.op === 'db');
const spans = await spansPromise;
const dbSpans = spans.filter(span => getSpanOp(span) === 'db');

const firstQuery = dbSpans.find(span => span.description === 'SELECT 1 + 1 AS solution');
const firstQuery = dbSpans.find(span => span.attributes['db.query.text']?.value === 'SELECT 1 + 1 AS solution');
expect(firstQuery).toBeDefined();
expect(firstQuery!.data?.['sentry.origin']).toBe('auto.db.postgres');
expect(firstQuery!.data?.['db.system.name']).toBe('postgresql');
expect(firstQuery!.data?.['db.query.text']).toBe('SELECT 1 + 1 AS solution');
expect(firstQuery!.data?.['server.port']).toBe(5432);
expect(firstQuery!.data?.['db.user']).toBe('postgres');
// With span streaming, db span names are the low-cardinality query summary, not the raw SQL
expect(firstQuery!.name).toBe('SELECT');
expect(firstQuery!.attributes).toMatchObject({
'sentry.origin': { value: 'auto.db.postgres', type: 'string' },
'db.system.name': { value: 'postgresql', type: 'string' },
'db.query.text': { value: 'SELECT 1 + 1 AS solution', type: 'string' },
'server.port': { value: 5432, type: 'integer' },
'db.user': { value: 'postgres', type: 'string' },
});
});

test('a nested query lands on the same transaction (AsyncLocalStorage context restored)', async ({ baseURL }) => {
test('a nested query lands on the same trace (AsyncLocalStorage context restored)', async ({ baseURL }) => {
// The second query runs inside the first query's callback
// i.e. across pg's async socket-callback dispatch. Both spans appearing
// on the SAME http.server transaction proves denoPostgresIntegration's
// i.e. across pg's async socket-callback dispatch. Both db spans being
// children of the SAME http.server segment proves denoPostgresIntegration's
// context strategy restored the parent span across that async boundary
// (otherwise the nested query would start its own trace and never join
// this transaction).
const transactionPromise = waitForTransaction('deno-pg', event => {
return (
event?.contexts?.trace?.op === 'http.server' &&
(event.request?.url ?? '').includes('/test-pg') &&
(event.spans?.filter(span => span.op === 'db').length ?? 0) >= 2
);
});
// this one).
const spansPromise = collectStreamedSpans(
'deno-pg',
spans => spans.some(isTestPgSegment) && spans.filter(span => getSpanOp(span) === 'db').length >= 2,
);

const res = await fetch(`${baseURL}/test-pg`);
expect(res.status).toBe(200);
await res.json();

const transaction = await transactionPromise;
const descriptions = transaction.spans!.filter(span => span.op === 'db').map(span => span.description);
expect(descriptions).toContain('SELECT 1 + 1 AS solution');
expect(descriptions).toContain('SELECT NOW()');
const spans = await spansPromise;
const segment = spans.find(isTestPgSegment)!;
const dbSpans = spans.filter(span => getSpanOp(span) === 'db');

const queries = dbSpans.map(span => span.attributes['db.query.text']?.value);
expect(queries).toContain('SELECT 1 + 1 AS solution');
expect(queries).toContain('SELECT NOW()');
expect(dbSpans.every(span => span.parent_span_id === segment.span_id)).toBe(true);
});
1 change: 0 additions & 1 deletion dev-packages/e2e-tests/test-applications/deno-redis/src/app.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@ import IORedis from 'ioredis';
import { createClient } from 'redis';

Sentry.init({
traceLifecycle: 'static',
environment: 'qa',
dsn: Deno.env.get('E2E_TEST_DSN'),
debug: !!Deno.env.get('DEBUG'),
Expand Down
121 changes: 67 additions & 54 deletions dev-packages/e2e-tests/test-applications/deno-redis/tests/ioredis.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,94 +1,107 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { collectStreamedSpans, getSpanOp } from '@sentry-internal/test-utils';
import type { SerializedStreamedSpan } from '@sentry/core';

test('ioredis GET emits an http.server transaction containing a db.query child span', async ({ baseURL }) => {
// Each incoming request gets a Sentry http.server transaction (via the
// `Deno.serve` has no route information, so with span streaming the http.server segment is
// named after the method only; the path lives in `url.path`.
function isSegmentFor(path: string): (span: SerializedStreamedSpan) => boolean {
return span => getSpanOp(span) === 'http.server' && span.is_segment && span.attributes['url.path']?.value === path;
}

function isRedisCommand(span: SerializedStreamedSpan): boolean {
return getSpanOp(span) === 'db.query';
}

// `db.query.text` carries the key, so with span streaming a redis command span is named
// `{db.operation.name} {server.address}:{server.port}` instead.
function expectedCommandName(span: SerializedStreamedSpan): string {
const { 'db.operation.name': operation, 'server.address': address, 'server.port': port } = span.attributes;
return `${operation?.value} ${address?.value}:${port?.value}`;
}

test('ioredis GET emits an http.server segment containing a db.query child span', async ({ baseURL }) => {
// Each incoming request gets a Sentry http.server segment span (via the
// default denoServeIntegration); the ioredis command runs inside it, so the
// child span attaches to that transaction.
const transactionPromise = waitForTransaction('deno-redis', event => {
return (
event?.contexts?.trace?.op === 'http.server' &&
(event.request?.url ?? '').includes('/ioredis-get') &&
(event.spans?.some(span => span.op === 'db.query') ?? false)
);
});
// child span joins that trace.
const spansPromise = collectStreamedSpans(
'deno-redis',
spans => spans.some(isSegmentFor('/ioredis-get')) && spans.some(isRedisCommand),
);

const res = await fetch(`${baseURL}/ioredis-get?key=iocache:user:42`);
expect(res.status).toBe(200);
await res.json();

const transaction = await transactionPromise;
const redisSpan = transaction.spans!.find(span => span.op === 'db.query');
const spans = await spansPromise;
const segment = spans.find(isSegmentFor('/ioredis-get'))!;
const redisSpan = spans.find(isRedisCommand);
expect(redisSpan).toBeDefined();
// ioredis publishes lowercase command names; node-redis publishes uppercase.
expect(redisSpan!.description).toBe('redis-get');
expect(redisSpan!.data?.['db.system.name']).toBe('redis');
expect(redisSpan!.data?.['db.query.text']).toBe('get iocache:user:42');
expect(redisSpan!.parent_span_id).toBe(segment.span_id);
expect(redisSpan!.name).toBe(expectedCommandName(redisSpan!));
expect(redisSpan!.attributes).toMatchObject({
'db.system.name': { value: 'redis', type: 'string' },
// ioredis publishes lowercase command names; node-redis publishes uppercase.
'db.operation.name': { value: 'get', type: 'string' },
'db.query.text': { value: 'get iocache:user:42', type: 'string' },
});
});

test('ioredis SET then GET emit two db.query child spans on the same transaction', async ({ baseURL }) => {
const transactionPromise = waitForTransaction('deno-redis', event => {
return (
event?.contexts?.trace?.op === 'http.server' &&
(event.request?.url ?? '').includes('/ioredis-set-get') &&
(event.spans?.filter(span => span.op === 'db.query').length ?? 0) >= 2
);
});
test('ioredis SET then GET emit two db.query child spans on the same trace', async ({ baseURL }) => {
const spansPromise = collectStreamedSpans(
'deno-redis',
spans => spans.some(isSegmentFor('/ioredis-set-get')) && spans.filter(isRedisCommand).length >= 2,
);

const res = await fetch(`${baseURL}/ioredis-set-get?key=iocache:greeting&value=hello`);
expect(res.status).toBe(200);
await res.json();

const transaction = await transactionPromise;
const redisSpans = transaction.spans!.filter(span => span.op === 'db.query');
const spans = await spansPromise;
const segment = spans.find(isSegmentFor('/ioredis-set-get'))!;
const redisSpans = spans.filter(isRedisCommand);
expect(redisSpans.length).toBeGreaterThanOrEqual(2);
const ops = redisSpans.map(s => s.description);
expect(ops).toContain('redis-set');
expect(ops).toContain('redis-get');
expect(redisSpans.every(span => span.parent_span_id === segment.span_id)).toBe(true);
const ops = redisSpans.map(span => span.attributes['db.operation.name']?.value);
expect(ops).toContain('set');
expect(ops).toContain('get');
});

test('ioredis MULTI emits one db.query span per command (no batch channel)', async ({ baseURL }) => {
// ioredis does not publish to a batch channel — each command in the
// transaction publishes individually with batchMode/batchSize set on its
// own payload. So the transaction should contain multiple `redis-<cmd>`
// child spans, but no PIPELINE/MULTI batch span.
const transactionPromise = waitForTransaction('deno-redis', event => {
return (
event?.contexts?.trace?.op === 'http.server' &&
(event.request?.url ?? '').includes('/ioredis-multi') &&
(event.spans?.filter(span => span.op === 'db.query').length ?? 0) >= 3
);
});
// own payload. So the trace should contain multiple command child spans,
// but no PIPELINE/MULTI batch span.
const spansPromise = collectStreamedSpans(
'deno-redis',
spans => spans.some(isSegmentFor('/ioredis-multi')) && spans.filter(isRedisCommand).length >= 3,
);

const res = await fetch(`${baseURL}/ioredis-multi`);
expect(res.status).toBe(200);
await res.json();

const transaction = await transactionPromise;
const redisSpans = transaction.spans!.filter(span => span.op === 'db.query');
const spans = await spansPromise;
const redisSpans = spans.filter(isRedisCommand);
expect(redisSpans.length).toBeGreaterThanOrEqual(3);
const descriptions = redisSpans.map(s => s.description);
expect(descriptions).toContain('redis-set');
expect(descriptions).toContain('redis-get');
const ops = redisSpans.map(span => span.attributes['db.operation.name']?.value);
expect(ops).toContain('set');
expect(ops).toContain('get');
// No PIPELINE/MULTI batch wrapper span — ioredis has no separate batch channel.
const batchSpan = transaction.spans!.find(span => span.description === 'MULTI' || span.description === 'PIPELINE');
const batchSpan = spans.find(span => span.name === 'MULTI' || span.name === 'PIPELINE');
expect(batchSpan).toBeUndefined();
});

test('ioredis PIPELINE emits one db.query span per command', async ({ baseURL }) => {
const transactionPromise = waitForTransaction('deno-redis', event => {
return (
event?.contexts?.trace?.op === 'http.server' &&
(event.request?.url ?? '').includes('/ioredis-pipeline') &&
(event.spans?.filter(span => span.op === 'db.query').length ?? 0) >= 3
);
});
const spansPromise = collectStreamedSpans(
'deno-redis',
spans => spans.some(isSegmentFor('/ioredis-pipeline')) && spans.filter(isRedisCommand).length >= 3,
);

const res = await fetch(`${baseURL}/ioredis-pipeline`);
expect(res.status).toBe(200);
await res.json();

const transaction = await transactionPromise;
const redisSpans = transaction.spans!.filter(span => span.op === 'db.query');
const spans = await spansPromise;
const redisSpans = spans.filter(isRedisCommand);
expect(redisSpans.length).toBeGreaterThanOrEqual(3);
});
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
test(e2e): Port Deno db E2E test apps to span streaming#24003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Open

msonnb
wants to merge
1
commit into

base:develop
Choose a base branch

from

 Open


test(e2e): Port Deno db E2E test apps to span streaming
#24003
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
dev-packages/e2e-tests/test-applications/deno-mysql/src/app.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,6 @@ import '@sentry/deno/import';
import * as Sentry from '@sentry/deno';

Sentry.init({
 traceLifecycle: 'static',
 environment: 'qa',
 dsn: Deno.env.get('E2E_TEST_DSN'),
 debug: !!Deno.env.get('DEBUG'),
Expand Down

75 changes: 42 additions & 33 deletions
dev-packages/e2e-tests/test-applications/deno-mysql/tests/mysql.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,54 +1,63 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { collectStreamedSpans, getSpanOp } from '@sentry-internal/test-utils';
import type { SerializedStreamedSpan } from '@sentry/core';

// `Deno.serve` has no route information, so with span streaming the http.server segment is
// named after the method only; the path lives in `url.path`.
function isTestMysqlSegment(span: SerializedStreamedSpan): boolean {
 return getSpanOp(span) === 'http.server' && span.is_segment && span.attributes['url.path']?.value === '/test-mysql';
}

test('mysql queries emit a db span with orchestrion-channel attributes', async ({ baseURL }) => {
 // Each incoming request gets a Sentry http.server transaction (via the
 // Each incoming request gets a Sentry http.server segment span (via the
 // default denoServeIntegration); the mysql queries run inside it, so their
 // db spans attach to that transaction.
 const transactionPromise = waitForTransaction('deno-mysql', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/test-mysql') &&
 (event.spans?.some(span => span.op === 'db') ?? false)
 );
 });
 // db spans join that trace.
 const spansPromise = collectStreamedSpans(
 'deno-mysql',
 spans => spans.some(isTestMysqlSegment) && spans.some(span => getSpanOp(span) === 'db'),
 );

 const res = await fetch(`${baseURL}/test-mysql`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const dbSpans = transaction.spans!.filter(span => span.op === 'db');
 const spans = await spansPromise;
 const dbSpans = spans.filter(span => getSpanOp(span) === 'db');

 const firstQuery = dbSpans.find(span => span.description === 'SELECT 1 + 1 AS solution');
 const firstQuery = dbSpans.find(span => span.attributes['db.query.text']?.value === 'SELECT 1 + 1 AS solution');
 expect(firstQuery).toBeDefined();
 expect(firstQuery!.data?.['sentry.origin']).toBe('auto.db.mysql');
 expect(firstQuery!.data?.['db.system.name']).toBe('mysql');
 expect(firstQuery!.data?.['db.query.text']).toBe('SELECT 1 + 1 AS solution');
 expect(firstQuery!.data?.['server.port']).toBe(3306);
 expect(firstQuery!.data?.['db.user']).toBe('root');
 // With span streaming, db span names are the low-cardinality query summary, not the raw SQL
 expect(firstQuery!.name).toBe('SELECT');
 expect(firstQuery!.attributes).toMatchObject({
 'sentry.origin': { value: 'auto.db.mysql', type: 'string' },
 'db.system.name': { value: 'mysql', type: 'string' },
 'db.query.text': { value: 'SELECT 1 + 1 AS solution', type: 'string' },
 'server.port': { value: 3306, type: 'integer' },
 'db.user': { value: 'root', type: 'string' },
 });
});

test('a nested query lands on the same transaction (AsyncLocalStorage context restored)', async ({ baseURL }) => {
test('a nested query lands on the same trace (AsyncLocalStorage context restored)', async ({ baseURL }) => {
 // The second query runs inside the first query's callback — i.e. across
 // mysql's async socket-callback dispatch. Both spans appearing on the SAME
 // http.server transaction proves denoMysqlIntegration's context strategy
 // mysql's async socket-callback dispatch. Both db spans being children of the
 // SAME http.server segment proves denoMysqlIntegration's context strategy
 // restored the parent span across that async boundary (otherwise the nested
 // query would start its own trace and never join this transaction).
 const transactionPromise = waitForTransaction('deno-mysql', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/test-mysql') &&
 (event.spans?.filter(span => span.op === 'db').length ?? 0) >= 2
 );
 });
 // query would start its own trace and never join this one).
 const spansPromise = collectStreamedSpans(
 'deno-mysql',
 spans => spans.some(isTestMysqlSegment) && spans.filter(span => getSpanOp(span) === 'db').length >= 2,
 );

 const res = await fetch(`${baseURL}/test-mysql`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const descriptions = transaction.spans!.filter(span => span.op === 'db').map(span => span.description);
 expect(descriptions).toContain('SELECT 1 + 1 AS solution');
 expect(descriptions).toContain('SELECT NOW()');
 const spans = await spansPromise;
 const segment = spans.find(isTestMysqlSegment)!;
 const dbSpans = spans.filter(span => getSpanOp(span) === 'db');

 const queries = dbSpans.map(span => span.attributes['db.query.text']?.value);
 expect(queries).toContain('SELECT 1 + 1 AS solution');
 expect(queries).toContain('SELECT NOW()');
 expect(dbSpans.every(span => span.parent_span_id === segment.span_id)).toBe(true);
});

1 change: 0 additions & 1 deletion
dev-packages/e2e-tests/test-applications/deno-pg/src/app.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,6 @@ import '@sentry/deno/import';
import * as Sentry from '@sentry/deno';

Sentry.init({
 traceLifecycle: 'static',
 environment: 'qa',
 dsn: Deno.env.get('E2E_TEST_DSN'),
 debug: !!Deno.env.get('DEBUG'),
Expand Down

75 changes: 42 additions & 33 deletions
dev-packages/e2e-tests/test-applications/deno-pg/tests/pg.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,55 +1,64 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { collectStreamedSpans, getSpanOp } from '@sentry-internal/test-utils';
import type { SerializedStreamedSpan } from '@sentry/core';

// `Deno.serve` has no route information, so with span streaming the http.server segment is
// named after the method only; the path lives in `url.path`.
function isTestPgSegment(span: SerializedStreamedSpan): boolean {
 return getSpanOp(span) === 'http.server' && span.is_segment && span.attributes['url.path']?.value === '/test-pg';
}

test('pg queries emit a db span with orchestrion-channel attributes', async ({ baseURL }) => {
 // Each incoming request gets a Sentry http.server transaction (via the
 // Each incoming request gets a Sentry http.server segment span (via the
 // default denoServeIntegration); the pg queries run inside it, so their
 // db spans attach to that transaction.
 const transactionPromise = waitForTransaction('deno-pg', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/test-pg') &&
 (event.spans?.some(span => span.op === 'db') ?? false)
 );
 });
 // db spans join that trace.
 const spansPromise = collectStreamedSpans(
 'deno-pg',
 spans => spans.some(isTestPgSegment) && spans.some(span => getSpanOp(span) === 'db'),
 );

 const res = await fetch(`${baseURL}/test-pg`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const dbSpans = transaction.spans!.filter(span => span.op === 'db');
 const spans = await spansPromise;
 const dbSpans = spans.filter(span => getSpanOp(span) === 'db');

 const firstQuery = dbSpans.find(span => span.description === 'SELECT 1 + 1 AS solution');
 const firstQuery = dbSpans.find(span => span.attributes['db.query.text']?.value === 'SELECT 1 + 1 AS solution');
 expect(firstQuery).toBeDefined();
 expect(firstQuery!.data?.['sentry.origin']).toBe('auto.db.postgres');
 expect(firstQuery!.data?.['db.system.name']).toBe('postgresql');
 expect(firstQuery!.data?.['db.query.text']).toBe('SELECT 1 + 1 AS solution');
 expect(firstQuery!.data?.['server.port']).toBe(5432);
 expect(firstQuery!.data?.['db.user']).toBe('postgres');
 // With span streaming, db span names are the low-cardinality query summary, not the raw SQL
 expect(firstQuery!.name).toBe('SELECT');
 expect(firstQuery!.attributes).toMatchObject({
 'sentry.origin': { value: 'auto.db.postgres', type: 'string' },
 'db.system.name': { value: 'postgresql', type: 'string' },
 'db.query.text': { value: 'SELECT 1 + 1 AS solution', type: 'string' },
 'server.port': { value: 5432, type: 'integer' },
 'db.user': { value: 'postgres', type: 'string' },
 });
});

test('a nested query lands on the same transaction (AsyncLocalStorage context restored)', async ({ baseURL }) => {
test('a nested query lands on the same trace (AsyncLocalStorage context restored)', async ({ baseURL }) => {
 // The second query runs inside the first query's callback
 // i.e. across pg's async socket-callback dispatch. Both spans appearing
 // on the SAME http.server transaction proves denoPostgresIntegration's
 // i.e. across pg's async socket-callback dispatch. Both db spans being
 // children of the SAME http.server segment proves denoPostgresIntegration's
 // context strategy restored the parent span across that async boundary
 // (otherwise the nested query would start its own trace and never join
 // this transaction).
 const transactionPromise = waitForTransaction('deno-pg', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/test-pg') &&
 (event.spans?.filter(span => span.op === 'db').length ?? 0) >= 2
 );
 });
 // this one).
 const spansPromise = collectStreamedSpans(
 'deno-pg',
 spans => spans.some(isTestPgSegment) && spans.filter(span => getSpanOp(span) === 'db').length >= 2,
 );

 const res = await fetch(`${baseURL}/test-pg`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const descriptions = transaction.spans!.filter(span => span.op === 'db').map(span => span.description);
 expect(descriptions).toContain('SELECT 1 + 1 AS solution');
 expect(descriptions).toContain('SELECT NOW()');
 const spans = await spansPromise;
 const segment = spans.find(isTestPgSegment)!;
 const dbSpans = spans.filter(span => getSpanOp(span) === 'db');

 const queries = dbSpans.map(span => span.attributes['db.query.text']?.value);
 expect(queries).toContain('SELECT 1 + 1 AS solution');
 expect(queries).toContain('SELECT NOW()');
 expect(dbSpans.every(span => span.parent_span_id === segment.span_id)).toBe(true);
});

1 change: 0 additions & 1 deletion
dev-packages/e2e-tests/test-applications/deno-redis/src/app.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@ import IORedis from 'ioredis';
import { createClient } from 'redis';

Sentry.init({
 traceLifecycle: 'static',
 environment: 'qa',
 dsn: Deno.env.get('E2E_TEST_DSN'),
 debug: !!Deno.env.get('DEBUG'),
Expand Down

121 changes: 67 additions & 54 deletions
dev-packages/e2e-tests/test-applications/deno-redis/tests/ioredis.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,94 +1,107 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { collectStreamedSpans, getSpanOp } from '@sentry-internal/test-utils';
import type { SerializedStreamedSpan } from '@sentry/core';

test('ioredis GET emits an http.server transaction containing a db.query child span', async ({ baseURL }) => {
 // Each incoming request gets a Sentry http.server transaction (via the
// `Deno.serve` has no route information, so with span streaming the http.server segment is
// named after the method only; the path lives in `url.path`.
function isSegmentFor(path: string): (span: SerializedStreamedSpan) => boolean {
 return span => getSpanOp(span) === 'http.server' && span.is_segment && span.attributes['url.path']?.value === path;
}

function isRedisCommand(span: SerializedStreamedSpan): boolean {
 return getSpanOp(span) === 'db.query';
}

// `db.query.text` carries the key, so with span streaming a redis command span is named
// `{db.operation.name} {server.address}:{server.port}` instead.
function expectedCommandName(span: SerializedStreamedSpan): string {
 const { 'db.operation.name': operation, 'server.address': address, 'server.port': port } = span.attributes;
 return `${operation?.value} ${address?.value}:${port?.value}`;
}

test('ioredis GET emits an http.server segment containing a db.query child span', async ({ baseURL }) => {
 // Each incoming request gets a Sentry http.server segment span (via the
 // default denoServeIntegration); the ioredis command runs inside it, so the
 // child span attaches to that transaction.
 const transactionPromise = waitForTransaction('deno-redis', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/ioredis-get') &&
 (event.spans?.some(span => span.op === 'db.query') ?? false)
 );
 });
 // child span joins that trace.
 const spansPromise = collectStreamedSpans(
 'deno-redis',
 spans => spans.some(isSegmentFor('/ioredis-get')) && spans.some(isRedisCommand),
 );

 const res = await fetch(`${baseURL}/ioredis-get?key=iocache:user:42`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const redisSpan = transaction.spans!.find(span => span.op === 'db.query');
 const spans = await spansPromise;
 const segment = spans.find(isSegmentFor('/ioredis-get'))!;
 const redisSpan = spans.find(isRedisCommand);
 expect(redisSpan).toBeDefined();
 // ioredis publishes lowercase command names; node-redis publishes uppercase.
 expect(redisSpan!.description).toBe('redis-get');
 expect(redisSpan!.data?.['db.system.name']).toBe('redis');
 expect(redisSpan!.data?.['db.query.text']).toBe('get iocache:user:42');
 expect(redisSpan!.parent_span_id).toBe(segment.span_id);
 expect(redisSpan!.name).toBe(expectedCommandName(redisSpan!));
 expect(redisSpan!.attributes).toMatchObject({
 'db.system.name': { value: 'redis', type: 'string' },
 // ioredis publishes lowercase command names; node-redis publishes uppercase.
 'db.operation.name': { value: 'get', type: 'string' },
 'db.query.text': { value: 'get iocache:user:42', type: 'string' },
 });
});

test('ioredis SET then GET emit two db.query child spans on the same transaction', async ({ baseURL }) => {
 const transactionPromise = waitForTransaction('deno-redis', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/ioredis-set-get') &&
 (event.spans?.filter(span => span.op === 'db.query').length ?? 0) >= 2
 );
 });
test('ioredis SET then GET emit two db.query child spans on the same trace', async ({ baseURL }) => {
 const spansPromise = collectStreamedSpans(
 'deno-redis',
 spans => spans.some(isSegmentFor('/ioredis-set-get')) && spans.filter(isRedisCommand).length >= 2,
 );

 const res = await fetch(`${baseURL}/ioredis-set-get?key=iocache:greeting&value=hello`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const redisSpans = transaction.spans!.filter(span => span.op === 'db.query');
 const spans = await spansPromise;
 const segment = spans.find(isSegmentFor('/ioredis-set-get'))!;
 const redisSpans = spans.filter(isRedisCommand);
 expect(redisSpans.length).toBeGreaterThanOrEqual(2);
 const ops = redisSpans.map(s => s.description);
 expect(ops).toContain('redis-set');
 expect(ops).toContain('redis-get');
 expect(redisSpans.every(span => span.parent_span_id === segment.span_id)).toBe(true);
 const ops = redisSpans.map(span => span.attributes['db.operation.name']?.value);
 expect(ops).toContain('set');
 expect(ops).toContain('get');
});

test('ioredis MULTI emits one db.query span per command (no batch channel)', async ({ baseURL }) => {
 // ioredis does not publish to a batch channel — each command in the
 // transaction publishes individually with batchMode/batchSize set on its
 // own payload. So the transaction should contain multiple `redis-<cmd>`
 // child spans, but no PIPELINE/MULTI batch span.
 const transactionPromise = waitForTransaction('deno-redis', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/ioredis-multi') &&
 (event.spans?.filter(span => span.op === 'db.query').length ?? 0) >= 3
 );
 });
 // own payload. So the trace should contain multiple command child spans,
 // but no PIPELINE/MULTI batch span.
 const spansPromise = collectStreamedSpans(
 'deno-redis',
 spans => spans.some(isSegmentFor('/ioredis-multi')) && spans.filter(isRedisCommand).length >= 3,
 );

 const res = await fetch(`${baseURL}/ioredis-multi`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const redisSpans = transaction.spans!.filter(span => span.op === 'db.query');
 const spans = await spansPromise;
 const redisSpans = spans.filter(isRedisCommand);
 expect(redisSpans.length).toBeGreaterThanOrEqual(3);
 const descriptions = redisSpans.map(s => s.description);
 expect(descriptions).toContain('redis-set');
 expect(descriptions).toContain('redis-get');
 const ops = redisSpans.map(span => span.attributes['db.operation.name']?.value);
 expect(ops).toContain('set');
 expect(ops).toContain('get');
 // No PIPELINE/MULTI batch wrapper span — ioredis has no separate batch channel.
 const batchSpan = transaction.spans!.find(span => span.description === 'MULTI' || span.description === 'PIPELINE');
 const batchSpan = spans.find(span => span.name === 'MULTI' || span.name === 'PIPELINE');
 expect(batchSpan).toBeUndefined();
});

test('ioredis PIPELINE emits one db.query span per command', async ({ baseURL }) => {
 const transactionPromise = waitForTransaction('deno-redis', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/ioredis-pipeline') &&
 (event.spans?.filter(span => span.op === 'db.query').length ?? 0) >= 3
 );
 });
 const spansPromise = collectStreamedSpans(
 'deno-redis',
 spans => spans.some(isSegmentFor('/ioredis-pipeline')) && spans.filter(isRedisCommand).length >= 3,
 );

 const res = await fetch(`${baseURL}/ioredis-pipeline`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const redisSpans = transaction.spans!.filter(span => span.op === 'db.query');
 const spans = await spansPromise;
 const redisSpans = spans.filter(isRedisCommand);
 expect(redisSpans.length).toBeGreaterThanOrEqual(3);
});
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test(e2e): Port Deno db E2E test apps to span streaming#24003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Open

msonnb
wants to merge
1
commit into

base:develop
Choose a base branch

from

 Open


test(e2e): Port Deno db E2E test apps to span streaming
#24003
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
dev-packages/e2e-tests/test-applications/deno-mysql/src/app.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,6 @@ import '@sentry/deno/import';
import * as Sentry from '@sentry/deno';

Sentry.init({
 traceLifecycle: 'static',
 environment: 'qa',
 dsn: Deno.env.get('E2E_TEST_DSN'),
 debug: !!Deno.env.get('DEBUG'),
Expand Down

75 changes: 42 additions & 33 deletions
dev-packages/e2e-tests/test-applications/deno-mysql/tests/mysql.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,54 +1,63 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { collectStreamedSpans, getSpanOp } from '@sentry-internal/test-utils';
import type { SerializedStreamedSpan } from '@sentry/core';

// `Deno.serve` has no route information, so with span streaming the http.server segment is
// named after the method only; the path lives in `url.path`.
function isTestMysqlSegment(span: SerializedStreamedSpan): boolean {
 return getSpanOp(span) === 'http.server' && span.is_segment && span.attributes['url.path']?.value === '/test-mysql';
}

test('mysql queries emit a db span with orchestrion-channel attributes', async ({ baseURL }) => {
 // Each incoming request gets a Sentry http.server transaction (via the
 // Each incoming request gets a Sentry http.server segment span (via the
 // default denoServeIntegration); the mysql queries run inside it, so their
 // db spans attach to that transaction.
 const transactionPromise = waitForTransaction('deno-mysql', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/test-mysql') &&
 (event.spans?.some(span => span.op === 'db') ?? false)
 );
 });
 // db spans join that trace.
 const spansPromise = collectStreamedSpans(
 'deno-mysql',
 spans => spans.some(isTestMysqlSegment) && spans.some(span => getSpanOp(span) === 'db'),
 );

 const res = await fetch(`${baseURL}/test-mysql`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const dbSpans = transaction.spans!.filter(span => span.op === 'db');
 const spans = await spansPromise;
 const dbSpans = spans.filter(span => getSpanOp(span) === 'db');

 const firstQuery = dbSpans.find(span => span.description === 'SELECT 1 + 1 AS solution');
 const firstQuery = dbSpans.find(span => span.attributes['db.query.text']?.value === 'SELECT 1 + 1 AS solution');
 expect(firstQuery).toBeDefined();
 expect(firstQuery!.data?.['sentry.origin']).toBe('auto.db.mysql');
 expect(firstQuery!.data?.['db.system.name']).toBe('mysql');
 expect(firstQuery!.data?.['db.query.text']).toBe('SELECT 1 + 1 AS solution');
 expect(firstQuery!.data?.['server.port']).toBe(3306);
 expect(firstQuery!.data?.['db.user']).toBe('root');
 // With span streaming, db span names are the low-cardinality query summary, not the raw SQL
 expect(firstQuery!.name).toBe('SELECT');
 expect(firstQuery!.attributes).toMatchObject({
 'sentry.origin': { value: 'auto.db.mysql', type: 'string' },
 'db.system.name': { value: 'mysql', type: 'string' },
 'db.query.text': { value: 'SELECT 1 + 1 AS solution', type: 'string' },
 'server.port': { value: 3306, type: 'integer' },
 'db.user': { value: 'root', type: 'string' },
 });
});

test('a nested query lands on the same transaction (AsyncLocalStorage context restored)', async ({ baseURL }) => {
test('a nested query lands on the same trace (AsyncLocalStorage context restored)', async ({ baseURL }) => {
 // The second query runs inside the first query's callback — i.e. across
 // mysql's async socket-callback dispatch. Both spans appearing on the SAME
 // http.server transaction proves denoMysqlIntegration's context strategy
 // mysql's async socket-callback dispatch. Both db spans being children of the
 // SAME http.server segment proves denoMysqlIntegration's context strategy
 // restored the parent span across that async boundary (otherwise the nested
 // query would start its own trace and never join this transaction).
 const transactionPromise = waitForTransaction('deno-mysql', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/test-mysql') &&
 (event.spans?.filter(span => span.op === 'db').length ?? 0) >= 2
 );
 });
 // query would start its own trace and never join this one).
 const spansPromise = collectStreamedSpans(
 'deno-mysql',
 spans => spans.some(isTestMysqlSegment) && spans.filter(span => getSpanOp(span) === 'db').length >= 2,
 );

 const res = await fetch(`${baseURL}/test-mysql`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const descriptions = transaction.spans!.filter(span => span.op === 'db').map(span => span.description);
 expect(descriptions).toContain('SELECT 1 + 1 AS solution');
 expect(descriptions).toContain('SELECT NOW()');
 const spans = await spansPromise;
 const segment = spans.find(isTestMysqlSegment)!;
 const dbSpans = spans.filter(span => getSpanOp(span) === 'db');

 const queries = dbSpans.map(span => span.attributes['db.query.text']?.value);
 expect(queries).toContain('SELECT 1 + 1 AS solution');
 expect(queries).toContain('SELECT NOW()');
 expect(dbSpans.every(span => span.parent_span_id === segment.span_id)).toBe(true);
});

1 change: 0 additions & 1 deletion
dev-packages/e2e-tests/test-applications/deno-pg/src/app.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,6 @@ import '@sentry/deno/import';
import * as Sentry from '@sentry/deno';

Sentry.init({
 traceLifecycle: 'static',
 environment: 'qa',
 dsn: Deno.env.get('E2E_TEST_DSN'),
 debug: !!Deno.env.get('DEBUG'),
Expand Down

75 changes: 42 additions & 33 deletions
dev-packages/e2e-tests/test-applications/deno-pg/tests/pg.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,55 +1,64 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { collectStreamedSpans, getSpanOp } from '@sentry-internal/test-utils';
import type { SerializedStreamedSpan } from '@sentry/core';

// `Deno.serve` has no route information, so with span streaming the http.server segment is
// named after the method only; the path lives in `url.path`.
function isTestPgSegment(span: SerializedStreamedSpan): boolean {
 return getSpanOp(span) === 'http.server' && span.is_segment && span.attributes['url.path']?.value === '/test-pg';
}

test('pg queries emit a db span with orchestrion-channel attributes', async ({ baseURL }) => {
 // Each incoming request gets a Sentry http.server transaction (via the
 // Each incoming request gets a Sentry http.server segment span (via the
 // default denoServeIntegration); the pg queries run inside it, so their
 // db spans attach to that transaction.
 const transactionPromise = waitForTransaction('deno-pg', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/test-pg') &&
 (event.spans?.some(span => span.op === 'db') ?? false)
 );
 });
 // db spans join that trace.
 const spansPromise = collectStreamedSpans(
 'deno-pg',
 spans => spans.some(isTestPgSegment) && spans.some(span => getSpanOp(span) === 'db'),
 );

 const res = await fetch(`${baseURL}/test-pg`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const dbSpans = transaction.spans!.filter(span => span.op === 'db');
 const spans = await spansPromise;
 const dbSpans = spans.filter(span => getSpanOp(span) === 'db');

 const firstQuery = dbSpans.find(span => span.description === 'SELECT 1 + 1 AS solution');
 const firstQuery = dbSpans.find(span => span.attributes['db.query.text']?.value === 'SELECT 1 + 1 AS solution');
 expect(firstQuery).toBeDefined();
 expect(firstQuery!.data?.['sentry.origin']).toBe('auto.db.postgres');
 expect(firstQuery!.data?.['db.system.name']).toBe('postgresql');
 expect(firstQuery!.data?.['db.query.text']).toBe('SELECT 1 + 1 AS solution');
 expect(firstQuery!.data?.['server.port']).toBe(5432);
 expect(firstQuery!.data?.['db.user']).toBe('postgres');
 // With span streaming, db span names are the low-cardinality query summary, not the raw SQL
 expect(firstQuery!.name).toBe('SELECT');
 expect(firstQuery!.attributes).toMatchObject({
 'sentry.origin': { value: 'auto.db.postgres', type: 'string' },
 'db.system.name': { value: 'postgresql', type: 'string' },
 'db.query.text': { value: 'SELECT 1 + 1 AS solution', type: 'string' },
 'server.port': { value: 5432, type: 'integer' },
 'db.user': { value: 'postgres', type: 'string' },
 });
});

test('a nested query lands on the same transaction (AsyncLocalStorage context restored)', async ({ baseURL }) => {
test('a nested query lands on the same trace (AsyncLocalStorage context restored)', async ({ baseURL }) => {
 // The second query runs inside the first query's callback
 // i.e. across pg's async socket-callback dispatch. Both spans appearing
 // on the SAME http.server transaction proves denoPostgresIntegration's
 // i.e. across pg's async socket-callback dispatch. Both db spans being
 // children of the SAME http.server segment proves denoPostgresIntegration's
 // context strategy restored the parent span across that async boundary
 // (otherwise the nested query would start its own trace and never join
 // this transaction).
 const transactionPromise = waitForTransaction('deno-pg', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/test-pg') &&
 (event.spans?.filter(span => span.op === 'db').length ?? 0) >= 2
 );
 });
 // this one).
 const spansPromise = collectStreamedSpans(
 'deno-pg',
 spans => spans.some(isTestPgSegment) && spans.filter(span => getSpanOp(span) === 'db').length >= 2,
 );

 const res = await fetch(`${baseURL}/test-pg`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const descriptions = transaction.spans!.filter(span => span.op === 'db').map(span => span.description);
 expect(descriptions).toContain('SELECT 1 + 1 AS solution');
 expect(descriptions).toContain('SELECT NOW()');
 const spans = await spansPromise;
 const segment = spans.find(isTestPgSegment)!;
 const dbSpans = spans.filter(span => getSpanOp(span) === 'db');

 const queries = dbSpans.map(span => span.attributes['db.query.text']?.value);
 expect(queries).toContain('SELECT 1 + 1 AS solution');
 expect(queries).toContain('SELECT NOW()');
 expect(dbSpans.every(span => span.parent_span_id === segment.span_id)).toBe(true);
});

1 change: 0 additions & 1 deletion
dev-packages/e2e-tests/test-applications/deno-redis/src/app.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@ import IORedis from 'ioredis';
import { createClient } from 'redis';

Sentry.init({
 traceLifecycle: 'static',
 environment: 'qa',
 dsn: Deno.env.get('E2E_TEST_DSN'),
 debug: !!Deno.env.get('DEBUG'),
Expand Down

121 changes: 67 additions & 54 deletions
dev-packages/e2e-tests/test-applications/deno-redis/tests/ioredis.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,94 +1,107 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { collectStreamedSpans, getSpanOp } from '@sentry-internal/test-utils';
import type { SerializedStreamedSpan } from '@sentry/core';

test('ioredis GET emits an http.server transaction containing a db.query child span', async ({ baseURL }) => {
 // Each incoming request gets a Sentry http.server transaction (via the
// `Deno.serve` has no route information, so with span streaming the http.server segment is
// named after the method only; the path lives in `url.path`.
function isSegmentFor(path: string): (span: SerializedStreamedSpan) => boolean {
 return span => getSpanOp(span) === 'http.server' && span.is_segment && span.attributes['url.path']?.value === path;
}

function isRedisCommand(span: SerializedStreamedSpan): boolean {
 return getSpanOp(span) === 'db.query';
}

// `db.query.text` carries the key, so with span streaming a redis command span is named
// `{db.operation.name} {server.address}:{server.port}` instead.
function expectedCommandName(span: SerializedStreamedSpan): string {
 const { 'db.operation.name': operation, 'server.address': address, 'server.port': port } = span.attributes;
 return `${operation?.value} ${address?.value}:${port?.value}`;
}

test('ioredis GET emits an http.server segment containing a db.query child span', async ({ baseURL }) => {
 // Each incoming request gets a Sentry http.server segment span (via the
 // default denoServeIntegration); the ioredis command runs inside it, so the
 // child span attaches to that transaction.
 const transactionPromise = waitForTransaction('deno-redis', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/ioredis-get') &&
 (event.spans?.some(span => span.op === 'db.query') ?? false)
 );
 });
 // child span joins that trace.
 const spansPromise = collectStreamedSpans(
 'deno-redis',
 spans => spans.some(isSegmentFor('/ioredis-get')) && spans.some(isRedisCommand),
 );

 const res = await fetch(`${baseURL}/ioredis-get?key=iocache:user:42`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const redisSpan = transaction.spans!.find(span => span.op === 'db.query');
 const spans = await spansPromise;
 const segment = spans.find(isSegmentFor('/ioredis-get'))!;
 const redisSpan = spans.find(isRedisCommand);
 expect(redisSpan).toBeDefined();
 // ioredis publishes lowercase command names; node-redis publishes uppercase.
 expect(redisSpan!.description).toBe('redis-get');
 expect(redisSpan!.data?.['db.system.name']).toBe('redis');
 expect(redisSpan!.data?.['db.query.text']).toBe('get iocache:user:42');
 expect(redisSpan!.parent_span_id).toBe(segment.span_id);
 expect(redisSpan!.name).toBe(expectedCommandName(redisSpan!));
 expect(redisSpan!.attributes).toMatchObject({
 'db.system.name': { value: 'redis', type: 'string' },
 // ioredis publishes lowercase command names; node-redis publishes uppercase.
 'db.operation.name': { value: 'get', type: 'string' },
 'db.query.text': { value: 'get iocache:user:42', type: 'string' },
 });
});

test('ioredis SET then GET emit two db.query child spans on the same transaction', async ({ baseURL }) => {
 const transactionPromise = waitForTransaction('deno-redis', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/ioredis-set-get') &&
 (event.spans?.filter(span => span.op === 'db.query').length ?? 0) >= 2
 );
 });
test('ioredis SET then GET emit two db.query child spans on the same trace', async ({ baseURL }) => {
 const spansPromise = collectStreamedSpans(
 'deno-redis',
 spans => spans.some(isSegmentFor('/ioredis-set-get')) && spans.filter(isRedisCommand).length >= 2,
 );

 const res = await fetch(`${baseURL}/ioredis-set-get?key=iocache:greeting&value=hello`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const redisSpans = transaction.spans!.filter(span => span.op === 'db.query');
 const spans = await spansPromise;
 const segment = spans.find(isSegmentFor('/ioredis-set-get'))!;
 const redisSpans = spans.filter(isRedisCommand);
 expect(redisSpans.length).toBeGreaterThanOrEqual(2);
 const ops = redisSpans.map(s => s.description);
 expect(ops).toContain('redis-set');
 expect(ops).toContain('redis-get');
 expect(redisSpans.every(span => span.parent_span_id === segment.span_id)).toBe(true);
 const ops = redisSpans.map(span => span.attributes['db.operation.name']?.value);
 expect(ops).toContain('set');
 expect(ops).toContain('get');
});

test('ioredis MULTI emits one db.query span per command (no batch channel)', async ({ baseURL }) => {
 // ioredis does not publish to a batch channel — each command in the
 // transaction publishes individually with batchMode/batchSize set on its
 // own payload. So the transaction should contain multiple `redis-<cmd>`
 // child spans, but no PIPELINE/MULTI batch span.
 const transactionPromise = waitForTransaction('deno-redis', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/ioredis-multi') &&
 (event.spans?.filter(span => span.op === 'db.query').length ?? 0) >= 3
 );
 });
 // own payload. So the trace should contain multiple command child spans,
 // but no PIPELINE/MULTI batch span.
 const spansPromise = collectStreamedSpans(
 'deno-redis',
 spans => spans.some(isSegmentFor('/ioredis-multi')) && spans.filter(isRedisCommand).length >= 3,
 );

 const res = await fetch(`${baseURL}/ioredis-multi`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const redisSpans = transaction.spans!.filter(span => span.op === 'db.query');
 const spans = await spansPromise;
 const redisSpans = spans.filter(isRedisCommand);
 expect(redisSpans.length).toBeGreaterThanOrEqual(3);
 const descriptions = redisSpans.map(s => s.description);
 expect(descriptions).toContain('redis-set');
 expect(descriptions).toContain('redis-get');
 const ops = redisSpans.map(span => span.attributes['db.operation.name']?.value);
 expect(ops).toContain('set');
 expect(ops).toContain('get');
 // No PIPELINE/MULTI batch wrapper span — ioredis has no separate batch channel.
 const batchSpan = transaction.spans!.find(span => span.description === 'MULTI' || span.description === 'PIPELINE');
 const batchSpan = spans.find(span => span.name === 'MULTI' || span.name === 'PIPELINE');
 expect(batchSpan).toBeUndefined();
});

test('ioredis PIPELINE emits one db.query span per command', async ({ baseURL }) => {
 const transactionPromise = waitForTransaction('deno-redis', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/ioredis-pipeline') &&
 (event.spans?.filter(span => span.op === 'db.query').length ?? 0) >= 3
 );
 });
 const spansPromise = collectStreamedSpans(
 'deno-redis',
 spans => spans.some(isSegmentFor('/ioredis-pipeline')) && spans.filter(isRedisCommand).length >= 3,
 );

 const res = await fetch(`${baseURL}/ioredis-pipeline`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const redisSpans = transaction.spans!.filter(span => span.op === 'db.query');
 const spans = await spansPromise;
 const redisSpans = spans.filter(isRedisCommand);
 expect(redisSpans.length).toBeGreaterThanOrEqual(3);
});
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test(e2e): Port Deno db E2E test apps to span streaming#24003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Open

msonnb
wants to merge
1
commit into

base:develop
Choose a base branch

from

 Open


test(e2e): Port Deno db E2E test apps to span streaming
#24003
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
dev-packages/e2e-tests/test-applications/deno-mysql/src/app.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,6 @@ import '@sentry/deno/import';
import * as Sentry from '@sentry/deno';

Sentry.init({
 traceLifecycle: 'static',
 environment: 'qa',
 dsn: Deno.env.get('E2E_TEST_DSN'),
 debug: !!Deno.env.get('DEBUG'),
Expand Down

75 changes: 42 additions & 33 deletions
dev-packages/e2e-tests/test-applications/deno-mysql/tests/mysql.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,54 +1,63 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { collectStreamedSpans, getSpanOp } from '@sentry-internal/test-utils';
import type { SerializedStreamedSpan } from '@sentry/core';

// `Deno.serve` has no route information, so with span streaming the http.server segment is
// named after the method only; the path lives in `url.path`.
function isTestMysqlSegment(span: SerializedStreamedSpan): boolean {
 return getSpanOp(span) === 'http.server' && span.is_segment && span.attributes['url.path']?.value === '/test-mysql';
}

test('mysql queries emit a db span with orchestrion-channel attributes', async ({ baseURL }) => {
 // Each incoming request gets a Sentry http.server transaction (via the
 // Each incoming request gets a Sentry http.server segment span (via the
 // default denoServeIntegration); the mysql queries run inside it, so their
 // db spans attach to that transaction.
 const transactionPromise = waitForTransaction('deno-mysql', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/test-mysql') &&
 (event.spans?.some(span => span.op === 'db') ?? false)
 );
 });
 // db spans join that trace.
 const spansPromise = collectStreamedSpans(
 'deno-mysql',
 spans => spans.some(isTestMysqlSegment) && spans.some(span => getSpanOp(span) === 'db'),
 );

 const res = await fetch(`${baseURL}/test-mysql`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const dbSpans = transaction.spans!.filter(span => span.op === 'db');
 const spans = await spansPromise;
 const dbSpans = spans.filter(span => getSpanOp(span) === 'db');

 const firstQuery = dbSpans.find(span => span.description === 'SELECT 1 + 1 AS solution');
 const firstQuery = dbSpans.find(span => span.attributes['db.query.text']?.value === 'SELECT 1 + 1 AS solution');
 expect(firstQuery).toBeDefined();
 expect(firstQuery!.data?.['sentry.origin']).toBe('auto.db.mysql');
 expect(firstQuery!.data?.['db.system.name']).toBe('mysql');
 expect(firstQuery!.data?.['db.query.text']).toBe('SELECT 1 + 1 AS solution');
 expect(firstQuery!.data?.['server.port']).toBe(3306);
 expect(firstQuery!.data?.['db.user']).toBe('root');
 // With span streaming, db span names are the low-cardinality query summary, not the raw SQL
 expect(firstQuery!.name).toBe('SELECT');
 expect(firstQuery!.attributes).toMatchObject({
 'sentry.origin': { value: 'auto.db.mysql', type: 'string' },
 'db.system.name': { value: 'mysql', type: 'string' },
 'db.query.text': { value: 'SELECT 1 + 1 AS solution', type: 'string' },
 'server.port': { value: 3306, type: 'integer' },
 'db.user': { value: 'root', type: 'string' },
 });
});

test('a nested query lands on the same transaction (AsyncLocalStorage context restored)', async ({ baseURL }) => {
test('a nested query lands on the same trace (AsyncLocalStorage context restored)', async ({ baseURL }) => {
 // The second query runs inside the first query's callback — i.e. across
 // mysql's async socket-callback dispatch. Both spans appearing on the SAME
 // http.server transaction proves denoMysqlIntegration's context strategy
 // mysql's async socket-callback dispatch. Both db spans being children of the
 // SAME http.server segment proves denoMysqlIntegration's context strategy
 // restored the parent span across that async boundary (otherwise the nested
 // query would start its own trace and never join this transaction).
 const transactionPromise = waitForTransaction('deno-mysql', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/test-mysql') &&
 (event.spans?.filter(span => span.op === 'db').length ?? 0) >= 2
 );
 });
 // query would start its own trace and never join this one).
 const spansPromise = collectStreamedSpans(
 'deno-mysql',
 spans => spans.some(isTestMysqlSegment) && spans.filter(span => getSpanOp(span) === 'db').length >= 2,
 );

 const res = await fetch(`${baseURL}/test-mysql`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const descriptions = transaction.spans!.filter(span => span.op === 'db').map(span => span.description);
 expect(descriptions).toContain('SELECT 1 + 1 AS solution');
 expect(descriptions).toContain('SELECT NOW()');
 const spans = await spansPromise;
 const segment = spans.find(isTestMysqlSegment)!;
 const dbSpans = spans.filter(span => getSpanOp(span) === 'db');

 const queries = dbSpans.map(span => span.attributes['db.query.text']?.value);
 expect(queries).toContain('SELECT 1 + 1 AS solution');
 expect(queries).toContain('SELECT NOW()');
 expect(dbSpans.every(span => span.parent_span_id === segment.span_id)).toBe(true);
});

1 change: 0 additions & 1 deletion
dev-packages/e2e-tests/test-applications/deno-pg/src/app.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,6 @@ import '@sentry/deno/import';
import * as Sentry from '@sentry/deno';

Sentry.init({
 traceLifecycle: 'static',
 environment: 'qa',
 dsn: Deno.env.get('E2E_TEST_DSN'),
 debug: !!Deno.env.get('DEBUG'),
Expand Down

75 changes: 42 additions & 33 deletions
dev-packages/e2e-tests/test-applications/deno-pg/tests/pg.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,55 +1,64 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { collectStreamedSpans, getSpanOp } from '@sentry-internal/test-utils';
import type { SerializedStreamedSpan } from '@sentry/core';

// `Deno.serve` has no route information, so with span streaming the http.server segment is
// named after the method only; the path lives in `url.path`.
function isTestPgSegment(span: SerializedStreamedSpan): boolean {
 return getSpanOp(span) === 'http.server' && span.is_segment && span.attributes['url.path']?.value === '/test-pg';
}

test('pg queries emit a db span with orchestrion-channel attributes', async ({ baseURL }) => {
 // Each incoming request gets a Sentry http.server transaction (via the
 // Each incoming request gets a Sentry http.server segment span (via the
 // default denoServeIntegration); the pg queries run inside it, so their
 // db spans attach to that transaction.
 const transactionPromise = waitForTransaction('deno-pg', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/test-pg') &&
 (event.spans?.some(span => span.op === 'db') ?? false)
 );
 });
 // db spans join that trace.
 const spansPromise = collectStreamedSpans(
 'deno-pg',
 spans => spans.some(isTestPgSegment) && spans.some(span => getSpanOp(span) === 'db'),
 );

 const res = await fetch(`${baseURL}/test-pg`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const dbSpans = transaction.spans!.filter(span => span.op === 'db');
 const spans = await spansPromise;
 const dbSpans = spans.filter(span => getSpanOp(span) === 'db');

 const firstQuery = dbSpans.find(span => span.description === 'SELECT 1 + 1 AS solution');
 const firstQuery = dbSpans.find(span => span.attributes['db.query.text']?.value === 'SELECT 1 + 1 AS solution');
 expect(firstQuery).toBeDefined();
 expect(firstQuery!.data?.['sentry.origin']).toBe('auto.db.postgres');
 expect(firstQuery!.data?.['db.system.name']).toBe('postgresql');
 expect(firstQuery!.data?.['db.query.text']).toBe('SELECT 1 + 1 AS solution');
 expect(firstQuery!.data?.['server.port']).toBe(5432);
 expect(firstQuery!.data?.['db.user']).toBe('postgres');
 // With span streaming, db span names are the low-cardinality query summary, not the raw SQL
 expect(firstQuery!.name).toBe('SELECT');
 expect(firstQuery!.attributes).toMatchObject({
 'sentry.origin': { value: 'auto.db.postgres', type: 'string' },
 'db.system.name': { value: 'postgresql', type: 'string' },
 'db.query.text': { value: 'SELECT 1 + 1 AS solution', type: 'string' },
 'server.port': { value: 5432, type: 'integer' },
 'db.user': { value: 'postgres', type: 'string' },
 });
});

test('a nested query lands on the same transaction (AsyncLocalStorage context restored)', async ({ baseURL }) => {
test('a nested query lands on the same trace (AsyncLocalStorage context restored)', async ({ baseURL }) => {
 // The second query runs inside the first query's callback
 // i.e. across pg's async socket-callback dispatch. Both spans appearing
 // on the SAME http.server transaction proves denoPostgresIntegration's
 // i.e. across pg's async socket-callback dispatch. Both db spans being
 // children of the SAME http.server segment proves denoPostgresIntegration's
 // context strategy restored the parent span across that async boundary
 // (otherwise the nested query would start its own trace and never join
 // this transaction).
 const transactionPromise = waitForTransaction('deno-pg', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/test-pg') &&
 (event.spans?.filter(span => span.op === 'db').length ?? 0) >= 2
 );
 });
 // this one).
 const spansPromise = collectStreamedSpans(
 'deno-pg',
 spans => spans.some(isTestPgSegment) && spans.filter(span => getSpanOp(span) === 'db').length >= 2,
 );

 const res = await fetch(`${baseURL}/test-pg`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const descriptions = transaction.spans!.filter(span => span.op === 'db').map(span => span.description);
 expect(descriptions).toContain('SELECT 1 + 1 AS solution');
 expect(descriptions).toContain('SELECT NOW()');
 const spans = await spansPromise;
 const segment = spans.find(isTestPgSegment)!;
 const dbSpans = spans.filter(span => getSpanOp(span) === 'db');

 const queries = dbSpans.map(span => span.attributes['db.query.text']?.value);
 expect(queries).toContain('SELECT 1 + 1 AS solution');
 expect(queries).toContain('SELECT NOW()');
 expect(dbSpans.every(span => span.parent_span_id === segment.span_id)).toBe(true);
});

1 change: 0 additions & 1 deletion
dev-packages/e2e-tests/test-applications/deno-redis/src/app.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@ import IORedis from 'ioredis';
import { createClient } from 'redis';

Sentry.init({
 traceLifecycle: 'static',
 environment: 'qa',
 dsn: Deno.env.get('E2E_TEST_DSN'),
 debug: !!Deno.env.get('DEBUG'),
Expand Down

121 changes: 67 additions & 54 deletions
dev-packages/e2e-tests/test-applications/deno-redis/tests/ioredis.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,94 +1,107 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { collectStreamedSpans, getSpanOp } from '@sentry-internal/test-utils';
import type { SerializedStreamedSpan } from '@sentry/core';

test('ioredis GET emits an http.server transaction containing a db.query child span', async ({ baseURL }) => {
 // Each incoming request gets a Sentry http.server transaction (via the
// `Deno.serve` has no route information, so with span streaming the http.server segment is
// named after the method only; the path lives in `url.path`.
function isSegmentFor(path: string): (span: SerializedStreamedSpan) => boolean {
 return span => getSpanOp(span) === 'http.server' && span.is_segment && span.attributes['url.path']?.value === path;
}

function isRedisCommand(span: SerializedStreamedSpan): boolean {
 return getSpanOp(span) === 'db.query';
}

// `db.query.text` carries the key, so with span streaming a redis command span is named
// `{db.operation.name} {server.address}:{server.port}` instead.
function expectedCommandName(span: SerializedStreamedSpan): string {
 const { 'db.operation.name': operation, 'server.address': address, 'server.port': port } = span.attributes;
 return `${operation?.value} ${address?.value}:${port?.value}`;
}

test('ioredis GET emits an http.server segment containing a db.query child span', async ({ baseURL }) => {
 // Each incoming request gets a Sentry http.server segment span (via the
 // default denoServeIntegration); the ioredis command runs inside it, so the
 // child span attaches to that transaction.
 const transactionPromise = waitForTransaction('deno-redis', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/ioredis-get') &&
 (event.spans?.some(span => span.op === 'db.query') ?? false)
 );
 });
 // child span joins that trace.
 const spansPromise = collectStreamedSpans(
 'deno-redis',
 spans => spans.some(isSegmentFor('/ioredis-get')) && spans.some(isRedisCommand),
 );

 const res = await fetch(`${baseURL}/ioredis-get?key=iocache:user:42`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const redisSpan = transaction.spans!.find(span => span.op === 'db.query');
 const spans = await spansPromise;
 const segment = spans.find(isSegmentFor('/ioredis-get'))!;
 const redisSpan = spans.find(isRedisCommand);
 expect(redisSpan).toBeDefined();
 // ioredis publishes lowercase command names; node-redis publishes uppercase.
 expect(redisSpan!.description).toBe('redis-get');
 expect(redisSpan!.data?.['db.system.name']).toBe('redis');
 expect(redisSpan!.data?.['db.query.text']).toBe('get iocache:user:42');
 expect(redisSpan!.parent_span_id).toBe(segment.span_id);
 expect(redisSpan!.name).toBe(expectedCommandName(redisSpan!));
 expect(redisSpan!.attributes).toMatchObject({
 'db.system.name': { value: 'redis', type: 'string' },
 // ioredis publishes lowercase command names; node-redis publishes uppercase.
 'db.operation.name': { value: 'get', type: 'string' },
 'db.query.text': { value: 'get iocache:user:42', type: 'string' },
 });
});

test('ioredis SET then GET emit two db.query child spans on the same transaction', async ({ baseURL }) => {
 const transactionPromise = waitForTransaction('deno-redis', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/ioredis-set-get') &&
 (event.spans?.filter(span => span.op === 'db.query').length ?? 0) >= 2
 );
 });
test('ioredis SET then GET emit two db.query child spans on the same trace', async ({ baseURL }) => {
 const spansPromise = collectStreamedSpans(
 'deno-redis',
 spans => spans.some(isSegmentFor('/ioredis-set-get')) && spans.filter(isRedisCommand).length >= 2,
 );

 const res = await fetch(`${baseURL}/ioredis-set-get?key=iocache:greeting&value=hello`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const redisSpans = transaction.spans!.filter(span => span.op === 'db.query');
 const spans = await spansPromise;
 const segment = spans.find(isSegmentFor('/ioredis-set-get'))!;
 const redisSpans = spans.filter(isRedisCommand);
 expect(redisSpans.length).toBeGreaterThanOrEqual(2);
 const ops = redisSpans.map(s => s.description);
 expect(ops).toContain('redis-set');
 expect(ops).toContain('redis-get');
 expect(redisSpans.every(span => span.parent_span_id === segment.span_id)).toBe(true);
 const ops = redisSpans.map(span => span.attributes['db.operation.name']?.value);
 expect(ops).toContain('set');
 expect(ops).toContain('get');
});

test('ioredis MULTI emits one db.query span per command (no batch channel)', async ({ baseURL }) => {
 // ioredis does not publish to a batch channel — each command in the
 // transaction publishes individually with batchMode/batchSize set on its
 // own payload. So the transaction should contain multiple `redis-<cmd>`
 // child spans, but no PIPELINE/MULTI batch span.
 const transactionPromise = waitForTransaction('deno-redis', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/ioredis-multi') &&
 (event.spans?.filter(span => span.op === 'db.query').length ?? 0) >= 3
 );
 });
 // own payload. So the trace should contain multiple command child spans,
 // but no PIPELINE/MULTI batch span.
 const spansPromise = collectStreamedSpans(
 'deno-redis',
 spans => spans.some(isSegmentFor('/ioredis-multi')) && spans.filter(isRedisCommand).length >= 3,
 );

 const res = await fetch(`${baseURL}/ioredis-multi`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const redisSpans = transaction.spans!.filter(span => span.op === 'db.query');
 const spans = await spansPromise;
 const redisSpans = spans.filter(isRedisCommand);
 expect(redisSpans.length).toBeGreaterThanOrEqual(3);
 const descriptions = redisSpans.map(s => s.description);
 expect(descriptions).toContain('redis-set');
 expect(descriptions).toContain('redis-get');
 const ops = redisSpans.map(span => span.attributes['db.operation.name']?.value);
 expect(ops).toContain('set');
 expect(ops).toContain('get');
 // No PIPELINE/MULTI batch wrapper span — ioredis has no separate batch channel.
 const batchSpan = transaction.spans!.find(span => span.description === 'MULTI' || span.description === 'PIPELINE');
 const batchSpan = spans.find(span => span.name === 'MULTI' || span.name === 'PIPELINE');
 expect(batchSpan).toBeUndefined();
});

test('ioredis PIPELINE emits one db.query span per command', async ({ baseURL }) => {
 const transactionPromise = waitForTransaction('deno-redis', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/ioredis-pipeline') &&
 (event.spans?.filter(span => span.op === 'db.query').length ?? 0) >= 3
 );
 });
 const spansPromise = collectStreamedSpans(
 'deno-redis',
 spans => spans.some(isSegmentFor('/ioredis-pipeline')) && spans.filter(isRedisCommand).length >= 3,
 );

 const res = await fetch(`${baseURL}/ioredis-pipeline`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const redisSpans = transaction.spans!.filter(span => span.op === 'db.query');
 const spans = await spansPromise;
 const redisSpans = spans.filter(isRedisCommand);
 expect(redisSpans.length).toBeGreaterThanOrEqual(3);
});
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
test(e2e): Port Deno db E2E test apps to span streaming#24003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Open

msonnb
wants to merge
1
commit into

base:develop
Choose a base branch

from

 Open


test(e2e): Port Deno db E2E test apps to span streaming
#24003
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
dev-packages/e2e-tests/test-applications/deno-mysql/src/app.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,6 @@ import '@sentry/deno/import';
import * as Sentry from '@sentry/deno';

Sentry.init({
 traceLifecycle: 'static',
 environment: 'qa',
 dsn: Deno.env.get('E2E_TEST_DSN'),
 debug: !!Deno.env.get('DEBUG'),
Expand Down

75 changes: 42 additions & 33 deletions
dev-packages/e2e-tests/test-applications/deno-mysql/tests/mysql.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,54 +1,63 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { collectStreamedSpans, getSpanOp } from '@sentry-internal/test-utils';
import type { SerializedStreamedSpan } from '@sentry/core';

// `Deno.serve` has no route information, so with span streaming the http.server segment is
// named after the method only; the path lives in `url.path`.
function isTestMysqlSegment(span: SerializedStreamedSpan): boolean {
 return getSpanOp(span) === 'http.server' && span.is_segment && span.attributes['url.path']?.value === '/test-mysql';
}

test('mysql queries emit a db span with orchestrion-channel attributes', async ({ baseURL }) => {
 // Each incoming request gets a Sentry http.server transaction (via the
 // Each incoming request gets a Sentry http.server segment span (via the
 // default denoServeIntegration); the mysql queries run inside it, so their
 // db spans attach to that transaction.
 const transactionPromise = waitForTransaction('deno-mysql', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/test-mysql') &&
 (event.spans?.some(span => span.op === 'db') ?? false)
 );
 });
 // db spans join that trace.
 const spansPromise = collectStreamedSpans(
 'deno-mysql',
 spans => spans.some(isTestMysqlSegment) && spans.some(span => getSpanOp(span) === 'db'),
 );

 const res = await fetch(`${baseURL}/test-mysql`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const dbSpans = transaction.spans!.filter(span => span.op === 'db');
 const spans = await spansPromise;
 const dbSpans = spans.filter(span => getSpanOp(span) === 'db');

 const firstQuery = dbSpans.find(span => span.description === 'SELECT 1 + 1 AS solution');
 const firstQuery = dbSpans.find(span => span.attributes['db.query.text']?.value === 'SELECT 1 + 1 AS solution');
 expect(firstQuery).toBeDefined();
 expect(firstQuery!.data?.['sentry.origin']).toBe('auto.db.mysql');
 expect(firstQuery!.data?.['db.system.name']).toBe('mysql');
 expect(firstQuery!.data?.['db.query.text']).toBe('SELECT 1 + 1 AS solution');
 expect(firstQuery!.data?.['server.port']).toBe(3306);
 expect(firstQuery!.data?.['db.user']).toBe('root');
 // With span streaming, db span names are the low-cardinality query summary, not the raw SQL
 expect(firstQuery!.name).toBe('SELECT');
 expect(firstQuery!.attributes).toMatchObject({
 'sentry.origin': { value: 'auto.db.mysql', type: 'string' },
 'db.system.name': { value: 'mysql', type: 'string' },
 'db.query.text': { value: 'SELECT 1 + 1 AS solution', type: 'string' },
 'server.port': { value: 3306, type: 'integer' },
 'db.user': { value: 'root', type: 'string' },
 });
});

test('a nested query lands on the same transaction (AsyncLocalStorage context restored)', async ({ baseURL }) => {
test('a nested query lands on the same trace (AsyncLocalStorage context restored)', async ({ baseURL }) => {
 // The second query runs inside the first query's callback — i.e. across
 // mysql's async socket-callback dispatch. Both spans appearing on the SAME
 // http.server transaction proves denoMysqlIntegration's context strategy
 // mysql's async socket-callback dispatch. Both db spans being children of the
 // SAME http.server segment proves denoMysqlIntegration's context strategy
 // restored the parent span across that async boundary (otherwise the nested
 // query would start its own trace and never join this transaction).
 const transactionPromise = waitForTransaction('deno-mysql', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/test-mysql') &&
 (event.spans?.filter(span => span.op === 'db').length ?? 0) >= 2
 );
 });
 // query would start its own trace and never join this one).
 const spansPromise = collectStreamedSpans(
 'deno-mysql',
 spans => spans.some(isTestMysqlSegment) && spans.filter(span => getSpanOp(span) === 'db').length >= 2,
 );

 const res = await fetch(`${baseURL}/test-mysql`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const descriptions = transaction.spans!.filter(span => span.op === 'db').map(span => span.description);
 expect(descriptions).toContain('SELECT 1 + 1 AS solution');
 expect(descriptions).toContain('SELECT NOW()');
 const spans = await spansPromise;
 const segment = spans.find(isTestMysqlSegment)!;
 const dbSpans = spans.filter(span => getSpanOp(span) === 'db');

 const queries = dbSpans.map(span => span.attributes['db.query.text']?.value);
 expect(queries).toContain('SELECT 1 + 1 AS solution');
 expect(queries).toContain('SELECT NOW()');
 expect(dbSpans.every(span => span.parent_span_id === segment.span_id)).toBe(true);
});

1 change: 0 additions & 1 deletion
dev-packages/e2e-tests/test-applications/deno-pg/src/app.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,6 @@ import '@sentry/deno/import';
import * as Sentry from '@sentry/deno';

Sentry.init({
 traceLifecycle: 'static',
 environment: 'qa',
 dsn: Deno.env.get('E2E_TEST_DSN'),
 debug: !!Deno.env.get('DEBUG'),
Expand Down

75 changes: 42 additions & 33 deletions
dev-packages/e2e-tests/test-applications/deno-pg/tests/pg.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,55 +1,64 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { collectStreamedSpans, getSpanOp } from '@sentry-internal/test-utils';
import type { SerializedStreamedSpan } from '@sentry/core';

// `Deno.serve` has no route information, so with span streaming the http.server segment is
// named after the method only; the path lives in `url.path`.
function isTestPgSegment(span: SerializedStreamedSpan): boolean {
 return getSpanOp(span) === 'http.server' && span.is_segment && span.attributes['url.path']?.value === '/test-pg';
}

test('pg queries emit a db span with orchestrion-channel attributes', async ({ baseURL }) => {
 // Each incoming request gets a Sentry http.server transaction (via the
 // Each incoming request gets a Sentry http.server segment span (via the
 // default denoServeIntegration); the pg queries run inside it, so their
 // db spans attach to that transaction.
 const transactionPromise = waitForTransaction('deno-pg', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/test-pg') &&
 (event.spans?.some(span => span.op === 'db') ?? false)
 );
 });
 // db spans join that trace.
 const spansPromise = collectStreamedSpans(
 'deno-pg',
 spans => spans.some(isTestPgSegment) && spans.some(span => getSpanOp(span) === 'db'),
 );

 const res = await fetch(`${baseURL}/test-pg`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const dbSpans = transaction.spans!.filter(span => span.op === 'db');
 const spans = await spansPromise;
 const dbSpans = spans.filter(span => getSpanOp(span) === 'db');

 const firstQuery = dbSpans.find(span => span.description === 'SELECT 1 + 1 AS solution');
 const firstQuery = dbSpans.find(span => span.attributes['db.query.text']?.value === 'SELECT 1 + 1 AS solution');
 expect(firstQuery).toBeDefined();
 expect(firstQuery!.data?.['sentry.origin']).toBe('auto.db.postgres');
 expect(firstQuery!.data?.['db.system.name']).toBe('postgresql');
 expect(firstQuery!.data?.['db.query.text']).toBe('SELECT 1 + 1 AS solution');
 expect(firstQuery!.data?.['server.port']).toBe(5432);
 expect(firstQuery!.data?.['db.user']).toBe('postgres');
 // With span streaming, db span names are the low-cardinality query summary, not the raw SQL
 expect(firstQuery!.name).toBe('SELECT');
 expect(firstQuery!.attributes).toMatchObject({
 'sentry.origin': { value: 'auto.db.postgres', type: 'string' },
 'db.system.name': { value: 'postgresql', type: 'string' },
 'db.query.text': { value: 'SELECT 1 + 1 AS solution', type: 'string' },
 'server.port': { value: 5432, type: 'integer' },
 'db.user': { value: 'postgres', type: 'string' },
 });
});

test('a nested query lands on the same transaction (AsyncLocalStorage context restored)', async ({ baseURL }) => {
test('a nested query lands on the same trace (AsyncLocalStorage context restored)', async ({ baseURL }) => {
 // The second query runs inside the first query's callback
 // i.e. across pg's async socket-callback dispatch. Both spans appearing
 // on the SAME http.server transaction proves denoPostgresIntegration's
 // i.e. across pg's async socket-callback dispatch. Both db spans being
 // children of the SAME http.server segment proves denoPostgresIntegration's
 // context strategy restored the parent span across that async boundary
 // (otherwise the nested query would start its own trace and never join
 // this transaction).
 const transactionPromise = waitForTransaction('deno-pg', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/test-pg') &&
 (event.spans?.filter(span => span.op === 'db').length ?? 0) >= 2
 );
 });
 // this one).
 const spansPromise = collectStreamedSpans(
 'deno-pg',
 spans => spans.some(isTestPgSegment) && spans.filter(span => getSpanOp(span) === 'db').length >= 2,
 );

 const res = await fetch(`${baseURL}/test-pg`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const descriptions = transaction.spans!.filter(span => span.op === 'db').map(span => span.description);
 expect(descriptions).toContain('SELECT 1 + 1 AS solution');
 expect(descriptions).toContain('SELECT NOW()');
 const spans = await spansPromise;
 const segment = spans.find(isTestPgSegment)!;
 const dbSpans = spans.filter(span => getSpanOp(span) === 'db');

 const queries = dbSpans.map(span => span.attributes['db.query.text']?.value);
 expect(queries).toContain('SELECT 1 + 1 AS solution');
 expect(queries).toContain('SELECT NOW()');
 expect(dbSpans.every(span => span.parent_span_id === segment.span_id)).toBe(true);
});

1 change: 0 additions & 1 deletion
dev-packages/e2e-tests/test-applications/deno-redis/src/app.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@ import IORedis from 'ioredis';
import { createClient } from 'redis';

Sentry.init({
 traceLifecycle: 'static',
 environment: 'qa',
 dsn: Deno.env.get('E2E_TEST_DSN'),
 debug: !!Deno.env.get('DEBUG'),
Expand Down

121 changes: 67 additions & 54 deletions
dev-packages/e2e-tests/test-applications/deno-redis/tests/ioredis.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,94 +1,107 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { collectStreamedSpans, getSpanOp } from '@sentry-internal/test-utils';
import type { SerializedStreamedSpan } from '@sentry/core';

test('ioredis GET emits an http.server transaction containing a db.query child span', async ({ baseURL }) => {
 // Each incoming request gets a Sentry http.server transaction (via the
// `Deno.serve` has no route information, so with span streaming the http.server segment is
// named after the method only; the path lives in `url.path`.
function isSegmentFor(path: string): (span: SerializedStreamedSpan) => boolean {
 return span => getSpanOp(span) === 'http.server' && span.is_segment && span.attributes['url.path']?.value === path;
}

function isRedisCommand(span: SerializedStreamedSpan): boolean {
 return getSpanOp(span) === 'db.query';
}

// `db.query.text` carries the key, so with span streaming a redis command span is named
// `{db.operation.name} {server.address}:{server.port}` instead.
function expectedCommandName(span: SerializedStreamedSpan): string {
 const { 'db.operation.name': operation, 'server.address': address, 'server.port': port } = span.attributes;
 return `${operation?.value} ${address?.value}:${port?.value}`;
}

test('ioredis GET emits an http.server segment containing a db.query child span', async ({ baseURL }) => {
 // Each incoming request gets a Sentry http.server segment span (via the
 // default denoServeIntegration); the ioredis command runs inside it, so the
 // child span attaches to that transaction.
 const transactionPromise = waitForTransaction('deno-redis', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/ioredis-get') &&
 (event.spans?.some(span => span.op === 'db.query') ?? false)
 );
 });
 // child span joins that trace.
 const spansPromise = collectStreamedSpans(
 'deno-redis',
 spans => spans.some(isSegmentFor('/ioredis-get')) && spans.some(isRedisCommand),
 );

 const res = await fetch(`${baseURL}/ioredis-get?key=iocache:user:42`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const redisSpan = transaction.spans!.find(span => span.op === 'db.query');
 const spans = await spansPromise;
 const segment = spans.find(isSegmentFor('/ioredis-get'))!;
 const redisSpan = spans.find(isRedisCommand);
 expect(redisSpan).toBeDefined();
 // ioredis publishes lowercase command names; node-redis publishes uppercase.
 expect(redisSpan!.description).toBe('redis-get');
 expect(redisSpan!.data?.['db.system.name']).toBe('redis');
 expect(redisSpan!.data?.['db.query.text']).toBe('get iocache:user:42');
 expect(redisSpan!.parent_span_id).toBe(segment.span_id);
 expect(redisSpan!.name).toBe(expectedCommandName(redisSpan!));
 expect(redisSpan!.attributes).toMatchObject({
 'db.system.name': { value: 'redis', type: 'string' },
 // ioredis publishes lowercase command names; node-redis publishes uppercase.
 'db.operation.name': { value: 'get', type: 'string' },
 'db.query.text': { value: 'get iocache:user:42', type: 'string' },
 });
});

test('ioredis SET then GET emit two db.query child spans on the same transaction', async ({ baseURL }) => {
 const transactionPromise = waitForTransaction('deno-redis', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/ioredis-set-get') &&
 (event.spans?.filter(span => span.op === 'db.query').length ?? 0) >= 2
 );
 });
test('ioredis SET then GET emit two db.query child spans on the same trace', async ({ baseURL }) => {
 const spansPromise = collectStreamedSpans(
 'deno-redis',
 spans => spans.some(isSegmentFor('/ioredis-set-get')) && spans.filter(isRedisCommand).length >= 2,
 );

 const res = await fetch(`${baseURL}/ioredis-set-get?key=iocache:greeting&value=hello`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const redisSpans = transaction.spans!.filter(span => span.op === 'db.query');
 const spans = await spansPromise;
 const segment = spans.find(isSegmentFor('/ioredis-set-get'))!;
 const redisSpans = spans.filter(isRedisCommand);
 expect(redisSpans.length).toBeGreaterThanOrEqual(2);
 const ops = redisSpans.map(s => s.description);
 expect(ops).toContain('redis-set');
 expect(ops).toContain('redis-get');
 expect(redisSpans.every(span => span.parent_span_id === segment.span_id)).toBe(true);
 const ops = redisSpans.map(span => span.attributes['db.operation.name']?.value);
 expect(ops).toContain('set');
 expect(ops).toContain('get');
});

test('ioredis MULTI emits one db.query span per command (no batch channel)', async ({ baseURL }) => {
 // ioredis does not publish to a batch channel — each command in the
 // transaction publishes individually with batchMode/batchSize set on its
 // own payload. So the transaction should contain multiple `redis-<cmd>`
 // child spans, but no PIPELINE/MULTI batch span.
 const transactionPromise = waitForTransaction('deno-redis', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/ioredis-multi') &&
 (event.spans?.filter(span => span.op === 'db.query').length ?? 0) >= 3
 );
 });
 // own payload. So the trace should contain multiple command child spans,
 // but no PIPELINE/MULTI batch span.
 const spansPromise = collectStreamedSpans(
 'deno-redis',
 spans => spans.some(isSegmentFor('/ioredis-multi')) && spans.filter(isRedisCommand).length >= 3,
 );

 const res = await fetch(`${baseURL}/ioredis-multi`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const redisSpans = transaction.spans!.filter(span => span.op === 'db.query');
 const spans = await spansPromise;
 const redisSpans = spans.filter(isRedisCommand);
 expect(redisSpans.length).toBeGreaterThanOrEqual(3);
 const descriptions = redisSpans.map(s => s.description);
 expect(descriptions).toContain('redis-set');
 expect(descriptions).toContain('redis-get');
 const ops = redisSpans.map(span => span.attributes['db.operation.name']?.value);
 expect(ops).toContain('set');
 expect(ops).toContain('get');
 // No PIPELINE/MULTI batch wrapper span — ioredis has no separate batch channel.
 const batchSpan = transaction.spans!.find(span => span.description === 'MULTI' || span.description === 'PIPELINE');
 const batchSpan = spans.find(span => span.name === 'MULTI' || span.name === 'PIPELINE');
 expect(batchSpan).toBeUndefined();
});

test('ioredis PIPELINE emits one db.query span per command', async ({ baseURL }) => {
 const transactionPromise = waitForTransaction('deno-redis', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/ioredis-pipeline') &&
 (event.spans?.filter(span => span.op === 'db.query').length ?? 0) >= 3
 );
 });
 const spansPromise = collectStreamedSpans(
 'deno-redis',
 spans => spans.some(isSegmentFor('/ioredis-pipeline')) && spans.filter(isRedisCommand).length >= 3,
 );

 const res = await fetch(`${baseURL}/ioredis-pipeline`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const redisSpans = transaction.spans!.filter(span => span.op === 'db.query');
 const spans = await spansPromise;
 const redisSpans = spans.filter(isRedisCommand);
 expect(redisSpans.length).toBeGreaterThanOrEqual(3);
});
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test(e2e): Port Deno db E2E test apps to span streaming#24003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Open

msonnb
wants to merge
1
commit into

base:develop
Choose a base branch

from

 Open


test(e2e): Port Deno db E2E test apps to span streaming
#24003
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
dev-packages/e2e-tests/test-applications/deno-mysql/src/app.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,6 @@ import '@sentry/deno/import';
import * as Sentry from '@sentry/deno';

Sentry.init({
 traceLifecycle: 'static',
 environment: 'qa',
 dsn: Deno.env.get('E2E_TEST_DSN'),
 debug: !!Deno.env.get('DEBUG'),
Expand Down

75 changes: 42 additions & 33 deletions
dev-packages/e2e-tests/test-applications/deno-mysql/tests/mysql.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,54 +1,63 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { collectStreamedSpans, getSpanOp } from '@sentry-internal/test-utils';
import type { SerializedStreamedSpan } from '@sentry/core';

// `Deno.serve` has no route information, so with span streaming the http.server segment is
// named after the method only; the path lives in `url.path`.
function isTestMysqlSegment(span: SerializedStreamedSpan): boolean {
 return getSpanOp(span) === 'http.server' && span.is_segment && span.attributes['url.path']?.value === '/test-mysql';
}

test('mysql queries emit a db span with orchestrion-channel attributes', async ({ baseURL }) => {
 // Each incoming request gets a Sentry http.server transaction (via the
 // Each incoming request gets a Sentry http.server segment span (via the
 // default denoServeIntegration); the mysql queries run inside it, so their
 // db spans attach to that transaction.
 const transactionPromise = waitForTransaction('deno-mysql', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/test-mysql') &&
 (event.spans?.some(span => span.op === 'db') ?? false)
 );
 });
 // db spans join that trace.
 const spansPromise = collectStreamedSpans(
 'deno-mysql',
 spans => spans.some(isTestMysqlSegment) && spans.some(span => getSpanOp(span) === 'db'),
 );

 const res = await fetch(`${baseURL}/test-mysql`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const dbSpans = transaction.spans!.filter(span => span.op === 'db');
 const spans = await spansPromise;
 const dbSpans = spans.filter(span => getSpanOp(span) === 'db');

 const firstQuery = dbSpans.find(span => span.description === 'SELECT 1 + 1 AS solution');
 const firstQuery = dbSpans.find(span => span.attributes['db.query.text']?.value === 'SELECT 1 + 1 AS solution');
 expect(firstQuery).toBeDefined();
 expect(firstQuery!.data?.['sentry.origin']).toBe('auto.db.mysql');
 expect(firstQuery!.data?.['db.system.name']).toBe('mysql');
 expect(firstQuery!.data?.['db.query.text']).toBe('SELECT 1 + 1 AS solution');
 expect(firstQuery!.data?.['server.port']).toBe(3306);
 expect(firstQuery!.data?.['db.user']).toBe('root');
 // With span streaming, db span names are the low-cardinality query summary, not the raw SQL
 expect(firstQuery!.name).toBe('SELECT');
 expect(firstQuery!.attributes).toMatchObject({
 'sentry.origin': { value: 'auto.db.mysql', type: 'string' },
 'db.system.name': { value: 'mysql', type: 'string' },
 'db.query.text': { value: 'SELECT 1 + 1 AS solution', type: 'string' },
 'server.port': { value: 3306, type: 'integer' },
 'db.user': { value: 'root', type: 'string' },
 });
});

test('a nested query lands on the same transaction (AsyncLocalStorage context restored)', async ({ baseURL }) => {
test('a nested query lands on the same trace (AsyncLocalStorage context restored)', async ({ baseURL }) => {
 // The second query runs inside the first query's callback — i.e. across
 // mysql's async socket-callback dispatch. Both spans appearing on the SAME
 // http.server transaction proves denoMysqlIntegration's context strategy
 // mysql's async socket-callback dispatch. Both db spans being children of the
 // SAME http.server segment proves denoMysqlIntegration's context strategy
 // restored the parent span across that async boundary (otherwise the nested
 // query would start its own trace and never join this transaction).
 const transactionPromise = waitForTransaction('deno-mysql', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/test-mysql') &&
 (event.spans?.filter(span => span.op === 'db').length ?? 0) >= 2
 );
 });
 // query would start its own trace and never join this one).
 const spansPromise = collectStreamedSpans(
 'deno-mysql',
 spans => spans.some(isTestMysqlSegment) && spans.filter(span => getSpanOp(span) === 'db').length >= 2,
 );

 const res = await fetch(`${baseURL}/test-mysql`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const descriptions = transaction.spans!.filter(span => span.op === 'db').map(span => span.description);
 expect(descriptions).toContain('SELECT 1 + 1 AS solution');
 expect(descriptions).toContain('SELECT NOW()');
 const spans = await spansPromise;
 const segment = spans.find(isTestMysqlSegment)!;
 const dbSpans = spans.filter(span => getSpanOp(span) === 'db');

 const queries = dbSpans.map(span => span.attributes['db.query.text']?.value);
 expect(queries).toContain('SELECT 1 + 1 AS solution');
 expect(queries).toContain('SELECT NOW()');
 expect(dbSpans.every(span => span.parent_span_id === segment.span_id)).toBe(true);
});

1 change: 0 additions & 1 deletion
dev-packages/e2e-tests/test-applications/deno-pg/src/app.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,6 @@ import '@sentry/deno/import';
import * as Sentry from '@sentry/deno';

Sentry.init({
 traceLifecycle: 'static',
 environment: 'qa',
 dsn: Deno.env.get('E2E_TEST_DSN'),
 debug: !!Deno.env.get('DEBUG'),
Expand Down

75 changes: 42 additions & 33 deletions
dev-packages/e2e-tests/test-applications/deno-pg/tests/pg.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,55 +1,64 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { collectStreamedSpans, getSpanOp } from '@sentry-internal/test-utils';
import type { SerializedStreamedSpan } from '@sentry/core';

// `Deno.serve` has no route information, so with span streaming the http.server segment is
// named after the method only; the path lives in `url.path`.
function isTestPgSegment(span: SerializedStreamedSpan): boolean {
 return getSpanOp(span) === 'http.server' && span.is_segment && span.attributes['url.path']?.value === '/test-pg';
}

test('pg queries emit a db span with orchestrion-channel attributes', async ({ baseURL }) => {
 // Each incoming request gets a Sentry http.server transaction (via the
 // Each incoming request gets a Sentry http.server segment span (via the
 // default denoServeIntegration); the pg queries run inside it, so their
 // db spans attach to that transaction.
 const transactionPromise = waitForTransaction('deno-pg', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/test-pg') &&
 (event.spans?.some(span => span.op === 'db') ?? false)
 );
 });
 // db spans join that trace.
 const spansPromise = collectStreamedSpans(
 'deno-pg',
 spans => spans.some(isTestPgSegment) && spans.some(span => getSpanOp(span) === 'db'),
 );

 const res = await fetch(`${baseURL}/test-pg`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const dbSpans = transaction.spans!.filter(span => span.op === 'db');
 const spans = await spansPromise;
 const dbSpans = spans.filter(span => getSpanOp(span) === 'db');

 const firstQuery = dbSpans.find(span => span.description === 'SELECT 1 + 1 AS solution');
 const firstQuery = dbSpans.find(span => span.attributes['db.query.text']?.value === 'SELECT 1 + 1 AS solution');
 expect(firstQuery).toBeDefined();
 expect(firstQuery!.data?.['sentry.origin']).toBe('auto.db.postgres');
 expect(firstQuery!.data?.['db.system.name']).toBe('postgresql');
 expect(firstQuery!.data?.['db.query.text']).toBe('SELECT 1 + 1 AS solution');
 expect(firstQuery!.data?.['server.port']).toBe(5432);
 expect(firstQuery!.data?.['db.user']).toBe('postgres');
 // With span streaming, db span names are the low-cardinality query summary, not the raw SQL
 expect(firstQuery!.name).toBe('SELECT');
 expect(firstQuery!.attributes).toMatchObject({
 'sentry.origin': { value: 'auto.db.postgres', type: 'string' },
 'db.system.name': { value: 'postgresql', type: 'string' },
 'db.query.text': { value: 'SELECT 1 + 1 AS solution', type: 'string' },
 'server.port': { value: 5432, type: 'integer' },
 'db.user': { value: 'postgres', type: 'string' },
 });
});

test('a nested query lands on the same transaction (AsyncLocalStorage context restored)', async ({ baseURL }) => {
test('a nested query lands on the same trace (AsyncLocalStorage context restored)', async ({ baseURL }) => {
 // The second query runs inside the first query's callback
 // i.e. across pg's async socket-callback dispatch. Both spans appearing
 // on the SAME http.server transaction proves denoPostgresIntegration's
 // i.e. across pg's async socket-callback dispatch. Both db spans being
 // children of the SAME http.server segment proves denoPostgresIntegration's
 // context strategy restored the parent span across that async boundary
 // (otherwise the nested query would start its own trace and never join
 // this transaction).
 const transactionPromise = waitForTransaction('deno-pg', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/test-pg') &&
 (event.spans?.filter(span => span.op === 'db').length ?? 0) >= 2
 );
 });
 // this one).
 const spansPromise = collectStreamedSpans(
 'deno-pg',
 spans => spans.some(isTestPgSegment) && spans.filter(span => getSpanOp(span) === 'db').length >= 2,
 );

 const res = await fetch(`${baseURL}/test-pg`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const descriptions = transaction.spans!.filter(span => span.op === 'db').map(span => span.description);
 expect(descriptions).toContain('SELECT 1 + 1 AS solution');
 expect(descriptions).toContain('SELECT NOW()');
 const spans = await spansPromise;
 const segment = spans.find(isTestPgSegment)!;
 const dbSpans = spans.filter(span => getSpanOp(span) === 'db');

 const queries = dbSpans.map(span => span.attributes['db.query.text']?.value);
 expect(queries).toContain('SELECT 1 + 1 AS solution');
 expect(queries).toContain('SELECT NOW()');
 expect(dbSpans.every(span => span.parent_span_id === segment.span_id)).toBe(true);
});

1 change: 0 additions & 1 deletion
dev-packages/e2e-tests/test-applications/deno-redis/src/app.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@ import IORedis from 'ioredis';
import { createClient } from 'redis';

Sentry.init({
 traceLifecycle: 'static',
 environment: 'qa',
 dsn: Deno.env.get('E2E_TEST_DSN'),
 debug: !!Deno.env.get('DEBUG'),
Expand Down

121 changes: 67 additions & 54 deletions
dev-packages/e2e-tests/test-applications/deno-redis/tests/ioredis.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,94 +1,107 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { collectStreamedSpans, getSpanOp } from '@sentry-internal/test-utils';
import type { SerializedStreamedSpan } from '@sentry/core';

test('ioredis GET emits an http.server transaction containing a db.query child span', async ({ baseURL }) => {
 // Each incoming request gets a Sentry http.server transaction (via the
// `Deno.serve` has no route information, so with span streaming the http.server segment is
// named after the method only; the path lives in `url.path`.
function isSegmentFor(path: string): (span: SerializedStreamedSpan) => boolean {
 return span => getSpanOp(span) === 'http.server' && span.is_segment && span.attributes['url.path']?.value === path;
}

function isRedisCommand(span: SerializedStreamedSpan): boolean {
 return getSpanOp(span) === 'db.query';
}

// `db.query.text` carries the key, so with span streaming a redis command span is named
// `{db.operation.name} {server.address}:{server.port}` instead.
function expectedCommandName(span: SerializedStreamedSpan): string {
 const { 'db.operation.name': operation, 'server.address': address, 'server.port': port } = span.attributes;
 return `${operation?.value} ${address?.value}:${port?.value}`;
}

test('ioredis GET emits an http.server segment containing a db.query child span', async ({ baseURL }) => {
 // Each incoming request gets a Sentry http.server segment span (via the
 // default denoServeIntegration); the ioredis command runs inside it, so the
 // child span attaches to that transaction.
 const transactionPromise = waitForTransaction('deno-redis', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/ioredis-get') &&
 (event.spans?.some(span => span.op === 'db.query') ?? false)
 );
 });
 // child span joins that trace.
 const spansPromise = collectStreamedSpans(
 'deno-redis',
 spans => spans.some(isSegmentFor('/ioredis-get')) && spans.some(isRedisCommand),
 );

 const res = await fetch(`${baseURL}/ioredis-get?key=iocache:user:42`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const redisSpan = transaction.spans!.find(span => span.op === 'db.query');
 const spans = await spansPromise;
 const segment = spans.find(isSegmentFor('/ioredis-get'))!;
 const redisSpan = spans.find(isRedisCommand);
 expect(redisSpan).toBeDefined();
 // ioredis publishes lowercase command names; node-redis publishes uppercase.
 expect(redisSpan!.description).toBe('redis-get');
 expect(redisSpan!.data?.['db.system.name']).toBe('redis');
 expect(redisSpan!.data?.['db.query.text']).toBe('get iocache:user:42');
 expect(redisSpan!.parent_span_id).toBe(segment.span_id);
 expect(redisSpan!.name).toBe(expectedCommandName(redisSpan!));
 expect(redisSpan!.attributes).toMatchObject({
 'db.system.name': { value: 'redis', type: 'string' },
 // ioredis publishes lowercase command names; node-redis publishes uppercase.
 'db.operation.name': { value: 'get', type: 'string' },
 'db.query.text': { value: 'get iocache:user:42', type: 'string' },
 });
});

test('ioredis SET then GET emit two db.query child spans on the same transaction', async ({ baseURL }) => {
 const transactionPromise = waitForTransaction('deno-redis', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/ioredis-set-get') &&
 (event.spans?.filter(span => span.op === 'db.query').length ?? 0) >= 2
 );
 });
test('ioredis SET then GET emit two db.query child spans on the same trace', async ({ baseURL }) => {
 const spansPromise = collectStreamedSpans(
 'deno-redis',
 spans => spans.some(isSegmentFor('/ioredis-set-get')) && spans.filter(isRedisCommand).length >= 2,
 );

 const res = await fetch(`${baseURL}/ioredis-set-get?key=iocache:greeting&value=hello`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const redisSpans = transaction.spans!.filter(span => span.op === 'db.query');
 const spans = await spansPromise;
 const segment = spans.find(isSegmentFor('/ioredis-set-get'))!;
 const redisSpans = spans.filter(isRedisCommand);
 expect(redisSpans.length).toBeGreaterThanOrEqual(2);
 const ops = redisSpans.map(s => s.description);
 expect(ops).toContain('redis-set');
 expect(ops).toContain('redis-get');
 expect(redisSpans.every(span => span.parent_span_id === segment.span_id)).toBe(true);
 const ops = redisSpans.map(span => span.attributes['db.operation.name']?.value);
 expect(ops).toContain('set');
 expect(ops).toContain('get');
});

test('ioredis MULTI emits one db.query span per command (no batch channel)', async ({ baseURL }) => {
 // ioredis does not publish to a batch channel — each command in the
 // transaction publishes individually with batchMode/batchSize set on its
 // own payload. So the transaction should contain multiple `redis-<cmd>`
 // child spans, but no PIPELINE/MULTI batch span.
 const transactionPromise = waitForTransaction('deno-redis', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/ioredis-multi') &&
 (event.spans?.filter(span => span.op === 'db.query').length ?? 0) >= 3
 );
 });
 // own payload. So the trace should contain multiple command child spans,
 // but no PIPELINE/MULTI batch span.
 const spansPromise = collectStreamedSpans(
 'deno-redis',
 spans => spans.some(isSegmentFor('/ioredis-multi')) && spans.filter(isRedisCommand).length >= 3,
 );

 const res = await fetch(`${baseURL}/ioredis-multi`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const redisSpans = transaction.spans!.filter(span => span.op === 'db.query');
 const spans = await spansPromise;
 const redisSpans = spans.filter(isRedisCommand);
 expect(redisSpans.length).toBeGreaterThanOrEqual(3);
 const descriptions = redisSpans.map(s => s.description);
 expect(descriptions).toContain('redis-set');
 expect(descriptions).toContain('redis-get');
 const ops = redisSpans.map(span => span.attributes['db.operation.name']?.value);
 expect(ops).toContain('set');
 expect(ops).toContain('get');
 // No PIPELINE/MULTI batch wrapper span — ioredis has no separate batch channel.
 const batchSpan = transaction.spans!.find(span => span.description === 'MULTI' || span.description === 'PIPELINE');
 const batchSpan = spans.find(span => span.name === 'MULTI' || span.name === 'PIPELINE');
 expect(batchSpan).toBeUndefined();
});

test('ioredis PIPELINE emits one db.query span per command', async ({ baseURL }) => {
 const transactionPromise = waitForTransaction('deno-redis', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/ioredis-pipeline') &&
 (event.spans?.filter(span => span.op === 'db.query').length ?? 0) >= 3
 );
 });
 const spansPromise = collectStreamedSpans(
 'deno-redis',
 spans => spans.some(isSegmentFor('/ioredis-pipeline')) && spans.filter(isRedisCommand).length >= 3,
 );

 const res = await fetch(`${baseURL}/ioredis-pipeline`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const redisSpans = transaction.spans!.filter(span => span.op === 'db.query');
 const spans = await spansPromise;
 const redisSpans = spans.filter(isRedisCommand);
 expect(redisSpans.length).toBeGreaterThanOrEqual(3);
});
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test(e2e): Port Deno db E2E test apps to span streaming#24003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Open

msonnb
wants to merge
1
commit into

base:develop
Choose a base branch

from

 Open


test(e2e): Port Deno db E2E test apps to span streaming
#24003
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
dev-packages/e2e-tests/test-applications/deno-mysql/src/app.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,6 @@ import '@sentry/deno/import';
import * as Sentry from '@sentry/deno';

Sentry.init({
 traceLifecycle: 'static',
 environment: 'qa',
 dsn: Deno.env.get('E2E_TEST_DSN'),
 debug: !!Deno.env.get('DEBUG'),
Expand Down

75 changes: 42 additions & 33 deletions
dev-packages/e2e-tests/test-applications/deno-mysql/tests/mysql.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,54 +1,63 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { collectStreamedSpans, getSpanOp } from '@sentry-internal/test-utils';
import type { SerializedStreamedSpan } from '@sentry/core';

// `Deno.serve` has no route information, so with span streaming the http.server segment is
// named after the method only; the path lives in `url.path`.
function isTestMysqlSegment(span: SerializedStreamedSpan): boolean {
 return getSpanOp(span) === 'http.server' && span.is_segment && span.attributes['url.path']?.value === '/test-mysql';
}

test('mysql queries emit a db span with orchestrion-channel attributes', async ({ baseURL }) => {
 // Each incoming request gets a Sentry http.server transaction (via the
 // Each incoming request gets a Sentry http.server segment span (via the
 // default denoServeIntegration); the mysql queries run inside it, so their
 // db spans attach to that transaction.
 const transactionPromise = waitForTransaction('deno-mysql', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/test-mysql') &&
 (event.spans?.some(span => span.op === 'db') ?? false)
 );
 });
 // db spans join that trace.
 const spansPromise = collectStreamedSpans(
 'deno-mysql',
 spans => spans.some(isTestMysqlSegment) && spans.some(span => getSpanOp(span) === 'db'),
 );

 const res = await fetch(`${baseURL}/test-mysql`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const dbSpans = transaction.spans!.filter(span => span.op === 'db');
 const spans = await spansPromise;
 const dbSpans = spans.filter(span => getSpanOp(span) === 'db');

 const firstQuery = dbSpans.find(span => span.description === 'SELECT 1 + 1 AS solution');
 const firstQuery = dbSpans.find(span => span.attributes['db.query.text']?.value === 'SELECT 1 + 1 AS solution');
 expect(firstQuery).toBeDefined();
 expect(firstQuery!.data?.['sentry.origin']).toBe('auto.db.mysql');
 expect(firstQuery!.data?.['db.system.name']).toBe('mysql');
 expect(firstQuery!.data?.['db.query.text']).toBe('SELECT 1 + 1 AS solution');
 expect(firstQuery!.data?.['server.port']).toBe(3306);
 expect(firstQuery!.data?.['db.user']).toBe('root');
 // With span streaming, db span names are the low-cardinality query summary, not the raw SQL
 expect(firstQuery!.name).toBe('SELECT');
 expect(firstQuery!.attributes).toMatchObject({
 'sentry.origin': { value: 'auto.db.mysql', type: 'string' },
 'db.system.name': { value: 'mysql', type: 'string' },
 'db.query.text': { value: 'SELECT 1 + 1 AS solution', type: 'string' },
 'server.port': { value: 3306, type: 'integer' },
 'db.user': { value: 'root', type: 'string' },
 });
});

test('a nested query lands on the same transaction (AsyncLocalStorage context restored)', async ({ baseURL }) => {
test('a nested query lands on the same trace (AsyncLocalStorage context restored)', async ({ baseURL }) => {
 // The second query runs inside the first query's callback — i.e. across
 // mysql's async socket-callback dispatch. Both spans appearing on the SAME
 // http.server transaction proves denoMysqlIntegration's context strategy
 // mysql's async socket-callback dispatch. Both db spans being children of the
 // SAME http.server segment proves denoMysqlIntegration's context strategy
 // restored the parent span across that async boundary (otherwise the nested
 // query would start its own trace and never join this transaction).
 const transactionPromise = waitForTransaction('deno-mysql', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/test-mysql') &&
 (event.spans?.filter(span => span.op === 'db').length ?? 0) >= 2
 );
 });
 // query would start its own trace and never join this one).
 const spansPromise = collectStreamedSpans(
 'deno-mysql',
 spans => spans.some(isTestMysqlSegment) && spans.filter(span => getSpanOp(span) === 'db').length >= 2,
 );

 const res = await fetch(`${baseURL}/test-mysql`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const descriptions = transaction.spans!.filter(span => span.op === 'db').map(span => span.description);
 expect(descriptions).toContain('SELECT 1 + 1 AS solution');
 expect(descriptions).toContain('SELECT NOW()');
 const spans = await spansPromise;
 const segment = spans.find(isTestMysqlSegment)!;
 const dbSpans = spans.filter(span => getSpanOp(span) === 'db');

 const queries = dbSpans.map(span => span.attributes['db.query.text']?.value);
 expect(queries).toContain('SELECT 1 + 1 AS solution');
 expect(queries).toContain('SELECT NOW()');
 expect(dbSpans.every(span => span.parent_span_id === segment.span_id)).toBe(true);
});

1 change: 0 additions & 1 deletion
dev-packages/e2e-tests/test-applications/deno-pg/src/app.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,6 @@ import '@sentry/deno/import';
import * as Sentry from '@sentry/deno';

Sentry.init({
 traceLifecycle: 'static',
 environment: 'qa',
 dsn: Deno.env.get('E2E_TEST_DSN'),
 debug: !!Deno.env.get('DEBUG'),
Expand Down

75 changes: 42 additions & 33 deletions
dev-packages/e2e-tests/test-applications/deno-pg/tests/pg.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,55 +1,64 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { collectStreamedSpans, getSpanOp } from '@sentry-internal/test-utils';
import type { SerializedStreamedSpan } from '@sentry/core';

// `Deno.serve` has no route information, so with span streaming the http.server segment is
// named after the method only; the path lives in `url.path`.
function isTestPgSegment(span: SerializedStreamedSpan): boolean {
 return getSpanOp(span) === 'http.server' && span.is_segment && span.attributes['url.path']?.value === '/test-pg';
}

test('pg queries emit a db span with orchestrion-channel attributes', async ({ baseURL }) => {
 // Each incoming request gets a Sentry http.server transaction (via the
 // Each incoming request gets a Sentry http.server segment span (via the
 // default denoServeIntegration); the pg queries run inside it, so their
 // db spans attach to that transaction.
 const transactionPromise = waitForTransaction('deno-pg', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/test-pg') &&
 (event.spans?.some(span => span.op === 'db') ?? false)
 );
 });
 // db spans join that trace.
 const spansPromise = collectStreamedSpans(
 'deno-pg',
 spans => spans.some(isTestPgSegment) && spans.some(span => getSpanOp(span) === 'db'),
 );

 const res = await fetch(`${baseURL}/test-pg`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const dbSpans = transaction.spans!.filter(span => span.op === 'db');
 const spans = await spansPromise;
 const dbSpans = spans.filter(span => getSpanOp(span) === 'db');

 const firstQuery = dbSpans.find(span => span.description === 'SELECT 1 + 1 AS solution');
 const firstQuery = dbSpans.find(span => span.attributes['db.query.text']?.value === 'SELECT 1 + 1 AS solution');
 expect(firstQuery).toBeDefined();
 expect(firstQuery!.data?.['sentry.origin']).toBe('auto.db.postgres');
 expect(firstQuery!.data?.['db.system.name']).toBe('postgresql');
 expect(firstQuery!.data?.['db.query.text']).toBe('SELECT 1 + 1 AS solution');
 expect(firstQuery!.data?.['server.port']).toBe(5432);
 expect(firstQuery!.data?.['db.user']).toBe('postgres');
 // With span streaming, db span names are the low-cardinality query summary, not the raw SQL
 expect(firstQuery!.name).toBe('SELECT');
 expect(firstQuery!.attributes).toMatchObject({
 'sentry.origin': { value: 'auto.db.postgres', type: 'string' },
 'db.system.name': { value: 'postgresql', type: 'string' },
 'db.query.text': { value: 'SELECT 1 + 1 AS solution', type: 'string' },
 'server.port': { value: 5432, type: 'integer' },
 'db.user': { value: 'postgres', type: 'string' },
 });
});

test('a nested query lands on the same transaction (AsyncLocalStorage context restored)', async ({ baseURL }) => {
test('a nested query lands on the same trace (AsyncLocalStorage context restored)', async ({ baseURL }) => {
 // The second query runs inside the first query's callback
 // i.e. across pg's async socket-callback dispatch. Both spans appearing
 // on the SAME http.server transaction proves denoPostgresIntegration's
 // i.e. across pg's async socket-callback dispatch. Both db spans being
 // children of the SAME http.server segment proves denoPostgresIntegration's
 // context strategy restored the parent span across that async boundary
 // (otherwise the nested query would start its own trace and never join
 // this transaction).
 const transactionPromise = waitForTransaction('deno-pg', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/test-pg') &&
 (event.spans?.filter(span => span.op === 'db').length ?? 0) >= 2
 );
 });
 // this one).
 const spansPromise = collectStreamedSpans(
 'deno-pg',
 spans => spans.some(isTestPgSegment) && spans.filter(span => getSpanOp(span) === 'db').length >= 2,
 );

 const res = await fetch(`${baseURL}/test-pg`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const descriptions = transaction.spans!.filter(span => span.op === 'db').map(span => span.description);
 expect(descriptions).toContain('SELECT 1 + 1 AS solution');
 expect(descriptions).toContain('SELECT NOW()');
 const spans = await spansPromise;
 const segment = spans.find(isTestPgSegment)!;
 const dbSpans = spans.filter(span => getSpanOp(span) === 'db');

 const queries = dbSpans.map(span => span.attributes['db.query.text']?.value);
 expect(queries).toContain('SELECT 1 + 1 AS solution');
 expect(queries).toContain('SELECT NOW()');
 expect(dbSpans.every(span => span.parent_span_id === segment.span_id)).toBe(true);
});

1 change: 0 additions & 1 deletion
dev-packages/e2e-tests/test-applications/deno-redis/src/app.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@ import IORedis from 'ioredis';
import { createClient } from 'redis';

Sentry.init({
 traceLifecycle: 'static',
 environment: 'qa',
 dsn: Deno.env.get('E2E_TEST_DSN'),
 debug: !!Deno.env.get('DEBUG'),
Expand Down

121 changes: 67 additions & 54 deletions
dev-packages/e2e-tests/test-applications/deno-redis/tests/ioredis.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,94 +1,107 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { collectStreamedSpans, getSpanOp } from '@sentry-internal/test-utils';
import type { SerializedStreamedSpan } from '@sentry/core';

test('ioredis GET emits an http.server transaction containing a db.query child span', async ({ baseURL }) => {
 // Each incoming request gets a Sentry http.server transaction (via the
// `Deno.serve` has no route information, so with span streaming the http.server segment is
// named after the method only; the path lives in `url.path`.
function isSegmentFor(path: string): (span: SerializedStreamedSpan) => boolean {
 return span => getSpanOp(span) === 'http.server' && span.is_segment && span.attributes['url.path']?.value === path;
}

function isRedisCommand(span: SerializedStreamedSpan): boolean {
 return getSpanOp(span) === 'db.query';
}

// `db.query.text` carries the key, so with span streaming a redis command span is named
// `{db.operation.name} {server.address}:{server.port}` instead.
function expectedCommandName(span: SerializedStreamedSpan): string {
 const { 'db.operation.name': operation, 'server.address': address, 'server.port': port } = span.attributes;
 return `${operation?.value} ${address?.value}:${port?.value}`;
}

test('ioredis GET emits an http.server segment containing a db.query child span', async ({ baseURL }) => {
 // Each incoming request gets a Sentry http.server segment span (via the
 // default denoServeIntegration); the ioredis command runs inside it, so the
 // child span attaches to that transaction.
 const transactionPromise = waitForTransaction('deno-redis', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/ioredis-get') &&
 (event.spans?.some(span => span.op === 'db.query') ?? false)
 );
 });
 // child span joins that trace.
 const spansPromise = collectStreamedSpans(
 'deno-redis',
 spans => spans.some(isSegmentFor('/ioredis-get')) && spans.some(isRedisCommand),
 );

 const res = await fetch(`${baseURL}/ioredis-get?key=iocache:user:42`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const redisSpan = transaction.spans!.find(span => span.op === 'db.query');
 const spans = await spansPromise;
 const segment = spans.find(isSegmentFor('/ioredis-get'))!;
 const redisSpan = spans.find(isRedisCommand);
 expect(redisSpan).toBeDefined();
 // ioredis publishes lowercase command names; node-redis publishes uppercase.
 expect(redisSpan!.description).toBe('redis-get');
 expect(redisSpan!.data?.['db.system.name']).toBe('redis');
 expect(redisSpan!.data?.['db.query.text']).toBe('get iocache:user:42');
 expect(redisSpan!.parent_span_id).toBe(segment.span_id);
 expect(redisSpan!.name).toBe(expectedCommandName(redisSpan!));
 expect(redisSpan!.attributes).toMatchObject({
 'db.system.name': { value: 'redis', type: 'string' },
 // ioredis publishes lowercase command names; node-redis publishes uppercase.
 'db.operation.name': { value: 'get', type: 'string' },
 'db.query.text': { value: 'get iocache:user:42', type: 'string' },
 });
});

test('ioredis SET then GET emit two db.query child spans on the same transaction', async ({ baseURL }) => {
 const transactionPromise = waitForTransaction('deno-redis', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/ioredis-set-get') &&
 (event.spans?.filter(span => span.op === 'db.query').length ?? 0) >= 2
 );
 });
test('ioredis SET then GET emit two db.query child spans on the same trace', async ({ baseURL }) => {
 const spansPromise = collectStreamedSpans(
 'deno-redis',
 spans => spans.some(isSegmentFor('/ioredis-set-get')) && spans.filter(isRedisCommand).length >= 2,
 );

 const res = await fetch(`${baseURL}/ioredis-set-get?key=iocache:greeting&value=hello`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const redisSpans = transaction.spans!.filter(span => span.op === 'db.query');
 const spans = await spansPromise;
 const segment = spans.find(isSegmentFor('/ioredis-set-get'))!;
 const redisSpans = spans.filter(isRedisCommand);
 expect(redisSpans.length).toBeGreaterThanOrEqual(2);
 const ops = redisSpans.map(s => s.description);
 expect(ops).toContain('redis-set');
 expect(ops).toContain('redis-get');
 expect(redisSpans.every(span => span.parent_span_id === segment.span_id)).toBe(true);
 const ops = redisSpans.map(span => span.attributes['db.operation.name']?.value);
 expect(ops).toContain('set');
 expect(ops).toContain('get');
});

test('ioredis MULTI emits one db.query span per command (no batch channel)', async ({ baseURL }) => {
 // ioredis does not publish to a batch channel — each command in the
 // transaction publishes individually with batchMode/batchSize set on its
 // own payload. So the transaction should contain multiple `redis-<cmd>`
 // child spans, but no PIPELINE/MULTI batch span.
 const transactionPromise = waitForTransaction('deno-redis', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/ioredis-multi') &&
 (event.spans?.filter(span => span.op === 'db.query').length ?? 0) >= 3
 );
 });
 // own payload. So the trace should contain multiple command child spans,
 // but no PIPELINE/MULTI batch span.
 const spansPromise = collectStreamedSpans(
 'deno-redis',
 spans => spans.some(isSegmentFor('/ioredis-multi')) && spans.filter(isRedisCommand).length >= 3,
 );

 const res = await fetch(`${baseURL}/ioredis-multi`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const redisSpans = transaction.spans!.filter(span => span.op === 'db.query');
 const spans = await spansPromise;
 const redisSpans = spans.filter(isRedisCommand);
 expect(redisSpans.length).toBeGreaterThanOrEqual(3);
 const descriptions = redisSpans.map(s => s.description);
 expect(descriptions).toContain('redis-set');
 expect(descriptions).toContain('redis-get');
 const ops = redisSpans.map(span => span.attributes['db.operation.name']?.value);
 expect(ops).toContain('set');
 expect(ops).toContain('get');
 // No PIPELINE/MULTI batch wrapper span — ioredis has no separate batch channel.
 const batchSpan = transaction.spans!.find(span => span.description === 'MULTI' || span.description === 'PIPELINE');
 const batchSpan = spans.find(span => span.name === 'MULTI' || span.name === 'PIPELINE');
 expect(batchSpan).toBeUndefined();
});

test('ioredis PIPELINE emits one db.query span per command', async ({ baseURL }) => {
 const transactionPromise = waitForTransaction('deno-redis', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/ioredis-pipeline') &&
 (event.spans?.filter(span => span.op === 'db.query').length ?? 0) >= 3
 );
 });
 const spansPromise = collectStreamedSpans(
 'deno-redis',
 spans => spans.some(isSegmentFor('/ioredis-pipeline')) && spans.filter(isRedisCommand).length >= 3,
 );

 const res = await fetch(`${baseURL}/ioredis-pipeline`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const redisSpans = transaction.spans!.filter(span => span.op === 'db.query');
 const spans = await spansPromise;
 const redisSpans = spans.filter(isRedisCommand);
 expect(redisSpans.length).toBeGreaterThanOrEqual(3);
});
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
test(e2e): Port Deno db E2E test apps to span streaming#24003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Open

msonnb
wants to merge
1
commit into

base:develop
Choose a base branch

from

 Open


test(e2e): Port Deno db E2E test apps to span streaming
#24003
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
dev-packages/e2e-tests/test-applications/deno-mysql/src/app.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,6 @@ import '@sentry/deno/import';
import * as Sentry from '@sentry/deno';

Sentry.init({
 traceLifecycle: 'static',
 environment: 'qa',
 dsn: Deno.env.get('E2E_TEST_DSN'),
 debug: !!Deno.env.get('DEBUG'),
Expand Down

75 changes: 42 additions & 33 deletions
dev-packages/e2e-tests/test-applications/deno-mysql/tests/mysql.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,54 +1,63 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { collectStreamedSpans, getSpanOp } from '@sentry-internal/test-utils';
import type { SerializedStreamedSpan } from '@sentry/core';

// `Deno.serve` has no route information, so with span streaming the http.server segment is
// named after the method only; the path lives in `url.path`.
function isTestMysqlSegment(span: SerializedStreamedSpan): boolean {
 return getSpanOp(span) === 'http.server' && span.is_segment && span.attributes['url.path']?.value === '/test-mysql';
}

test('mysql queries emit a db span with orchestrion-channel attributes', async ({ baseURL }) => {
 // Each incoming request gets a Sentry http.server transaction (via the
 // Each incoming request gets a Sentry http.server segment span (via the
 // default denoServeIntegration); the mysql queries run inside it, so their
 // db spans attach to that transaction.
 const transactionPromise = waitForTransaction('deno-mysql', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/test-mysql') &&
 (event.spans?.some(span => span.op === 'db') ?? false)
 );
 });
 // db spans join that trace.
 const spansPromise = collectStreamedSpans(
 'deno-mysql',
 spans => spans.some(isTestMysqlSegment) && spans.some(span => getSpanOp(span) === 'db'),
 );

 const res = await fetch(`${baseURL}/test-mysql`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const dbSpans = transaction.spans!.filter(span => span.op === 'db');
 const spans = await spansPromise;
 const dbSpans = spans.filter(span => getSpanOp(span) === 'db');

 const firstQuery = dbSpans.find(span => span.description === 'SELECT 1 + 1 AS solution');
 const firstQuery = dbSpans.find(span => span.attributes['db.query.text']?.value === 'SELECT 1 + 1 AS solution');
 expect(firstQuery).toBeDefined();
 expect(firstQuery!.data?.['sentry.origin']).toBe('auto.db.mysql');
 expect(firstQuery!.data?.['db.system.name']).toBe('mysql');
 expect(firstQuery!.data?.['db.query.text']).toBe('SELECT 1 + 1 AS solution');
 expect(firstQuery!.data?.['server.port']).toBe(3306);
 expect(firstQuery!.data?.['db.user']).toBe('root');
 // With span streaming, db span names are the low-cardinality query summary, not the raw SQL
 expect(firstQuery!.name).toBe('SELECT');
 expect(firstQuery!.attributes).toMatchObject({
 'sentry.origin': { value: 'auto.db.mysql', type: 'string' },
 'db.system.name': { value: 'mysql', type: 'string' },
 'db.query.text': { value: 'SELECT 1 + 1 AS solution', type: 'string' },
 'server.port': { value: 3306, type: 'integer' },
 'db.user': { value: 'root', type: 'string' },
 });
});

test('a nested query lands on the same transaction (AsyncLocalStorage context restored)', async ({ baseURL }) => {
test('a nested query lands on the same trace (AsyncLocalStorage context restored)', async ({ baseURL }) => {
 // The second query runs inside the first query's callback — i.e. across
 // mysql's async socket-callback dispatch. Both spans appearing on the SAME
 // http.server transaction proves denoMysqlIntegration's context strategy
 // mysql's async socket-callback dispatch. Both db spans being children of the
 // SAME http.server segment proves denoMysqlIntegration's context strategy
 // restored the parent span across that async boundary (otherwise the nested
 // query would start its own trace and never join this transaction).
 const transactionPromise = waitForTransaction('deno-mysql', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/test-mysql') &&
 (event.spans?.filter(span => span.op === 'db').length ?? 0) >= 2
 );
 });
 // query would start its own trace and never join this one).
 const spansPromise = collectStreamedSpans(
 'deno-mysql',
 spans => spans.some(isTestMysqlSegment) && spans.filter(span => getSpanOp(span) === 'db').length >= 2,
 );

 const res = await fetch(`${baseURL}/test-mysql`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const descriptions = transaction.spans!.filter(span => span.op === 'db').map(span => span.description);
 expect(descriptions).toContain('SELECT 1 + 1 AS solution');
 expect(descriptions).toContain('SELECT NOW()');
 const spans = await spansPromise;
 const segment = spans.find(isTestMysqlSegment)!;
 const dbSpans = spans.filter(span => getSpanOp(span) === 'db');

 const queries = dbSpans.map(span => span.attributes['db.query.text']?.value);
 expect(queries).toContain('SELECT 1 + 1 AS solution');
 expect(queries).toContain('SELECT NOW()');
 expect(dbSpans.every(span => span.parent_span_id === segment.span_id)).toBe(true);
});

1 change: 0 additions & 1 deletion
dev-packages/e2e-tests/test-applications/deno-pg/src/app.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,6 @@ import '@sentry/deno/import';
import * as Sentry from '@sentry/deno';

Sentry.init({
 traceLifecycle: 'static',
 environment: 'qa',
 dsn: Deno.env.get('E2E_TEST_DSN'),
 debug: !!Deno.env.get('DEBUG'),
Expand Down

75 changes: 42 additions & 33 deletions
dev-packages/e2e-tests/test-applications/deno-pg/tests/pg.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,55 +1,64 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { collectStreamedSpans, getSpanOp } from '@sentry-internal/test-utils';
import type { SerializedStreamedSpan } from '@sentry/core';

// `Deno.serve` has no route information, so with span streaming the http.server segment is
// named after the method only; the path lives in `url.path`.
function isTestPgSegment(span: SerializedStreamedSpan): boolean {
 return getSpanOp(span) === 'http.server' && span.is_segment && span.attributes['url.path']?.value === '/test-pg';
}

test('pg queries emit a db span with orchestrion-channel attributes', async ({ baseURL }) => {
 // Each incoming request gets a Sentry http.server transaction (via the
 // Each incoming request gets a Sentry http.server segment span (via the
 // default denoServeIntegration); the pg queries run inside it, so their
 // db spans attach to that transaction.
 const transactionPromise = waitForTransaction('deno-pg', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/test-pg') &&
 (event.spans?.some(span => span.op === 'db') ?? false)
 );
 });
 // db spans join that trace.
 const spansPromise = collectStreamedSpans(
 'deno-pg',
 spans => spans.some(isTestPgSegment) && spans.some(span => getSpanOp(span) === 'db'),
 );

 const res = await fetch(`${baseURL}/test-pg`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const dbSpans = transaction.spans!.filter(span => span.op === 'db');
 const spans = await spansPromise;
 const dbSpans = spans.filter(span => getSpanOp(span) === 'db');

 const firstQuery = dbSpans.find(span => span.description === 'SELECT 1 + 1 AS solution');
 const firstQuery = dbSpans.find(span => span.attributes['db.query.text']?.value === 'SELECT 1 + 1 AS solution');
 expect(firstQuery).toBeDefined();
 expect(firstQuery!.data?.['sentry.origin']).toBe('auto.db.postgres');
 expect(firstQuery!.data?.['db.system.name']).toBe('postgresql');
 expect(firstQuery!.data?.['db.query.text']).toBe('SELECT 1 + 1 AS solution');
 expect(firstQuery!.data?.['server.port']).toBe(5432);
 expect(firstQuery!.data?.['db.user']).toBe('postgres');
 // With span streaming, db span names are the low-cardinality query summary, not the raw SQL
 expect(firstQuery!.name).toBe('SELECT');
 expect(firstQuery!.attributes).toMatchObject({
 'sentry.origin': { value: 'auto.db.postgres', type: 'string' },
 'db.system.name': { value: 'postgresql', type: 'string' },
 'db.query.text': { value: 'SELECT 1 + 1 AS solution', type: 'string' },
 'server.port': { value: 5432, type: 'integer' },
 'db.user': { value: 'postgres', type: 'string' },
 });
});

test('a nested query lands on the same transaction (AsyncLocalStorage context restored)', async ({ baseURL }) => {
test('a nested query lands on the same trace (AsyncLocalStorage context restored)', async ({ baseURL }) => {
 // The second query runs inside the first query's callback
 // i.e. across pg's async socket-callback dispatch. Both spans appearing
 // on the SAME http.server transaction proves denoPostgresIntegration's
 // i.e. across pg's async socket-callback dispatch. Both db spans being
 // children of the SAME http.server segment proves denoPostgresIntegration's
 // context strategy restored the parent span across that async boundary
 // (otherwise the nested query would start its own trace and never join
 // this transaction).
 const transactionPromise = waitForTransaction('deno-pg', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/test-pg') &&
 (event.spans?.filter(span => span.op === 'db').length ?? 0) >= 2
 );
 });
 // this one).
 const spansPromise = collectStreamedSpans(
 'deno-pg',
 spans => spans.some(isTestPgSegment) && spans.filter(span => getSpanOp(span) === 'db').length >= 2,
 );

 const res = await fetch(`${baseURL}/test-pg`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const descriptions = transaction.spans!.filter(span => span.op === 'db').map(span => span.description);
 expect(descriptions).toContain('SELECT 1 + 1 AS solution');
 expect(descriptions).toContain('SELECT NOW()');
 const spans = await spansPromise;
 const segment = spans.find(isTestPgSegment)!;
 const dbSpans = spans.filter(span => getSpanOp(span) === 'db');

 const queries = dbSpans.map(span => span.attributes['db.query.text']?.value);
 expect(queries).toContain('SELECT 1 + 1 AS solution');
 expect(queries).toContain('SELECT NOW()');
 expect(dbSpans.every(span => span.parent_span_id === segment.span_id)).toBe(true);
});

1 change: 0 additions & 1 deletion
dev-packages/e2e-tests/test-applications/deno-redis/src/app.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@ import IORedis from 'ioredis';
import { createClient } from 'redis';

Sentry.init({
 traceLifecycle: 'static',
 environment: 'qa',
 dsn: Deno.env.get('E2E_TEST_DSN'),
 debug: !!Deno.env.get('DEBUG'),
Expand Down

121 changes: 67 additions & 54 deletions
dev-packages/e2e-tests/test-applications/deno-redis/tests/ioredis.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,94 +1,107 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { collectStreamedSpans, getSpanOp } from '@sentry-internal/test-utils';
import type { SerializedStreamedSpan } from '@sentry/core';

test('ioredis GET emits an http.server transaction containing a db.query child span', async ({ baseURL }) => {
 // Each incoming request gets a Sentry http.server transaction (via the
// `Deno.serve` has no route information, so with span streaming the http.server segment is
// named after the method only; the path lives in `url.path`.
function isSegmentFor(path: string): (span: SerializedStreamedSpan) => boolean {
 return span => getSpanOp(span) === 'http.server' && span.is_segment && span.attributes['url.path']?.value === path;
}

function isRedisCommand(span: SerializedStreamedSpan): boolean {
 return getSpanOp(span) === 'db.query';
}

// `db.query.text` carries the key, so with span streaming a redis command span is named
// `{db.operation.name} {server.address}:{server.port}` instead.
function expectedCommandName(span: SerializedStreamedSpan): string {
 const { 'db.operation.name': operation, 'server.address': address, 'server.port': port } = span.attributes;
 return `${operation?.value} ${address?.value}:${port?.value}`;
}

test('ioredis GET emits an http.server segment containing a db.query child span', async ({ baseURL }) => {
 // Each incoming request gets a Sentry http.server segment span (via the
 // default denoServeIntegration); the ioredis command runs inside it, so the
 // child span attaches to that transaction.
 const transactionPromise = waitForTransaction('deno-redis', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/ioredis-get') &&
 (event.spans?.some(span => span.op === 'db.query') ?? false)
 );
 });
 // child span joins that trace.
 const spansPromise = collectStreamedSpans(
 'deno-redis',
 spans => spans.some(isSegmentFor('/ioredis-get')) && spans.some(isRedisCommand),
 );

 const res = await fetch(`${baseURL}/ioredis-get?key=iocache:user:42`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const redisSpan = transaction.spans!.find(span => span.op === 'db.query');
 const spans = await spansPromise;
 const segment = spans.find(isSegmentFor('/ioredis-get'))!;
 const redisSpan = spans.find(isRedisCommand);
 expect(redisSpan).toBeDefined();
 // ioredis publishes lowercase command names; node-redis publishes uppercase.
 expect(redisSpan!.description).toBe('redis-get');
 expect(redisSpan!.data?.['db.system.name']).toBe('redis');
 expect(redisSpan!.data?.['db.query.text']).toBe('get iocache:user:42');
 expect(redisSpan!.parent_span_id).toBe(segment.span_id);
 expect(redisSpan!.name).toBe(expectedCommandName(redisSpan!));
 expect(redisSpan!.attributes).toMatchObject({
 'db.system.name': { value: 'redis', type: 'string' },
 // ioredis publishes lowercase command names; node-redis publishes uppercase.
 'db.operation.name': { value: 'get', type: 'string' },
 'db.query.text': { value: 'get iocache:user:42', type: 'string' },
 });
});

test('ioredis SET then GET emit two db.query child spans on the same transaction', async ({ baseURL }) => {
 const transactionPromise = waitForTransaction('deno-redis', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/ioredis-set-get') &&
 (event.spans?.filter(span => span.op === 'db.query').length ?? 0) >= 2
 );
 });
test('ioredis SET then GET emit two db.query child spans on the same trace', async ({ baseURL }) => {
 const spansPromise = collectStreamedSpans(
 'deno-redis',
 spans => spans.some(isSegmentFor('/ioredis-set-get')) && spans.filter(isRedisCommand).length >= 2,
 );

 const res = await fetch(`${baseURL}/ioredis-set-get?key=iocache:greeting&value=hello`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const redisSpans = transaction.spans!.filter(span => span.op === 'db.query');
 const spans = await spansPromise;
 const segment = spans.find(isSegmentFor('/ioredis-set-get'))!;
 const redisSpans = spans.filter(isRedisCommand);
 expect(redisSpans.length).toBeGreaterThanOrEqual(2);
 const ops = redisSpans.map(s => s.description);
 expect(ops).toContain('redis-set');
 expect(ops).toContain('redis-get');
 expect(redisSpans.every(span => span.parent_span_id === segment.span_id)).toBe(true);
 const ops = redisSpans.map(span => span.attributes['db.operation.name']?.value);
 expect(ops).toContain('set');
 expect(ops).toContain('get');
});

test('ioredis MULTI emits one db.query span per command (no batch channel)', async ({ baseURL }) => {
 // ioredis does not publish to a batch channel — each command in the
 // transaction publishes individually with batchMode/batchSize set on its
 // own payload. So the transaction should contain multiple `redis-<cmd>`
 // child spans, but no PIPELINE/MULTI batch span.
 const transactionPromise = waitForTransaction('deno-redis', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/ioredis-multi') &&
 (event.spans?.filter(span => span.op === 'db.query').length ?? 0) >= 3
 );
 });
 // own payload. So the trace should contain multiple command child spans,
 // but no PIPELINE/MULTI batch span.
 const spansPromise = collectStreamedSpans(
 'deno-redis',
 spans => spans.some(isSegmentFor('/ioredis-multi')) && spans.filter(isRedisCommand).length >= 3,
 );

 const res = await fetch(`${baseURL}/ioredis-multi`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const redisSpans = transaction.spans!.filter(span => span.op === 'db.query');
 const spans = await spansPromise;
 const redisSpans = spans.filter(isRedisCommand);
 expect(redisSpans.length).toBeGreaterThanOrEqual(3);
 const descriptions = redisSpans.map(s => s.description);
 expect(descriptions).toContain('redis-set');
 expect(descriptions).toContain('redis-get');
 const ops = redisSpans.map(span => span.attributes['db.operation.name']?.value);
 expect(ops).toContain('set');
 expect(ops).toContain('get');
 // No PIPELINE/MULTI batch wrapper span — ioredis has no separate batch channel.
 const batchSpan = transaction.spans!.find(span => span.description === 'MULTI' || span.description === 'PIPELINE');
 const batchSpan = spans.find(span => span.name === 'MULTI' || span.name === 'PIPELINE');
 expect(batchSpan).toBeUndefined();
});

test('ioredis PIPELINE emits one db.query span per command', async ({ baseURL }) => {
 const transactionPromise = waitForTransaction('deno-redis', event => {
 return (
 event?.contexts?.trace?.op === 'http.server' &&
 (event.request?.url ?? '').includes('/ioredis-pipeline') &&
 (event.spans?.filter(span => span.op === 'db.query').length ?? 0) >= 3
 );
 });
 const spansPromise = collectStreamedSpans(
 'deno-redis',
 spans => spans.some(isSegmentFor('/ioredis-pipeline')) && spans.filter(isRedisCommand).length >= 3,
 );

 const res = await fetch(`${baseURL}/ioredis-pipeline`);
 expect(res.status).toBe(200);
 await res.json();

 const transaction = await transactionPromise;
 const redisSpans = transaction.spans!.filter(span => span.op === 'db.query');
 const spans = await spansPromise;
 const redisSpans = spans.filter(isRedisCommand);
 expect(redisSpans.length).toBeGreaterThanOrEqual(3);
});
Loading
Loading