Skip to content

fix(integrations): Add tests for CustomEvent handling fix - #2431

Merged
kamilogorek merged 3 commits into
masterfrom
kmclb-fake-promise-rejection-handling-tests
Feb 19, 2020
Merged

fix(integrations): Add tests for CustomEvent handling fix#2431
kamilogorek merged 3 commits into
masterfrom
kmclb-fake-promise-rejection-handling-tests

Conversation

@lobsterkatie

Copy link
Copy Markdown
Member

Adds tests to #2429.

@getsentry-bot

getsentry-bot commented Feb 14, 2020

Copy link
Copy Markdown
Contributor
Warnings
⚠️Please add a changelog entry for your changes.
Messages
📖✅ TSLint passed
📖

@sentry/browser bundle gzip'ed minified size: (ES6: 15.7412 kB) (ES5: 16.7314 kB)

Generated by 🚫 dangerJS against 4e7ab65

@lobsterkatielobsterkatie changed the title fix(integrations): Add tests for CustomEvent handling fixWIP: fix(integrations): Add tests for CustomEvent handling fixFeb 14, 2020
@lobsterkatielobsterkatie changed the title WIP: fix(integrations): Add tests for CustomEvent handling fixfix(integrations): Add tests for CustomEvent handling fixFeb 14, 2020
summary.events[0].exception.values[0].mechanism.type,
"onunhandledrejection"
);
// even though it's a regular Event (rather than a PRE) it should sill only

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// even though it's a regular Event (rather than a PRE) it should sill only
// even though it's a regular Event (rather than a PRE) it should still only

Comment threadpackages/browser/test/integration/suites/onunhandledrejection.js Outdated
Co-Authored-By: Kamil Ogórek <kamil.ogorek@gmail.com>
@kamilogorek
kamilogorek self-requested a review February 17, 2020 09:32
@kamilogorek
kamilogorek merged commit 644b36c into masterFeb 19, 2020
@kamilogorek
kamilogorek deleted the kmclb-fake-promise-rejection-handling-tests branch February 19, 2020 13:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@lobsterkatie@getsentry-bot@kamilogorek