Skip to content

fix: A bunch of typos - #2849

Merged
rhcarvalho merged 3 commits into
masterfrom
rhcarvalho/from-2820
Aug 26, 2020
Merged

fix: A bunch of typos#2849
rhcarvalho merged 3 commits into
masterfrom
rhcarvalho/from-2820

Conversation

@rhcarvalho

@rhcarvalhorhcarvalho commented Aug 26, 2020

Copy link
Copy Markdown
Contributor

Some of the changes are extracted from #2820 (changes that are unrelated to the main work in the PR -- thanks @lobsterkatie), while some are new fixes, like behaviour -> behavior (we use US spelling).

@github-actions

github-actionsBot commented Aug 26, 2020

Copy link
Copy Markdown
Contributor

size-limit report

PathSize
@sentry/browser - CDN Bundle (gzipped)17.68 KB (+0.01% 🔺)
@sentry/browser - Webpack18.46 KB (0%)
@sentry/react - Webpack18.46 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped)22.77 KB (+0.01% 🔺)

@lobsterkatielobsterkatie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny suggestion, but otherwise LGTM! Thanks for pulling this stuff out of my PR!

Comment threadpackages/tracing/src/transaction.ts Outdated
Co-authored-by: Katie Byers <katie.byers@sentry.io>
@rhcarvalho
rhcarvalho merged commit 4f75e8f into masterAug 26, 2020
@rhcarvalho
rhcarvalho deleted the rhcarvalho/from-2820 branch August 26, 2020 15:52
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@rhcarvalho@lobsterkatie